| *** alga has quit IRC | 00:53 | |
| *** th1a has joined #schooltool | 01:45 | |
| *** ignas has quit IRC | 02:29 | |
| *** th1a has quit IRC | 03:12 | |
| *** aks has joined #schooltool | 04:31 | |
| *** aks has joined #schooltool | 04:31 | |
| *** olegb has quit IRC | 08:58 | |
| *** olegb has joined #schooltool | 09:14 | |
| *** aks has quit IRC | 09:24 | |
| *** aks has joined #schooltool | 09:30 | |
| *** aks has quit IRC | 09:41 | |
| *** aks has joined #schooltool | 09:41 | |
| *** menesis has joined #schooltool | 10:35 | |
| *** ignas has joined #schooltool | 11:49 | |
| *** ignas has quit IRC | 11:59 | |
| *** menesis has quit IRC | 12:04 | |
| *** menesis has joined #schooltool | 13:15 | |
| *** alga has joined #schooltool | 13:59 | |
| *** th1a has joined #schooltool | 15:07 | |
| *** aks has quit IRC | 15:49 | |
| *** ignas has joined #schooltool | 16:25 | |
| aelkner | yv;, ayt? | 16:29 |
|---|---|---|
| yvl | hey aelkner | 16:36 |
| *** replaceafill has joined #schooltool | 16:40 | |
| th1a | replaceafill: Can you add this into your journal tasks (which you should be starting soon iirc) https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/961854 | 16:59 |
| th1a | Basically just make it work like the gradebook xls export | 16:59 |
| th1a | And figure on doing the same for CanDo. | 17:00 |
| replaceafill | ah ok | 17:00 |
| replaceafill | yes, i'm starting on it today | 17:00 |
| replaceafill | will do | 17:00 |
| th1a | Can you make that a separate patch that could be applied earlier than the rest? | 17:01 |
| replaceafill | hhmm i can apply it to the current trunk instead of doing it in my branch | 17:01 |
| th1a | Yeah. | 17:01 |
| replaceafill | kk, want me to work on it today? | 17:02 |
| replaceafill | i was going to apply my gradebook ajax changes to the journal today | 17:02 |
| replaceafill | but i can do this before | 17:02 |
| th1a | It isn't something where one day is going to make a difference either way. | 17:03 |
| replaceafill | ah ok | 17:03 |
| th1a | OTOH, if you can throw my svg background on one of your demo instances or a branch or something today, that'll give me an idea of what I should do next with that. | 17:03 |
| replaceafill | i did! | 17:04 |
| replaceafill | didnt you read my email? :/ | 17:04 |
| * replaceafill thinks th1a has him on the spam list... | 17:04 | |
| replaceafill | th1a, http://69.164.203.135:6660 | 17:05 |
| th1a | Hm... | 17:06 |
| th1a | Thanks replaceafill. | 17:10 |
| * th1a goes to the dentist. | 17:10 | |
| *** th1a has quit IRC | 18:14 | |
| *** paulproteus has quit IRC | 18:47 | |
| *** paulproteus has joined #schooltool | 18:48 | |
| *** th1a has joined #schooltool | 19:19 | |
| *** menesis has quit IRC | 19:34 | |
| *** replaceafill has quit IRC | 19:53 | |
| *** replaceafill has joined #schooltool | 19:53 | |
| th1a | replaceafill: What's a reasonable size for a background image? | 20:08 |
| th1a | The svg right now is 109 KB. I can probably cut it down just by rounding off the coordinates and not drawing some of the invisible hexes. | 20:10 |
| replaceafill | th1a, well, it depends | 20:11 |
| th1a | Of course. | 20:11 |
| replaceafill | youtube background images are around 100-200kb | 20:11 |
| replaceafill | iirc | 20:11 |
| replaceafill | same in twitter apparently | 20:12 |
| th1a | It is a question of cutting down the svg I have or writing javascript, which obviously has other costs. | 20:12 |
| replaceafill | the ones you set for your background | 20:12 |
| replaceafill | but in the hexes case, i think it can be really small | 20:12 |
| replaceafill | since it's just a part of the screen | 20:12 |
| replaceafill | you dont want to export it? | 20:12 |
| th1a | Export? | 20:12 |
| replaceafill | to png | 20:13 |
| th1a | Uh... | 20:13 |
| replaceafill | yay! finally i was able to reproduce Carlos bug :) | 20:17 |
| replaceafill | now, to investigate why is happening.. | 20:18 |
| replaceafill | yep | 20:20 |
| replaceafill | just what i thought | 20:20 |
| replaceafill | th1a, have a minute? | 20:20 |
| replaceafill | https://bugs.launchpad.net/schooltool/+bug/944471 | 20:20 |
| replaceafill | http://imageshack.us/f/9/democarlosshare.png/ | 20:22 |
| th1a | kk | 20:23 |
| replaceafill | when the importer gets the demo fields for the person | 20:23 |
| replaceafill | it tries to detect the limited ones | 20:23 |
| replaceafill | if it's a new person | 20:23 |
| replaceafill | that person is not in any group | 20:24 |
| replaceafill | so all the limited fields are not imported | 20:24 |
| * replaceafill tries to *update* a existing person | 20:24 | |
| replaceafill | yep, updating people works if they're in the appropriate groups | 20:26 |
| th1a | OK, down to 71 kb. | 20:26 |
| replaceafill | sounds good to me | 20:26 |
| th1a | Oh, so this is a hack to check if the person in already in a group that does too much? | 20:27 |
| replaceafill | not really a hack, it's the way the adapter works | 20:27 |
| replaceafill | ibasicperson -> idemographicsfields | 20:28 |
| replaceafill | it's a feature :) | 20:28 |
| replaceafill | what carlos would have to do is to set all the people in their groups first | 20:28 |
| replaceafill | then import their demo data | 20:28 |
| replaceafill | if he creates/imports demo at the same time, that doesnt work | 20:29 |
| th1a | How is this ever a feature? | 20:29 |
| replaceafill | :D | 20:29 |
| replaceafill | i think it's a feature of the adapter that the import maybe shouldn't be using | 20:30 |
| th1a | I don't understand why it is ever useful. | 20:30 |
| replaceafill | to show you only relevant data for you | 20:31 |
| replaceafill | according to you status in the system | 20:31 |
| replaceafill | you dont want to see teacher_id for a student | 20:31 |
| replaceafill | so the adapter does that | 20:31 |
| replaceafill | i mean, in an edit form for example | 20:31 |
| th1a | Oh, LIMITED ones. | 20:31 |
| replaceafill | yes | 20:32 |
| replaceafill | sorry, i should have started by using the right terms :) | 20:32 |
| th1a | I wasn't following that term. | 20:32 |
| th1a | np | 20:32 |
| th1a | So limited fields aren't really checked in the view step? | 20:34 |
| th1a | It is more on the editing end? | 20:34 |
| replaceafill | no, they're used everywhere | 20:34 |
| replaceafill | everytime you get demo fields for a person, there's a check | 20:35 |
| replaceafill | to get only what's necessary for that person | 20:35 |
| replaceafill | but the importer is doing the same | 20:35 |
| replaceafill | creates the person, then checks | 20:35 |
| th1a | OK, so can we just take it out of the importer somehow? | 20:35 |
| replaceafill | since the person is new, not in any group | 20:35 |
| th1a | Or maybe add a step to the importer? | 20:35 |
| th1a | Add the people, do the groups, go back to the demographics? | 20:36 |
| replaceafill | hhhmm | 20:36 |
| replaceafill | sound complicated, since importing is done by sheet | 20:36 |
| replaceafill | but i'll look | 20:36 |
| replaceafill | at least i was able to reproduce the bug :) | 20:36 |
| th1a | Well, aelkner is starting a big importer review... today. | 20:37 |
| replaceafill | oh | 20:37 |
| replaceafill | maybe we should pass this to him? | 20:37 |
| replaceafill | i'd like that :) | 20:37 |
| th1a | If we have a workaround, definitely yes. | 20:40 |
| th1a | OK, down to 36K. :-D | 20:47 |
| th1a | This is PoV style optimization. | 20:48 |
| replaceafill | :D | 20:48 |
| replaceafill | i think the *actual* bug, is that the xls importer doesn't put a person in their appropriate group if he's set as instructor or student in a section | 20:54 |
| replaceafill | that's really the cause why carlos doesn't see the limited fields after importer | 20:54 |
| replaceafill | importing* | 20:55 |
| th1a | Well aelkner's task basically is to merge the CanDo importer functionality into ours. | 20:55 |
| th1a | So we're going to have student and teacher import forms I think. | 20:55 |
| th1a | Different worksheets. | 20:56 |
| replaceafill | yes | 20:56 |
| replaceafill | the cando importer does that iirc | 20:56 |
| replaceafill | ok, i'll suggest carlos to place the students and teachers into groups manually | 20:57 |
| replaceafill | if he's not doing it in the xls | 20:57 |
| th1a | Or you could suggest he do it in the XLS. | 20:57 |
| replaceafill | yes | 20:57 |
| th1a | Which still might be easier if he knows to do it. | 20:57 |
| replaceafill | that's better :) | 20:57 |
| th1a | But it won't check the group membership before doing demographics? | 20:58 |
| th1a | Maybe he can run the importer twice? | 20:58 |
| replaceafill | according to the order of processing of the importer, persons is processed before groups | 20:59 |
| replaceafill | since you need the persons first :) | 20:59 |
| replaceafill | if he runs it twice with groups data, it'll work | 20:59 |
| th1a | 23K now... | 21:06 |
| replaceafill | still in svg? | 21:06 |
| th1a | Yes. | 21:06 |
| replaceafill | kk | 21:06 |
| th1a | I was drawing way more hexes than I needed. | 21:06 |
| th1a | This will be cached most of the time anyhow, right? | 21:08 |
| replaceafill | yes, file resources have some caching headers set | 21:08 |
| replaceafill | header: Cache-Control: public,max-age=86400 | 21:09 |
| replaceafill | and expires header for 1 day later | 21:09 |
| th1a | OK, this is small enough for now. | 21:16 |
| th1a | replaceafill: You'd better handle the workaround instructions. | 21:17 |
| replaceafill | cool, i'm still waiting for confirmation on his part about setting groups | 21:18 |
| replaceafill | i just asked him about it | 21:18 |
| replaceafill | if he's doing it i'll set up a full xls for testing | 21:19 |
| replaceafill | with schoolyears, etc | 21:19 |
| replaceafill | maybe just importing Persons is not enough to trace the bug | 21:19 |
| th1a | When you get a chance you can update form here: http://69.164.203.135/d3/hex/hexes.svg | 21:20 |
| replaceafill | let me do it before going for lunch... | 21:20 |
| replaceafill | th1a, done | 21:21 |
| replaceafill | reload to get the small version | 21:21 |
| th1a | aelkner: ayt? | 21:25 |
| * replaceafill goes to get lunch | 21:25 | |
| aelkner | th1a, hey | 21:48 |
| * replaceafill back | 22:32 | |
| *** menesis has joined #schooltool | 22:52 | |
| *** th1a has quit IRC | 22:52 | |
| *** jelkner has joined #schooltool | 23:01 | |
| *** jelkner has quit IRC | 23:24 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
