| *** alga has joined #schooltool | 00:46 | |
| *** menesis has quit IRC | 00:49 | |
| *** replaceafill has quit IRC | 01:08 | |
| *** alga has quit IRC | 02:27 | |
| *** ignas has quit IRC | 04:09 | |
| *** aks has joined #schooltool | 05:13 | |
| *** aks has quit IRC | 05:14 | |
| *** aks has joined #schooltool | 05:14 | |
| *** yvl has joined #schooltool | 09:08 | |
| *** olegb has quit IRC | 09:25 | |
| *** olegb has joined #schooltool | 09:28 | |
| olegb | trying to subscribe to the mailinglists at lists.schooltool.org, gives me "Bug in Mailman version 2.1.9, We're sorry, we hit a bug!". Are the mailinglists not used? | 09:45 |
|---|---|---|
| yvl | correct, we've moved to Launchpad: https://launchpad.net/~schooltoolers | 10:16 |
| olegb | thanks | 10:20 |
| *** menesis has joined #schooltool | 11:14 | |
| *** aks has quit IRC | 11:44 | |
| *** aks has joined #schooltool | 11:47 | |
| *** menesis has quit IRC | 12:10 | |
| *** menesis has joined #schooltool | 13:16 | |
| *** menesis has quit IRC | 13:20 | |
| *** menesis has joined #schooltool | 13:21 | |
| *** aks has quit IRC | 14:03 | |
| *** th1a has joined #schooltool | 15:07 | |
| *** replaceafill has joined #schooltool | 15:17 | |
| th1a | hi menesis, replaceafill, aelkner, yvl. | 15:30 |
| replaceafill | good morning/afternoon | 15:30 |
| aelkner | morning | 15:31 |
| menesis | hi | 15:32 |
| th1a | hi menesis. Did you look at resolving the font bug in the release? | 15:33 |
| menesis | th1a: yes, it only needs adding another directory to a path in conf file | 15:34 |
| th1a | Can we get that pushed today? | 15:34 |
| menesis | with only this change? | 15:34 |
| menesis | ok I can do that | 15:35 |
| th1a | It is a serious bug. | 15:35 |
| th1a | We have to stop thinking of users as hypothetical! | 15:35 |
| th1a | If you need to print out your attendance report every day and pdf support breaks, it is a serious problem! | 15:36 |
| th1a | Unless this is only on precise. | 15:37 |
| th1a | So let's get that wrapped up asap. | 15:39 |
| yvl | oh, good morning guys | 15:40 |
| th1a | hi yvl. | 15:41 |
| yvl | Unity notifications are *evil*, at least in 11.10 | 15:41 |
| th1a | Anything else menesis? | 15:42 |
| menesis | th1a: no | 15:42 |
| menesis | worked with laurynas on philippines stories | 15:42 |
| th1a | We may need to add a staging PPA to catch these things before they go out. | 15:43 |
| th1a | Or something. | 15:43 |
| th1a | How are the Philippines stories coming? | 15:44 |
| menesis | we have written some tasks | 15:47 |
| menesis | but got tired halway | 15:47 |
| menesis | will continue tomorrow | 15:47 |
| th1a | OK. Let me know how it goes. | 15:48 |
| th1a | Thanks menesis. | 15:48 |
| th1a | aelkner? | 15:48 |
| menesis | Laurynas also talked with Adam, some requirements were dropped | 15:48 |
| th1a | Ah, which ones? | 15:48 |
| aelkner | worlds .... slowest ... conversation ... :) | 15:51 |
| th1a | Perhaps we should multitask. | 15:52 |
| th1a | aelkner? | 15:52 |
| aelkner | ok, first thing reall quick, i fixed this bug: | 15:52 |
| aelkner | https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/932508 | 15:52 |
| yvl | aelkner, I recently found out this: http://bazaar.launchpad.net/~justas-pov/schooltool.gradebook/flourish/revision/462 | 15:52 |
| yvl | never ever ever ever do that again please | 15:52 |
| yvl | (commit is a fix) | 15:52 |
| yvl | (I understand that got there by accident) | 15:53 |
| th1a | That might be older than you think yvl. | 15:53 |
| th1a | Or, I guess not. I just remember Stephan liking to use super. | 15:54 |
| th1a | But I guess he didn't write the worksheets. | 15:54 |
| aelkner | i don't remember when we added all_worksheets to the interface | 15:54 |
| yvl | not the point | 15:54 |
| aelkner | probably i was the one who did it | 15:54 |
| yvl | if you find places where super is used *this* way, please add XXX | 15:54 |
| yvl | or better - fix immediately | 15:55 |
| yvl | it's a trap for other developers | 15:55 |
| aelkner | yvl, np, i had to use the super call before we had all_worksheets because I changed values | 15:55 |
| aelkner | at one point to filter out hidden worksheet | 15:55 |
| aelkner | worksheets | 15:56 |
| replaceafill | yvl, but it's ok to use it as super(class_name, self.), right? | 15:56 |
| aelkner | then, and i can't remember when, i added all_worksheets to not filter | 15:56 |
| yvl | in most cases I'm ok with that, replaceafill | 15:56 |
| aelkner | and i forgot to backport out the super calls as you did | 15:56 |
| aelkner | so thanks for that :) | 15:56 |
| aelkner | it's not exactly evil to use super, but i agree your fix is better | 15:57 |
| yvl | super there is asumming that activities are instance of class inherited from Activities, and also that parent class of Activities implements a certain method | 15:57 |
| yvl | aelkner, | 15:57 |
| yvl | in this case | 15:57 |
| yvl | it's not evil | 15:57 |
| yvl | it's Cthulhu evil | 15:57 |
| replaceafill | :| | 15:57 |
| aelkner | Cthulhu? what's that? | 15:58 |
| th1a | http://en.wikipedia.org/wiki/Cthulhu | 15:58 |
| yvl | that ;) | 15:58 |
| th1a | Simply to see it will drive you mad. | 15:58 |
| yvl | exactly | 15:59 |
| * yvl is still trying to recover | 15:59 | |
| th1a | Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn | 15:59 |
| yvl | be careful with that ;) | 15:59 |
| aelkner | yvl, you'll get over it :) | 15:59 |
| yvl | but on the serious side | 16:00 |
| yvl | please don't add traps like this | 16:00 |
| yvl | it's not a good idea to trap a developer who also knows how to build traps ;) | 16:00 |
| yvl | anyway | 16:01 |
| aelkner | ah, so as you can see by your own statement, it works both ways :) | 16:01 |
| yvl | apologies for interruption | 16:01 |
| yvl | yes | 16:01 |
| yvl | but I owe you one trap ;) | 16:01 |
| th1a | Where were we? | 16:01 |
| menesis | :) | 16:01 |
| aelkner | i was saying how i fixed the period order bug simply by making sure that the period coluns were alphabetical | 16:01 |
| aelkner | that's all there was to that | 16:02 |
| aelkner | the more interesting fix, which i haven't merged into trunk yet:: | 16:02 |
| aelkner | https://bugs.launchpad.net/schooltool/+bug/938825 | 16:02 |
| th1a | menesis: Feel free to chime in about those requirement changes... | 16:03 |
| aelkner | th1a and i agreed that it would be a good idea to add a Calendar tab as part of the fix | 16:03 |
| aelkner | as manager: | 16:03 |
| aelkner | http://69.164.203.135:36660/hide_unhide_tabs.html | 16:03 |
| aelkner | note the presence the new Calendar tab which is the default value for default tab | 16:03 |
| th1a | I guess there is no standard way to indicate that you can't uncheck a selected checkbox. | 16:04 |
| aelkner | i have javascript that makes sure you can't hide the default tab | 16:04 |
| aelkner | and also that you can't change the default tab to one that is hidden | 16:04 |
| aelkner | also, the view now requires the user to submit | 16:05 |
| aelkner | no more submit on change | 16:05 |
| replaceafill | aelkner, why don't you disable the radio button when the user unchecks the checkbox? | 16:05 |
| th1a | Oh, yeah, you should do that. | 16:06 |
| aelkner | when i did that, the request wasn't sending the radio value | 16:06 |
| aelkner | for some reason, disabling one radio button seemed to break the submit of the radio field entirely | 16:06 |
| replaceafill | hhmm | 16:07 |
| aelkner | i don't know why that was, but what i did works, doesn't it? | 16:07 |
| replaceafill | looks funny to me | 16:07 |
| aelkner | well, you look funny to me :) | 16:08 |
| replaceafill | ¬¬ | 16:08 |
| th1a | It would be better if the inactivated radio button looked inactive. | 16:08 |
| aelkner | man, i tell you, if i knew i was going to be insulted so much this morning ... | 16:08 |
| th1a | You could fiddle with it a bit more, but it isn't a big deal. | 16:09 |
| th1a | I'll send you updated What is This? text. | 16:09 |
| aelkner | ah, yes, i was going to ask you for that | 16:09 |
| aelkner | menesis, this bug fix involves adding the calendar tab | 16:09 |
| aelkner | do you need me to create a new bug and update CHANGES.txt wth that? | 16:10 |
| aelkner | th1a, the book would need to be updated to include screenshots with the Calendar tab | 16:10 |
| menesis | aelkner: not neccessary | 16:10 |
| aelkner | menesis, ok, thanks | 16:10 |
| th1a | I think people will be able to figure it out without me updating every screen shot. | 16:11 |
| th1a | I do have some updates to do though. | 16:11 |
| th1a | Next week may be a doc week. | 16:11 |
| aelkner | anyway, i'll try one more time to disable the radio buttons, but if the no-submit problem happens again, i'll have to forget it | 16:12 |
| th1a | This is something that should probably be released in the next few months, since CanDo and probably the Philippines will want it. | 16:12 |
| aelkner | it's not like we have any other case of partially disabling radio choices in the app | 16:12 |
| aelkner | replaceafill, have you ever done anything like that? | 16:13 |
| th1a | There is no reason disabled radio buttons should be a problem, but something weird may be going on javascript-wise. | 16:13 |
| aelkner | disabled radio buttons may lead to disabling the field entirely | 16:14 |
| aelkner | that would not be a problem javascript-wise, just a specification | 16:14 |
| aelkner | like i said, never seen an example | 16:15 |
| aelkner | but i'll play arond with it some more | 16:15 |
| aelkner | also, i'll add a stest file for the whole tabs hiding/change default feature | 16:16 |
| th1a | Yes -- this definitely needs tests. | 16:16 |
| aelkner | anyway, that's it for me | 16:16 |
| th1a | OK, so a couple loose ends and hopefully onto CanDo-style imports tomorrow. | 16:18 |
| th1a | Thanks aelkner. | 16:18 |
| th1a | yvl? | 16:18 |
| yvl | work in progress | 16:19 |
| yvl | should be delivered by Monday | 16:19 |
| th1a | Done? | 16:20 |
| th1a | I mean, is that all? | 16:20 |
| * yvl done | 16:20 | |
| th1a | I'll get more inquisitive if you're late. ;-) | 16:20 |
| th1a | Thanks yvl. | 16:20 |
| yvl | please do :) | 16:20 |
| th1a | replaceafill? | 16:20 |
| menesis | th1a: uploaded packages with fixed font path. | 16:21 |
| replaceafill | ok, i added a couple of selenium extensions to the gradebook | 16:21 |
| replaceafill | for adding activities, and for printing the gradebook | 16:21 |
| replaceafill | i've also been looking at other things like the cache problem from sid | 16:21 |
| replaceafill | or yesterday's jquery issue with the package | 16:22 |
| replaceafill | version | 16:22 |
| replaceafill | http://69.164.203.135:6662/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000/activities/Worksheet/gradebook | 16:22 |
| replaceafill | teacher004 | 16:22 |
| th1a | replaceafill is a good fireman. | 16:22 |
| replaceafill | i fixed the zoom buttons | 16:22 |
| replaceafill | not at all :) | 16:22 |
| replaceafill | and i added a expand/collapse button | 16:23 |
| replaceafill | which well... expand or collapse the grades part :) | 16:23 |
| replaceafill | their position + hiding/showing is not the best though | 16:23 |
| replaceafill | but i think it's functionality the cando users might need | 16:24 |
| th1a | We were discussing the need for some sort of settings menu in the gradebook. | 16:24 |
| th1a | Since we're also hiding stuff under the "Name" menu that you wouldn't expect to be there. | 16:24 |
| menesis | replaceafill: I'd like the arrow stay in the same place when clicked | 16:24 |
| th1a | I'm debating a Google-style gear icon somewhere. | 16:25 |
| replaceafill | menesis, i can do that, sure | 16:25 |
| replaceafill | menesis, it's just that to me that indicator should be on the left side at the beginning | 16:25 |
| replaceafill | kind of what twitter had before to expand/collapse tweets | 16:26 |
| replaceafill | (in case you saw it) :D | 16:26 |
| menesis | yes, left | 16:26 |
| replaceafill | yes | 16:26 |
| replaceafill | th1a, now i'm moving to the journal | 16:26 |
| menesis | it's not very obvious what it does, but I don't see where else to put the button | 16:26 |
| replaceafill | apply all these changes there | 16:26 |
| th1a | I think the whole thing needs to be rearranged so it might as well be there for now. | 16:27 |
| yvl | some people would have put that in the space between gradebook and the left column | 16:27 |
| replaceafill | like sphinx does | 16:27 |
| replaceafill | http://docs.python.org/ | 16:28 |
| th1a | Oh yeah. | 16:28 |
| th1a | That would be fine. | 16:28 |
| replaceafill | cool, i'll give it a try | 16:28 |
| th1a | Except... | 16:29 |
| th1a | Our page isn't structured the same way, but see if you can make it work. | 16:29 |
| replaceafill | kk | 16:29 |
| th1a | Well... maybe just don't do anything yet. | 16:29 |
| replaceafill | ah | 16:29 |
| th1a | It isn't a big priority. | 16:29 |
| replaceafill | ok | 16:29 |
| replaceafill | yes | 16:29 |
| replaceafill | the js logic is there anyway | 16:29 |
| replaceafill | th1a, question | 16:29 |
| th1a | Yes, we can come back to it. | 16:30 |
| replaceafill | about the bugs you assigned to me yesterday | 16:30 |
| replaceafill | the modal ones | 16:30 |
| replaceafill | you said those should be done before the release | 16:30 |
| replaceafill | should i start on those now? | 16:30 |
| th1a | Before October I meant. | 16:30 |
| replaceafill | ah! | 16:30 |
| th1a | I guess that's an important distinction. ;-) | 16:30 |
| replaceafill | duh! i thought you meant the april realease :D | 16:30 |
| replaceafill | ok | 16:30 |
| th1a | I don't think I specified. | 16:30 |
| replaceafill | ok, i'm done now | 16:31 |
| th1a | I do have two little bugs from yesterday I don't know who to give to. | 16:31 |
| th1a | https://bugs.launchpad.net/schooltool/+bug/960367 | 16:31 |
| th1a | and | 16:31 |
| th1a | https://bugs.launchpad.net/schooltool/+bug/961150 | 16:31 |
| th1a | If replaceafill is switching tasks, probably he should do them. | 16:31 |
| replaceafill | i checked the first one | 16:31 |
| th1a | (if he hasn't already) | 16:32 |
| replaceafill | our parse_date function and python's date() allows years to be even 1 | 16:32 |
| replaceafill | but the strftime method needs 1900 or higher | 16:32 |
| replaceafill | weird to me :/ | 16:32 |
| replaceafill | anyway, since the user has already the bad date in the system | 16:33 |
| replaceafill | i was thinking he should get a validation error when he displays the edit form | 16:33 |
| replaceafill | and we should not allow years < 1900 on date creation | 16:33 |
| th1a | Sounds good to me. | 16:33 |
| replaceafill | i can take that one :) | 16:34 |
| replaceafill | i don't like the other one because it involves two different forms :) | 16:34 |
| replaceafill | when you click the (-) you lost the data in the other form | 16:34 |
| replaceafill | i mean you click (-) in one form, and the search is in another form | 16:34 |
| replaceafill | i think yvl is the right person to work on that one :) | 16:35 |
| th1a | OK. ;-) | 16:35 |
| yvl | or we could just not do it? | 16:35 |
| th1a | I could make it "medium" | 16:35 |
| replaceafill | losing the search in that condition it doesnt bother *me* :) | 16:36 |
| * yvl too | 16:36 | |
| yvl | :) | 16:36 |
| th1a | I mean, I suppose it doesn't matter does it. | 16:36 |
| th1a | ? | 16:36 |
| th1a | Now that I think of it. | 16:36 |
| yvl | maybe in one case it could | 16:36 |
| yvl | if you added somebody by accident | 16:36 |
| yvl | and want to remove | 16:36 |
| yvl | and add the right person | 16:36 |
| * replaceafill thought of the same use case! | 16:37 | |
| yvl | but I'd make it low priority | 16:37 |
| th1a | yvl: So you're saying this would be a pain to fix. | 16:37 |
| yvl | somewhat | 16:37 |
| th1a | I'll make it medium (which means we won't think about it again for a long time). | 16:37 |
| yvl | ok :D | 16:37 |
| th1a | We may need a mass-recalibration of our bug importance at some point. | 16:38 |
| th1a | OK, thanks replaceafill. | 16:38 |
| th1a | We have new report card designs, which I like: https://schwadesign.basecamphq.com/projects/7580415-2682-003-phase-1-2/posts/58828570/comments#comment_168222597 | 16:39 |
| th1a | We probably won't actually do the big scores at the top, but it is a nice idea. | 16:39 |
| th1a | I think the overall look is good. | 16:41 |
| replaceafill | th1a, that design will be used when we do the "CSS for PDFs" story, correct? | 16:41 |
| th1a | We will have to change the layout forms aelkner to work with this. | 16:41 |
| replaceafill | i mean, when we clean our pdf styles | 16:41 |
| th1a | replaceafill: Yes. | 16:41 |
| aelkner | we don't have data for the last two columns | 16:41 |
| th1a | ? | 16:42 |
| aelkner | adn yes, we need pdf styles | 16:42 |
| th1a | We probably won't use the Overview by default. | 16:42 |
| aelkner | i was referring to Strengths and Topics to review | 16:42 |
| th1a | Are we looking at the same thing? | 16:43 |
| replaceafill | i think aelkner is looking at the first version | 16:43 |
| th1a | Are you looking at SchoolTool_PrintReport_3_page1.pdf | 16:43 |
| aelkner | ah | 16:43 |
| aelkner | you didn't say to look at that one | 16:43 |
| th1a | That was the comment I linked to... | 16:44 |
| th1a | OK, so there's that. | 16:44 |
| th1a | I think that covers everything. | 16:45 |
| aelkner | ok, so the comments part is not part of our model, right? | 16:45 |
| th1a | It is in a different place. | 16:45 |
| th1a | No outline view. | 16:45 |
| th1a | So we'll have to think about that a bit. | 16:45 |
| *** ignas has joined #schooltool | 16:46 | |
| th1a | Oh, Justas is probably going to go to Portugal sometime in the next month or two to help get the CL update going. | 16:47 |
| yvl | wait what? | 16:47 |
| th1a | I sent you an email about that didn't I? | 16:47 |
| yvl | yes | 16:47 |
| * yvl managed to read that Gediminas is going | 16:48 | |
| th1a | "Justas, | 16:48 |
| th1a | I volunteered you for a trip to Portugal, so hopefully we can make that work. | 16:48 |
| th1a | " | 16:48 |
| yvl | yes, I know | 16:48 |
| th1a | :-D | 16:48 |
| th1a | So anyhow, if you DON'T want to go to Portugal at some point, we'll need to discuss that. | 16:49 |
| th1a | We haven't gotten down to dates yet regardless. | 16:49 |
| * yvl won't be able to go mid May I think | 16:50 | |
| yvl | other than that, it would be nice to visit Critical Links guys again :) | 16:50 |
| th1a | I'm sure we can sort out a date that works. | 16:51 |
| yvl | sure | 16:51 |
| th1a | The only problem is you won't have aelkner to drive you around. | 16:51 |
| aelkner | :) | 16:51 |
| th1a | Do you have a driver's license, yvl? | 16:52 |
| aelkner | as long as he doesn't lose his wallet | 16:52 |
| yvl | yes th1a | 16:52 |
| * th1a had forgotten about that. | 16:52 | |
| th1a | OK, good. | 16:52 |
| th1a | All right, that should do it then. | 16:52 |
| th1a | Have a great week and weekend guys! | 16:52 |
| * th1a drops the bag of gravel. | 16:52 | |
| yvl | thanks guys | 16:52 |
| replaceafill | thanks everybody | 16:52 |
| aelkner | thanks all, have a greate weekend | 16:52 |
| aelkner | th1a, replaceafill, good news, i can disable single radio buttons and submit | 17:21 |
| aelkner | i don't know what happened before that made me think that i couldn't | 17:21 |
| aelkner | i could have had a different problem and didn't realize it | 17:22 |
| th1a | That's what I suspected. | 17:23 |
| replaceafill | :) | 17:24 |
| aelkner | th1a, replaceafill, for your approval, as manager: | 17:30 |
| aelkner | http://69.164.203.135:36660/hide_unhide_tabs.html | 17:30 |
| th1a | Ah. Yes, I guess you can deactivate selected checkboxes. | 17:31 |
| th1a | Good! | 17:31 |
| th1a | Add to What is This?: | 17:32 |
| th1a | "When users log in, the will usually be directed to the tab selected in the default column. The default tab must also be visible." | 17:33 |
| th1a | And get rid of the extra period you have in the last paragraph. | 17:34 |
| *** replaceafill has quit IRC | 17:34 | |
| aelkner | ok, will do | 17:35 |
| *** replaceafill has joined #schooltool | 17:36 | |
| replaceafill | yvl, you gone? | 17:58 |
| replaceafill | th1a, is this a good validation error message: | 18:18 |
| replaceafill | 'Year has to be equal or higher than 1900' | 18:18 |
| th1a | greater than | 18:19 |
| replaceafill | ah ok | 18:19 |
| th1a | replaceafill: I'm distracting you again... can you look at the spreadsheet? https://bugs.launchpad.net/schooltool/+bug/944471 | 18:32 |
| th1a | Maybe this is just a unicode problem. | 18:32 |
| replaceafill | looking | 18:32 |
| replaceafill | ah this is carlos problem, right? | 18:33 |
| replaceafill | i think it may be a problem with his demo types | 18:33 |
| replaceafill | i sent him an email, but he didnt reply | 18:34 |
| replaceafill | i cc'ed you on that one | 18:34 |
| th1a | Yes. | 18:34 |
| th1a | What did you think it was? | 18:34 |
| replaceafill | i tried his same xls | 18:34 |
| replaceafill | but most of my types were text | 18:34 |
| th1a | https://answers.launchpad.net/schooltool/+question/189192 | 18:34 |
| replaceafill | and dates | 18:34 |
| replaceafill | let me see, i think i still have that instance running | 18:34 |
| * replaceafill has so many instances running lately... | 18:34 | |
| replaceafill | ah yes | 18:35 |
| replaceafill | http://69.164.203.135:6660/persons/10272671821 | 18:35 |
| replaceafill | i used his spreadsheet to create that person | 18:35 |
| replaceafill | and here are my demos: | 18:36 |
| replaceafill | http://69.164.203.135:6660/demographics | 18:36 |
| replaceafill | maybe we should ask him to share his /demographics screenshot | 18:36 |
| replaceafill | that would give me a better clue | 18:37 |
| th1a | Oh, yes, we can't import some types? | 18:37 |
| replaceafill | we can, but we would need to know the values he entered | 18:38 |
| replaceafill | what it seems weird to me is that he says the rest of the person gets imported fine | 18:39 |
| replaceafill | iirc | 18:39 |
| replaceafill | "The only fields that were imported were general information." | 18:39 |
| th1a | OK, ask him whatever you think would help. | 18:40 |
| replaceafill | kk | 18:40 |
| th1a | http://69.164.203.135/d3/hex/ | 18:46 |
| th1a | w00t! | 18:46 |
| replaceafill | :D | 18:46 |
| th1a | I need to fiddle with the CSS now, but the SVG is pretty much there. | 18:47 |
| * th1a goes to get Vivian. | 18:49 | |
| replaceafill | aelkner, you can use $(element).is(':checked') instead of using .attr('checked') == 'checked' | 19:00 |
| replaceafill | you also can use $(element).is(':disabled') | 19:00 |
| aelkner | ah, thanks | 19:05 |
| *** alga has joined #schooltool | 19:05 | |
| replaceafill | they're slower, but easier to read imo | 19:05 |
| aelkner | i guess the speed issue would matter more if the loop was longer, more selector calls | 19:09 |
| replaceafill | true | 19:10 |
| *** paulproteus has quit IRC | 19:10 | |
| *** paulproteus has joined #schooltool | 19:10 | |
| th1a | replaceafill: Did you ever try the audit feature on Chrome? | 19:40 |
| replaceafill | th1a, no | 19:40 |
| replaceafill | just came to chrome a couple of weeks ago :) | 19:41 |
| th1a | Just open the dev panel (inspect page element...) | 19:41 |
| th1a | And select Audits, | 19:41 |
| th1a | and then from the page you want Reload Page and Audit on Load. | 19:42 |
| replaceafill | :| | 19:42 |
| replaceafill | lots of red on my gradebook view | 19:42 |
| replaceafill | There are multiple resources served from same domain. Consider combining them into as few files as possible. | 19:42 |
| replaceafill | :O | 19:42 |
| replaceafill | ah come on! | 19:44 |
| replaceafill | A width and height should be specified for all images in order to speed up page display. The following image(s) are missing a width and/or height: | 19:44 |
| replaceafill | logo-small.png | 19:44 |
| replaceafill | we set it through css ;) | 19:44 |
| replaceafill | or no, we don't :D | 19:45 |
| th1a | heh heh | 19:45 |
| replaceafill | reminds me of the yslow extension for firefox | 19:46 |
| th1a | Yeah. Same idea. | 19:48 |
| th1a | replaceafill: I guess paster doesn't give you much control over caching, so it probably does make more sense to do this in Apache. | 19:56 |
| replaceafill | th1a, yes | 19:56 |
| replaceafill | i was looking for a wsgi middleware solution but all of them seemed too complex | 19:57 |
| replaceafill | compared to apache's two lines | 19:57 |
| th1a | Yes... we need to make Apache fully part of apt-getting schooltool. | 19:57 |
| replaceafill | hhmm, not sure about that one | 19:58 |
| replaceafill | but your call :) | 19:58 |
| replaceafill | i mean, you can use schooltool without apache | 19:58 |
| th1a | I mean, it may be a separate package. | 19:58 |
| replaceafill | ah, something that creates the proper configuration for you? | 19:58 |
| th1a | Probably Apache should be gzipping everything. | 19:59 |
| th1a | Setting caching. | 19:59 |
| th1a | Ideally SSL... | 19:59 |
| replaceafill | next week, i need to do some serious cleanup in the vps | 20:00 |
| replaceafill | we only have 1.47 GB free | 20:00 |
| th1a | kk | 20:01 |
| replaceafill | and my sandboxes directoy has like 14 GB! | 20:01 |
| *** menesis has quit IRC | 20:16 | |
| th1a | I may have to re-write this in javascript because it is too big. | 20:28 |
| replaceafill | ah great... | 20:46 |
| replaceafill | th1a, you around? | 20:46 |
| th1a | Yes. | 20:47 |
| replaceafill | k, let me try to sum up the warning dialog situation for the gradebook | 20:47 |
| replaceafill | our current way is to use a prompt, remember? | 20:47 |
| replaceafill | let me set an instance to show it | 20:47 |
| replaceafill | http://69.164.203.135:6663/schoolyears/2010-2011/2010-fall/sections/art_a_2010-fall_teacher004_000/activities/Worksheet/gradebook | 20:48 |
| replaceafill | teacher004 | 20:48 |
| replaceafill | if you visit that one with ff | 20:48 |
| replaceafill | you get the prompt with OK, Cancel buttons | 20:48 |
| replaceafill | and a custom message | 20:48 |
| th1a | new http://69.164.203.135/d3/hex/ btw | 20:48 |
| replaceafill | :D | 20:48 |
| replaceafill | that background reminds me of bees :) | 20:48 |
| replaceafill | ok | 20:49 |
| replaceafill | if you visit the url with chrome | 20:49 |
| replaceafill | you dont get the prompt | 20:49 |
| th1a | y | 20:49 |
| replaceafill | because chrome doesnt give a **** about the unload event, and doesnt allow you to customize it | 20:49 |
| replaceafill | so, we need to use something else | 20:49 |
| th1a | Ah. | 20:49 |
| replaceafill | onbeforeunload | 20:50 |
| replaceafill | notice the before | 20:50 |
| th1a | Uh... ok. | 20:50 |
| replaceafill | but this has a nice new problem | 20:50 |
| replaceafill | you cannot have prompt buttons | 20:50 |
| replaceafill | OK, Cancel | 20:50 |
| replaceafill | these are set by the browser | 20:50 |
| replaceafill | to: | 20:50 |
| replaceafill | Stay in the page, Leave the page | 20:51 |
| replaceafill | (or something like that) | 20:51 |
| replaceafill | i'm seeing it in spanish ;) | 20:51 |
| th1a | OK, fine. | 20:51 |
| replaceafill | and the last thing ff did: https://bugzilla.mozilla.org/show_bug.cgi?id=588292 | 20:51 |
| replaceafill | you cannot customize the message anymore :( | 20:52 |
| replaceafill | but i think it's a good behaviour anyway for the gradebook | 20:52 |
| replaceafill | kind of out of our hands though | 20:52 |
| th1a | It is ok with me. | 20:53 |
| th1a | Gets the point across. | 20:53 |
| replaceafill | reload: http://69.164.203.135:6663/schoolyears/2010-2011/2010-fall/sections/art_a_2010-fall_teacher004_000/activities/Worksheet/gradebook | 20:53 |
| replaceafill | you'll see the new behaviour | 20:53 |
| th1a | Probably better than "OK" "Cancel" anyhow! | 20:53 |
| replaceafill | see the page in both browsers | 20:54 |
| replaceafill | chrome displays the old warning message | 20:54 |
| replaceafill | (which we will need to change) | 20:54 |
| replaceafill | the rest is browser dependent | 20:54 |
| replaceafill | ff doesn't show the custom message, just the browser dependent stuff | 20:54 |
| th1a | Chrome can use the same message as far as I'm concerned. | 20:55 |
| replaceafill | right, but without the "Click OK to save now..." right | 20:55 |
| replaceafill | just "You have some changes that have not been saved" | 20:55 |
| th1a | Mine says "This page is asking you to confirm that you want to leave - data you have entered may not be saved." | 20:55 |
| replaceafill | did you reload? | 20:56 |
| th1a | FIrefox may be too inconsistent to match. ;-) | 20:56 |
| replaceafill | :D | 20:56 |
| th1a | That's what I get from FF. | 20:56 |
| replaceafill | ah yes | 20:56 |
| th1a | 11.0 | 20:57 |
| replaceafill | this is my chrome: http://imageshack.us/photo/my-images/855/pantallazodel2012032112.png/ | 20:59 |
| replaceafill | custom message on top | 20:59 |
| replaceafill | spanish at bottom :) | 20:59 |
| replaceafill | ok, if you're ok with this behaviour i'll go with it | 21:00 |
| th1a | Uh... | 21:00 |
| th1a | So Chrome we can control the message but not FF? | 21:00 |
| replaceafill | yes | 21:00 |
| th1a | Just make them the same if we can. | 21:01 |
| replaceafill | we can't :( | 21:01 |
| replaceafill | either way we go with | 21:01 |
| replaceafill | we get a mistmatch between the two | 21:01 |
| replaceafill | we can have the prompt (ok,cancel) in ff, and not in chrome | 21:01 |
| replaceafill | or the custom message in chrome and not in ff | 21:01 |
| th1a | Use the Chrome system and make the chrome message match the FF message. | 21:03 |
| replaceafill | is this worth sniffing the browser? | 21:03 |
| th1a | I don't understand the confusion. | 21:03 |
| replaceafill | and setting the appropriate behaviour on each? | 21:03 |
| th1a | Use the chrome system and make "This page is asking you to confirm that you want to leave - data you have entered may not be saved." the message. | 21:04 |
| th1a | In English, at least. | 21:04 |
| replaceafill | but we wont see that in ff | 21:04 |
| *** menesis has joined #schooltool | 21:04 | |
| th1a | I copy/pasted that from FF. | 21:04 |
| replaceafill | ah | 21:04 |
| replaceafill | got it | 21:04 |
| th1a | :-) | 21:05 |
| replaceafill | that's our new custom emssage | 21:05 |
| replaceafill | message | 21:05 |
| replaceafill | understood | 21:05 |
| th1a | Yes. | 21:05 |
| replaceafill | thanks th1a | 21:05 |
| * replaceafill goes to get lunch | 21:08 | |
| th1a | replaceafill: http://69.164.203.135/d3/flourish/main.html | 21:27 |
| th1a | Could you throw that background into a regular instance. | 21:27 |
| th1a | That I can take a look at tomorrow? | 21:27 |
| aelkner | yvl, ayt? | 22:25 |
| aelkner | replaceafill? | 22:25 |
| * replaceafill back | 22:31 | |
| replaceafill | th1a, kk will do | 22:31 |
| replaceafill | aelkner, i'm back | 22:31 |
| aelkner | i'm looking to create a selenium script for the server tabs, but app/stests are based on old app layer | 22:34 |
| replaceafill | ah yes | 22:34 |
| aelkner | i was wondering if you thought we could scrap app.txt | 22:35 |
| replaceafill | not really | 22:35 |
| aelkner | and change stesting.zcml to use flourish | 22:35 |
| replaceafill | i'd move it to a stesting-oldskin.zcml file or something like that | 22:35 |
| replaceafill | and would create a new stesting.zcml for flourish | 22:35 |
| replaceafill | i was about to do that for the ui.login(...) extension | 22:35 |
| replaceafill | but didnt get there | 22:35 |
| aelkner | i would need to create a new stests-oldskin directory with different test_all.py, right? | 22:39 |
| aelkner | and i could move app.txt to that directory | 22:39 |
| replaceafill | why not use the same directory and same stesting.py file? | 22:39 |
| replaceafill | you can have two layers in the same stesting.py file | 22:39 |
| replaceafill | one layer picks the old skin zcml | 22:39 |
| replaceafill | and the other the flourish one | 22:40 |
| aelkner | in schooltool/app/testing, i'd need a new layer definition | 22:40 |
| replaceafill | let me see the files so im not talking wrong here :) | 22:40 |
| aelkner | how does the layer know which files to run? | 22:41 |
| aelkner | i think we need the directories to be split up to do that | 22:41 |
| replaceafill | same way the gradebook does with the journal, you hard code the old ones | 22:41 |
| replaceafill | or you could do taht | 22:41 |
| replaceafill | (split them) | 22:42 |
| aelkner | it would be cleaner | 22:42 |
| aelkner | although i'm not sure if yvl would mind | 22:43 |
| aelkner | he may prefer the hard-coded way that you referred to | 22:44 |
| replaceafill | you can ask him, i'm fine either way, just think we shouldn't get rid of tests, even if they're old | 22:44 |
| replaceafill | and the ftests set up of the gradebook (conditionally) is not hard to understand | 22:45 |
| replaceafill | imo | 22:45 |
| aelkner | i see how it works now, probably simpler to do it the hard-coded way | 22:48 |
| replaceafill | :) | 22:48 |
| aelkner | i just have to add the same kind of multi-layer code with hard coded list to test_all.py | 22:49 |
| replaceafill | yep | 22:49 |
| aelkner | and se the same no in old_tests logic, etc. | 22:49 |
| aelkner | not in old_tests, i mean | 22:49 |
| aelkner | but anyway, thanks for the suggestion | 22:52 |
| replaceafill | np | 22:52 |
| replaceafill | th1a, instance with your hexes background http://69.164.203.135:6660/ | 23:05 |
| *** th1a has quit IRC | 23:20 | |
| *** replaceafill has quit IRC | 23:28 | |
| *** menesis has quit IRC | 23:33 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
