IRC log of #schooltool for Wednesday, 2012-03-21

*** alga has joined #schooltool00:46
*** menesis has quit IRC00:49
*** replaceafill has quit IRC01:08
*** alga has quit IRC02:27
*** ignas has quit IRC04:09
*** aks has joined #schooltool05:13
*** aks has quit IRC05:14
*** aks has joined #schooltool05:14
*** yvl has joined #schooltool09:08
*** olegb has quit IRC09:25
*** olegb has joined #schooltool09:28
olegbtrying to subscribe to the mailinglists at, gives me "Bug in Mailman version 2.1.9, We're sorry, we hit a bug!". Are the mailinglists not used?09:45
yvlcorrect, we've moved to Launchpad:
*** menesis has joined #schooltool11:14
*** aks has quit IRC11:44
*** aks has joined #schooltool11:47
*** menesis has quit IRC12:10
*** menesis has joined #schooltool13:16
*** menesis has quit IRC13:20
*** menesis has joined #schooltool13:21
*** aks has quit IRC14:03
*** th1a has joined #schooltool15:07
*** replaceafill has joined #schooltool15:17
th1ahi menesis, replaceafill, aelkner, yvl.15:30
replaceafillgood morning/afternoon15:30
th1ahi menesis.  Did you look at resolving the font bug in the release?15:33
menesisth1a: yes, it only needs adding another directory to a path in conf file15:34
th1aCan we get that pushed today?15:34
menesiswith only this change?15:34
menesisok I can do that15:35
th1aIt is a serious bug.15:35
th1aWe have to stop thinking of users as hypothetical!15:35
th1aIf you need to print out your attendance report every day and pdf support breaks, it is a serious problem!15:36
th1aUnless this is only on precise.15:37
th1aSo let's get that wrapped up asap.15:39
yvloh, good morning guys15:40
th1ahi yvl.15:41
yvlUnity notifications are *evil*, at least in 11.1015:41
th1aAnything else menesis?15:42
menesisth1a: no15:42
menesisworked with laurynas on philippines stories15:42
th1aWe may need to add a staging PPA to catch these things before they go out.15:43
th1aOr something.15:43
th1aHow are the Philippines stories coming?15:44
menesiswe have written some tasks15:47
menesisbut got tired halway15:47
menesiswill continue tomorrow15:47
th1aOK.  Let me know how it goes.15:48
th1aThanks menesis.15:48
menesisLaurynas also talked with Adam, some requirements were dropped15:48
th1aAh, which ones?15:48
aelknerworlds .... slowest ... conversation ... :)15:51
th1aPerhaps we should multitask.15:52
aelknerok, first thing reall quick, i fixed this bug:15:52
yvlaelkner, I recently found out this:
yvlnever ever ever ever do that again please15:52
yvl(commit is a fix)15:52
yvl(I understand that got there by accident)15:53
th1aThat might be older than you think yvl.15:53
th1aOr, I guess not.  I just remember Stephan liking to use super.15:54
th1aBut I guess he didn't write the worksheets.15:54
aelkneri don't remember when we added all_worksheets to the interface15:54
yvlnot the point15:54
aelknerprobably i was the one who did it15:54
yvlif you find places where super is used *this* way, please add XXX15:54
yvlor better - fix immediately15:55
yvlit's a trap for other developers15:55
aelkneryvl, np, i had to use the super call before we had all_worksheets because I changed values15:55
aelknerat one point to filter out hidden worksheet15:55
replaceafillyvl, but it's ok to use it as super(class_name, self.), right?15:56
aelknerthen, and i can't remember when, i added all_worksheets to not filter15:56
yvlin most cases I'm ok with that, replaceafill15:56
aelknerand i forgot to backport out the super calls as you did15:56
aelknerso thanks for that :)15:56
aelknerit's not exactly evil to use super, but i agree your fix is better15:57
yvlsuper there is asumming that activities are instance of class inherited from Activities, and also that parent class of Activities implements a certain method15:57
yvlin this case15:57
yvlit's not evil15:57
yvlit's Cthulhu evil15:57
aelknerCthulhu?  what's that?15:58
yvlthat ;)15:58
th1aSimply to see it will drive you mad.15:58
* yvl is still trying to recover15:59
th1aPh'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn15:59
yvlbe careful with that ;)15:59
aelkneryvl, you'll get over it :)15:59
yvlbut on the serious side16:00
yvlplease don't add traps like this16:00
yvlit's not a good idea to trap a developer who also knows how to build traps ;)16:00
aelknerah, so as you can see by your own statement, it works both ways :)16:01
yvlapologies for interruption16:01
yvlbut I owe you one trap ;)16:01
th1aWhere were we?16:01
aelkneri was saying how i fixed the period order bug simply by making sure that the period coluns were alphabetical16:01
aelknerthat's all there was to that16:02
aelknerthe more interesting fix, which i haven't merged into trunk yet::16:02
th1amenesis:  Feel free to chime in about those requirement changes...16:03
aelknerth1a and i agreed that it would be a good idea to add a Calendar tab as part of the fix16:03
aelkneras manager:16:03
aelknernote the presence the new Calendar tab which is the default value for default tab16:03
th1aI guess there is no standard way to indicate that you can't uncheck a selected checkbox.16:04
aelkneri have javascript that makes sure you can't hide the default tab16:04
aelknerand also that you can't change the default tab to one that is hidden16:04
aelkneralso, the view now requires the user to submit16:05
aelknerno more submit on change16:05
replaceafillaelkner, why don't you disable the radio button when the user unchecks the checkbox?16:05
th1aOh, yeah, you should do that.16:06
aelknerwhen i did that, the request wasn't sending the radio value16:06
aelknerfor some reason, disabling one radio button seemed to break the submit of the radio field entirely16:06
aelkneri don't know why that was, but what i did works, doesn't it?16:07
replaceafilllooks funny to me16:07
aelknerwell, you look funny to me :)16:08
th1aIt would be better if the inactivated radio button looked inactive.16:08
aelknerman, i tell you, if i knew i was going to be insulted so much this morning ...16:08
th1aYou could fiddle with it a bit more, but it isn't a big deal.16:09
th1aI'll send you updated What is This? text.16:09
aelknerah, yes, i was going to ask you for that16:09
aelknermenesis, this bug fix involves adding the calendar tab16:09
aelknerdo you need me to create a new bug and update CHANGES.txt wth that?16:10
aelknerth1a, the book would need to be updated to include screenshots with the Calendar tab16:10
menesisaelkner: not neccessary16:10
aelknermenesis, ok, thanks16:10
th1aI think people will be able to figure it out without me updating every screen shot.16:11
th1aI do have some updates to do though.16:11
th1aNext week may be a doc week.16:11
aelkneranyway, i'll try one more time to disable the radio buttons, but if the no-submit problem happens again, i'll have to forget it16:12
th1aThis is something that should probably be released in the next few months, since CanDo and probably the Philippines will want it.16:12
aelknerit's not like we have any other case of partially disabling radio choices in the app16:12
aelknerreplaceafill, have you ever done anything like that?16:13
th1aThere is no reason disabled radio buttons should be a problem, but something weird may be going on javascript-wise.16:13
aelknerdisabled radio buttons may lead to disabling the field entirely16:14
aelknerthat would not be a problem javascript-wise, just a specification16:14
aelknerlike i said, never seen an example16:15
aelknerbut i'll play arond with it some more16:15
aelkneralso, i'll add a stest file for the whole tabs hiding/change default feature16:16
th1aYes -- this definitely needs tests.16:16
aelkneranyway, that's it for me16:16
th1aOK, so a couple loose ends and hopefully onto CanDo-style imports tomorrow.16:18
th1aThanks aelkner.16:18
yvlwork in progress16:19
yvlshould be delivered by Monday16:19
th1aI mean, is that all?16:20
* yvl done16:20
th1aI'll get more inquisitive if you're late.  ;-)16:20
th1aThanks yvl.16:20
yvlplease do :)16:20
menesisth1a: uploaded packages with fixed font path.16:21
replaceafillok, i added a couple of selenium extensions to the gradebook16:21
replaceafillfor adding activities, and for printing the gradebook16:21
replaceafilli've also been looking at other things like the cache problem from sid16:21
replaceafillor yesterday's jquery issue with the package16:22
th1areplaceafill is a good fireman.16:22
replaceafilli fixed the zoom buttons16:22
replaceafillnot at all :)16:22
replaceafilland i added a expand/collapse button16:23
replaceafillwhich well... expand or collapse the grades part :)16:23
replaceafilltheir position + hiding/showing is not the best though16:23
replaceafillbut i think it's functionality the cando users might need16:24
th1aWe were discussing the need for some sort of settings menu in the gradebook.16:24
th1aSince we're also hiding stuff under the "Name" menu that you wouldn't expect to be there.16:24
menesisreplaceafill: I'd like the arrow stay in the same place when clicked16:24
th1aI'm debating a Google-style gear icon somewhere.16:25
replaceafillmenesis, i can do that, sure16:25
replaceafillmenesis, it's just that to me that indicator should be on the left side at the beginning16:25
replaceafillkind of what twitter had before to expand/collapse tweets16:26
replaceafill(in case you saw it) :D16:26
menesisyes, left16:26
replaceafillth1a, now i'm moving to the journal16:26
menesisit's not very obvious what it does, but I don't see where else to put the button16:26
replaceafillapply all these changes there16:26
th1aI think the whole thing needs to be rearranged so it might as well be there for now.16:27
yvlsome people would have put that in the space between gradebook and the left column16:27
replaceafilllike sphinx does16:27
th1aOh yeah.16:28
th1aThat would be fine.16:28
replaceafillcool, i'll give it a try16:28
th1aOur page isn't structured the same way, but see if you can make it work.16:29
th1aWell... maybe just don't do anything yet.16:29
th1aIt isn't a big priority.16:29
replaceafillthe js logic is there anyway16:29
replaceafillth1a, question16:29
th1aYes, we can come back to it.16:30
replaceafillabout the bugs you assigned to me yesterday16:30
replaceafillthe modal ones16:30
replaceafillyou said those should be done before the release16:30
replaceafillshould i start on those now?16:30
th1aBefore October I meant.16:30
th1aI guess that's an important distinction.  ;-)16:30
replaceafillduh! i thought you meant the april realease :D16:30
th1aI don't think I specified.16:30
replaceafillok, i'm done now16:31
th1aI do have two little bugs from yesterday I don't know who to give to.16:31
th1aIf replaceafill is switching tasks, probably he should do them.16:31
replaceafilli checked the first one16:31
th1a(if he hasn't already)16:32
replaceafillour parse_date function and python's date() allows years to be even 116:32
replaceafillbut the strftime method needs 1900 or higher16:32
replaceafillweird to me :/16:32
replaceafillanyway, since the user has already the bad date in the system16:33
replaceafilli was thinking he should get a validation error when he displays the edit form16:33
replaceafilland we should not allow years < 1900 on date creation16:33
th1aSounds good to me.16:33
replaceafilli can take that one :)16:34
replaceafilli don't like the other one because it involves two different forms :)16:34
replaceafillwhen you click the (-) you lost the data in the other form16:34
replaceafilli mean you click (-) in one form, and the search is in another form16:34
replaceafilli think yvl is the right person to work on that one :)16:35
th1aOK.  ;-)16:35
yvlor we could just not do it?16:35
th1aI could make it "medium"16:35
replaceafilllosing the search in that condition it doesnt bother *me* :)16:36
* yvl too16:36
th1aI mean, I suppose it doesn't matter does it.16:36
th1aNow that I think of it.16:36
yvlmaybe in one case it could16:36
yvlif you added somebody by accident16:36
yvland want to remove16:36
yvland add the right person16:36
* replaceafill thought of the same use case!16:37
yvlbut I'd make it low priority16:37
th1ayvl: So you're saying this would be a pain to fix.16:37
th1aI'll make it medium (which means we won't think about it again for a long time).16:37
yvlok :D16:37
th1aWe may need a mass-recalibration of our bug importance at some point.16:38
th1aOK, thanks replaceafill.16:38
th1aWe have new report card designs, which I like:
th1aWe probably won't actually do the big scores at the top, but it is a nice idea.16:39
th1aI think the overall look is good.16:41
replaceafillth1a, that design will be used when we do the "CSS for PDFs" story, correct?16:41
th1aWe will have to change the layout forms aelkner to work with this.16:41
replaceafilli mean, when we clean our pdf styles16:41
th1areplaceafill:  Yes.16:41
aelknerwe don't have data for the last two columns16:41
aelkneradn yes, we need pdf styles16:42
th1aWe probably won't use the Overview by default.16:42
aelkneri was referring to Strengths and Topics to review16:42
th1aAre we looking at the same thing?16:43
replaceafilli think aelkner is looking at the first version16:43
th1aAre you looking at SchoolTool_PrintReport_3_page1.pdf16:43
aelkneryou didn't say to look at that one16:43
th1aThat was the comment I linked to...16:44
th1aOK, so there's that.16:44
th1aI think that covers everything.16:45
aelknerok, so the comments part is not part of our model, right?16:45
th1aIt is in a different place.16:45
th1aNo outline view.16:45
th1aSo we'll have to think about that a bit.16:45
*** ignas has joined #schooltool16:46
th1aOh, Justas is probably going to go to Portugal sometime in the next month or two to help get the CL update going.16:47
yvlwait what?16:47
th1aI sent you an email about that didn't I?16:47
* yvl managed to read that Gediminas is going16:48
th1aI volunteered you for a trip to Portugal, so hopefully we can make that work.16:48
yvlyes, I know16:48
th1aSo anyhow, if you DON'T want to go to Portugal at some point, we'll need to discuss that.16:49
th1aWe haven't gotten down to dates yet regardless.16:49
* yvl won't be able to go mid May I think16:50
yvlother than that, it would be nice to visit Critical Links guys again :)16:50
th1aI'm sure we can sort out a date that works.16:51
th1aThe only problem is you won't have aelkner to drive you around.16:51
th1aDo you have a driver's license, yvl?16:52
aelkneras long as he doesn't lose his wallet16:52
yvlyes th1a16:52
* th1a had forgotten about that.16:52
th1aOK, good.16:52
th1aAll right, that should do it then.16:52
th1aHave a great week and weekend guys!16:52
* th1a drops the bag of gravel.16:52
yvlthanks guys16:52
replaceafillthanks everybody16:52
aelknerthanks all, have a greate weekend16:52
aelknerth1a, replaceafill, good news, i can disable single radio buttons and submit17:21
aelkneri don't know what happened before that made me think that i couldn't17:21
aelkneri could have had a different problem and didn't realize it17:22
th1aThat's what I suspected.17:23
aelknerth1a, replaceafill, for your approval, as manager:17:30
th1aAh.  Yes, I guess you can deactivate selected checkboxes.17:31
th1aAdd to What is This?:17:32
th1a"When users log in, the will usually be directed to the tab selected in the default column.  The default tab must also be visible."17:33
th1aAnd get rid of the extra period you have in the last paragraph.17:34
*** replaceafill has quit IRC17:34
aelknerok, will do17:35
*** replaceafill has joined #schooltool17:36
replaceafillyvl, you gone?17:58
replaceafillth1a, is this a good validation error message:18:18
replaceafill'Year has to be equal or higher than 1900'18:18
th1agreater than18:19
replaceafillah ok18:19
th1areplaceafill:  I'm distracting you again... can you look at the spreadsheet?
th1aMaybe this is just a unicode problem.18:32
replaceafillah this is carlos problem, right?18:33
replaceafilli think it may be a problem with his demo types18:33
replaceafilli sent him an email, but he didnt reply18:34
replaceafilli cc'ed you on that one18:34
th1aWhat did you think it was?18:34
replaceafilli tried his same xls18:34
replaceafillbut most of my types were text18:34
replaceafilland dates18:34
replaceafilllet me see, i think i still have that instance running18:34
* replaceafill has so many instances running lately...18:34
replaceafillah yes18:35
replaceafilli used his spreadsheet to create that person18:35
replaceafilland here are my demos:18:36
replaceafillmaybe we should ask him to share his /demographics screenshot18:36
replaceafillthat would give me a better clue18:37
th1aOh, yes, we can't import some types?18:37
replaceafillwe can, but we would need to know the values he entered18:38
replaceafillwhat it seems weird to me is that he says the rest of the person gets imported fine18:39
replaceafill"The only fields that were imported were general information."18:39
th1aOK, ask him whatever you think would help.18:40
th1aI need to fiddle with the CSS now, but the SVG is pretty much there.18:47
* th1a goes to get Vivian.18:49
replaceafillaelkner, you can use $(element).is(':checked') instead of using .attr('checked') == 'checked'19:00
replaceafillyou also can use $(element).is(':disabled')19:00
aelknerah, thanks19:05
*** alga has joined #schooltool19:05
replaceafillthey're slower, but easier to read imo19:05
aelkneri guess the speed issue would matter more if the loop was longer, more selector calls19:09
*** paulproteus has quit IRC19:10
*** paulproteus has joined #schooltool19:10
th1areplaceafill:  Did you ever try the audit feature on Chrome?19:40
replaceafillth1a, no19:40
replaceafilljust came to chrome a couple of weeks ago :)19:41
th1aJust open the dev panel (inspect page element...)19:41
th1aAnd select Audits,19:41
th1aand then from the page you want Reload Page and Audit on Load.19:42
replaceafilllots of red on my gradebook view19:42
replaceafillThere are multiple resources served from same domain. Consider combining them into as few files as possible.19:42
replaceafillah come on!19:44
replaceafillA width and height should be specified for all images in order to speed up page display. The following image(s) are missing a width and/or height:19:44
replaceafillwe set it through css ;)19:44
replaceafillor no, we don't :D19:45
th1aheh heh19:45
replaceafillreminds me of the yslow extension for firefox19:46
th1aYeah.  Same idea.19:48
th1areplaceafill:  I guess paster doesn't give you much control over caching, so it probably does make more sense to do this in Apache.19:56
replaceafillth1a, yes19:56
replaceafilli was looking for a wsgi middleware solution but all of them seemed too complex19:57
replaceafillcompared to apache's two lines19:57
th1aYes... we need to make Apache fully part of apt-getting schooltool.19:57
replaceafillhhmm, not sure about that one19:58
replaceafillbut your call :)19:58
replaceafilli mean, you can use schooltool without apache19:58
th1aI mean, it may be a separate package.19:58
replaceafillah, something that creates the proper configuration for you?19:58
th1aProbably Apache should be gzipping everything.19:59
th1aSetting caching.19:59
th1aIdeally SSL...19:59
replaceafillnext week, i need to do some serious cleanup in the vps20:00
replaceafillwe only have 1.47 GB free20:00
replaceafilland my sandboxes directoy has like 14 GB!20:01
*** menesis has quit IRC20:16
th1aI may have to re-write this in javascript because it is too big.20:28
replaceafillah great...20:46
replaceafillth1a, you around?20:46
replaceafillk, let me try to sum up the warning dialog situation for the gradebook20:47
replaceafillour current way is to use a prompt, remember?20:47
replaceafilllet me set an instance to show it20:47
replaceafillif you visit that one with ff20:48
replaceafillyou get the prompt with OK, Cancel buttons20:48
replaceafilland a custom message20:48
th1anew btw20:48
replaceafillthat background reminds me of bees :)20:48
replaceafillif you visit the url with chrome20:49
replaceafillyou dont get the prompt20:49
replaceafillbecause chrome doesnt give a **** about the unload event, and doesnt allow you to customize it20:49
replaceafillso, we need to use something else20:49
replaceafillnotice the before20:50
th1aUh... ok.20:50
replaceafillbut this has a nice new problem20:50
replaceafillyou cannot have prompt buttons20:50
replaceafillOK, Cancel20:50
replaceafillthese are set by the browser20:50
replaceafillStay in the page, Leave the page20:51
replaceafill(or something like that)20:51
replaceafilli'm seeing it in spanish ;)20:51
th1aOK, fine.20:51
replaceafilland the last thing ff did:
replaceafillyou cannot customize the message anymore :(20:52
replaceafillbut i think it's a good behaviour anyway for the gradebook20:52
replaceafillkind of out of our hands though20:52
th1aIt is ok with me.20:53
th1aGets the point across.20:53
replaceafillyou'll see the new behaviour20:53
th1aProbably better than "OK" "Cancel" anyhow!20:53
replaceafillsee the page in both browsers20:54
replaceafillchrome displays the old warning message20:54
replaceafill(which we will need to change)20:54
replaceafillthe rest is browser dependent20:54
replaceafillff doesn't show the custom message, just the browser dependent stuff20:54
th1aChrome can use the same message as far as I'm concerned.20:55
replaceafillright, but without the "Click OK to save now..." right20:55
replaceafilljust "You have some changes that have not been saved"20:55
th1aMine says "This page is asking you to confirm that you want to leave - data you have entered may not be saved."20:55
replaceafilldid you reload?20:56
th1aFIrefox may be too inconsistent to match.  ;-)20:56
th1aThat's what I get from FF.20:56
replaceafillah yes20:56
replaceafillthis is my chrome:
replaceafillcustom message on top20:59
replaceafillspanish at bottom :)20:59
replaceafillok, if you're ok with this behaviour i'll go with it21:00
th1aSo Chrome we can control the message but not FF?21:00
th1aJust make them the same if we can.21:01
replaceafillwe can't :(21:01
replaceafilleither way we go with21:01
replaceafillwe get a mistmatch between the two21:01
replaceafillwe can have the prompt (ok,cancel) in ff, and not in chrome21:01
replaceafillor the custom message in chrome and not in ff21:01
th1aUse the Chrome system and make the chrome message match the FF message.21:03
replaceafillis this worth sniffing the browser?21:03
th1aI don't understand the confusion.21:03
replaceafilland setting the appropriate behaviour on each?21:03
th1aUse the chrome system and make "This page is asking you to confirm that you want to leave - data you have entered may not be saved." the message.21:04
th1aIn English, at least.21:04
replaceafillbut we wont see that in ff21:04
*** menesis has joined #schooltool21:04
th1aI copy/pasted that from FF.21:04
replaceafillgot it21:04
replaceafillthat's our new custom emssage21:05
replaceafillthanks th1a21:05
* replaceafill goes to get lunch21:08
th1aCould you throw that background into a regular instance.21:27
th1aThat I can take a look at tomorrow?21:27
aelkneryvl, ayt?22:25
* replaceafill back22:31
replaceafillth1a, kk will do22:31
replaceafillaelkner, i'm back22:31
aelkneri'm looking to create a selenium script for the server tabs, but app/stests are based on old app layer22:34
replaceafillah yes22:34
aelkneri was wondering if you thought we could scrap app.txt22:35
replaceafillnot really22:35
aelknerand change stesting.zcml to use flourish22:35
replaceafilli'd move it to a stesting-oldskin.zcml file or something like that22:35
replaceafilland would create a new stesting.zcml for flourish22:35
replaceafilli was about to do that for the ui.login(...) extension22:35
replaceafillbut didnt get there22:35
aelkneri would need to create a new stests-oldskin directory with different, right?22:39
aelknerand i could move app.txt to that directory22:39
replaceafillwhy not use the same directory and same file?22:39
replaceafillyou can have two layers in the same file22:39
replaceafillone layer picks the old skin zcml22:39
replaceafilland the other the flourish one22:40
aelknerin schooltool/app/testing, i'd need a new layer definition22:40
replaceafilllet me see the files so im not talking wrong here :)22:40
aelknerhow does the layer know which files to run?22:41
aelkneri think we need the directories to be split up to do that22:41
replaceafillsame way the gradebook does with the journal, you hard code the old ones22:41
replaceafillor you could do taht22:41
replaceafill(split them)22:42
aelknerit would be cleaner22:42
aelkneralthough i'm not sure if yvl would mind22:43
aelknerhe may prefer the hard-coded way that you referred to22:44
replaceafillyou can ask him, i'm fine either way, just think we shouldn't get rid of tests, even if they're old22:44
replaceafilland the ftests set up of the gradebook (conditionally) is not hard to understand22:45
aelkneri see how it works now, probably simpler to do it the hard-coded way22:48
aelkneri just have to add the same kind of multi-layer code with hard coded list to test_all.py22:49
aelknerand se the same no in old_tests logic, etc.22:49
aelknernot in old_tests, i mean22:49
aelknerbut anyway, thanks for the suggestion22:52
replaceafillth1a, instance with your hexes background
*** th1a has quit IRC23:20
*** replaceafill has quit IRC23:28
*** menesis has quit IRC23:33

Generated by 2.15.1 by Marius Gedminas - find it at!