| replaceafill | what do you think? :) | 00:00 |
|---|---|---|
| aelkner | and what code are you referring to that you did to make h3 hide/ove to dialog title | 00:00 |
| replaceafill | css | 00:00 |
| aelkner | call_modal_form? | 00:00 |
| aelkner | css? | 00:01 |
| replaceafill | the h3 in modal forms is hidden through css | 00:01 |
| aelkner | adn call_modal_form is the js that moves it to title | 00:02 |
| aelkner | that part yvl did, right? | 00:02 |
| replaceafill | yep | 00:02 |
| replaceafill | well, yvl put it there | 00:02 |
| aelkner | so that's what i was blaming him for :) | 00:02 |
| replaceafill | i wrote the nasty hack | 00:02 |
| replaceafill | anyhow... | 00:02 |
| aelkner | which hack, the css? | 00:02 |
| replaceafill | back to gradebook work | 00:02 |
| aelkner | could you point me to it? | 00:02 |
| replaceafill | skin/flourish/resources/form.css | 00:03 |
| aelkner | form > .viewspace > h3 { | 00:04 |
| aelkner | display: none; | 00:04 |
| aelkner | } | 00:04 |
| replaceafill | correct | 00:04 |
| aelkner | ok, well i used h2 for now to get around that | 00:04 |
| replaceafill | yeah, that's bad | 00:05 |
| replaceafill | i hope we fix it soon | 00:05 |
| aelkner | yes | 00:05 |
| aelkner | tomorrow morning we shall discuss it with yvl to come up with a plan for going forward | 00:06 |
| replaceafill | k | 00:06 |
| th1a | One issue is why does it show a box around the first year when you open it? | 00:29 |
| th1a | aelkner: Do you think you could turn this into a form with radio buttons in less than two hours? | 00:30 |
| th1a | Also, aelkner, sync from trunk so I can see the new CSS with this. | 00:30 |
| aelkner | th1a, yes i could, so i will | 00:43 |
| aelkner | do you want Submit | Cancel instead of Download | Cancel? | 00:44 |
| aelkner | keep in mind that we need to preset the first radio button to selected | 00:52 |
| aelkner | otherwise we would need to have an error message for if the fail to select one and hit Download or Submit | 00:53 |
| aelkner | then that would definitely take longer than two hours | 00:53 |
| aelkner | if on the other hand, we do set the first one to preselected it would not require and error message step | 00:54 |
| aelkner | because once a radio button is set, you can't unset it as far as i recall | 00:54 |
| *** alga has quit IRC | 01:06 | |
| *** replaceafill has quit IRC | 01:58 | |
| th1a | preset button is fine. | 02:02 |
| th1a | aelkner | 02:02 |
| th1a | Submit | Cancel | 02:02 |
| aelkner | th1a, loaded on my instance | 02:06 |
| aelkner | i anticipated you would approve preloading, so i went ahead and did it | 02:07 |
| *** replaceafill has joined #schooltool | 02:17 | |
| th1a | aelkner: Why do the years/terms have the same title? | 02:26 |
| th1a | Just the way you set them up? | 02:27 |
| aelkner | yeah, my mistake, i can change the Data.fs and ship it up | 02:27 |
| aelkner | it's a single term year | 02:27 |
| th1a | That's fine. | 02:27 |
| aelkner | don't bother changing it? | 02:27 |
| th1a | Otherwise, looks pretty good. You need to match replaceafill's button style. | 02:27 |
| th1a | Oh... | 02:28 |
| th1a | I see. | 02:28 |
| th1a | Well... | 02:28 |
| aelkner | yeah, i was looking at the css in firebug, and i don't know whether it works for modals yet | 02:28 |
| th1a | It is in the preferences modal. | 02:28 |
| aelkner | i follow the form .buttons .submit-widget parapdigm | 02:28 |
| aelkner | oh, i should check there | 02:28 |
| th1a | Let's discuss the year/term issue tomorrow. | 02:29 |
| th1a | You can go watch the game. | 02:30 |
| aelkner | ok | 02:30 |
| replaceafill | aelkner make your tables to use <thead> and <tbody> when necessary | 02:31 |
| replaceafill | for the meeting tomorrow: styling of generated content and styling manual content | 02:32 |
| * replaceafill goes to buy dinner | 02:33 | |
| *** replaceafill has quit IRC | 02:33 | |
| *** th1a has quit IRC | 04:21 | |
| *** aks has joined #schooltool | 08:46 | |
| *** yvl has quit IRC | 10:05 | |
| *** yvl has joined #schooltool | 10:10 | |
| *** alga has joined #schooltool | 11:03 | |
| *** menesis has joined #schooltool | 12:02 | |
| *** ignas has joined #schooltool | 12:19 | |
| *** krishnagiri has joined #schooltool | 13:19 | |
| *** krishnagiri has quit IRC | 13:31 | |
| *** aks has quit IRC | 14:23 | |
| *** menesis has quit IRC | 14:35 | |
| *** menesis has joined #schooltool | 15:02 | |
| *** replaceafill has joined #schooltool | 16:14 | |
| *** th1a has joined #schooltool | 16:28 | |
| th1a | hi yvl, replaceafill, aelkner, menesis. | 16:30 |
| yvl | morning guys | 16:30 |
| aelkner | morning | 16:30 |
| menesis | hi | 16:31 |
| th1a | How's it coming yvl? | 16:31 |
| replaceafill | good morning | 16:32 |
| yvl | moving forward, th1a | 16:32 |
| yvl | I'd like to finish the wizard tomorrow if the rest goes well | 16:32 |
| yvl | on a related matter: | 16:32 |
| th1a | Good news. | 16:32 |
| yvl | does anybody have any concerns related to javascript JSON library? | 16:33 |
| yvl | I mean - do you have a preferred one? | 16:33 |
| yvl | namely: | 16:34 |
| yvl | json_parse.js | 16:34 |
| yvl | json2.js | 16:34 |
| yvl | or json_sans_eval.js ? | 16:34 |
| * yvl is leaning towards json_sans_eval | 16:34 | |
| * replaceafill has never used js + json :( | 16:34 | |
| aelkner | me neither | 16:34 |
| yvl | let's go with json_sans_eval for now then | 16:35 |
| th1a | Are any packaged for Ubuntu? | 16:35 |
| yvl | and switch if it annoys us | 16:35 |
| yvl | we'll bundle local copies | 16:35 |
| yvl | people tend to link them directly in *websites* | 16:35 |
| th1a | Oh... right, javascript. | 16:37 |
| yvl | right | 16:37 |
| th1a | I'd think the libraries are pretty simple since they're just javascript data structures. | 16:37 |
| th1a | OK. Moving on... | 16:38 |
| yvl | and quite small, and in public domain | 16:38 |
| th1a | Anything else? | 16:40 |
| yvl | no at the moment | 16:41 |
| th1a | OK. I think aelkner and replaceafill have some issues to raise from yesterday's work. | 16:41 |
| replaceafill | i have one | 16:42 |
| aelkner | ' styling of generated content and styling manual content' | 16:42 |
| replaceafill | correct | 16:42 |
| replaceafill | so far i've been setting styles for generated content like z3c.form output or table formatters | 16:43 |
| replaceafill | for example table formatters spit tables like: | 16:43 |
| replaceafill | <table><thead><tbody> | 16:43 |
| replaceafill | z3c.form also generates a lot of "redundant" mark up | 16:43 |
| replaceafill | so my question is, should we define styles for generated content + manual content or | 16:44 |
| replaceafill | should we produce our manually created forms and tables to match the structure of the generated ones | 16:44 |
| yvl | well | 16:45 |
| yvl | ideally they should match | 16:45 |
| yvl | html that defines a form we want to style a certain way | 16:45 |
| yvl | should be the same, no matter if it was "generated" or copy-pasted "manually" | 16:46 |
| aelkner | sound reasonable | 16:46 |
| aelkner | sounds | 16:46 |
| replaceafill | i agree, we should make our manually created stuff to match the generated one | 16:46 |
| yvl | unless it's turns out to be too much work for some views | 16:47 |
| yvl | but since we re-make templates anyway | 16:47 |
| yvl | it should not be a common case | 16:47 |
| replaceafill | yvl the other issue is the title hack for dialogs :) | 16:48 |
| aelkner | also, as uch as possible, we should be using templates from flourish/skin | 16:48 |
| aelkner | yes, the title hack | 16:48 |
| yvl | right | 16:48 |
| yvl | it's a good question what to do with that one | 16:49 |
| yvl | on one hand we can easily add dialog titles to link viewlets that spawn them | 16:49 |
| yvl | but it just doesn't feel right | 16:50 |
| aelkner | why not | 16:50 |
| yvl | say you want somewhat dynamic title | 16:51 |
| aelkner | oh, right | 16:51 |
| yvl | and you have a page that calculates it's title | 16:51 |
| th1a | Dynamic title bar for a modal? | 16:51 |
| replaceafill | i assume we put the title of the dialog in the z3c.form class that renders the dialog content | 16:51 |
| yvl | you need to move that logic to the viewlet | 16:51 |
| yvl | well, replaceafill dialog might not be a form | 16:52 |
| replaceafill | yvl correct | 16:52 |
| yvl | so I just haven't decided on that one yet | 16:53 |
| yvl | I think at some point modal versions of the views could carry some | 16:53 |
| yvl | json payload | 16:53 |
| th1a | We don't need to overthink this. | 16:54 |
| yvl | I know | 16:54 |
| yvl | but I rather we should | 16:54 |
| aelkner | why can't dialog_title be an attribute of the viewlet | 16:54 |
| yvl | it can | 16:54 |
| aelkner | something that can be set in zcml | 16:54 |
| aelkner | or overridden with @property in the viewlet class | 16:55 |
| yvl | it can | 16:55 |
| yvl | I'm just saying it does not feel right | 16:55 |
| aelkner | again, why not? | 16:55 |
| th1a | I'm not feeling that feeling. | 16:56 |
| yvl | I know | 16:56 |
| yvl | probably none of you get that feeling ;) | 16:56 |
| replaceafill | i do if you do :) | 16:56 |
| yvl | :D | 16:56 |
| yvl | let's put it this way | 16:56 |
| th1a | Dynamic dialog titles doesn't strike me as important. | 16:56 |
| yvl | I know | 16:56 |
| aelkner | what ever happened to YAGNI | 16:57 |
| yvl | guys | 16:57 |
| yvl | we can really do whatever there | 16:57 |
| aelkner | in other words, if we can't define a problem, then it doesn't exist | 16:57 |
| yvl | and change our minds later on | 16:57 |
| yvl | it's not like we write code in stone | 16:57 |
| aelkner | we've been doing that with everytthing else, why not here? | 16:57 |
| yvl | I'm not sure we actually grasp JS coding that well at the moment | 16:58 |
| yvl | anyway | 16:58 |
| th1a | I'm on aelkner's side on this one. | 16:58 |
| yvl | I know | 16:58 |
| yvl | so I'm ok with setting it from viewlets | 16:59 |
| th1a | OK. Settled. | 16:59 |
| th1a | Moving on... | 16:59 |
| th1a | Any other issues aelkner & replaceafill? | 16:59 |
| th1a | Or yvl, menesis? | 16:59 |
| aelkner | if we do that, then we remove the magic <h3> becomes title, then display: none magic, right? | 16:59 |
| menesis | no | 16:59 |
| th1a | Who are you answering, menesis? | 17:00 |
| menesis | I have no issues :) | 17:00 |
| yvl | aelkner - we obviously add another parameter named title in both methods in flourish.js, then we manually pass it | 17:01 |
| aelkner | sounds right | 17:01 |
| aelkner | the viewlet pt can do the passing, right? | 17:01 |
| aelkner | using the class attribute, i assume | 17:02 |
| yvl | aelkner, check out the modal_form_link.pt | 17:02 |
| aelkner | yvl, would you be able to do this today before knocking off? | 17:02 |
| aelkner | looking... | 17:02 |
| yvl | yes | 17:02 |
| aelkner | that's the template i was referring to | 17:02 |
| yvl | then again, other views that do not use that viewlet | 17:03 |
| yvl | will need to pass their own titles | 17:03 |
| aelkner | report/templates/f_report_link_manager.pt needs to change, too | 17:03 |
| yvl | yes | 17:03 |
| yvl | that's the one I'm talking about | 17:03 |
| yvl | and others to come, of course | 17:04 |
| aelkner | so we are on the same page | 17:04 |
| yvl | sure :) | 17:04 |
| aelkner | no pun intended :) | 17:04 |
| yvl | :DDDD | 17:04 |
| * yvl just got that :DDD | 17:04 | |
| aelkner | i vote for having yvl fix that real quick before leaving today, and replaceafill and i can enjoy the fruits :) | 17:05 |
| yvl | will do | 17:05 |
| aelkner | we will need to remove display: none from flourish.css and rework views not to have <h3> | 17:06 |
| replaceafill | hhmm | 17:06 |
| yvl | I'll leave that part for you guys ;) | 17:06 |
| aelkner | sure thing | 17:06 |
| replaceafill | just the modal dialogs, right? | 17:06 |
| yvl | yes | 17:07 |
| aelkner | we are only talking about them, right | 17:07 |
| replaceafill | regular z3c.forms still need the display:none hack | 17:07 |
| replaceafill | we can set it back for forms "inside" jquery ui dialogs | 17:08 |
| aelkner | unless we create a new version of the form macro for flourish | 17:08 |
| yvl | sure, replaceafill | 17:08 |
| aelkner | how about we create a modal_form macro? | 17:08 |
| yvl | ui-dialog class if memory serves well | 17:08 |
| yvl | why would we do that? | 17:09 |
| yvl | we were talking about html being same for same things | 17:09 |
| aelkner | current form macro puts an <h3> n the form, display: none hacks around that | 17:09 |
| aelkner | why not just leave out the <h3> for modal forms | 17:09 |
| yvl | we can do that | 17:10 |
| replaceafill | label = None? | 17:10 |
| aelkner | since we are going to put the title in the modal dialog title | 17:10 |
| yvl | flourish has a copy of form macros, IIRC | 17:10 |
| aelkner | thing is, we need two versions | 17:10 |
| aelkner | non-modal forms still need the <h3> | 17:10 |
| replaceafill | aelkner we can do that with appropriate css | 17:11 |
| replaceafill | forms that are INSIDE a dialog display the h3s | 17:11 |
| replaceafill | forms that are not dont | 17:11 |
| aelkner | no | 17:11 |
| aelkner | that's the hack, we agreed the hack was bad | 17:12 |
| th1a | wtf is this h3 issue? | 17:12 |
| aelkner | let's think about this | 17:12 |
| aelkner | if i want to put a heading in a modal dialog | 17:12 |
| aelkner | right now i have tp not make it an h3 | 17:12 |
| aelkner | because some hack is going to make it disappear | 17:12 |
| replaceafill | aelkner because the css is wrong | 17:12 |
| aelkner | well, how would it be right? | 17:12 |
| th1a | Are we arguing over something we already decided to fix? | 17:13 |
| aelkner | not arguing, just asking | 17:13 |
| th1a | Are we asking about something we already decided to fix? | 17:13 |
| aelkner | we haven't decided aything, that's wh i'm askingy | 17:13 |
| aelkner | replaceafill, please lay out exactly what you intend to do with the css | 17:14 |
| replaceafill | yvl you agree with doing it through css? | 17:14 |
| yvl | set a css "form-label" class to the form's label probably | 17:14 |
| replaceafill | yes | 17:14 |
| yvl | and not displaying it in modals | 17:15 |
| aelkner | so any h3 that is not class="form-label" will display | 17:15 |
| yvl | yes | 17:15 |
| replaceafill | hhmm yvl i was thinking display all in modals | 17:15 |
| replaceafill | hide only in regular z3c.forms | 17:15 |
| yvl | well I don't know what th1a wants there | 17:16 |
| yvl | we can do whatever | 17:16 |
| replaceafill | :) | 17:16 |
| yvl | it is styling... :) | 17:16 |
| th1a | I don't know what h3 has to do with anything. | 17:16 |
| th1a | Shouldn't it just be div class form-label and forget about it. | 17:16 |
| th1a | ? | 17:16 |
| th1a | Or is it 1998 again? | 17:17 |
| yvl | that's what we're trying to do | 17:17 |
| yvl | set the class | 17:17 |
| yvl | and let you decide if forms have the whatever text is now set as their labels | 17:17 |
| yvl | visible in all views / visible only in modals or non modals / removed completely | 17:18 |
| replaceafill | i'd say, lets not hide anything and fix the regular z3c.forms to not have labels | 17:18 |
| aelkner | +1 | 17:18 |
| yvl | it's one of the things you and replaceafill go through really fast :) | 17:18 |
| th1a | The modal label should be a special case. | 17:18 |
| th1a | Handled through zcml or whatever. | 17:19 |
| aelkner | replaceafill, when you say 'fix the regular z3c.forms' you really mean fix the form macros | 17:19 |
| yvl | yes | 17:19 |
| replaceafill | no, i meant the z3c.form classes | 17:20 |
| aelkner | we need to consider the modal and non-modal cases together | 17:20 |
| replaceafill | but i'd have to test that | 17:20 |
| th1a | So... dialog label is a special div that is not rendered outside a dialog? | 17:20 |
| th1a | Is that ok? | 17:20 |
| aelkner | and extrapolate the pattern from there | 17:20 |
| aelkner | no div for dialog label | 17:21 |
| aelkner | it is passed to the call_dialog js method | 17:21 |
| yvl | replaceafill, yes, that's another way of doing that | 17:21 |
| replaceafill | yvl i think it's easier, css hacks wont bite us | 17:21 |
| replaceafill | i mean, not easier | 17:21 |
| replaceafill | we would need to review the z3c.form classes :) | 17:22 |
| replaceafill | but it's not hard | 17:22 |
| replaceafill | and dialogs can do whatever they want | 17:22 |
| yvl | or we can remove the label rendering completely | 17:22 |
| yvl | from the macros | 17:22 |
| aelkner | yes, it's the macros | 17:22 |
| replaceafill | tomorrow we could say "we need a label in this form..." | 17:22 |
| yvl | true | 17:22 |
| replaceafill | and we would have to do this then | 17:22 |
| yvl | hence - th1a's choice | 17:22 |
| aelkner | obviously the macros depend on the view classes | 17:23 |
| aelkner | but first the macros need fixing | 17:23 |
| aelkner | then anything we need to add to the view classes, we can | 17:23 |
| replaceafill | aelkner we can do it without touching the templates | 17:24 |
| yvl | yes, there is actually at least 3 simple solutions to this | 17:24 |
| yvl | seriously | 17:24 |
| aelkner | well, simple is key | 17:24 |
| aelkner | especially since it is going to be omnipresent | 17:25 |
| * yvl does not see this as an issue worth talking about for almost half an hour | 17:26 | |
| replaceafill | :) | 17:26 |
| yvl | just decide how all forms in ST will look and make the right solution | 17:26 |
| yvl | easy as that :) | 17:26 |
| replaceafill | th1a can i do this? | 17:26 |
| th1a | please. | 17:27 |
| th1a | Moving on... | 17:27 |
| replaceafill | thanks | 17:27 |
| th1a | replaceafill: How's Cambodia? | 17:27 |
| replaceafill | th1a last report to go | 17:27 |
| replaceafill | i'll finish today | 17:28 |
| th1a | OK. Good. | 17:28 |
| replaceafill | th1a i plan to: 1/2 day css, 1/2 day cambodia | 17:28 |
| th1a | OK. | 17:28 |
| th1a | aelkner: Do you have any loose ends at this point? | 17:29 |
| th1a | Want to start on /demographics? | 17:29 |
| aelkner | already started looking at it, have lots of questions for you | 17:29 |
| replaceafill | that will be an interesting view! | 17:29 |
| aelkner | after the meeting? | 17:29 |
| th1a | There isn't that much too it!. | 17:30 |
| th1a | OK, give me 10 minutes to make some brunch. | 17:30 |
| * th1a drops the bag of gravel. | 17:30 | |
| th1a | Thanks guys! | 17:30 |
| aelkner | ok, see you in ten | 17:30 |
| * replaceafill goes to remove the infamous css hack... | 17:31 | |
| * th1a is back. | 17:42 | |
| aelkner | th1a, let's go over demographics, one step at a time | 17:43 |
| aelkner | first we have the person index.html view | 17:43 |
| th1a | I'm talking about the management view. | 17:44 |
| aelkner | oh? | 17:44 |
| th1a | as in /demographics | 17:44 |
| aelkner | what user action? | 17:45 |
| th1a | Not $PERSON/demographics. | 17:45 |
| th1a | LIke go to localhost:7080/demographics | 17:45 |
| aelkner | users don't type urls | 17:45 |
| aelkner | at least the app shouldn't require it | 17:45 |
| th1a | Going from manage. | 17:45 |
| th1a | OK, starting at the beginning... | 17:46 |
| aelkner | ok, not having a manage tab, we could force us to type the url | 17:46 |
| th1a | We are done with person views and moving to management views. | 17:46 |
| aelkner | ok | 17:46 |
| th1a | We aren't doing the manage view in general yet because it is one of the hardest. | 17:46 |
| th1a | So we're going to go through some of the simpler ones. | 17:46 |
| th1a | Like /demographics | 17:47 |
| aelkner | we do have an Application tab | 17:47 |
| th1a | We don't really care how you get there at the moment. | 17:47 |
| th1a | We don't care! | 17:47 |
| aelkner | but that's not the right place for it, right? | 17:47 |
| th1a | Who knows? | 17:47 |
| th1a | It is irrelevant at the moment. | 17:48 |
| aelkner | so first thing is we need a flourish view of IDemographicsFields index.html | 17:49 |
| *** menesis has quit IRC | 17:50 | |
| aelkner | what did you mean by "Change title to "Demographics and Personal Information"" | 17:50 |
| aelkner | where? | 17:50 |
| th1a | On /demographics | 17:51 |
| th1a | Instead of "Demographics Container" | 17:52 |
| aelkner | ok | 17:53 |
| aelkner | so i know what needs to be done first, so i'm doing it now | 17:53 |
| aelkner | couldn't we just add a Demographcs link to the Application tab for ease of testing? | 17:54 |
| th1a | No. | 17:54 |
| th1a | Can't you add a bookmark if it bothers you? | 17:55 |
| aelkner | you like typing urls, don't you? | 17:55 |
| *** menesis has joined #schooltool | 17:55 | |
| aelkner | yeah, so i'll need a book mark for both instances, local and demo | 17:55 |
| aelkner | whatever | 17:55 |
| th1a | We're working on the look and feel of the app, so we can't just drop things around. | 17:56 |
| aelkner | ok, now that i know that you meant IDemographicsFields and not IDemographicss, i know what to do for now | 17:56 |
| th1a | OK. | 17:56 |
| th1a | One thing I didn't note is that the index view isn't going to do reordering. | 17:57 |
| th1a | Essentially the current view will become a "Reorder" action. | 17:57 |
| aelkner | so index.html is just a table rendering | 17:58 |
| aelkner | and buttons will take the user to edit views | 17:58 |
| th1a | The links in the table will take you to an edit view, probably a modal. | 17:59 |
| th1a | I don't think we really need view views if we can fit enough in the table. | 17:59 |
| th1a | We kind of need to see what fits. | 17:59 |
| aelkner | ok | 18:00 |
| replaceafill | this is what i had in mind for the h3 problem: http://bazaar.launchpad.net/~replaceafill/schooltool/flourish/revision/2952 | 18:07 |
| replaceafill | if your z3c.form has a label it will be rendered, so if you dont want the label dont set it or set it to None | 18:08 |
| th1a | I still don't even know how h3 got dragged into this at all. | 18:08 |
| replaceafill | :D | 18:08 |
| th1a | What is the form label? | 18:09 |
| replaceafill | remember the old UI, forms had a gray title bar with black text | 18:09 |
| * replaceafill referes to the old UI as in several years ago... | 18:09 | |
| th1a | Oh... ok, I get it. | 18:09 |
| replaceafill | we dont use that anymore | 18:10 |
| th1a | I see. | 18:10 |
| th1a | Yes, there are a million ways to fix this. | 18:10 |
| th1a | I think I should be kept out of this discussion though. | 18:11 |
| replaceafill | :) | 18:11 |
| aelkner | replaceafill, do you want me to weigh in here? | 18:12 |
| replaceafill | of course | 18:12 |
| aelkner | what is diff for again? | 18:13 |
| aelkner | form > .viewspace > h3 { | 18:13 |
| aelkner | you got rid of display: none | 18:13 |
| aelkner | when was this? | 18:13 |
| replaceafill | yep | 18:13 |
| replaceafill | like 10 minutes ago... | 18:13 |
| aelkner | ah, found the date | 18:14 |
| replaceafill | :) | 18:14 |
| th1a | lol | 18:15 |
| aelkner | +1 on the solution | 18:15 |
| replaceafill | th1a i'll change the request student report views to match the "generated" layout | 18:16 |
| aelkner | so if i want to have an h3 in my modal form, i'm free to without having it be either hidden or duplicated | 18:16 |
| replaceafill | and will remove the h2 workaround aelkner had to do | 18:17 |
| replaceafill | aelkner correct | 18:17 |
| aelkner | is yvl making the call_modal change? | 18:17 |
| th1a | OK. | 18:17 |
| yvl | yes, please wait | 18:17 |
| aelkner | ok, looks like you two will have solution very soon | 18:17 |
| yvl | done | 18:18 |
| replaceafill | :| | 18:19 |
| yvl | wait | 18:19 |
| yvl | I did the thing with the modal title | 18:19 |
| yvl | nothing on h3 | 18:19 |
| replaceafill | ? | 18:19 |
| yvl | bzr pull | 18:22 |
| replaceafill | ah, nice | 18:24 |
| replaceafill | ah! | 18:29 |
| replaceafill | yvl we need to use translate before passing a _(..) :) | 18:29 |
| replaceafill | or i get Change preferences for ${person_full_name} | 18:30 |
| yvl | ? | 18:31 |
| yvl | where? | 18:31 |
| yvl | it's called Change Preferences | 18:31 |
| yvl | no for ${} part | 18:32 |
| replaceafill | http://69.164.203.135:6660/persons/alvaro | 18:32 |
| replaceafill | that's old version of trunk btw | 18:32 |
| replaceafill | the title was customized to include the person's name | 18:32 |
| replaceafill | so i subclassed ModalFormLinkViewlet | 18:33 |
| replaceafill | and added: | 18:33 |
| replaceafill | @property | 18:33 |
| replaceafill | def dialog_title(self): | 18:33 |
| replaceafill | person = self.context | 18:33 |
| replaceafill | title = _(u'Change preferences for ${person_full_name}', | 18:33 |
| replaceafill | mapping={'person_full_name': "%s %s" % (person.first_name, | 18:33 |
| replaceafill | person.last_name)}) | 18:33 |
| replaceafill | return translate(title, context=self.request) | 18:33 |
| yvl | hmm, good point | 18:34 |
| replaceafill | i just return the _(...) it doesn't get translated | 18:34 |
| replaceafill | in the js | 18:34 |
| yvl | probably serialization should do translate | 18:34 |
| yvl | yes | 18:34 |
| yvl | somehow | 18:34 |
| yvl | thanks for the bug report ;)))) | 18:35 |
| replaceafill | :D | 18:35 |
| replaceafill | i'm ok with using translate | 18:35 |
| replaceafill | explicit is bett... | 18:35 |
| replaceafill | :P | 18:35 |
| yvl | well | 18:36 |
| yvl | flourish/tal.py | 18:36 |
| yvl | JSONEncoder should take optional request parameter | 18:36 |
| yvl | and translate messages if it has reuqest | 18:36 |
| yvl | in the same place where it does generator listing | 18:37 |
| yvl | I'll do that at some point | 18:38 |
| yvl | (and yes, here go the dynamic titles ;P ) | 18:38 |
| yvl | ok | 18:38 |
| * yvl has to go | 18:38 | |
| yvl | good luck guys! | 18:38 |
| replaceafill | thanks yvl | 18:38 |
| replaceafill | th1a you there? | 18:43 |
| * th1a is pacing. | 18:48 | |
| replaceafill | th1a never mind sorry | 18:48 |
| replaceafill | i found it | 18:49 |
| *** alga has quit IRC | 19:08 | |
| *** ignas has quit IRC | 19:11 | |
| replaceafill | th1a could you check http://69.164.203.135:6660/persons/alvaro/reports | 19:24 |
| replaceafill | and http://69.164.203.135:6660/persons/alvaro | 19:24 |
| replaceafill | Preferences | 19:24 |
| replaceafill | (i mean the dialogs) | 19:24 |
| th1a | replaceafill: Checking... | 19:34 |
| replaceafill | th1a wait! | 19:34 |
| replaceafill | :D | 19:34 |
| replaceafill | let me revert a change | 19:34 |
| replaceafill | i was testing something | 19:34 |
| replaceafill | done | 19:35 |
| th1a | Look ok to me. | 19:37 |
| th1a | Am I looking for something in particular? | 19:37 |
| replaceafill | dialog titles | 19:38 |
| replaceafill | they're generated with yvl fix now | 19:38 |
| replaceafill | passing it explicitly in js | 19:38 |
| th1a | Could they say "Request a Student Report Card" | 19:38 |
| th1a | instead? | 19:38 |
| replaceafill | sure, let me change it | 19:39 |
| replaceafill | actually, the title of the dialog is taken from the reportLink directive :( | 19:43 |
| replaceafill | if i change the title of the directive the link gets changed here too: http://69.164.203.135:6660/persons/alvaro/reports | 19:44 |
| replaceafill | refresh to see what i mean | 19:44 |
| th1a | Eh. That's a little more magical than I'd like, but I guess we'll live. You can revert it. | 19:45 |
| replaceafill | reverted | 19:46 |
| replaceafill | ok, pushing the style changes | 19:46 |
| replaceafill | changes pushed to trunks | 19:49 |
| aelkner | guys, if the dialog title can be driven by the reportLink directive, i would say that is good magic | 20:16 |
| aelkner | replaceafill, do i understand it correctly? | 20:17 |
| replaceafill | aelkner it's used for two things | 20:17 |
| replaceafill | the links in the /reports page | 20:17 |
| replaceafill | and the dialog title | 20:17 |
| aelkner | sounds great, doesn't it | 20:17 |
| aelkner | nothing better than reuse | 20:17 |
| replaceafill | what if you want them different? | 20:18 |
| replaceafill | :) | 20:18 |
| aelkner | overrides | 20:18 |
| aelkner | :) | 20:18 |
| replaceafill | overrides what? | 20:18 |
| replaceafill | i mean, different link title and different dialog title | 20:18 |
| aelkner | we can add an override to the reportLink directive if you want it different | 20:18 |
| aelkner | but if you mean dynamic, then that has to be solved by the view class | 20:19 |
| replaceafill | if you change title="..." in the reportLink directive you change both | 20:19 |
| aelkner | yeah, i was suggesting if we had dialog_title="" | 20:19 |
| aelkner | as an override | 20:19 |
| replaceafill | :S | 20:19 |
| replaceafill | i feel like we're going to start adding dialog_title for everything | 20:19 |
| aelkner | but otherwise, reusing the title is ok | 20:19 |
| replaceafill | but th1a said we're ok, so... | 20:19 |
| aelkner | for reports, we probably will have a consistent title matching the link | 20:20 |
| aelkner | why not | 20:20 |
| * replaceafill shrugs... | 20:20 | |
| aelkner | anyway, as you said, whatever | 20:20 |
| th1a | I don't want to sink too deeply into this. Nobody reads title bars anyhow. | 20:21 |
| aelkner | for now, reusing the title allows us to move more quickly, so i say stick with that | 20:22 |
| replaceafill | we are aelkner ;) | 20:22 |
| aelkner | good then :) | 20:22 |
| aelkner | i'm just always gong to vote for efficient development patterns | 20:22 |
| th1a | Why don't we start this conversation over from the beginning? | 20:23 |
| aelkner | i thought we were done | 20:23 |
| th1a | I'm joking, aelkner. | 20:23 |
| aelkner | you're so wry | 20:23 |
| * replaceafill looks up "wry" | 20:25 | |
| replaceafill | :O | 20:25 |
| * replaceafill has learned a new word | 20:26 | |
| aelkner | th1a, i did the first step which was to create flourish versions of old views, pushed to my instance | 20:35 |
| aelkner | i'd like to look at them together to discuss details | 20:35 |
| th1a | OK. | 20:36 |
| th1a | We're starting over from scratch. | 20:37 |
| th1a | Forget this exists. | 20:37 |
| th1a | move it to reorder.html | 20:37 |
| aelkner | yes, reoorder.html | 20:38 |
| aelkner | index.html will be a table | 20:38 |
| aelkner | as you suggested in TODO | 20:38 |
| th1a | Yes. | 20:38 |
| aelkner | how about we collapse these: | 20:39 |
| aelkner | All (i.e., checked if no limits) | Teach. | Stud. | Admin | 20:39 |
| aelkner | into just Limit | 20:39 |
| aelkner | and list the groups (most of the time empty) | 20:39 |
| aelkner | that would solve the width problem | 20:39 |
| th1a | I'm not sure that helps much -- or that we really have a problem. | 20:40 |
| aelkner | for resources, it wouldn't be Teacher, Student, etc. anyway | 20:40 |
| aelkner | it's Location, Equiptment... | 20:41 |
| th1a | Well, that's a different view. | 20:41 |
| th1a | Next project! | 20:42 |
| th1a | How you doing, aelkner? | 21:05 |
| aelkner | receiving many calls from family for my birthday, so nothing new to show you yet | 21:37 |
| replaceafill | happy birthday aelkner! :) | 21:37 |
| aelkner | if that's not fishing, i don't know what is :) | 21:37 |
| aelkner | but thanks | 21:38 |
| th1a | happy birthday aelkner. | 21:38 |
| aelkner | thanks | 21:38 |
| th1a | Your present was me taking your side in an arugment. | 21:38 |
| replaceafill | :)) | 21:38 |
| th1a | My most precious gift, after my virginity. | 21:39 |
| replaceafill | :)))) | 21:39 |
| th1a | But what aelkner really wants is for me to be less of a smartass. | 21:40 |
| aelkner | th1a, i did notice you're taking my side, and i did almost faint :) | 21:41 |
| replaceafill | :D | 21:41 |
| aelkner | but i am glad that i got your *second* most precious gift | 21:42 |
| th1a | As am I. | 21:44 |
| * replaceafill goes to get lunch | 21:47 | |
| th1a | Are you working on the table, aelkner? | 22:08 |
| aelkner | th1a, loaded in my instance, reorder.html still brings up old view | 22:13 |
| aelkner | i chose x for checked | 22:13 |
| th1a | I forgot the . in Admin. | 22:13 |
| aelkner | it is a view only table, not an edit table, so i didn't put <input type="ckeckbox"> | 22:13 |
| th1a | replaceafill, http://69.164.203.135:36660/demographics/@@index.html | 22:14 |
| th1a | aelkner: Right. | 22:14 |
| * replaceafill is back, typing with one hand :) | 22:15 | |
| aelkner | replaceafill, i pushed my changes to trunk | 22:15 |
| th1a | Can we make tooltips (title) come up for the column headers? | 22:15 |
| aelkner | replaceafill, i only know of title attribute for <a> elements | 22:16 |
| replaceafill | aelkner is this a tableformatter? | 22:16 |
| aelkner | what is the general way to do that? | 22:16 |
| aelkner | no not table formatter | 22:16 |
| replaceafill | aelkner most modern browser will show the title="..." attribute as a tooltip | 22:17 |
| replaceafill | for any element | 22:17 |
| replaceafill | try setting titles for your <th> | 22:17 |
| replaceafill | and youll see | 22:17 |
| aelkner | any element, cool | 22:17 |
| replaceafill | well, most elements ;) | 22:17 |
| aelkner | th1a, what titles wold you want for the column headings | 22:17 |
| aelkner | replaceafill, yeah, probably the ones we need, right? | 22:18 |
| replaceafill | aelkner correct | 22:18 |
| replaceafill | titles work on <th> | 22:18 |
| th1a | Hm. | 22:19 |
| aelkner | if you look at basicperson/interfaces.py | 22:20 |
| th1a | There is some problem explaining this logic. | 22:20 |
| aelkner | there are descriptions for title, name and required | 22:20 |
| th1a | Yeah, don't use those. | 22:20 |
| aelkner | The title of this Field Description | 22:20 |
| th1a | Don't use those. | 22:20 |
| th1a | Forget they exist. | 22:20 |
| aelkner | ok, i didn't think you'd like them :) | 22:20 |
| th1a | You have no idea how much I hate them. | 22:21 |
| aelkner | just list the descriptions here and i'll put them in the title attributes | 22:21 |
| th1a | Well... we need to think about this a little more. | 22:21 |
| aelkner | your thoughts? | 22:21 |
| th1a | A field is for all groups by default, but if you select one limit group, it toggles to only that group. | 22:22 |
| aelkner | it can be for multiple groups | 22:22 |
| aelkner | it's a list | 22:22 |
| th1a | Yes, but selecting all those groups is not the same as "all" | 22:22 |
| aelkner | limit_keys | 22:22 |
| th1a | Is the weird part. | 22:23 |
| aelkner | good point | 22:23 |
| aelkner | selecting all WOULD have the same effect as none | 22:23 |
| aelkner | but it would show up as the different ones being checked | 22:23 |
| aelkner | however, i don't think that is a problem | 22:23 |
| th1a | Well, we should make this clearer in the edit form, | 22:24 |
| aelkner | i believe the information is there for the user to figure out | 22:24 |
| th1a | but in terms of the table... | 22:24 |
| aelkner | what fields are limited | 22:24 |
| aelkner | go on | 22:24 |
| th1a | Actually, "all" should probably be "other" | 22:24 |
| th1a | and if it is "all" then each group plus other should be checked. | 22:24 |
| th1a | Otherwise, just the groups. | 22:25 |
| th1a | I think that's the right logic. | 22:25 |
| th1a | From the user's point of view. | 22:25 |
| th1a | I'm talking about the table view now. | 22:26 |
| aelkner | i don't know why you think that is clearer, i think it is clearest right now | 22:26 |
| aelkner | all means all | 22:26 |
| aelkner | not all means what's checked | 22:26 |
| aelkner | if all three are checked | 22:26 |
| aelkner | well | 22:26 |
| aelkner | the user can work out what that means | 22:26 |
| th1a | It should be explicit. | 22:26 |
| aelkner | it's not pretending to be anything it isn't | 22:26 |
| th1a | If all is checked, then also all three should always be checked. | 22:27 |
| th1a | It is not really clear what the difference between "all + s + t + a" and "s + t + a" is. | 22:27 |
| th1a | "s + t + a + other" is clearer. | 22:28 |
| aelkner | well, here's the thing | 22:28 |
| aelkner | the user needs to, at some point, grapple with the concept of limit_keys | 22:28 |
| aelkner | if not with those workds | 22:28 |
| aelkner | but the concept is that you don't have to think | 22:29 |
| aelkner | about anything unless you want to limit a field | 22:29 |
| aelkner | so the default is all, no tiking | 22:29 |
| aelkner | thinking | 22:29 |
| th1a | The form needs to be a bit more clear to first give you a choice between no limit and some limits. | 22:29 |
| aelkner | the problem with outgenerated forms | 22:30 |
| aelkner | auto | 22:30 |
| aelkner | we could code the flourish version to be custom | 22:30 |
| aelkner | are you referring to the field edit view? | 22:30 |
| th1a | Yes. | 22:30 |
| aelkner | or add, right | 22:30 |
| aelkner | so anyway, not your concern on the view class, template, etc. so never mind | 22:31 |
| aelkner | but you would like a better explanation on the edit view of limit_keys | 22:31 |
| th1a | We can't have "other" as a choice in the form because it is a different implementation. | 22:31 |
| th1a | To have a field *only* for things not in the other groups. | 22:31 |
| *** ignas has joined #schooltool | 22:32 | |
| th1a | Maybe just clearer text would do it. | 22:32 |
| aelkner | how about Limited | Teach. | Stu... | 22:32 |
| aelkner | limited check only if others are checked | 22:32 |
| th1a | You know, let's just do that. | 22:32 |
| th1a | I'll come up with better text. | 22:32 |
| aelkner | what i just suggested, do that? | 22:33 |
| th1a | But what I do want is the table to have Stud. | Teach. | Admin. | Other | 22:34 |
| th1a | Don't change the edit form at all. | 22:34 |
| th1a | I'll just change the text. | 22:34 |
| aelkner | What does OTher mean? | 22:34 |
| th1a | I mean, update it and make it modal. | 22:34 |
| th1a | So the logic you'll need in the view is: | 22:34 |
| th1a | If "all" then all four are selected. | 22:35 |
| th1a | If any limit keys are used, then other is empty and the selected groups are selected. | 22:35 |
| th1a | Does that make sense to you? | 22:35 |
| aelkner | no | 22:35 |
| aelkner | other does not ring as a concept | 22:35 |
| aelkner | so it confuses the naming of the other things | 22:36 |
| aelkner | how about limited, teach, stu...? | 22:36 |
| aelkner | limited is what it is | 22:36 |
| aelkner | limited | 22:36 |
| aelkner | then teach, stu are the limits | 22:36 |
| th1a | Happy birthday, aelkner, I guess that does make sense. | 22:36 |
| aelkner | simple, no? | 22:37 |
| replaceafill | :) | 22:37 |
| th1a | OK, do that. | 22:37 |
| th1a | I think we may end up with a subheader here. | 22:37 |
| th1a | Just to give us another line of explanation. | 22:38 |
| th1a | Let's just get the basic forms down first. | 22:38 |
| aelkner | let's wire the add, edit, reorder, yes? | 22:39 |
| aelkner | i need to know how you would like to have the user find those views | 22:41 |
| th1a | The add should go in the sidebar. | 22:41 |
| th1a | Add | 22:41 |
| aelkner | I think i need to add a viewlet manager for action links for that page | 22:41 |
| aelkner | replaceafill could help me with that if i need it | 22:42 |
| th1a | - Text field | 22:42 |
| th1a | etc. | 22:42 |
| aelkner | what shold the title of the manager be | 22:42 |
| aelkner | Add is one of the actions under it | 22:42 |
| th1a | clicking on the title of a field should give you an edit modal. | 22:42 |
| aelkner | ok, the edit modal | 22:43 |
| aelkner | so there are two tasks, add in the sidebar, and edit links that are modals | 22:43 |
| aelkner | but getting back to the sidebar | 22:44 |
| th1a | And I'm leaning toward just putting misc things in an "Actions" section in the sidebar. | 22:44 |
| aelkner | what should the section of the sidebar's title be | 22:44 |
| th1a | That's where Reorder fields would go. | 22:44 |
| aelkner | and then under it, Add | 22:44 |
| th1a | No, Add is a section. | 22:44 |
| aelkner | Actions | 22:44 |
| th1a | (Like in persons) | 22:44 |
| th1a | Actions | 22:45 |
| th1a | - Reorder fields | 22:45 |
| aelkner | so sections are Add, Actions | 22:45 |
| th1a | replaceafill: Got that? "Actions" is the catchall section for the sidebar. | 22:45 |
| th1a | Yes. | 22:45 |
| aelkner | what does Add have under it so far? | 22:45 |
| aelkner | did you say already? | 22:45 |
| aelkner | Text Field | 22:45 |
| replaceafill | th1a i had bet that the word Actions would come up in that space :) | 22:45 |
| aelkner | Bool Fields | 22:46 |
| aelkner | wait | 22:46 |
| th1a | Well, not "bool" | 22:46 |
| aelkner | Bull | 22:46 |
| replaceafill | :| | 22:46 |
| aelkner | under Add we have four links: | 22:46 |
| replaceafill | True/False? | 22:46 |
| aelkner | Text Field | 22:46 |
| replaceafill | Yes/No | 22:46 |
| aelkner | Date Field | 22:46 |
| replaceafill | sorry | 22:46 |
| aelkner | Yes/No field | 22:46 |
| aelkner | Enumerate Type Field?!!! | 22:47 |
| aelkner | the last one is obviously wrong | 22:47 |
| replaceafill | we should also change Enum in the table :) | 22:47 |
| th1a | True/False field? | 22:47 |
| aelkner | ok | 22:47 |
| aelkner | and the last one? | 22:48 |
| replaceafill | th1a sorry they're called Yes/No | 22:48 |
| th1a | OK, we can keep that. | 22:48 |
| aelkner | ok | 22:48 |
| aelkner | th1a, enums? | 22:48 |
| th1a | What's in the interface now is fine. | 22:48 |
| th1a | Selection list field | 22:48 |
| aelkner | oh, yes, the action buttons in the old skin tell the answer | 22:48 |
| aelkner | New Selection List Field | 22:49 |
| replaceafill | aelkner for an example of how to set the sidebar look at basicerson/browser/flourish.zcml viewlet named person_container | 22:49 |
| aelkner | ok, thanks | 22:50 |
| replaceafill | since you'll probably need two viewlet managers, also check "person-links" and "person-settings-links" | 22:51 |
| *** alga has joined #schooltool | 22:54 | |
| *** menesis has quit IRC | 22:56 | |
| *** replaceafill has quit IRC | 23:10 | |
| *** replaceafill has joined #schooltool | 23:18 | |
| *** menesis has joined #schooltool | 23:44 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!