IRC log of #schooltool for Thursday, 2011-06-30

*** th1a has quit IRC00:14
*** ignas has quit IRC00:34
*** ignas has joined #schooltool00:44
*** ignas has quit IRC01:22
*** replaceafill has quit IRC01:34
*** menesis has quit IRC03:09
*** alga has quit IRC03:50
*** aks has joined #schooltool06:16
*** aks has joined #schooltool06:16
*** alga has joined #schooltool09:36
*** alga has quit IRC11:08
*** menesis has joined #schooltool11:35
*** ignas has joined #schooltool12:39
*** aks has quit IRC14:19
*** menesis has quit IRC14:22
*** ignas has quit IRC14:54
*** ignas has joined #schooltool14:56
*** menesis has joined #schooltool15:05
*** replaceafill has joined #schooltool16:04
*** th1a has joined #schooltool16:27
* th1a is getting his summer schedule dialed in.16:27
th1aUp at 7:30, hit the skatepark for about 45 minutes, back home, shower, log on IRC 9:27.16:28
th1ahi yvl, menesis, aelkner, replaceafill.16:29
replaceafillgood morning/afternoon16:29
th1aHow was your birthday, aelkner?16:29
th1aEnjoying the Phillies?16:29
yvlmorning guys16:30
aelkneryes, the phillies have given me a nice bday16:31
th1aOK, first off, I want thank you guys for your work this month.16:31
th1aUnless we all fall to pieces in the next six weeks, this is going to be the biggest, most impressive release of SchoolTool ever.16:32
th1aAnd the timing will be perfect.16:32
* th1a notes we will not be falling to pieces in the next six weeks.16:32
th1aAnd, beyond verbal praise, you'll all get bonuses this month.16:33
th1aI'll email you individually about the particulars.16:33
* yvl seconds the kudos16:33
yvlnice work, guys!16:33
th1aWell, "all" meaning yvl, aelkner and replaceafill.16:33
th1amenesis got a nice bonus for the release.16:34
th1aAnd has had a relatively relaxing June.16:34
th1aNo slight intended menesis.  ;-)16:35
menesisexcept for two days when the server went down16:35
th1aYeah... we haven't been getting those warnings lately, right?16:35
th1aWe should try to move before the October release.16:36
th1aOK, summer vacation.16:37
menesisI get those warnings every few weeks16:37
menesiswhat I need first is access to DNS settings for schooltool.org16:38
th1aOK.  I'll look into that menesis.16:39
replaceafill+1 on us managing the dns :)16:39
menesisthen I can at least add a fallback IP pointing to schooltool.pov.lt16:39
th1aVacation:  I'm going to be at the in-laws from July 11-15 and my parents around July 26 to August 1.16:40
th1aBut I'll be online daily throughout.16:40
aelknerup in Maine?16:40
th1aThat's pretty similar to Justas's plans.16:41
aelknerbeautiful in the summer16:41
th1aJennifer's parents are in Maine and mine are in PA.16:41
th1aI guess I don't feel particularly strongly about coordinating vacations one way or another.16:42
th1aI don't like to have nobody working on SchoolTool for a week in case something comes up.16:42
th1aSo just let me know aelkner and replaceafill when you decide what to do.16:43
replaceafilli'll keep working during the summer16:43
aelkneri have no vacation plans as of yet, but i'll let you know if i decide to take off16:43
th1aMoving on...16:44
th1ayvl:  How's the wizard coming?16:44
th1a(if it is a wizard)16:45
yvlit is :)16:45
yvlhit a few snags today16:45
yvlbut now over them, moving on16:45
yvlthe non-modal version of it is almost done16:45
yvlI'll work on making it modal tomorrow16:45
yvlspent (little) time trying to decide if I want JSON to serialize dates automatically or explicitly16:46
yvlI think we'll end up with almost manual conversion16:46
yvlstring format as per RFC3999 IIRC16:47
yvlkind of had to choose between this and ASP.NET style16:47
yvlso if anyone wants to communicate dates / times to javascript from the view16:47
yvlrefert to ttwizard.py16:47
yvlor me :)16:48
th1abtw, do you want to discuss your change of calendar widgets in Cambodia, replaceafill?16:48
replaceafillah sure, it was a small change16:48
replaceafillpeople in cambodia complained about the jquery ui calendar widget16:49
replaceafillsaying that it's difficult to navigate to distant years16:49
replaceafilllike if you want to go to 1991 or so16:49
replaceafillyou have to click click click the arrows :)16:49
replaceafillbut the jquery ui widget has options for that16:50
replaceafillyou can display the months and a set of years in dropdowns16:50
replaceafill    $(".date-field").datepicker({16:50
replaceafill        dateFormat: 'dd-mm-yy',16:50
replaceafill        changeMonth: true,16:50
replaceafill        changeYear: true,16:50
replaceafill        yearRange: 'c-20:c+05'16:50
replaceafill    });16:50
yvl(can you please point at the current working branch at some point? )16:50
replaceafillyvl ah sure16:51
replaceafillyvl maybe next week you can review it16:51
replaceafilli talked to th1a we should do it at some point16:51
replaceafillit's a mess i'm still cleaning btw :)16:51
yvldon't worry about the mess ;)16:51
th1aPerhaps we should at least use that widget whenever we're entering date of birth, if not always.16:52
replaceafillthe jquery docs for the change is at
th1aI don't know if it is disadvantageous in regular cases for some reason.16:52
replaceafillfor the cambodia case i also applied a little css:16:53
replaceafill.ui-datepicker select.ui-datepicker-month,16:53
replaceafill.ui-datepicker select.ui-datepicker-year {16:53
replaceafill    height: 33px;16:53
* aelkner is back in five minutes16:53
replaceafillthe khmer fonts make the month dropdown higher than the year's16:53
replaceafillso they looked uneven16:53
replaceafillthat's the cambodia vps, if you click that link you'll get redirected to the add view for school years16:54
replaceafillyou can see the widget there16:54
replaceafillplease don't add a school year ;)16:54
yvlok :)16:56
* aelkner is back16:56
yvlthe calendar is glitching for some reason in FFox 3.516:56
th1aI guess timetables don't actually use the calendar widget anyhow, so I'm just diverting off topic anyhow.16:56
replaceafillyvl really? :(16:57
replaceafilli'm using 3.5.16 and it doesnt...16:57
yvlwell - nice changes in any case16:57
replaceafilli think it's a valid argument (the one about the clicks)16:58
yvlwe should definitely add year/month ranges16:59
th1aFinding someone's birthday is a different problem than a date this year.16:59
th1aSo yes, something must be done.16:59
yvlwe can always fine-tune year ranges for specific forms of course17:00
yvland it even updates the dropdown if you click out of the year span17:00
yvlright, let's move on17:00
th1aBack to yvl.  Sorry to interrupt.17:00
yvlthat's ok, I'm done actually17:01
th1aSo we should be able to have a crack at the wizard tomorrow?17:02
* yvl is a bit hesitant to merge timetabling to flourish branch17:03
yvlbut it's better to merge earlier than later17:03
th1aYes, we need to do it.17:03
yvljust FYI17:03
yvlI broke something when merging17:03
yvli.e. we'll find bugs17:04
yvlthe branches diverged, and it was a bit too big chunk to review properly17:04
yvlbut nothing serious I think17:04
yvlby the way17:05
yvlcan I temporarily add the modal dialong link somewhere?17:05
yvlas in - in a random place17:05
th1aFor... new timetables?17:05
yvlto call up the wizard17:06
yvljust for you guys to see it17:06
yvlunless I also flourish the container tomorrow17:06
yvlwell, now that I said it17:07
th1aJust don't stick it somewhere where we have to look at it all the time.17:07
yvlthat's what crossed my mind just now17:07
th1aI told aelkner he couldn't jam a convenience link in the top bar.17:07
th1aLooking forward to it.17:08
th1aThanks yvl.17:08
th1aaelkner, anything new to report?17:09
th1aI hope you weren't sitting at home coding all night.17:09
aelkneri got some in while enjoying the game :)17:09
aelknerhow about that Worley17:09
aelkneryou  guys are injured, so...17:09
aelkneranyway, i created the two link managers, Add and Actions17:10
aelknermy instance is updated with them17:10
aelkneri changed the title to and edit link in the table17:10
aelknerand the edit view now redirects to the table on Apply as well as Cancel17:11
aelknerthe add views still redirect to index.html of the new object on Add17:11
aelkneri was going to ask, should it go back to the table?17:11
aelkneralso, they are not modal yet17:11
aelknerthat's next17:11
aelkneri was hoping that yvl would stick around another hour17:12
aelknerso i could ask aything about current modal paradigm if i need to17:12
th1aIs that pushed to the test server?17:12
aelknerth1a, should we redirect to table on succesfful add?17:12
replaceafillone comment about forms:17:13
aelknerand do we even need index.html of field now that we have the table?17:13
replaceafillshould all forms subclass the expanded page?17:13
replaceafillfor instance, shows the sidebar17:13
aelknerexpanded page has no sidebar?17:13
aelkneri was asking before (a couple days ago)17:14
aelknerwhy is it called expanded if it has less?17:14
aelknerit's not important, i'm just curious17:15
aelknerreplaceafill, ayway, it's going to be modal, so...17:15
aelkneryvl, are you around another hour or so?17:15
yvlaelkner, as it was said before, the content area is expanded17:15
yvlsure, aelkner17:16
aelknerhow, expanded?17:16
aelknerby not including the sidebar17:16
yvltakes up space where sidebar was17:16
yvlbut I'm ok with renaming to something else17:17
aelknerth1a, should i get rid of index.html of fields and make edit view the index.html view?17:17
aelkneryvl, how about WidePage17:17
aelknerit's not important though17:17
aelknerlet's forget about the ame for now17:18
th1aaelkner:  Well... I wouldn't change the name in case we decide we do need a regular index.html view view later.17:18
aelkneri'm done my report17:19
th1a(where later might be this afternoon)  ;-)17:19
th1aThanks aelkner.17:19
th1areplaceafill, ?17:19
replaceafillth1a i finished cambodia's tasks17:19
replaceafilli can work on flourish again17:19
th1aAh.  So you need tasks?17:20
th1aStart with the password form.17:20
th1aAnd we'll go from there.17:20
th1aAlso, the spacing in the footer got spread out a bit when we jiggered the spacings.17:21
th1aSo basically I'll keep replaceafill and aelkner busy today.17:21
replaceafillah, true17:21
th1aOK, thanks guys.17:21
* th1a drops the bag of gravel.17:21
yvlthanks th1a17:23
yvlaelkner, so - modal dialogs17:23
yvlajax'y form submitting is WIP at the moment17:24
* th1a goes to make brunch.17:24
yvlbon appetite, th1a17:24
yvlso making them open modal should be quite easy17:25
yvlbut there's nothing IIRC done on submitting and error validation17:25
* replaceafill goes to get breakfast17:30
aelkneryvl, so are you working on some wiring for modals i should know about17:30
yvlbon appetite, replaceafill17:31
yvlaelkner, I think I should :)17:31
aelkneri like the idea :)17:31
aelknershould i wait until tomorrow to do the modals then?17:31
yvlgive me 30-40 minutes...17:31
aelknerah, perfect17:31
aelknerlet's talk then17:31
aelknerth1a, demo instance now redirects to table on successful add18:00
th1aCan you easily make the reorder page use a table?18:02
aelknerhow woul you like it to look?18:03
th1aJust... tabular.18:03
aelknerwe have three things, the dropdown, for reordering18:03
aelknerthe checkbox, for deleting18:04
aelknerand the title link18:04
th1aJust a table above the buttons.18:04
th1aAnd all the buttons should have the standard style now.18:04
aelknermake those three things the three columns of the table?18:04
th1aNo header.18:04
aelknerok, should be no big deal18:04
yvlsorry aelkner18:04
yvlhacky approach didn't work out18:04
yvlso nothing more today18:05
yvlyou can make the links open modal dialogs18:05
aelknerok, we can table the modals for now18:05
th1aSo what can't we do with modals at this point?18:05
th1aWe don't have ajaxy validation?18:05
yvladd buttons won't work18:05
yvlor rather work weird18:05
yvlwon't reload into the modal dialog18:05
aelknercan you have seomthing for us by tomorrow morning?18:05
th1aNo biggie.18:06
yvlbut you can make them open modals, just mimic the preferences button18:06
aelkneropen modals?18:06
aelknerwhat do you mean by that?18:06
yvlclick link -> opens a modal dialog18:06
th1aPop one open that doesn't actually work.18:06
yvlbut renders correctly visually18:06
th1aWe don't need that now though.18:07
aelkneryeah, it can wait until tomorrow18:07
yvlall right then, see you guys soon ;)18:07
aelknerhave a good one18:07
th1aThanks yvl.18:07
yvlthanks guys18:08
yvlgood luck!18:08
th1areplaceafill: ayt?18:08
replaceafillth1a yes18:08
th1aLook at
replaceafillth1a i'm reviewing a merge request by menesis18:08
replaceafillah ok18:08
th1aare you looking at it replaceafill?18:09
th1aLet's go over some general points.18:09
th1aThis kind of form shouldn't have a sidebar.18:09
th1arelated question: What's the deal with pages that just have a little gray rectangle at the top of the sidebar?18:10
th1aI mean, I know they should have no links, but we need to be rid of the box.18:10
replaceafillth1a we have a default padding for the sidebar18:11
replaceafillthat's what you see18:11
replaceafilleven if it's empty18:11
replaceafilllet me check the page template18:11
th1aHow do we hide/get rid of it.18:11
th1aWe got rid of it in the persons/add views.18:12
* replaceafill looks for a page with empty sidebar18:12
replaceafillth1a yes, because the forms use the expanded page class18:12
replaceafillnow i can't find a page with empty sidebar...18:13
th1aperhaps it should be the NoSidebar page class.18:13
replaceafillth1a can you point me to a page with empty sidebar please?!!?18:14
replaceafilli can't find any :(18:14
replaceafillah /reports18:14
replaceafillconditioned the sidebar18:17
replaceafill<div class="refine" tal:define="refine view/providers/page_refine|nothing"18:18
replaceafill     tal:condition="refine">18:18
replaceafilli guess this way forms don't have to subclass expanded page anymore just to get rid of the sidebar18:19
* replaceafill tests it18:19
aelknerth1a, +1 on the class name18:19
th1aIs it too late to just change that replaceafill?18:19
th1aIt is pretty confusing.18:19
replaceafillth1a you mean the class name?18:19
replaceafillhhm i dont' think so, few classes are using it18:21
th1aWhy don't we just do that then?18:21
replaceafill12 references only18:21
th1areplaceafill:  Let's discuss the rest of this before you do that.18:23
replaceafillah... i was already doing it :D18:24
th1aaelkner: Do you follow the point about the sidebar?18:24
replaceafillfor example is a regular page now18:24
th1a(not being there)18:24
replaceafillwith that change we probably wont need the NoSidebar class18:24
th1aWell, that's simple enough.18:24
replaceafillyes, unless there are viewlets registered for that refined manager the sidebar wont be there18:25
replaceafillok, let's disscuss the rest18:25
th1aDo you understand why we don't want it there, aelkner?18:25
th1aIn the meantime...18:25
aelknersorry, wasn't following the conversation, looking back at it now...18:25
aelknerth1a, we all agreed to changing the class name to avoid confusing while discussing which classes to use18:28
replaceafilloops, typo on my instance :)18:28
aelkneris there anything else i missed?18:28
th1aI'm just saying, do you understand that pages like this should not have sidebars?18:28
th1aWhat should be up there and how?18:28
aelknerspecifically for demos or in general?18:29
th1aOr should we just wait until we have a manage page.18:29
th1aFor this page.18:29
th1aThe demographics page, the reorder fields page.18:29
aelknerSchool -> Demographic Fields?18:30
* replaceafill thinks we should work breadcrumbs last18:30
replaceafillafter we have most parts working18:30
replaceafilljust my $0.0218:30
th1aAlso, You could argue this is more site settings.18:30
aelknerreplaceafill, are breadcrumbs in a state of flux?18:31
th1aThese are things that have to be resolved.18:31
th1aI'd say skip it since we don't know the root.18:31
replaceafillaelkner ?18:31
th1aThey work for persons18:31
aelknerreplaceafill, 'after we have most parts working'18:32
aelknerwas that about nreadcrumbs?18:32
replaceafillaelkner yes18:32
th1aMost parts of the manage/setting views.18:32
th1aIs I think the context.18:32
th1aOK, moving on...18:32
th1aformatting drop downs.18:32
th1aNot too much on the subject on p. 22.18:33
replaceafillno :(18:33
th1aDid we already change the CSS for these at all?18:33
th1aWhat am I looking at now?18:33
* replaceafill looks18:34
th1aI guess this is the first time we've done drop downs in flourish?18:34
replaceafillth1a no18:34
replaceafilli mean, yes first time18:34
replaceafillno, we dont have styles yet18:34
replaceafillff 3.5 and chrome differences18:36
th1aSO they aren't styling them very agressively.18:36
th1aShould we just add the "Focused input" CSS on p. 22?18:37
replaceafilljust two styles in
replaceafillwidth and vertical-align18:37
replaceafillth1a we have focused input18:38
replaceafillfor textlines18:38
th1aLooking at the wrong thing.18:38
th1aText input/select fields on p. 22.18:38
th1aJust has font-size and and color.18:38
th1aSo you could set that but, essentially, nothing to see here.18:38
th1aWhat's the style of the text here (ID, ethnicity, etc)?18:39
replaceafillsimple link18:40
replaceafillcolor and text-decoration=none only18:40
replaceafillno font-size for example (because we removed it)18:41
th1aOK, well, essentially we don't want text just floating like this.  Put it in a table, aelkner.18:41
th1aI suppose the point is this text doesn't really have a style, which should be a red flag.18:42
replaceafillth1a well, it's just <div><a>...</a></div>18:42
th1aIt should always have some kind of specific role: paragraph, header, list item, etc.18:42
th1aTable text, form label, etc.18:43
th1aFollowing me, aelkner?18:43
th1aThere's no such thing as "just text."18:43
th1aAnd when in doubt: tables.18:44
th1aThe buttons need to be styled.  Shouldn't that be automatic?18:44
replaceafillagain, they're just <input>s in a <form>18:45
replaceafillfor them to be styled need to be placed in a:18:45
replaceafill<div class="buttons"> container18:45
replaceafillor <div class="controls">18:45
replaceafillbtw, we should get rid of one...18:45
replaceafillnot one button, i mean one of those containers...18:46
replaceafillaelkner do we really need this in the templates:18:46
th1aAlso, the table should have title and ID columns (title first), and neither of them need to be links.18:46
replaceafill<tal:dummy condition="view/update"> </tal:dummy>18:46
th1abtw aelkner just did what I told him to do.  I'm not picking on him!18:47
th1aEven though it seems like it.18:47
replaceafilldoes reorder.html work?18:48
th1aIt used to.18:48
replaceafilli set placeofbirth to 118:48
replaceafilland it gets back to 418:48
aelknerreplaceafill, it never worked18:49
aelknerthat is, the number is off by one18:49
aelknerif you change to 3, it will put it in slot 218:49
aelknerthat would be a bug from the old skin, not flourish18:49
th1aWhy does it do that?18:49
replaceafilldoesnt work at all18:50
aelknerzero-based vs one-based i'm guessing18:50
replaceafillif i set 4 to be 3, gets back to 318:50
replaceafilli mean, 418:50
aelknerwhat about setting 4 to 118:50
aelknerdoes it go to 2?18:50
replaceafillnothing goes nowhere18:51
aelkneror does setting it to 2 go to 1?18:51
aelknerok, i'll look into it18:51
aelknerbut you guys were asking question/making comments before18:51
aelknerone at a time18:51
aelknerth1a, what text needs to go in a table?18:51
aelknerreplaceafill, +1 on deciding between controls and buttons18:51
aelknerwe can wait for yvl to discuss this18:52
aelknerth1a, i'll put the buttons in one of the containers for now18:52
replaceafillaelkner use buttons18:53
th1aThe table should have Order | Title | ID18:53
aelkner<div class="buttons"> is the container div18:53
aelknerreplaceafill, ok18:53
aelknerreplaceafill, did you rename ExpandedPAge to NoSidebarPage yet?18:53
aelknerit sounded like you were in the middle of doing it before18:54
replaceafilli was in the middle... :)18:54
replaceafilli'm still in the middle...18:54
aelknerth1a, Order | Title | ID as headings or just the order of the columns?18:54
aelknerand what about the checkbox?18:55
replaceafillth1a we're asumming javascript enabled in the browser, correct?18:55
replaceafillwhy do we need the two buttons in reorder.html?18:55
aelknerth1a, what about my question?18:56
aelknerreplaceafill, we don't18:57
th1aOh... hm...18:57
aelknersince the reorder happens upon changing the dropdown18:57
th1aI haven't been thinking about the delete aspect of this.18:57
th1aDo we have to have two buttons?18:58
th1aIf you reorder and hit delete, does nothing happen?18:59
th1aAnd if you check to delete and hit apply nothing happens?18:59
replaceafillyeah, delete is broken too18:59
th1aCan we have one submit button that does both?19:00
th1a(and works)19:00
replaceafillshouldn't Delete be on a "Manage fields" view or something?19:01
replaceafillnot on "Reorder fields"19:01
replaceafillmaybe "Rearrange fields"19:01
th1aWell, yes.19:02
th1aI was kind of overlooking that whole aspect.19:02
th1aBut we can change the link and page title.19:02
replaceafillth1a what about Delete buttons in each row?19:02
replaceafilllike in relationship views19:02
replaceafillto delete19:02
aelkneri loaded a couple fixes into the instance19:03
th1aMaybe I need to actually try this form too.19:03
aelkner1) the buttons are in a buttons div19:03
aelkner2) the reorder form action make reordering work again19:03
aelknerstill one-based vs zero-based19:03
th1aWait... what does "Apply" do?19:03
aelknerdelete crashes19:03
th1a(in theory)19:03
aelknerApply does noting19:04
replaceafillth1a in theory19:04
replaceafillapply works for no javascript scenario19:04
replaceafill(i think)19:04
replaceafillyou select the values in the dropdown19:04
replaceafilland dont get redirected19:04
th1aApply is "Done"19:04
aelknerreplaceafill, i think you're right about apply19:04
replaceafillApply should redirect to the same page19:05
replaceafillDone redirects to another one, right?19:05
aelknerwe must assume javascript for now on, so that button has no use19:05
aelknerDone could go back to container view19:05
aelkneri meant Apply had no use, just in case the thread got confusing here19:06
th1aIn theory, this is changing the order in the database as soon as you change the drop-down?19:06
replaceafillth1a correct19:06
aelknerin practice19:06
th1aCould it not do that?19:06
replaceafillthen you'd need Apply ;)19:06
aelkneri went to the doctor and said 'it hurts when i do this'19:06
aelknerknow what he said?19:06
aelknerth1a, so no submit on change and keep apply?19:07
th1abacking up...19:07
th1aTrying to remember some principles here.19:07
th1aOK.  Delete.19:07
aelkneryeah, let's deal with delete19:07
th1aHere's the thing I'm forgetting.19:07
th1aWe don't want to do delete this way.19:07
th1aSo we switch to a delete icon in the table rows.19:08
th1aReorder live (as now)19:08
replaceafillyay "minus" buttons!19:08
th1aand have a done button.19:08
th1aDone link!19:08
th1aThat's it.19:08
aelkneri figured we were heading there19:08
aelknerto repeat19:09
th1aSo Order | Title | ID | Delete19:09
aelknergo on19:09
th1aThose are the columns.19:09
th1aDelete has icons.19:09
aelknerlike relationship views, right?19:09
aelknerdelete icons19:10
aelknersorry, thought that was a ?, not a Y19:10
aelknera question about delete (here or in relationship views)19:10
aelkneryvl always clamours for confirmation step19:11
aelknerin the past, at least19:11
aelknerwhat's your feeling?19:11
th1aDon't do it yet.19:11
th1aWe can do it with jquery if we want.19:11
aelknerif we could come up (later) with a modal for confirmation19:11
aelknerthat wold be good19:12
aelkneranyway, directly delete for now19:12
aelknerand directly reorder19:12
aelknerand Done is the only button, taking user back to table19:12
th1aLink, not button.19:12
aelknerabout the four columns19:13
th1aThe relationship management views are your guide style-wise.19:13
aelknertitle and id, neither are links?19:13
aelknerno need to be able to edit from here?19:13
th1aI don't think it is helpful in this case.19:13
replaceafillaelkner please do me a favor19:14
replaceafilluse <table class="demographics-reoder-table">19:14
replaceafilland <th class="id">19:14
replaceafill<th class="delete">19:14
aelknerwhat's with the minus signs, btw?19:15
aelknerreplaceafill, do you realize that if we don't keep consistent with using _ or -19:15
aelknerthen people like me waste needless time choosing the wrong ne19:15
aelknerfrom time to time19:15
aelknerthings like that do matter, you know19:16
aelknerdeveloper productivity and all19:16
replaceafillgood point19:16
aelkneri'd choose _ over minus because it is used for python varaibles19:17
aelknerso it's consistent even across longuages19:17
aelknerbut at least let's choose one19:17
aelknerwe can talk about wich one with yvl tomorrow19:17
replaceafilli'd do too19:17
replaceafillgo with '_'19:17
aelknerok, we can agree on that for now, great19:17
aelknerso you want me to add that class to the table19:18
replaceafilland classes for the <th>19:18
aelknerwhat's up with that, styling column widths?19:18
aelknerwhere's the css?19:18
replaceafillwe don't have it yet19:18
replaceafillit'll be there if we think we need it19:19
replaceafilljust put the styles for now19:19
replaceafillsorry, the classes not the styles19:19
aelknertable: demographics_reoder_table19:19
aelknerth, column1: ?19:19
aelknerth, column2: ?19:19
aelkneryou tell me19:19
replaceafillwhat are the columns again?19:20
aelknerOrder | Title | ID | Delete19:20
replaceafillorder, title, id, action19:20
replaceafilland we should use Remove instead of Delete19:21
replaceafillright th1a?19:21
th1aAh.. is that what we did before?19:22
th1aWell, in that case we weren't literally deleting the person.19:22
th1aSo it was more accurate.19:22
replaceafillah ok19:22
th1aIf you remove Jeff Elkner as a contact you aren't deleting him.19:22
th1aIn this case you are deleting the field.19:23
replaceafillso Delete means gone forever19:23
replaceafillgot it19:23
th1aMore to the point, you're deleting the object.19:23
replaceafillwe should use different icons...19:23
th1aYou don't delete a relationship.19:23
aelknerwhat about th class names?19:23
th1aIt isn't a temporal distinction, but one of type.19:23
replaceafillaelkner i typed them above19:23
th1aType not permanence.19:24
aelknerremoving a relationship19:24
replaceafillaelkner order, title, id, action19:24
aelkneri can name classes that generically?19:24
aelknerjust because you will use css rules?19:24
replaceafillaelkner you're setting a class on the table19:25
replaceafillwe're setting classes on almost all the tables19:25
aelknerdemographics_reoder_table title{19:26
aelkner      some css19:26
aelkner       }19:26
replaceafilldont forget the dots starting the class names ;)19:26
replaceafill.demographics_reorder_table .title19:26
replaceafillbut yes19:26
aelkneri see19:27
aelknerso gong forward, as long as we have some container class for our local css situation19:27
aelknerlike demographics_reorder_table19:27
aelknerwe are free to use generic (i.e. short and easy to use) class names19:27
aelknerfor anything element contained therein19:28
aelknersince the css rules will sort it out19:28
replaceafillit depends on how the table looks19:28
aelknergo on19:28
replaceafillif we can let it to the browser...19:28
replaceafillfor example19:29
replaceafillin some of the relationships views19:29
replaceafillhave first name, last name, relationship, action19:29
replaceafilland the table below just first name, last name, action19:29
replaceafillthey looked funny with no styles19:29
replaceafillso, i set widths for some columns19:30
replaceafillthey still look funny, but less :)19:30
aelknerwell, i anticipated the need for column styles for widths in tables in general19:31
replaceafillit's difficult to do it generally19:31
aelknerbut i was wondering about the coding pattern19:31
replaceafillsince tables have so little space and different columns19:31
replaceafillyour table won't be at all like: first_name, last_name, action19:32
replaceafillth1a my tasks for the rest of the day: rename the expanded page, change our styles to use "_" instead of "-", review menesis merge request (which includes hiding empty rows in person accordions) and the password form19:34
th1aSounds good, replaceafill.19:35
menesismy merge is a few very simple changes, I just didn't want to interfere19:35
replaceafillmenesis not at all19:35
replaceafilli'll set it up so th1a see it19:35
th1aaelkner:  Basically, your next task is the same thing for "Resource attributes"19:35
th1aI never want to hear the term "resource demographics" again!  ;-)19:36
menesisI saw you talking about password form, but I just did that a few minutes earlier :)19:36
aelknerth1a, :)19:36
replaceafillmenesis thanks :)19:36
aelknerResource custom attributes?19:36
aelknerjust throwing it out there19:36
replaceafillresource demographics is banned link "action buttons" :D19:37
aelkneraction links, right19:37
replaceafillaelkner i guess you missed my comment:19:40
replaceafilldo we really need <tal:dummy condition="view/update"> </tal:dummy> in the new templates?19:40
aelknerum, maybe not, which one?19:43
aelkneri mean, when update needs to be alled?19:43
aelkneris it always called now?19:43
replaceafillflourish pages do that for you19:43
aelknerok, i'll remember that, thanks19:43
aelknerth1a, if i'm changing the title link to now be two columns, title and id, neither links19:51
aelknerwouldn't it help for the tale to have headings?19:51
th1aYes, it should.19:51
th1aIt has gotten more complicated.19:52
replaceafillth1a question19:58
replaceafilldo you want the sidebar rendered in the reorder view19:58
replaceafillthey should only be available in /demographics, correct?19:59
replaceafillwtf?!?! i'm trying to check my email typing: manager/schooltool20:00
replaceafillaelkner you should limit the demographics_fields and demographics_actions managers to the /demographics view20:01
replaceafilljust adding: view=".demographics.FlourishDemographicsView"20:01
replaceafillto the viewlet directive20:02
replaceafillchanges pushed to trunk: "Changed ExpandedPage class name to NoSidebarPage. Also conditioned sidebar rendering"20:07
*** menesis has quit IRC20:09
replaceafillth1a new task for me: make the error messages in forms to look the same without extra markup20:20
th1asounds  good replaceafill20:27
replaceafillchange pushed to trunk: "Removed label from contact edit form and styled contact forms errors"20:33
* replaceafill realizes jquery and zc.table use - for classes...20:59
* th1a goes to see if he can get some new glasses.20:59
replaceafillfor tomorrow meeting: should we change our css class names to use _ instead of -21:00
*** menesis has joined #schooltool21:01
*** ignas has quit IRC21:25
aelknerth1a, new reorder view load in demo server22:02
aelknerbtw, the change order thing works perfectly22:02
aelknerso i guess the whole zero-base/one-based discussion was way off base :)22:03
aelknerperhaps i misunderstood the behaviour at a time when it wasn't working for other reasons22:03
aelknerbut it works fine now22:03
replaceafillaelkner remember to set the sidebars only for the /demographics view22:09
replaceafillnice work on the reorder.html btw :)22:09
aelknerhow do i set the sidebars only for the one view?22:11
aelkneri didn't see that in the person-container case22:11
replaceafilli told you before.. :/22:11
replaceafilljust adding: view=".demographics.FlourishDemographicsView"22:12
aelknerin the manager, right?22:12
replaceafillto the demographics_fields and demographics_actions managers22:12
aelknerreplaceafill, now it has the blank grey sidebar22:14
replaceafillhave you sync WITH trunk?22:14
aelknernot yet22:14
replaceafillit should be gone when you sync22:15
aelknerloaded in the server22:19
replaceafilli applied the part of menesis patch that hides empty fields in accordions22:28
aelknerdo i need to sync again?22:29
replaceafillaelkner no, this is not in trunk yet22:29
aelkneri pushed my changes to trunk22:33
replaceafillth1a we need to fix the bound contact page (contact information on persons)22:37
* replaceafill goes to get lunch22:40
* th1a is back.22:41
th1a20/25 vision.22:41
* replaceafill stops from going for lunch22:41
replaceafillth1a a couple of questions22:41
replaceafillshould "password edit" be modal?22:42
th1aNo... we though it would be weird since it logs you out, right?22:42
replaceafillit depends22:42
replaceafillnot if you're the manager22:43
replaceafillwhich brings me to my second question22:43
replaceafillmaybe we need a "change my own password" form and a "reset the password for this user" form22:43
th1aAh, yes.22:43
replaceafillchange my own password should ask you for your current password22:43
replaceafilland the two new passwdx22:43
*** menesis has quit IRC22:44
replaceafillreset the password for this user should be for admins only22:44
replaceafillrequiring just the 2 new pass22:44
replaceafillchange my own password should warn you about the log out22:45
th1aYou can have that project replaceafill.  ;-)22:45
replaceafilllabel for the "reset the password for this user" form?22:46
replaceafillin Settings in the person index?22:46
replaceafillor Actions? ;)22:46
th1aI think it can have the same label but different behaviours.22:48
th1aBut the form should be... informative.22:48
replaceafillsame label? like:22:49
replaceafill- Preferences22:49
replaceafill- Password22:49
replaceafill- Password22:49
replaceafilli meant the link for the form22:49
* replaceafill just read his own question...22:49
replaceafilli mean the title for the link to the reset password form22:50
th1aI know.22:50
th1aYou just have to not duplicate it if the active user is looking at his own page.22:50
replaceafillah, smart link22:51
th1aI think you can do that kind of logic with some marbles and tinkertoys.22:51
th1aI can probably get those bolted onto the server.22:51
replaceafilllast unnanounced question22:52
replaceafilli merged menesis fix about hiding empty fields in accordions22:52
th1aYes, looks good.22:52
replaceafillit helped me to find out that we need to fix contact info for persons22:52
replaceafillwe have contact info on contacts22:53
replaceafillbut check Sally Cunninham22:53
replaceafillin alvaros page22:53
replaceafillSally is a person22:53
replaceafillwho is also a contact22:53
replaceafillpersons can have "bound" contact info22:53
replaceafillor "self"22:53
th1aOh, right, yes, we forgot that!22:53
replaceafillhow do we get to that form_22:54
replaceafillfrom the person view?22:54
th1aWell, it could just be an action on manage contacts.22:55
replaceafillare we going to add an accordion for that?22:56
th1aOr it could be listed as an editable default contact if you wanted a shortcut.22:56
th1aI mean, we could.22:56
th1aBut in K-12 schools you rarely actually use it.22:56
replaceafillah ok22:56
th1aLet's start with it as an action on manage contacts.22:57
th1a  - New Contact22:58
th1a  - hm...22:58
replaceafillok, i'll add it to my queue, will go for lunch23:02
* replaceafill goes away for 1h23:02
th1a  -- $Person as Contact?23:03
replaceafillseems strange23:03
th1aIt is all a bit strange.23:03
th1aI don't want to add an accordion that will be useless most of the time.23:04
replaceafilli agree23:04
th1aAlthough perhaps several of them will be for specific users.23:04
replaceafillwhat if we mix contact data with the General information data?23:05
replaceafillin the first accordion?23:05
replaceafillwe hide emtpy fields now anyway23:05
th1aYeah, but we don't want to encourage people to do contacts incorrectly either.23:05
th1aThat's the catch.23:05
th1atbh $PERSON as Contact might be best.23:06
replaceafillah ok, i'll use that23:06
th1aI'd actually rather have it be a little confusing than lead people to use the application incorrectly.23:06
replaceafillactually, looking it all in the "manage contact" view "add $person as contact" makes sense23:08
th1aIt is accurate.23:09
* th1a goes to make dinner.23:13
*** replaceafill has quit IRC23:33

Generated by 2.15.1 by Marius Gedminas - find it at!