| *** replaceafill has quit IRC | 00:25 | |
| *** replaceafill has joined #schooltool | 00:31 | |
| *** replaceafill has quit IRC | 00:48 | |
| *** replaceafill has joined #schooltool | 01:02 | |
| th1a | replaceafill: ayt? | 02:23 |
|---|---|---|
| replaceafill | th1a yes | 02:23 |
| th1a | What if we just added a delete action to the person edit? | 02:24 |
| th1a | As the way to do that. | 02:24 |
| replaceafill | hhmm | 02:25 |
| replaceafill | delete button on edit form? | 02:25 |
| replaceafill | sounds weird... | 02:25 |
| replaceafill | why not on /persons? | 02:25 |
| th1a | Why there? | 02:25 |
| th1a | It isn't like we want to make it easy to bulk delete people. | 02:25 |
| th1a | what about a link on the person view. | 02:26 |
| replaceafill | that would be better i guess | 02:26 |
| replaceafill | you'll need a title for that button group, right? | 02:26 |
| replaceafill | since it makes no sense under "Alvaro" or "Settings" | 02:27 |
| th1a | I'm getting a little annoyed with the titles... | 02:27 |
| th1a | Or we just need a generic title. | 02:28 |
| replaceafill | hey i forgot the error on the login form! | 02:29 |
| replaceafill | :D | 02:29 |
| replaceafill | fixing... | 02:30 |
| *** alga has quit IRC | 02:33 | |
| th1a | Can modals trigger page reloads? | 02:35 |
| th1a | Is it a problem if a modal dialog should trigger a change in a table index? | 02:35 |
| replaceafill | actually, they do that right now | 02:36 |
| replaceafill | when you hit Add or Cancel or Apply in a modal, you get a full reload next | 02:36 |
| th1a | kk | 02:37 |
| replaceafill | login form fixed | 02:53 |
| th1a | Probably we need a better message too. | 02:56 |
| th1a | I'll look into it. | 02:56 |
| th1a | replaceafill, Will you be working on Cambodia into tomorrow? | 02:57 |
| replaceafill | th1a yes | 02:58 |
| replaceafill | i'm almost done with the gradebook changes | 02:58 |
| replaceafill | but i'll need to work on the new reports | 02:58 |
| th1a | OK. I won't be at the meeting for the most part tomorrow. | 02:58 |
| replaceafill | ah, ok | 02:58 |
| *** Lumiere has quit IRC | 03:09 | |
| *** issyl0 has quit IRC | 03:09 | |
| *** replaceafill has quit IRC | 03:09 | |
| *** th1a has quit IRC | 03:09 | |
| *** aelkner has quit IRC | 03:09 | |
| *** replaceafill has joined #schooltool | 03:13 | |
| *** th1a has joined #schooltool | 03:13 | |
| *** Lumiere has joined #schooltool | 03:13 | |
| *** issyl0 has joined #schooltool | 03:13 | |
| *** aelkner has joined #schooltool | 03:13 | |
| *** Lumiere has quit IRC | 04:55 | |
| *** Lumiere has joined #schooltool | 05:01 | |
| *** th1a has quit IRC | 06:01 | |
| *** aks has joined #schooltool | 06:15 | |
| *** replaceafill has quit IRC | 06:32 | |
| *** alga has joined #schooltool | 10:14 | |
| *** menesis has joined #schooltool | 10:20 | |
| *** menesis has quit IRC | 11:46 | |
| *** ignas has joined #schooltool | 11:50 | |
| *** menesis has joined #schooltool | 12:47 | |
| *** ignas has quit IRC | 13:24 | |
| *** ignas has joined #schooltool | 13:28 | |
| *** menesis has quit IRC | 13:47 | |
| *** menesis has joined #schooltool | 14:17 | |
| *** ignas has quit IRC | 14:32 | |
| *** ignas has joined #schooltool | 14:34 | |
| *** aks has quit IRC | 14:51 | |
| *** replaceafill has joined #schooltool | 16:27 | |
| *** th1a has joined #schooltool | 16:31 | |
| yvl | morning guys | 16:32 |
| th1a | hi yvl, aelkner, replaceafill, menesis. | 16:32 |
| th1a | I'm here after all. | 16:32 |
| replaceafill | good morning/afternoon | 16:32 |
| th1a | No traffic. ;-) | 16:32 |
| yvl | lucky :) | 16:32 |
| th1a | Nice being able to get to the airport in 12 minutes. | 16:33 |
| menesis | hi | 16:33 |
| aelkner | morning all | 16:33 |
| th1a | aelkner: How are you feeling about the Boston/Philadelphia series? | 16:33 |
| aelkner | excited, looks like a world series preview | 16:34 |
| th1a | The Red Sox seem a bit rattled playing by National League rules. | 16:34 |
| aelkner | we can use all the help we can get | 16:35 |
| th1a | OK, let's get started. | 16:35 |
| aelkner | it's good that its homw this year | 16:35 |
| aelkner | home | 16:35 |
| th1a | replaceafill: How's Cambodia coming? | 16:35 |
| replaceafill | the changes to the gradebook are done | 16:36 |
| replaceafill | need to work on the new reports now | 16:36 |
| th1a | kk | 16:37 |
| th1a | aelkner? | 16:37 |
| aelkner | i added the Done button to the relationship views | 16:40 |
| aelkner | but i only added it to the top, do you want it on the bottom as well | 16:40 |
| th1a | You know, aelkner, all my instructions here are recording in a log on the internet. | 16:40 |
| th1a | Can we see that on the testing instance? | 16:41 |
| replaceafill | yep, it's updated | 16:41 |
| aelkner | yes, and you said you did, but i wanted to double-check | 16:41 |
| th1a | aelkner, you have to get used to the idea that we're going to try things and then change them. | 16:41 |
| aelkner | i'm used to it, that's why i feel free to change it now if you want :) | 16:42 |
| th1a | It should be a link, not a button. | 16:42 |
| aelkner | a link? | 16:42 |
| th1a | And top really isn't going to work. | 16:42 |
| th1a | Link. | 16:42 |
| th1a | Distinguishing between a form action and navigation. | 16:43 |
| th1a | I'm really thinking it could go above Available contacts. | 16:43 |
| aelkner | that is at the top | 16:44 |
| aelkner | oh, no | 16:44 |
| th1a | It is below current contacts. | 16:44 |
| aelkner | below Current contacts, above Available contacts | 16:44 |
| th1a | I think more space between the two wouldn't hurt. | 16:45 |
| th1a | Lets try that next, as a link. | 16:45 |
| th1a | Also, we could put it at the bottom but reduce the batch size again. | 16:45 |
| th1a | For the Availables. | 16:45 |
| aelkner | so is that an <a><h3>Done</h3></a> that yo want? | 16:45 |
| th1a | Let's try that, aelkner. | 16:45 |
| th1a | I think the anchor inside the h3 is better style though. | 16:46 |
| aelkner | actually, it depends on what css we have | 16:46 |
| aelkner | replaceafill, which one should i use? | 16:46 |
| replaceafill | as th1a said | 16:47 |
| aelkner | ok | 16:47 |
| aelkner | i got the This person has no... messages into the person info viewlets | 16:47 |
| aelkner | and finally, as you know, i dealt with z3c form hell until i got the Submit and Submit and add to work | 16:48 |
| aelkner | that's it for me | 16:48 |
| replaceafill | are we putting an empty message on the Sections accordion? http://69.164.203.135:6660/persons/alan | 16:49 |
| th1a | That's still on the TODO. | 16:49 |
| th1a | I've got that assigned to aelkner. | 16:49 |
| aelkner | oh, that | 16:49 |
| th1a | Also, I added some instructions for doing the demographics management screen. | 16:50 |
| aelkner | right now, the Sections Taught, for instance doesn't even apear if the person doesn't teach anything | 16:50 |
| aelkner | it's different than the other viewlets | 16:50 |
| th1a | Well, you should get a message if both are empty. | 16:50 |
| th1a | "This space intentionally left blank." | 16:51 |
| aelkner | what should it say? | 16:51 |
| aelkner | ok | 16:51 |
| th1a | "This person has no sections." is probably ok. | 16:51 |
| th1a | I don't think it needs to say, | 16:51 |
| th1a | "This person neither teaches nor attends any sections." | 16:51 |
| th1a | So you need to look at the todo. | 16:52 |
| th1a | I assume we don't really want to do drag and drop ordering. | 16:52 |
| th1a | (we could use it to order demographics fields) | 16:53 |
| th1a | I don't think it is worth the bother. | 16:53 |
| th1a | Unless someone's really geeked up about it. | 16:54 |
| replaceafill | :) | 16:54 |
| menesis | I think empty fields should not be displayed in person tables. http://bazaar.launchpad.net/~menesis/schooltool/flourish/revision/2905 | 16:54 |
| th1a | Did you implement that in that branch? | 16:55 |
| aelkner | the branch has code to skip showing fields that have no value | 16:56 |
| aelkner | are you sure that's what the user wants? | 16:56 |
| aelkner | i mean, doesn't the user want to know what fields are possible? | 16:56 |
| th1a | Well... probably not. | 16:56 |
| aelkner | so we want the change from that branch, is it merged to trunk? | 16:57 |
| menesis | no, I would like this merged | 16:58 |
| menesis | because especially in Contacts, most of the fields are blank | 16:58 |
| aelkner | we've been merging our own changes so far | 16:59 |
| th1a | aelkner: I'm sure we can handle this. | 16:59 |
| aelkner | if you prefer that one of us does it instead of menesis, fine | 17:00 |
| th1a | aelkner: This doesn't really require any discussion. | 17:00 |
| th1a | menesis knows how to merge his branch. | 17:01 |
| th1a | Anyhow, I think it is the right change, thanks menesis. | 17:01 |
| menesis | good | 17:01 |
| *** issyl0 has quit IRC | 17:02 | |
| th1a | Wrapping up aelkner -- finish up what you've got, the smaller things on the todo and then we probably have to discuss the demographics container further. | 17:02 |
| aelkner | ok | 17:02 |
| th1a | Remember to restyle the report card modals to look like the prefs one -- I sent you an email on that, iirc. | 17:03 |
| aelkner | it's in the todo also | 17:03 |
| th1a | OK, cool. Thanks aelkner. | 17:03 |
| th1a | yvl? | 17:03 |
| yvl | th1a, did you get my email? | 17:03 |
| yvl | just checking | 17:03 |
| *** issyl0 has joined #schooltool | 17:04 | |
| yvl | summary: looked at wizards again for timetabling wizard, found no useful ones | 17:04 |
| *** issyl0 is now known as Guest73699 | 17:04 | |
| *** Guest73699 has joined #schooltool | 17:04 | |
| yvl | now merging timetable branch with flourish branch | 17:04 |
| yvl | looking ok, server starts, flourish functionality seems to work | 17:05 |
| yvl | I'm thinking of doing the ttwizard next | 17:05 |
| yvl | are you ok with this? | 17:05 |
| *** Guest73699 is now known as issyl0 | 17:05 | |
| th1a | Yes. | 17:05 |
| yvl | cool | 17:05 |
| th1a | We don't want this to turn into a tarpit, but since it is basically the first complicated thing a user has to do, it needs to be decent. | 17:06 |
| yvl | right | 17:06 |
| yvl | it will take some time to do this | 17:07 |
| yvl | I'd like to try out some ajaxy stuff | 17:07 |
| yvl | like using local variables instead of session data to keep the wizard state | 17:07 |
| yvl | should be not too difficult, just didn't try that before :) | 17:08 |
| yvl | * "haven't done that before" | 17:08 |
| th1a | Local javascript variables? | 17:08 |
| yvl | yes | 17:08 |
| yvl | it'll be a modal dialog | 17:08 |
| yvl | that loads different steps | 17:09 |
| yvl | currently step state is stored in session data | 17:09 |
| yvl | server side | 17:09 |
| yvl | I want to store it on client side | 17:09 |
| yvl | in a javascript state in the modal dialog | 17:09 |
| th1a | That's reasonable. | 17:09 |
| yvl | I think so | 17:09 |
| yvl | well, I'll keep you posted ;) | 17:10 |
| th1a | OK. | 17:11 |
| th1a | We're almost done with the person and persons views. | 17:11 |
| th1a | Make sure you've all had a good look through them, as that's the model for the rest of the application. | 17:12 |
| yvl | sure | 17:12 |
| th1a | Oh, I was speaking to the crowd there. | 17:13 |
| th1a | (btw) | 17:13 |
| th1a | Thanks yvl. | 17:13 |
| th1a | I guess that's about it. | 17:14 |
| th1a | menesis is working on a bugfix release for this week. | 17:14 |
| th1a | At this point replaceafill has me addicted to the test server, so maybe replaceafill can facilitate aelkner updating it so I can see his stuff. | 17:16 |
| replaceafill | well, aelkner has an account on that server | 17:16 |
| replaceafill | could he set up an instance he can control? | 17:17 |
| replaceafill | i dont mind pulling from trunk | 17:17 |
| replaceafill | to make thing easier | 17:17 |
| replaceafill | *things | 17:17 |
| th1a | aelkner: Can you set up an instance? | 17:19 |
| aelkner | replaceafill, could you email me a password for aelkner on that machine? | 17:20 |
| replaceafill | ok | 17:20 |
| aelkner | and a port numer to use please | 17:20 |
| * th1a knew aelkner was going to say that. :-D | 17:20 | |
| th1a | That should do it for today. | 17:21 |
| th1a | Thanks guys. | 17:21 |
| th1a | OH! | 17:21 |
| th1a | Unless aelkner wants to discuss form base classes. | 17:21 |
| aelkner | not at the moment, that's ok | 17:21 |
| th1a | ok | 17:22 |
| * th1a drops the bag of gravel. | 17:22 | |
| yvl | well, a productive day to you guys :) | 17:23 |
| aelkner | and to you as well, yvl :) | 17:23 |
| replaceafill | aelkner login data sent | 17:25 |
| aelkner | replaceafill, thanks, what port number would be best for me to use? | 17:26 |
| replaceafill | it's in the email... | 17:27 |
| aelkner | oh, sorry, there at the bottom | 17:27 |
| replaceafill | :/ | 17:27 |
| aelkner | oh, that's the same machine i used to host schooltool.niepa | 17:28 |
| aelkner | it's been a while | 17:28 |
| replaceafill | since october 5 :) | 17:28 |
| * replaceafill goes to get breakfast | 17:29 | |
| th1a | aelkner: Can we get this link straightened out? | 18:03 |
| aelkner | that's what i'm doing now, and setting up the server instance | 18:05 |
| th1a | ok | 18:05 |
| aelkner | 69.164.203.135:36660, btw | 18:05 |
| aelkner | running now | 18:05 |
| replaceafill | aelkner have you synch'ed this branch with trunk? | 18:11 |
| aelkner | i do from time to time, why? | 18:21 |
| replaceafill | i didnt get the new login form | 18:23 |
| aelkner | th1a, Done is now a link on relationship views, loaded on my instance | 18:23 |
| th1a | Can you make it h3? | 18:24 |
| aelkner | it is | 18:24 |
| replaceafill | the <a> style wins over the <h3> style | 18:25 |
| aelkner | how about h2 which would make it as big as the headings? | 18:25 |
| replaceafill | 12px font-size | 18:25 |
| replaceafill | nope | 18:25 |
| th1a | Well, that's a bug. | 18:25 |
| aelkner | replaceafill, that's why i asked before :) | 18:25 |
| replaceafill | we can add a new rule ;) | 18:26 |
| th1a | Why does link affect size? | 18:26 |
| th1a | That's not in the spec. | 18:27 |
| aelkner | we just need a rule for h3 > a | 18:27 |
| th1a | NO, | 18:27 |
| th1a | There is a bug in the CSS. | 18:27 |
| th1a | It is incorrect. | 18:27 |
| aelkner | right, that's what i'm saying | 18:27 |
| aelkner | css rule for h3 > a | 18:27 |
| replaceafill | th1a agree, it's a bug | 18:28 |
| aelkner | so that is keeps to the guidlenes | 18:28 |
| th1a | NO! | 18:28 |
| th1a | anchor should not affect size at all. | 18:28 |
| th1a | That is the bug. | 18:28 |
| replaceafill | yes | 18:29 |
| th1a | It is not your bug. | 18:29 |
| th1a | aelkner. | 18:29 |
| th1a | But that's the bug, and we need to fix it. | 18:29 |
| th1a | When CSS doesn't work, the first thing you should question (in SchoolTool) is whether there is a problem in the basic element CSS. | 18:30 |
| th1a | Not how you can cover over it. | 18:30 |
| th1a | Because usually there IS a very fundamental flaw in SchoolTool CSS. | 18:30 |
| th1a | I just need you to think that way. | 18:30 |
| * replaceafill reviews all the font-size rules | 18:31 | |
| th1a | And fixing a basic CSS bug isn't as hairy as fixing z3c.form magic. | 18:31 |
| th1a | There is just a line or two in the anchor CSS that needs to go away. | 18:31 |
| th1a | Actually, maybe the problem is that H3 is just so close to the paragraph font. | 18:32 |
| th1a | No, I'd be able to tell the difference. | 18:33 |
| *** alga has quit IRC | 18:33 | |
| replaceafill | th1a i'll add 8px margin-bottom to tables | 18:35 |
| replaceafill | to give them some room | 18:35 |
| replaceafill | <table><h2><table> looks tight | 18:36 |
| aelkner | replaceafill, so if the problem is that the <a> style wins over the <h3> style | 18:36 |
| th1a | That is not the problem aelkner. | 18:36 |
| aelkner | don't we want to create a special h3 > a rule in flourish.css? | 18:36 |
| th1a | That is not the problem. | 18:36 |
| replaceafill | aelkner no | 18:36 |
| th1a | The problem is that a should not dictate size. | 18:36 |
| replaceafill | i just removed the font-size, line-height from the <a> rule and it looks right | 18:36 |
| th1a | Right. | 18:36 |
| aelkner | so, so we take out the rule that makes it so | 18:37 |
| aelkner | a, a:link, a:visited, a:active { | 18:37 |
| aelkner | font-size: 12px; | 18:37 |
| th1a | Conceptually <a> should not change the size. | 18:37 |
| th1a | Yes, just remove that. | 18:37 |
| aelkner | ok | 18:37 |
| replaceafill | i just did in trunk | 18:37 |
| aelkner | line-height should go, too, i suppose | 18:37 |
| aelkner | line-height: 16px; | 18:38 |
| replaceafill | aelkner just sync | 18:38 |
| aelkner | th1a, instance updated | 18:40 |
| aelkner | replaceafill, is there something you could change on that box so my connection doesn't time out so quickly> | 18:41 |
| th1a | ? | 18:41 |
| replaceafill | aelkner mine doesnt | 18:41 |
| th1a | I think that looks pretty ok. | 18:42 |
| aelkner | it's a keepalive setting i believe | 18:42 |
| th1a | What is timing out? | 18:42 |
| aelkner | i don't remember, but matt gallager set it up for me once | 18:42 |
| aelkner | i have to ssh to the server to maintain the instance | 18:42 |
| aelkner | and ssh is breaking the pipe | 18:42 |
| replaceafill | i'll ask Matt | 18:43 |
| aelkner | thanks | 18:43 |
| th1a | Do the h2 and h3 have the right top and bottom margins? | 18:46 |
| th1a | Their top margins should be 16. | 18:46 |
| replaceafill | all headers have 8px | 18:46 |
| replaceafill | 16px? | 18:46 |
| th1a | p. 17. | 18:46 |
| replaceafill | +1 | 18:47 |
| replaceafill | fixing | 18:47 |
| * th1a broke out firebug. | 18:47 | |
| replaceafill | th1a you said h4-h6 are dead to us, right? | 18:50 |
| replaceafill | i should remove their rules | 18:51 |
| th1a | Yes. | 18:51 |
| th1a | aelkner: I'd say your task is complete, for today at least. | 18:52 |
| th1a | So you can move on. | 18:52 |
| th1a | Or eat lunch. | 18:52 |
| replaceafill | th1a wow http://69.164.203.135:6660/persons/alvaro/@@manage_contacts.html?SEARCH_TITLE=%C3%81lvarez | 18:53 |
| replaceafill | lots of room for that first h2 | 18:53 |
| th1a | Does the container need that much top padding? | 18:54 |
| th1a | That's the spec, I guess. | 18:54 |
| replaceafill | although page 16 looks kind of the same | 18:55 |
| replaceafill | yes, the spec says 32px top | 18:55 |
| th1a | Also title and subtitle is off now. | 18:55 |
| replaceafill | hhmm | 18:55 |
| replaceafill | actually | 18:55 |
| replaceafill | check p10 | 18:55 |
| th1a | Oh... if the total space is 32, the padding is not necessarily 32. | 18:56 |
| replaceafill | but check /persons ;) | 18:56 |
| th1a | And h1 has no margin top. | 18:56 |
| aelkner | th1a, empty sections message now loaded in my instance | 18:57 |
| replaceafill | th1a correct, the first header in the spec is h1, no margin | 18:58 |
| th1a | Can you make all those messages just regular paragraph size. | 18:58 |
| th1a | replaceafill, that seems like a bug. | 18:59 |
| replaceafill | in the spec? or ours? :) | 18:59 |
| th1a | In theirs. | 18:59 |
| th1a | replaceafill, I think maybe forms need a top margin, and the padding of the container should go down. | 19:00 |
| th1a | Make the top container padding 16. | 19:00 |
| th1a | And give forms a top margin of 16. | 19:00 |
| th1a | ? | 19:00 |
| replaceafill | yes, same margin-top as headers | 19:01 |
| th1a | I think that makes sense. | 19:01 |
| replaceafill | the accordion will go up though | 19:01 |
| replaceafill | in person index | 19:02 |
| replaceafill | ok, fixing those | 19:02 |
| replaceafill | i'm moving the first <h2> in the relationship views out of the form | 19:07 |
| replaceafill | i guess aelkner put it there on the first try | 19:08 |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro/@@manage_contacts.html?SEARCH_TITLE=%C3%81lvarez | 19:10 |
| replaceafill | you ok with that space? | 19:10 |
| th1a | That's pretty good. | 19:10 |
| th1a | Definitely better. | 19:10 |
| replaceafill | thank you ubuntu guidelines ;) | 19:11 |
| replaceafill | Done seems randomly put to me :( | 19:12 |
| replaceafill | maybe it could use some background or something | 19:12 |
| th1a | Lets leave it for now. | 19:13 |
| replaceafill | cool | 19:13 |
| replaceafill | pushing my changes to trunk | 19:13 |
| replaceafill | aelkner sync with trunk "More css fixes" | 19:13 |
| th1a | Actually, we could just try a <hr /> under done. | 19:14 |
| replaceafill | :| | 19:14 |
| th1a | I never know if that is a positive or negative reaction. | 19:17 |
| replaceafill | :D | 19:17 |
| replaceafill | i just dont like hr's | 19:17 |
| replaceafill | that's all | 19:17 |
| th1a | It isn't generally something I'd throw in. | 19:18 |
| replaceafill | i'm fixing the margin of the accordion... | 19:18 |
| replaceafill | it went up | 19:18 |
| replaceafill | th1a i'm not sure if us reducing that top padding to 16px is a good idea... | 19:19 |
| replaceafill | we can add 16px margin-top to forms, sure | 19:20 |
| replaceafill | but all the new pages will have trouble | 19:20 |
| replaceafill | for example: | 19:20 |
| replaceafill | http://69.164.203.135:6660/persons/alvaro/reports | 19:20 |
| th1a | There are only so many elements that will go there. | 19:20 |
| th1a | Give tables a 16px top margin too! | 19:20 |
| replaceafill | that i didnt want to do, but ok | 19:21 |
| replaceafill | :) | 19:21 |
| th1a | Well, we'll see. | 19:21 |
| replaceafill | http://69.164.203.135:6660/persons/alvaro/reports | 19:21 |
| replaceafill | sure, that fixes it | 19:21 |
| replaceafill | the accordions have it too | 19:21 |
| th1a | I'm sure it doesn't break anything else. ;-) | 19:21 |
| replaceafill | :D | 19:22 |
| replaceafill | nooo!!! | 19:22 |
| th1a | That looks ok in the accordion. | 19:22 |
| replaceafill | the batch ;) | 19:22 |
| replaceafill | http://69.164.203.135:6660/persons | 19:22 |
| th1a | I thought that was part of the table. | 19:22 |
| replaceafill | hhmm no | 19:23 |
| replaceafill | it's a separate div | 19:23 |
| th1a | If it is an odd case you could just give it a negative bottom margin. | 19:23 |
| *** menesis has quit IRC | 19:24 | |
| replaceafill | not sure that would work | 19:24 |
| replaceafill | since the table below has its own margin-top | 19:24 |
| replaceafill | let me try | 19:24 |
| replaceafill | well margin-bottom: -16px looks great on chrome... | 19:29 |
| th1a | lol | 19:29 |
| replaceafill | but not great in ff 3.5 | 19:29 |
| replaceafill | you have ff th1a? | 19:29 |
| th1a | Works in FF 4. | 19:29 |
| replaceafill | :-O | 19:30 |
| replaceafill | i should upgrade... | 19:30 |
| th1a | No... | 19:30 |
| th1a | Gives us some perspective. | 19:30 |
| * th1a goes to make a sandwich. | 19:32 | |
| *** ignas has quit IRC | 19:34 | |
| * th1a is done with lunch. | 19:47 | |
| * replaceafill is fighting ff 3.5 :D | 19:48 | |
| th1a | Oh... | 19:48 |
| th1a | I was going to suggest tabling the issue for now. | 19:48 |
| aelkner | th1a, a quick question | 20:14 |
| th1a | Yes? | 20:15 |
| aelkner | you suggested taking out the Cancel button from report request | 20:15 |
| aelkner | yet you said you wanted it to look like preferences | 20:15 |
| aelkner | which has apply, cancel | 20:15 |
| aelkner | i don't think we want to require the user to hit the X | 20:15 |
| aelkner | that's something power user know to do | 20:16 |
| aelkner | also, besides getting rid of the redundant heading, it already looks like the preferneces view | 20:16 |
| th1a | There shouldn't be a cancel button if you aren't submitting a form. | 20:17 |
| aelkner | i'll need to load it into my instance for you to see | 20:17 |
| aelkner | how about a link to get back? | 20:17 |
| aelkner | like Done in the relationship views | 20:17 |
| th1a | I don't think an x to close a window is a power user move. It is on every window on your computer. | 20:17 |
| th1a | Since 1984. | 20:18 |
| replaceafill | i'd like Cancel buttons to do what the X button on dialogs do | 20:18 |
| th1a | Or Windows 3.1 at least. | 20:18 |
| replaceafill | just .dialog('close') | 20:18 |
| th1a | It isn't a form. | 20:18 |
| th1a | If it is a form with a submit, there should be a cancel. | 20:18 |
| aelkner | ok | 20:19 |
| th1a | I mean, maybe we'll decide we need a close link, but I'd like to start without. | 20:19 |
| th1a | Better to try simpler first. | 20:19 |
| replaceafill | th1a heh http://archivist.incutio.com/viewlist/css-discuss/107291 | 20:20 |
| replaceafill | at the bottom of the page: | 20:20 |
| replaceafill | "2. don't use margin-top on table" | 20:20 |
| replaceafill | it seems like a known issue on ff 3.5 :( | 20:21 |
| replaceafill | i created a mock and it's true | 20:21 |
| replaceafill | tables with margin-top behave incorrectly | 20:21 |
| * replaceafill just couldn't understand it :) | 20:21 | |
| th1a | Ha. | 20:22 |
| th1a | OK, so we'll just ignore it. | 20:22 |
| replaceafill | agree | 20:22 |
| replaceafill | moving on... | 20:22 |
| replaceafill | :) | 20:22 |
| th1a | I'm trying to avoid sinking into browser compatibility hell. | 20:23 |
| replaceafill | aelkner sync with trunk "More css fixes" | 20:23 |
| aelkner | replaceafill, will do, at some point | 20:23 |
| replaceafill | aelkner dont want to annoy you btw, just to inform you | 20:24 |
| aelkner | that's ok, i just say 'something is pushed' to let others know | 20:24 |
| aelkner | sync with trnk sounds more like something i need to do right away | 20:24 |
| aelkner | which in rare cases may be true | 20:24 |
| th1a | Well, considering we changed a bunch of CSS, you might want it now. | 20:25 |
| replaceafill | yep | 20:25 |
| th1a | Since it changes the way every page in the application is displayed. | 20:25 |
| aelkner | so i'm strugling with modal form magic | 20:25 |
| aelkner | when i have the <h3> in my page, it shows up twice | 20:26 |
| aelkner | once as the modal dialog heading, and once as the first ting in the content area | 20:26 |
| aelkner | if i remove the <h3>, it gets removed in both places! | 20:26 |
| replaceafill | aelkner the title of the dialog is a nasty hack | 20:26 |
| replaceafill | (as yvl says) | 20:27 |
| replaceafill | if your form follows the same structure of the preferences dialog, the css will hide the <h3> in the content | 20:27 |
| replaceafill | (or it should...) | 20:28 |
| replaceafill | :) | 20:28 |
| aelkner | i probably need it to be in a form | 20:28 |
| aelkner | even though the download modal is not a form | 20:28 |
| replaceafill | ahh!!! | 20:28 |
| th1a | It could be a form. | 20:28 |
| replaceafill | does it need a button? | 20:29 |
| th1a | That would solve both problems. | 20:29 |
| replaceafill | damn css! | 20:29 |
| replaceafill | :D | 20:29 |
| aelkner | :) | 20:29 |
| replaceafill | th1a check the preferences dialog ;) | 20:29 |
| replaceafill | margint-top on the form :P | 20:30 |
| aelkner | it is a form and it has buttons | 20:30 |
| replaceafill | fixing it... | 20:30 |
| replaceafill | aelkner you can follow the same structure then | 20:30 |
| aelkner | so all agreed on me putting download modal content inside a form even though there are no buttons | 20:30 |
| aelkner | to solve the magic hack issue? | 20:30 |
| th1a | You could just make it a form with radio buttons. | 20:31 |
| th1a | To select the year/term. | 20:31 |
| th1a | And a submit and cancel button. | 20:31 |
| replaceafill | th1a btw, i'm changing cambodia to this: http://jqueryui.com/demos/datepicker/#dropdown-month-year | 20:32 |
| replaceafill | since Chandara asked for an easier way to select years | 20:32 |
| th1a | Ah... ok. | 20:32 |
| *** menesis has joined #schooltool | 20:33 | |
| replaceafill | More css changes pushed to trunk... | 20:35 |
| aelkner | replaceafill, holy cow, yvl has really created a fancy paradigm with his scriptlocal directive | 20:38 |
| replaceafill | :D | 20:38 |
| * replaceafill was scared of touching js after seeing what yvl did :) | 20:39 | |
| aelkner | in schooltool/report/templates/f_report_link_manager.pt | 20:39 |
| replaceafill | scared in a good way ;) | 20:39 |
| aelkner | he loads the same view attribute, table that i used for rendering the html | 20:39 |
| aelkner | into a js variable | 20:39 |
| aelkner | that's the json stuf i guess, right? | 20:40 |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro | 20:40 |
| replaceafill | Manage contacts as h3? | 20:41 |
| replaceafill | i remember you said it should be bigger | 20:41 |
| th1a | Well, I just told aelkner to make other things smaller in there. | 20:41 |
| replaceafill | ah ok, reverting then | 20:41 |
| th1a | Well. | 20:42 |
| th1a | ... | 20:42 |
| th1a | I'm not sure... | 20:42 |
| replaceafill | i just don't like we're using a special css class for that link :) | 20:42 |
| th1a | We are? | 20:42 |
| * replaceafill is trying to kill special cases | 20:42 | |
| th1a | What's the special case? | 20:42 |
| replaceafill | well, when we put it back it was an special case... | 20:43 |
| replaceafill | it's not anymore | 20:43 |
| th1a | Anyhow, I think I prefer it as an h3. | 20:43 |
| th1a | You're too quick for me, replaceafill. | 20:43 |
| replaceafill | :D | 20:44 |
| replaceafill | sorry | 20:44 |
| replaceafill | so, not reverting then... | 20:44 |
| * aelkner runs to the WaWa to grab a bite | 20:44 | |
| th1a | I'm getting current contacts header running to two lines now. | 20:44 |
| replaceafill | ? | 20:45 |
| th1a | The arrows are on a second line. | 20:45 |
| replaceafill | hhmm | 20:46 |
| th1a | Ah... ad Yolanda Alvarez. | 20:46 |
| th1a | add | 20:46 |
| th1a | Take address out of that table. | 20:47 |
| replaceafill | ahh! | 20:47 |
| replaceafill | the arrows for sorting! | 20:47 |
| th1a | Always good to look at some actual data. ;-) | 20:47 |
| replaceafill | i thought you were referring to the arrows in the accordions... | 20:47 |
| th1a | no | 20:47 |
| replaceafill | so, Address out only in the first table (current contacts)? | 20:48 |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro/@@manage_contacts.html | 20:50 |
| replaceafill | i think we should set widths on those table columns | 20:51 |
| replaceafill | like we have in the groups relationship view | 20:52 |
| *** alga has joined #schooltool | 20:53 | |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro/@@manage_contacts.html | 21:02 |
| replaceafill | uniform column widths | 21:02 |
| th1a | We don't need to jam address in their though. | 21:03 |
| th1a | But yes, we also need to control those. | 21:03 |
| replaceafill | remove address from the second table? | 21:03 |
| th1a | y | 21:03 |
| replaceafill | k | 21:03 |
| replaceafill | done | 21:05 |
| * aelkner is back | 21:05 | |
| replaceafill | changed pushed to trunk "Removed address column from contact relationship view and fixed css for tables" | 21:13 |
| * replaceafill goes back to cambodia gradebook work | 21:14 | |
| th1a | replaceafill: Weren't you supposed to be doing that anyhow? :-D | 21:17 |
| replaceafill | :D | 21:17 |
| replaceafill | i got caught in css work easily ;) | 21:17 |
| th1a | We made some important fixes. | 21:21 |
| replaceafill | aelkner i added ClientAliveInterval 120 | 21:36 |
| replaceafill | to the ssh server configuration | 21:36 |
| replaceafill | let me know if you still get broken pipes | 21:36 |
| aelkner | replaceafill, thanks | 21:40 |
| th1a | One thing we could do to solve the done placement problem on the relationship view is to put the search results in an embedded scrollable frame, so on the most common browser sizes the done button would be at the bottom and visible. | 21:41 |
| aelkner | th1a, report request views loaded in my instance | 21:44 |
| th1a | Can you give me a fresh url? | 21:44 |
| aelkner | i figured out how to structure my template to get the magic title hack to work | 21:44 |
| aelkner | http://69.164.203.135:36660/persons | 21:45 |
| th1a | I guess you didn't like the idea of actually making it a form? | 21:45 |
| aelkner | replaceafill, what do i need to do to enable pdf support there? | 21:45 |
| aelkner | i checked schooltool.conf and the reportlab_fontdir is set: | 21:46 |
| aelkner | reportlab_fontdir /usr/share/fonts/truetype/ttf-liberation | 21:46 |
| th1a | OK... title works. | 21:46 |
| aelkner | yeah, i figured out the hack | 21:47 |
| aelkner | th1a, oh, and making it a form | 21:47 |
| aelkner | i thought you only suggested that to get around the hack | 21:47 |
| aelkner | do you want me to change it to have radio/submit buttons | 21:48 |
| th1a | Well, it might be an improvement, but at this point I'm not sure it is worth the bother. | 21:48 |
| aelkner | let's table it then if you're ok with what is there | 21:49 |
| th1a | It is a better paradigm I think. | 21:49 |
| th1a | I was originally thinking of buttons next to the title. | 21:50 |
| th1a | But radio buttons are probably better. | 21:50 |
| th1a | But I suspect it would all take a while at this point. | 21:50 |
| aelkner | it would, but perhaps later, after we have more experience with other cases, we will want to change it | 21:51 |
| replaceafill | aelkner sorry i was away | 21:51 |
| th1a | There are some other style changes in the email. | 21:52 |
| aelkner | but for now, i'm ok fr moving on from it | 21:52 |
| replaceafill | ah, we don't have that package installed in the vps | 21:52 |
| aelkner | thought that might be the case ::) | 21:52 |
| aelkner | but then i thought, doesn't he have many users using that machine? | 21:52 |
| th1a | He? | 21:53 |
| aelkner | i guess none have need reports yet | 21:53 |
| replaceafill | aelkner done | 21:53 |
| aelkner | th1a, he, read replaceafill | 21:53 |
| th1a | It is our demo server. | 21:53 |
| aelkner | oh, i thought it was something replaceafill built | 21:54 |
| replaceafill | pdf support should be now enabled | 21:54 |
| aelkner | never mind | 21:54 |
| aelkner | replaceafill, thanks | 21:54 |
| aelkner | pdfs work now | 21:55 |
| aelkner | th1a, i pushed TODO.txt changes to trunk, so you can pull to see | 22:15 |
| th1a | Are you restarting the demo server now? | 22:19 |
| th1a | aelkner: Your server instance isn't up. | 22:20 |
| aelkner | damn, the broken pipe again | 22:21 |
| replaceafill | aelkner why don't you start the server in the background? | 22:21 |
| replaceafill | bin/start-schooltool-instance instance --daemon | 22:21 |
| replaceafill | bin/start-schooltool-instance instance --stop | 22:21 |
| *** menesis has quit IRC | 22:25 | |
| aelkner | replaceafill, thanks, that will work better than make run & | 22:26 |
| replaceafill | :) | 22:26 |
| aelkner | which still had the backround process attached to the terminal instance | 22:26 |
| replaceafill | ah and dont forget: | 22:26 |
| th1a | Can you take the header out and put in the text from the email? | 22:26 |
| replaceafill | bin/start-schooltool-instance instance --status | 22:26 |
| th1a | replaceafill & aelkner: I think we need some padding in the modals. | 22:39 |
| * replaceafill checks our modals | 22:42 | |
| replaceafill | padding: 2px | 22:42 |
| replaceafill | aelkner have you pushed your changes to trunk? | 22:43 |
| th1a | Some... more padding. | 22:43 |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro | 22:47 |
| replaceafill | Preferences | 22:47 |
| replaceafill | with 8px | 22:47 |
| th1a | I guess that includes the title bar? | 22:48 |
| th1a | Can you put the padding just in the content area and make it 16? | 22:48 |
| replaceafill | yes, you want padding only in the content area? | 22:48 |
| replaceafill | ok | 22:49 |
| replaceafill | refresh http://69.164.203.135:6660/persons/alvaro | 22:49 |
| replaceafill | Preferences | 22:49 |
| th1a | is that 8? | 22:49 |
| replaceafill | no, 16 | 22:49 |
| th1a | Oh, I'm looking at aelkner's server now... | 22:50 |
| th1a | I guess 8. | 22:51 |
| replaceafill | changed | 22:51 |
| th1a | Thanks. | 22:52 |
| replaceafill | should i take the Cancel button out of preferences? | 22:52 |
| replaceafill | or is aelkner doing that? | 22:52 |
| replaceafill | or are we not doing that? :D | 22:52 |
| th1a | It is not that I'm anti-cancel button in general. | 22:52 |
| th1a | I'm anti-cancel buttons outside of forms. | 22:52 |
| replaceafill | ah ok | 22:52 |
| replaceafill | got it | 22:52 |
| th1a | And still considering whether to just make the report modal a form... because it'll be the first annoyance I've just given up on if I do. | 22:53 |
| th1a | don't | 22:53 |
| th1a | And it is a slippery slope... | 22:53 |
| replaceafill | :) | 22:54 |
| replaceafill | ok pushing this padding change to trunk... | 22:54 |
| replaceafill | change pushed to trunk, "Fixed padding of dialog content" | 22:55 |
| th1a | aelkner: Are you making those changes to the report modals? | 23:05 |
| aelkner | th1a, are you saying get rid of any mentioning of Report Card vs. Detail Report on the modal | 23:14 |
| aelkner | A user can forget where they are from click (phone call distraction) click | 23:14 |
| th1a | No. | 23:14 |
| th1a | Put as a h3 "Select a year or term" and then just take the header off the table. | 23:15 |
| aelkner | Put what? | 23:15 |
| aelkner | Your shorthand is not comprehensible to me | 23:15 |
| aelkner | Red bar has what? | 23:16 |
| aelkner | Table has no header? | 23:16 |
| th1a | move "Request Detailed Student Report" to the red bar. | 23:16 |
| th1a | Which you did. | 23:16 |
| th1a | Put as a h3 "Select a year or term" in the body of the modal. | 23:16 |
| th1a | Take the header off the table. | 23:16 |
| aelkner | ok | 23:16 |
| aelkner | th1a, loaded on my instance | 23:56 |
| aelkner | had to use h2 instead of h3 because of yvl hack | 23:56 |
| aelkner | we can talk about that at tomorrow's meeting | 23:56 |
| replaceafill | aelkner don't blame yvl :) | 23:56 |
| replaceafill | it's mine ;) | 23:56 |
| aelkner | oh, sorry yvl | 23:57 |
| aelkner | i just assumed because he worked on the whole modal js magic stuff | 23:57 |
| aelkner | i'm happy to blame you though :) | 23:58 |
| aelkner | but seriously, is this a short-term hack or a long-term design pattern? | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!