IRC log of #schooltool for Thursday, 2011-06-16

*** asharma has quit IRC00:01
th1areplaceafill: Yeah, make add black.00:36
th1aYou know, this is looking pretty good.00:38
* replaceafill is happy th1a is kind of happy :)00:38
*** jelkner has quit IRC00:39
replaceafillthe breadcrumbs!00:39
replaceafilli forgot about them00:39
replaceafilli have to move them right?00:39
th1aAlso, if you need something to do, fix the login screen.00:39
th1aYou can.00:39
replaceafillcan i port the edit view for persons?00:39
replaceafilland put the "Edit" link in the person view?00:39
th1aWell, we can't view a person yet.00:40
th1aSo you could do that first!00:42
replaceafillth1a we can view persons00:42
replaceafillthat's the accordion page00:42
replaceafillisnt it?00:42
th1aAnd other info.00:43
replaceafillah, ok00:43
replaceafillok, so 1. breadcrumbs, 2. login screen00:43
replaceafillif you remember something else let me know00:43
aelknerth1a, should we create a viewlet for demographics?00:54
aelkneri was thinking if the demographics viewlet had core attributes followed by demos00:57
aelknerit would always have at least the core attributes to display, and we could make it the default opened accordion00:58
aelknerit could also be a table like the ones we've been using in sections and groups00:58
aelknerField      |       Value00:58
aelknerlast_name   |   Smith00:59
aelknermy_demo      |     some value00:59
aelkneras it is, we changed the person edit views recently to have two fieldsets, core and demos01:00
aelknerso the viewlet would be rendering the same fields in the same order, just in a table01:01
replaceafillth1a breacrumbs01:15
replaceafillfeels like a css hack :/01:15
th1areplaceafill:  What's the hack?01:24
th1aaelkner: I think we're on the same page.01:25
replaceafillthe breadcrumbs are inside the secondary navigation as a <li>01:25
replaceafilli used absolute positioning for take them out01:25
replaceafillthe right solution should be having two <ul> :)01:25
replaceafillat the same level01:26
th1aaelkner:  Advisors should also be tables.01:27
th1aAnd advisees...01:27
*** alga has quit IRC01:49
replaceafillth1a raise an error02:35
* replaceafill goes out02:35
*** replaceafill has quit IRC02:36
*** th1a has quit IRC02:53
*** aelkner has quit IRC02:53
*** th1a has joined #schooltool02:59
*** aelkner has joined #schooltool02:59
*** ignas has quit IRC03:16
*** issyl0 has quit IRC04:46
*** issyl0 has joined #schooltool04:47
*** issyl0 is now known as Guest9673204:47
*** fsufitch has joined #schooltool04:49
*** replaceafill has joined #schooltool06:04
*** aks has joined #schooltool06:06
*** aks has joined #schooltool06:06
*** replaceafill has quit IRC06:09
*** th1a has quit IRC07:21
*** yvl has joined #schooltool09:18
*** alga has joined #schooltool09:41
*** alga has quit IRC10:00
*** alga has joined #schooltool10:51
*** ignas has joined #schooltool11:14
*** menesis has joined #schooltool11:40
*** menesis has quit IRC14:08
*** aks has quit IRC14:19
*** menesis has joined #schooltool14:40
*** th1a has joined #schooltool15:02
*** replaceafill has joined #schooltool15:19
*** replaceafill has quit IRC15:23
*** replaceafill has joined #schooltool15:23
* replaceafill updates the testing instance16:25
th1ahi replaceafill, aelkner, yvl, menesis.16:30
th1aI have some good news and some bad news.16:30
replaceafillgood morning/afternoon16:30
th1aGood news, I'm going to hard limit the "official" meetings the next two days to an hour.16:30
th1aBad news, I think we need to keep having daily meetings for at least another week.16:31
th1areplaceafill:  Did you get an error when you tried to run flourish trunk?16:31
yvlgood morning guys16:31
replaceafillth1a NO16:31
th1aoh... it is me I guess...16:32
th1aThat's right, I was messing with the buildout yesterday.16:33
th1aThat's right, I was messing with the buildout yesterday.16:33
th1ayvl: What did you do on the night shift?16:33
yvlreversed person name order16:34
yvlcreated flourish branches for intervention, journal and gradebook16:34
yvlput links for each in top bar16:34
yvlported intervention to use updated traverser directives16:35
yvlthat's about it16:35
th1aShould I be seeing that in the testing instance?16:36
replaceafilli think in need to include those new branches in the testing instance buildout16:36
replaceafillcorrect, yvl?16:36
* replaceafill goes to do it16:37
yvlI did not merge Douglas or Alan work16:37
yvlthere were no commits in your branches16:37
replaceafillsorry that i've been pushing to trunk :(16:37
yvlthat's ok16:38
th1aSo basically my goal for this week -- the next two days, is to get the core set of person views done.16:38
th1aAnd then we need to turn the corner and just start grinding through the rest of the app.16:39
th1aDo you guys have any thoughts or feelings about how that should be organized?16:39
th1aDo you each just want to take a component and do the whole thing?16:40
th1aOr should we do this assembly line fashion?16:40
th1ayvl plumbs; aelkner puts up the walls; replaceafill paints?16:40
aelknerreplaceafill, just pushed some changes to trunk, please pull to instance16:40
replaceafillaelkner ok16:40
th1aassembly line might be better for consistency.16:41
aelknergot the advisrory tables to work16:41
th1aAh.  Good.16:42
replaceafilltesting instance updated with all the plugins enabled16:44
th1aOK, things to do today.16:44
th1aSwitch to using the LP edit icon.16:45
th1aNext to the relevant table labels.16:45
th1aThis should of course only show up when appropriate by permission.16:45
th1aI guess I'll give that task to replaceafill.16:46
th1aWe need to create UWG views for editing advisors, advisees, groups.16:46
th1aWe need a UWG compliant dialog (they call them overlays, I think) for preferences.16:47
replaceafillaelkner please remove that <div>&nbsp;</div> in advisoryViewlet.pt16:47
th1aLook at the person page.16:48
aelkneri didn't even see it16:48
th1aAh, aelkner can work on making all the add person pages capable of going directly to adding another person.16:49
th1aNeed a reports view (table)16:50
aelknerreplaceafill, pushed to trunk16:50
th1a(consider this the official todo list, guys)16:50
replaceafillaelkner thanks :)16:50
th1aNeed a section in the sidebar for $USERNAME's ...16:51
th1aThat will have:16:51
th1a- Intervention center16:51
th1a- Reports16:51
th1aI'm not sure what the header is in whatever section Preferences goes in.16:52
th1aIs all this making sense?16:52
th1aI have to run around this morning because it is the last day of preschool for Vivian.16:53
th1aSo I need replaceafill and aelkner to pick what of the above they're going to work on.16:53
replaceafilli'll work on changing the "edit" links to the icon16:54
yvlI'll work on whatever's left ;)16:54
* th1a taps the microphone.16:54
replaceafillbtw, can you visit:
replaceafilland hit the Add button with no data16:55
aelknerhas anyone noticed that the school view is broken16:55
replaceafillto see the error formatting16:55
th1aYes, those are going to require some love too.16:55
aelknerit doesn't show the persons link or any links for that matter16:55
replaceafilli want to know if that icon is ok for "error"16:55
th1aEverything is broken by default.16:56
yvlthe status messages are hidden at the moment16:56
yvldisplay: none16:56
yvlwas not sure how to style them quickly16:56
th1aThe orange one?16:56
replaceafilland the hints add a little space16:56
replaceafillth1a it's supposed to be red16:56
replaceafill(the error messages)16:56
*** menesis has quit IRC16:56
th1aMaking orange things red is low priority.16:57
th1aJust go ahead with the orange one.16:57
th1aWe don't need to worry about color until we're sure we like the shape.16:57
th1aIs there too much space between the label and the field?16:58
replaceafilljust a little extra16:59
replaceafillthere's hint in between16:59
replaceafillcheck date of birth16:59
th1aNow, as a for example about how we want to think about labeling things.16:59
replaceafillor username16:59
replaceafillthey have hints displayed16:59
th1aWhat should the fieldset title be?16:59
th1aWhat information would be helpful to the user?16:59
* th1a looks expectantly at the class.17:00
* replaceafill failed user interface design last semester...17:00
yvlnew person / new administrator / etc.17:00
yvlremove subtitle form the view17:00
yvlbasically - make it smaller17:01
yvlor else there's not much to put ther17:01
th1aWell, what information is the user going to be entering.17:01
th1aWhat should the user be thinking about?17:01
replaceafillaelkner somethings wrong with the advisory accordion17:01
aelknerhow so?17:01
replaceafillaelkner i'll explain after the meeting17:01
th1aStay on topic class.17:02
replaceafillsorry sir17:02
yvlyou can also split the form into several fieldsets17:02
yvllike personal information17:02
yvlcontact information17:02
th1aThe example form in the UWG is actually a good model.17:03
replaceafillAbout you, Address17:03
th1aWe'd be a bit more formal, but basically the fieldset title should tell the user what kind of information they'll be entering in each section.17:04
th1aAre there examples of hints in these forms?17:05
replaceafilli dont think so17:05
replaceafilljust errors17:05
* yvl is sensing th1a is leading us to the answer17:06
th1aOh, sorry.17:07
yvllike, show hints where the errors are shown17:07
th1a*I* had moved onto a new subject.  ;-)17:07
yvlor something17:07
th1aAnyway, the add person page should have fieldsets more or less like17:08
th1aFull name17:08
th1aActually, this is just going to take some experimentation.17:09
th1aHow many sets is too many.17:09
th1aThe last four counting Ethnicity should actually be the first four in a "demographics" fieldset.17:10
aelknerthat's the way it is in the old skin17:10
th1aThat'll take some fiddling.17:11
th1ayvl:  Do you want to work on that tomorrow?17:12
yvlif you specify exactly what I need to do, yes17:12
th1aWell, let's say17:12
th1aFull Name17:12
yvlDetails (gender, birth date)17:13
yvlSchoolTool user17:13
yvland thats'it17:13
yvlno group17:13
yvlno advisor17:13
yvlor leave them in?17:13
th1aI mean, this kind of has to marinate for a while.17:13
th1aYes, leave them in.17:14
yvlseparate section?17:14
th1aThey probably should have their own fieldset.17:14
yvlyes, I meant fieldset17:14
th1aWe really just have to try it and see how it looks.17:14
th1aATM I feel like that would be called "Relationships"17:14
th1aBut basically, we just need to rough it out and get a sense of the whole thing.17:15
th1aSee how it feels.17:15
yvlI'll do some trying then ;)17:15
th1aGet our new calendar widget in there.17:16
yvlI should probably also do the add-and-add-next17:16
th1aWe probably need to style that a bit too.17:16
th1aOK, yvl can do that.17:16
yvlsounds like a plan17:16
th1aOK, so really, do you guys have any wishes about how to organize changing the rest of the app?17:17
th1aOr should I just decide?17:17
th1aIt will determine how the next six weeks go.17:17
yvlfirst and most important - whatever way is the easiest for you to manage17:17
* yvl would like to do plumbing17:18
yvlbut I can whatever17:19
yvlprobably it would be best to get the core working for now17:20
yvlit's annoying that I can't add courses17:20
th1aWell, yes.17:20
* replaceafill has to use an external instance to update the Data.fs :)17:20
* yvl too17:20
yvlcopy Data.fs17:20
yvlstart the instance17:20
yvlclick click17:20
yvlstop, copy back17:21
yvlstart the one I'm working on17:21
th1aWould you guys prefer to just be assigned pages to do from start to finish?17:21
yvlremember something17:21
*** asharma has joined #schooltool17:21
* yvl would prefer a mixed model17:21
yvlth1a got our roles right, I think17:22
yvlreplaceafill paints awesomely17:22
th1aAny objections?17:22
yvlaelkner, I'm really interested in your opinion on this17:23
*** AndChat has joined #schooltool17:23
aelkneron which task which of us gets next, on what colors to use, please ask again17:24
*** AndChat is now known as Guest8961617:24
*** Guest89616 is now known as menesis17:24
aelkneras far as what to do next, i'd say getting core add/edit views to work would be high priority17:24
aelknermyself, i have a demographics viewlet to write17:25
aelkneralso, action links17:25
aelknerclicking on School now yields an empty view17:25
aelknerit used to have Persons17:25
aelknerand other link, i can't remember17:25
th1aaelkner... the entire rest of the application doesn't work.17:25
aelknerso those are the two categories as i see them, add/edit, action link17:26
aelknerthese viewlet managers should start being used17:26
th1aWhat's on the table now is are you going to do whatever is required between yvl setting up the plumbing for each view and replaceafill tweaking the presentation?17:27
aelkneryvl went through the trouble of creating them after all17:27
th1aIf you're ok with that, we're done for today.17:27
th1aAnd if you're not ok, we're still done, but we'll have to keep talking about the issue.17:27
aelknerwhat about the demographics viewlet?17:28
th1aYes.  Do that.17:28
aelknershould that be a sortable table17:28
aelknerthe columns are:      Field       |       Value17:28
th1aSortable by what?17:28
aelknergood point17:28
aelknerthe fields might as well stay in the same order17:29
th1aWe're just generally formatting more things as tables.17:29
aelknerso i won't be creating a table formatter for it17:29
th1aaelkner:  you've got one minute to object to your new role.17:29
aelkneri'll just code the html table directly in the viewlet17:29
th1aaelkner:  Fine.17:29
yvlthat's ok17:30
aelknerdefine this new role17:30
th1aI did above.17:30
yvlmostly - porting views17:30
th1aOK, we're done here.  I'll flesh out the plan for tomorrow.17:30
* th1a drops the bag of gravel.17:30
yvland poking me when stuff is missing or inconvenient :)17:30
replaceafillyvl i have a request17:31
yvlth1a, if you happen to arrive at some revelations about person views, please email17:31
yvllistening, replaceafill17:31
aelknerguys what about the School tab?17:31
replaceafillcould you take the breadcrumbs list out of the secondary navigation?17:31
replaceafilli mean17:32
replaceafillit's ok to have it as a viewlet17:32
aelknerare you guys having to type persons in the url like i have to?17:32
yvlyes, aelkner17:32
replaceafillbut i don't like the css hack i did17:32
replaceafillby hack i mean absolute positioning :)17:32
replaceafillaelkner yes17:32
yvlwell, that's why I kindly left that to you17:33
th1ayvl:  I will.17:33
*** jelkner has joined #schooltool17:33
yvlto position it the way we want is a b*tch17:33
replaceafillyvl i thought "yvl should do this" :D17:33
yvlor to be more precise, I don't know how to do that cleanly17:33
replaceafilli'd vote for: <ul class="breadcrumbs"> <ul class="secondary_nav">17:34
* th1a runs some errands.17:34
replaceafillas siblings17:34
replaceafillbut it's not a big deal17:34
yvlsee you tomorrow, th1a17:34
yvlyou can do that, replaceafill17:34
yvlyou got the powa!17:34
replaceafilli want you to do it :D17:34
* replaceafill plays the plumbing card!!!17:35
yvlit was done that way, actually17:35
replaceafilli know :(17:35
* yvl plays the painter-that-is-some-times-also-a-plumber-actually card :P17:35
yvlbut ok17:35
yvlI can do that17:35
yvlbut you'll have to do the styling17:35
replaceafillsure, np17:35
replaceafillit's only that i dont like absolute positioning much17:36
yvlhmm, better yet!17:36
yvlI'll tell you how to do that :D17:36
replaceafillthe styling?17:36
yvlno, how to make them siblings17:36
replaceafillhhmm ok17:36
yvljust put it in the main pt17:36
replaceafillas it used to be?17:36
yvltal block17:37
yvland - tada!17:37
yvlit worky17:37
yvland yes, unregister the breadcrubms viewlet17:37
replaceafillbut now i have your permission ;)17:37
replaceafilli've been commenting stuff in case you're not ok with the changes :D17:37
yvlyou had it yesterday ;)17:38
replaceafillthanks yvl17:38
yvlfor the permission, right? :D17:38
*** menesis has quit IRC17:38
*** menesis1 has joined #schooltool17:38
*** menesis1 is now known as menesis17:38
replaceafillfor the permission and the advicing :)17:38
yvlwell, if that's that, I've got a birthday party to attend ;)17:39
yvlsee you guys17:39
yvlhappy coding!17:39
replaceafillhave fun17:39
replaceafillbring some cake ;)17:39
aelknerguys, please ping me when your conversation thread is over17:39
replaceafillit's over aelkner17:39
aelknerjust as i was typing :)17:39
aelknerso what's the deal with the persons flourish.zcml having the viewlets commented out?17:40
aelknerfor ManageSchoolLinks, that is17:40
replaceafillaelkner th1a decided to disable them17:40
replaceafillto make the School links disappear17:40
replaceafill(the ones you were asking about before)17:40
aelknerwhat are we doing in its place to get navigation working?17:41
replaceafillfor the moment nothing17:41
replaceafillwe have to type urls momentarily17:42
replaceafillor you can use bookmarks!! ;)17:42
replaceafillaelkner regarding the advisory viewlet, fix the advisees property17:42
replaceafillyou have:17:42
replaceafill    @property17:43
replaceafill    def advisees(self):17:43
replaceafill        return list(self.context.advisors)17:43
replaceafillwhich is wrong17:43
aelknergot it17:43
replaceafillall right17:43
aelknerwhat are you doing next?17:43
replaceafillmoving breadcrumbs and changing "edit" links in the accordions17:43
aelknerwhat after that?17:44
replaceafillhhmm will ask th1a :)17:44
replaceafillbut i want to fix a few styles in the forms too17:44
aelkneryvl will be fixing add/edit person, right?17:45
replaceafillaelkner i think so17:46
replaceafilland adding multiple (students, teachers, etc)17:46
replaceafilli like the way yvl designed the multiple person add form :)17:46
replaceafillvery clever17:46
replaceafilli exploited it in cambodia :P17:46
replaceafillbtw, aelkner17:46
replaceafillis this necessary:17:46
replaceafill    template = ViewPageTemplateFile('templates/')17:47
replaceafill    render = lambda self, *a, **kw: self.template(*a, **kw)17:47
replaceafillcant you just:17:47
replaceafill    render = ViewPageTemplateFile('templates/')17:47
aelknerlet me check17:47
yvlaelkner, no, you will not be fixing person forms17:48
yvlat least for now17:48
aelknerwhat are you doing next?17:49
yvlperson forms17:49
yvlat least I think17:49
yvlplease check with th1a when he gets back17:49
aelknerwhat about the code snippet directly above, i got those lines from following one of our viewlets17:50
aelkneri was going to ask you about that17:50
aelknerreplaceafill, as far as i can see, that wouldn't work17:51
aelknerbecause the first line creates the template17:51
aelknerthe second one calls it17:51
aelknerthough, if we added () to your idea.maybe it would work17:52
aelknertrying now...17:52
* replaceafill goes to have breakfast17:52
yvlI think you can also just specify the template17:53
yvland add render="template" to your viewlet registrations17:53
*** ignas has quit IRC17:53
yvlI sincerely don't remember now17:53
aelkneri needed to override render(), like you did in one of your viewlets17:53
yvlneed to write documentation at some point!17:53
aelknerbecause render has just pass in it17:53
aelknerand that gets called even if you override it in your own class17:54
yvlpersonally, I'd keep template variable named template17:54
aelknercouldn't we have the base class do the same thing the lambda does17:55
yvlsince directives can override that variable by specifying template=""17:55
aelknerso that the deriving class doesn't need to worry about rendering17:55
aelknerand can control things by defining the template17:55
aelknerthese base classes should do most of the work for us17:56
aelknercontrollable via attributes like template17:56
yvlyou're right aelkner17:56
aelknerand any others we decide we need in the future17:56
yvlthat one is a bit of unfinished business17:56
aelknerso can we finish it simply like i suggested above17:56
aelknerputting the call to the template in the render method of the base class?17:57
* yvl hasn't decided that17:57
aelknerbtw, yvl, we said we were going to play around with this stuff a while first17:57
aelknerbut if th1a wants us to start changing many views in the same manner17:58
aelknerwouldn't it be prudent to get this stuff out of the way soon?17:58
yvlgood point17:58
aelkneryou and i cold pair program on it17:58
aelknerwe could even use skype if you'd like17:59
yvlI think it would be quicker if that was just done17:59
yvl(if it was a live sprint, we would definitely pair-program)18:00
yvlso, here's the thing18:00
aelkneri'm not sure we should rule out pairing even remptely18:00
aelkneri did so with filip over the weeks leading up to our live sprint18:00
yvlI slightly don't want to put template = None into most base classes18:01
yvlI'd rather have meta directives imply render="template" and put that lambdas into class dict18:01
yvlif the template is specified18:01
yvlwhat would you think about that?18:02
aelknerdo you mean render="templates/'?18:02
yvlI mean - if you specify a template="..." in the directive18:03
aelknerlitterally render'template"?18:03
yvlor there is a template in the base dict18:03
yvland given class' render is not implemented18:03
yvlit's replaced with lambda that renders the template18:03
aelkneri'm assuming you are introducing this confusing flexibility for a reason18:04
yvlcurrently you can actually specify render="XXX" and update="XXX" in some directives18:04
yvlactually, yes :)18:04
aelkneryou were just saying18:05
aelknergo on18:05
yvlimagine you want to register the page that should render only the content_template18:05
yvlfor some modal dialog or other18:05
yvlcopy the directive18:05
yvland add18:05
aelknerah, got it18:05
yvlin reality that injects "render = lambda ****: self.content_template(***)"18:06
aelknerthe same precise python view class can be used to render full page18:06
aelkneror just content_template18:06
aelknerwhat are the full list of choices for render?18:06
aelknertemplate, content_template18:06
yvlactually - anything18:06
yvlit just forwards to another method, or template18:07
yvlif a class has18:07
aelknerok, so instead of the lambda for render i used, i should just use the zcml?18:07
yvldef render_modified(self, *args, **kw)18:07
yvlyou can say render="render_modified"18:07
yvlit should work18:07
yvlnever tested that :/18:07
yvlbut that was the intent18:07
aelkneri'l do that now18:08
aelknercould you stick around another fve minutes18:08
*** alga has quit IRC18:09
aelkneryvl, it works!18:10
aelknerhere's something to consider18:11
aelkneroh, you know what, never mind18:11
aelkneri think that directive will come in handy18:11
yvlgreat, aelkner18:12
yvlsorry again for no documentation18:12
yvlit *needs* to be written18:12
yvlwell, /me goes home18:13
yvlgood luck!18:13
aelknerthanks, see you tomorrow18:13
yvland if you run into some weird behaviour or bugs18:13
yvlplease email18:13
yvlI'll look into that18:13
yvlsee you tomorrow :)18:13
replaceafillaelkner you should rename to f_advisoryViewlet.pt18:28
jelknerth1a, are you here?18:29
jelkneri just tried to call18:29
replaceafilljelkner i think he went out18:29
jelkneri left a message on his phone18:30
th1aWhat's up jelkner?18:54
replaceafillth1a security question18:55
replaceafillthe accordions are protected with schooltool.edit18:55
replaceafillso the user can't see his own accordions18:55
replaceafillif he's not a manager18:55
replaceafillso, we need to change that to schooltool.view18:55
th1a Well, that's wrong, obviously.18:55
replaceafillshould other non-manager users view able to view his data?18:56
replaceafilli think that's an access control setting ,correct?18:56
* replaceafill goes look18:56
th1aThat should be an established issue.18:56
* th1a goes to take a shower.18:59
th1aI'll be back around 1:30.18:59
*** menesis has quit IRC19:03
*** menesis has joined #schooltool19:12
jelknerth1a, are you back?19:20
jelkneri tried to call you19:20
jelknerbut no answer19:20
jelknerasharma has completed the book19:20
jelknershe is looking for her next task ;-)19:20
jelknerand i want to know where to put it?19:21
replaceafillaelkner sync with trunk, i fixed the advisees problem, renamed the template and changed the permission of all the accordions19:21
jelknerit should be on the ST site, yes?19:21
* jelkner tries ringing th1a again... no answer19:23
replaceafilljelkner he said he will be back at 1:3019:23
jelknerok, replaceafill, thanks!19:23
replaceafillaelkner pushed edit icons for accordions to trunk19:35
aelknerreplaceafill, ok, thanks19:37
replaceafilllog in as alvaro and then as manager19:38
replaceafilli decided to let "edit" next to the pencil19:38
aelknerreplaceafill, i pushed a small fix to trunk19:48
aelknerjust got rid of some unnecessary view attributes19:49
replaceafillaelkner sync with trunk :)19:56
replaceafill"Cleaned flourish templates and added file resource for javascript code"19:57
replaceafilljavascript code for flourish is now under skin/flourish/resources/flourish.js19:57
replaceafillwow, resource library is smart :D19:58
aelknerreplaceafill, flourish.js seems like a general name20:01
replaceafillit is :)20:01
aelknerand you put person info stuff there20:02
aelknernot general20:02
replaceafilllet's not have this discussion again...20:02
aelknerok, forget it20:02
replaceafillwe can change it later ;)20:02
aelkneryeah, you and yvl have been saying that for a while now20:03
aelknerand when later comes and it's 5000 lines that need to change, i'll just laugh20:03
replaceafilland then you say: "see!??! i told you this would happen"20:03
replaceafill(i'm talking about flourish.js)20:03
replaceafillok, now breadcrumbs...20:04
replaceafillth1a hhmm i wonder if we should float those edit icons to the right, ala LP20:06
replaceafillth1a never mind, LP doesnt float them to the right as i thought :)20:07
replaceafillit's "above" the bug description to the right20:07
th1areplaceafill, You can take out the "edit"20:38
replaceafillah ok20:39
th1aAlso, the icon is riding a little low.20:39
th1aBasically, it is only a usability issue the first time you use the application.20:39
th1aWhich I think we can deal with.20:39
th1aCan you make it say "Edit" when you mouseover?20:39
replaceafillth1a you want the Edit as a tooltip? right now the tooltip says "Manage this persons'..."20:43
th1aTooltip, yes.20:43
th1aCan we make it different for each icon?20:44
th1aEdit advisors20:44
th1aEdit or manage?20:44
th1aManage advisors...20:44
th1aYes, like it is now is fine.20:45
replaceafillth1a so, same messages then?20:46
replaceafillwhat about the last one?20:46
replaceafillfor groups?20:46
replaceafill"Manage this person's memberships"20:46
replaceafillok, removing the "edit" link20:47
th1aWe need to deal with what to display if there is nothing in the table but the user has edit permission.20:48
th1aIn that case they should see the label and the edit link and... ?20:48
th1aEmpty table?20:48
replaceafillth1a refresh20:54
replaceafillaelkner sync with trunk, "Moved breadcrumbs out and changed edit links for accordions"20:54
th1aI'm not happy with just the table header.20:55
replaceafillconditional "There is none"?20:56
replaceafillwhat i'm unhappy with is:20:57
replaceafillcheck alvaro20:57
replaceafillsee Sections20:57
replaceafillsee the table headers20:57
replaceafillthey're not aligned20:57
th1aI see.20:57
replaceafillwe need to class those two at least20:57
replaceafilltheir width is automatic20:57
th1aYes, that can be manual.20:58
replaceafillwhat would be appropriate widths for the columns? 33% each?20:58
th1aWe can't really say how big each one is.21:00
replaceafillaelkner sync with trunk: "Fixed widths of section tables in person view"21:09
replaceafillwe need a bot to track flourish trunk in IRC ;)21:09
th1aI would say make years narrow but some people give them long names.21:10
replaceafilllonger texts will flow in the cell21:11
replaceafillth1a i'm going out to run some errands, will be back in an hour or so21:12
replaceafillneed something to do next :)21:12
replaceafill(i think my queue is empty...)21:12
aelknerth1a, a question about the demographics21:13
aelknerthe accordion should be labeled Demographics, i imagine21:13
aelknerwhat would the header of the content be?21:14
th1aI don't know what else I'd label it.21:14
*** asharma has quit IRC21:14
th1aMaybe just Label | Value ?21:14
aelkneri have Field  |   Value for the table, but i can change that21:15
th1alabel is a little less tech.21:15
aelknerthing is, if there's nothing before the table, it's a bit toppy21:15
aelknerok, label it is21:15
aelknerso the heading would help visually, but also provide a place to put the pencil21:16
aelknerwhat do you think?21:16
* replaceafill goes out21:16
*** replaceafill has quit IRC21:16
th1aMaybe just "Demographic and other data"21:17
aelknerah, a sentence :)21:17
th1aWe can't really meaningfully label something that is customizable.21:17
aelknerand the pencil?21:18
th1aWell... it isn't necessarily all demographic data anyhow.21:18
th1aYes, use it.21:18
aelknerright, not all demographics21:18
aelknerhow about not calling the accordion Demo.., but Attributes or something general21:19
aelknerhow about breaking up the fields into two tables, following the pattern already established21:19
aelknerin the edit and add views21:19
th1aActually, good point.21:20
aelkneraccordion: General Information21:20
aelknerBut the headings for the tables cold match those of the fieldsets in the edit views21:20
th1aIf anything more generic like Attributes21:20
th1aYes, they should.21:21
aelknerAttributes is fine for me, how about the headings21:21
aelkneroh, you answered that21:23
th1aBasically, nothing is set in stone at this point anyhow.21:23
th1aAnd since we're not breaking tests when we change verbiage at this point, assume it is a draft.21:24
aelknerok, i know enough to code it now21:26
*** menesis has quit IRC21:48
aelknerth1a, i pushed the demographics person info viewlet to trunk22:58
aelkneryou can pull to your own instance if you want to look before douglas gets bacm22:58
th1aYEah, I have to start over on mine though.22:58
aelkneri was thinking that Attributes should be the first accordion, and thus, open by default23:00
aelknerbut if the content is long (lots of demos) then the other accordions will not be23:00
aelknervisible unless you scroll down23:01
th1aNo attributes shouldn't be first.23:02
aelknerwhat should the order of the accordions be23:03
aelknerright now they are arbitrary23:03
th1aYou could send me a screenshot while I download eggs.23:03
aelkneri need to learn out how the viewlet manager sorting works23:03
*** replaceafill has joined #schooltool23:05
* replaceafill is back and soaked...23:06
* replaceafill updates the testing instance23:07
th1aOK, take out the edit text.23:07
th1aMove the value over to about 1/3rd instead of 2/3rds.23:07
th1aDon't we have human readable labels?23:08
th1ainformation should not be caps.  ;-)23:08
replaceafillaelkner copy the edit button from the other viewlets23:08
replaceafill(advisory and groups)23:09
th1aThis is pretty much where aelkner will be handing things off to replaceafill and I for the next two months.23:09
aelknerreplaceafill, what do you think i did?23:09
replaceafillaelkner the updated version ;)23:09
aelknerreplaceafill, could you be more specific about the change?23:11
replaceafillaelkner the edit link23:11
replaceafillin General information23:11
replaceafilland Demographics23:11
replaceafillhave you sync'ed with trunk?23:12
replaceafilllook Advisors and Advisees23:12
aelkneri did twn minutes ago23:12
replaceafillsee that there's no text?23:12
replaceafilljust the pencil23:12
aelkneri see edit23:12
replaceafillagain, have you sync'ed WITH trunk...23:13
* replaceafill goes see aelkners branch23:13
aelkneri merged my changes to trunk, not the other way around23:13
replaceafillevery time i suggest "sync with trunk" i mean, pull changes from trunk to your personal branch23:14
replaceafilli call "merging to trunk", push :)23:14
aelknerok, got it23:14
replaceafillth1a what's next?23:15
* replaceafill reviews the logs in case he forgot something23:16
aelknerreplaceafill, pushed edit change to trunk23:19
replaceafillk, pulling23:19
replaceafilli wonder if we should use an fragment identifier for those Attribute edit links23:20
replaceafilllike @@edit.html#demographics23:20
replaceafillso when the user changes to the form, he's put right in the demographics space23:21
replaceafillnah, too much :/23:21
replaceafillis the change to [Cancel] [Apply] intentional?23:23
aelknernot such a bad idea at all, i could add that to the link for demographics23:23
replaceafillaelkner nah, we would have to modify the form23:24
aelknerright, forget it then :)23:24
replaceafillor... we could use jquery ;)23:24
replaceafillnah, forget it too :d23:24
aelknerthere are plenty of other things to do23:24
th1aSo... what's the deal with the label text for attributes?23:27
aelknerth1a, i'll change that now23:32
th1aGender is part of demographics.23:34
th1aThe other things are all "demographics" demographics though, right?23:35
th1aSee, I was thinking "General Information" as its own accordion.23:36
replaceafillfirst accordion23:37
th1athe "Attributes" accordion as a second one.23:37
th1aWhat should be open is just "who is this person."23:37
th1aThat is, that's what you should see when the page loads.23:37
aelknerreplaceafill, pushed label fix to trunk23:43
replaceafillpulled, refresh23:44
aelknerth1a, ok i see you want general information as separate accordion23:44
aelknerDemographics as another accordion?23:44
th1aAccordion #1 -- General Information23:47
aelknerwe will need heading for the content are for appearance and the pencel23:47
aelknersame for the heading?23:47
th1aMake the label the full name.23:48
th1aprefix + first + middle + last + suffix23:48
th1aAccordion #2 -- Attributes23:49
th1aLabel: Demographics and other personal data23:49
th1aThat'll do for now.23:49

Generated by 2.15.1 by Marius Gedminas - find it at!