IRC log of #schooltool for Wednesday, 2011-06-15

*** dadeng has quit IRC00:05
*** dadeng has joined #schooltool00:26
*** dadeng has quit IRC00:41
*** replaceafill has quit IRC01:17
*** menesis has quit IRC01:41
*** replaceafill has joined #schooltool02:07
*** aks has joined #schooltool06:17
*** th1a has quit IRC06:56
*** yvl has quit IRC07:09
*** yvl has joined #schooltool07:16
aelkneryvl,  ayt?07:33
yvlgood evening, aelkner07:33
aelknerwow, it's early for you07:33
aelknerwhat time is it there?07:33
yvl7:3007:34
aelknerearly bird, are we?07:34
yvlI love my job that much ;)07:35
aelkner:)07:35
aelkneri assume that you will merge every morning, right?07:35
aelknerso i don't have to ask you needlessly07:35
yvlof course07:35
aelknerjust making sure07:35
yvlactually I tend to do that by the end of my day07:35
aelknerwhich is still the beginning of ours07:36
yvlright07:36
aelknerwell, have a good one, and see you at the meeting!07:36
yvlsee you soon07:37
* yvl goes to look at your latest changes07:38
*** dadeng has joined #schooltool08:57
*** ignas has joined #schooltool10:19
ignasyvl, ping!10:29
yvlpong, ignas10:29
ignasyou prolly solved the security policy reporting problem already10:30
ignasbut still10:30
ignaswanted to share an awesome solution to it10:30
* yvl listens :)10:30
*** menesis has joined #schooltool10:31
ignashttps://github.com/Pylons/pyramid/blob/5484e3e9be61b82b55e6e1e94365cfb3cd4d3a94/pyramid/security.py10:31
ignasACLDenied and ACLAllowed classes10:31
ignassimple and quite elegant10:31
ignasand kind of *duh*10:31
*** menesis has quit IRC10:33
*** menesis has joined #schooltool10:36
yvlvery elegant!10:37
yvland it is a *duh* moment10:38
yvljeez10:38
yvlthanks :)10:38
* ignas still is having, 4 years, 4 friggin years, and I could not come up with this!10:39
*** replaceafill has quit IRC10:43
yvlso obvious now10:45
* yvl is ashamed10:45
*** alga has joined #schooltool10:46
ignascredit goes to Chris McDonough (repoze, pyramid)10:56
yvlthat guy is quite awesome himself, I agree ;)11:01
*** dadeng has quit IRC12:03
*** dadeng has joined #schooltool13:40
*** dadeng has quit IRC14:03
*** aks has quit IRC14:19
*** menesis has quit IRC14:24
*** dadeng has joined #schooltool14:34
*** dadeng has quit IRC15:09
*** dadeng has joined #schooltool15:25
*** jelkner has joined #schooltool15:26
*** th1a has joined #schooltool15:27
jelknergood morning th1a!15:28
th1ahi jelkner.15:28
*** fsufitch has joined #schooltool15:30
jelknergood morning fsufitch!15:30
fsufitchjelkner: morning to you too :)15:30
*** menesis has joined #schooltool15:34
yvlth1a, all latest work pushed to central branch15:52
th1athanks yvl.15:52
yvlif you're up for it, you can check it out before the meeting15:52
th1aI am up (for it).15:52
yvl:)15:52
yvlthere are too much person links ATM15:53
yvlespecially "Add Person" and "Add Persons"15:53
yvlso you could compare multi-add and simple add side by side15:53
yvloh, and if you have a data fs with sections and their members set up15:55
yvlyou can also check out Alans work (better)15:55
th1aYes... I thought I tried to explain that... all of the add forms should be changed to allow you to add multiple students.15:55
*** replaceafill has joined #schooltool16:06
* th1a is getting his populated Data.fs in the right spot...16:13
th1aAGH.16:13
th1a  File "/home/hoffman/Desktop/flourish/eggs/zope.app.appsetup-3.14.0-py2.6.egg/zope/app/appsetup/bootstrap.py", line 77, in ensureUtility16:14
th1a    if (reg.provided.isOrExtends(interface) and reg.name == name)]16:14
th1aAttributeError: type object 'ICustomScoreSystem' has no attribute 'isOrExtends'16:14
th1aWhat might that be?16:21
replaceafillthe testing instance with current trunk + small css changes we made yesterday:16:21
replaceafillhttp://69.164.203.135:6660/persons16:21
replaceafillgood morning all, btw :)16:21
th1aThat error is from using a .deb Data.fs with flourish branch.16:21
th1aPeople!16:22
replaceafill:D16:22
th1aaelkner:  Looking pretty good!16:23
* th1a goes to get more coffee.16:28
yvlth1a, you can put schooltool.gradebook at eggs= in buildout.cfg of your flourish branch16:29
aelknermorning all16:30
yvlright, coffee!16:30
yvl3 mins16:30
th1a[package]16:34
th1aeggs = schooltool schooltool.gradebook ?16:34
yvleggs = schooltool16:34
yvl <some spaces> schooltool.gradebook16:34
yvlthat's the old "once you plug it in, you've plugged it in" thing16:35
th1aValueError: ('Expected version spec in', 'schooltool, schooltool.gradebook', 'at', ', schooltool.gradebook')16:35
th1aDo I need to make clean or something?16:35
th1aAnyhow...16:37
th1areplaceafill:  Cambodia squared away for now?16:37
replaceafillth1a yes16:37
th1aGood.16:37
th1aaelkner: status?16:37
aelknerwell, i made new versions of the viewlets and made tables for groups and courses16:38
aelkneri guess now we should just look it over together and make any adjustments you want16:38
th1aOK.16:38
aelknerreplaceafill, is the latest instance loaded?16:38
replaceafillaelkner yes16:38
yvlit looks a bit weird16:39
aelknerwhat's the ip again?16:39
th1aOK, let's all look at http://69.164.203.135:6660/persons16:39
yvlfor example, in the login screen, there's some empty bar visible at the left column16:39
menesisth1a: strange error. send me full traceback later.16:39
th1akk16:40
yvlsame in person's index.html16:40
yvljust FYI16:40
th1aYes, we're in a weird state atm.16:40
replaceafillyvl you mean the padding in the content container?16:40
th1aWe kind of threw things off trying to separate the sidebar and the main content.16:41
th1aHow do we feel about the basic look (sidebar and content separated this way)?16:41
replaceafilli don't like the 32px padding at the top of the main content16:42
th1aThis will almost certainly change before the final version, but is the basic look ok?16:42
replaceafillbut that's the uwg :/16:42
th1aI'm not going to sweat the vertical spacing at this point.16:42
replaceafillcool16:43
th1aI'd say our natural tendency would be to cram stuff too tightly.16:43
th1aAnd it is easy enough to cram later.16:43
yvltrue16:43
th1aSo basically we're going to nitpick these two views for a while.16:44
th1aIn case you were wondering about the agenda.16:44
th1areplaceafill:  adding that white divider threw a lot of other stuff off.16:45
th1aAre we going to be able to fix that?16:45
th1aOr is it a whole cascade of issues?16:45
replaceafillth1a we can revert it easily16:46
replaceafillwant me to revert it?16:46
th1aI'm just getting the feeling that we did a quick change to one part that will require a whole sequence of complicated changes.16:47
th1aAnd perhaps there is another approach we should have taken.16:47
th1aBut yes, maybe we should revert for now.16:48
th1aAlthough I like the spacing now.16:48
th1aSo don't revert everything.16:48
replaceafillreverted16:48
replaceafill:/16:48
replaceafillok, putting it back...16:48
replaceafillspaces back16:49
th1aCan we have the new spacing and old background?16:50
* yvl does not understand the choice not to follow the guidelines here - or Ubuntu pages themselves for that matter - but that's ok ;)16:51
th1aThere are no guidelines for sidebars.16:51
replaceafillth1a like this?16:52
yvlif you say so16:52
th1ayvl:  I would be happy if there were.16:52
th1aThis is the kind of futzing around we're trying hard to avoid.16:52
th1aCan we just fake a divider here with, say, a 16px white left border on the main content area?16:53
yvlpage.. 10 maybe?16:53
th1aThat wouldn't mess up the rest of the margins?16:53
yvl(btw, replaceafill there's a bug in page 21... can you spot it? ;) )16:55
yvlapologies for interruption16:56
th1areplaceafill?16:56
th1aOK, replaceafill, I need you to talk some.16:57
replaceafillhold on, i'm trying to put the white dividier16:57
th1akk.16:57
replaceafill:)16:57
th1aI don't literally want to spend the meeting time doing this.16:57
replaceafillwe shouldn't...16:57
replaceafilli'd like to revert everything and do it after the meeting16:58
replaceafillyvl bug?16:58
* replaceafill looks16:58
yvlplease don't do that now ;)16:58
th1aOK.16:58
yvloh, and please remeber the CSS box model16:58
th1aMoving on.16:58
yvlwhen doing borders16:58
yvlif you add a 1 px bottom border, you need to take 1 px from something else16:59
replaceafillah yes, width = border + padding + content17:00
th1aOK here's one issue: I'm feeling like we should switch to first name last name in most cases (say, in the secondary navbar).17:00
th1aTop of person page, etc.17:00
yvlor else you get twitchy error messages in forms when you select the fields with errors17:00
th1aBUT tables should put lastname in leftmost column.17:00
* yvl is up for the task17:01
th1ayvl: name switchery?17:01
yvlyes17:01
th1aLike, today?17:01
yvlok17:01
th1aI guess it doesn't matter.17:01
th1aMark won't be thinking about that.17:01
yvl:)17:01
th1aBut yes, yvl can do that.17:02
yvlthanks17:02
th1aOK though -- NEW RULE.17:02
th1aaelkner, got it?17:02
aelknergot what?17:02
th1aFirstname Lastname in most displays.17:02
th1aLastname in leftmost column in tables.17:03
th1aOK?17:03
yvlI'd like if people used something centralized17:03
yvlit's not like that rule applies to the whole world17:03
aelkneryeah, we need a new title attribute17:03
yvlso the rule should be - don't invent your own17:03
replaceafilli remember yvl writing a blueprint about that17:03
replaceafill:)17:03
yvlit bugs me still17:03
th1aYes..17:04
th1a.17:04
th1asurname in leftmost column.17:04
yvlagreed17:04
th1aTitle can just be first last as entered.17:04
th1aWe don't have to reverse it.  ;-)17:04
yvlI want to make it easy to add that option to ST app settings17:05
th1aI think that was originally just for sorting reasons.17:05
th1aOK.17:05
th1aOtherwise, let's look at the secondary nav bar.17:05
th1aThe problem is that it feels like the breadcrumbs should be align left and name/log out align right.17:06
th1aBut I don't want to hide the logout on narrow screens.17:06
th1aSo I'm a little stumped.17:06
th1aThe way it is now works but feels a little off.17:06
th1aThoughts, feelings?17:07
th1a(aren't you glad we figured out a way to avoid 90% of these conversations)17:07
yvl:)17:08
menesisof course breadcrumbs should be on the left and Name (logout) right17:08
menesis:)17:08
yvlhttp://shop.canonical.com/17:08
yvl:D17:08
menesisthere's no breadcrumbs17:08
th1aI think we'll just do that.17:08
th1aFor now.17:08
th1aAnd basically we'll make a list of questions to ask one of the designers at our disposal.17:09
* yvl hates that type of CSS17:09
yvlcan replaceafill do it? :)17:09
th1aYes.17:09
th1areplaceafill:  That's on your list for later today.17:09
replaceafillok17:09
th1aOtherwise I'm feeling ok about that space.17:10
th1aWe can take out the School section in the sidebar since we have other stuff to hold the sidebar open.17:11
replaceafillyvl can we take out the breadcrumbs ul from the secondary_nav?17:11
th1ayvl:  Does everyone see "Application" in the top bar or just the manager?17:11
yvlshould be just the manager17:11
menesisyvl: about the display name. that should be a property, person.display_name or something, and a preference in app settings.17:11
yvlsorry, just administrators17:11
th1ayvl: right17:12
menesisalso something is wrong with security17:12
yvlmenesis - maybe17:12
yvlyes?17:12
menesissome people cannot access other people names17:12
yvlprobably17:12
menesiswill find a bug17:12
th1amenesis:  some people aren't supposed to be able to access other people's names.17:13
menesisnot a crash17:13
yvlreplaceafill - you can do whatever you want with breadcrumbs, as long as th1a is ok with it :)17:13
th1aI'm not sure what the question is.17:13
replaceafillyvl understood17:13
th1aOK.17:14
menesishttps://bugs.launchpad.net/schooltool/+bug/68328617:14
th1aI'm on a need to know basis.17:14
th1amenesis:  Thanks.17:14
yvlthanks, menesis17:15
menesisto reproduce, try cando with schooltool trunk17:16
yvljust remember, that breadcrumbs ten to be long17:16
menesistest17:16
yvland some people also have long first / last names17:17
th1aWell, we have a nice wide bar up there.17:17
th1aOK, more sidebar.17:17
menesisbreadcrumbs... I would just put name/logout on the right now17:17
menesisand see what happens later17:17
menesisthere's nothing else to put in secondary nav for now17:18
th1aLets go with:17:18
th1aAdd...17:18
th1a    Person17:18
th1aetc.17:18
th1aAnd style it like http://ubuntu-news.org/17:18
th1areplaceafill can do that later too.17:18
replaceafill:)17:19
th1aAnd in the very near future we need to change all the add person views to include the "add persons" functionality (by adding another button).17:19
th1akk?17:19
yvlk17:20
th1aAnyone else have any thoughts before we move to the person page?17:20
th1aOK, onto alvaro alvarez.17:21
replaceafillthe hover for accordions show the orange border17:21
th1alol17:22
replaceafillah, and i need to change the icons to be white...17:22
th1aWhat style is "Sections Taught?"17:23
yvlh317:23
yvlno style17:23
aelknerthat is still an <h3>17:23
th1aWhere is the margin bottom?17:24
replaceafillheader elements dont have margins at the moment17:24
replaceafillh1.. h617:24
aelknerit doesn't have to be an h3 if we already styled a different h17:24
th1afix that.17:24
aelknerah17:24
th1aCan we make all tables sortable?17:25
aelknerwe need the same type of thing as table.css for headers?17:25
replaceafillaelkner ?17:25
aelknertable.css makes it so that one doesn't even need classes anymore17:26
aelknerbecause the table has standard styles for the elements17:26
replaceafillyes17:26
aelkneri'm just asking if we can have the same for headers17:26
replaceafillaelkner we should :)17:26
th1aI think that's the point of all this.17:26
aelknerheaders.css?17:26
replaceafillaelkner, headers are defined in flourish.css17:27
aelkneri like the idea of breaking this stuff down by easy to follow file names17:27
aelkneryvl said we had no styles for headers17:27
replaceafilli was tempted to include the table css in the flourish.css file :P17:27
aelknerreplaceafill, don't entertain such temptations17:28
aelknerlet's use easy to follow/find file names for css17:28
th1areplaceafill: You're CSS Czar.17:28
th1aDo we want one big one or lots of little ones?17:29
yvl+1 for table.css with decent table classes17:29
aelknerso if replaceafill says, 'put everyth9ing in one css file', you'd be ok with that17:29
aelknerth1a, you think maybe having a little input from your developers may be a good idea?17:30
replaceafill:/17:30
th1aFor basic elements that all components use, it is plausible.17:30
th1areplaceafill has your input, aelkner.17:30
replaceafillcan we take the css czar title away from me :)17:30
th1aThere seems to be no objection to multiple css files.17:30
aelknerwhat is with the whole tzar concept, are we lovers of Bush 117:31
aelkneror was it Carter?17:31
aelkneranyway, my point is, i'm pushing for ease of code reading17:32
th1aThe idea is to avoid tedious arguments and keep moving along.17:32
aelknerwhich helps improve productivity of developers17:32
th1aLook, lots of little files is not inherently better than one central one.  They both have their times and places.17:32
* replaceafill remembers to use the minified version of jquery-ui.js :)17:33
th1aAnd dividing a big CSS file into several is not hard if it is well organized.17:33
th1aSO...17:33
th1areplaceafill:  Are you OK with the multiple file approach?17:34
replaceafillsure17:34
th1aOK, settled.17:34
th1aMoving on.17:34
th1aCan we make all tables sortable?17:34
replaceafillwe need to use table formatters for that17:35
replaceafilleverywhere17:35
aelknerright, i didn't use that for the viewlets17:35
th1aIs that hard?17:35
aelknerwell, yes17:35
replaceafilli'd say tedious, not hard17:36
replaceafill:)17:36
aelknertable formatters are tedious, ues17:36
aelkneryes17:36
th1aWhat's the difference?17:36
aelknerright, tedious = hard17:36
aelknerin that it takes time, is expensive17:36
aelknerif we could create more convenient base classes for tables...17:37
yvlthat also takes time ;)17:37
yvland it's plumbing ;)17:37
th1aWhat do you need to do with the table formatters?17:38
th1aA bunch of registrations?17:38
replaceafillth1a i think the registration is easy, building the columns is not17:38
aelknerand some tedious plumbing in each view that uses them17:39
replaceafillyou need getters for every column17:39
aelknerright, a real pain17:39
aelknerthe thing is, if we looked into improving the class structure for this stuff17:40
yvlkeep in mind, that they're also registered on context,request at the moment17:40
aelknerthe payoff would be hig17:40
aelknerhigh17:40
th1ayvl:  What are the implications of that?17:40
yvlhmm17:41
yvlthey're crappy and inconvenient now, that is obvious17:41
yvlalso, they're quite pesky when it comes to registering stuff for views, IIRC17:41
th1aBasically I want to use tables more in general (as opposed to, say, lists) and I'd like them to be consistent in their functionality.17:42
th1aNot some sortable, some not.17:42
yvl+1 on the approach17:42
aelkneryes17:42
yvlI don't know how much that would take and what needs to be done ATM17:42
th1aOK, yvl, you could take a look into that.17:42
yvlwill do17:43
aelknerwe could pair program on that17:43
yvlsorry, no17:43
th1aI don't want to go there right now.17:43
yvlunless you want to go thinking about catalogs and other stuff also17:43
th1aOK... moving on...17:44
th1aJust want to hit a couple more points here.17:44
aelknerjust as long as you come up with someting convenient :)17:44
yvlaelkner - of course!  They bug me a lot :)17:44
* yvl always forgets the quirks and gets annoyed by them17:44
th1aSo something like "edit advisors," in the body of the accordion should be bare links, not buttons, right?17:44
th1aButtons should be for submitting forms.17:44
th1aOr cancelling.17:45
yvlsounds right17:45
yvland those links can do modal dialogs17:46
yvlIMHO17:46
yvlwhere needed17:46
th1aYes.17:47
th1aAlso, here's a long running paper-cut.17:47
th1aCan we just make the default capitalization of random snippets:17:47
th1aFirst word caps, later words not.17:47
th1aIncluding table headers.17:48
th1a?17:48
yvl+2? :)17:48
yvlno, +3 maybe?17:48
yvlI don't know which capitalization rules are better17:49
yvlbut I'm all for consistency in that matter17:49
aelknerisn't the literary rule appropriate here17:50
aelknerall first letters caps for titles17:50
aelknerexcept preositions and articles17:50
th1aWell, what's a title.17:50
aelknera heading of a table is like a title for that column17:50
menesishttp://developer.gnome.org/hig-book/stable/design-text-labels.html.en#layout-capitalization17:50
menesiscapitalization rules17:51
th1aAh.17:51
aelknerso i was right17:51
yvlcan we adopt them?17:51
yvlplease? :)17:51
th1aOK, those are the rules.17:51
replaceafillhow important are those rules for translated content?17:51
th1aYes aelkner, you're right.17:51
yvlaelkner - WIN ;)17:52
menesisjust something to have in mind when adding text17:52
aelknerit has to happen once a year :)17:52
menesisreplaceafill: each language has their own rules17:52
th1aSomething to keep in mind as we review EVERY PAGE IN THIS APPLICATION.17:52
th1aSo... aelkner has plenty to do on the person view still, correct?17:53
th1amodal dialogs, etc.17:53
menesisin Lithuanian everything is  sentence capitalization, no Capital Letter in a Middle of Phrase17:53
aelknerdefinitely that is going to be language dependent17:53
replaceafilli guess my point is that we can put lot of efforts on "code" capitalization, we dont have entire control on the output17:54
th1aSure.17:54
th1aBut for English, we'll follow GNOME.17:54
aelknerth1a, i thought today, you and i would first look at what we have and nitpick the viewlets17:54
aelknerthen i cold do some modal dialogs17:55
aelknerbut i need links for that17:55
menesisfor edit advisors, edit groups... etc I would just replace those links with an edit icon, like in launchpad17:55
th1aYou need links?17:56
th1amenesis:  What, a little pencil?17:57
menesisth1a: yes17:57
th1aI guess we could, since we're already taking the space to label them.17:58
th1aSections taught (edit)17:58
th1aGood idea menesis.17:59
th1aaelkner:  what do you need links for?18:00
aelknerwell, i was was thinking about the action buttons that are not in the sidebar yet18:02
aelkneralthough we have links (or a pencil) in the viewlets already18:02
aelkneror is the sidebar only fro navigating away from the person?18:03
th1aThe sidebar is for things that don't go elsewhere.18:03
aelknerso for editing things, right?18:03
th1aIt is for things that wouldn't be better off going someplace else.18:03
aelknerchanging the thing you're looking at in the content18:03
aelknernice non-statement, you should enter politics18:04
aelkner:)18:04
th1aaelkner:  it is for "other."18:04
menesisAdvisors: Bob, Jim (edit)18:04
aelkneranyway, that's what i meant about links for calling p modal dialogs18:04
menesiscertainly one of links that goes near the content, not in sidebar18:05
th1aI think we've got them, pretty much.18:05
aelknerth1a, you mean the viewlets will have the links we need?18:06
replaceafilltake into account that all those links (in accordions) are for relationship views18:06
replaceafilland i think it's really hard to make that view modal18:07
replaceafillas it is right now18:07
th1aI thought we'd made progress on that.18:07
yvlI'd say - some18:08
th1aaelkner:  I'm looking at the links on your current implementation, and that's basically how they should be.18:08
replaceafillyvl does flourish have a new relationship view?18:08
th1aI guess that would be step 1.18:09
yvlreplaceafill, no18:09
aelkneroh, what about person preferences?  that needs a link18:09
th1aThat goes in the sidebar.18:09
yvlindeed18:10
th1aOK, but we need to make a decision about these relationship views.18:10
th1aWe can (aside from updating the styles):18:10
th1a1) do nothing;18:10
th1a2) keep the same functionality but make them modal, which I think would moderately improve the user experience;18:11
th1a3) just re-implement the view from scratch to make it better (modal or not).18:11
th1a3) would include, say, drag and drop functionality.18:11
yvlmaybe we can do all three?18:11
th1aOr some other inspiration I don't have.18:11
yvlstep-by-step18:11
th1aWell... it is not worth doing 2) if we're doing 3).18:12
aelknerstep 1) is already done :)18:12
yvlno, it's not18:12
replaceafill:D18:12
yvlthey're not working now, are they18:12
yvlor did I miss something18:12
th1aThey probably need tweaking.18:12
menesisfor Person, in sidebar would go: Preferences, Calendar, Gradebook, Reports, Interventions, Export... and this is the right sidebar (related), not left.18:12
th1amenesis:  If that goes in the right the left is empty.18:13
th1aI think we only need one sidebar.18:13
yvlI don't, but that's another matter ;)18:13
th1aAlso, probably most of that goes on top.18:13
replaceafilli'd like two sidebars, but i dont like they're too tiny18:13
menesisthat's how yvl explained the organization of the page to me18:14
menesison left go filters, navigation18:14
th1aWell, I'm not convinced I've got yvl on the same page.18:14
yvlI'm pretty sure we're not18:14
menesison right go actions18:14
yvlbut I'll follow th1a :)18:14
th1aAs of this point there is no right sidebar.18:15
th1aIt does not exist.18:15
th1aAnd, at this point, the primary function of the top navigation is the same as it is now.18:15
yvlanyway18:16
yvlfor relntionship views18:16
fsufitchso, there is no unit testing of the adapters in schooltool.course.course18:16
yvlI vote - port them and do nothing more now18:16
fsufitchjust dropping this thought in18:16
aelknerfsufitch, we're not in a place to discuss that right now18:17
yvldamn, you had to notice that18:17
fsufitchi know, which is why i'm not pushing it18:17
th1aThank you fsufitch.18:17
fsufitchbut it came up in writing my own tests, and i had to write a silly stub to make the course adapters work18:17
fsufitchanyway, carry on18:17
fsufitch :)18:17
th1aOK, so we won't worry about the relationship modals.18:17
th1aWe'll just make those regular links.18:18
th1aAll right, let's break this up, take a 10 minute break, and then replaceafill, aelkner and I will just continue with specific changes to the views we've been working on.18:19
th1aOK.18:19
th1a?18:19
replaceafillcool18:19
* th1a drops the bag of gravel.18:20
replaceafillyvl the bug in page 21 is the total width of the form, right?18:20
replaceafillit's wider than 544px18:20
yvlwe can work on them more later18:24
*** yvl has quit IRC18:24
th1aaelkner:  Ready?18:31
aelknerready18:34
aelknerwhat does excess flood mean?18:35
th1aOK.18:35
th1aEjaculation.18:35
replaceafill:))18:36
aelknerthaks for the sarcastic non-answer, i always like that18:36
aelknerbut it doens't matter18:36
aelknerwhat do we want to look at first18:36
th1aOK, aelkner, can you start by getting our header styles in line with what's on page 17?18:36
aelknerreplaceafill, headers.css, pretty please18:37
replaceafillthen we'll have paragraphs.css18:37
replaceafilldivs.css18:37
replaceafilljust think as headers as "general" styles18:38
replaceafilland general styles go into flourish.css18:38
aelknerok18:38
aelknerso i see they don't have everything they need yet18:38
aelknerlike spacing18:38
replaceafillcorrect18:38
th1areplaceafill:  You can try to sort out the sidebar/main issue.18:39
replaceafillok18:39
replaceafillso, we're getting rid of the right sidebar, correct?18:39
replaceafilli'll remove it from the template and adjust the css18:40
th1aAs far as I knew it never existed.18:40
aelknerreplaceafill, now would be a good time to sort our the h5 h3 thing18:40
th1aI think h5 no longer exists to us.18:40
replaceafillaelkner definitely18:40
aelknerdoes the accordion need to use an h element for the header?18:40
replaceafillaelkner just go in descending order according to p1718:40
replaceafillthe accordion can use anything18:41
replaceafillyou define that selector when you're setting it up18:41
aelknerwell, perhaps we should avoid using an h for that18:41
aelknersince we will want h elements to style a certain way18:41
replaceafillaelkner i think the issue is Sections Taught18:41
aelkneri know, but18:41
replaceafilland that's not an accordion header18:42
aelknerin order to choose the h element for that, i wanted to sort out the accordion header18:42
th1aI'm not clear on what aelkner is referring to.18:42
th1a"Sections" or "Sections taught"?18:42
aelknerSections18:42
aelknerwe should use an element there that doesn't already have style choices assigned to it18:43
th1aWe're following the standard already, right?18:43
replaceafillaelkner it doesnt matter, you styled the accordion heaeders already18:43
replaceafillaelkner suppose i use <h1>s for the accordion header, it doesn't matter because .ui-accordion-header sets it up completely18:44
aelknerby class, right18:44
replaceafillmy problem is the content of the accordion18:45
aelknerso if we use h1 for the accordion header18:45
replaceafillthat needs to use "general" styles18:45
aelknerthen the general styles will not apply to it?18:45
th1a... the accordion widget styles we can't do much with.18:45
aelknerbecause the class styles will override it?18:45
replaceafillaelkner correct18:46
th1aSo that's fine as is.18:46
replaceafillaelkner for the content of the accordion you just decide what standard style you need18:46
replaceafillaccording to page 1718:46
aelknerwe're getting to that18:46
aelknerfirst, i'm going to change the accordion, hence, the viewlets18:47
th1a...18:47
th1aCan we get the header styles correct first?18:47
aelknerok, fine18:47
replaceafillto me, accordion content should use Header 3 (as it is)18:47
aelknerwhat h elemet do we want for Sections Taught18:47
replaceafillpage 1618:47
replaceafillwe just need margin-bottoms for headers18:48
th1aYes.18:48
aelknerso th1a, about the tables18:48
th1aYes?18:49
aelknerremember we changed the according header styles because we thought we would need sub-headings for the tables18:49
aelknerbut we don't if we use h3 instead18:49
aelknerbut i stil like the color choices for the accordions18:49
aelknerand we don't need to use table heading/sub-heading18:50
th1aYes... I see.18:50
aelknerif you like the h3 in its place18:50
th1aOh...18:50
aelknerpersonnaly, i'm not crasy about the look of the tables in the guidelines18:51
aelkneri mean with the subheadings18:51
aelknerbut that's your call18:51
th1aWell... since we need two edit links anyhow, the current implementation is probably better.18:51
aelkneryeah, i was thinking the same18:52
* th1a is trying to figure out how to capture Launchpad's edit icon.18:52
th1aThe web used to be simpler...18:52
replaceafillth1a can you refresh the person page?18:52
th1aYes.18:52
aelkneri'm not crazy about the pencil, but i'm sure i'll lose that one :)18:52
replaceafillthat's 8px for margin-bottom18:52
th1aYes, that's better.18:52
replaceafillfor headers18:52
aelkneri don't have an alternative suggestion anyway18:52
replaceafilland "paragraph" style for the links18:52
aelkneractually, some interfaces use a word AND an icon18:53
aelknerlike 'edit' with a pencel18:53
th1aThere's a table body specification.18:53
replaceafilli also applied "paragraph" style for list items18:54
replaceafilllike the advisor/advisees names18:54
aelknerspeaking of advisory18:54
aelknershould that we a table?18:54
aelknerprobably a dumb suggestion18:54
aelknerconsidering it's just the one column18:55
th1aNo, I'm thinking "yes."18:55
th1aIt could be more than one column.18:55
aelknerthere's also the question of the heading for the column18:55
replaceafillid' like first name, last name18:55
aelknerah18:55
replaceafillor last name, first name as the correct order is now :)18:55
aelknerso we want two columns for all persons displayed in table?18:55
replaceafilland sortable! :D18:56
replaceafill(kidding)18:56
aelknerit's something to think about at this point18:56
replaceafilltable formatters!18:56
replaceafillsorry aelkner, go on :)18:56
th1aIn my mind, it should be the same widget as on the people view, just filtered differently.18:56
th1aIt should just be that.18:56
aelkneri want to work with yvl on better pythn classes for table formatters18:56
aelknerwe could use them in the short term18:57
th1aWhy can't we reuse that?18:57
aelknermaking it easier for us to say, 'we'll just add a column'18:57
replaceafillwe can18:57
th1aOK, lets do that.18:57
aelknerth1a, could we table the idea until tomorrow morning, and18:57
aelknerdiscuss the possibility of pair programming it18:57
th1aWell, what's the problem?18:58
th1aWe've already got a person table.18:58
th1aSortable.18:58
th1aWe can't re-use it?18:58
aelknerno18:58
aelknerevery view that uses a table18:58
replaceafillaelkner you can18:58
aelknerneeds a couple pages worth of python code to set it up18:58
replaceafilli disagree18:59
replaceafillit's not that hard18:59
replaceafillit's tedious18:59
replaceafillbut not hard18:59
aelkneryou like tedium, i don't18:59
aelknermy head explodes and i shut down19:00
replaceafillcan i give it a try?19:00
aelkneri don't think th1a wants that19:00
aelknerit would make much ore sense for tables to be built in views with simple dictionaries19:00
replaceafillif my head explodes doing it i quit the idea :)19:00
replaceafillaelkner i agree, it should be simpler19:00
aelknerthat the base class sorts out19:01
th1aI can't imagine that we can't just make a reusable sortable person table that will display whichever list of people you give it.19:01
aelknerwell, in a simple case19:01
th1aIsnt' this a simple case?19:02
replaceafillit is19:02
aelknerwe can just imbed a template in the template, like our page template/class already does19:02
th1aPrecisely.19:02
replaceafillhere's a lousy example from cambodia:19:02
replaceafillpersons = ISchoolToolApplication(None)['persons']19:02
replaceafillself.table = getMultiAdapter((persons, self.request), ITableFormatter)19:02
replaceafillitems = [member for member in self.group.members]19:02
replaceafillself.table.setUp(table_formatter=table.StandaloneFullFormatter,19:02
replaceafill                 items=items)19:02
replaceafill4 lines of python19:02
replaceafilland you just render view/tablei n the template19:02
replaceafilland that's it!19:03
replaceafillno zcml19:03
replaceafilland you get first name, last name19:03
aelknerwell, that's more like it19:03
th1aExactly.19:03
replaceafilland if you want to change the sorting of columns to: last name, first name19:03
replaceafillone factory class and one zcml registration19:03
replaceafillthat's it!19:03
replaceafillagain!!! tedious19:03
replaceafillnot hard19:03
th1aNot even tedious.19:04
replaceafill:D19:04
aelknerin that case, not even tedious19:04
aelknerright19:04
replaceafill;)19:04
replaceafilli've learned a few things thanks to Cambodia :P19:04
replaceafilland you live with them19:04
replaceafillok, back to css for me19:04
aelknerone can learn to love the magic :)19:04
aelknerbut the magic upsets the newbie19:05
aelkneras long as we have some docs that point to live examples19:05
aelknerthen the magic isn't so bad19:05
replaceafillall i'm saying is, try it out19:05
replaceafilli can help19:06
replaceafilli know it's doable19:06
aelkneri know it is now, and i will19:06
th1aOK.  Great.19:06
aelkneri was just saying on the subject of magic in general19:06
aelknerso what about this sortable persons table19:06
th1aWhat's up with the spacing under the sections taught table?19:06
aelknerth1a, i'm not done19:07
replaceafillth1a the accordions use the same height by default19:07
replaceafillth1a there's an option to override19:07
replaceafillautoHeight: false19:07
aelknerok, i'll come back to the tables discussion later19:07
replaceafilli remember i told aelkner about it19:07
replaceafillsorry aelkner go on19:07
replaceafilli'll try not to interrupt anymore :)19:08
aelkneri don't remember autoHeagith19:08
replaceafillhttp://schooltool.pov.lt/irclogs/%23schooltool.2011-06-08.log.html#t2011-06-08T20:48:4119:08
th1areplaceafill, So they'll all be the height of the tallest one?19:08
replaceafill:)19:08
replaceafillth1a correct19:08
aelknerso what are we doing right now? am i changing css?19:08
th1aWe're returning to the Sections accordion.19:09
th1aWe should turn autoheight off because occasionally one of these will get much bigger than the rest.19:09
th1aSo do that aelkner.19:10
aelknerreading the docs...19:13
replaceafillaelkner could you convert the <script></script> element to a file resource?19:13
th1areplaceafill: do you know how to track down the LP edit icon.19:13
th1aI can't track this stuff down anymore.19:14
aelknerreplaceafill, while i'm at it, should i keep header as h5?19:16
aelknerkeeping it the same means not having to change the viewlets19:16
replaceafilli'd like a <div> with a class there19:17
aelknerbut it's your call19:17
replaceafilland tell the accordion the selector instead19:17
th1aI don't think there should be any h4 or h5's.19:17
aelknerok, h1 then?19:17
replaceafillaelkner forget it, use h219:17
th1aWhich header?19:17
aelknerthe accordion19:17
th1a...19:18
th1alike "Advisory?"19:18
aelkneri'm changing behaviour, so it was the time o ask19:18
replaceafillaelkner think of it as this: suppose there are no accordions :)19:18
replaceafilli mean, styled19:18
aelknerthen picking the element matters19:18
replaceafill<h2>Advisors</h2>19:18
th1aAaagh.19:18
th1aWhat about this is different than Sections?19:18
replaceafillsorry19:19
replaceafillthat should be19:19
aelknerAdvisory19:19
replaceafill<h2>Advisory</h2>19:19
aelkneryes19:19
replaceafillsorry :19:19
replaceafill:)19:19
th1aAll these should be exactly the same.19:19
aelknerok, so i'll change the viewlets to render h219:19
th1aSections is h3, right?19:19
th1aDidn't we like that?19:19
aelknerand change the accordion js to use h219:19
replaceafillSections should be h219:19
replaceafillSections taught is h319:19
aelkneris that a final decision?19:20
th1aNO.19:20
aelkner:)19:20
replaceafillhttp://img69.imageshack.us/img69/9241/pantallazopd.png19:21
replaceafilllook at the page with no javascript19:21
replaceafilli'm not saying we should care19:21
th1aLovely.19:21
replaceafilli'm just saying that's a good indicator of how to structure content19:21
replaceafillto me Adivosry should be <h2>19:21
replaceafillAdvisors <h3>19:21
th1areplaceafill:  just try it on the live server so i can see.19:21
replaceafillok19:22
th1aIt might make the accordions too big.19:22
*** dadeng has quit IRC19:22
aelknerso am i making the change or not?19:22
th1aWe're going to take a look.19:23
th1areplaceafill is the one with a live server running.19:23
aelknerok19:23
th1aAs far as I'm concerned, the way sections looks now is fine.19:23
th1aBut maybe bigger will be better.19:24
th1aAre we talking about making it h2 but keeping the same presentation?19:24
th1areplaceafill is making my brain explode.19:25
replaceafilla sec19:25
aelknerth1a, what i was referring to was the accordion header element19:26
th1aYes.19:26
th1aThose look fine to me already.19:26
aelknerthat can be anything since it is styled via acoordion css class19:26
aelknerbut i thought it best to let replaceafill choose the element19:26
aelknerright now Sections Taught is <h3>19:26
aelknerso that wouldn't need to change19:27
aelknerreplaceafill suggested using <h2> for the accordion header19:27
replaceafillok, done19:27
aelknerwhich sounds as good as anything else19:27
replaceafillsorry that i dont respond19:27
replaceafillbut i'm coding :)19:27
aelknernp, was glad to get a word in edgewise :)19:27
replaceafillsee any "visual" change????19:27
th1aLooks the same.19:27
replaceafillth1a exactly ;)19:27
th1aUnless we turn JS off?19:28
aelknerth1a, another thing, this playing with styles thing is probably done best as a pair19:28
th1aYes, you and me.19:28
th1aA pair.19:28
aelkneri cold be better used off doing something unrelated19:28
aelkneryou and replaceafill are the ones pairing here19:28
th1aI have two pairs.19:28
replaceafilllook with no javascript: http://img607.imageshack.us/img607/3963/pantallazo1zm.png19:28
aelkneri've got three of a kind19:29
replaceafillnot pretty, but better19:29
th1aOK, good.19:29
th1aThanks.19:29
th1aMoving on.19:29
aelknerbtw19:29
replaceafilllol19:29
th1areplaceafill: Do you know how to find the edit icon?19:29
replaceafill(on the 2 pairs) :)19:29
replaceafillah i did19:29
aelkneryou guys talk to fast19:29
replaceafill(im multitasking here...)19:30
aelkneri can't get a word in19:30
replaceafillth1a wget https://code.launchpad.net/+icing/rev13216/icon-sprites19:30
replaceafillrename to png19:30
th1aCool.  Thanks.19:30
aelknerso i'll go off and think about modal dialogs19:30
replaceafilldont point your browser, it has a wrong content-type19:30
th1aNo...19:30
th1aaelkner:  We're a pair!19:30
aelknera pair of what? :)19:30
th1aManager/managed.19:30
replaceafilla pair of people who care about schooltool ;)19:31
th1aOK aelkner, grab that icon.19:31
replaceafillit's a sprite19:31
replaceafillseveral icons in there19:31
th1aJust to complexify things.19:31
replaceafillwant me to take the pencil out?19:32
th1aPlease.19:32
th1aaelkner needs it.19:32
replaceafillhttp://69.164.203.135/pencil.png19:34
th1aGrab that ad add it as a resource, aelkner.19:34
replaceafillwhat was i doing...19:35
replaceafillth1a ok, i'll start reverting the margin changes19:37
replaceafill(what we did yesterday)19:37
replaceafilland taking the right sidebar out19:37
replaceafilland then adding the appropriate whitespace19:37
th1areplaceafill: kk.19:37
th1a aelkner: Got that?19:40
aelknerreplaceafill, i made the header element and autoHeight setting change19:40
aelknerpushed19:40
aelknerplease merge and get running19:40
replaceafillcan you merge to trunk?19:40
replaceafillaelkner and dont forget to remove the orange hover19:41
aelknerreplaceafill, please merge and start server, you already have that paradigm down19:41
replaceafillaelkner i've set up like a million instances with a million changes19:42
replaceafillplease update trunk19:42
replaceafillit's easier for me19:42
replaceafilli have a trunk instance running19:42
aelkneris that the one that we have been sing?19:42
aelknerusing19:42
replaceafillno19:42
replaceafillthat's one of mine with trunk merged19:43
replaceafillbut with uncommited changes too19:43
th1aHow we doing, aelkner?19:49
th1a...19:50
* th1a goes to take a shower.19:52
aelknerreplaceafill, trunk has my changes now19:54
replaceafillgreat, pulling19:54
aelknernote how the view itself flickers when the size of the accordion section changes19:55
replaceafillyep19:55
aelkneras long as that's ok with th1a19:55
*** alga has quit IRC19:56
replaceafillactually, it flickers even if you dont use autoHeight19:56
replaceafillaelkner orange hover next :)19:56
aelknerwhat about it?19:57
replaceafillremove it19:58
aelknerlet me look20:00
replaceafillaelkner you need border: none; for .ui-state-hover20:00
aelknerok20:03
replaceafillaelkner btw, try using px insted of ems20:04
replaceafillit seems like we've left ems out :(20:05
replaceafilli liked ems :)20:05
aelknerso did i20:07
aelknerbut the guidelines are all in px, so...20:07
replaceafilljust for moving the text in the header to the right20:07
replaceafill    padding-left: 2em;20:07
aelknerah, that20:07
aelknerthat's because of the iocn20:08
replaceafilli know20:08
replaceafill:)20:08
aelknerso you want that in px20:08
replaceafillplease20:08
replaceafilland for the last rule:20:08
replaceafill.ui-accordion-content20:08
replaceafillchange it to:20:08
replaceafill.ui-accordion .ui-accordion-content20:08
replaceafillwe may want to change the padding of the accordion content20:09
replaceafilli'll ask th1a20:09
th1aHm?20:09
th1aAre you guys seeing the flicker in firefox?20:10
th1aI don't see it in chrome.20:10
replaceafillnot really20:10
th1aOK.20:11
replaceafilli saw it with autoHeight: true20:11
replaceafillth1a question20:11
replaceafilldo you like the padding for the accordion content20:11
th1aThe spacing should be consistent with the rest of the guidelines.20:11
replaceafillleft and right padding20:11
replaceafillah ok20:11
replaceafillhowever, should we use rules for forms for the content of the accordion?20:12
replaceafilllike 8px in each side?20:12
th1aWe should start wit that.20:12
replaceafilllook at 8px left and right20:12
replaceafillpadding top and bottom should be set by jquery20:13
replaceafillbecause of the autoHeight20:13
aelknerreplaceafill, pushed to trunk20:14
replaceafillthanks, will pull20:14
*** menesis has quit IRC20:16
replaceafillpulling20:16
th1aI'm afraid we my have to set up a real system for doing this with aelkner...20:16
th1aOr maybe I can just pull his branch to my machine.20:16
th1aOr something.20:16
th1aThese five minute gaps are not very sprinty.20:18
th1aPerhaps we could just post screenshots...20:19
th1aAnything...20:19
replaceafillaelkner my bad20:20
replaceafillborder: none; makes hovering flickers20:20
replaceafill.ui-state-hover {20:20
replaceafill    border: 1px solid #540000;20:20
replaceafill}20:20
replaceafillcan borders be transparent....20:21
th1aaelkner:  Are we waiting for something?20:22
aelknertaking a quick break20:23
th1aLook, aelkner, you need to talk to me here.20:23
aelknerlet me finish my chicken20:25
* th1a ponders how difficult it would be to replace aelkner with three Indians.20:25
aelknersorry, picked a bad time to grab a quick bite20:29
aelkneryou were discussing changing the instance?20:29
aelknerfor quicker turnaround?20:30
th1aLet's just do screenshots for what we're doing now.20:30
replaceafillaelkner sync with trunk20:30
aelknerunfortunately, accordions have animation20:30
aelknerthat can't be expressed in a screenshot20:30
th1aaelkner: Would you please do what I ask?20:31
replaceafillaelkner i applied the header styles to trunk and a fix for the flickering20:32
replaceafillth1a refresh please20:33
replaceafilland check the padding of the accordion20:33
replaceafillused 8px as for forms20:33
aelknerhow are we going to proceed here:20:34
aelkner1) start using screenshots20:34
aelkner2) continue to update the instance with changes20:34
th1aaelkner:  What did I ask you to do?20:34
th1areplaceafill:  I'm a little dubious about the narrow margin, but lets keep it for now.20:35
replaceafillth1a ok20:35
th1aConsidering the tables are supposed to fill the whole content area.20:35
th1aMaybe they should have no margin.20:35
replaceafillhhmm20:35
th1a(left and right)20:35
th1aOK, aelkner.20:36
th1aWe want that edit icon next to "Sections Taught"20:36
replaceafillth1a also, the accordion will be wider once we remove the right sidebar :D20:36
th1aOK.20:36
th1aJust move onto that stuff please, replaceafill.20:36
th1aThat's more pressing.20:36
replaceafillok20:36
aelknerso th1a, why don't you set up an instance on your own machine for trunk20:37
aelkneri can merge any changes i make to that20:37
th1aI have one aelkner.20:37
replaceafillsync your trunks20:37
th1aLook, I'm not asking you.20:37
th1aI'm telling you to send me screenshots.20:37
th1aWhen I ask for them, ok?20:37
aelknerok20:38
th1aHm, actually, I guess there isn't literally a section edit view is there?20:39
th1aThat is, you can only add people to sections right now from the section's view.20:39
replaceafillno, there isn't20:39
th1aOK, so let's wrap up sections for now then and move onto groups.20:40
th1a"Taught" should not be capitalized.20:40
th1aIt is a label.20:40
aelknerpage 16 of the guidelines20:41
th1aHm?20:41
aelknerbut if by disagreeing i'm only going to make you mad, forget about it20:41
th1aI'm looking at the GNOME spec.20:42
th1aIt is a label above a table.20:42
aelknerwe're not talking about the ubuntu guidlines?20:42
th1aThere is no capitalization in the Ubuntu guidelines.20:42
aelknerpage 1620:42
aelknerGlobal Provider20:43
th1aYes...?20:43
th1aHow to join20:43
aelknerah20:43
th1aI mean, it is a toss up.20:43
aelkneryeah, and a slef-contrdictory guideline in that case20:43
th1aBut the closest thing I can find in GNOME is a sentence.20:43
aelkneri guess it's saying both are ok20:44
th1aThe Ubuntu guidelines have nothing to say about capitalization.20:44
aelknerwhat do mean by find in GNOME?20:44
th1ahttp://developer.gnome.org/hig-book/stable/design-text-labels.html.en#layout-capitalization20:44
th1aWe talked about this this morning.20:44
aelkneryes, i had shut down the tab so i lost it20:45
th1aThis is why I just wanted to make everything the same.20:45
aelkneranyway, it's funny how that section uses sentence capitalization in the red headings20:45
aelknerbut that's what you're saying20:46
aelknerok, now that i've read further down, i see the table20:46
th1aI'm really just trying to apply the guidelines.20:46
th1aI have no dogma in this fight.20:46
aelknerIt's a hard decision to make because we want to apply it globally no matter which one we choose20:47
aelknerso the impact of the choice is great even though the choice itself is not so important20:47
th1aWell, let's just try it lower case.20:48
aelkneri'd be comfortable going by the GNOME table20:48
th1aWhich element would you call this?20:49
aelkneryeah, that's the problem20:49
aelkneri just like the idea of having the table, but i don't understand it all20:50
th1aLet's just call it a sentence and move on.20:50
aelknerok20:50
th1aNow... column ordering.20:50
th1aThis is a little tricky because this should be consistent.20:50
th1aSo it makes sense that what we're sorting by should be at left.20:51
th1aBut it doesn't make sense that what the user cares about is at right.20:51
th1aMoreso in Groups than Sections.20:51
th1aSo I'm thinking the sequence should be reversed.20:51
th1aSection | Term | School Year20:52
th1aaelkner?20:53
aelknermakes sense20:53
th1aOK.20:53
th1aI'm also thinking that maybe rather than coming up with new architecture for tables, we really just need about five standard ones that it might be easier to just go ahead and write.20:54
th1aSo sortable:20:54
th1a1) person20:54
th1a2) groups20:54
th1a3) sections20:54
th1a...20:55
th1a4) resources20:55
th1aMaybe a couple more.20:55
th1aWhat do you think?20:56
th1aWe might have that done before yvl can figure out an estimate for a big refactor.20:56
aelknerdo you mean those tables rendered as a standalone view that can20:57
aelknerbe inserted into another20:57
th1aLike we were discussing for people earlier.20:57
th1aSortable tables.20:57
th1aThere's just a limited number of combinations we need to reuse.20:58
aelkneri like the idea of creating reuable views20:58
aelknersections, do we want course there?20:59
aelkneri mean if it is to be reusable20:59
th1aYes.20:59
aelknerSection | Course | Term | School Year20:59
th1aNow we're running into a width issue.20:59
th1aWe need to fix these crazy default section titles.21:00
th1aBut not now for that.21:00
aelknerwhy not now21:02
aelknerthat's a good idea for the tale21:02
aelknertable21:02
th1aWell...21:02
aelknerwell, the issue is, the section title is geneeated21:03
th1aIf you want to take a quick look at it.21:03
aelknerunless the user overrides it21:03
aelknerso if the user changed it, we wouldn't want to try and remove the course before rendering it21:03
replaceafillth1a sorry to interrupt http://69.164.203.135:6660/persons/alvaro21:04
aelkneri should look at section ttle method reall quick21:04
replaceafilldo you want the accordions to expand?21:04
replaceafillth1a same for http://69.164.203.135:6660/persons ?21:04
replaceafill(i need to insert the paddings back btw)21:04
replaceafilland are those dimension ok for the sidebar and content?21:05
replaceafill250px, 16px, 678px21:05
replaceafillcopied sidebar width from ubuntu news21:05
replaceafill:)21:05
replaceafillbut they use a larger font21:05
th1aThat's wider than I want.21:06
th1aI want it as narrow as we can reasonably make it.21:06
replaceafillyesterday we made it 160px21:06
th1aThat's fine with me for now.21:07
th1aIt is kind of a yagni situation.21:07
th1aExcept for pixels.21:07
replaceafillrefresh21:07
replaceafill160px21:07
replaceafillAdd Administrator looks good21:07
replaceafilli wonder about "Añadir Administrador" :)21:08
replaceafillhey we have firebug ;)21:08
replaceafillspanish version fits almost perfect21:08
th1aIf by "perfect" you mean "just barely" then boost it up another 16 or so.  ;-)21:09
replaceafillcool21:09
replaceafillyes, just barely :)21:09
replaceafillexpanded accordion21:10
aelknerth1a, from the section add view:21:10
aelkner        # overwrite section title.21:10
aelkner        section.title = "%s (%s)" % (course.title, section.__name__)21:10
aelknerthere's a note in the code referring to this bug:21:10
aelknerhttps://bugs.launchpad.net/schooltool/+bug/38928321:10
aelknerwhere an interesting discussion of section titles and terms took place21:11
th1awhat is section.__name__ ?21:11
aelknerthe arbitrary id in the container, not interesting to the user unless21:11
aelknerthey are importing from XLS21:11
aelknerthen we force them to specify it21:11
aelkneractually, maybe forced is wrong21:12
aelkneri have to check21:12
aelkneryes, it is required in the import21:13
th1aThese titles are always redundant.  Can we just get rid of the first part21:13
th1aso it is "Chemistry (1)" instead of "Chemistry -- Chemistry (1)"21:13
th1aIn the default case?21:13
aelkner"Chemistry (1)" is what the section title should have in it21:14
th1aYes, that's what I'm saying.21:14
aelknerso it must be the renderer of the link that is adding the course21:14
aelknerlet me check21:14
th1aOh... I see.21:14
th1aProbably.21:14
aelknerah, it is the view code that does it21:15
aelknerso i can change it to not include the course ttle21:15
aelknerespecally if we have a course column21:15
aelknercourses actuelly21:15
th1aPLEASE.21:15
aelknerSection | Course | Term | School Year?21:16
th1aWell, let's try.21:17
replaceafillth1a http://69.164.203.135:6660/persons21:21
th1aWe still need right margins, correct?21:22
aelknerth1a, a problem with the courses21:22
th1aMultiples?21:22
aelknertypically a cell refers to one thing, so it being a link makes sense21:23
th1aMaybe we should keep this simple.21:23
aelknerbut if we take the course titles and join them with ','21:23
aelknerthen what link?21:23
aelknerwe could have consecutive links, no commas21:23
th1aWell... the link should really be the text anyhow.21:23
th1aLike in /persons now.21:24
replaceafillth1a more margin between the sidebar and content?21:24
aelknerth1a, don't understand, the link is always the text21:24
th1aLooks ok ro mw replaceafill.21:24
replaceafill:)21:24
aelknerthat's what i mean, with courses, it can't be just one link21:24
th1aWhy couldn't each course link to the relevant course page?21:25
aelknerlet me see how sections container view in old skin works21:25
th1aIdentifying sections is a recurring nightmare.21:27
replaceafillok, sync trunk guys21:27
replaceafillth1a what's next?21:27
th1aRight margins?21:28
th1aBottom margin?21:28
th1aWe had those and seem to have lost them.21:29
replaceafillit's because i removed the background of the body container21:29
replaceafillbut the right margin is 16px21:29
replaceafillaccording to the guidelines21:29
replaceafilli do have to take 16 from below though21:30
th1aWhat about that 224 at the right.21:30
th1a?21:30
th1aaelkner:  You know, Section | Term | Year might just be best.21:30
replaceafillth1a you mean, you still want the whitespace of the right sidebar?!?!?21:31
replaceafill:(21:31
th1agrayspace.21:31
th1aI'm just talking about the spec.21:31
replaceafillah!21:31
th1aYes.21:32
replaceafillhold on, let me do a mock to see if that's what you want21:32
th1aRemember?21:32
th1aWe probably should narrow it by the extra width at left. At least.21:32
aelknerth1a, ok, then keep the courses in the section title?21:34
th1aCut the first half off anyhow.21:34
th1aIt is still redundant, or displayed as redundant. Or whatever.21:35
th1aMake it stop repeating itself.21:35
th1aI don't care how.21:35
aelknerwhat if the section title is different than the course?21:35
th1aFine.21:35
aelknerwe'll keep it the way it is21:35
th1aAAAGHGHGHGHGHG.21:35
aelknerjust changing the column order21:35
th1aKeep the title the way it is?21:35
aelknerwell, if the user importe the section and the section title does not have the course in it21:36
aelknerthan removing the course from the section title21:36
th1aThat is his damn problem.21:36
aelknerand not displying the courses wold be confusing21:36
th1aLook, please, aelkner.21:36
aelknerok21:36
aelknergetting rid of the courses21:37
th1aI don't completely understand what is going on here, but surely there is some way we can prevent the default title of every section from being twice as long as it needs to be.21:37
th1aCan we just take out the SECOND course title in the default section name then?21:37
th1aWhy is that one there?21:37
th1aOne of those is completely unnecessary.21:38
th1aDo you understand what I am saying aelkner?21:39
replaceafillth1a http://69.164.203.135:6660/persons21:41
replaceafillhttp://69.164.203.135:6660/persons/alvaro21:41
replaceafilldid i get it? :/21:41
aelkneri sent a screenshot21:42
* replaceafill hopes he's not making th1a's head to explode :)21:42
th1aThat's as good as we're going to get without getting some input from a real designer.21:42
replaceafillthe real designer: "what's with that grayspace in the right" :D21:43
aelknerth1a, if you like the screenshot i'll commit and push21:43
th1aaelkner, That's fine.21:43
replaceafillaelkner sync before pushing21:44
aelknertoo late21:44
aelkneri just pushed to my branch21:45
replaceafillah, np then21:45
replaceafillonly sync before pushing to trunk21:45
replaceafilli'm pushing to trunk21:45
th1aWe do need to tweak the spacing.21:45
th1aDo we need the margin-tops in the headers as well?21:46
th1ah3, etc.21:46
th1aIs the line height in there too?21:46
*** ignas has quit IRC21:46
replaceafillyes, there's line-height in all of them21:47
*** asharma has joined #schooltool21:47
replaceafillth1a we can add top-margin, but how can we test it?21:48
replaceafillporting something?21:48
th1aUh... reload the page?21:49
*** menesis has joined #schooltool21:49
th1aaelkner's table labels are jammed up against each other.21:49
th1aOr, the table above,more specifically.21:49
replaceafillth1a in the testing instance?21:50
th1aIn the screenshot.21:50
th1areplaceafill:  do you need something else to do?  ;-)21:50
replaceafilli thought you were going to tell me...21:50
replaceafillbut now i'm wondering if i want to know... ;)21:50
th1aOK.  YEs.21:50
aelkneroh, sorry, forgot to lowercase Taught and Attended21:51
th1aGet to work on the People sidebar, replaceafill.21:51
th1aKill the School thing.21:51
replaceafillah, i hadn't seen aelkner's screenshot21:51
replaceafilltrue, we need margins for headers21:52
th1aYes, we had that conversation last week.21:52
replaceafill16px top, 8px bottom21:52
th1a<div>&nbsp</div>21:52
th1aSee, we're making progress!21:52
replaceafillyikes!21:52
aelknerpushed21:52
replaceafillno more &nbsp's right?21:53
aelkner:)21:53
th1aNooooooo!21:53
replaceafillaelkner pushed to trunk?21:53
aelknerno21:53
replaceafillaelkner let me know when you push to trunk, ok? so i can update the isntance21:53
replaceafilland see your changes21:53
aelknerok21:53
replaceafillty21:53
replaceafillok, killing School21:54
aelknerreplaceafill, pushed to trunk21:55
replaceafillpulling21:56
replaceafillrestarting...21:56
replaceafilli need to put Álvaro in a section as a student :)21:57
th1aOh!  Section size!  That's a good one to include too since it is small.21:58
aelknerth1a, are you saying add a column to the sections viewlet?21:59
aelknercolumn two, Size21:59
th1aI just actually looked at what we have now.21:59
aelknerthe sections container view, right?21:59
th1aYes.21:59
th1aThe actual width of the columns is not set by the UWG, correct?22:00
aelknerhow could it?22:01
*** replaceafill_ has joined #schooltool22:01
th1a?22:01
th1aOK.22:01
replaceafill_sorry got disconnected22:01
aelknerexcept maybe if each column width had to be a multiple of some numbe of pixels22:01
*** replaceafill has quit IRC22:01
*** replaceafill_ is now known as replaceafill22:01
th1aSo this is sorted by year, then term, then section title?22:02
aelkneryes22:02
th1aOK, let's move on.22:03
th1aHrm.22:04
th1aGroups.22:04
th1aOK, I think we need to make the labels standard.22:05
th1aSo try "Group memberships"22:05
th1aFor a label.22:05
th1aFlip the columns.22:06
th1aand then we can try the edit icon next to "Group memberships" that'll link to the group relationship edit page.22:06
th1amake sense, aelkner?22:07
replaceafillth1a http://69.164.203.135:6660/persons/alvaro22:07
replaceafillcheck the spacing for the table and header22:08
th1aSections?22:08
replaceafillyes22:08
th1aIsn't that what aelkner just changed?22:08
* replaceafill looks22:09
aelkneryeah, what heppened to the spacing?22:09
aelknerth1a, i can add the h3 and flip the columns  groups now22:09
th1aok22:10
replaceafillno revisions to pull in trunk...22:11
replaceafilli'll stop working on what aelkner is changing22:11
replaceafilli'll go fix the sidebar22:11
th1aplease22:11
aelknerreplaceafill, pushed to trunk22:14
replaceafillpulling22:14
*** fsufitch has quit IRC22:17
replaceafillth1a http://69.164.203.135:6660/persons22:24
replaceafillSchool viewlet manager gone22:24
th1aOK.22:25
th1aNow make it more Ubuntu news style.22:25
th1aWIthout making the fonts bigger...22:25
replaceafill:|22:25
replaceafillok22:25
replaceafillth1a http://69.164.203.135:6660/persons22:29
replaceafillshould i make those action links red?22:29
replaceafillor underlined?22:30
th1aJust standard links for now.22:30
*** alga has joined #schooltool22:31
replaceafillrefresh22:32
* replaceafill goes to have lunch, will be back in an hour22:37
th1aMake the header bigger, red (underline too), and not bold.22:38
replaceafillok22:38
th1aTighten up the line spacnig for the links.22:38
th1aAlso...22:38
replaceafillah ok22:38
th1aAdd... instead of "People"22:38
th1aAnd just Person, Administrator, Student etc.22:38
replaceafillok22:38
th1aAnd take Persons out for now.22:38
replaceafillgot it22:39
replaceafillwill start with that when i come back22:39
*** ignas has joined #schooltool22:39
* replaceafill is back23:20
replaceafillth1a http://69.164.203.135:6660/persons23:28
replaceafilli don't like the red "Add"23:28
replaceafillit looks like a link23:28
replaceafillah! i'll change those orange icons in the accordions23:36
*** menesis has quit IRC23:40
replaceafillaelkner pushed new jquery icons to trunk23:51

Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!