IRC log of #schooltool for Friday, 2011-01-14

*** menesis has quit IRC00:20
*** alga has quit IRC04:44
replaceafillaelkner, you around?05:20
*** th1a has quit IRC07:35
aelknerreplaceafill, you there?08:08
*** replaceafill has quit IRC08:54
*** yvl has quit IRC10:39
*** yvl has joined #schooltool10:42
*** menesis has joined #schooltool11:32
*** alga has joined #schooltool12:45
*** menesis has quit IRC14:40
*** replaceafill has joined #schooltool16:00
*** menesis has joined #schooltool16:11
*** th1a has joined #schooltool16:19
th1areplaceafill: zyt?17:19
replaceafillth1a, yes17:19
th1aI think I'll go through the bugs and assign a bunch to you.17:21
replaceafillth1a, ah cool17:21
th1aUnless you have a better idea of what to do.17:21
replaceafillwell, i just wanted that the gradebook had good functional test coverage, so i can add the preferences feature safely, and do the score refactoring needed for cambodia17:22
replaceafilland it helped me find a few bugs too17:22
replaceafilleven in cando17:22
th1aHow much more work it there in the above?17:22
replaceafillfinishing adding tests, this week, adding the preference feature + score refactoring, 2 days next week i guess17:23
replaceafillthe first bugs i was going to focus next week, were some small ones about report sheets17:24
replaceafillthat are already assigned to me17:25
replaceafillbtw, i had a question about the fck editor widget17:25
th1aI'll probably shift some that are currently assigned to other people.17:25
replaceafillwhy do we need rich text support?17:25
replaceafilli havent seen it used yet, at least in the gradebook, do you know where it's used?17:26
th1aYes, we do need it.17:27
replaceafillyes, i saw the comments scores17:27
th1aI *wish* we didn't.17:27
replaceafillth1a, in linked columns you pick activities, totals or averages from other worksheets, correct?17:32
replaceafillis there a reason why deployed activities from report sheets are not pickable?17:32
th1aOh, sorry.17:38
th1aCovered you up.  :-)17:38
th1areplaceafill, I suppose no reason.17:39
replaceafillReport Activity 1.1 is a comment17:39
th1aDo we need to unescape there?17:39
replaceafillwonder how do you translate html to rml...17:39
th1aOh... does RML use <b> instead of <strong>?17:42
th1aWhere did the strong tag come from?17:42
replaceafilli guess the strong is stored by the fck widget17:42
replaceafilli put bold on that line17:42
th1aProbably we can change that in fck.17:42
th1aThat would be the thing to do.17:42
replaceafillbut then you lose the rich functionality, right?17:43
replaceafillyou mean store just plain text, or change fck to spit things rml understands?17:43
th1aChange fck to use <b> instead of <strong>17:44
th1aassuming that's what rml expects.17:44
replaceafillhhmm i think rml does <strong> using paragraph styles...17:46
th1aYou might need to setFont to bold.17:50
th1aInside the story, you can also do a number of things that you can't do with the drawString commands. For a17:50
th1astart, you can use bold, italics and underlining. If you are familiar with HTML, you will recognize these tags -17:50
th1a<i> and </i> start and stop italics, <b> and </b> start and stop the text being set as bold, and <u> and17:50
th1a</u> start and stop underlining.17:50
replaceafillth1a, i reported it, so we dont forget:
th1aWe just need to change it to <b>17:52
th1aWhat is fck called now?17:52
replaceafillat least in the gradebook code i see references to it like: _unescape_FCKEditor_HTML17:53
th1aWell, that may be necessary too.17:53
th1aAs usual I think I've drifted onto a different question.17:54
th1aYes, regardless it needs to be unescaped.17:54
th1aOr never escaped.17:55
th1aBut also, fck should be set to use <b> and <i>17:55
replaceafillhhmm, maybe 'HTML code for Comment scores is not escaped in report card' is not the right title for the bug...17:55
replaceafill'is not interpreted...'17:56
th1aSwitch it to <b> first.17:56
th1aSee what happens.17:56
* replaceafill goes hacking fck17:57
* th1a goes to get lunch.18:18
replaceafillaelkner, zyt?18:53
aelknerhey replaceafill18:56
replaceafillhey aelkner18:56
replaceafilldid you create gradebook.browser.report_utils?18:56
replaceafillspecifically buildHMTLParagraph18:57
* th1a is back.18:58
aelknerthat was originally custom code yvl wrote for the sla narrative report18:59
replaceafillth1a, even if we switch it to <b> there's a escaping function that is supposed to remove invalid tags before rendering the paragraph18:59
aelkneri used it in the gradebook reports, so yes18:59
replaceafillaelkner, these two lines got my attention:18:59
replaceafill        # Unescape some of the tags which are also valid in Reportlab18:59
replaceafill        valid_text = escaped_reportlab_tags_re.sub(u'<\g<1>>', fixed_escaping)18:59
th1aDoes <b> give you bold?18:59
replaceafillth1a, the change in the editor you pointed me to didnt work, maybe it's the version of the editor19:00
replaceafillwe're using fckeditor
replaceafilli found this:
replaceafilli was going to test: FCKConfig.CoreStyles['Bold'] = {Element : 'b', Overrides : 'strong' };19:02
replaceafillth1a, yep, that worked19:04
replaceafillth1a, now i get:
th1aI figured there was also some kind of escaping problem.19:05
*** alga has quit IRC19:06
th1aaelkner:  Phone?19:23
replaceafillth1a, YES!19:25
replaceafillit's the rml template, it needs content="structure ..."19:25
replaceafillboy, that was confusing for me :P19:26
aelknerreplaceafill, are you saying you found a change needed in schooltool core's ReportBase class?19:56
replaceafillit's the rml template for the report card19:57
aelknerwhere is the structure thing you to?19:57
replaceafillEven though the <strong>, <b>, <em> and <i> tags are valid in Reportlab, the rml template (schooltool/gradebook/browser/rml/ needs a content="structure ..." attribute. This seems to fix the problem.19:57
aelknerschooltool.gradebook core doesn't have your reorg yet, right?19:58
aelknerso i can't see the rml directory cause there isn't one there yet19:58
replaceafillworking in my branch19:58
aelknerso i can't see what you're saying19:59
replaceafillyou can, let me get the file for you19:59
replaceafillin trunk20:00
replaceafillline 11520:00
aelknerah, the score20:06
aelknerso it just need structure there?20:06
replaceafillthis is why i think it's worth adding ftest to the gradebook :)20:07
th1aYes, it is a good time.20:10
th1areplaceafill:  Some of the bugs I'm reassigning to you might not be bugs anymore.21:03
replaceafillah, ok, ill check them21:08
th1aI think a lot are fixed.21:08
replaceafilli saw one about zope.html being upgraded21:08
replaceafillah no, i guess it's stil valid:
replaceafill...although we're using the latest version: 2.2.0...21:10
replaceafilloh, zope.html-2.2.0-py2.6.egg/zope/html/ckeditor/3.2.1/21:11
th1areplaceafill:  I'm giving you plenty to choose from.  ;-)21:15
replaceafill:| <- whatever that means :P21:15
replaceafillah, interesting, zope.html has both, fckeditor and ckeditor21:20
replaceafillthe gradebook is using fck21:20
th1aYes, menesis is looking at that issue.21:21
*** menesis has quit IRC21:29
replaceafillth1a, any objection if i try to make this:
replaceafilllook more like this:
replaceafillaelkner, in which case the source for an ILinkedColumnActivity wont provide IActivity or IWorksheet?21:54
replaceafilli can't think of any21:55
*** menesis has joined #schooltool22:19
*** dadeng has joined #schooltool22:57
th1areplaceafill:  That sounds fine.22:58
replaceafillth1a, cool, i'll put it on my todo22:58
replaceafillnice weight values ;)
*** dadeng has quit IRC23:29
*** replaceafill has quit IRC23:35
*** alga has joined #schooltool23:42

Generated by 2.15.1 by Marius Gedminas - find it at!