| *** menesis1 has joined #schooltool | 01:11 | |
| *** menesis has quit IRC | 01:11 | |
| *** replaceafill has joined #schooltool | 01:56 | |
| *** menesis1 has quit IRC | 02:20 | |
| *** replaceafill has quit IRC | 03:33 | |
| *** replaceafill has joined #schooltool | 04:40 | |
| *** alga has quit IRC | 05:04 | |
| *** th1a has quit IRC | 05:21 | |
| aelkner | replaceafill, ayt? | 06:37 |
|---|---|---|
| replaceafill | hey aelkner | 06:37 |
| aelkner | i was looking at your comment about ILinkedColumnActivity,and i'm not sure what you mean | 06:38 |
| replaceafill | ah ok, can you take a look at the schooltool.gradebook.browser.gradebook module? | 06:38 |
| aelkner | ok | 06:38 |
| replaceafill | class GradebookOverview | 06:38 |
| replaceafill | method activities | 06:38 |
| replaceafill | once you get the filtered activities, | 06:39 |
| replaceafill | you check if its a linked column | 06:39 |
| replaceafill | if it is | 06:39 |
| replaceafill | you check if its linked to another regular activity (or external) | 06:40 |
| replaceafill | or if linked to an average | 06:40 |
| aelkner | yep | 06:40 |
| replaceafill | but after those two checks, there's an 'else' | 06:40 |
| replaceafill | shortTitle = longTitle = bestScore = '' | 06:40 |
| replaceafill | setting that ^ | 06:40 |
| replaceafill | which i cannot get to with the coverage reports | 06:40 |
| replaceafill | because i think that would never be a case | 06:40 |
| aelkner | i'd call that a fail safe | 06:41 |
| replaceafill | hhmm i rather fail fast :P | 06:41 |
| aelkner | if you are adding tests and consider that code not testable, then i see wh you would get rid of it | 06:42 |
| replaceafill | it's impossible to get there in a test, i think | 06:42 |
| aelkner | the more tests we have, the less need to fail safe | 06:42 |
| replaceafill | right | 06:42 |
| aelkner | what if source is None? | 06:43 |
| aelkner | getSourceObj returns None in many cases | 06:44 |
| aelkner | if the section has disappeared | 06:44 |
| aelkner | if the activity is gone | 06:44 |
| replaceafill | so, i could test those corner cases and get there | 06:44 |
| aelkner | i'd leave it in, and if you have time to come up with tests | 06:44 |
| aelkner | yes | 06:44 |
| replaceafill | remove the source | 06:44 |
| replaceafill | is '' the best way to tell that to the user? | 06:45 |
| replaceafill | maybe a 'This source was removed' or something | 06:45 |
| aelkner | that would be better | 06:45 |
| replaceafill | i'll ask th1a to come up with a message :) | 06:45 |
| aelkner | good idea | 06:46 |
| replaceafill | so, i stand corrected, it's possible to get to that part ;) | 06:46 |
| aelkner | you can see how it could easily happen that a person would link to something | 06:46 |
| aelkner | and that thing would disappear | 06:46 |
| aelkner | definitely we need a good message from th | 06:46 |
| replaceafill | yes, specially with worksheets | 06:46 |
| aelkner | tom | 06:46 |
| replaceafill | right, i'll put in on my notes and ask on monday | 06:46 |
| aelkner | butalso, if you can come p with the edge tests, that would be good | 06:46 |
| replaceafill | i will, also in the notes :) | 06:47 |
| aelkner | nice | 06:47 |
| replaceafill | thanks aelkner | 06:47 |
| aelkner | np | 06:47 |
| *** replaceafill has quit IRC | 09:14 | |
| *** menesis has joined #schooltool | 11:10 | |
| *** alga has joined #schooltool | 13:05 | |
| *** ignas has joined #schooltool | 14:11 | |
| *** replaceafill has joined #schooltool | 16:43 | |
| *** replaceafill has quit IRC | 16:59 | |
| *** menesis has quit IRC | 18:37 | |
| *** alga has quit IRC | 19:39 | |
| *** replaceafill has joined #schooltool | 21:08 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!