| *** alga has quit IRC | 00:48 | |
| *** aks has joined #schooltool | 06:11 | |
| *** aks has quit IRC | 07:11 | |
| *** aks has joined #schooltool | 07:11 | |
| *** ignas has joined #schooltool | 13:26 | |
| *** menesis has quit IRC | 13:51 | |
| *** aks has quit IRC | 14:16 | |
| *** menesis has joined #schooltool | 15:10 | |
| *** replaceafill has joined #schooltool | 15:54 | |
| *** th1a has joined #schooltool | 16:16 | |
| th1a | We'll see if I can have a meeting on an iPhone. | 16:19 |
|---|---|---|
| th1a | Hi aelkner yvl menesis replaceafill | 16:30 |
| replaceafill | good morning/afternoon | 16:30 |
| menesis | hi | 16:30 |
| yvl | hey | 16:31 |
| aelkner | morning | 16:31 |
| * replaceafill updates the testing instance | 16:31 | |
| th1a | Ok yvl? | 16:32 |
| yvl | styled calendar colours | 16:32 |
| replaceafill | url: http://69.164.203.135:6660 | 16:32 |
| * th1a will b terse 2day | 16:32 | |
| yvl | added missing timetable view - set default timetable | 16:32 |
| yvl | fixed timetable import for new school year | 16:33 |
| yvl | ran out of stuff to do in few hours. | 16:33 |
| yvl | been fixing unit tests for the rest of the day. | 16:33 |
| yvl | that's it. | 16:33 |
| th1a | Do we still need a no school years view? | 16:33 |
| yvl | ? | 16:34 |
| * th1a really needs a new todo list | 16:35 | |
| th1a | replaceafill: Did we do the no years view? | 16:35 |
| replaceafill | th1a no | 16:35 |
| replaceafill | still needed | 16:35 |
| replaceafill | * add special view for no existing years | 16:36 |
| th1a | yvl: Can add that | 16:36 |
| * yvl will try | 16:36 | |
| th1a | It should fit into the new interface pretty well | 16:37 |
| yvl | anything else? | 16:38 |
| th1a | So if I say I'm going to add a resource and them cancel that step I get no event? | 16:38 |
| yvl | hmm | 16:40 |
| yvl | *if* I understand your question, then no | 16:40 |
| yvl | you will get event | 16:40 |
| yvl | it's been like that for ages | 16:40 |
| th1a | Ok | 16:40 |
| * yvl did not change any calendar logic there | 16:41 | |
| th1a | I must have confused myself | 16:41 |
| * yvl thought that's what th1a wanted - a simple port without changing/improving anything | 16:41 | |
| th1a | So aelkner and replaceafill can help come up with yvl tasks as we chat | 16:42 |
| th1a | yvl: It was just something I thought I noticed | 16:42 |
| yvl | ah -- ok then | 16:43 |
| th1a | No biggie | 16:43 |
| th1a | Thanks | 16:43 |
| th1a | aelkner? | 16:43 |
| aelkner | i changed the gradebook overview template to not render more thean just empty divs | 16:44 |
| aelkner | for the part of the template that is hidden anyway by the freezecol div above it | 16:44 |
| aelkner | also, i renamed the css classes for the popup menus to have class names with popup in them | 16:44 |
| aelkner | not activity which they had | 16:45 |
| aelkner | then i added popup menus to Total and Ave. headings | 16:45 |
| aelkner | had to change old skin update method to sort ontotal and average | 16:45 |
| th1a | Link? | 16:45 |
| aelkner | it won't break any old tests | 16:45 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/20102011/sections/1/activities/Worksheet/gradebook/index.html?sort_by=student | 16:46 |
| aelkner | better yet: | 16:46 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/20102011/sections/1/activities/Worksheet/gradebook | 16:46 |
| aelkner | without the sort in the url | 16:46 |
| aelkner | finally, i added tertiary nav for add activity, but it won't come up | 16:47 |
| aelkner | i put a pdb break in the items() method, but it doesn't even get called | 16:47 |
| aelkner | replaceafill, after the meeting, could you look at this with me? | 16:47 |
| replaceafill | kk | 16:47 |
| aelkner | also, why does Name not center vertically? | 16:48 |
| aelkner | i looked at the css for gradebook-heading and see it there | 16:48 |
| aelkner | but it isn't taking fr the gradebook-name column for some reason | 16:48 |
| replaceafill | the div has height | 16:49 |
| replaceafill | 3em | 16:49 |
| aelkner | and? | 16:49 |
| aelkner | why does that make it not vertically center? | 16:50 |
| replaceafill | it is being centered | 16:50 |
| th1a | I don't seem to be able to get the menus on this phone | 16:50 |
| aelkner | try shift-ctrl-R | 16:51 |
| aelkner | oh, on the phone | 16:51 |
| aelkner | couldn't tell you about that one | 16:51 |
| th1a | We do need a menu icon | 16:51 |
| aelkner | i was gong to ask you | 16:51 |
| aelkner | what kind of icon? | 16:51 |
| th1a | Should b one in jquery ui | 16:52 |
| aelkner | should the icon be part of the link, live directly after the text, but also part of the underline part? | 16:54 |
| aelkner | replaceafill, if i insert an <img> after the text of an <a>, does that render as underlined? | 16:54 |
| th1a | Down triangle | 16:54 |
| aelkner | ok | 16:55 |
| replaceafill | aelkner it depends on the css of the img | 16:55 |
| th1a | What triggers the menu now | 16:56 |
| aelkner | clicking the link | 16:56 |
| aelkner | which is just text noe | 16:56 |
| aelkner | now | 16:56 |
| th1a | Oh | 16:57 |
| aelkner | but i see why you want the icon | 16:57 |
| th1a | FYI that makes you score the activity on this | 16:57 |
| yvl | (aelkner, if you need a down triangle: http://en.wikipedia.org/wiki/Unicode_Geometric_Shapes ) | 16:57 |
| aelkner | yvl, thanks | 16:58 |
| th1a | There is one in jqueryui | 16:58 |
| aelkner | we also have a down triangle in jquery-ui as th1a suggests, right | 16:58 |
| aelkner | ? | 16:58 |
| aelkner | anyway, i have a long list of todo items now, th1a, so you don't have to worry about finding more for a couple days | 16:59 |
| th1a | Otoh the icon might waste precious space | 17:00 |
| th1a | Ok | 17:00 |
| aelkner | th1a, shall i scrap the icon? | 17:00 |
| aelkner | or try it out first | 17:00 |
| th1a | Hold off | 17:00 |
| aelkner | ok | 17:00 |
| th1a | Do aelkner and replaceafill need to get merged? | 17:02 |
| aelkner | not urgent if replaceafill hasn't changed gradebook lately | 17:03 |
| replaceafill | i haven't | 17:03 |
| th1a | Why is aelkner s ave and total at left | 17:03 |
| replaceafill | ah | 17:03 |
| aelkner | replaceafill, i pushed to trunk if you'd like to merge | 17:03 |
| replaceafill | my bad, i haven't commit that change yet | 17:03 |
| th1a | U should get in sync | 17:03 |
| th1a | Ok | 17:04 |
| aelkner | yeah, i was going to ask what happened to that | 17:04 |
| aelkner | replaceafill, what?! | 17:04 |
| replaceafill | aelkner you don't mind i touch the gradebook? | 17:04 |
| replaceafill | :) | 17:04 |
| aelkner | well, i made lots of changes to the overview pt | 17:04 |
| replaceafill | i know, it will raise conflicts | 17:05 |
| replaceafill | but i'll resolve them | 17:05 |
| aelkner | let's get this straitened out right after the meeting | 17:05 |
| th1a | Thanks aelkner | 17:05 |
| th1a | replaceafill? | 17:05 |
| replaceafill | http://69.164.203.135:6660/schoolyears/2010/q1/sections/2/journal | 17:06 |
| replaceafill | william:william | 17:06 |
| replaceafill | sorry i didn't use 'tom:tom' this time :) | 17:06 |
| replaceafill | th1a i have a couple of questions | 17:06 |
| replaceafill | how does the user gets to the journal? from section index? | 17:07 |
| replaceafill | there's a Journal tab, but i think it takes you to the student journal view | 17:07 |
| replaceafill | its url is ${person}/gradebook.html | 17:08 |
| th1a | I think this should work like the gradebook | 17:09 |
| replaceafill | using the tab, right? | 17:09 |
| th1a | Time to make these consistent | 17:09 |
| th1a | Y | 17:09 |
| replaceafill | but unlike the gradebook, the journal doesnt remember the last visited section | 17:10 |
| th1a | You might want to change the URL too | 17:10 |
| th1a | Maybe they should share | 17:12 |
| replaceafill | ah | 17:12 |
| th1a | Although it would need to be in core then | 17:12 |
| th1a | The value | 17:13 |
| replaceafill | hhmm | 17:13 |
| replaceafill | preferences package in core....? | 17:14 |
| th1a | I guess | 17:14 |
| replaceafill | ok | 17:14 |
| replaceafill | - Where do we put the legend? | 17:15 |
| replaceafill | for absences and tardies marks | 17:15 |
| th1a | Oh that damned thing | 17:15 |
| replaceafill | :D | 17:15 |
| th1a | Can we make it a dialog fro | 17:16 |
| aelkner | yeah, you'll need to add an annotations section to IPerson for journal preferences | 17:16 |
| th1a | M the sidebar? | 17:16 |
| replaceafill | th1a like "Help" or something? | 17:17 |
| th1a | aelkner: The point is it is a generic Active Section annotation | 17:17 |
| aelkner | we don't have such a thing yet | 17:17 |
| aelkner | so far the gradebook is the only package with person preferences annotation | 17:17 |
| th1a | aelkner: Which is the point | 17:17 |
| aelkner | and its key is gradebook specific | 17:17 |
| th1a | It is now a core issue | 17:18 |
| th1a | Does the gradebool store the section | 17:19 |
| aelkner | yes | 17:19 |
| aelkner | adn teh current worksheet | 17:19 |
| th1a | Or just the worksheet | 17:19 |
| aelkner | both | 17:19 |
| aelkner | let me look right now to be certain | 17:19 |
| aelkner | here's the list: | 17:19 |
| aelkner | GRADEBOOK_SORTING_KEY = 'schooltool.gradebook.sorting' | 17:19 |
| aelkner | CURRENT_SECTION_TAUGHT_KEY = 'schooltool.gradebook.currentsectiontaught' | 17:19 |
| aelkner | CURRENT_SECTION_ATTENDED_KEY = 'schooltool.gradebook.currentsectionattended' | 17:19 |
| aelkner | CURRENT_WORKSHEET_KEY = 'schooltool.gradebook.currentworksheet' | 17:19 |
| aelkner | DUE_DATE_FILTER_KEY = 'schooltool.gradebook.duedatefilter' | 17:19 |
| aelkner | COLUMN_PREFERENCES_KEY = 'schooltool.gradebook.columnpreferences' | 17:19 |
| aelkner | obviously the gradebook allows a teacher to be a student as well | 17:20 |
| th1a | So the section taught goes to core | 17:20 |
| th1a | A little refactor will be needed | 17:21 |
| aelkner | how about we let replaceafill add section taught to core and | 17:21 |
| aelkner | have me update the gradebook later to use it? | 17:21 |
| replaceafill | i'd prefer yvl to add the annotation to core | 17:21 |
| th1a | Ok | 17:21 |
| th1a | Ok | 17:22 |
| aelkner | we were looking for something to do for him anyway :) | 17:22 |
| replaceafill | and he does that better than me :) | 17:22 |
| replaceafill | th1a last question | 17:22 |
| replaceafill | - Total columns are calculated by term, but they seem like form month | 17:22 |
| replaceafill | oops | 17:22 |
| replaceafill | i meant: when you see month by month | 17:23 |
| replaceafill | they seem like they're calculated by month | 17:23 |
| replaceafill | not a big deal, just an observation | 17:23 |
| replaceafill | the gradebook does it by worksheet, which seems more natural | 17:23 |
| th1a | Well a menu here would be good | 17:23 |
| th1a | Let you select | 17:24 |
| th1a | Are the calculations going to be at right? | 17:24 |
| replaceafill | yes | 17:24 |
| th1a | Ok | 17:25 |
| replaceafill | are they going to be customizable? | 17:25 |
| replaceafill | edit the labels, hide, etc? | 17:25 |
| replaceafill | gradebook's are going to be, right? | 17:25 |
| th1a | Not edit | 17:25 |
| replaceafill | ah ok | 17:25 |
| th1a | Hide though | 17:25 |
| th1a | Yes | 17:25 |
| replaceafill | how do we unhide them? | 17:26 |
| replaceafill | Preferences view?!?! :) | 17:26 |
| th1a | Like gradebook | 17:26 |
| replaceafill | kk | 17:26 |
| replaceafill | i think that's it from me | 17:27 |
| aelkner | replaceafill, i haven't added the hide/unhide stuff to gradebook, but i will soon | 17:27 |
| aelkner | th1a wanted it to go in the Name menu | 17:27 |
| th1a | replaceafill: Do you have thing on your todo list that yvl can do? | 17:27 |
| aelkner | you should look at what i did before starting on that | 17:27 |
| aelkner | i can do that next | 17:27 |
| th1a | I don't want to stick him with interventions | 17:28 |
| replaceafill | my todo includes small things like: | 17:28 |
| aelkner | he could look at getting old sin tests working again | 17:28 |
| replaceafill | * Selection List Fields in person/resource demographics should be rendered as optional | 17:28 |
| replaceafill | ah! | 17:29 |
| replaceafill | i want a text area resource field :) | 17:29 |
| replaceafill | for resource evolution | 17:29 |
| replaceafill | for the notes field | 17:29 |
| yvl | and probably that should be HTMLFragment | 17:29 |
| replaceafill | ah | 17:30 |
| replaceafill | we have it already? | 17:30 |
| replaceafill | * Delete link should not be rendered when viewing 'manager'. You get a Dependency error | 17:30 |
| yvl | don't know, just saying - HTMLFragment over zope.schema.Text | 17:30 |
| replaceafill | * Port errors view | 17:31 |
| th1a | These are all good things | 17:31 |
| replaceafill | * add css parameter for table formatters | 17:31 |
| th1a | Check and add breadcrumbs | 17:32 |
| yvl | check and add breadcrumbs? | 17:33 |
| th1a | replaceafill: Any more? | 17:33 |
| th1a | A lot of views don't have them | 17:33 |
| replaceafill | th1a no, that's it | 17:33 |
| th1a | yvl: Breadcrumbs is the biggest job probably | 17:34 |
| yvl | more than one day's worth likely | 17:34 |
| th1a | So take your pick yvl | 17:35 |
| th1a | I may have to get my laptop working tomorrow... | 17:35 |
| th1a | Thanks replaceafill | 17:35 |
| th1a | I think were done | 17:36 |
| th1a | Last words? | 17:36 |
| th1a | ... | 17:36 |
| * th1a drops the bag I'd gravel | 17:36 | |
| th1a | Of | 17:36 |
| aelkner | Of? | 17:37 |
| replaceafill | :D | 17:37 |
| aelkner | of gravel | 17:37 |
| aelkner | :) | 17:37 |
| th1a | Of gravel | 17:37 |
| aelkner | could one gravel a bag? | 17:37 |
| aelkner | i wonder... | 17:37 |
| *** th1a has quit IRC | 17:37 | |
| aelkner | replaceafill, can we look at the gradebook right now? | 17:37 |
| replaceafill | aelkner ok | 17:37 |
| aelkner | for starters, i'd like you to merge and enconter the conflicts | 17:38 |
| aelkner | secondly, note that i changed some of the content to be empty divs | 17:38 |
| aelkner | because they were hidden by the freezecol div | 17:38 |
| replaceafill | i know | 17:38 |
| aelkner | ok | 17:38 |
| aelkner | so just be carefulto include the same in resolved version | 17:39 |
| aelkner | also, the popup meu class changes | 17:39 |
| aelkner | but i gues you were going to look at my divs to make sure anyway, right? | 17:39 |
| aelkner | diffs | 17:39 |
| replaceafill | yes | 17:39 |
| replaceafill | i'll finish my journal view, and then i'll work on that | 17:39 |
| aelkner | no, please, the other first | 17:40 |
| aelkner | for my peace of mind, i'd like to know what i'm changing is not disappearing later | 17:40 |
| replaceafill | aelkner i made too many changes to the gradebook_overview template | 17:40 |
| aelkner | so you can see why i don't like this multi-developer overhauling same template stuff | 17:41 |
| replaceafill | i'm not saying it will break, i'm saying it will take time | 17:41 |
| aelkner | but then if i change something else today, the problem starts again | 17:42 |
| * replaceafill sighs.. | 17:42 | |
| replaceafill | that's why i said i'd work on the gradebook until you leave | 17:42 |
| aelkner | so replaceafill echos /me's sentiments | 17:42 |
| replaceafill | but th1a wants them synced | 17:42 |
| aelkner | he wants them to work the same | 17:43 |
| aelkner | what he doesn't realize yet is how much work there will be | 17:43 |
| replaceafill | we have to do it anyway | 17:43 |
| replaceafill | today or when you're done with all the gradebook stuff | 17:44 |
| aelkner | as yvl said today, i thought our priority was to get the old code looking new | 17:44 |
| aelkner | not changing the way the old code works | 17:44 |
| aelkner | and what about this updoming freeze date? | 17:45 |
| aelkner | what could we possibly freeze in two weeks if we start adding lots of new features | 17:45 |
| replaceafill | when is the date? | 17:45 |
| aelkner | instead of just changing the look of the old ones | 17:45 |
| aelkner | a couple of weeks, i believe | 17:45 |
| replaceafill | ah | 17:45 |
| aelkner | but that could be moved, i guess, not my decision | 17:46 |
| aelkner | we don't even have interventions started, you just started journal | 17:46 |
| aelkner | gradebook has nice new style and operation, but lots of report sheet work to be done there | 17:46 |
| aelkner | but if you mean that thla wants the journal and gradebook to LOOK the same, that's another thing | 17:47 |
| aelkner | any css work you and he did should be repeatable in the journal | 17:47 |
| aelkner | although i did mention putting those styles in core so that you would not have to clone them | 17:48 |
| aelkner | but did anyone listen? | 17:48 |
| aelkner | i don't think so | 17:48 |
| aelkner | so now you have to clone them or move them to core | 17:48 |
| aelkner | if you clone them and then proceed to change them over the next week or so | 17:48 |
| aelkner | then you will need to back-port all the new stuff to the gradebook | 17:49 |
| aelkner | but the fact that i even need to mention the evils of cloning | 17:49 |
| aelkner | is enough to make my sigh for a week | 17:49 |
| aelkner | that's my daily rant :) | 17:49 |
| replaceafill | :D | 17:50 |
| aelkner | i'm not going to touch the gradebook css so as not to step on your journal efforts | 17:50 |
| aelkner | of effect your backporting work, that is | 17:50 |
| aelkner | or | 17:50 |
| replaceafill | don't worry, i'm not scared of conflicts | 17:50 |
| aelkner | fear is not the issue, time spent dong something that could cost zero time is the issue | 17:51 |
| aelkner | but knock yourself out | 17:51 |
| replaceafill | we just spent 10 minutes chatting when i thought we were going to discuss your pdb problem ;) | 17:52 |
| aelkner | right, ten minutes against the hours and hours i'm trying to save us | 17:52 |
| aelkner | but anyway, let's move on | 17:52 |
| replaceafill | :D | 17:52 |
| aelkner | pdb? | 17:52 |
| aelkner | you mean the tertiary not gettin gcalled | 17:52 |
| replaceafill | yep | 17:52 |
| aelkner | yeah, did you see something that i forgot to put in there? | 17:53 |
| replaceafill | did you push it to trunk? | 17:53 |
| aelkner | the view= directive has the right class | 17:53 |
| aelkner | yes | 17:53 |
| replaceafill | what's the name of the class? | 17:54 |
| replaceafill | i only see the tertiary nav manager | 17:54 |
| aelkner | the view class is FlourishActivityAddView | 17:55 |
| aelkner | is that what you mean? | 17:55 |
| replaceafill | no, i meant the viewlet manager for the tertiary navigation? | 17:55 |
| aelkner | ITertiaryNavigationManager | 17:55 |
| aelkner | look at the one directly above it | 17:56 |
| aelkner | it's the one you added for the gradebook overview | 17:56 |
| aelkner | it doesn't mention the class of the manager | 17:56 |
| aelkner | because the interface is enough | 17:56 |
| replaceafill | the only tertiary manager that i see in the gradebook is: | 17:56 |
| replaceafill | <flourish:viewletManager | 17:57 |
| replaceafill | name="tertiary_navigation" | 17:57 |
| replaceafill | provides="schooltool.skin.flourish.page.ITertiaryNavigationManager" | 17:57 |
| replaceafill | class=".gradebook.GradebookTertiaryNavigationManager" | 17:57 |
| replaceafill | view=".gradebook.FlourishGradebookOverview" | 17:57 |
| replaceafill | permission="zope.Public" | 17:57 |
| replaceafill | /> | 17:57 |
| aelkner | right after that is tertiary_activity_add | 17:57 |
| replaceafill | ah | 17:57 |
| aelkner | it looks the same except the view class | 17:58 |
| aelkner | ad the tertiary manager class | 17:58 |
| aelkner | which i coded in activity.py | 17:58 |
| replaceafill | aelkner it's the name="..." | 17:59 |
| replaceafill | the provider must be called tertiary_navigation | 17:59 |
| replaceafill | exactly | 17:59 |
| replaceafill | look at the page template in flourish | 17:59 |
| aelkner | ah | 17:59 |
| aelkner | the name and the interface are need to be the same | 17:59 |
| replaceafill | ? | 17:59 |
| aelkner | for anyone wanting to add a tertiary to a view, right? | 17:59 |
| replaceafill | yes | 18:00 |
| aelkner | ok, thanks | 18:00 |
| aelkner | now i understand the lookup | 18:00 |
| replaceafill | :) | 18:00 |
| aelkner | the name is the very ting that is traversed in man.pt | 18:00 |
| replaceafill | correct | 18:00 |
| aelkner | provideers/etrtiary_navigation | 18:00 |
| replaceafill | with less typos, but yes | 18:00 |
| replaceafill | ;) | 18:00 |
| aelkner | i was trying to figure out how that worked, but in pdb even, it's hard | 18:00 |
| aelkner | the lookups | 18:00 |
| aelkner | but now i get that it's taking advantage of the results of a named adapter lookup | 18:01 |
| replaceafill | correct | 18:01 |
| aelkner | thanks, that clears a lot up for me | 18:01 |
| replaceafill | great | 18:01 |
| * replaceafill goes back to the journal | 18:02 | |
| replaceafill | aelkner i'll break your work later >:D | 18:02 |
| replaceafill | i'm using the journal for testing btw | 18:02 |
| replaceafill | i think i'll merge the left/right work there | 18:03 |
| replaceafill | before merging it to the gradebook | 18:03 |
| replaceafill | and i'll use your popup work from the gradebook | 18:03 |
| aelkner | left/right? | 18:04 |
| replaceafill | names on the left, totals on the right | 18:04 |
| replaceafill | scrollable center only | 18:04 |
| aelkner | what about moving popup menu css and js to core? | 18:04 |
| aelkner | you see i made the class names gradebook independent | 18:04 |
| replaceafill | i don't want to bring that old conversation from last time :( | 18:04 |
| aelkner | why not have all our popup menus work the same | 18:05 |
| replaceafill | well, mine follow yours | 18:05 |
| aelkner | and have the document ready stuff in the main js include | 18:05 |
| replaceafill | yesterday for a while i was using the gradebooks zc resource library | 18:06 |
| aelkner | i don' see why you can't clone the <ul> and <a> stuff, but at least the css and js could be in core? | 18:06 |
| replaceafill | aelkner they will | 18:06 |
| aelkner | you were using gradebook resource from journal? | 18:06 |
| replaceafill | yes | 18:06 |
| replaceafill | i know it makes one dependent on the other, etc | 18:06 |
| aelkner | ah, so you will move them to core | 18:06 |
| replaceafill | but i was testing | 18:06 |
| replaceafill | i hope so | 18:06 |
| replaceafill | one thing that makes me not to do that right now, is that company th1a hired | 18:07 |
| replaceafill | i think they'll come up with something | 18:07 |
| replaceafill | and if we spent time making ours perfect right now... | 18:07 |
| replaceafill | that does seem like a waste to me | 18:07 |
| aelkner | well | 18:08 |
| aelkner | i would say, oving css and js to core wouldn't waste time | 18:08 |
| aelkner | because whatever changes the consultants lead us to make | 18:08 |
| aelkner | will be made wherever they are | 18:08 |
| aelkner | so if that's just in core rather than in two places! | 18:08 |
| aelkner | you see the time saving there? | 18:08 |
| replaceafill | well, i can use the gradebook's | 18:08 |
| replaceafill | i have been | 18:09 |
| replaceafill | so... really only one place | 18:09 |
| aelkner | yes, the journal does not depend n the gradebook | 18:09 |
| aelkner | so making it do so only adds work undoing that | 18:09 |
| replaceafill | yes, taking that zc resource library line is hard... | 18:09 |
| replaceafill | :/ | 18:10 |
| aelkner | is that wy you don't want to do it, because it is hard? | 18:10 |
| replaceafill | it was a bad joke aelkner :) | 18:11 |
| aelkner | i had a feeling you were being sarcastic | 18:11 |
| aelkner | i was just making sure | 18:11 |
| replaceafill | :D | 18:11 |
| *** ignas has quit IRC | 18:11 | |
| aelkner | so if it isn't hard, then wy don't you just say, "yes, i'll do it (and in little time since it's so simple)" | 18:11 |
| replaceafill | yes, i'll do it | 18:13 |
| aelkner | that can be part of your right/left change | 18:14 |
| aelkner | i'll work around the edges in the meantime | 18:14 |
| replaceafill | don't | 18:14 |
| replaceafill | i want you to work confortably | 18:14 |
| aelkner | well, until i see the changes that you make, i won't be comfortable, so don't worry about that | 18:15 |
| replaceafill | :D | 18:15 |
| replaceafill | ah ok then | 18:15 |
| aelkner | i can fix the add activity tertiary now, though, and that won't collide with you in the least | 18:16 |
| aelkner | and i'll want to review your diff right away, so please ping me when you've pushed | 18:16 |
| replaceafill | will do | 18:16 |
| aelkner | thanks | 18:16 |
| aelkner | moving the js is trivial | 18:17 |
| aelkner | it's clean and compact | 18:17 |
| aelkner | the css stuff, actuall, is also, pretty simple to move | 18:17 |
| replaceafill | ok, you know what | 18:18 |
| replaceafill | let's move them! | 18:18 |
| aelkner | popup stuff should go in page.css, right? | 18:18 |
| replaceafill | :D | 18:18 |
| replaceafill | aelkner no | 18:18 |
| replaceafill | grid.css | 18:18 |
| replaceafill | hhhmm | 18:18 |
| aelkner | this is not grid specific in my opionion | 18:19 |
| replaceafill | don't know | 18:19 |
| replaceafill | i agree | 18:19 |
| aelkner | a popup menu could go on any page, that's why i suggested page.css | 18:19 |
| replaceafill | i'll put things that i don't know whet to put at the bottom of flourish.css :) | 18:19 |
| replaceafill | *where | 18:19 |
| replaceafill | with an XXX | 18:19 |
| aelkner | page.css | 18:19 |
| aelkner | why not there | 18:19 |
| replaceafill | put it there | 18:20 |
| replaceafill | just add an XXX | 18:20 |
| aelkner | so obviously we need to cordinate closely here for the next half hour of so | 18:20 |
| aelkner | or | 18:20 |
| replaceafill | no, *you* do it | 18:20 |
| aelkner | i cold do the move | 18:20 |
| replaceafill | yes | 18:20 |
| aelkner | :) | 18:20 |
| aelkner | i'll do that right now | 18:21 |
| replaceafill | go go go | 18:21 |
| replaceafill | we're moving the f_gradebook_overview.pt template too, right? | 18:21 |
| aelkner | ? | 18:22 |
| aelkner | replaceafill, i was tlaking about just moving the document ready js for popup menu | 18:23 |
| aelkner | what are you talking about? | 18:23 |
| replaceafill | are we not going to sync the two grids? | 18:23 |
| aelkner | think about it | 18:23 |
| aelkner | we have a codebase that we've invested years in | 18:23 |
| replaceafill | what about the evils of cloning? | 18:23 |
| aelkner | the cost of rewriting both the gradebook and the journal are huge, so i don't know what you mean | 18:25 |
| replaceafill | no!!! | 18:25 |
| replaceafill | i dont want the API i dream of :) | 18:25 |
| replaceafill | i'm talking about both plugins using the same template | 18:25 |
| aelkner | but the templates are tied to the APIs of the view classes | 18:26 |
| aelkner | the gradebook and journal are much different in their view classes | 18:26 |
| aelkner | how could they possibly share a template? | 18:26 |
| replaceafill | yes, but i made the journal flourish view to use most of the gradebooks template | 18:26 |
| replaceafill | they *were* very different | 18:26 |
| replaceafill | one rendering the table by hand, the other using a really cool table formatter (which i'll miss) | 18:27 |
| replaceafill | :D | 18:27 |
| aelkner | yeah, i know you love those table formatters :) | 18:27 |
| replaceafill | now, both use the rendering by hand approach | 18:27 |
| replaceafill | (unfortunately) | 18:28 |
| aelkner | i don't see why you cose to do this | 18:28 |
| aelkner | chose | 18:28 |
| aelkner | wasn't the css of cells the issue | 18:28 |
| replaceafill | no, was that i had invested time in cleaning the gradebook | 18:28 |
| replaceafill | and that work was useful for the journal | 18:29 |
| aelkner | outside of css, what cleaning are you referring to | 18:29 |
| replaceafill | and th1a insisted on they behaving almost the same | 18:29 |
| replaceafill | css | 18:29 |
| aelkner | yeah, so you clone (yes i suggested that in this case) the journal's old sin template | 18:30 |
| aelkner | and make the css class changes needed | 18:30 |
| aelkner | so that the view uses the old view class | 18:30 |
| replaceafill | that's not good for us anymore | 18:30 |
| aelkner | with the table formatters and all | 18:30 |
| aelkner | why not? | 18:30 |
| replaceafill | the old skin used the table formatter + ajax | 18:30 |
| aelkner | ah, i guess the old one isn't a priority in the new skin | 18:31 |
| aelkner | i can see that now | 18:31 |
| aelkner | thla wants the journal to work like the gradebook (which is impvoed) and that's it | 18:31 |
| replaceafill | yep | 18:31 |
| aelkner | that's cool | 18:31 |
| replaceafill | did you see the journal this morning? | 18:32 |
| aelkner | so you are in a way, rewriting the journal, but a lot of the old skin | 18:32 |
| replaceafill | didnt you notice it was "exactly" the same | 18:32 |
| aelkner | view class will help | 18:32 |
| aelkner | i didn't notice anything because i didn't see anything :) | 18:32 |
| aelkner | link? | 18:32 |
| replaceafill | http://69.164.203.135:6660/schoolyears/2010/q1/sections/2/journal | 18:32 |
| replaceafill | william:william | 18:32 |
| aelkner | i get an exception clicking on the journal tab | 18:33 |
| aelkner | i guess you know that | 18:34 |
| replaceafill | yes | 18:34 |
| aelkner | i'll try the link | 18:34 |
| replaceafill | we discussed that also... | 18:34 |
| aelkner | again, now that i've logged in | 18:34 |
| aelkner | i need to add the journal to my local and demo instances soon | 18:34 |
| aelkner | please push stuff as soon as it is useful | 18:35 |
| replaceafill | will do | 18:35 |
| aelkner | i try to do that with my gradebook changes as i do them | 18:35 |
| aelkner | anyway, looks nice | 18:35 |
| aelkner | and exactly like the gradebook! | 18:35 |
| aelkner | this is clearing up years of inconsistency and over-design | 18:36 |
| replaceafill | see, that's why i say go one step further and share the templates | 18:36 |
| aelkner | well, now i see your point | 18:36 |
| aelkner | but, think about this | 18:36 |
| aelkner | making all the columns work off the same template would require them sharing a base view class | 18:37 |
| aelkner | i'd say, after the freeze, when we have tons of time | 18:38 |
| aelkner | refactor time! | 18:38 |
| aelkner | this would be the time to create a base Grid view class | 18:38 |
| aelkner | and have both the gradebook and journal use it | 18:38 |
| aelkner | just looking at the gradebook's update method | 18:39 |
| aelkner | where so many different things are done | 18:39 |
| aelkner | and, as you said, no table formatters like the journal | 18:39 |
| aelkner | making them wok the same way in the python is much different than getting them to look | 18:40 |
| aelkner | the same as you just did | 18:40 |
| replaceafill | http://pastebin.com/KcNajm1T | 18:40 |
| replaceafill | that's the method that builds the table for the journal right now | 18:40 |
| replaceafill | notice i tried to make it look like the gradebook's | 18:41 |
| replaceafill | it still can be improved | 18:41 |
| aelkner | i see that most is the same | 18:41 |
| aelkner | the gradebook has four columns | 18:41 |
| replaceafill | the gradebook uses the activity hash + person id | 18:41 |
| aelkner | all need to hidable | 18:41 |
| aelkner | total, average, absenses, tardies | 18:42 |
| replaceafill | yes, but i think those are the things we need to solve | 18:42 |
| aelkner | i see | 18:42 |
| replaceafill | or.... we can keep maintining our clones... | 18:42 |
| aelkner | will the journal have those same four columns? | 18:42 |
| aelkner | and will they also be hidable | 18:42 |
| replaceafill | no, but that's a design flaw in the gradebook | 18:42 |
| replaceafill | why not a dictionary with the totals? | 18:43 |
| aelkner | you see, the absenses and tardies cols in he gradebook are foreign data | 18:43 |
| replaceafill | correct | 18:43 |
| replaceafill | some of them are optional | 18:43 |
| aelkner | i'm talking user-centered at the moment | 18:43 |
| aelkner | if the user changes something in the journal | 18:43 |
| replaceafill | ah ok | 18:43 |
| aelkner | they are changing the totals or absenses and tardies as well as journal grades | 18:44 |
| aelkner | so i guess the same four columns could exists, right? | 18:44 |
| replaceafill | hhmm not total | 18:44 |
| replaceafill | the journal doesn't have total | 18:45 |
| replaceafill | i mean, current schooltool | 18:45 |
| aelkner | i understand, that was partly my point | 18:45 |
| aelkner | but i'm trying to think outside of the box | 18:45 |
| aelkner | if thla wants both to work the same | 18:45 |
| replaceafill | but again, why not an iterable with total columns | 18:45 |
| replaceafill | why do they have to be dictionalry keys | 18:46 |
| aelkner | dictionary keys are used for traversal in the template | 18:46 |
| aelkner | how do you mean to change that? | 18:46 |
| replaceafill | same as we do with grades | 18:46 |
| replaceafill | grades is a list | 18:46 |
| replaceafill | you just iterate it | 18:47 |
| aelkner | ah, so summary cols could be a list | 18:47 |
| replaceafill | totals could be a list | 18:47 |
| replaceafill | yep | 18:47 |
| replaceafill | the gradebook inserts what it needs | 18:47 |
| replaceafill | and the journal too | 18:47 |
| replaceafill | it gets rendered the same | 18:47 |
| aelkner | keep in mind this one: | 18:47 |
| aelkner | the total col in the gradebook will end up soon having a menu with Sort by | 18:48 |
| aelkner | and a dropdown to change score system | 18:48 |
| replaceafill | menus should be inserted too by the plugins | 18:48 |
| replaceafill | for instance, the journal columns dont need edit action | 18:48 |
| replaceafill | the gradebook's do | 18:48 |
| replaceafill | you just set the placeholder | 18:49 |
| replaceafill | even the activity headers should have a render method | 18:49 |
| replaceafill | but that's not important | 18:49 |
| replaceafill | both plugins can send in the dictionary the title they want rendered | 18:49 |
| aelkner | so you're suggesting moving rendering of plugin-specific stuff to view methods | 18:50 |
| aelkner | and having the grid template call into that | 18:50 |
| aelkner | grid base class i mean | 18:50 |
| aelkner | and template, of course | 18:50 |
| replaceafill | either way | 18:50 |
| *** menesis has quit IRC | 18:50 | |
| replaceafill | we could in the template | 18:50 |
| replaceafill | row/title | 18:50 |
| replaceafill | title was calculated in the view class | 18:51 |
| replaceafill | the journal does it one way | 18:51 |
| replaceafill | the gradebook in another way | 18:51 |
| replaceafill | but both creates the {'title': XXXX} key | 18:51 |
| replaceafill | in my head it's possible | 18:51 |
| replaceafill | i've been playing with it | 18:51 |
| aelkner | so the dictionary carries the rendered html, not view methods? | 18:52 |
| replaceafill | i'd prefer putting the same place holders | 18:52 |
| replaceafill | and adding independent js for specific stuff | 18:52 |
| replaceafill | for example | 18:53 |
| replaceafill | an "activity" title | 18:53 |
| aelkner | js can be rendered together with html in those cases of specific local need | 18:53 |
| replaceafill | to me the templates for the gradebook and journal should be like our z3c-form macros | 18:53 |
| replaceafill | like | 18:53 |
| replaceafill | <script> XXX </script> | 18:54 |
| replaceafill | <div use-macro="grid"> | 18:54 |
| replaceafill | or something like that | 18:54 |
| replaceafill | the grid is the same, both plugins add specific js | 18:54 |
| aelkner | sounds clean enough | 18:54 |
| aelkner | how about this | 18:54 |
| aelkner | you can create the grid base class and macro in core | 18:55 |
| aelkner | use it in the journal | 18:55 |
| aelkner | and fix the gradebook to use the grid class later | 18:55 |
| aelkner | whatever changes i make to the gradebook grid | 18:55 |
| aelkner | mostly, btw, to the menus | 18:56 |
| aelkner | will be easily ported to the grid macro | 18:56 |
| aelkner | sound like a plan? | 18:56 |
| replaceafill | hhmm | 18:56 |
| replaceafill | i could try | 18:56 |
| replaceafill | i'm not good at that though | 18:56 |
| replaceafill | :) | 18:56 |
| aelkner | what do you mean, we're all capable of the same stuff | 18:57 |
| aelkner | and you suggested the whole grid base class anyway | 18:57 |
| aelkner | are you saying you had in mind someone else doing it? | 18:57 |
| replaceafill | it was just my rant ;) | 18:57 |
| aelkner | i mean, you are already overhailing the journal | 18:57 |
| replaceafill | yep | 18:57 |
| aelkner | i'd say you're on the right track | 18:57 |
| aelkner | you can create a core base class if you have something in mind | 18:58 |
| aelkner | and use it in the gradebook when i am out of the way | 18:58 |
| replaceafill | maybe i will :) | 18:58 |
| aelkner | it's not urgent, but i like your thinking | 18:58 |
| aelkner | i was going to say, isn't this treason? | 18:58 |
| aelkner | suggesting a view class over cloning? | 18:58 |
| aelkner | :) | 18:58 |
| replaceafill | :D | 18:59 |
| replaceafill | ok, i'll give it a try | 18:59 |
| aelkner | good luck, i think you'll come up with something good | 18:59 |
| replaceafill | thanks aelkner! | 18:59 |
| aelkner | do i still want to move the popup menu js, css now? | 19:00 |
| replaceafill | i'll do it | 19:00 |
| replaceafill | :D | 19:00 |
| aelkner | ok, thanks | 19:00 |
| aelkner | see how i tricked you into dong that? :) | 19:00 |
| replaceafill | yeah, i was thinkign the same | 19:00 |
| replaceafill | :P | 19:00 |
| aelkner | but anyway, good discussion | 19:01 |
| replaceafill | that's the problem with being the junior developer here | 19:01 |
| replaceafill | yeah, thanks | 19:01 |
| replaceafill | i hope it works | 19:01 |
| aelkner | i hink we have a good plan for proceeding (AND staying out of each other's way) | 19:01 |
| aelkner | for the next couple of day | 19:01 |
| replaceafill | :D | 19:01 |
| replaceafill | kk, will start then | 19:01 |
| replaceafill | see you later aelkner | 19:01 |
| aelkner | of course, i do need you to ping me when you've folded your unpushed gradebook stuff into trunk | 19:02 |
| aelkner | just a reminder :) | 19:02 |
| replaceafill | i will | 19:02 |
| aelkner | thanks | 19:02 |
| *** alga has joined #schooltool | 21:13 | |
| *** menesis has joined #schooltool | 21:21 | |
| *** dadeng has joined #schooltool | 21:30 | |
| *** menesis has quit IRC | 21:41 | |
| replaceafill | aelkner you there? | 21:46 |
| *** dadeng has quit IRC | 21:49 | |
| *** jelkner has joined #schooltool | 22:11 | |
| *** replaceafill has quit IRC | 22:22 | |
| *** jelkner has quit IRC | 22:45 | |
| *** aelkner has quit IRC | 23:22 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!