IRC log of #schooltool for Wednesday, 2013-03-27

*** replaceafill has quit IRC01:17
*** menesis has quit IRC01:30
*** khildin has joined #schooltool09:22
*** ignas has joined #schooltool11:55
*** menesis has joined #schooltool11:58
*** ignas has quit IRC12:24
*** replaceafill has joined #schooltool15:02
th1ahi replaceafill, yvl, menesis.15:31
yvlgood morning15:31
replaceafillgood morning/afternoon15:31
th1aFirst off, was the last email I sent to Thailand accurate?15:32
*** ignas has joined #schooltool15:32
menesisth1a: yes15:33
th1aOK, I'll fix the book.15:33
th1ayvl: Go ahead.15:34
yvlI'll make it short15:34
yvlfixed journal, menesis merged it15:34
yvlit includes evolution15:34
yvlnow got back on reports15:34
yvlthat is all15:35
th1areplaceafill:  Can we test the journal fix with jelkner's data?15:35
replaceafillah sure15:36
replaceafilli'll update his "unstable" instance15:36
replaceafill(we have two types of instances running for them now) :)15:36
replaceafillunstable is the one running the sprint code15:37
th1aAlso... jelkner also had the duplicate periods issue, correct?15:37
th1aIs that another manifestation of the same bug?15:37
replaceafillyes, i think he did15:38
replaceafillbut i don't remember seeing it in his journal views15:38
replaceafilli'll look15:38
th1ayvl:  Do you know what I'm talking about?15:39
menesisduplicate periods bug:
replaceafillhe either fixed the timetable/schedules or it was a different instance, i don't see it in the HILT instance15:40
th1aThey had it in Thailand too.15:41
th1aCould the journal sometimes have been taking the periods from the overlapping terms?15:41
yvlit's probably adjacent sections15:42
yvlbut I can't tell from the bug description15:42
th1aOK, well, regardless we should see if it goes away now.15:42
replaceafilli tried to reproduce it but i wasn't able to15:42
menesisI think that's similar issue that yvl has fixed15:43
th1ayvl:  You'll have to show me the report system at some point.15:43
menesisperiods from somewhere else visible in the journal15:44
yvlas for adjacent section15:44
yvljournals used to mash up sections with same instructors and courses for any of the students of the section you're looking at15:45
yvland I mean any15:45
yvlschoolyears don't matter15:45
yvlso if there was some test data or something - it could cause that15:47
yvlI think I also saw a bug recently with schedules15:47
yvlwhen school year is copied15:47
yvldidn't double check15:47
yvlbut I think it copies the dates15:47
yvlthat means - section is scheduled for the *previous* year15:47
th1aRight... it shouldn't try to schedule them at all.15:48
th1aShouldn't try to move them, that is.15:48
yvljust a place we need to check at some point15:48
yvlcopying the timetables15:48
yvljust saying - you might have witnessed an undocumented behaviour exposed by a bug :)15:49
yvlbehaviour now fixed.15:49
th1aThanks yvl.15:50
replaceafillok, small comment on the thailand journal issue15:51
replaceafillafter i tried to reproduce15:51
replaceafillpujendra sent me his admin login credentials for their instance15:52
replaceafilli just logged in and noticed the "duplicated periods" bug15:52
replaceafillbut it's because in his schedule15:52
replaceafillhe has two consecutive periods marked for the same day15:52
replaceafilland he hasn't checked the "Treat consecutive periods as one meeting" option15:53
replaceafillso, he gets two "08 08" for march15:53
replaceafillnot sure what would happen if we tell him "check that option"...15:54
th1aOh, retroactively?15:54
replaceafillbut the period is clear15:54
th1aWe should probably find out. :-S15:54
* replaceafill goes to see the bug15:54
th1aI don't know that I filed a separate one.15:55
replaceafilli remember we had some screenshot...15:55
* replaceafill looks for the section in the screenshot15:55
menesisthat's correct behavior, and with the option checked, only one period would be displayed15:55
replaceafill(i can do this after the meeting if you want) :)15:55
replaceafilloh my! lots of math sections :D15:56
replaceafilli think that's the issue15:57
replaceafilli mean15:57
yvloh, btw, remembered a small thing about Jeffs data15:57
th1aYes, that's why the box is there.15:57
replaceafillit's correct behaviour15:57
yvlhe teaches some section over 4 quarters15:57
yvland Q1 is streched over a year15:58
yvlsome student dropped out, and he is only in section of Q1, but not in Q2-Q415:58
yvlthen again, he has attendance marked in dates that should be Q2 :)15:58
th1aIs that because he made Q1 first and changed it?15:58
th1aSo ideally... what?  If you change a term's range all the sections should update?15:59
th1aThat's a little scary in itself.15:59
yvlnow that I do not know15:59
* yvl is a bit uncomfortable with automation like that16:00
th1aYou could destroy a lot of data that way.16:00
replaceafillhhmm looking at pujendra's dates it seems like a bug though, he should have repeated periods just for one day16:00
th1aWell, that gets into year statuses.16:00
th1aDo that during the setup period.16:00
th1aDon't allow it to be changed once active.16:00
replaceafilland he has repeated periods in consecutive days, which don't match the section schedule setup16:00
replaceafillwell, i hope yvl's change to adjacent sections fixes pujendras duplication16:02
replaceafilli don't see it in jelkner's hilt anymore16:02
th1aI'll make sure and ask.16:03
replaceafilli'll check his other instances (nvcc, amhs)16:03
replaceafilllots of "acronyms?" :D16:03
replaceafilli fixed the current section logic in the gradebook16:03
replaceafillyvl, i have a question here16:03
replaceafilli decided not to touch the actual function16:04
replaceafilland put the check on the views16:04
replaceafilldo you think this is ok?16:04
replaceafillah, and i added a stest for it16:04
yvl(only views, not why stests :) )16:04
replaceafillbecause views had access to the user sections already16:05
replaceafilli could move that to a function in the gradebook module itself16:05
replaceafilli also considered it's the only place it's being used right now, and that limiting the actual function was a bad idea16:06
yvlyes, if dependencies are there16:06
yvlwell, there is a duplicate of the function in journal16:07
replaceafilloops, i thought the journal was using this same one :(16:07
replaceafilli need to fix *that* too16:08
replaceafilli checked cando and it uses the same view16:08
replaceafillas the gradebook16:08
yvlthere is a duplicate there too though16:08
yvl(rudimentary probably)16:08
replaceafillhhmm maybe me using grep was a mistake16:09
replaceafillgot them16:10
yvloh, and the reason I asked was that16:10
yvlname setCurrentSectionTaught16:10
yvlkind of implies that you have to teach the section to make it current taught16:11
yvlcurrent taught section that you do not teach16:11
yvlis not something that makes sense16:11
replaceafillgot it16:11
* yvl would vote for limiting the function itself :)16:11
replaceafilland i considered it to be just a preference16:11
replaceafillsomething to remember16:12
replaceafillnot the "taught" part16:12
yvl(and when you have functions that do not make sense, you have bugs that do not make sense ;) )16:12
yvlwe could always rename it to setCurrentSectionToRemember :)16:12
replaceafillok, i'll move the limiting part to the function itself16:13
replaceafilland will get the IInstructor and ILearner sections there16:13
replaceafillas well16:13
replaceafillthanks yvl16:13
* replaceafill done16:14
th1aOK, so we'll be waiting for that to do a bugfix release.16:14
th1aThanks replaceafill.16:14
menesiscurrent section only matters for the views... I would say the set/getCurrentSection would better fit in browser16:14
th1amenesis:  Remind me of what our release deadline is for universe.16:14
menesisyou fixed the places where the set function is used, so I think this change is all ok16:15
menesisonly have to fix the equivalent function in journal16:15
menesisth1a: final freeze is April 1816:16
menesisin three weeks16:17
replaceafilli wonder, if all of the three packages (gradebook, cando and journal) are using the same annotation key, why don't we move this to core?16:18
yvlbecause journal works without gradebook?16:19
replaceafillright, but it would work from core, right?16:19
replaceafilli mean, the journal sets the annotation key as the same of the gradebook16:19
replaceafill(or maybe i'm missing something)16:19
replaceafillso does cando16:20
replaceafillcando depends on the gradebook, but not the journal16:20
replaceafillwhy don't we move the annotation key (and functions) to core and make the gradebook ,cando and journal to use them from there16:20
replaceafillhhmm i think it's the same story as with the js resources shared by all of them16:21
replaceafilland i probably know how we all think about it :D16:21
replaceafillit would just be nice to have what causes the bug centralized in a single place16:22
replaceafillbut ok, i'll let it go :)16:22
* replaceafill goes to update jelkner's instance16:23
yvlyou can move it ;)16:23
replaceafilli know you don't like that idea, right?16:23
yvlif we do make journal use requirements16:23
yvlit will become dependent on gradebook anyway16:24
th1aWhich we will very soon.16:24
menesiscando has a copy of getCurrentSection functions, but does not use them16:24
yvlunless we split out the requirement from gradebok - which we will not16:24
th1aRequirement should probably be in core.  ;-)16:24
yvlin any case16:25
yvlit could reside in gradebook, but it would need to make journal dependent on gradebook16:25
yvlin both eggs and debs16:25
replaceafilli have no problem maintaining the three versions... as long as we have tests for all of them :)16:26
yvlit's the only reason I would postpone this until the next release16:26
replaceafilli understand16:26
th1aYeah... now is not the moment.16:26
replaceafillhhmm th1a i'll better wait to talk to jelkner to update his instance16:28
replaceafilljust in case he's giving a quiz or something16:28
menesiscurrently gradebook depends on journal, but only because there are some reports that mix grades with absences16:28
menesisattendance-only reports can be moved.16:29
menesisjournal external source (for report sheets), too16:29
menesisthen only journal depends on gradebook, because it uses some of its features16:30
th1aOK.  Anything else menesis?16:33
menesisreplaceafill: of the three versions, cando does not set current section, and does not use getCurrentSection methods it redefines16:34
replaceafillmenesis, right16:34
replaceafilli'll add a stest and try to get rid of them16:35
menesisI have looked at the new issues posted, replied about translations and installation16:35
menesismarked duplicates and where the 2.1 branch ended for another bugfix that would be good to include16:36
menesiswanted to paste a link to install from ppa instructions, but there is no such page in the book?16:37
menesisso I updated the Installation instructions, added install-dev page for installing development version16:37
menesisupdated links in the book and PPA descriptions on launchpad16:38
th1aWell there's this:
menesisno, this is install from bzr branches16:38
menesis(needs updating, too)16:39
menesisI was talking about dev PPA16:39
menesismore, looked at yvl's journal merge request16:40
menesiswas puzzled by test output changes, but after looking closer I undestood what was being done16:41
menesisso merged it16:41
menesisother than that, was writing/refactoring the schooltool.paste and the main script in my celery branch16:44
th1aOK.  Sounds good.16:44
th1areplaceafill:  I guess still re-doing old reports next.  Well, move the graphical reports into main CanDo first.16:45
replaceafillth1a, understood16:45
th1aAlso, we need to talk about the autism stuff.  I want that in main CanDo too.16:45
replaceafillah ok16:46
replaceafilli should test that with new code16:46
th1aThat may take a score systems update though.16:46
replaceafillor update it16:46
th1aKeep me in the loop.16:46
th1aThanks guys.16:46
* th1a drops the bag of gravel.16:46
th1aHave a good week/end.16:47
yvlthanks guys16:47
th1aHappy Easter.16:47
yvlHappy Easter :)16:47
th1aWho's working Monday?16:47
replaceafillthanks everybody16:47
replaceafilli am :)16:47
menesisnot me16:48
* replaceafill might take a couple of days off at the end of april... i'll let you know :)16:48
th1aOK replaceafill.16:48
yvlok :)16:49
* yvl not working too it turns out16:49
th1aOK. So... see you next Wednesday then.16:50
th1areplaceafill:  We can just meet whenever on Monday.  You don't have to get up. ;-)16:51
replaceafillthanks! :D16:51
*** yvl has quit IRC16:52
*** ignas has quit IRC19:11
*** khildin has quit IRC22:32
*** replaceafill has quit IRC23:28

Generated by 2.15.1 by Marius Gedminas - find it at!