IRC log of #schooltool for Wednesday, 2012-10-03

*** th1a has quit IRC00:58
*** replaceafill has quit IRC01:30
*** khildin_ has quit IRC02:52
*** Lumiere has quit IRC05:16
*** Lumiere has joined #schooltool06:28
*** Lumiere has quit IRC06:34
*** Lumiere has joined #schooltool06:34
*** khildin has joined #schooltool09:45
*** menesis has quit IRC11:40
*** menesis has joined #schooltool12:40
*** menesis has quit IRC14:51
*** yvl has joined #schooltool15:32
*** th1a has joined #schooltool16:12
*** replaceafill has joined #schooltool16:13
th1ahi replaceafill, aelkner, yvl.16:30
yvlgood morning16:31
replaceafillgood morning/afternoon16:31
th1aWould you like to start us off yvl?16:31
*** menesis has joined #schooltool16:32
yvlI fixed two bugs16:32
yvlthe one with login16:32
yvland the security issue16:32
yvlI'm almost done with calendar current day highlighting16:32
th1aWhat did you do about the security issue?16:33
th1aThat is, how does it work now?16:33
yvlfixed it16:33
yvlI'll update the bug status16:33
yvlIRC is public and all :)16:34
yvlthere :)16:34
th1aI don't know that the future implementation needs to be secret.16:35
* yvl too16:35
yvlanyway, you should get the email now16:35
yvlanother thing.. I was wondering if we should add school logo import16:35
yvlwe do have photos anyway now16:36
th1aYes please!16:36
yvlare there places where you'd like me to display it?16:36
th1aHm... good question.16:37
th1aIt won't look right against the teal.16:37
th1aWe've tried to shrink that.16:37
th1aI'd say printed reports are the main thing.16:37
th1aYou might suggest a white or transparent background.16:37
yvlI could display it instead of SchoolTool text16:38
yvland add a small border16:38
yvl(darker teal)16:39
yvlso if it is with white background, it will look in a box16:39
yvlnot sure if it's a good idea16:39
th1aI don't want to rush it into the web interface.16:39
menesisfor Philippines I have added the school logo below the schooltool logo, in the same row as heading16:39
menesison the right16:39
menesisbut only on two pages that have short titles16:40
th1aThat's a possibility.16:40
menesissome titles can be very long, they don't fit16:40
menesisand logo can be wide16:40
menesisso even less space16:40
yvlth1a might contract our web designers for "a place to put school logo" :)16:40
yvlit seems like a thing they would deal on a daily basis16:41
th1aTo me it has always been more of an issue for printed reports.16:41
th1aThe teal header screws it up -- we'd have to change the whole header.16:41
menesisreplacing schooltool logo would be better... except that it has teal background and schooltool logo itself had to be inverted there16:41
th1aWe could add it to the login page, perhaps.16:42
th1aThat's one place you'd like to be assured of where you are.16:42
yvlcan I add it at the left?16:43
th1aThat's what I was thinking.16:43
yvlwill do16:43
th1aWhere the sidebar would be, right?16:43
yvlI was also looking at
yvlUI for calendar overlays16:44
yvlI wonder how low that fruit is hanging16:44
th1aI suspect that's more than a two day fix.16:45
th1aDid you look at this one:
th1aIs this still a bug?
yvlI loooked at the teacher bug16:46
yvlno idea how that happened still16:46
yvlselenium tests... some of that may still be a bug16:47
replaceafilli don't think so16:47
yvlthere's some new stuff of course16:47
replaceafillall of them have been resolved i think16:47
yvllike chrome makes temp files export.xls.chromedld16:47
replaceafill(i mean, the 3 items i listed in the bug) :)16:48
yvlI remember solving something there, but can't remember what16:48
yvl(the orig bug that is)16:48
replaceafillhow about this?
replaceafillsounds easy?16:50
th1aAh, sure!16:50
replaceafillthere was another about contacts i'm looking for... :)16:50
replaceafillthis one:
th1aPretty much any of the high priority bugs are... high priority.  ;-)16:51
th1aSo feel free.16:51
replaceafillthis may not be so low hanging:
th1aAlso some of these just haven't been makred as fixed.16:52
th1aoh... yeah, I should have triaged that.16:53
* th1a looks at undecided.16:53
th1aI'll go through those after the meeting.16:54
th1aOK, I think you'll be able to stay busy for a couple days, yvl.16:54
yvlyes, I'm fine bugwise now16:54
th1aThank you!16:54
replaceafilli have a question for yvl16:55
replaceafilli haven't checked your section skills changes very well16:55
replaceafillbut i noticed while i was merging my projects gradebook branch to trunk16:55
replaceafillthat now the skills gradebook shows worksheets as "deployed"16:56
replaceafillcould you explain that a little?16:56
yvlseems that some functionality got inherited16:57
yvlby accident16:57
yvlis it bad that it shows worksheets deployed?16:57
replaceafillit just that the worksheet tab in the cando dropdown gets italic  font16:57
replaceafillnot a big deal16:58
aelknerdeployed worksheets are for the report card system16:58
replaceafillbut it gets my attention :D16:58
aelkneri would say it is bad if any worksheet that is not for the report card would be marked deployed16:58
yvlI missed that16:58
replaceafilli can dig into the change and see what it's doing it16:59
replaceafill(i just haven't yet) :)16:59
yvlthanks man17:00
replaceafillth1a, i'm now adding the functionality you requested17:00
replaceafillto update from projects -> skills17:00
replaceafilli decided to write a test so i don't have to keep testing it manually ;)17:00
th1aI think replaceafill programmed a bot to say "th1a, i'm now adding the functionality you requested" at 10:00 in case he's not here.17:00
th1aThat'll fool me.17:01
replaceafillgood idea!17:01
replaceafilla bot to give my reports...17:01
th1aI am on track to meet the appointed deadline.17:01
replaceafilli also helped dwelsh and glenda this couple of days17:01
replaceafillwith some minor issues17:02
replaceafillth1a, but the biggest surprise for me today17:02
replaceafillwas that i got an email from Cambodia17:02
th1aThat was cryptic.17:02
replaceafillit seems like our contact person there Chandara was in a serious accident :(17:03
th1a"I am so sorry that I kept silent for long time ago. Because my family and I  were knocked unconscious in the accident on the way."17:03
th1a!!! ?17:03
replaceafillit seems like i should start digging through my old branches to look for cambodia :)17:04
replaceafill(if we decide to continue ofc)17:04
replaceafillth1a, i'll finish this last piece (and check the deployed part) and set up an instance to show you to get feedback, ok?17:05
th1aWell, I think I'm going to say we have to start with the 2 branch with them now.17:05
th1areplaceafill: yes, please.17:06
replaceafillth1a, can we meet tomorrow at meeting time?17:06
replaceafilli need to run some errands this afternoon17:06
th1areplaceafill: yes.17:06
* th1a tells Siri.17:06
* replaceafill done17:06
th1aMeeting with Into glass.17:07
th1aSiri understood "quantal update," which I thought was interesting.17:07
th1aThat's where you benefit from centralized voice processing.17:08
th1aI don't think I'm the first person to say that peculiar phrase.17:08
th1aThanks replaceafill.17:08
aelknerok, i got the student journal to work and have stests for it17:08
aelkneri haven't pushed yet, so i can't show you on the demo instance right now17:09
aelknerbut it reports the three tables as we discussed, with absences and tardies sorted by day, period17:09
th1aCan you send a screenshot?17:10
aelknerparticipation averages sorted by term, section17:10
aelkneralso, i uncovered a bug while writing the stest17:10
aelknera good thing, too, that i can get the fix pushed and released17:10
aelknerit has to do with the new importer, SectionTimetables17:11
aelknerit added the schedules to the sections before adding the periods to the schedules17:11
aelknerthis resulted in the section and person calendars not having the events17:11
th1aAh. Tests.17:12
aelknerthe reason i caught it is that i used the imported in my stest17:12
aelknerjournal_security.txt does the setup of everything through the web17:12
aelknerbut that takes SO long that i didn't think we needed to so that every time we write a test17:12
aelkneronce is not bad to have such a stests for ttw timetable setup, but every test done that way is too expensive17:13
aelknerso anyway, it was a good thing i decided to so that since i found the bug17:13
aelknerbtw, can that bug explain what happened with
aelknercomment #217:14
aelkneryvl, what do you think?17:14
th1aWell... it came up when I was doing the screenshots for the book, so in theory those are the steps to reproduce.17:15
yvlit looks suspiciously similar17:15
th1aExcept, I might have stopped and deleted things and started over an unknown number of times.17:16
replaceafillyvl, what's your opinion on aelkner's approach of using imports to set up tests?17:16
replaceafillit's definitely way faster17:16
yvlfeel free to, but keep in mind that some parts are better when written in tests explicitly17:17
aelkneryou should see how long it takes the journal_security.txt test to run just to set up the data17:17
yvlthat might be a case were importing is the preferable option17:17
replaceafillimho it's worth when you use the same setup in several different stests17:18
aelknerright, my point exactly17:18
yvlkeep in mind that is a point of rot17:18
yvlhence +0.517:18
yvl(it's way too easy to just pile into those .xls files)17:19
yvl(and end up writing tests where you need to look at .xls file just to undertand what's going on)17:20
replaceafillyou mean, like start abusing the feature?17:20
replaceafillgot it17:20
yvlbut if you don't abuse it too much - please use the importers at your leisure17:21
replaceafillkk, will do17:21
replaceafillthanks for the feedback17:21
replaceafillthanks aelkner for the idea ;)17:21
yvland thanks for finding the bug17:22
yvlit really looks like th1a also found it ;)17:22
th1aAh, I see.17:23
aelknerso i'm about to send screenshots for all to look at, one sec17:23
replaceafilli forgot to mention17:24
replaceafillthanks to glenda's instance, i found a bug yesterda17:24
replaceafillrelated to one done_link url17:24
replaceafillhere's the fix:17:24
replaceafilli just wanted to mention that we should make sure to use absolute urls on redirects17:25
replaceafillthe old code was producing a done_link=/.../.../17:25
* replaceafill done interrupting :)17:25
aelknernp replaceafill, thanks for addressing that17:26
aelknerwhat was wrong with using PATH_INFO?17:26
aelkneralthough i think you already answered17:26
aelknerwell, maybe not17:27
replaceafillright, we just needed an absolute url (http://...)17:27
replaceafillthat takes virtual hosting into account for example17:27
replaceafillin the old approach, you would get vh++... garbage in the url17:27
replaceafillif the instance is behind apache17:27
aelknerah, i get it, cool17:27
aelknerso formatter.request.url is more reliable17:28
aelknerthan PATH_INFO, that is17:28
replaceafillafaik request doesn't have any other method to get the url?17:28
aelknerthat's why i used PATH_INFO :)17:29
replaceafilli mean, the "current" url17:29
yvlhas .URL17:29
aelknerbut you were right to change it17:29
replaceafillyvl, right, that's what i used17:29
replaceafillbut it's not a method, right?17:29
yvla variable17:29
aelknerso guys, could you please look at the screenshots i sent to the developer list just now?17:30
aelknerthe question i have is in regard to the dates17:30
aelknerstrftime doesn't have a % option for the type of date that i present there17:31
aelknerand i'm guessing that european users may object to the order of month day that i present17:31
aelkneris that true?17:31
replaceafillwhy don't you use the "date" views we have, like @@shortDate?17:32
replaceafillthose use the browser's locale17:32
th1aAlso... I'm feeling like we really do need to do one row per day for absences and tardies.17:32
aelknerth1a, i can make that change, np17:33
aelknerreplaceafill, do you know of a view that uses shortDate off hand?17:33
replaceafillgradebook score history17:33
replaceafillbut you could look at
replaceafilland look for fullDate, mediumDate and shortDate17:34
aelknersure, thanks17:34
aelknerth1a, do you want me to use shortDate like gradebook score history does?17:34
th1aI have not given the matter much thought, but I can't imagine that this view needs special dates.17:35
th1aStadard shortDates should suffice.17:35
replaceafillaelkner schooltool/gradebook/browser/templates/f_student_grade_history.pt17:35
aelknerth1a, cool, replaceafill, thanks17:36
aelknermenesis, i'll create a new bug for the importer problem and mention it in CHANGES.txt17:36
aelknerso i'll make the shortDate fix, change the absences and tardies to have on line per day17:37
aelknerand push the importer fix so that we have that stuff for the release17:38
aelknerth1a, i'll send you updated screenshots after i make the changes17:38
aelknerthat's it for me17:38
th1aOK, thanks aelkner.  Looks like we're on track to wrap everything up pretty well.17:39
th1aShoot for Friday!17:39
th1aHave a good week & weekend.17:40
aelknercan we meet on Friday morning to have a status check?17:40
th1aSame time.17:40
th1aSee you then.17:40
aelknerjust in case we need last minute changes17:40
aelkneryvl, menesis, replaceafill, sorry for making you meet again this week :)17:40
yvlno problem17:41
th1areplaceafill and I have a business meeting then anyhow now.17:41
th1aSo we'll be here regardless.17:41
yvl(it's going to be a short meeting anyway - I hope ;) )17:41
aelkneryes :)17:41
th1aWe'll let you go drink yvl.17:41
th1aOK.  See you Friday.17:41
* th1a drops the bag of gravel.17:41
replaceafillthanks everybody17:41
yvlthanks guys17:41
aelknerthanks guys, cya friday17:42
*** yvl has quit IRC17:43
*** menesis has quit IRC18:52
*** menesis has joined #schooltool18:56
*** menesis has quit IRC20:22
*** menesis has joined #schooltool20:59
*** menesis has quit IRC21:06
*** menesis has joined #schooltool21:06
*** replaceafill has quit IRC21:16
*** replaceafill has joined #schooltool21:21
*** khildin has quit IRC22:16
*** th1a has quit IRC23:03
*** ignas has joined #schooltool23:45

Generated by 2.15.1 by Marius Gedminas - find it at!