| *** th1a has quit IRC | 00:07 | |
| *** replaceafill has quit IRC | 00:47 | |
| *** khildin has quit IRC | 02:26 | |
| *** th1a has joined #schooltool | 04:53 | |
| *** th1a has quit IRC | 09:06 | |
| *** povbot has joined #schooltool | 09:32 | |
| *** menesis has joined #schooltool | 11:55 | |
| *** menesis has quit IRC | 13:46 | |
| *** menesis has joined #schooltool | 14:42 | |
| *** th1a has joined #schooltool | 16:05 | |
| *** replaceafill has joined #schooltool | 16:26 | |
| th1a | hi replaceafill. | 16:30 |
|---|---|---|
| replaceafill | hey th1a | 16:30 |
| th1a | Quick question here then maybe switch to a hangout? | 16:31 |
| replaceafill | ok | 16:31 |
| th1a | So is there something about filldown that bypasses the normal check for invalid scores? | 16:32 |
| replaceafill | not really | 16:33 |
| replaceafill | why? | 16:33 |
| th1a | I don't understand what the issue is with invalid scores. | 16:34 |
| replaceafill | ah | 16:34 |
| replaceafill | ok | 16:34 |
| replaceafill | when you type an invalid score, you get the red background, right? | 16:34 |
| replaceafill | telling you is invalid | 16:35 |
| th1a | Yes. | 16:35 |
| replaceafill | you can then click Save | 16:35 |
| replaceafill | and the red background and <input /> field go away | 16:35 |
| replaceafill | showing the invalid score as a regular <td> element | 16:35 |
| replaceafill | *that* gives you the impression that the invalid value was saved | 16:35 |
| replaceafill | but in reality it was taking from the request only | 16:36 |
| replaceafill | not from the gradebook | 16:36 |
| replaceafill | not from the stored data | 16:36 |
| replaceafill | so, if you refresh the page again | 16:36 |
| replaceafill | (with nothing in the request this time) | 16:36 |
| replaceafill | you'll get the value *from* the gradebook | 16:36 |
| replaceafill | (the previous valid value) | 16:37 |
| th1a | OK. | 16:37 |
| th1a | Yes, that's definitely bad | 16:37 |
| th1a | In the gradebook we store invalid scores, don't we? | 16:37 |
| th1a | I mean it is pretty much a toss up. | 16:37 |
| replaceafill | i think it shouldn't even activate "Save" when there are invalid <input/> | 16:37 |
| th1a | No, it should. | 16:38 |
| replaceafill | no, that's the point, we don't store invalid | 16:38 |
| replaceafill | it seems like we do | 16:38 |
| replaceafill | but we don't | 16:38 |
| replaceafill | you can try it out | 16:38 |
| th1a | What about if we: | 16:38 |
| replaceafill | http://69.164.203.135:6660/schoolyears/2012-2013/MP2/sections/16607-45-4-1/gradebook-skills | 16:38 |
| th1a | I meant in the gradebook gradebook. | 16:38 |
| th1a | I think we might store invalid grades there. | 16:39 |
| replaceafill | hhmm it's the same problem in the gradebook/cando | 16:39 |
| th1a | OK. | 16:39 |
| th1a | So what if we: | 16:39 |
| th1a | 1) pop a js warning "Some invalid scores were not saved." | 16:40 |
| th1a | 2) Show them as red input fields with the invalid scores. | 16:40 |
| th1a | But save the valid ones. | 16:40 |
| replaceafill | +1 | 16:40 |
| replaceafill | should the popup be modal? | 16:41 |
| th1a | Yes. | 16:41 |
| replaceafill | ok | 16:41 |
| replaceafill | i can work on that before moving to projects | 16:41 |
| replaceafill | i was thinking also of adding the warning message | 16:41 |
| th1a | Oh, ok. | 16:41 |
| replaceafill | when you have unsaved scores | 16:41 |
| replaceafill | and want to leave the gradebook | 16:41 |
| th1a | Yes, it is supposed to be there if it isn't. | 16:42 |
| th1a | Can you explain this proxy issue to me? I think making course skills "proxy" global skills was a huge mistake on my part. It was put there to allow rating same (course) skill in several different sections, with changes being shared immediately. But that's not a very useful scenario I guess. | 16:47 |
| th1a | That's quoting yvl. | 16:47 |
| replaceafill | ah yes | 16:47 |
| replaceafill | i think the original use case was: | 16:49 |
| replaceafill | override required/optional | 16:49 |
| replaceafill | at the course level | 16:49 |
| replaceafill | that's the "sharing" part yvl mentions (i think) | 16:49 |
| th1a | I guess I don't understand the difference between copies and proxies in this case. | 16:50 |
| replaceafill | copies at the section level would make them different "requirements" | 16:51 |
| replaceafill | we save requirements in the evaluation | 16:52 |
| replaceafill | and you could find out the section from the evaluation | 16:52 |
| th1a | What is a proxy in comparison? | 16:53 |
| replaceafill | i think this could also give dwelsh the section level skills he wanted at some point | 16:53 |
| replaceafill | the proxy represents the global skill | 16:53 |
| replaceafill | just overriding some of its "original" attributes | 16:54 |
| replaceafill | but if you do some url calculation on it (for example) | 16:54 |
| replaceafill | you'll get pointed to its original container | 16:54 |
| replaceafill | in this case the course skills | 16:54 |
| replaceafill | "it's easy to figure out section and course (since the rated skills would be stored in section itself)" | 16:56 |
| replaceafill | copies | 16:56 |
| th1a | OK... so does this change seem reasonable to you? | 16:57 |
| replaceafill | absolutely | 16:57 |
| th1a | kk. | 16:57 |
| replaceafill | again, gives us skills at the section level | 16:57 |
| th1a | Evolvable? | 16:57 |
| replaceafill | hhmm good question | 16:57 |
| th1a | We have enough info to infer them in the small number of existing cases. | 16:58 |
| th1a | infer the sections. | 16:58 |
| th1a | In evaluations. | 16:58 |
| th1a | I guess that's not the issue though. | 16:58 |
| replaceafill | i think *that* would be the issue | 16:59 |
| replaceafill | assuming someone is already grading multi term skills ;) | 17:00 |
| th1a | We could infer it, it would just be a little hacky, right? | 17:00 |
| replaceafill | i don't see how to tell them apart | 17:01 |
| replaceafill | from the evaluation | 17:01 |
| replaceafill | datetime is not good imho | 17:01 |
| replaceafill | you have (student, skill [global], evaluator, datetime) | 17:01 |
| replaceafill | iirc | 17:01 |
| th1a | If you have the student, evaluator and date, you should be able to guess the section. | 17:02 |
| replaceafill | well... | 17:02 |
| replaceafill | yes, not exactly right, but it could work | 17:03 |
| replaceafill | hacky as you say | 17:03 |
| replaceafill | :) | 17:03 |
| th1a | I think it would work well enough considering that most CanDo users haven't been trained yet. | 17:03 |
| replaceafill | ah yes, and considering they're using single term years | 17:04 |
| replaceafill | i guess you have to use the hacky approach only when you see multiple linked sections | 17:04 |
| th1a | It isn't that hacky since we know for sure that everything should be in the first one. | 17:05 |
| th1a | I mean, it is hacky. | 17:05 |
| th1a | But not complicated. ;-) | 17:05 |
| replaceafill | :D | 17:06 |
| th1a | OK. Give me 10 minutes and then hangout? | 17:06 |
| replaceafill | ok | 17:06 |
| replaceafill | i'll get my stuff | 17:06 |
| *** ignas has joined #schooltool | 17:29 | |
| th1a | replaceafill: Do you want this permissions bug from Glenda or should I give it to someone else. | 18:58 |
| th1a | You've got the biggest pile right now. | 18:58 |
| replaceafill | is it a bug? | 18:58 |
| replaceafill | or should we just use schooltool.view for the options? | 18:59 |
| replaceafill | btw, is the code for other projects (thailand, australia) available somewhere? | 19:00 |
| replaceafill | i'd like to see the "read anything/but not edit" implementation :) | 19:00 |
| th1a | That's an idea, not an implementation. ;-) | 19:01 |
| replaceafill | :| | 19:01 |
| replaceafill | ah ok | 19:01 |
| th1a | We *definitely* should want to move away from using edit to view though. | 19:01 |
| th1a | Because I have a feeling that we'll be trying that change. | 19:01 |
| replaceafill | i think the problem here is that students have access to the worksheet | 19:02 |
| replaceafill | i don't know if the students gradebook helps | 19:02 |
| replaceafill | i think we could use a gradebook_security.txt selenium test for sure | 19:03 |
| replaceafill | for this | 19:03 |
| replaceafill | (if we change the permissions of the options to schooltool.view) | 19:03 |
| replaceafill | i can investigate ;) | 19:03 |
| th1a | Can students see the whole worksheet? | 19:04 |
| th1a | That would be VERY wrong. | 19:04 |
| replaceafill | i don't think so, because it requires schooltool.edit | 19:04 |
| replaceafill | let me check | 19:04 |
| th1a | So what do they see? | 19:04 |
| replaceafill | an adapter | 19:04 |
| replaceafill | studentgradebook | 19:05 |
| th1a | kk | 19:05 |
| th1a | So... | 19:05 |
| replaceafill | testing... | 19:05 |
| th1a | ok | 19:05 |
| replaceafill | ah ok | 19:08 |
| replaceafill | yes, i think we could change the options to schooltool.view | 19:08 |
| replaceafill | i do think a selenium test is worth :) | 19:09 |
| *** ignas has quit IRC | 19:10 | |
| replaceafill | :| | 19:10 |
| replaceafill | glenda is requesting protection by resource | 19:11 |
| th1a | That's not happening. | 19:11 |
| *** ignas has joined #schooltool | 19:11 | |
| replaceafill | th1a, ok, i'll change the permissions of the options then | 19:13 |
| replaceafill | since i'm now working on the gradebook | 19:14 |
| replaceafill | gradebook/cando | 19:14 |
| th1a | OK. | 19:14 |
| *** ignas has quit IRC | 19:50 | |
| *** paulproteus has quit IRC | 20:07 | |
| *** paulproteus has joined #schooltool | 20:11 | |
| th1a | aelkner: ayt? | 21:29 |
| *** khildin has joined #schooltool | 21:47 | |
| *** menesis has left #schooltool | 22:03 | |
| *** menesis_ has joined #schooltool | 22:04 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!