IRC log of #schooltool for Monday, 2012-02-20

*** replaceafill has quit IRC01:44
*** ignas has quit IRC01:56
*** alga has quit IRC03:34
*** aks has joined #schooltool05:15
*** aks has quit IRC05:18
*** aks has joined #schooltool05:18
*** yvl has joined #schooltool09:57
*** ignas has joined #schooltool13:24
*** alga has joined #schooltool14:04
*** aks has quit IRC14:10
*** alga has quit IRC16:11
*** alga has joined #schooltool16:13
*** replaceafill has joined #schooltool16:16
*** th1a has joined #schooltool16:17
th1ahi aelkner_, yvl, replaceafill.16:30
yvlgood morning16:30
replaceafillgood morning/afternoon16:30
th1aCan you guys see this?
th1aSo anyway, I'm wondering what you guys think of the hex grid as a motif.16:34
yvlforgot my password, resetting, waiting for an email16:34
th1aMaybe we could start using that like Ubuntu uses the dot grid (I think that's where Vinny is going with this).16:34
th1aIf anyone has any serious reservations about SVG entering our interface, you'd better speak up.16:36
th1aOK then.16:37
th1aChatty group today.16:38
* replaceafill is reviewing yvl's data uri change... sorry16:39
aelkner_i don't have an opinion about design - i figure someone else knows better than me16:39
th1aAll right, so full speed ahead with SVG.16:42
th1aYou're stuck with it now.16:42
yvlhex grid looks nice btw16:43
* replaceafill doesnt likes the second one better16:44
replaceafillmy english is more broken than usual today :)16:44
replaceafilli like the 2nd one16:44
th1aThe second and third are both fine.16:45
th1aOK, replaceafill, would you like to start us off?16:45
replaceafillah ok16:45
replaceafilllast week i worked on:16:46
replaceafill- photos16:46
* th1a starts Planner...16:46
replaceafillyvl awesome, i didnt know of that attribute in the <image /> element for rml16:46
* replaceafill is referring to yvl's last change on datauri16:46
th1aShould I mark that as complete?16:47
replaceafillth1a, well, yes, now i can try the id pdf we were talking about16:47
replaceafillbut i think the photo work is mostly done16:47
* yvl still misses the round photo borders..16:47
replaceafillyvl, can you comment on that please?16:47
replaceafilli forgot to ask you on friday16:48
yvlit was nice when photos had rounded corners by css16:48
replaceafillbut they did on friday16:48
replaceafilli mean, at the time you looked at the instance16:48
yvlwhen you stored resized thumbnail on a white 3x4 background,16:48
yvlthe rounded corners became invisible on all landscaped photos16:49
yvl(because of white padding top/bottom)16:49
replaceafillbut the round corners were still applied to the white canvas, right?16:49
replaceafillgot you now16:49
yvlbut if the image background is blue...16:49
replaceafillyou liked it better on the actual image16:49
replaceafillthanks now i understand16:50
replaceafillwell, at the end we removed the border16:50
replaceafilli liked the border :)16:50
yvlwell, storing strictly 3x4 photos may be a tiny bit easier when doing RML16:51
replaceafillpredictable ratio i think16:51
replaceafilllast week i also worked on searches16:52
replaceafillfor persons and contacts16:52
replaceafillyvl, there's a part on my last change i'd like to check and maybe improve16:52
replaceafilllet me get the code16:53
replaceafillsuppose you look for:16:54
replaceafillabate kim, alan, jeffrey16:54
replaceafillthe final query should be:16:55
replaceafillabate* kim*, alan*, jeffrey*16:55
replaceafillth1a requested automatic globbing16:55
replaceafillso i did it that way16:55
replaceafilli was about to use map(...) to get fancy, but i decided not to :D16:55
replaceafilland used a list comprenhension instead16:56
replaceafillsince i understand those :P16:56
replaceafillanyway, could you please review/merge those two branches16:56
yvlbtw, did we get rid of "," support?16:57
replaceafillyvl, no16:57
replaceafillit's still there16:57
yvlone minor thing we could maybe add16:57
yvlsupport for "16:57
yvl"kim" would return kim, but not kimberley16:57
th1aI don't think that's a priority.16:58
yvlhence maybe16:58
replaceafillyvl, we get that for free16:58
yvljust thought the search would go well with add all visible16:58
replaceafillit's supported by the index16:58
replaceafilli just tried it:
replaceafillcan you confirm?16:59
yvland "kim, alan" returns no results16:59
* replaceafill remembers reading it in the index rules :)16:59
replaceafillphrase search i think they call it16:59
replaceafilllast thing17:00
replaceafilli also worked on the formviewlet use task17:00
* yvl saw that :)17:00
replaceafilli think it's an OK chance17:00
replaceafillwhat do you think yvl?17:00
replaceafilli mean17:00
replaceafillnot a huuuuge advantage17:00
replaceafillbut at least we get some "date" functionality for the future17:01
replaceafilljust my 2 cents17:01
yvllooked good at a first glance17:01
* yvl marked that to review later17:01
replaceafillcool, can you merge it also after you review it?17:02
* replaceafill remembers he had some other point17:02
replaceafilllet me check my notes17:02
replaceafillah no17:02
replaceafillgradebook template optimization17:02
replaceafilli was confused that my next task was ajaxing the gradebook :(17:03
replaceafillnow i'm wondering what's the meaning of "gradebook template optimization"17:03
yvldon't render all the tds17:03
replaceafilland was thinking if i could steal 30mins-1h of yvl time tomorrow to talk about that17:03
yvldo JSON data17:03
replaceafillso, it *is* kind of ajaxy17:04
yvlwe can even... try a google hangout or something :D17:04
* yvl is itching to try out the camera on his new laptop :D17:04
replaceafillsure, i can do that17:04
replaceafillnever done it before, but i can try17:04
replaceafillyvl, when it's better for you, i mean for us meeting?17:05
replaceafilleither on video or chat17:05
replaceafilli can stay up late17:05
yvlwell, the earlier the better :D17:05
replaceafillmorning time for you17:05
yvllet's talk about the after the meeting17:05
replaceafillah sure17:05
replaceafillth1a, i think that's it for me17:06
th1aOK replaceafill.  We should work on the ID this week.17:07
replaceafillth1a, ah ok17:07
replaceafillyou want it for the april release, yes?17:07
th1aIt is one of the main reasons we have photos!17:08
replaceafilli should start working on it before moving to the gradebook template then17:08
th1aJust check which fields the user asked for in the question.17:08
th1aThanks replaceafill.17:08
replaceafillth1a, will do17:08
th1aaelkner_, I just gave you a bug:
aelkner_ok, i'll look into that this week17:09
th1aOK.  Go ahead aelkner_.17:09
aelkner_ok, so i started using chrome's developer tools this week which look like firebug, but cleaner17:10
aelkner_i figured out why the modal was disappearing and fixed that17:11
aelkner_also, i added a section to our ui overrides css file for modals17:11
aelkner_i had to override some of the styles for the width of form elements to 266px17:11
th1aDid you make some breakpoints?17:11
aelkner_that's because our modal css is set to 300px for the whole modal17:12
th1aWhen you were debugging?17:12
aelkner_sure, wy?17:12
th1aJust checking.  I'm enjoying Javascript breakpoints now.17:13
aelkner_yeah, they come in handy17:13
aelkner_anyway, as i said chrome's version of firebug looks cleaner17:13
aelkner_i have a feeling that google is going to support it better than the mozilla team in the end17:13
aelkner_so i've become a fan of chrome now :)17:14
* replaceafill feels like he's the only in the team that still loves FF :)17:15
aelkner_now, i made one decision to remove an override of fieldset color for modals17:15
th1aFirebug isn't an integral part of Firefox.17:15
aelkner_and it wasn't even being used by any of our modals anyway17:15
aelkner_so, replaceafill, i did in fact check all our modals, and nothing was changed by my css changes17:15
aelkner_but, th1a, you have to deside (again, design, not my area of opinion) whether you like what i did17:16
th1aWell... can I see it?17:16
aelkner_as teacher00117:16
aelkner_besides the fact that there is no scrool bar anymore17:17
aelkner_you'l not that our standard css for labels and hints works17:17
aelkner_and the backround color for the fieldset is there17:17
aelkner_replaceafill, that was done by removing the white style you had created17:17
aelkner_it wasn't being used, so removing it didn't change any other modals17:18
replaceafillaelkner_, you mean the other modals dont have fieldsets?17:18
th1aThe vertical spacing is way too cramped.17:19
replaceafillaelkner_, check the Preferences dialog17:19
th1aIt should look like a regular form.17:19
aelkner_should we change the css for modals to not be 300px?17:19
aelkner_if so, then i can change the form styles to also be wider17:20
th1aThe width looks ok on this.17:20
aelkner_replaceafill, preferences dialog, where is that?17:21
replaceafillhome page for a person17:21
aelkner_ah, didn't know to check that one17:22
aelkner_so should we have a standard modal form width like we have with non-modals?17:23
aelkner_then the grey fieldset would always fit17:23
aelkner_and the filldown wouldn't look so cramped17:24
th1aI'm more worried about vertical space, aelkner_.17:25
aelkner_ok, well, i'm not sure hwat your concern is with that17:25
aelkner_but we do need a standard width in order for css to work17:26
th1aThe text doesn't have the appropriate top and bottom margins.17:26
th1aI don't think we need a gray background on these if that helps.17:26
replaceafillaelkner_, another dialog that uses z3c.form, Make Default view for timetables17:27
th1aWe will probably end up wanting a some narrow and some wide dialogs.17:28
aelkner_that will lead to an interesting set of css rules i guess17:28
aelkner_we would have to decide on a container class17:29
aelkner_then our rules would include that class before the form fieldset part17:29
aelkner_replaceafill, what do you recommend?17:29
replaceafillwhat you just said :)17:30
replaceafillnew class, narrow dialogs use it17:30
th1aI don't think we need a wide dialog yet.17:30
th1aThe person preferences could be narrow.17:31
aelkner_so, 300px is set up as the default width17:31
replaceafilli thought our current ones are wide and the one aelkner did was the narrow one :)17:31
aelkner_i didn't do anything to narrow it, it ust used the rule17:31
aelkner_.ui-dialog { position: absolute; padding: .2em; width: 300px; overflow: hidden; }17:31
th1aThe fill down would be an example of the narrow one.17:31
replaceafillth1a, correct17:32
th1aBut that's wide enough for all the ones we have, right?17:32
replaceafilli think so17:32
aelkner_the preferences is a lot wider17:32
aelkner_but having the grey backround, you can see what it would look like if we narrowed it17:33
th1aIt should be fine.17:33
th1aGet rid of the gray background in the dialogs though.17:33
replaceafillaelkner_, -1 on that17:33
replaceafillnotice the title bar17:33
replaceafillchange preferences for ${person}17:34
th1aJust make the title bar simpler.17:34
th1aActually, it should be smaller anyhow.17:34
th1aIt is too chunky.17:34
th1aProbably replaceafill and I should just go over this.17:35
aelkner_i like the sound of that17:35
aelkner_though it was interesting to get involved with the css17:35
th1aOK, so we'll finish it.17:35
aelkner_ok, also, i changed the menu item to Fill down17:36
aelkner_and i made it not change existing scores and change the color of scores that have changed17:36
aelkner_as you asked last meeting17:36
th1aYou know, we don't have a "cancel" button on the gradebook.17:37
aelkner_ah, yes, i saw in chrome's debugger that the check for changed scores runs17:37
aelkner_but it doesn't do anything17:37
aelkner_saveFlag = window.confirm(warningText);17:37
aelkner_in firefox, that causes the confirm window to render17:38
aelkner_in chrome, nothing17:38
aelkner_so that explains why chrome doesn't ask for the confirm17:38
aelkner_i don't know what the solution to that is, but i just wanted to mention what i fond so far17:38
aelkner_perhaps there is a better javascript call to make than window.confirm17:39
aelkner_Chrome users (e.g. extensions) should use methods of nsIPromptService instead.17:42
th1aYes, Google's advice here is very vague.17:42
th1aOK, so what's the status of course report sheet permissions?17:43
aelkner_ok, so i fixed the Deploy as Course Worksheet link to not render17:44
aelkner_if a) there are no courses17:44
aelkner_or b) any of the courses is not lead by the teacher17:44
aelkner_i'm not sure if b) was the right decision17:45
yvlaelkner_, btw:
th1aNone of the courses or any?17:45
aelkner_is that better?17:45
aelkner_i could so that17:45
aelkner_so i can change that before merging into trunk17:45
th1aIf the teacher is leader of any of the courses they should be able to deploy to the course they lead.17:46
aelkner_but for now, check out how it works with the three different scenarios17:46
aelkner_no course, one course, multiple courses17:46
th1aDo we have an example?17:46
aelkner_all three scenarios are accesible by changing the section17:47
aelkner_so you can suggest any text changes for the case where the Courses part comes up in the deploy view17:47
th1aOK.  We need to change all the text.17:47
th1aI'll send you an email about that.17:48
aelkner_you see how it doesn't even come up in the single course scenario?17:48
aelkner_if there is only one course to deploy to, no need to ask, right?17:48
th1aI get a traceback if I select no courses.17:48
th1aaelkner_, If you ask me to write you a recommendation for a QA job, I won't do it.17:49
aelkner_i woudln't ask for that :)17:49
aelkner_that's why there are QA departments17:49
th1aNot on this project.17:50
aelkner_anyway, i'll fix that to do nothing instead of crashing17:50
th1aCan it be treated as a required field?17:50
aelkner_i could apply the same error text that i do for the other fields17:51
th1aDo we need to discuss what the actual permissions are supposed to be?17:51
th1aOr are you ok with that?17:51
th1aAlso, yvl, is there anything we need to do to make this actually show up in the permissions overview view?17:52
yvlwell, it depends :)17:52
yvllet's say, yes17:53
aelkner_permissions overview view, what is that?17:54
aelkner_are we talking about the security view that we had in the old skin?17:55
replaceafillServer -> Security17:55
yvlin the new skin, it's Server->Security17:55
yvldamn, replaceafill beat me to it17:55
yvland th1a :/17:55
* th1a can't remember the names of views.17:55
yvlprobably what you'll need is just add describe_action entry17:56
yvllike in most security.zcml files17:56
yvlprobably schooltool/course/security.zcml is as good a reference as any17:57
replaceafillsecurity descriptions feature17:57
yvlbut really it depends on what you do with permissions17:58
aelkner_so, in the gradebook package, where the feature is defined, we need a new security description defined17:58
yvlthere are plenty of examples, when you implement the security thing, I can point to them17:58
aelkner_is that right?17:58
* yvl shrugs17:59
* yvl does not know what you're trying to accomplish17:59
aelkner_i think th1a wants the 'Can deploy worksheet' permission to be defined17:59
aelkner_the answer to who can is "course leader"18:00
yvland administration?18:00
yvlso basically, same as edit permissions for course?18:00
th1aI mean, the point is that in reviewing aelkner's work, I should be able to confirm it looking at the permissions overview.18:00
th1aIn addition to actually testing it.18:01
th1aYes, it is the same.18:01
aelkner_adding a security description doesn't change the way the app works18:01
aelkner_it just changes the output of the security settings view18:01
th1aSo I guess in that sense maybe it doesn't deserve a separate description?18:01
yvlit's up to you really18:02
aelkner_that's what i figured, but that's just my opinion18:02
th1aEven if it is the same as regular edit I'd like it to have a separate description.18:02
yvlif "modify" a course is descriptive enough, then it's ok18:02
yvlyou can :)18:02
aelkner_i can add it18:02
yvlthanks aelkner_18:02
yvljust copy the line from course/security.zcml18:02
yvlthe one that describes modify for ICourse18:03
yvlmeaning you have schooltool.edit18:03
aelkner_th1a, can you add the text for that description to our email please18:03
yvland put it in gradebook's security.zcml somewhere18:03
aelkner_will do, yvl, thanks18:03
replaceafillthe gradebook already has a security.zcml18:03
aelkner_that was easy :)18:04
th1aOK, what about section locations?18:04
* yvl tried to be flexible with security descriptions - for situations like this18:04
th1a(these meetings may get longer now that I have a gantt chart....)18:04
yvl"Even if it is the same as regular edit I'd like it to have a separate description." :)18:04
replaceafillth1a, :D18:04
aelkner_haven't started section locations yet, but i will as soon as i finish and merge the course worksheets changes18:04
aelkner_but that's it for me18:05
th1aThanks aelkner_.18:05
th1aSo replaceafill, we need to meet about the dialog CSS.  Later today?18:05
th1aSay, three hours from now? 4?18:06
replaceafill4 better18:06
th1aOK, so 3:00 my time.18:06
th1aAll right, yvl, sorry to keep you waiting.18:06
yvlthat's ok18:06
* yvl done first 3 items from the project with the gantt chart18:07
yvlnow doing 4th :D18:07
yvlthat's some bugfixes + add all18:08
yvlso that's that.18:09
replaceafillyvl, question about your last mail18:09
th1aIs Ajax batching 4th?18:09
replaceafillthe one with <image .../> in rml18:09
replaceafilli see imageName available for <imageAndFlowables .../>18:09
replaceafillin the rml reference18:10
replaceafillbut not for <image .../>18:10
replaceafillanyway, i can try it out, just was wondering18:10
yvlyes, th1a, 4th18:10
th1aOK.  Cool.18:11
yvlwell, yes, use imageAndFlowables18:11
yvlimage has something else I think18:11
replaceafillah ok18:11
yvlbut you can put the data in place of any name18:11
yvl(for images)18:11
replaceafillcool, i'll work on that today18:12
th1aOK, so everyone set?18:13
* yvl yes18:14
* replaceafill is18:14
th1aOK.  Thanks guys.18:14
aelkner_th1a, if i have any question on section linking i'll lauchpad you18:14
th1aTalk to you Wednesday.18:14
th1aaelkner_:  OK.18:15
aelkner_cya guys wed18:15
* th1a drops the bag of gravel.18:15
replaceafillthanks everybody18:15
yvlthanks guys18:15
yvlreplaceafill, I'll be here a bit late tomorrow18:15
yvl2AM your time18:15
replaceafillah ok18:16
yvlor we can chat later18:16
yvl8AM your time18:17
yvlor 8:30 :)18:17
replaceafilli can get up early, 5AM?18:17
replaceafillwhat's 5am my time in lithuania? :)18:17
yvlis it 10AM now?18:17
replaceafill8 hours, right?18:17
replaceafill5 am + 8 hours....18:17
* yvl would like to leave before...18:17
yvl10AM your time18:17
yvlso you we can meet at 8-9 AM18:17
yvlyour choice :)18:17
* yvl will be around18:17
replaceafill8:30 AM :)18:18
replaceafillmeeting time18:18
yvlok! :)18:18
replaceafilli mean, regular meeting time :)18:18
replaceafillthanks yvl18:18
replaceafilldo you have skype?18:18
replaceafillin case we use video18:18
yvlumm, not installed yet18:19
replaceafillah ok18:19
* yvl wants to try google hangout18:19
* replaceafill has to investigate about that :)18:19
yvlbecause it should support multiple videos18:19
yvland has an awesome welcome message :D18:19
replaceafillok, i'll look into that18:19
yvl"Check your hair and make sure your mic works!"18:20
yvlsee you tomorrow!18:20
replaceafillsee you yvl18:20
yvland please mail me any branches/questions/stuff ;)18:21
yvlif any :)18:21
replaceafillwill do18:21
*** ignas has quit IRC18:42
*** th1a has quit IRC19:44
*** th1a has joined #schooltool19:55
replaceafillwhat about that design?21:51
th1aUh... bars?21:51
replaceafillnot necessarily21:51
th1aJust make it look like a Canonical ID.21:51
* replaceafill looks a Canonical ID....21:51
th1aOr, what a Canonical ID might look like.21:52
replaceafillah, i thought you had seen one on the design page21:53
* th1a goes to get some coffee.21:57
th1aWhat should we look at replaceafill?22:01
replaceafillwe're talking dialog css, correct?22:02
replaceafilllet me set the latest trunk on the vps22:02
th1aOK, so shrink that header down to be closer to just a regular window header in Ubuntu.22:07
replaceafillaelkner_, you there?22:11
replaceafillmy connection is slower than usual :(22:15
replaceafillth1a refresh22:15
replaceafillthe titlebar is the same height as a regular ubuntu title bar22:16
th1aThere is a black border around it?22:16
th1aTake out the border.22:16
replaceafillth1a, border gone22:19
th1aI like that better.22:19
th1aOK, get rid of the gray background.22:20
th1aMake this a modal dialog.22:24
replaceafillsorry if i'm taking more time than usual to make the changes but reloading any page is taking forever22:24
th1aI kind of feel like this might need a light gray background, but let's see it as a modal first.22:25
replaceafillth1a, reload22:31
replaceafillset resizable=false too22:31
replaceafilli don't like that bottom right corner :)22:31
th1aI think white is fine.22:31
th1aCan you standardize the vertical spacing?22:31
replaceafillyou want it to look like
replaceafillbut with white background, correct22:33
replaceafilli mean, vertical-space-wise22:33
replaceafilland font sizes too22:34
replaceafillcan we make it wider?22:34
replaceafillor maybe make the hint shorter22:35
replaceafilltaking out "Choose" maybe22:35
th1aAll that text is going out the window.22:35
replaceafillyou mean we're going to remove the label and hit?22:36
th1aThe label will be the title of the activity and the hint will be its description.22:36
replaceafilli was thinking of putting the label in the title bar ;)22:37
replaceafillbut ok22:37
replaceafillanyway, let me apply the same style of the regular form fields22:37
replaceafillthat took time :D22:51
replaceafillth1a, reload22:51
th1aThis might be better as a non-modal dialog since then you can see the gradebook, what's already been scored, etc.22:54
th1aAnd it doesn't cause a page reload, right?22:54
th1aEh... Switch it back to regular.22:54
replaceafilldid you imply that a modal causes a page reload?22:56
replaceafillbecause it doesnt22:56
th1aNo... I just wasn't sure if there was some case lurking there where you'd call up the modal, make some changes to the gradebook itself, then trigger the dialog and get something out of sync.22:57
th1aWe should still try to break it.22:57
replaceafillQA :)22:58
replaceafillit would be nice if we could move the dialog just below the column header ;)22:59
replaceafillwith a little ^ like those google uses :D22:59
replaceafillin maps.google22:59
* replaceafill writes it down for version 3 ;)23:00
replaceafillthat field in the dialog should also use the background logic of the cells23:06
replaceafillso you dont fill the cell with -8.223:06
replaceafillok, now? change label for activity title?23:08
replaceafilland hint for description?23:08
th1aYou can make the dialog title "Fill down empty cells"23:10
th1aOr something... that one is trucky.23:11
*** th1a has quit IRC23:14
*** th1a has joined #schooltool23:15
th1aMaybe just "Fill in empty cells"23:20
th1aI'm going to have to go start supper.23:21
replaceafillah ok23:21
replaceafillim changing the labels and hints23:21
replaceafillit needs js23:21
th1aI think that's the last thing.23:21
replaceafillbecause the dialog is unique23:21
replaceafillbut maybe i should do this locally23:22
replaceafillmy connection is getting ridiculous23:22
th1aOK, I'm going to cook.23:23
th1aThanks replaceafill.23:23
replaceafillsee u th1a23:23
replaceafillth1a, refresh23:34
replaceafillwe don't use the description of the activity anywhere in that view23:34
replaceafillfor now i'd have to insert it hidden and use it only in the dialog23:35
replaceafillth1a, done23:46
replaceafilltitles for labels, descriptions for hints (if they exist)23:46

Generated by 2.15.1 by Marius Gedminas - find it at!