IRC log of #schooltool for Monday, 2011-11-07

*** aks has joined #schooltool05:16
*** aks has joined #schooltool05:16
*** yvl has joined #schooltool10:08
*** aks has quit IRC11:03
*** menesis has joined #schooltool12:05
*** jelkner has joined #schooltool14:47
*** replaceafill has joined #schooltool15:02
jelknerreplaceafill, good morning! th1a, are you all meeting this morning?15:03
replaceafillgood morning jelkner15:03
jelkneri was looking for a good time to talk about gradebook reports15:04
jelknerand ask a question about the teacher view of the gradebook15:04
jelknerreplaceafill, are you all meeting this morning?15:05
replaceafilljelkner, yes15:05
jelknerit is end of quarter for me, and my supervisor has asked me to print "progress reports" for students in one of my sections.15:05
jelknerI'm wondering if there is an easy way to do that?15:06
jelknerI don't see anything on the Gradebook view.15:06
jelkneror the section view15:07
replaceafillis it me or the person view is broken....?15:23
replaceafillah never mind15:25
replaceafilljelkner, i see gradebook reports registered for persons and groups15:26
jelknerreplaceafill, where?15:27
replaceafilljelkner, log in as manager, go to a student, and you'll see the Reports15:42
*** povbot has joined #schooltool16:12
*** yvl has quit IRC16:13
*** th1a has quit IRC16:13
*** aelkner_ has quit IRC16:14
*** yvl has joined #schooltool16:14
*** th1a has joined #schooltool16:17
jelknerth1a, bugs filed16:21
jelknerdo the look ok?16:21
jelknerreplaceafill, ahh, you need to be manager16:21
jelknerlet me look...16:21
*** Lumiere has joined #schooltool16:22
th1aOh, if you have to be manager that's a bug.16:23
*** aelkner_ has joined #schooltool16:27
th1ahi aelkner_, replaceafill, menesis, yvl.16:31
replaceafillgood morning/afternoon16:31
th1aThe goal for the week is getting everyone turning bugs over in anticipation of the release.16:32
th1amenesis:  Thanks for the new release last week and the announcement.16:32
yvlgood morning16:33
th1aI need October invoices.16:33
menesiswas overdue, sorry16:33
th1amenesis:  You can go first today.16:33
menesisth1a: don't know should I have posted this to users mailing list16:33
th1aOh, I thought you did.16:33
th1aYes.  ;-)16:33
menesisthe announcement16:34
menesisI posted to both16:34
th1aOh, right, yes.16:34
menesisI haven't added this to launchpad16:34
th1aThat's what I wanted.16:34
th1aI'll do that now.16:34
menesisI have made gradebook and schooltool releases late Friday16:35
menesisall four now available in ppa:schooltool-owners/dev16:36
menesislooked at what is needed to make flourish available there for lucid, too16:36
menesisbut a handful of zope packages need to be updated16:37
menesisand there is a build system mismatch (there is no dh_python2). but a backport is easy16:38
menesisthen I have updated the release notes16:38
menesisin the book16:38
menesisreordered them by date (was grouped by project) to have the latest updates on top16:39
menesisalso reordered the release notes page16:39
menesisso that clicking 'previous' would show you a previous release16:40
menesisupdated a few more pages that caught my eye16:40
menesisthen I looked at
menesisthe docs generated from source16:40
menesisnot automatically, and they were not updated16:41
menesisI glanced over the pages, fixed obvious formatting issues16:41
menesisremoved a couple obsolete texts16:41
menesisI have created a blueprint for 2.016:42
th1aIt would be nice to get that merged into the rest of the documentation (or at least linked) but it isn't a priority immediately.16:42
menesisit's whiteboard could be used to mark tasks as TODO or DONE16:43
menesismore importantly, the url of that blueprint is a wiki page16:43
menesisto have a place for an overview what needs to be done in Ubuntu16:44
menesisadded a Branding section there16:45
menesiswith placeholders for the new artwork examples16:45
menesisth1a: can we add the latest official logos and banners there?16:46
th1aSure.  They're on the Basecamp site.16:46
menesisbecause if we are to restyle the book, documentation, website, we need a place for reference artwork and colors16:47
menesisbasecamp is not public16:47
th1aWell, yes menesis, but replaceafill and I know what is going on.16:47
th1aThis isn't really your problem.16:47
menesisbut I will have to change branding on launchpad16:48
th1aWe just have to switch logos.16:48
menesisand use the same colors in developer pages or something16:49
menesisok, where do I take those logos from?16:49
th1aI'll get that to y ou menesis.16:49
th1aAnything else?16:49
menesisthat is all16:50
th1aThanks menesis.16:50
yvlI've been fixing functional tests mostly16:51
th1a(btw, replaceafill, did we swap in the new transparent favicon?)16:51
yvlthere were actually few regressions that tests correctly caught16:51
yvlso had to fix those also16:51
yvlI guess there's a reason we have tests :)16:52
yvlI also implemented a security policy cache16:52
th1amenesis: for the whole thread.16:57
th1ayvl:  I thought tests were just there to break whenever we changed anything.16:57
th1aA little "You changed something!" flag.16:57
th1amenesis:  Also, colors.css is pretty much the documentation of the colors.16:57
th1aDoes the security policy cache speed up gradebook?16:57
*** replaceafill_ has joined #schooltool16:57
replaceafill_sorry, got disconnected16:57
*** replaceafill has quit IRC16:57
yvlit should speed up the app in many places16:57
yvl(note the app is still slow when ZODB cache is cold)16:57
yvland I added a security debug view when devmode is on16:57
yvlinstead of redirecting to log-in screen16:57
yvlit displays the recent security checks16:57
yvlfailed checks are red16:57
yvllast red check is almost always the cause of redirect16:57
yvlso status of ftests... 5/22 fixed16:57
yvl+3 will be fixed quite soon16:57
yvlthat's that16:57
*** replaceafill_ is now known as replaceafill16:57
th1aOh God thanks for the security debug view.16:58
th1aFor some reason I thought that was impossible.16:58
aelkner_th1a, are you looking at it now?16:58
yvlth1a, we changed *a lot*16:59
yvland never updated the tests16:59
yvlnever = this summer16:59
th1aaelkner_, no.16:59
aelkner_oh, ok, because i didn't see a link for it16:59
th1ayvl:  Yes, I know.16:59
yvlas for speeding up the gradebook...17:00
yvla little extra bit, yes17:00
yvlbut first look after server restart is still slow17:00
yvlgradebook and journal main views mostly hang on template rendering now17:01
th1aWhat's on your plate now?17:05
yvlfix 17/22 functional tests17:06
yvland then XLS/CSV reimport17:06
th1aShould I give someone else "Saving attendance does not work?"17:07
yvlI tought I fixed that17:07
menesisI thought, too.17:07
menesisbut it does not work17:08
th1aYes, menesis booted it back.17:08
yvlnot committed :)17:08
yvlthanks menesis17:09
menesisalso journal security is now too strict. student and administrator cannot view it17:10
replaceafilladministrator can't?17:10
replaceafilli'm as admin and i can see it17:11
replaceafillthere's no "easy" way to get there though17:11
menesisalso true17:11
replaceafilli asked th1a to set a Journal link in the section view on friday17:11
replaceafilland he said yes17:11
menesisneeds a link from section like Gradebook gained17:11
th1aWe all agree.17:12
replaceafillone thing i noticed is that the Journal link on calendar boxes should be smarter17:12
replaceafillbecause it points to the section journal17:12
replaceafilland i "think" students can see the link17:12
replaceafillso now, they would get a log in screen17:12
replaceafilli'll file both as bugs17:14
th1aWe can deal with longstanding calendar bugs next cycle.17:15
th1aBut yes, file a bug.17:16
th1aAnything else yvl?17:16
yvlno, that's it17:16
th1aOK, thanks yvl.17:16
replaceafilli reported a bug related to css work:
replaceafillplease comment/updated as you wish17:17
replaceafillwe already styled gradebook popups, with th1a17:18
replaceafillyou can see them:
replaceafillalso, one thing that was annoying for me, was that small sample data made 2010-2011 the active year17:18
replaceafillso i changed both (small and large) to make the 2011-2012 year, the active one17:19
replaceafillanother thing that was bothering me, was that the small sample data had no consecutive usernames17:19
replaceafillso i fixed that17:19
replaceafillnow we have student000-student46517:20
replaceafilland teacher000-teacher005 (i think)17:20
replaceafilllast week i also played with the new book style:17:20
th1aDid you commit that?17:20
replaceafillth1a, not yet17:21
replaceafilli dont like one thing in vinnys design17:21
replaceafillsee the title on that page?17:21
replaceafillThe SchoolTool Book17:21
replaceafillthose titles are being absolute positioned17:21
replaceafillwell, it's not vinnys design actually17:22
replaceafillit's my css :D17:22
replaceafillthat needs to be smarter17:22
th1aHow is it different than the titles in the app itself?17:22
replaceafillthe html17:22
replaceafillin the app we have a section for the title17:22
replaceafillin the book, the title is coming from a container inside the content17:22
replaceafillso i have to drag it up17:23
th1aDo you want to just put it in the content area?17:23
replaceafillth1a, that would be a lot easier17:23
replaceafillbut never mind17:23
th1aSeems like it would be ok to me.17:23
replaceafilli think i can do it "right" :)17:23
replaceafillanyway, i set the secondary navbar to use sphix "breadcrumbs"17:24
replaceafillthe search box17:24
replaceafilland adjusted the footer a little17:24
replaceafilli need to insert the "see source" link17:24
replaceafilli have one question for yvl, as usual17:25
yvlgo ahead :)17:25
replaceafillyvl, is it possible to get a dialog on page load?17:25
replaceafilli see that js code in flourish.js depends on links being clicked, correct?17:25
replaceafillor at least, being links17:25
replaceafillbecause it uses the href attr17:25
yvlhmm, I already forgot how that works :D17:26
yvlbut yes, it should be possible17:26
yvllemme look17:26
replaceafilli'd appreciate if you could give me an idea17:26
replaceafillwhat i want is:17:26
replaceafillto redirect the user to a dialog after he changes his password17:26
replaceafillthe dialog would have an OK button17:27
replaceafillwhen you click it, you get a redirect to the login form17:27
replaceafillas th1a said in the bug, i think the dialog would make things clearer17:27
menesisI don't like that after changing password you are left at the same page with nowhere to go17:28
replaceafillmenesis, correct17:28
replaceafillthat's why the dialog would work better17:28
menesisand why would you be logged out after password change?17:28
replaceafillmenesis, session credentials?17:29
yvlI'd rather look if it's easy to fix this one17:29
menesispassword in session credentials?17:29
yvlas for showing modal dialog, it's possible replaceafill17:29
yvlI just made modal_form_dialog private for some reason :)17:30
replaceafilli noticed17:30
replaceafillshould we make it public?17:30
yvlcould you rather.... implement something like open_modal_link?17:31
yvlthat builds the container div if it's not there?17:32
yvland accepts an optional dialog_container_id?17:32
replaceafillview_url, container_id, title?17:33
replaceafilli can ask that later17:34
yvlmaybe view_url, title, container_id... maybe not :)17:34
replaceafillso we can move on17:34
replaceafillth1a, i think that's it from me17:34
th1aThanks replaceafill.17:34
aelkner_ok, so i got the hide/unhide report sheets view to work17:34
aelkner_then i coded a evolution script to get the deployment keys to conform to the new pattern17:35
aelkner_i had to make one difficult decision on that, related to the decision i had to make with the keys last week17:35
aelkner_i had to make one deployment row for each year/term pair, even if the whole year was deployed at once17:36
aelkner_that is because, with the old way of deploying, there was no way to match up deployment keys to actions17:36
aelkner_so, keeping that in mind, and remembering the playing around that you did on the demo server17:37
aelkner_where you kept redeploying the same template to see how messed up it would get17:37
aelkner_here's the result of the evolution:17:37
aelkner_also, not that i fixed the permission to not let you see if not mamager user17:37
aelkner_note that i17:37
aelkner_not, not that i :)17:38
th1aIn the future you won't be able to deploy report sheets with duplicate names, right?17:38
aelkner_i couldn't fix the titles to be different17:38
aelkner_that's right17:38
aelkner_you can try right now and see17:38
th1aDo they all hiave different keys?17:38
th1aMaybe that should be in the hide/unhide table.17:39
aelkner_the key?17:39
th1aSo there is SOME way to differentiate.17:39
th1aYou could truncate the beginning to make it fit.17:39
th1aSince the differences will generally be in the end, right?17:39
aelkner_you mean, don't show year_term_index, just the index?17:40
th1aJust make it the last 20 characters or something.17:40
aelkner_why not the index only, that's the key part that links the deployment action17:41
th1aOK, whatever.17:41
aelkner_just in the hide/unhide view or in the main view, too?17:41
th1aI think just hide/unhide.17:42
aelkner_first col, entitled Index?17:43
th1aThis is kind of an edge case.17:43
menesiswhy is it allowed to deploy the same template to the same term again?17:43
aelkner_menesis, i saw your comment in the bug report17:43
aelkner_we decided to not stop the user from doing that if they wanted17:43
aelkner_they can always hide it now17:43
th1aWe're also going to let the user set the title.17:44
th1aWe still have to add that, right, aelkner_?17:44
aelkner_yes, that's right, and also, i need to write the tests for the evolution17:44
menesisok so this is by design17:44
menesisnow that they can be hidden it is better17:44
aelkner_remind me, if the user picks a title that is already there, we add the -2, right?17:45
aelkner_ok, one more thing17:45
th1aThe titles have to be unique (enforced by the view).17:45
aelkner_click on the other year tab, see how it says, no sheets deployed?17:45
aelkner_now click the hide/unhode17:46
aelkner_i'm just wondering if that link should even be available in the case where there is nothing deployed17:46
th1aIt should not.17:47
aelkner_ok, i'll code the viewlet to not render in that case17:47
aelkner_that's it for me17:47
th1aWhat do you guys think of putting the form above the table (instead of how it is now)?17:47
menesisI think it is ok17:50
aelkner_that way it is?17:50
th1aWe generally have forms over tables.17:50
menesisthere won't be that much report sheets as in this demo17:50
aelkner_i agree17:50
th1aOK then.17:51
menesiswill teachers be able to hide a report sheet?17:51
replaceafillone thing i dont like is the Cancel instead of Done17:51
th1aIn conclusion:
menesisnow they can't17:51
aelkner_btw, what example do we even have of a form over a table?17:51
th1amenesis:  Absolutely not.17:51
th1aaelkner_:  Well search forms.17:52
th1aI'm not making a strong argument here aelkner_.17:52
aelkner_that's ok, i just couldn't think of an example17:52
aelkner_replaceafill, the Cancel is there because of the Submit17:52
th1aThe Done would be under the table.17:52
aelkner_Done is for when we don't have a form usually, isn't that correct?17:52
replaceafillto me it feels weird17:53
th1aEsp. if the table was below the form.17:53
aelkner_ok, replaceafill makes a good case for moving the form to the top17:53
aelkner_and putting Done at the bottom17:53
aelkner_Submit under the form, no Cancel17:54
aelkner_Done under the table17:54
aelkner_this is for the /report_sheets view, not the hide/unhide17:54
aelkner_isn't that what you mean, replaceafill?17:54
aelkner_there only one thing, replaceafill17:55
aelkner_i can't think of a case where the Submit button changes data when we have Done17:55
aelkner_that means, the user could change stuff on the form, hit Done, and assume the action took place17:55
th1aOh, good point.17:56
th1aYes, lets not do that.17:56
aelkner_Cancel is different from the user's point of view than Done17:56
th1aJust keep it as is for now.17:56
aelkner_right, ok, so no change17:56
aelkner_i'll just add the Title17:56
aelkner_ok, i'm done again17:56
th1aOK.  Thanks guys.17:56
th1aLet's keep cranking through bugs!17:56
* th1a drops the bag of gravel.17:56
replaceafillthanks everybody17:57
aelkner_cya all Wednesday17:57
yvlthanks guys17:57
yvlsee you soon :)17:57
*** menesis has quit IRC19:32
*** jelkner has quit IRC19:48
*** replaceafill has quit IRC23:18
*** jelkner has joined #schooltool23:21
jelknerth1a, are you here?23:21
jelkneri think i may have found a bug23:21
jelknerbut i was hoping for help confirming it23:21
jelkneri had a student in my javascript class23:22
jelknerhe is in the after school section, but i hadn't finished copying and pasting the competencies into that section yet23:22
jelknerso i put in temporarily in the other section23:22
jelknerso he could view the skills on which he would be evaluated23:22
jelknerwhen i moved him back into his real section23:23
jelknerhe can't view the gradebook any more23:23

Generated by 2.15.1 by Marius Gedminas - find it at!