IRC log of #schooltool for Thursday, 2011-07-21

*** menesis has joined #schooltool00:02
*** replaceafill has joined #schooltool00:21
*** menesis has quit IRC00:45
*** fsufitch has quit IRC00:59
*** issyl0_ has joined #schooltool01:10
*** issyl0_ is now known as Guest6880401:11
*** issyl0 has quit IRC01:13
*** th1a_ has joined #schooltool01:50
*** th1a has quit IRC01:54
*** ignas has joined #schooltool02:09
*** replaceafill has quit IRC02:31
*** ignas has quit IRC02:44
*** fsufitch has joined #schooltool03:05
*** replaceafill has joined #schooltool03:49
aelknerreplaceafill, hey03:51
replaceafillhey aelkner03:51
aelknercan you look at something with me a second?03:52
aelknerok, i'm about to push, one sec03:53
aelknerok, everything is pushed all the way to trunk03:55
replaceafillk, pulling03:55
aelknerso if you look at, i only changed the cloned template to get the legend set up03:55
aelknerand add an extra <p> markup for spacing03:55
aelknerbut you'll notice that there are a lot of classes set up for old skin css03:56
aelknerand removing them doesn't seem to matter anyway03:56
aelkneri guess because they are not in the flourish skin03:56
replaceafillyou can safely remove them03:56
replaceafillin fact, we should remove classes we dont use03:57
replaceafillso, is anything wrong with the template?03:57
aelknercan you try adding a term until you get to the refresh screen03:57
replaceafillah, ok03:57
aelknernothing that i have an opinion on, but i thought you wold be able to anticipate what tom03:57
aelknerwould want to have changed03:57
aelknerlet me know when you have the screen loaded03:58
replaceafilldo terms have the 12 chars constraint for titles?03:58
aelkneroh, and make sure that the term is multi-month03:58
aelknernot that i know03:58
replaceafilli thought th1a asked for it03:58
replaceafill(but maybe i'm wrong)03:58
aelknerthere is a table for each month03:59
replaceafillok, adding a term03:59
aelknerit doesn't look so bad, but i thought you would have some thoughts03:59
aelknerthe buttons have to be buttons because the form has to stay up04:00
aelknerit's like a wizard, a multi-step form04:00
aelkneri'm referring to Monday, Tuesday, btw when i refer to the buttons04:01
replaceafillyou could set classes on them04:01
replaceafilllike button-ok|neutral04:02
replaceafillif you do that, make sure you also set a class on the parent element containing the buttons04:02
replaceafillthe <p>04:02
replaceafillshould be <p class="buttons">04:02
replaceafilland the buttons like <input type="submit" class="button-ok" ...>04:03
replaceafillthat would matter when we have the final palette04:03
replaceafilli think the fieldset legend should be shorter04:04
replaceafillbut not a big deal04:05
aelkneryeah, i'll let tom come up wth that one04:05
replaceafillyou know, you should leave the old css classes in this template04:05
aelknerhow did you get your buttons to come out that way04:05
aelknerwhat did you change?04:06
replaceafillhhmm nothing04:06
replaceafillwhat do you mean "that way"?04:06
aelknerMonday, etc. is dark grey for me, your screenshot has them light-grey, aolmost white04:07
replaceafillthey dont have a flourish css class, so it's defined by the browser04:07
replaceafillthey have class="button"04:08
replaceafilland we dont have a style for that04:08
aelknerwhat bowser are you using?04:09
replaceafillff 3.504:09
replaceafillbut in any case, i think those buttons need flourish css classes04:09
aelkneryes, i should add those04:10
aelkneralso, how should i add the old css classes?04:10
aelkneri can copy them from the old skin, but wereto?04:10
replaceafillold css classes?04:10
aelkner<replaceafill> you know, you should leave the old css classes in this template04:10
replaceafillah yes04:11
replaceafilli meant, dont remove them04:11
replaceafilli'll need them04:11
aelknerok, you'll handle adding the css to the new skin to style them04:11
aelknercool, thanks04:12
replaceafillone comment though04:12
replaceafillhold on, let me check something04:12
replaceafillah yes04:13
replaceafillyou know, the old view04:13
replaceafilluses javascript to mark the holidays04:13
replaceafillyou just click on the day04:13
replaceafillthe checkboxes are backup for not having js04:13
replaceafillyou should ask th1a if he wants to keep that04:14
replaceafilli mean, it's nice being able to click the whole square to enable/disable the day04:15
replaceafilljust nitpicking i guess :)04:15
aelknernot really, all good points04:16
replaceafillthat's all i have, good work on this view04:17
replaceafillwill be fun to style :/04:17
replaceafilllots of parts :)04:17
aelknercool, thanks for you help04:19
replaceafillhhmm interesting04:20
replaceafillsuppose i have a year from jan 1 to dec 3104:21
replaceafillah no, never mind04:21
replaceafillwhat i'm thinking it's not possible04:21
aelkneri added back the js that i removed before and it changes the checkboxes to cells that have no checkbox04:22
aelknerbut clicking on them doesn't change to red like in the old version04:22
replaceafillit also needs the flourish css class04:22
aelknera, of course04:23
replaceafillcheck in firebug if a new class is set04:23
replaceafillwhen you click04:23
replaceafillif it does, your ok04:23
aelknerexcellent, that was a great idea, the classes toggle between holiday and schoolday04:24
aelknerso yeah, it's just the css that i will leave in your capable hands04:24
replaceafillyou know, looking at /terms closely04:24
replaceafillit's difficult to understand why do you have two rows with the same data04:25
replaceafill(if your year has only one term for example)04:25
replaceafillbut i guess th1a is ok with that04:25
replaceafilli'll leave /terms alone :)04:25
aelknerwell, i guess having the second row display to the user the fact that the year has only one term04:27
aelknereven if they didn't need to be told that04:27
aelknerit is an honest account of what's going on04:27
aelknerand when the user adds more than one term, the difference is visually clear04:28
*** aks has joined #schooltool06:28
*** th1a_ has quit IRC07:01
*** replaceafill has quit IRC07:38
*** menesis has joined #schooltool10:04
*** menesis has quit IRC11:06
*** menesis has joined #schooltool11:09
*** aks has quit IRC11:17
*** aks has joined #schooltool11:26
*** aks has joined #schooltool11:26
*** menesis has quit IRC13:15
*** ignas has joined #schooltool13:16
*** aks has quit IRC14:19
*** itsurkg has joined #schooltool14:24
*** fsufitch has quit IRC14:26
*** itsurkg has quit IRC15:16
*** fsufitch has joined #schooltool15:49
*** replaceafill has joined #schooltool16:24
*** th1a has joined #schooltool16:31
th1ahi aelkner, replaceafill.16:32
replaceafillgood morning16:32
* th1a was hoping for the return of yvl...16:32
th1aI do want to talk to him about School/Application page design before we do that, because I know he was thinking about it.16:33
th1aAnd I don't have any particularly brilliant ideas.16:33
th1aRegarding old skin tests.16:35
th1aFor me this is a "pay me now or pay me later" issue.16:35
aelknerhow do you mean that?16:36
th1aI'm going to pay for it either way, and what I don't want is five years from now a new developer wasting an afternoon trying to figure out why some views are weird and eventually remembering that it was a workaround to not break tests five years ago.16:36
th1aSo lets keep things consistent.16:38
th1aWe'll decide which old tests to fix when we get there.16:40
aelknerthis is the way i understand the situations16:42
aelknerwe have a flourish skin, why, couldn't tell you16:43
aelkneri was guessing that we did so to allow us to have the old skin running for some reason16:43
aelkneragain, don't know why, but there  it is16:43
aelknerso my only question is, if we need the thing running, do we need it to run without crashing?16:44
aelkneras far as weird views, they're all weird because they have this special flourish registration16:44
aelknerand base class usage16:44
aelkneri didn'[t have a problem with the new flourish classes, i just figured out how to use them16:45
aelknerwe don'[t need to break the old skin16:45
aelknerwe can override anything we want in the flourish classes and templates16:46
th1aPerhaps we should step back to the actual question at hand.16:46
aelknerit's just changing the interfaces that is a no-no16:46
aelknerchanging interfaces or old skin base classes means breaking the old skin16:46
aelknerbut we don't need to do that16:46
th1aWas the question yesterday about changing text in the interface schema rather than just changing it at the skin level?on16:46
th1aIn that issue in particular I'd much rather fix the old tests because you're improving the old skin.16:47
th1aYou're fixing the interface, not breaking it.16:48
th1aAnd it will be easy to update the tests if we decide to.16:48
aelknerif we are only changing test of interface fields, fixing the tests will be straight-forward16:48
aelknertext of interface fields16:48
aelkneri would advise against any changes to base classes however16:49
aelknerold skin classes, i mean16:49
th1aI don't really think those are on the table anyhow.16:49
aelknerok, so only interface text changes16:49
aelknerso replaceafill, what was your original question about?16:50
th1aLet's say it should be discussed on a case by case basis.16:50
aelknerwhy i didn't change the interface somewhere?16:50
replaceafilli wondered if you knew of a reason to use updateWidgets instead of changing the interfaces16:51
aelknerwhich case?16:52
replaceafillthe forms where you set descriptions on widget fields16:52
aelknerin the case of adding a term, the first/last hints are dynamic now16:52
replaceafilli'm ok with using updateWidgets for that16:52
aelknerThe year starts Jan 1, 201216:52
replaceafillfor dynamic stuff16:53
th1aI think if aelkner had used that answer the first time, we would have saved an hour.16:53
replaceafillbut for static text, i say change the interface16:53
aelknerit's ok, i think the discussion was fruitful, and i think we all agree on how to go from here16:53
aelkneronly text changes in interfaces, no old skin class changes, and we'll be ok16:54
th1aaelkner:  That was not the decision.16:54
replaceafillwhy is wrong to change base classes?16:55
th1aThe decision is:16:55
th1a- definitely change text in interfaces;16:55
th1a- discuss other changes.16:55
th1aBut the bias is still toward the new when it comes up.16:55
th1aI just don't think the "other changes" are going to come up.16:55
aelknerok, sounds good to me16:56
replaceafillaelkner why do you think changing old classes is wrong?16:57
*** Guest68804 is now known as issyl016:57
*** issyl0 has quit IRC16:57
*** issyl0 has joined #schooltool16:57
th1aI think we're arguing now about things that aren't going to happen.16:57
aelknerreplaceafill, if you want to create work for us later and potential deadline pressure, i won't stop you :)16:57
th1aBy definition we shouldn't need to change things in the old skin.16:57
replaceafillok an example:16:58
th1aAnd there is no reason to think we'll need to suddenly change base classes.16:58
aelknerthat's why we created flourish, i figured16:58
replaceafillsuppose you need to redirect to a newly created object16:58
replaceafillbut the old class redirects to the container16:58
aelknerdo it in the flourish view class please16:58
replaceafillyou can easily add self._resource = resource to the old class16:58
aelkneri just handled that last night16:58
replaceafilland change the redirect16:58
replaceafillwithout duplicating the whole method16:59
aelkneri needed the term delet to redirect to /terms16:59
aelknerso i did it in the flourish view class16:59
aelkneri didn't change the old skin class16:59
aelknerwhy break it and have to fix it later16:59
aelknerwe have a lot of old skin tests that have navigation in them16:59
aelknerand it will be a lot of work to fix them if we mess with the old skin classes17:00
aelknerso let's not, ok replaceafill?17:00
replaceafillwhy do we care about old tests again?17:00
th1aI'm ambivalent about that one.  I have nothing against copying the method.17:00
aelknerreplaceafill, we only care about tests if we care about code working17:00
aelknerif not, then why not delete all the tests from the codebase?!17:01
aelknerwe are going to have flourish tests17:01
replaceafillwell, i'll wait for yvl opinion but i thought that's what we're going to do17:01
replaceafillget rid of most of the old tests17:01
replaceafillfunctional at least17:01
replaceafillthe ones that simulate the UI17:01
aelknerand why do we need the old skin code that has no test coverage?17:02
aelkneror the old skin for that matter?17:02
th1aWell, let's say CanDo says "NO WE CAN'T USE FLOURISH" next year.17:02
aelknerso we better amke sure that code isn't broken17:03
replaceafillth1a they stick to core, right?17:03
th1aIf the old skin is still there with a few trivially broken functional tests, it isn't the end of the world.17:03
replaceafilla different branch17:03
aelknerpassing tests is the only way to know if code is not broken17:03
th1aaelkner:  In a sense, it is their problem.17:03
th1aIt is still a small change anyhow.17:04
th1aWhatever kind of fix you want is still pretty straightforward.17:04
aelknerwe can change redirects in the flourish view classes so as not to break the old skin17:04
aelkneri know yvl will back me up on this17:05
aelknerth1a, but you answered the question as to why we need to support the old skin17:06
th1aI have no problem with that one.17:06
aelkneralso, courseinfo package will probably use the old skin this year17:06
aelknerso breaking it would be mean to them17:06
replaceafillsorry, but i still dont understand this part, worrying about cando, isnt flourish a new different series from core?17:08
replaceafillif cando doesnt want to use flourish yet, they use core17:08
replaceafillso, flourish will be the new core?17:08
replaceafillin that case, old code should stay exactly the same :D17:09
aelknercando already derives its skin from the old skin, so they will not need to know about flourish17:09
aelknerreplaceafill, thanks :)17:09
replaceafillexactly exactly the same ;)17:09
aelknerand keep in mind, cando is not testing the labels that result from the interface changes we make17:09
aelknerat least, it should only break a couple tests that will be easy to fix17:10
replaceafilli always thought flourish was like the schooltool 1.2 vs schooltool 1.0 case17:10
replaceafillwhere you had bleeding edge features in 1.2 and stable ones in 1.017:11
replaceafilland you backported from one to the other17:11
th1aThe debatable question is the rare occurrence when we do want to change the base code, not the view code.17:11
aelkneras you pointed out, that will be rare, and we only need to respect the consideration of the costs of making changes of that nature17:12
aelknerjust breaking code without considering costs is the only mistake we would make17:12
th1aOK, so NOW I think we've got that settled.17:13
replaceafillok, we need to fix old tests then :)17:13
replaceafillor at least find a way to run them together with the new skin17:14
replaceafilli'm sure yvl already has something in mind for that :)17:14
aelkneryes, let's see what yvl has planned17:14
* replaceafill leaves the old code alone ;)17:15
aelknerthank god! :)17:15
th1aNow, what do you have for me aelkner?17:15
aelkneri fixed the add term view so that you can add a term now17:15
aelknerreplaceafill was kind to offer to handle fixing the css17:16
aelkneri also created the index.html viedw for a term17:16
aelknerand the delete action and dialog17:16
aelknerso you can delete terms that you add17:16
aelkneri can work on edit.html today17:17
th1aThe header on the term index should say "Title" not "Term"17:17
th1aI agree with you guys that the distinction between year and term in the table could be a little better.17:17
aelknerhow about the year title having prefix of 'School Year:'?17:18
th1aYeah, something like that.17:18
th1aTry that.17:19
th1aJesus H. Christ aelkner, this looks pretty good.17:19
aelknerwhy, thank you, th1a!17:20
th1aNeeds some work, but much cleaner than the original.17:20
aelkneri haven't even had  the chance to look at the improvements you guys are making to /courses17:21
aelkneris that in trunk yet?17:21
th1aOK, let's look at replaceafill's work now and come back to tweaking the calendar.17:21
aelknerwait, on e sec17:21
replaceafillaelkner no, not yet17:21
aelknerreplaceafill, i definitely like the idea of letting you fix the css in terms view17:22
replaceafillaelkner :)17:22
th1aOK, we'll do that.17:22
aelknerviews, but can we wait until i move on to another package to reduce merge conflicts17:22
replaceafillit's in my flourish todo already ;)17:22
aelkneri still have other term views to get going17:22
replaceafillaelkner sure17:22
replaceafilli'll work on that until you tell me you're leaving, ok?17:23
th1areplaceafill:  The add link is going to have to be year-aware for courses.17:23
replaceafillit is17:23
replaceafill(i think)17:23
th1aOh, I'm not logged in.17:23
replaceafillwell /courses and course index are public17:23
th1ait is the right behavior.17:24
replaceafilli guess most of the functionality is finished for courses17:24
replaceafillindex, edit, delete17:25
replaceafillAdd Course inside course index ;)17:25
th1aaelkner:  That's a controversial move.17:25
th1aWhat do you think?17:26
replaceafillth1a i have a few questions17:27
aelknersorry, was making a fix17:27
replaceafillth1a should we hide empty non-required values in course index?17:27
replaceafilllike empty description for example17:27
replaceafilllike we do with person accordions17:27
replaceafillthat we only display fields with data17:27
aelknerth1a, what's controversial?17:28
aelkneri'm missing something17:28
replaceafillaelkner Add Course inside the course view17:28
th1areplaceafill:  I'd say yes.17:29
replaceafillmeaning adding a course from a course17:29
replaceafillth1a ok, will do17:29
aelkneryou mean /courses?17:29
aelknersorry guys, my head s not in that view, so i can't offer an opinion17:29
aelknercould you push to trunk so i could look?17:29
th1aCourse needs a Done, too.17:29
th1aI gave you a link.17:29
aelknerth1a,, is that good enough for now?17:29
replaceafillth1a the Done button was another question :)17:30
replaceafillput it at the bottom, right?17:30
replaceafillth1a also, could you review the message for the delete dialog?17:30
aelknerok, i followed the link, so i'm lloking at the view17:31
th1aYou can add a course from there.17:31
aelknerso adding a course from that view makes sense to me17:31
aelkneris that the question?17:31
aelkneri am a little concerned about the user knowing what year it is17:32
aelkneri know we have th tab17:32
aelknerbut i'm not sure the user will always notice17:32
replaceafillah that's another change i made17:32
th1aIt will be the active year, so that's ok.17:32
replaceafilli removed the "Courses for 2011" from the title17:32
replaceafillassuming you have the right year highlighted17:32
replaceafilland the title for /courses is just "Courses"17:33
th1aoh, I prefered it with the year.17:33
aelkneri actually think that title would help17:33
replaceafillcool, i'll put the year back17:33
aelknereven if it is redundant with the tab17:33
replaceafillth1a is the delete dialog message scary enough? :)17:34
replaceafillkk, next question17:34
replaceafillah this:17:34
replaceafillthe redirect button in Add Course17:34
replaceafillthe Cancel button17:34
replaceafillshould it be smart enough to know where to return?17:35
th1aIn terms of year?17:35
replaceafillfor example if you hit Add Course from /courses or from course index17:35
replaceafillshould Cancel always take you back to /courses?17:36
th1aI think that's fine.17:36
replaceafilland my final question17:36
aelknerthat's the way adding term works, it returns to /terms17:36
replaceafillaelkner yes but you dont add terms from inside a term ;)17:36
th1aNo, but aelkner, it seems we're standardizing on sending you to the object after you create it.17:37
aelkneri'm confused, isn't adding a course from /courses the same as adding a term from /terms?17:37
replaceafillit is17:37
aelknerth1a, yes, i do that with successful add of term17:37
aelknerit goes to the new term's index.html17:37
th1aOh, if you cancel you go to /terms17:37
th1aOK, that's fine.17:37
replaceafillbut returning to /courses after you hit Add Course from inside a course feels funny17:38
replaceafilli'd expect to return to the course index17:38
th1aIt is probably most correct to go back to where you came.17:38
aelkneri thought /courses is the course index17:38
replaceafillth1a +117:38
replaceafillok, i'll make the Cancel button smart17:38
th1areplaceafill:  Is it a 10 minute fix?17:38
replaceafillth1a yes17:38
replaceafillok, last question17:39
replaceafillregarding responsible parties17:39
replaceafill  - What tasks should course/resource leaders do?17:39
replaceafill    + Edit data17:39
replaceafill    + Manage leaders17:39
replaceafill    + Delete17:39
replaceafilli guess Edit course attributes, right17:39
th1aLooking at what we have now, it is just edit.17:39
replaceafillcan a leader manage other leaders?17:39
th1aCan they now?17:40
th1aI'd say no.17:40
replaceafillok, just Edit then17:40
replaceafillthat's it from me :)17:40
replaceafillok, my todo list:17:41
replaceafill  - Make Cancel button in Add Course smart to redirect to where you came from17:41
replaceafill  - Put the year back in Courses title17:41
replaceafill  - Hide empty non-required values in course index17:41
replaceafill  - Put a Done button at the bottom of course index17:41
replaceafill  - What tasks should course/resource leaders do?17:41
replaceafill    + Edit data17:41
replaceafillth1a is /sections coming next for me?17:42
replaceafillsame way, right?17:42
replaceafillby the way17:42
replaceafilli also need to fix search in /courses :)17:42
replaceafillit only looks in the active year ;)17:43
replaceafillso, i'll add that to my TODO17:43
th1aSections is tricky because we have to decide how to select the course.17:43
replaceafillth1a correct i was going to ask that17:43
th1aI guess we should just do it from the add form.17:43
th1aAnd add an add section link from the course view.17:43
th1aOf course, that might make the add course link more confusing...17:44
th1aWe'll make it work.17:44
replaceafillaelkner does add term uses sessions?17:45
replaceafillfor storing the initial title and date values?17:45
aelkneri don't think so17:45
replaceafillor does it pass them in the request17:45
aelknerthose fields are in the form each step17:45
aelknerso i guess there's no need to save them in session data17:45
aelknerwhy do you ask?17:46
replaceafilli'm just wondering how to pass data from one view to another17:46
aelknerquerystrings work :)17:46
replaceafillth1a the first step in add section would be to search for the course right17:47
aelknerth1a, are you trying to make it so that the user can add a section without navigating to the course?17:47
replaceafilli'm thinking how that result table would look like17:47
replaceafillaelkner correct17:48
aelkneris it so bad to have to navigate to the course?17:48
th1areplaceafill:  Yes.17:48
replaceafillactually, the current skin allows you to do that17:48
aelkneri never thought the old skin was so bad with that17:48
aelknerth1a, what's your thinking here?17:48
replaceafillif you navigate to the course, it's selected automatically17:48
replaceafillbut you can select another course if you want17:48
th1aBasically, we're not requiring the user to think hierarchically.17:49
replaceafilljust inside the year, right?17:49
replaceafillSections for 201117:49
replaceafillclick Add Section17:49
replaceafillyou look in courses in 201117:49
th1aBut it is still like switching tabs to them, not drilling down.17:50
replaceafillth1a can i put a + column at the end of the courses result list17:50
replaceafillto select the course you want17:50
replaceafilland then take you to the add form with the section fields17:51
replaceafillstarting term, ending term, etc17:51
replaceafillok, will work on that next17:52
* replaceafill is enjoying this work :)17:52
th1aOh, I have a conference call with the designers in 8 minutes.17:52
th1aaelkner:  You have stuff to do, right?17:52
th1a(for the next hour...)17:53
th1aOK, later guys.17:56
* th1a drops the bag of gravel.17:56
replaceafillgood luck th1a17:56
th1aSince I'm paying them, I shouldn't need luck.17:57
aelknerth1a, i have stuff to do, yea17:58
th1abtw, I decided to wait until we get School and Application together to do the screencast.18:47
th1areplaceafill:  The Shuttleworth Foundation appears to have changed its motto again.18:47
th1aAlso, they seem even more anti "The" in their name.18:48
replaceafilltime to update the footer18:48
th1aAlso, their new site seems kind of tweaked.18:48
replaceafill"Supporting exceptional people to change the world"18:49
replaceafillare we exceptional people!?!? :D18:49
* replaceafill updates the footer18:50
replaceafill© 2011 Shuttleworth Foundation :O18:50
th1aYou are exceptional, but you aren't supported by Shuttleworth Foundation.18:50
th1aGet rid of the "the!"18:50
replaceafillah :(18:51
replaceafillfooter updated18:52
replaceafillbtw, search is fixed in /courses18:53
replaceafilli only have 2 more items in my TODO18:53
replaceafillth1a i think leaders should work the same way for resources as for courses, right?18:54
replaceafilli mean, they can only edit resource data18:54
th1aThey have some permissions regarding scheduling though?18:55
th1aOr is there a choice regarding that?18:55
replaceafillhavent checked scheduling18:55
th1aracing you...18:55
replaceafilli've only seen them in courses, groups, and resources18:55
replaceafillbtw, are we adding a /groups view too?18:56
replaceafilllike /courses and /sections, with multitabs?18:56
th1aNo, that's the point... the responsible party for the resource should have different permissions to schedule it.18:56
replaceafillor is that too much :D18:56
th1areplaceafill:  Yes, tabs for groups.18:56
replaceafillschedule it = reserve, correct?18:57
th1aSo something like:18:57
replaceafillwell, since Reserve doesnt work yet, i'll put it on my TODO18:57
th1a"These users can modify and schedule reservations for the resource."18:58
th1aIt affects just booking the resource in a regular calendar event.18:59
th1aSo it is still applicable.18:59
th1aOur terminology is mushy here.19:00
th1aWe say "book resources" when you're creating a calendar event.19:00
th1aLet's use "book" here since it applies specifically to reserving a resource.19:01
replaceafillbtw, should /resources be public?19:02
replaceafilland should resources be public?19:03
replaceafilli wonder if that's a control access setting...19:03
th1aDo you need to reset all these in the new skin or something?19:04
replaceafill"Only school administration can view the list of resources."19:05
replaceafillaccess setting19:05
replaceafillth1a what do you mean?19:05
th1aI'm not sure why you're asking me these questions.19:06
th1aIt is in the code already, right?19:06
replaceafillah, to match the behaviour of the course view19:06
replaceafillfor leaders19:07
replaceafillletting resource leaders to have access to certain parts of the rsource only19:07
th1aThat resources permission is a little weird.19:07
replaceafillbut in the case of resources, it set by access control settings19:07
replaceafillcourses are not19:07
th1aIt could just as easily be public/admin-teachers-leaders19:08
th1ainstead of public/admin19:08
th1aI don't remember what I was thinking for that.19:08
th1aIt is pretty paranoid.19:08
replaceafillwell, i'll write "review resources security" in my TODO19:08
replaceafillwill finish these course changes first19:09
replaceafillcontinuing the leaders conversation...19:15
replaceafillleaders get schooltool.edit on their contexts :(19:16
replaceafillso they can access object/leaders.html!!!19:16
replaceafillthrough URL19:16
replaceafillwriting it down in the TODO19:16
replaceafill* fix: schoolyears/AYEAR/courses/ACOURSE/leaders.html is still accessible to leaders through URL19:16
th1aProbably we should change the permissions.19:16
th1aThese are overly complicated.19:16
th1aOh, they can edit it?19:17
replaceafillyes, leaders get schooltool.edit on things they're responsible for19:17
replaceafilli managed to hide the "Add" menu from the course index for leaders19:17
replaceafilland the "Responsible parties" block19:17
replaceafillbut they can access the urls19:18
replaceafillwell, not for adding courses19:18
replaceafillbut yes for editing other leaders in the object19:18
th1aThis is a very minor point.19:18
replaceafilli was thinking maybe people dont use leaders too much19:19
replaceafillsince they dont do much in the current version19:19
replaceafilllog out and login as carmen/carmen19:19
replaceafillcarmen is a leader on that course19:19
replaceafillshe can edit it19:20
replaceafillbut she doesnt see the Add menu or the Responsible parties block19:20
th1aI was just thinking that it would be good to make escalating privileges better as a general rule of thumb.19:20
th1aBut it is a very minor point.19:20
th1aI mean, making escalating privileges harder is better.19:20
replaceafilli blame the LeadersCrowd19:21
replaceafillok, final item: making Cancel smarter19:21
replaceafilland then will move to /sections19:21
th1aLiterally you could change the permission and file a low priority bug that we'll never look at.19:21
th1aJust do that (but don't file the bug)19:23
replaceafillwhat do you mean by "change the permission"?19:23
replaceafillchange the permission on leaders.html?19:23
th1aSo leaders can add leaders.19:23
replaceafillcool, leaders can edit leaders now19:24
replaceafilleasier ;)19:24
*** ignas has quit IRC19:24
* th1a wonders if we just broke some tests. ;-)19:29
replaceafillwe'll find out soon i hope :)19:30
replaceafillCancel in Add Course is smart now19:47
replaceafilli guess that's it for /courses!19:48
th1aWe've got three weeks until feature freeze as of today, by the way.20:08
aelknerguys, courses looks nice!20:09
replaceafilli hope /sections and /groups will be faster20:09
aelknerthe title together with the tabs is so easy to follow20:09
aelknerwell, sections is more complicated than courses20:10
aelknergroups will be easier20:10
replaceafilli think /sections is just one extra step20:10
aelknerth1a, could i do groups after i finish terms20:10
replaceafillto look for the right course20:10
replaceafillaelkner dont you want to start with interventions?20:11
replaceafilland let /groups to me20:11
aelkneris that the plan20:11
replaceafilli think i can do both today20:11
aelknerreplaceafill, we could do that20:11
replaceafilli mean, interventions is your baby :)20:11
replaceafilland i cannot touch it! :P20:11
replaceafillbut i'll let th1a to decide20:12
replaceafilljust my $0.0220:12
aelknerbut if you're already in that mindspace, i agree you should do groups20:12
replaceafilli think so20:12
replaceafillit's the same "pattern"20:13
replaceafillhey! i'm using your words!!!20:13
aelkneri was just thinking from the point of view of having a next task + having a chance to get into that mindspace20:13
aelknerbut it's not important20:14
aelknerare we alomost ready to work on the plugins?20:14
aelkneri noticed th1a mentioned gradebook tasks that you and he would work on, is that soon?20:14
replaceafillgradebook, i think he said interventions20:15
replaceafillthat's why i came up with that20:15
aelkneri think you and i should each pick a plugin befreo we start20:15
aelknerbetter for us to not step on each other's merge20:15
replaceafillyou're the one for interventions i think20:16
replaceafillyou know it better20:17
aelkneri agree20:17
aelkneryou already have mucho experience with the gradebook20:17
aelknerand we can fight over the journal after that :)20:17
replaceafillok, we're swtiching to spanish next week20:17
aelknerno (the spanish no, not the english one)20:18
replaceafillok, i'm about to push these changes to trunk20:18
* th1a is back.20:24
replaceafillaelkner i want your opinion on something20:27
th1aI want to finish the management views completely before moving on.20:27
th1aSo groups next for replaceafill.20:27
th1aThen replaceafill > journal.20:27
th1a(I mis-typed about interventions)20:28
th1aaelkner > gradebook20:28
th1ayvl > calendar20:28
th1aPresumably aelkner > interventions, but basically, it is the red-headed stepchild still, so whomever has time.20:28
replaceafillth1a /sections -> /groups -> journal right?20:29
replaceafilli think i can have the first two by tomorrow20:29
th1aWhomever is free.20:29
aelknerred-headed stepchild?  i'm not getting the reference20:30
* replaceafill wondered the same!20:30
aelkneris that a slur on irish people? :)20:30
replaceafillthe /courses and related views pushed to trunk20:33
replaceafillth1a, i  think i'll do /groups before /sections20:35
replaceafillsince it's almost the same as /courses20:36
*** ignas has joined #schooltool20:53
replaceafillth1a zyt?21:09
th1aare you restarting?21:09
replaceafilloops restarting the server21:09
th1aGot it.21:09
th1aGet rid of the hints.21:10
replaceafillrestarted the server21:11
replaceafillwe can't delete default groups!!21:15
replaceafillDependencyError :D21:15
replaceafillwill make the Delete link smarter21:15
replaceafillhey! the members!!!21:16
replaceafillwe should be able to see the members of the group, right? :D21:16
replaceafillunless we think we dont need that functionality anymore ;)21:16
replaceafillwe still dont worry about import views, right?21:18
replaceafillah, the Reports tab too21:19
replaceafilland a Calendar link21:19
th1aWell, there is no particular reason we're skipping import views, unless someone wants to argue for moving them.21:20
replaceafilli think we were going to do a full sweep on import views later21:20
replaceafillxls, csv, etc21:20
replaceafillbut i'm most worried about the members views right now21:21
replaceafilland action link: Manage Members21:21
replaceafilland we list them under the group details in group index?21:22
replaceafilllike the old view21:22
* replaceafill thinks is asking th1a too much :(21:22
th1aI think all the exports should be centralized as reports.21:23
th1aBut the imports probably are just actions on the container indexes.21:23
th1aJust under the details is fine for members.21:24
th1aAbove responsible parties.21:24
th1aWith a pencil.21:24
replaceafilli always forget the pencil :)21:24
replaceafillshould i add a third action links group for Calendar and Reports21:25
replaceafillunder ${group}'s21:25
replaceafilllike we do for persons?21:25
replaceafill- Calendar21:26
replaceafill- Reports21:26
th1aDelete should be last.21:28
replaceafill${groups}'s, Add and Actions21:28
replaceafillfor the link groups21:28
replaceafillok, will work on these changes21:30
*** fsufitch has quit IRC21:56
* replaceafill wonders if it's better to hide the Delete link or render it "deactivated"22:27
replaceafillth1a zty?23:00
replaceafilloops, zyt? :D23:01
* replaceafill is getting hungry...23:01
replaceafilli think group functionality is complete23:01
replaceafillah, except for reports23:02
replaceafill- add reports view for groups23:02
replaceafill  * Student Detail Report by Group23:02
replaceafill  * Student Report Card by Group23:02
replaceafilllast item of my TODO23:02
replaceafillbut i had a question about the title: subtitle in the edit members view23:02
replaceafillin group index we have Groups for 2011: Baseball23:03
replaceafilland the Baseball: Members23:03
replaceafilland Baseball: Responsible parties23:03
replaceafillno reference to the year, is that ok?23:03
* replaceafill goes to get lunch23:04
replaceafillaelkner you there?23:54

Generated by 2.15.1 by Marius Gedminas - find it at!