| *** didymo has joined #schooltool | 00:27 | |
| aelkner | th1a? | 01:01 |
|---|---|---|
| aelkner | sorry, i was away | 01:01 |
| *** alga has joined #SchoolTool | 10:53 | |
| *** lisppaste5 has quit IRC | 12:58 | |
| *** jfroche has quit IRC | 12:58 | |
| *** lisppaste5 has joined #schooltool | 12:58 | |
| *** jfroche has joined #schooltool | 12:58 | |
| *** didymo has quit IRC | 13:35 | |
| *** ignas has joined #schooltool | 13:58 | |
| ignas | aelkner: fixed the bug | 15:10 |
| ignas | aelkner: pcarduner migrated most of schooltool forms to use z3c.form | 15:11 |
| ignas | aelkner: as your PersonEdit form was not in the sandbox he didn't fix it | 15:11 |
| aelkner | i'm here | 15:11 |
| ignas | the error was absolutely uninformative though | 15:11 |
| aelkner | why did it have to do with the form? | 15:11 |
| ignas | I had to guess what's wrong because debugging was useless | 15:12 |
| ignas | z3c.form is handling vocabularies/sources differently | 15:12 |
| ignas | in some misterious way | 15:12 |
| ignas | *mysterious | 15:12 |
| aelkner | zope is definitely too mysterious | 15:12 |
| ignas | i have fixed terms to work with z3c.form and it broke your forms | 15:12 |
| ignas | it's not zope it's zope form libraries | 15:13 |
| ignas | and the widget mess | 15:13 |
| aelkner | but paul didn't migrate every form, did he? | 15:14 |
| ignas | apparently no he didn't and there are a couple forms that are still formlib | 15:14 |
| ignas | but we should fix them sooner or later though | 15:14 |
| ignas | so we would not be using formlib anymore | 15:14 |
| ignas | it's an intermediate step towards migration to pagelets + layouts | 15:15 |
| ignas | it goes something like this - view marco's are not so cool | 15:15 |
| ignas | pagelets + layouts are way better | 15:15 |
| ignas | you can't use formlib with pagelets and layouts | 15:15 |
| ignas | and z3c.form is better than pagelets and layouts anyway | 15:16 |
| ignas | and z3c.form is better than formlib | 15:16 |
| ignas | :D | 15:16 |
| ignas | ;) | 15:16 |
| aelkner | i understand | 15:16 |
| aelkner | does this mean i'm forced to use zc3.form for all of my sla forms immediately? | 15:17 |
| ignas | immediately - no, but if you would - it would be nice ;) | 15:17 |
| ignas | though i haven't learned that much about z3c.form yet | 15:17 |
| ignas | which is why I asked paul to start the migration | 15:18 |
| aelkner | i have a deadline to deliver csap | 15:18 |
| aelkner | and i'm not sure i have time to learn zc3.form until after May 1 | 15:18 |
| ignas | i see | 15:18 |
| ignas | well - do it the way it works for you then | 15:18 |
| aelkner | i have no problem refactoring after the deadline | 15:19 |
| ignas | works for me, as long as you'll have time for that | 15:19 |
| ignas | i'll probably set up a buildbot for SLA | 15:19 |
| ignas | to get notified about such breakages earlier than you see them ;) | 15:19 |
| aelkner | but the problem with the vocabularies only affected the person edit form, right? | 15:20 |
| aelkner | i like the sound of that | 15:20 |
| aelkner | did you try out the group edit bug that i mentioned | 15:20 |
| aelkner | ? | 15:20 |
| ignas | it seems that it's only person edit form, unless you are using AdvisorSource and GroupSource in other forms | 15:20 |
| ignas | which one? | 15:20 |
| aelkner | the other problem (which i didn't need to test) | 15:21 |
| aelkner | was that after i've imported the students and teachers | 15:21 |
| aelkner | if i go to either the student or teachers group | 15:21 |
| aelkner | it crashes there | 15:21 |
| ignas | could you give me a traceback or a test please? | 15:22 |
| aelkner | i'll develop the test when i get to sla and check it in for you | 15:22 |
| ignas | ok | 15:23 |
| aelkner | i have to shower and get ready to go now | 15:23 |
| ignas | thanks | 15:23 |
| aelkner | thanks to you | 15:23 |
| *** aelkner has quit IRC | 16:02 | |
| *** mgedmin has joined #schooltool | 16:02 | |
| th1a | Hrm... | 16:36 |
| ignas | hrm? | 16:46 |
| ignas | th1a: could you please give me the steps to reproduce https://bugs.launchpad.net/bugs/210964 ? because i seem to be unable to reproduce it ... | 16:57 |
| th1a | OK... I'll try it again. | 17:01 |
| th1a | That was with a resource I created manually. | 17:02 |
| *** aelkner_ has joined #schooltool | 17:02 | |
| ignas | yeah, i did that too | 17:02 |
| ignas | if you could just give a bit more details | 17:02 |
| ignas | like - what user you logged in with | 17:02 |
| ignas | how you got to the resource calendar | 17:02 |
| ignas | and where you got redirected + when | 17:03 |
| th1a | OK... | 17:03 |
| th1a | I go to Reservations | 17:03 |
| th1a | As adminstrator. | 17:03 |
| th1a | Click on Location > Resource. | 17:04 |
| th1a | Room 03 | 17:04 |
| th1a | View Calendar | 17:04 |
| th1a | Create an event. | 17:04 |
| th1a | I get redirected back to my personal calendar. | 17:05 |
| ignas | "create an event" how? | 17:05 |
| ignas | click on new event button? | 17:05 |
| ignas | click on the calendar ? | 17:05 |
| th1a | Click on the calendar. | 17:05 |
| ignas | hmm | 17:05 |
| ignas | and then? | 17:05 |
| ignas | i mean - i get a calendar view showing my newly created event ... | 17:05 |
| th1a | There is no event back on the room's calendar. | 17:05 |
| th1a | You don't get redirected? | 17:06 |
| ignas | i do | 17:06 |
| ignas | i get redirected to my personal calendar | 17:06 |
| ignas | and can see the event in there | 17:06 |
| ignas | or are you going back to the resource calendar somehow? | 17:06 |
| th1a | Huh. | 17:06 |
| th1a | I can't see it on either calendar. | 17:07 |
| ignas | ok, managed to reproduce it it seems | 17:07 |
| ignas | worked with one configuration | 17:07 |
| ignas | does not work with another | 17:07 |
| ignas | i think i know who did that ;) | 17:08 |
| th1a | Do you know how to set up firebug to do live css editing? | 17:08 |
| ignas | nope, not really | 17:09 |
| th1a | I'm working on the footer. | 17:09 |
| ignas | i always thought you just switch to firebug | 17:10 |
| ignas | click CSS | 17:10 |
| ignas | and click "edit" in there | 17:10 |
| ignas | i mean - it works for me | 17:10 |
| th1a | ...perhaps I should try that then. | 17:10 |
| ignas | you have these buttons [Console] [Html] [Css] [Script] etc. | 17:11 |
| ignas | click on Css, and there is an Edit button nearby | 17:11 |
| th1a | Yes. | 17:11 |
| ignas | you can pick the Css file by clicking on the filename of the active one | 17:11 |
| ignas | it expands into a menu | 17:11 |
| th1a | Does it actually change the file? | 17:12 |
| ignas | no | 17:13 |
| ignas | it can't know where the file is | 17:13 |
| ignas | the file is served by Zope3 | 17:13 |
| th1a | That's what I thought. | 17:13 |
| th1a | So do I just copy/paste my change? | 17:13 |
| ignas | i think so | 17:15 |
| th1a | OK. | 17:16 |
| aelkner_ | ignas: did you get my note a couple days back regarding my not getting checkin notifications anymore? | 17:17 |
| ignas | i am not getting them too | 17:17 |
| ignas | i think our checkin mailing list is not working | 17:17 |
| ignas | i had no time to investigate it or talk to marius about what can be broken | 17:18 |
| ignas | you might want to write an email to Jinty | 17:18 |
| aelkner_ | what's Jinty's email address? | 17:29 |
| ignas | "Brian Sutherland" <jinty@web.de> | 17:30 |
| aelkner_ | ah, so jinty is just his handle, not his name | 17:32 |
| ignas | yes | 17:32 |
| aelkner_ | ignas: i've created the failing test for the group crash | 17:53 |
| aelkner_ | svn up sla | 17:53 |
| aelkner_ | ignas: will you be able to look at this before you are done for the week? | 17:54 |
| ignas | i guess ;) | 17:54 |
| ignas | if it's interesting enough ;) | 17:54 |
| aelkner_ | oh, it will be interesting ;) | 17:55 |
| ignas | aelkner_: hmm | 18:05 |
| ignas | so if it's dry_run | 18:05 |
| ignas | you are not adding the person to the person container | 18:05 |
| ignas | but you are adding him to the group | 18:05 |
| ignas | and expect it to work properly? | 18:05 |
| aelkner_ | that was horrible of me | 18:05 |
| aelkner_ | i'll fix that now and see if it works | 18:06 |
| ignas | yep my code tries to list members of a group and crashed on a person who is not in the person container | 18:06 |
| aelkner_ | you mean you had the same bug in your own import | 18:07 |
| aelkner_ | ? | 18:07 |
| ignas | no | 18:07 |
| ignas | i mean - i just printed persons created vs persons added | 18:08 |
| ignas | and saw that the person object in the traceback is one of the persons that were not in the person container (dry run one) | 18:08 |
| aelkner_ | you're talking of a dry_run | 18:09 |
| aelkner_ | isn't that import | 18:09 |
| aelkner_ | ? | 18:09 |
| ignas | yes, your import code | 18:09 |
| ignas | the: | 18:10 |
| ignas | if district_id: | 18:10 |
| ignas | obj.groups.add(ISchoolToolApplication(None)['groups']['students']) | 18:10 |
| ignas | else: | 18:10 |
| ignas | obj.groups.add(ISchoolToolApplication(None)['groups']['teachers']) | 18:10 |
| ignas | bit should be after you check for dry_run flag | 18:10 |
| th1a | Is there a way to do i18n for the alt attribute of an image? | 18:10 |
| ignas | i18n:attributes="alt" | 18:10 |
| ignas | i think | 18:10 |
| aelkner_ | ignas: i moved that code into my if dry_run and now it works. thanks a million. | 18:11 |
| ignas | you're welcome ;) | 18:11 |
| th1a | Hm... I managed to break a bunch of functional tests by adding an image to the footer. | 18:22 |
| th1a | I added the resource to the skin, and it works in real life. | 18:22 |
| ignas | some unit tests want that resource registered for them too | 18:23 |
| ignas | old style unit tests... | 18:23 |
| th1a | Where? | 18:23 |
| ignas | src/schooltool/app/browser/testing.py:165: for name in ['layout.css', 'schooltool.css', 'schooltool.js', | 18:24 |
| ignas | for example | 18:24 |
| th1a | Ach. | 18:25 |
| th1a | OK, that's not so bad... I don't have to fix EACH TEST at least. | 18:27 |
| ignas | :) | 18:28 |
| th1a | OK... that's my biggest checkin in a while. | 18:43 |
| th1a | See if I broke anything. | 18:43 |
| ignas | buildbot will tell ;) | 18:46 |
| ignas | Fujitsu: ping | 19:10 |
| *** alga has quit IRC | 20:24 | |
| aelkner_ | th1a: ayt? | 20:35 |
| th1a | Si. | 20:36 |
| aelkner_ | could you call me at work please? | 20:36 |
| th1a | What's the number? | 20:36 |
| aelkner_ | one sec | 20:36 |
| aelkner_ | 215-979-5620 | 20:36 |
| aelkner_ | ask the secretary for me | 20:36 |
| *** ignas has quit IRC | 21:16 | |
| *** mgedmin has quit IRC | 22:05 | |
| aelkner_ | th1a: a question about the gradebook | 22:12 |
| aelkner_ | th1a: ayt? | 22:13 |
| th1a | Si. | 22:14 |
| th1a | aelkner_ | 22:14 |
| aelkner_ | so the tab works like we would want it | 22:15 |
| aelkner_ | but there is this idea of being able to get to the gradebook from the section view | 22:15 |
| aelkner_ | but then anyone can view a section | 22:16 |
| aelkner_ | and there used to be an action button | 22:16 |
| th1a | We're generally not encouraging that style of navigation. | 22:16 |
| aelkner_ | called Gradebook that got you to the gradebook for that section | 22:16 |
| aelkner_ | i agree | 22:16 |
| th1a | So what's the question? | 22:17 |
| aelkner_ | and i removed the action button | 22:17 |
| aelkner_ | well, i just wanted to make sure you agreed with my action to remove the button | 22:17 |
| aelkner_ | because there are tests | 22:17 |
| aelkner_ | in security policy | 22:17 |
| aelkner_ | probably written by Stephan | 22:17 |
| aelkner_ | that have the manager adding activities | 22:17 |
| aelkner_ | and navigating to the section | 22:18 |
| aelkner_ | hitting the gradebook button | 22:18 |
| aelkner_ | and expecting a Traceback! | 22:18 |
| aelkner_ | then, he navigates to a screen that say's | 22:18 |
| aelkner_ | Managers can work with the gradebook | 22:18 |
| aelkner_ | so could i just remove the test | 22:19 |
| aelkner_ | is the question | 22:19 |
| th1a | It sounds like it to me. | 22:19 |
| aelkner_ | ok. will do. | 22:19 |
| aelkner_ | th1a: i'm having an uneasy feeling about our decision here | 22:25 |
| aelkner_ | could it be said that managers would want to be able to look at any teacher's gradebook? | 22:25 |
| aelkner_ | i'm sure the original idea was to make that a site preference | 22:26 |
| aelkner_ | hence the security_policy test | 22:26 |
| th1a | It is certainly not a given. | 22:26 |
| th1a | When we wrote that, we probably still had super-atomic permissions. | 22:27 |
| aelkner_ | ah, that's right. i can blame you for this partly :) | 22:27 |
| th1a | It is just the default Zope system. | 22:28 |
| aelkner_ | but all kidding aside, how would you like to handle that request | 22:28 |
| aelkner_ | from say Chris | 22:28 |
| aelkner_ | to be able to see anybody's gradebook | 22:29 |
| th1a | Well, that's why there are managers and administrators. | 22:29 |
| th1a | But really, it is the school's decision. | 22:29 |
| aelkner_ | could you call me please? | 22:29 |
| aelkner_ | th1a: fyi, i decided that the redundant Gradebook link could be explained to Chris as all action menu items | 23:56 |
| aelkner_ | being context based versus the tab | 23:56 |
| aelkner_ | and I can fix the tests by add 'inedx=1' to the getLink calls | 23:56 |
| aelkner_ | so no need for 'Section Gradebook' to crowd and already crowded actions menu | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!