| *** ccarey has joined #schooltool | 00:22 | |
| *** alga has quit IRC | 00:47 | |
| *** th1a_ has quit IRC | 01:05 | |
| ccarey | Lumiere: ayt? | 01:30 |
|---|---|---|
| *** th1a has joined #schooltool | 01:34 | |
| *** ccarey has quit IRC | 02:00 | |
| *** wbrady has joined #schooltool | 02:54 | |
| *** wbrady has quit IRC | 03:15 | |
| *** wbrady has joined #schooltool | 03:25 | |
| *** wbrady has quit IRC | 04:04 | |
| *** didymo has quit IRC | 06:34 | |
| *** th1a_ has joined #schooltool | 06:37 | |
| *** jfroche has quit IRC | 10:08 | |
| *** SteveA has quit IRC | 10:08 | |
| *** jfroche has joined #schooltool | 10:08 | |
| *** SteveA has joined #schooltool | 10:08 | |
| *** aelkner has quit IRC | 11:37 | |
| *** aelkner has joined #schooltool | 11:37 | |
| *** ignas has joined #schooltool | 14:36 | |
| *** wbrady has joined #schooltool | 14:51 | |
| *** wjohnsto has joined #schooltool | 15:24 | |
| *** th1a__ has joined #schooltool | 15:27 | |
| *** th1a_ has quit IRC | 15:43 | |
| *** alga has joined #SchoolTool | 15:49 | |
| wjohnsto | ignas: I could never get cancel_url to work, but cancel_url is not called anywhere in app, so I changed everything to next_url | 15:55 |
| ignas | schooltool/schooltool/src/schooltool/resource/browser/booking.py ? | 15:55 |
| ignas | line 123 | 15:56 |
| *** th1a has quit IRC | 15:56 | |
| ignas | wjohnsto: i think it's used there | 15:56 |
| *** th1a__ is now known as th1a | 15:56 | |
| wjohnsto | but isn't it defined there already? | 15:57 |
| wjohnsto | ignas: I dont know if that is the same cancel_url that would be defined in app/browser/templates/event_add.pt | 16:03 |
| ignas | yes it's a link to the edit event view | 16:38 |
| ignas | so it's the same one | 16:38 |
| wjohnsto | so I can change it to next_url without problems!? | 16:39 |
| ignas | i think so | 16:40 |
| wjohnsto | quick question though | 16:40 |
| ignas | hmm, though it might cause problems | 16:41 |
| wjohnsto | yea | 16:41 |
| ignas | you see - cancel_url is used to remove the event | 16:41 |
| ignas | if you decide not to book a resource | 16:41 |
| ignas | if you will redirect to the cancel_url after person clicks "Add" | 16:41 |
| ignas | you will delete the event that was just created | 16:41 |
| ignas | so we actually need both - cancel_url and next_url | 16:41 |
| ignas | but we must use one when person clicks Cancel | 16:42 |
| ignas | and the other when he clicks Update | 16:42 |
| wjohnsto | ok | 16:42 |
| wjohnsto | so something like "if "CANCEL_SUBMIT | 16:43 |
| wjohnsto | then use the cancel_url link | 16:43 |
| wjohnsto | else use next_url | 16:43 |
| wjohnsto | ? | 16:43 |
| ignas | something like that | 16:44 |
| ignas | I don't really know at the moment, so you should just write a functional test | 16:44 |
| ignas | to check whether it's doing what you want | 16:44 |
| wjohnsto | ok | 16:44 |
| ignas | or a unit test | 16:44 |
| ignas | a functional is better, because you would be able to submit the form with an error once | 16:45 |
| ignas | and check whether both urls are kept in there | 16:45 |
| ignas | even you make a mistake | 16:45 |
| ignas | it would not be nice to get redirected to some random place if you mistyped a date once, and then clicked "Update" after fixing it | 16:46 |
| wjohnsto | yeah | 16:46 |
| wjohnsto | also | 16:46 |
| wjohnsto | nvm | 16:46 |
| wjohnsto | so which file should I use for the functional test? | 16:47 |
| wjohnsto | app.txt? | 16:47 |
| *** wjohnsto has quit IRC | 16:48 | |
| *** wbrady has quit IRC | 16:49 | |
| *** lisppaste5 has quit IRC | 18:20 | |
| *** lisppaste5 has joined #schooltool | 18:29 | |
| *** mgedmin has joined #schooltool | 19:38 | |
| *** wbrady has joined #schooltool | 19:41 | |
| wbrady | Lumiere: ayt? | 19:42 |
| *** wbrady has quit IRC | 20:20 | |
| *** ignas has quit IRC | 20:56 | |
| *** jelkner has joined #schooltool | 21:25 | |
| Lumiere | jelkner: hi | 21:28 |
| Lumiere | I won't even have a chance to do anything till tomorrow | 21:28 |
| Lumiere | and, "Ask your networking people to look over" was a reference to me not knowing anything at all about what was going on | 21:29 |
| Lumiere | and not knowing that matt had looked at it and not been able to figure it out | 21:29 |
| jelkner | tomorrow is great | 21:47 |
| jelkner | thanks! | 21:47 |
| jelkner | i understand | 21:47 |
| jelkner | i already told them there was a problem | 21:47 |
| jelkner | we really can't wait | 21:47 |
| jelkner | it has been 5 weeks | 21:47 |
| jelkner | so i need to move my cando to wherever you are hosting | 21:47 |
| jelkner | that's why i asked | 21:47 |
| *** jelkner has quit IRC | 21:53 | |
| *** alga has quit IRC | 22:19 | |
| *** mgedmin has quit IRC | 22:21 | |
| *** th1a_ has joined #schooltool | 23:23 | |
| *** th1a has quit IRC | 23:24 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!