| povbot | /svn/commits: * srichter committed revision 4707: | 00:15 |
|---|---|---|
| povbot | /svn/commits: Implemented new pluggable traverser and made initial use of it. The REST traversers were actually already flexible, so I just integrated them. We could convert them all completely to the new way as well, but this would have some implications (not very serious) we might want to discuss first. | 00:15 |
| povbot | /svn/commits: * tvon committed revision 4708: | 01:41 |
| povbot | /svn/commits: keep multiple batches on one page (acl view) from wrapping. | 01:41 |
| *** jinty has left #schooltool | 01:51 | |
| povbot | /svn/commits: * tvon committed revision 4709: | 07:23 |
| povbot | /svn/commits: 'Showing xxx of yyy items' text for containers. | 07:23 |
| povbot | /svn/commits: I put it in the most logical place and tried to style it to look nice, but I think the container UI could look better... maybe by sliding the search box to the right side... I'm not sure. Suggestions for something better? | 07:23 |
| povbot | /svn/commits: * tvon committed revision 4710: | 07:24 |
| povbot | /svn/commits: same as r4709 but for schooltool ('showing xxx of yyy' text). | 07:24 |
| *** pzingg has joined #schooltool | 07:48 | |
| pzingg | Yikes! Although schooltool is so cool, I as a sysadmin (and being zope3-ignorant) would like to see some documentation or hints on customization. F'rinstance: | 07:50 |
| pzingg | 1. replacing the zebra with my own logo | 07:50 |
| pzingg | 2. replacing the default site-wide "SchoolBell Calendar" title with the name of my own organization. | 07:51 |
| pzingg | 3. Leveraging off my OS X server's LDAP directory for persons and group membership. | 07:52 |
| pzingg | I'm sure 1. and 2. can be "easily" done, if I were to be able to figure out how the zope templates and configuration and source repository for resources all work together. Unfortunately, neither the zope3 nor the schooltool docs are that clear to the outsider. | 07:53 |
| tvon | pzingg: for 2, you can login as manager and go to the managers page... there on the left you should see 'site preferences' which lets you set the name of the site | 08:04 |
| tvon | pzingg: for 1 you could change the schoolbell.png file in src/schoolbell/app/browser/resources | 08:05 |
| tvon | er.. thats for schoolbell, for schooltool it is src/schooltool/browser/resources/logo.png I believe | 08:05 |
| tvon | I don't know anything about getting '3' to work though | 08:05 |
| pzingg | Thanks. I either didn't catch the Site Preferences page in the schooltool docs, or it's new. | 08:07 |
| tvon | It's new | 08:08 |
| tvon | now I'm going to bed, more folks will be around in 6-8 hours if you need anything else ;) | 08:08 |
| pzingg | quit | 08:29 |
| *** pzingg has quit IRC | 08:29 | |
| *** ignas has joined #schooltool | 10:20 | |
| *** ignas has quit IRC | 11:17 | |
| *** jinty has joined #schooltool | 11:56 | |
| *** ignas has joined #schooltool | 12:04 | |
| povbot | /svn/commits: * jinty committed revision 4711: | 12:34 |
| povbot | /svn/commits: Merged 4962:4964 for issue 328. | 12:34 |
| povbot | /svn/commits: * tvon committed revision 4712: | 12:37 |
| povbot | /svn/commits: passing search results through batch navigation links so we can batch our searches properly. Also provide a 'clear' button with our search to get back to the normal view. | 12:37 |
| povbot | /svn/commits: Please backport, fixes issue335 and the rest of issue334 (along with the next commit) | 12:37 |
| povbot | /svn/commits: * tvon committed revision 4713: | 12:38 |
| povbot | /svn/commits: Fixes issue335 and the rest of issue334 for schooltool | 12:38 |
| povbot | /svn/commits: Please backport. | 12:38 |
| povbot | /svn/commits: * jinty committed revision 4714: | 12:41 |
| povbot | /svn/commits: Back-ported 4673. | 12:41 |
| povbot | /svn/commits: * jinty committed revision 4715: | 12:43 |
| povbot | /svn/commits: Back-ported 4674. | 12:43 |
| povbot | /svn/commits: * tvon committed revision 4716: | 12:55 |
| povbot | /svn/commits: whoops, tests that should have gone in with 4712 | 12:55 |
| povbot | /svn/commits: * jinty committed revision 4717: | 12:56 |
| povbot | /svn/commits: Back-port 4678 for http://issues.schooltool.org/issue338 | 12:56 |
| tvon | dammit | 13:01 |
| povbot | /svn/commits: * tvon committed revision 4718: | 13:01 |
| povbot | /svn/commits: uhm, and the test for 4713 | 13:01 |
| *** mgedmin has joined #schooltool | 13:22 | |
| *** gintas has joined #schooltool | 13:24 | |
| gintas | jinty, thanks for your help with the release | 13:26 |
| *** bskahan has joined #schooltool | 14:24 | |
| *** gintas has quit IRC | 14:25 | |
| bskahan | does anyone else get an ftest failure on errors.txt in trunk? | 14:51 |
| bskahan | i only get it when I run the tests -uf on schoolbell and schooltool concurrently | 14:56 |
| *** ignas has quit IRC | 14:56 | |
| mgedmin | buildbot doesn't | 14:56 |
| mgedmin | what sort of failure is it? | 14:56 |
| mgedmin | very interesting | 14:57 |
| mgedmin | paste.plone.org? | 14:57 |
| mgedmin | I'd like to see the traceback | 14:57 |
| * bskahan nods | 14:57 | |
| bskahan | http://paste.plone.org/3306 | 14:58 |
| mgedmin | whoa! | 14:59 |
| mgedmin | ConnectionStateError: Shouldn't load state for 0x07 when the connection is closed | 14:59 |
| srichter | shrug | 14:59 |
| srichter | your DB is hosed | 14:59 |
| bskahan | ./test.py -uf | 15:00 |
| mgedmin | while providing an adapter in a functional test? | 15:00 |
| bskahan | in schooltool | 15:00 |
| mgedmin | why does ztapi.browserView even touch ZODB? | 15:00 |
| bskahan | specifying schoolbell or schooltool doesn't raise it | 15:00 |
| mgedmin | it is certainly caused by some test that does not clean up after itself | 15:01 |
| bskahan | so I'm guessing its a test that isn't cleaned up somewhere ... | 15:01 |
| bskahan | heh | 15:01 |
| mgedmin | does it happen if you run ./test.py -f (without -u)? | 15:01 |
| bskahan | no | 15:01 |
| mgedmin | ah | 15:01 |
| mgedmin | no, no 'ah' | 15:09 |
| mgedmin | I do not understand | 15:09 |
| mgedmin | the test runner runs functional tests first | 15:09 |
| mgedmin | (because unit tests will damage all setup done by ftesting.zcml) | 15:09 |
| mgedmin | ./test.py -fupv works here | 15:12 |
| mgedmin | Ran 735 tests in 75.921s | 15:12 |
| mgedmin | no errors/failures | 15:12 |
| * mgedmin shrugs | 15:12 | |
| bskahan | wierd | 15:12 |
| bskahan | thanks for checking | 15:12 |
| mgedmin | it might be timing related perhaps? | 15:14 |
| bskahan | I'm going to get a fresh tree and see if I still get it | 15:15 |
| mgedmin | I've seen it before | 15:17 |
| mgedmin | not on my machine, but reports about this exception | 15:17 |
| *** gintas has joined #schooltool | 15:19 | |
| jinty | hoi gintas, no worries. currently Im looking at 4682 | 15:20 |
| bskahan | mgedmin: got the same error on a fresh checkout, must be machine specific | 15:22 |
| mgedmin | to fix issue 341 for the release, please merge 4686, [4687], 4688, 4689 to schoolbell's release branch, and 4690 to schooltool's release branch | 15:24 |
| mgedmin | 4687 is optional -- it removes a DeprecationWarning | 15:25 |
| mgedmin | gintas says he has seen this ConnectionStateError on Windows | 15:25 |
| * mgedmin is going to resurrect checks.py from schooltool-twisted-branch | 15:25 | |
| bskahan | mgedmin: what is checks.py? | 15:27 |
| gintas | it's a collection of functons that check that tests clean up after theirselves | 15:28 |
| gintas | jinty, I'm still not sure I understand what you are proposing with regard to .debs | 15:28 |
| gintas | are you suggesting releasing debs that depend on zope3-lib? | 15:29 |
| gintas | I think it's a better idea to release the current package (with Zope3 inside) | 15:30 |
| gintas | later we can release 1.2-2 which uses the new scheme | 15:30 |
| bskahan | gintas: I think the idea was that we can't get into ubuntu main if we have zope in the package | 15:31 |
| mgedmin | oh? why? | 15:32 |
| jinty | gintas: you understood correctly. My reasoning is that the tests are run at build time using the installed zope3-lib, if they fail, the build fails. | 15:32 |
| mgedmin | oh, security reasons | 15:32 |
| jinty | but I defer to your decision | 15:33 |
| povbot | /svn/commits: * mg committed revision 4719: | 15:34 |
| povbot | /svn/commits: Resurrected checks.py from schooltool-twisted-branch (minus old ComponentChecks). Fixed a unit test that expected sys.stderr to be unwrapped. | 15:34 |
| * mgedmin suggests merging 4720 -- another DeprecationWarning | 15:34 | |
| povbot | /svn/commits: * mg committed revision 4720: | 15:35 |
| povbot | /svn/commits: Fixed another DeprecationWarning. | 15:35 |
| povbot | /svn/commits: Merge candidate. | 15:35 |
| * jinty will probably upload 1.2-1 (with zope) to unstable and 1.2-2 to experimental (without zope) | 15:35 | |
| bskahan | on a fresh checkout, lots of ftests fail because the page headers are getting produced as: | 15:36 |
| bskahan | - Content-Type: text/xml; charset=UTF-8 | 15:36 |
| bskahan | ? ^ - ^^^ | 15:36 |
| bskahan | + Content-Type: text/html;charset=utf-8 | 15:36 |
| mgedmin | bskahan, I don't see those | 15:37 |
| * bskahan goes to investigate | 15:38 | |
| bskahan | maybe my computer is just hosed | 15:38 |
| bskahan | that was svn co; cd st-new; make; ./test.py -pvuf | 15:39 |
| mgedmin | bskahan, I suggest you use 'make test ftest' | 15:40 |
| mgedmin | I do not entirely trust test -fu | 15:40 |
| bskahan | ok | 15:40 |
| mgedmin | otoh it would be really good to identify why test -fu sometimes fails when test -f; test -u doesn't | 15:41 |
| * mgedmin has a zcml i18n question | 15:41 | |
| bskahan | still seeing that error on make test ftest | 15:42 |
| mgedmin | oh? interesting... | 15:43 |
| mgedmin | very interesting | 15:43 |
| jinty | bskahan: I think 4680 is also necessary to back port 4682. agree? | 15:43 |
| bskahan | jinty: one sec, I'll look | 15:44 |
| gintas | don't forget 3723, 8928, 2939, 1239, 4884, 8585 and 7$%^ | 15:44 |
| gintas | these heaps of numbers are getting to me | 15:44 |
| * jinty is glad there is somebody to share the pain;) | 15:45 | |
| mgedmin | we had a process for this | 15:45 |
| mgedmin | issue tracker, tags, lists of revisions pertaining for each issue | 15:46 |
| mgedmin | make extract-translations fails | 15:46 |
| bskahan | jinty: 4680 and 4682 conflicted, 4682 wipes out 4680 | 15:47 |
| povbot | /svn/commits: * srichter committed revision 4721: | 15:47 |
| povbot | /svn/commits: Added a couple tests from schooltool. | 15:47 |
| jinty | if people agree, I am completely prepared to start ignoring back-port requests not made strictly according to the process | 15:47 |
| jinty | ;) | 15:48 |
| bskahan | jinty: I think that's a good idea | 15:48 |
| jinty | really? | 15:48 |
| mgedmin | can we ask everyone to look at his checkins since the release branch was made, and make sure that ones that need merging are listed in the issue tracker? | 15:48 |
| * jinty is +1 for issue tracker + schooltool 0.xx tags | 15:49 | |
| mgedmin | which translation is most complete? | 15:50 |
| * jinty thinks es_ES for schoolbell might be quite complete | 15:51 | |
| bskahan | jinty: I added a bug that referes to 4682/4695 | 15:53 |
| bskahan | http://issues.schooltool.org/issue343 | 15:53 |
| bskahan | that's the only one revision I know of that didn't have a specific issue | 15:54 |
| bskahan | mgedmin: do we have the release cycle process written down? | 15:55 |
| mgedmin | we had something like that, I think | 15:56 |
| * mgedmin doesn't understand | 15:56 | |
| mgedmin | lang es_ES doesn't seem to work in schoolbell.conf | 15:57 |
| * jinty goes on 15min typing break | 15:58 | |
| gintas | what do you think about rev 4654? (generation script to make schooltool's application calendar public and set security policy to the 0.11 defaults) | 16:00 |
| bskahan | gintas: I was initially opposed to it being backported | 16:01 |
| bskahan | but after some thought I think it should | 16:01 |
| bskahan | if it isn't applied, then the top level url will always kick to the login page unless the admin changes ACL on the root/root calendar | 16:02 |
| gintas | exactly | 16:02 |
| bskahan | doing that, without going through and explicitly closing the containers, will open the site up to the public | 16:02 |
| bskahan | the generation at least makes shure /persons/ is denied | 16:03 |
| bskahan | s/shure/sure | 16:03 |
| gintas | OK, I'll backport it then | 16:03 |
| mgedmin | is there an issue for deprecation warning cleanups? | 16:03 |
| povbot | /svn/commits: * mg committed revision 4722: | 16:04 |
| povbot | /svn/commits: Fix DeprecationWarnings about missing i18n_domain in SCHOOLBELL_SITE_DEFINITION. | 16:04 |
| povbot | /svn/commits: Fix incorrect i18n translation of principal names -- ZCML does i18n by itself, you don't have to explicitly translate them before specifying them in.ZCML. | 16:04 |
| povbot | /svn/commits: I should have written a unit test for this, but I do not know how. | 16:04 |
| bskahan | gintas: can we trigger a debian package install alert that the permissions have changed? | 16:04 |
| bskahan | changing security policy silently is still pretty rotten | 16:05 |
| gintas | hmm | 16:05 |
| gintas | it's possible | 16:05 |
| mgedmin | NEWS.Debian.gz? | 16:05 |
| gintas | but this will only work for Debian | 16:05 |
| bskahan | it can be in the release notes (for people running from tarballs) | 16:06 |
| gintas | right | 16:06 |
| bskahan | and I'll ask eric if we can do something similar for RPMs (though I don't recall ever seeing something like that) | 16:06 |
| mgedmin | bskahan, can you please svn up and run ./tests.py -fu | 16:09 |
| gintas | hmm, doesn't this permission change apply to schoolbell as well? | 16:09 |
| mgedmin | I've added checks.py -- they will notice if you leave unclean transactions | 16:10 |
| bskahan | gintas: no | 16:10 |
| povbot | /svn/commits: * mg committed revision 4723: | 16:10 |
| povbot | /svn/commits: Removed DeprecationWarning, fixed incorrect i18n translation. The equivalent of rev 4722, but for schooltool. | 16:10 |
| bskahan | mgedmin: no mention of unclean transations | 16:12 |
| bskahan | still have the errors.txt failure | 16:13 |
| mgedmin | I wish there was a way to figure out whether a test crapped in the component architecture configuration | 16:16 |
| mgedmin | but adapter registry's internals are so obfuscated, that you essentially cannot take a snapshot of the state and compare it to another state later | 16:17 |
| povbot | /svn/commits: * jinty committed revision 4724: | 16:19 |
| povbot | /svn/commits: Back-ported 4679:4682 and 4695 for http://issues.schooltool.org/issue343 | 16:19 |
| jinty | gintas: I'm working on 341 now. | 16:21 |
| bskahan | mgedmin: what revision of Zope are you using with schooltool? | 16:21 |
| mgedmin | let me check | 16:23 |
| bskahan | thanks | 16:23 |
| mgedmin | svn://svn.zope.org/repos/main/Zope3/branches/Zope-3.1, revision 37885 | 16:23 |
| gintas | hmm, bskahan, that evolve script in rev 4654 does not have tests | 16:23 |
| bskahan | gintas: what sort of tests would you like for it? | 16:23 |
| gintas | well, in other projects we had tests for evolve scripts | 16:24 |
| gintas | but they're really messy | 16:24 |
| bskahan | I don't think any of our evolve scripts have tests | 16:24 |
| gintas | I assume you have tested the evolution script carefully | 16:24 |
| gintas | bskahan, I don't mean to imply that you should have written a test | 16:25 |
| bskahan | yes, I'd be very happy to add tests for it too | 16:25 |
| gintas | I am just wary of checking in untested code (Python's a dynamic language and all...) | 16:25 |
| gintas | I'll do a manual test and then commit | 16:26 |
| bskahan | I'd like a good way to test generations | 16:26 |
| bskahan | at least functionally | 16:26 |
| gintas | in that other project we had a heap of stubs that we would give the 'evolve' function | 16:27 |
| gintas | but I think that we don't have time to do this now | 16:27 |
| gintas | there's a heap of other checkins waiting | 16:27 |
| *** ignas has joined #schooltool | 16:27 | |
| bskahan | i like marius' idea of having sample data.fs for each release in svn | 16:28 |
| * mgedmin does svn up Zope3 | 16:28 | |
| gintas | yes, sounds good | 16:28 |
| povbot | /svn/commits: * srichter committed revision 4725: | 16:28 |
| povbot | /svn/commits: Okay, we cannot use the standard ContainerTraverser, since it also tries to lookup a view. This is really a sign that the default traverser implementation is less than ideal. | 16:28 |
| mgedmin | whoa, massive failures everywhere | 16:28 |
| mgedmin | thank you, Zope 3, we needed that on the final release day | 16:28 |
| mgedmin | BTW one of the reasons I suffered svn:externals was that it ensured all developers had the same version of Zope 3 (assuming they did svn up) | 16:28 |
| mgedmin | failures=12 | 16:28 |
| bskahan | mgedmin: oh good | 16:29 |
| gintas | you mean the Zope-3.1 branch is wedged? | 16:29 |
| bskahan | I thought I was going crazy | 16:29 |
| mgedmin | bskahan, no, that is not good | 16:30 |
| bskahan | :\ | 16:30 |
| mgedmin | gintas, the newest Zope 3.1 breaks 12 of our ftests | 16:30 |
| bskahan | yeah, but I though it was just me | 16:30 |
| bskahan | the html header format changed | 16:30 |
| mgedmin | note that buildbot doesn't update Zope 3 -- it used to rely on svn:externals, but there are no more externals | 16:31 |
| bskahan | and its breaking something fierce in the REST interface | 16:31 |
| mgedmin | bskahan, I see 500 internal server errors everywhere | 16:31 |
| gintas | ha | 16:31 |
| bskahan | I think that's the REST pages | 16:32 |
| gintas | so I was right about binding to a specific revision | 16:32 |
| mgedmin | and instead of REST pages I see browser pages | 16:32 |
| bskahan | ugh | 16:32 |
| povbot | /svn/commits: * gintas committed revision 4726: | 16:36 |
| povbot | /svn/commits: Backported revision 4654 (evolution script for new permission policy where the site-wide calendar is public and all containers are closed down explicitly). | 16:36 |
| povbot | /svn/commits: A note about this change in the release notes would be nice. | 16:36 |
| mgedmin | http://issues.schooltool.org/issue344 lists revisions that get rid of deprecation warnings | 16:36 |
| gintas | yay | 16:37 |
| mgedmin | (possibly not all of them -- just those that I made) | 16:38 |
| povbot | /svn/commits: * jinty committed revision 4727: | 16:38 |
| povbot | /svn/commits: Back-ported 4685:4689 to release branch for issue 341. | 16:38 |
| gintas | I'm thinking about backporting 4703 together with 4687 and 4695 | 16:39 |
| gintas | bskahan writes: There is an ftest for this in r4703, but that also includes a security policy change that I don't think should be moved to the release branch this late. | 16:39 |
| gintas | I think that the change is small enough to be backported | 16:39 |
| gintas | and the result is worth it | 16:40 |
| gintas | <content class=".TimetableDict"> | 16:40 |
| gintas | <require permission="schoolbell.edit" | 16:40 |
| gintas | - interface="zope.app.container.interfaces.IContainer" /> | 16:40 |
| gintas | + interface="zope.app.container.interfaces.IWriteContainer" /> | 16:40 |
| gintas | + <require permission="schoolbell.view" | 16:40 |
| gintas | + interface="zope.app.container.interfaces.IReadContainer" /> | 16:40 |
| gintas | </content> | 16:40 |
| bskahan | gintas: the change is small, but it is a feature addition with a security change between RC3 and final | 16:41 |
| bskahan | if you and jinty agree on it though | 16:42 |
| gintas | well, thing is that we will not be doing releases for a while | 16:43 |
| * jinty is not the release manager for this release, meerly helping out with the obvious | 16:43 | |
| gintas | this is a once-a-year shot, I'd like to have it as polished as possible | 16:43 |
| mgedmin | do I fix the ftests now, or do I revert to an older Z3 snapshot and help with merging/etc? | 16:45 |
| bskahan | mgedmin: this implies that we can't depend on zope 3.1 branch being stable enough not to break schooltool | 16:46 |
| bskahan | do we want to move back to a particular zope revision? | 16:47 |
| * mgedmin wishes srichter said something | 16:47 | |
| gintas | we don't have an external | 16:47 |
| srichter | ok, I did not follow | 16:47 |
| srichter | I am having deep issue with my code | 16:47 |
| gintas | I say just grab a several-day old revision that works and let's put this aside for now | 16:47 |
| srichter | hold on, I'll read on | 16:48 |
| povbot | /svn/commits: * jinty committed revision 4728: | 16:48 |
| povbot | /svn/commits: Back-ported 4689:4690 to release branch for issue 341. | 16:48 |
| bskahan | I really would like to get zope 3.1 bug fixes for the next year | 16:49 |
| srichter | what failures do you guys get? | 16:49 |
| mgedmin | srichter, briefly, some recent change in Zope 3.1 branch broke something | 16:49 |
| mgedmin | one of the failures is | 16:49 |
| srichter | (btw, I think stuart's HTTP header fix is correct) | 16:49 |
| mgedmin | TypeError: mapply() can not call <schoolbell.app.rest.acl.ACLTraverser object at 0xb580b8ec> | 16:49 |
| srichter | boah | 16:49 |
| mgedmin | rev 37885 worked, rev 37961 broke | 16:50 |
| srichter | so we have to look at stuart's changes more carefully? | 16:50 |
| mgedmin | what was changed in Z3.1 recently? | 16:50 |
| mgedmin | I saw that functional.py was updated | 16:50 |
| mgedmin | and some http code | 16:50 |
| srichter | Stuart fixed the behavior when having multiple HTTP headers | 16:50 |
| srichter | like: | 16:50 |
| srichter | x-foo: 1 | 16:50 |
| srichter | x-foo: 2 | 16:50 |
| povbot | /svn/commits: * gintas committed revision 4729: | 16:50 |
| povbot | /svn/commits: Cosmetic fixes, added svn:keywords. | 16:50 |
| srichter | becomes x-foo: 1, 2 | 16:51 |
| srichter | I am updating ST right now to check out the failures | 16:52 |
| bskahan | I'll be back in 30 minutes | 16:52 |
| *** bskahan has quit IRC | 16:53 | |
| mgedmin | I suspect http://z3c.pov.lt/20050815210935.208B32033DD@mail.zope.org | 16:53 |
| srichter | DAMN, I wish I would not have approved this | 16:54 |
| srichter | I think I actually did not | 16:55 |
| mgedmin | I'll try to run tests with that checkin reverted and see if it helps | 16:55 |
| mgedmin | we need change the request class for our RESTive requests | 16:55 |
| srichter | right | 16:56 |
| mgedmin | srichter, if you have a moment, take a look at src/schoolbell/rest/ftests/__init__.py | 16:59 |
| srichter | yep | 16:59 |
| mgedmin | all we need to do is to make GET requests in functional doctests, but use HTTPRequest rather than BrowserRequest | 16:59 |
| srichter | (BTW, I was just about to discover this problem myself, since this is exactely the same deep issue I was looking at ;-) | 17:00 |
| mgedmin | :) | 17:01 |
| gintas | I'm backporting 4703 | 17:02 |
| povbot | /svn/commits: * gintas committed revision 4730: | 17:07 |
| povbot | /svn/commits: Backported 4703. | 17:07 |
| povbot | /svn/commits: This is a controversial change because it affects the security policy a little bit (see change in timetable/configure.zcml), but I think that it would be very nice to have this in 0.11. | 17:07 |
| srichter | whee, I hope benji is done soon with this | 17:13 |
| *** bskahan has joined #schooltool | 17:16 | |
| srichter | ok, that seems to fix the problem | 17:17 |
| srichter | I have tried this on my refactor branch and the tests go on for a while longer | 17:18 |
| mgedmin | as a workaround I did cd Zope3 && svn merge 37948:37947 . | 17:19 |
| mgedmin | all tests pass | 17:19 |
| srichter | ok | 17:19 |
| srichter | we just need to verify that the fix benji is checking in still has all the tests pass | 17:19 |
| gintas | what can we do about issue 323? http://issues.schooltool.org/issue323 | 17:19 |
| gintas | hoffman says: Actually, the way it is now (rc3) kicks people back to the front page WAY to much. It is super confusing. | 17:20 |
| srichter | btw, eventually we should create an IRestRequest interface and RestRequest class | 17:20 |
| gintas | I'll take tvon's new checkins: 4693, 4696, 4697, 4698, 4699, 4700, 4701, 4708, 4709 and 4710 | 17:21 |
| srichter | this way views registered for REST (pure HTTP) don't accidentily crop into the browser | 17:21 |
| *** tvon has quit IRC | 17:22 | |
| ignas | would have done this in the first place yet we had a bug in our skin code that made me try a few different approaches, and HTTP request was the one that was implemented when gintas found the bug | 17:23 |
| mgedmin | we had a IRestRequest once, I think | 17:23 |
| mgedmin | somebody decided it wasn't necessary and refactored it out | 17:24 |
| povbot | /svn/commits: * mg committed revision 4731: | 17:24 |
| povbot | /svn/commits: Spacing | 17:24 |
| srichter | (I think this was a bad decision ;-) | 17:25 |
| ignas | srichter, you should have been there when we were debuging the code ;) | 17:26 |
| srichter | I would think that IRestRequest would make it easier to debug | 17:26 |
| povbot | /svn/commits: * mg committed revision 4732: | 17:27 |
| povbot | /svn/commits: Fix nondeterministic test failures (issue 340). | 17:27 |
| povbot | /svn/commits: Note that the placement of sections that happen simultaneously (i.e. scheduling conflicts) remains nondeterministic in the real user interface. I think that's not a problem. | 17:27 |
| ignas | well - the syptom of the bug was - in some cases we had rest specific traversers working and in some cases - not | 17:28 |
| ignas | changing the request to HTTP one was making it work in more places ;) | 17:28 |
| mgedmin | ignas, it is irrelevant | 17:28 |
| ignas | True | 17:28 |
| mgedmin | that's a conceptual decision -- is a RESTive request something new, or is that just a plain old HTTP request/ | 17:29 |
| gintas | doesn't really matter | 17:29 |
| mgedmin | ? | 17:29 |
| gintas | right now at least | 17:29 |
| mgedmin | alga argued that it is just an HTTP request | 17:29 |
| mgedmin | I had no strong opinion one way or another | 17:29 |
| srichter | ignas: yeah, and that is exactely the problem | 17:29 |
| srichter | now you use browser traversers for HTTP :-( | 17:29 |
| mgedmin | I do not believe anybody raised srichter's argument -- preventing RESTive views from cropping up in Browser UI | 17:29 |
| srichter | but I fixed most of this already ;-) | 17:29 |
| mgedmin | gintas, is issue 340 (rev 4732) worth backporting? I leave the decision to you | 17:30 |
| srichter | I think it is more than a plain HTTP request, because we have definitely expected semantics | 17:31 |
| mgedmin | srichter, the whole philosophy of REST is that you use plain HTTP requests rather than building something complicated on top | 17:31 |
| mgedmin | this might translate into Zope3-land as "IRestRequest is an HTTP request that is used for RESTive API" | 17:32 |
| srichter | yeah, but it becomes more complicated, because now the lines are blurred | 17:32 |
| mgedmin | but the temptation of just using HTTP requests ("because that's what REST means!") is great | 17:32 |
| gintas | jinty, I'm backporting 4713 right now | 17:32 |
| srichter | pretty much all HTTP protocols now have REST views | 17:32 |
| * jinty urges anyone who checked in depreciation warning fixes to add them to issue 344 for back-porting | 17:33 | |
| * mgedmin ran out of things to do | 17:33 | |
| jinty | gintas: anything you want me to take a look at? | 17:33 |
| gintas | let's see | 17:33 |
| mgedmin | gintas, $same_question | 17:33 |
| srichter | also, most REST views are registered for IPublishTraverse, which is even worse | 17:34 |
| srichter | now RESTive views will be available even in FTP | 17:34 |
| srichter | (I fixed that on the way as much as I could) | 17:35 |
| gintas | hmm, issue330 is for me probably | 17:35 |
| gintas | jinty, you can merge fixes in http://issues.schooltool.org/issue334, I think | 17:36 |
| jinty | gintas: ok, i'll have a look | 17:37 |
| mgedmin | am I the only one who thinks issue numbers ought to have a checksum digit? | 17:38 |
| gintas | hmm, I'm starting to think that we will be able to release today after all | 17:38 |
| jinty | mgedmin: no, some debian developers also want it for debian bugs, they have 6 digits to get right... | 17:40 |
| gintas | is 4706 backported? | 17:40 |
| gintas | looks like it is not | 17:43 |
| gintas | by the way, jinty, have you backported 4673 & 4674? | 17:45 |
| gintas | I haven't looked into them deeply, if you know they're simple enough, feel free | 17:46 |
| povbot | /svn/commits: * srichter committed revision 4733: | 17:48 |
| povbot | /svn/commits: Update schooltool to the new packaging structure and traverser code in schoolbell. The pluggable traverser worked great and did not cause any troubles. | 17:48 |
| jinty | gintas: yep, back-ported them this morning. | 17:49 |
| gintas | great | 17:51 |
| mgedmin | ignas, take a look at http://source.schooltool.org/viewcvs/branches/schoolbell-1.0.x/db-conversion-tests/ | 17:52 |
| jinty | gintas: looks like issue 334 & 335 are going to need a huge swathe of back-ports, starting from at least 4696. If you want it I can make a non-conflicting patch (and revision numbers) and submit it to the issue tracker for review first. | 17:59 |
| gintas | hmm | 18:02 |
| gintas | I'm still wrestling with 4712 ;( | 18:02 |
| gintas | umm, tvon writes: As of r4699 next/previous now show appropriate numbers (they indicate the batch | 18:03 |
| gintas | size on most pages, or the remainder when there are fewer items than the batch | 18:03 |
| gintas | size). | 18:03 |
| gintas | have we backported changes "up to 4699"? | 18:04 |
| jinty | thats the problem | 18:04 |
| jinty | no | 18:04 |
| jinty | we are also missing quite a few tests, some committed in 4696. (README.txt). | 18:05 |
| gintas | I think we have everything up to 4696 | 18:06 |
| gintas | (excluding that one) | 18:06 |
| gintas | ow | 18:08 |
| gintas | 4699 touches membership.txt which we don't have in the branch at all | 18:08 |
| jinty | that's what I was about to say. | 18:08 |
| mgedmin | it's just an ftest | 18:09 |
| mgedmin | otoh... I see your point | 18:09 |
| mgedmin | 9how do you verify that the backport works?) | 18:09 |
| gintas | it was added in r4688 | 18:10 |
| gintas | I'll fix this | 18:10 |
| srichter | which objects can have timetables again? person. group, resource, term, course, section? | 18:11 |
| srichter | their containers too? | 18:11 |
| mgedmin | ITimetabled objects | 18:11 |
| mgedmin | I think containers have no timetables | 18:12 |
| srichter | well, my branch does not have this directly implemented anymore | 18:12 |
| mgedmin | (unless people who added a schoolwide calendar added a schoolwide timetable as well) | 18:12 |
| srichter | ok | 18:12 |
| mgedmin | can apidoc list all known classes that implement a given interface? | 18:12 |
| * jinty waits for membership.txt before attacking 334 again | 18:12 | |
| srichter | yes | 18:12 |
| srichter | it is part of the interface details view | 18:13 |
| mgedmin | membership.txt appeared in rev 4688 | 18:14 |
| mgedmin | oh, gintas is already on it | 18:14 |
| mgedmin | sorry | 18:14 |
| povbot | /svn/commits: * gintas committed revision 4734: | 18:15 |
| povbot | /svn/commits: Backported rev 4688, which adds the functional test membership.txt. Later changes modify this doctest. | 18:15 |
| gintas | jinty, you can then merge the changes outlined in issue 334, I'll examine your commit and then see what's missing | 18:18 |
| gintas | we want that stuff merged anyway | 18:18 |
| jinty | cool, I'll get to it after my typing break | 18:18 |
| gintas | ok | 18:18 |
| gintas | I'll check out 330 then | 18:19 |
| gintas | jinty, how's it going? | 18:26 |
| *** tvon has joined #schooltool | 18:32 | |
| gintas | hi tvon | 18:34 |
| tvon | hey gintas | 18:35 |
| tvon | gintas: whats up with 334? | 18:37 |
| jinty | gintas: just starting | 18:37 |
| gintas | tvon, jinty's working on backporting all the stuff | 18:38 |
| tvon | ah, okay | 18:38 |
| gintas | but I just found a supposedly major problem (see issue345) | 18:38 |
| gintas | I don't think we'll be able to release today, I really want to test this whole thing manually | 18:39 |
| gintas | hmm | 18:39 |
| gintas | maybe that bug is bogus | 18:39 |
| gintas | otoh, it's not | 18:40 |
| tvon | hrm | 18:40 |
| tvon | 'tomorrows events' portlet maybe | 18:43 |
| bskahan | gintas: I can't recreate that bug | 18:48 |
| tvon | I can | 18:48 |
| * tvon tries wiping data.fs | 18:48 | |
| tvon | I still getit | 18:50 |
| tvon | get it | 18:50 |
| tvon | Its only with recurring events, if you turn that off again it's okay | 18:51 |
| bskahan | what Recurrence are you using? | 18:51 |
| tvon | just 'repeat until' | 18:51 |
| tvon | (this is in SB, havent tried ST) | 18:52 |
| bskahan | testing in schooltool | 18:52 |
| bskahan | I'll try in SB | 18:52 |
| tvon | hrm | 18:52 |
| * mgedmin trying to reproduce it in SB too | 18:53 | |
| mgedmin | Unauthorized: (<zope.app.pagetemplate.simpleviewclass.SimpleViewClass from /home/mg/src/schoolbell/src/schoolbell/app/browser/templates/cal_daily.pt object at 0xb12fd78c>, 'browserDefault', 'schoolbell.viewCalendar') | 18:53 |
| mgedmin | whaaa? this makes no sense! | 18:53 |
| tvon | mgedmin: I was getting an error on 'allday' access | 18:53 |
| mgedmin | tvon, aha! | 18:53 |
| tvon | Unauthorized: (<schoolbell.calendar.mixins.ExpandedCalendarEvent object at 0xb14a056c>, 'allday', 'schoolbell.view') | 18:53 |
| mgedmin | go to src/schoolbell/app/configure.zcml | 18:54 |
| mgedmin | line 258 | 18:54 |
| mgedmin | change attributes="resources" to attributes="resources allday", try again | 18:54 |
| mgedmin | no, don't | 18:54 |
| tvon | heh | 18:55 |
| tvon | bskahan: you fixed a site-wide calendar permissions bug in ST, right? | 18:56 |
| bskahan | yes | 18:57 |
| * tvon thinks the permissions are set differently in SB (and probably wrongly) | 18:57 | |
| mgedmin | missing __parent__ somewhere? | 18:57 |
| bskahan | just reproduced it in SB trunk | 18:57 |
| gintas | * Module schoolbell.app.browser.cal, line 550, in getEvents | 18:57 |
| gintas | if (removeSecurityProxy(event.__parent__) is removeSecurityProxy(self.context) and | 18:57 |
| gintas | Unauthorized: (<schoolbell.calendar.mixins.ExpandedCalendarEvent object at 0xb123216c>, 'allday', 'schoolbell.view') | 18:57 |
| mgedmin | interesting... | 18:58 |
| mgedmin | AAARGH | 18:58 |
| tvon | no, its the ACL | 18:59 |
| tvon | in SB I set the ACL on app.calendar, not app | 18:59 |
| mgedmin | no, no argh | 18:59 |
| mgedmin | the ACL indicates that Unauthenticated users have no permissions at all | 18:59 |
| mgedmin | why can they see nonrecurring events then? | 18:59 |
| mgedmin | should I rm my Data.fs? | 18:59 |
| * mgedmin looking at http://localhost:7080/acl.html | 19:00 | |
| tvon | mgedmin: http://localhost:7080/calendar/acl.html | 19:00 |
| mgedmin | also empty | 19:00 |
| mgedmin | must be my data.fs | 19:00 |
| tvon | oh? thats peculiar | 19:00 |
| bskahan | tvon: they have viewCalendar on the calendar, but not 'view' | 19:01 |
| mgedmin | why does ExpandedCalendarEvent require schoolbell.view, and not schoolbell.viewCalendar? | 19:02 |
| mgedmin | bug! | 19:02 |
| mgedmin | src/schoolbell/app/configure.zcml line 257 | 19:02 |
| mgedmin | also, look around | 19:02 |
| tvon | that fixes it | 19:04 |
| mgedmin | ImmutableCalendar a few pages down also wants schoolbell.view rather than viewCalendar | 19:04 |
| gintas | I really want a functional test for this | 19:05 |
| tvon | I've started | 19:07 |
| tvon | adding recur event to site-wide and checking that it can be viewed anon | 19:07 |
| gintas | great | 19:09 |
| gintas | I would like to leave in a few minutes | 19:10 |
| tvon | almost there | 19:10 |
| gintas | I will probably be back online in a few hours and will try to solve some of the remaining problems | 19:10 |
| gintas | tvon, that's OK, it's obvious that I won't release today | 19:10 |
| tvon | okay | 19:11 |
| gintas | there aren't too many revisions to be backported; hopefully all of these can be covered today | 19:11 |
| gintas | I still want to do some clickety-click testing after everything is backported | 19:11 |
| jinty | aargh the patches for 334 break schoolbell/app/browser/ftests/app.txt | 19:11 |
| gintas | to catch the likes of issue345 | 19:12 |
| gintas | jinty, if you have a reasonable cumulative patch, you can upload it to the issue tracker | 19:12 |
| gintas | and I'll have a closer look and figure out the gory details | 19:12 |
| gintas | (hopefully) | 19:12 |
| bskahan | jinty: can you paste.plone.org the app.txt failure? | 19:13 |
| * mgedmin is feeling very disoriented | 19:13 | |
| gintas | mgedmin, you're not the only one | 19:13 |
| jinty | bskahan: http://paste.plone.org/3311 | 19:14 |
| bskahan | jinty: thanks | 19:14 |
| jinty | I am probably missing a revision somewhere... | 19:15 |
| *** gintas has quit IRC | 19:25 | |
| jinty | bskahan: now it passes... huh... guess its time to stop for the day | 19:28 |
| jinty | gintas: I compiled a list of revisions for 344 (safer than patches as files are being added). they merge cleanly and all tests pass, I think. Possibly the list is too complete. | 19:31 |
| ignas | gintas has quit | 19:31 |
| jinty | oops, hope he reads the logs. | 19:32 |
| jinty | night! | 19:32 |
| *** jinty has quit IRC | 19:32 | |
| mgedmin | I home jinty added that list to the issue itself | 19:33 |
| mgedmin | nope :( | 19:34 |
| povbot | /svn/commits: * tvon committed revision 4735: | 19:38 |
| povbot | /svn/commits: fix for ExpandedCalendarEvent permissions in issue345 | 19:38 |
| ignas | emm cr*p | 19:40 |
| ignas | tarball release of ST does not allow one to look at calendars of resources | 19:40 |
| ignas | can someone please try and reproduce it ? | 19:40 |
| ignas | 0.10 | 19:40 |
| ignas | release tarball | 19:41 |
| mgedmin | cannot repro with current trunk | 19:46 |
| ignas | oh, found the problem - we didn't backport it | 19:46 |
| ignas | it is fixed in the trun rev4040 and rev4041 | 19:46 |
| ignas | but it was not backported, because we marked it as resolved ... | 19:47 |
| * mgedmin hasn't eaten today | 19:47 | |
| tvon | ah | 19:47 |
| mgedmin | is it present in 0.11 release branch? | 19:47 |
| ignas | guess not, it was fixed while releasing 0.10 | 19:48 |
| povbot | /svn/commits: * srichter committed revision 4736: | 19:53 |
| povbot | /svn/commits: Okay, I would have been surprised, if I would have gotten the traverser stuff right the first time. We have to be very careful that none of the traverser plugins tries to lookup a view. Views should only be looked up after all the plugins failed. Otherwise the semantics of traversal change in very unexpeced ways -- in other words I just spent 2 hours debugging this. ;-) | 19:53 |
| povbot | /svn/commits: * mg committed revision 4737: | 20:01 |
| povbot | /svn/commits: Backported Makefile changes from rev 4659: check out Zope3 if it is not there already. | 20:01 |
| povbot | /svn/commits: * mg committed revision 4738: | 20:07 |
| povbot | /svn/commits: Backported Makefile changes from rev 4659: check out Zope3 if it is not there already. | 20:07 |
| mgedmin | ok, I'm going to backport deprecation warning changes | 20:09 |
| mgedmin | um, how do you merge stuff? | 20:13 |
| mgedmin | svn merge -r 4686:4687 svn+ssh://source.schooltool.org/svn/schooltool/trunk/schoolbell . | 20:13 |
| mgedmin | doesn't | 20:13 |
| mgedmin | oh, it is already applied | 20:14 |
| mgedmin | and so is 4720 | 20:18 |
| tvon | heh | 20:19 |
| povbot | /svn/commits: * mg committed revision 4739: | 20:19 |
| povbot | /svn/commits: Merged rev 4722 -- killing deprecation warnings on startup. | 20:19 |
| ignas | tvon, and in case of heh - migration scripts do not migrate personal preferences properly ... | 20:20 |
| mgedmin | bug: schooltool-0.11.x footer says " SchoolTool Server Running SchoolTool 1.2rc " | 20:21 |
| povbot | /svn/commits: * mg committed revision 4740: | 20:22 |
| povbot | /svn/commits: Merged rev 4723 -- killing deprecation warnings on startup. | 20:22 |
| tvon | in case of heh? | 20:23 |
| mgedmin | tvon, bskahan: the revision number in the footer -- where does it come from? | 20:23 |
| tvon | schoolbell/__init__ | 20:24 |
| ignas | tvon, evolve6.py is buggy, debugging it now | 20:25 |
| tvon | mgedmin: erm, thats for schoolbell anyways | 20:25 |
| mgedmin | what??? | 20:25 |
| tvon | one sec | 20:25 |
| tvon | schooltool should come from schooltool/__init__ | 20:26 |
| mgedmin | SchoolBell 1.2 footer says " SchoolBell Server Running SchoolBell 1.2rc " -- which is fine | 20:26 |
| mgedmin | but SchoolTool says its version 1.2, which is not fine, as it is version 0.11 | 20:26 |
| ignas | evolve6.py is not migrating prefs.dateformat correctly when given a 0.10 data.fs | 20:26 |
| tvon | mgedmin: I have it, making a ftest | 20:27 |
| tvon | hrm, ideas on how I could change the version in an ftest? | 20:29 |
| srichter | right | 20:29 |
| srichter | I fixed that footer problem on the refactor branch too | 20:29 |
| mgedmin | evolve6 bug is clear | 20:30 |
| ignas | elif prefs.dateformat == 'YYYY-DD-MM': | 20:30 |
| ignas | prefs.dateformat = '%Y-%m-%d' | 20:30 |
| mgedmin | 'YYYY-DD-MM' is something exotic | 20:30 |
| mgedmin | we used to have 'YYYY-MM-DD' | 20:30 |
| mgedmin | which is ISO-8601 | 20:30 |
| mgedmin | ignas, create an issue please | 20:31 |
| mgedmin | tvon, where does the version number come from? | 20:31 |
| mgedmin | and why do you want to change it in an ftest? | 20:31 |
| tvon | ignas: whats wrong with that? | 20:32 |
| tvon | YYYY-DD-MM does not exist afaik, it changes it to yyyy-mm-dd | 20:32 |
| tvon | mgedmin: so I can test that the ftest shows the schooltool version and not the schoolbell version | 20:32 |
| mgedmin | and you do not want to hardcode a specific version in the test? | 20:33 |
| mgedmin | I suggest >>> 'SchoolTool %s' % VERSION in str(response) | 20:33 |
| tvon | that wont prove anything, in svn it will be 'SVN' for both schoolbell and schooltool | 20:34 |
| mgedmin | oh | 20:34 |
| mgedmin | heh | 20:34 |
| tvon | (afk 1 min) | 20:34 |
| mgedmin | tvon, you can do | 20:34 |
| mgedmin | >>> import schooltool | 20:35 |
| mgedmin | >>> old_version = schooltool.VERSION | 20:35 |
| mgedmin | >>> schooltool.VERSION = '(the correct version number)' | 20:35 |
| mgedmin | >>> print http("""...""") | 20:35 |
| mgedmin | ... | 20:35 |
| mgedmin | ... SchoolTool Server Running SchoolTool (the correct version number) ... | 20:35 |
| mgedmin | >>> schooltool.VERSION = old_version | 20:36 |
| povbot | /svn/commits: * ignas committed revision 4741: | 20:41 |
| povbot | /svn/commits: Fix the issue349 a bug when evolving preferences that had 'YYYY-MM-DD' set as dateformat. | 20:41 |
| povbot | /svn/commits: * srichter committed revision 4742: | 20:42 |
| povbot | /svn/commits: Changed ITimetabled to ITimetables. Also added a new IHaveTimetables interface that the content objects can implement to declare that they have timetables. | 20:42 |
| povbot | /svn/commits: * mg committed revision 4743: | 20:48 |
| povbot | /svn/commits: Backported rev 4741: fix issue 349 -- bug in database upgrades (ISO 8601 date format is not migrated correctly). | 20:48 |
| povbot | /svn/commits: It is not good that evolution scripts have no unit tests. :( | 20:48 |
| ignas | tvon, who did the section table ? | 20:53 |
| tvon | ignas: bskahan | 20:53 |
| tvon | ignas: that generation was intentional | 20:53 |
| ignas | ? | 20:54 |
| ignas | which generation ? | 20:54 |
| tvon | 4064:4065 on schoolbell.app.interfaces, personpreferences dateformat was wrongly stored as YYYY-DD-MM, the generation fixes it by changing it to %y-%m-%d | 20:54 |
| tvon | http://source.schooltool.org/viewcvs/trunk/schoolbell/src/schoolbell/app/interfaces.py?r1=text&tr1=4064&r2=text&tr2=4065&diff_format=h | 20:55 |
| tvon | ignas: I might be misunderstanding what you did | 20:55 |
| ignas | tvon, well what I did was get the 0.10 tarball, create some stuff | 20:56 |
| ignas | and put the data.fs for current release as a base... | 20:56 |
| mgedmin | ignas, tvon: perhaps you need to convert both 'YYYY-MM-DD' and 'YYYY-DD-MM' into '%Y-%m-%d' | 20:56 |
| ignas | and well - apparently default preferences are stored as YYY-MM-DD | 20:56 |
| ignas | oh | 20:56 |
| ignas | ouch | 20:56 |
| tvon | ahhh | 20:56 |
| mgedmin | reopening the issue | 20:57 |
| tvon | so a new generation to do YYYY-MM-DD -> %Y-%m-%d then? | 20:57 |
| ignas | next time please put a comment near the code that looks outright buggy ... | 20:58 |
| mgedmin | it's OK to change existing evolution scripts, if they were not present in any previous release | 20:58 |
| tvon | ignas: nod | 20:58 |
| mgedmin | I guess evolve6.py was present in rc2, so there's a strong argument to not touch it | 20:58 |
| mgedmin | tvon, I created http://issues.schooltool.org/issue350 for the version issue | 20:59 |
| mgedmin | I assumed you were working on it | 20:59 |
| ignas | well, imho we should change it because it was buggy after all - the default pref for all the users was YYYY-MM-DD, yet the one you could select when modifying your preferences is YYYY-DD-MM | 20:59 |
| povbot | /svn/commits: * mg committed revision 4744: | 21:00 |
| povbot | /svn/commits: Reverting incorrect backport. See http://issues.schooltool.org/issue349 for more info. | 21:00 |
| mgedmin | ignas, create evolve${N+1}.py that converts YYYY-MM-DD | 21:00 |
| mgedmin | so that people who upgrade 0.10 -> 0.11rc2 -> 0.11 final will not be screwed | 21:00 |
| ignas | i still get it :D | 21:01 |
| tvon | mgedmin: yeah, thanks | 21:01 |
| mgedmin | ignas, can you revert 4741, and also add a comment in evolve6 that YYYY-DD-MM is intentional there | 21:02 |
| mgedmin | ? | 21:02 |
| mgedmin | nah, I'll do that myself | 21:02 |
| povbot | /svn/commits: * mg committed revision 4745: | 21:06 |
| povbot | /svn/commits: Reverted 4741, added informative comments. See http://issues.schooltool.org/issue349 for more info. | 21:06 |
| povbot | /svn/commits: * tvon committed revision 4746: | 21:06 |
| povbot | /svn/commits: fix for issue350 (schoolbell version showing up in schooltool footer) | 21:06 |
| *** tvon|x31 has joined #schooltool | 21:06 | |
| tvon|x31 | argh wifi | 21:08 |
| tvon|x31 | ignas: are you doing evolve8 or shall I? | 21:09 |
| * mgedmin loves svn commit announcements on irc | 21:09 | |
| tvon|x31 | it's nice | 21:09 |
| ignas | i am already testing it | 21:09 |
| * tvon|x31 nods | 21:09 | |
| tvon|x31 | tvon: go away | 21:09 |
| *** tvon has quit IRC | 21:10 | |
| mgedmin | whew! | 21:10 |
| *** tvon|x31 is now known as tvon | 21:10 | |
| povbot | /svn/commits: * mg committed revision 4747: | 21:10 |
| mgedmin | what's left to merge? | 21:10 |
| povbot | /svn/commits: Backported rev 4746: fix for issue350 (schoolbell version showing up in schooltool footer). | 21:10 |
| mgedmin | is anyone keeping track? | 21:10 |
| tvon | mgedmin: ever toy with CIA? | 21:12 |
| mgedmin | looked at it once or twice | 21:12 |
| mgedmin | can't say I've ever toyed with it | 21:13 |
| povbot | /svn/commits: * ignas committed revision 4748: | 21:13 |
| povbot | /svn/commits: The real fix for the issue349. | 21:13 |
| * tvon thinks it's pretty nice | 21:14 | |
| povbot | /svn/commits: * mg committed revision 4749: | 21:16 |
| povbot | /svn/commits: Backported rev 4748: The real fix for the issue349 (YYYY-MM-DD date format not migrated). | 21:16 |
| mgedmin | time for me to go home | 21:21 |
| mgedmin | I guess issue 345 needs to be backported, and perhaps investigated | 21:23 |
| mgedmin | I don't understand the status of issue 330 | 21:23 |
| bskahan | mgedmin: I can reproduce 330 | 21:28 |
| bskahan | ignas: what was the question about the section index table? | 21:29 |
| mgedmin | bskahan, can you write up the steps to reproduce it? | 21:31 |
| bskahan | mgedmin: new data.fs, front page (/calendar), click the printer icon | 21:34 |
| bskahan | this is in schoolbell | 21:34 |
| mgedmin | bskahan, in the issue tracker, please | 21:34 |
| ignas | bskahan, why search only searches in section ids ? | 21:34 |
| ignas | why so many spaces before commas ? | 21:34 |
| ignas | why when deleting sections you still see only their ids ? | 21:35 |
| ignas | anyway | 21:35 |
| *** mgedmin has quit IRC | 21:36 | |
| bskahan | ignas: not sure about the search, didn't change its behavior, commas is an html artifact, good point about deleting | 21:37 |
| * tvon did searching | 21:37 | |
| tvon | I know what 330 is I believe... where should I see a print icon? | 21:38 |
| tvon | ah, missing timesbd.ttf | 21:39 |
| * tvon has Times_New_Roman_Bold.ttf | 21:39 | |
| bskahan | tvon: 330 is caused by ISchoolBellApplication not having a title attribute | 21:39 |
| * tvon nods | 21:40 | |
| tvon | it's more directly caused by access to title not being specified in zcml. we can just add it there | 21:41 |
| bskahan | shouldn't the interface not being correct be fixed? | 21:42 |
| tvon | srichter: did you create an ITitleOwner or something along those lines in your branch? | 21:42 |
| * tvon shrugs | 21:42 | |
| tvon | just because it's in the class doesnt mean it has to be in the interface | 21:42 |
| tvon | I'm not sure what the right answer is | 21:42 |
| bskahan | shouldn't it be in an interface somewhere? | 21:42 |
| tvon | ISchoolBellApplication inherits ICalendarOwner which has title | 21:43 |
| *** pcardune has joined #schooltool | 21:43 | |
| tvon | zcml doesnt follow subclasses | 21:43 |
| pcardune | eldafar: ayt? | 21:44 |
| bskahan | tvon: add <allow interface=".interfaces.ICalendarOwner" /> | 21:45 |
| bskahan | ? | 21:45 |
| eldafar | pcardune: yes | 21:45 |
| tvon | bskahan: yeah, that sounds right to me | 21:45 |
| pcardune | Has anyone ever gotten a Bus Error? as in, i push a button and suddenly zope crashes and all it says is "Bus error" | 21:45 |
| tvon | wait a sec... | 21:45 |
| bskahan | i realize that's not the exact module | 21:45 |
| tvon | icalendarowner doenst have title, I think it should though | 21:45 |
| tvon | no, I guess it should go on ISBApp | 21:46 |
| tvon | I thought ICalendarOwner had it, my mistake | 21:46 |
| tvon | bskahan: are you working on that one? | 21:55 |
| bskahan | yes | 21:55 |
| tvon | k | 21:55 |
| bskahan | tvon: is there a default title? | 21:58 |
| tvon | bskahan: yeah, SchoolBell/SchoolTool | 21:59 |
| *** ignas has quit IRC | 21:59 | |
| bskahan | where is that default set? | 22:00 |
| tvon | app.py in ApplicationPreferences | 22:00 |
| povbot | /svn/commits: * srichter committed revision 4750: | 22:13 |
| povbot | /svn/commits: Made CalendarOverlayInfo's showTimetables available via an adapter instead of implementing a derived class. This allowed me to remove the second implementation of IPerson. This simplified code a bit. | 22:13 |
| bskahan | for some reason the PDF view doesn't display the site name correctly | 22:14 |
| srichter | I wonder whether courses and sections should be together in a package | 22:14 |
| srichter | thoughts? | 22:14 |
| bskahan | srichter: yes, I think they should | 22:14 |
| srichter | ok, will do that then :-) | 22:14 |
| bskahan | yay | 22:14 |
| bskahan | :) | 22:15 |
| povbot | /svn/commits: * bskahan committed revision 4751: | 22:20 |
| povbot | /svn/commits: added a title TextLine attribute to the ISchoolBellApplication interface. This allows the current security definition to work properly. | 22:20 |
| povbot | /svn/commits: There is no attached doctest because verifyObject is allready tested in test_app. There is an ftest for regressions though. | 22:21 |
| povbot | /svn/commits: This should close issue330 and is a candidate for backporting. It exposes a new bug however, the pdf of the frontpage calendar does not properly print the site title in the header. creating a seperate issue351 for that bug. | 22:21 |
| *** tvon has quit IRC | 22:28 | |
| *** tvon has joined #schooltool | 22:50 | |
| *** pcardune_ has joined #schooltool | 23:39 | |
| *** pcardune has quit IRC | 23:39 | |
| *** bskahan has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!