| *** th1a has quit IRC | 00:58 | |
| *** replaceafill has quit IRC | 01:30 | |
| *** khildin_ has quit IRC | 02:52 | |
| *** Lumiere has quit IRC | 05:16 | |
| *** Lumiere has joined #schooltool | 06:28 | |
| *** Lumiere has quit IRC | 06:34 | |
| *** Lumiere has joined #schooltool | 06:34 | |
| *** khildin has joined #schooltool | 09:45 | |
| *** menesis has quit IRC | 11:40 | |
| *** menesis has joined #schooltool | 12:40 | |
| *** menesis has quit IRC | 14:51 | |
| *** yvl has joined #schooltool | 15:32 | |
| *** th1a has joined #schooltool | 16:12 | |
| *** replaceafill has joined #schooltool | 16:13 | |
| th1a | hi replaceafill, aelkner, yvl. | 16:30 |
|---|---|---|
| yvl | good morning | 16:31 |
| replaceafill | good morning/afternoon | 16:31 |
| aelkner | morning | 16:31 |
| th1a | Would you like to start us off yvl? | 16:31 |
| yvl | ok | 16:31 |
| *** menesis has joined #schooltool | 16:32 | |
| yvl | I fixed two bugs | 16:32 |
| yvl | the one with login | 16:32 |
| yvl | and the security issue | 16:32 |
| yvl | I'm almost done with calendar current day highlighting | 16:32 |
| th1a | What did you do about the security issue? | 16:33 |
| th1a | That is, how does it work now? | 16:33 |
| yvl | fixed it | 16:33 |
| yvl | I'll update the bug status | 16:33 |
| yvl | IRC is public and all :) | 16:34 |
| yvl | there :) | 16:34 |
| th1a | I don't know that the future implementation needs to be secret. | 16:35 |
| * yvl too | 16:35 | |
| yvl | anyway, you should get the email now | 16:35 |
| yvl | another thing.. I was wondering if we should add school logo import | 16:35 |
| yvl | we do have photos anyway now | 16:36 |
| th1a | Yes please! | 16:36 |
| yvl | ok! | 16:36 |
| yvl | are there places where you'd like me to display it? | 16:36 |
| th1a | Hm... good question. | 16:37 |
| th1a | It won't look right against the teal. | 16:37 |
| replaceafill | footer? | 16:37 |
| th1a | We've tried to shrink that. | 16:37 |
| th1a | I'd say printed reports are the main thing. | 16:37 |
| th1a | You might suggest a white or transparent background. | 16:37 |
| yvl | yes | 16:38 |
| yvl | I could display it instead of SchoolTool text | 16:38 |
| yvl | and add a small border | 16:38 |
| yvl | (darker teal) | 16:39 |
| yvl | so if it is with white background, it will look in a box | 16:39 |
| yvl | not sure if it's a good idea | 16:39 |
| th1a | I don't want to rush it into the web interface. | 16:39 |
| menesis | for Philippines I have added the school logo below the schooltool logo, in the same row as heading | 16:39 |
| menesis | on the right | 16:39 |
| menesis | but only on two pages that have short titles | 16:40 |
| th1a | That's a possibility. | 16:40 |
| menesis | some titles can be very long, they don't fit | 16:40 |
| menesis | and logo can be wide | 16:40 |
| menesis | so even less space | 16:40 |
| yvl | th1a might contract our web designers for "a place to put school logo" :) | 16:40 |
| yvl | it seems like a thing they would deal on a daily basis | 16:41 |
| th1a | To me it has always been more of an issue for printed reports. | 16:41 |
| yvl | right | 16:41 |
| th1a | The teal header screws it up -- we'd have to change the whole header. | 16:41 |
| menesis | replacing schooltool logo would be better... except that it has teal background and schooltool logo itself had to be inverted there | 16:41 |
| th1a | We could add it to the login page, perhaps. | 16:42 |
| yvl | yes! | 16:42 |
| th1a | That's one place you'd like to be assured of where you are. | 16:42 |
| yvl | sure! | 16:43 |
| yvl | can I add it at the left? | 16:43 |
| th1a | That's what I was thinking. | 16:43 |
| yvl | excellent | 16:43 |
| yvl | will do | 16:43 |
| th1a | Where the sidebar would be, right? | 16:43 |
| yvl | yes | 16:43 |
| th1a | ok | 16:43 |
| yvl | I was also looking at https://bugs.launchpad.net/schooltool/+bug/360967 | 16:44 |
| yvl | UI for calendar overlays | 16:44 |
| yvl | I wonder how low that fruit is hanging | 16:44 |
| th1a | I suspect that's more than a two day fix. | 16:45 |
| yvl | probably | 16:45 |
| th1a | Did you look at this one: https://bugs.launchpad.net/schooltool/+bug/905479 | 16:46 |
| th1a | Is this still a bug? https://bugs.launchpad.net/schooltool/+bug/893186 | 16:46 |
| yvl | I loooked at the teacher bug | 16:46 |
| yvl | no idea how that happened still | 16:46 |
| yvl | selenium tests... some of that may still be a bug | 16:47 |
| replaceafill | i don't think so | 16:47 |
| yvl | there's some new stuff of course | 16:47 |
| replaceafill | all of them have been resolved i think | 16:47 |
| yvl | like chrome makes temp files export.xls.chromedld | 16:47 |
| replaceafill | (i mean, the 3 items i listed in the bug) :) | 16:48 |
| yvl | :D | 16:48 |
| yvl | I remember solving something there, but can't remember what | 16:48 |
| yvl | (the orig bug that is) | 16:48 |
| replaceafill | how about this? https://bugs.launchpad.net/schooltool/+bug/970201 | 16:50 |
| replaceafill | sounds easy? | 16:50 |
| th1a | Ah, sure! | 16:50 |
| yvl | sure | 16:50 |
| replaceafill | there was another about contacts i'm looking for... :) | 16:50 |
| replaceafill | this one: https://bugs.launchpad.net/schooltool/+bug/479336 | 16:51 |
| th1a | Yes. | 16:51 |
| th1a | Pretty much any of the high priority bugs are... high priority. ;-) | 16:51 |
| th1a | So feel free. | 16:51 |
| replaceafill | this may not be so low hanging: https://bugs.launchpad.net/schooltool/+bug/983912 | 16:52 |
| th1a | Also some of these just haven't been makred as fixed. | 16:52 |
| th1a | oh... yeah, I should have triaged that. | 16:53 |
| * th1a looks at undecided. | 16:53 | |
| th1a | I'll go through those after the meeting. | 16:54 |
| th1a | OK, I think you'll be able to stay busy for a couple days, yvl. | 16:54 |
| yvl | yes, I'm fine bugwise now | 16:54 |
| yvl | thanks! | 16:54 |
| th1a | Thank you! | 16:54 |
| th1a | replaceafill? | 16:54 |
| replaceafill | ok | 16:55 |
| replaceafill | i have a question for yvl | 16:55 |
| replaceafill | i haven't checked your section skills changes very well | 16:55 |
| replaceafill | but i noticed while i was merging my projects gradebook branch to trunk | 16:55 |
| replaceafill | that now the skills gradebook shows worksheets as "deployed" | 16:56 |
| replaceafill | could you explain that a little? | 16:56 |
| yvl | hmm | 16:56 |
| yvl | seems that some functionality got inherited | 16:57 |
| yvl | by accident | 16:57 |
| yvl | is it bad that it shows worksheets deployed? | 16:57 |
| replaceafill | ah | 16:57 |
| replaceafill | it just that the worksheet tab in the cando dropdown gets italic font | 16:57 |
| replaceafill | not a big deal | 16:58 |
| aelkner | deployed worksheets are for the report card system | 16:58 |
| replaceafill | but it gets my attention :D | 16:58 |
| aelkner | i would say it is bad if any worksheet that is not for the report card would be marked deployed | 16:58 |
| yvl | ok | 16:58 |
| yvl | I missed that | 16:58 |
| replaceafill | i can dig into the change and see what it's doing it | 16:59 |
| replaceafill | (i just haven't yet) :) | 16:59 |
| replaceafill | so | 16:59 |
| yvl | thanks man | 17:00 |
| replaceafill | th1a, i'm now adding the functionality you requested | 17:00 |
| replaceafill | to update from projects -> skills | 17:00 |
| replaceafill | i decided to write a test so i don't have to keep testing it manually ;) | 17:00 |
| th1a | I think replaceafill programmed a bot to say "th1a, i'm now adding the functionality you requested" at 10:00 in case he's not here. | 17:00 |
| th1a | That'll fool me. | 17:01 |
| replaceafill | :| | 17:01 |
| replaceafill | good idea! | 17:01 |
| replaceafill | a bot to give my reports... | 17:01 |
| replaceafill | anyway | 17:01 |
| th1a | I am on track to meet the appointed deadline. | 17:01 |
| replaceafill | i also helped dwelsh and glenda this couple of days | 17:01 |
| replaceafill | with some minor issues | 17:02 |
| replaceafill | th1a, but the biggest surprise for me today | 17:02 |
| replaceafill | was that i got an email from Cambodia | 17:02 |
| th1a | Yes. | 17:02 |
| th1a | That was cryptic. | 17:02 |
| replaceafill | it seems like our contact person there Chandara was in a serious accident :( | 17:03 |
| th1a | "I am so sorry that I kept silent for long time ago. Because my family and I were knocked unconscious in the accident on the way." | 17:03 |
| th1a | !!! ? | 17:03 |
| replaceafill | it seems like i should start digging through my old branches to look for cambodia :) | 17:04 |
| replaceafill | (if we decide to continue ofc) | 17:04 |
| replaceafill | th1a, i'll finish this last piece (and check the deployed part) and set up an instance to show you to get feedback, ok? | 17:05 |
| th1a | Well, I think I'm going to say we have to start with the 2 branch with them now. | 17:05 |
| th1a | replaceafill: yes, please. | 17:06 |
| replaceafill | th1a, can we meet tomorrow at meeting time? | 17:06 |
| replaceafill | i need to run some errands this afternoon | 17:06 |
| th1a | replaceafill: yes. | 17:06 |
| replaceafill | kk | 17:06 |
| * th1a tells Siri. | 17:06 | |
| replaceafill | :)) | 17:06 |
| * replaceafill done | 17:06 | |
| th1a | Meeting with Into glass. | 17:07 |
| replaceafill | :| | 17:07 |
| th1a | Siri understood "quantal update," which I thought was interesting. | 17:07 |
| th1a | That's where you benefit from centralized voice processing. | 17:08 |
| th1a | I don't think I'm the first person to say that peculiar phrase. | 17:08 |
| th1a | Anyhow... | 17:08 |
| th1a | Thanks replaceafill. | 17:08 |
| th1a | aelkner? | 17:08 |
| aelkner | ok, i got the student journal to work and have stests for it | 17:08 |
| aelkner | i haven't pushed yet, so i can't show you on the demo instance right now | 17:09 |
| aelkner | but it reports the three tables as we discussed, with absences and tardies sorted by day, period | 17:09 |
| th1a | Can you send a screenshot? | 17:10 |
| aelkner | participation averages sorted by term, section | 17:10 |
| aelkner | sure | 17:10 |
| aelkner | also, i uncovered a bug while writing the stest | 17:10 |
| aelkner | a good thing, too, that i can get the fix pushed and released | 17:10 |
| aelkner | it has to do with the new importer, SectionTimetables | 17:11 |
| aelkner | it added the schedules to the sections before adding the periods to the schedules | 17:11 |
| aelkner | this resulted in the section and person calendars not having the events | 17:11 |
| th1a | Ah. Tests. | 17:12 |
| aelkner | the reason i caught it is that i used the imported in my stest | 17:12 |
| aelkner | journal_security.txt does the setup of everything through the web | 17:12 |
| aelkner | but that takes SO long that i didn't think we needed to so that every time we write a test | 17:12 |
| aelkner | once is not bad to have such a stests for ttw timetable setup, but every test done that way is too expensive | 17:13 |
| aelkner | so anyway, it was a good thing i decided to so that since i found the bug | 17:13 |
| th1a | Yes. | 17:13 |
| aelkner | btw, can that bug explain what happened with https://bugs.launchpad.net/schooltool/+bug/905479? | 17:14 |
| aelkner | comment #2 | 17:14 |
| aelkner | yvl, what do you think? | 17:14 |
| yvl | well | 17:15 |
| th1a | Well... it came up when I was doing the screenshots for the book, so in theory those are the steps to reproduce. | 17:15 |
| yvl | it looks suspiciously similar | 17:15 |
| th1a | Except, I might have stopped and deleted things and started over an unknown number of times. | 17:16 |
| replaceafill | yvl, what's your opinion on aelkner's approach of using imports to set up tests? | 17:16 |
| replaceafill | it's definitely way faster | 17:16 |
| yvl | +0.5 | 17:16 |
| replaceafill | :D | 17:17 |
| yvl | feel free to, but keep in mind that some parts are better when written in tests explicitly | 17:17 |
| aelkner | you should see how long it takes the journal_security.txt test to run just to set up the data | 17:17 |
| yvl | that might be a case were importing is the preferable option | 17:17 |
| replaceafill | imho it's worth when you use the same setup in several different stests | 17:18 |
| aelkner | right, my point exactly | 17:18 |
| yvl | keep in mind that is a point of rot | 17:18 |
| yvl | hence +0.5 | 17:18 |
| replaceafill | kk | 17:19 |
| yvl | (it's way too easy to just pile into those .xls files) | 17:19 |
| yvl | (and end up writing tests where you need to look at .xls file just to undertand what's going on) | 17:20 |
| replaceafill | you mean, like start abusing the feature? | 17:20 |
| yvl | yes | 17:20 |
| replaceafill | got it | 17:20 |
| yvl | but if you don't abuse it too much - please use the importers at your leisure | 17:21 |
| replaceafill | kk, will do | 17:21 |
| replaceafill | thanks for the feedback | 17:21 |
| replaceafill | thanks aelkner for the idea ;) | 17:21 |
| yvl | and thanks for finding the bug | 17:22 |
| yvl | it really looks like th1a also found it ;) | 17:22 |
| th1a | Ah, I see. | 17:23 |
| aelkner | so i'm about to send screenshots for all to look at, one sec | 17:23 |
| replaceafill | btw | 17:24 |
| replaceafill | i forgot to mention | 17:24 |
| replaceafill | thanks to glenda's instance, i found a bug yesterda | 17:24 |
| replaceafill | y | 17:24 |
| replaceafill | related to one done_link url | 17:24 |
| replaceafill | here's the fix: | 17:24 |
| replaceafill | http://bazaar.launchpad.net/~schooltool-owners/schooltool/flourish/revision/3481 | 17:24 |
| replaceafill | i just wanted to mention that we should make sure to use absolute urls on redirects | 17:25 |
| replaceafill | the old code was producing a done_link=/.../.../ | 17:25 |
| * replaceafill done interrupting :) | 17:25 | |
| aelkner | np replaceafill, thanks for addressing that | 17:26 |
| aelkner | what was wrong with using PATH_INFO? | 17:26 |
| aelkner | although i think you already answered | 17:26 |
| aelkner | well, maybe not | 17:27 |
| replaceafill | right, we just needed an absolute url (http://...) | 17:27 |
| replaceafill | that takes virtual hosting into account for example | 17:27 |
| replaceafill | in the old approach, you would get vh++... garbage in the url | 17:27 |
| replaceafill | if the instance is behind apache | 17:27 |
| aelkner | ah, i get it, cool | 17:27 |
| aelkner | so formatter.request.url is more reliable | 17:28 |
| aelkner | than PATH_INFO, that is | 17:28 |
| replaceafill | afaik request doesn't have any other method to get the url? | 17:28 |
| aelkner | that's why i used PATH_INFO :) | 17:29 |
| replaceafill | i mean, the "current" url | 17:29 |
| yvl | has .URL | 17:29 |
| aelkner | but you were right to change it | 17:29 |
| replaceafill | yvl, right, that's what i used | 17:29 |
| replaceafill | but it's not a method, right? | 17:29 |
| yvl | no | 17:29 |
| yvl | a variable | 17:29 |
| replaceafill | right | 17:29 |
| aelkner | so guys, could you please look at the screenshots i sent to the developer list just now? | 17:30 |
| aelkner | the question i have is in regard to the dates | 17:30 |
| aelkner | strftime doesn't have a % option for the type of date that i present there | 17:31 |
| aelkner | and i'm guessing that european users may object to the order of month day that i present | 17:31 |
| aelkner | is that true? | 17:31 |
| replaceafill | why don't you use the "date" views we have, like @@shortDate? | 17:32 |
| replaceafill | those use the browser's locale | 17:32 |
| th1a | Also... I'm feeling like we really do need to do one row per day for absences and tardies. | 17:32 |
| aelkner | th1a, i can make that change, np | 17:33 |
| aelkner | replaceafill, do you know of a view that uses shortDate off hand? | 17:33 |
| replaceafill | gradebook score history | 17:33 |
| replaceafill | iirc | 17:33 |
| replaceafill | but you could look at schooltool.skin.flourish.configure.zcml | 17:33 |
| replaceafill | and look for fullDate, mediumDate and shortDate | 17:34 |
| aelkner | sure, thanks | 17:34 |
| aelkner | th1a, do you want me to use shortDate like gradebook score history does? | 17:34 |
| th1a | I have not given the matter much thought, but I can't imagine that this view needs special dates. | 17:35 |
| th1a | Stadard shortDates should suffice. | 17:35 |
| replaceafill | aelkner schooltool/gradebook/browser/templates/f_student_grade_history.pt | 17:35 |
| aelkner | th1a, cool, replaceafill, thanks | 17:36 |
| aelkner | menesis, i'll create a new bug for the importer problem and mention it in CHANGES.txt | 17:36 |
| aelkner | so i'll make the shortDate fix, change the absences and tardies to have on line per day | 17:37 |
| aelkner | and push the importer fix so that we have that stuff for the release | 17:38 |
| aelkner | th1a, i'll send you updated screenshots after i make the changes | 17:38 |
| aelkner | that's it for me | 17:38 |
| th1a | OK, thanks aelkner. Looks like we're on track to wrap everything up pretty well. | 17:39 |
| th1a | Shoot for Friday! | 17:39 |
| th1a | Have a good week & weekend. | 17:40 |
| aelkner | can we meet on Friday morning to have a status check? | 17:40 |
| th1a | Sure. | 17:40 |
| th1a | Same time. | 17:40 |
| th1a | See you then. | 17:40 |
| aelkner | just in case we need last minute changes | 17:40 |
| th1a | Sure. | 17:40 |
| aelkner | yvl, menesis, replaceafill, sorry for making you meet again this week :) | 17:40 |
| yvl | no problem | 17:41 |
| th1a | replaceafill and I have a business meeting then anyhow now. | 17:41 |
| replaceafill | :) | 17:41 |
| th1a | So we'll be here regardless. | 17:41 |
| yvl | (it's going to be a short meeting anyway - I hope ;) ) | 17:41 |
| aelkner | yes :) | 17:41 |
| th1a | We'll let you go drink yvl. | 17:41 |
| th1a | OK. See you Friday. | 17:41 |
| yvl | :DDD | 17:41 |
| replaceafill | :D | 17:41 |
| * th1a drops the bag of gravel. | 17:41 | |
| replaceafill | thanks everybody | 17:41 |
| yvl | thanks guys | 17:41 |
| aelkner | thanks guys, cya friday | 17:42 |
| *** yvl has quit IRC | 17:43 | |
| *** menesis has quit IRC | 18:52 | |
| *** menesis has joined #schooltool | 18:56 | |
| *** menesis has quit IRC | 20:22 | |
| *** menesis has joined #schooltool | 20:59 | |
| *** menesis has quit IRC | 21:06 | |
| *** menesis has joined #schooltool | 21:06 | |
| *** replaceafill has quit IRC | 21:16 | |
| *** replaceafill has joined #schooltool | 21:21 | |
| *** khildin has quit IRC | 22:16 | |
| *** th1a has quit IRC | 23:03 | |
| *** ignas has joined #schooltool | 23:45 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!