*** alga has quit IRC | 00:58 | |
*** replaceafill has quit IRC | 01:15 | |
*** replaceafill has joined #schooltool | 01:34 | |
*** replaceafill has quit IRC | 04:47 | |
*** aks has joined #schooltool | 06:10 | |
*** aks has joined #schooltool | 06:10 | |
th1a | aks: http://69.164.203.135:38000/persons/manager/index.html | 06:10 |
---|---|---|
th1a | (manager:schooltool) | 06:10 |
aks | th1a: ok | 06:10 |
th1a | This is NOT the final version... | 06:10 |
th1a | Just thought you might be interested in the draft. | 06:11 |
aks | th1a: wow! the new UI looks cool | 06:11 |
th1a | What do you think about the colors? | 06:12 |
th1a | We have to get away from the red because red=danger. | 06:12 |
aks | th1a: colors are good | 06:12 |
aks | th1a: Can i run this version on my machine?? | 06:12 |
th1a | The link text also needs to be darker. | 06:12 |
th1a | You can except for the colors. | 06:13 |
th1a | We'll have debs any day now. | 06:13 |
th1a | Also, I think the translation templates are up but not much good without the debs. | 06:14 |
th1a | I'm afraid we changed a LOT of strings. | 06:14 |
th1a | aks: bzr branch lp:schooltool.release/flourish ; cd flourish ; make develop | 06:14 |
th1a | make run | 06:15 |
aks | th1a: thanks | 06:22 |
*** alga has joined #schooltool | 09:27 | |
*** alga has quit IRC | 10:50 | |
*** menesis has joined #schooltool | 11:22 | |
*** alga has joined #schooltool | 12:37 | |
*** aks has quit IRC | 14:29 | |
*** aelkner has quit IRC | 15:17 | |
*** jelkner has joined #schooltool | 15:17 | |
*** aelkner has joined #schooltool | 15:19 | |
*** replaceafill has joined #schooltool | 15:59 | |
* th1a 's new refrigerator just arrived... | 16:10 | |
th1a | might have to start a few minutes late. | 16:10 |
th1a | I had a question last night about importing contacts... nobody has already implemented that (through xls) right? | 16:28 |
th1a | (discuss) | 16:28 |
* th1a goes back to supervise in the kitchen. | 16:28 | |
replaceafill | i haven't | 16:28 |
th1a | I should be ready here in about 10 minutes. | 16:36 |
yvl | nobody implemented that, AFAIK | 16:42 |
replaceafill | yvl while we wait for th1a, could you help me with https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/846448 | 16:45 |
replaceafill | http://69.164.203.135:6660/ | 16:45 |
replaceafill | jeffrey.elkner, schooltool | 16:46 |
replaceafill | Gradebook | 16:46 |
replaceafill | or Journal for "ITP 140 - PM" | 16:46 |
replaceafill | i've tracked down the issue to journal.journal.SectionJournalData | 16:47 |
replaceafill | specifically to the recordedMeetings method | 16:47 |
yvl | looking... | 16:48 |
replaceafill | but i couldn't find a way to get from the Calendar or its events to the SelectedPeriodsSchedule | 16:48 |
replaceafill | the issue, as jelkner reported is that his schedule uses consecutive_periods_as_one = True | 16:50 |
yvl | well, a while ago th1a decided that setting should not be a part of journal ;) | 16:50 |
replaceafill | ah | 16:51 |
yvl | anyway | 16:51 |
yvl | hmm | 16:51 |
th1a | ok | 16:51 |
th1a | Setting? | 16:51 |
yvl | yes | 16:52 |
yvl | remember the discussion? | 16:52 |
th1a | No. | 16:52 |
yvl | you said it should not be implemented in journal? | 16:52 |
th1a | I don't know what "setting" means in this context. | 16:52 |
aelkner | when you create a schedule, you can click on a checkbox | 16:52 |
yvl | I spent half an hour trying to convince you that might be not the best idea? | 16:52 |
replaceafill | http://69.164.203.135:6660/schoolyears/2011-2012/first-quarter/sections/4/schedule | 16:52 |
yvl | sigh | 16:52 |
replaceafill | jeffrey.elkner:schooltool | 16:52 |
yvl | ok | 16:52 |
th1a | Oh, THAT setting. | 16:53 |
replaceafill | :D | 16:53 |
yvl | so meeting ids are - or at least should be - unique per meeting | 16:53 |
replaceafill | " Consecutive periods are treated as a single meeting. " | 16:53 |
th1a | Not "setting should not be a part of journal" | 16:53 |
th1a | OK, anyhow. | 16:53 |
th1a | jelkner doesn't want to take attendance twice. | 16:53 |
yvl | consecutive events have same meeting id, when that setting is checked | 16:54 |
yvl | or they should AFAIR | 16:54 |
th1a | So what's the problem? | 16:55 |
th1a | the technical problem | 16:55 |
replaceafill | yvl you mean unique_id in schooltool.timetable.calendar.ScheduleCalendarEvent? | 16:56 |
yvl | no, replaceafill, meeting_id | 16:56 |
yvl | unique_id is unique identifier of the evnet | 16:57 |
yvl | meeting_id - unique identifier of (multi-event) meeting that day | 16:57 |
replaceafill | ah | 16:57 |
yvl | replaceafill, are you using an evolved Data.fs there? | 16:58 |
replaceafill | yvl yes | 16:58 |
yvl | did recordedMeetings yield double events for the same day? | 17:00 |
replaceafill | yes | 17:00 |
replaceafill | len(recorded_ids) -> 19 | 17:01 |
replaceafill | len([v for v in calendar if v.meeting_id in recorded_ids]) -> 38 | 17:01 |
yvl | ok, that seems correct | 17:03 |
yvl | sorry, can't find what's wrong by purely looking at the code | 17:05 |
replaceafill | yvl np | 17:05 |
th1a | So at this point we're still diagnosing the problem, correct? | 17:05 |
replaceafill | yes | 17:06 |
th1a | OK. So that's what replaceafill is working on... | 17:07 |
replaceafill | correct | 17:07 |
th1a | Cool. OK yvl, anything to report on testing? | 17:07 |
yvl | umm, not much | 17:08 |
yvl | read a bunch of source and looked at things today | 17:08 |
yvl | and played around | 17:08 |
yvl | for now it looks promising | 17:08 |
yvl | I'll start implementing tomorrow, I think | 17:09 |
aelkner | will we be able to do the same thing we did before in that | 17:10 |
aelkner | we could test just a certain package and even a single test file | 17:10 |
yvl | :) | 17:10 |
yvl | yes, aelkner, I'm reusing zope.testrunner | 17:10 |
th1a | Didn't you ask that yesterday aelkner? | 17:10 |
yvl | yes :) | 17:10 |
aelkner | oh, sorry for repeating myself | 17:10 |
th1a | Perhaps these are lobbying strategies one learns growing up with jelkner. | 17:10 |
aelkner | :) | 17:11 |
th1a | Thanks yvl. | 17:11 |
th1a | menesis? | 17:11 |
yvl | from day-to-day dev experience it should be similar to what we have | 17:11 |
yvl | don't know if I'll make the headless thing now, or later | 17:11 |
aelkner | one learns a lot of annoying strategies growing up with jelkner | 17:11 |
menesis | th1a: I was fixing zope packages that had bugs introduced in summer | 17:12 |
menesis | that prevented schooltool from starting | 17:13 |
menesis | https://bugs.launchpad.net/ubuntu/+source/zope.html/+bug/843884 | 17:13 |
th1a | Ah. | 17:13 |
menesis | with 10 (!) duplicates | 17:13 |
menesis | means someone is trying schooltool on oneiric | 17:13 |
th1a | Interesting. | 17:13 |
th1a | OK. Keep at it. | 17:14 |
th1a | I've got oneiric on my laptop but I didn't try SchoolTool yet. | 17:14 |
menesis | I will be finished with that shortly | 17:15 |
th1a | Cool. | 17:15 |
th1a | Thanks menesis. | 17:15 |
th1a | Before we go onto aelkner I have a quick story. | 17:16 |
menesis | also, added some 1.9.0 milestones | 17:16 |
menesis | assigned bugs to milestones | 17:16 |
menesis | etc. in preparation for release | 17:16 |
menesis | also, moved buildbot to schooltool.pov.lt | 17:16 |
menesis | because the one on schooltool.org does not notice any commits | 17:17 |
menesis | and I need to be notified of build failures if there are any | 17:17 |
th1a | Indeed. | 17:18 |
menesis | but did not want to spend time investigating what's wrong | 17:18 |
menesis | http://schooltool.pov.lt/buildbot | 17:19 |
th1a | That's fine. | 17:19 |
menesis | has other problems, I need a port opened | 17:20 |
menesis | but does what I need now | 17:20 |
* yvl is anxious to hear th1a's story ;) | 17:20 | |
replaceafill | :D | 17:20 |
th1a | So... chatted with David Ally last night. | 17:21 |
th1a | Turns out he walked out of the UN office in Nigeria 10 minutes before it was bombed a couple weeks ago. | 17:21 |
th1a | His wife works there but she's ok. | 17:21 |
th1a | But a lot of their friends and colleagues were badly injured or killed. | 17:21 |
yvl | oh. | 17:22 |
replaceafill | :( | 17:22 |
aelkner | damn | 17:22 |
yvl | awful | 17:22 |
aelkner | was it a terrorist attack? | 17:23 |
th1a | Yes. | 17:23 |
th1a | I didn't follow the story very closely, I'm afraid. | 17:23 |
th1a | ABUJA, Nigeria - A car loaded with explosives crashed into the main United Nations' building in Nigeria's capital and exploded Friday, killing at least 18 people in one of the deadliest assaults on the international body in a decade. A radical Muslim sect blamed for a series of attacks in the country claimed responsibility for the bombing, a major escalation of their sectarian fight against Nigeria's weak central government. | 17:24 |
th1a | Small world. | 17:25 |
th1a | OK, aelkner, what's your queue look like? | 17:26 |
aelkner | so they have their own sectarian issues there | 17:26 |
aelkner | anyway, first i fixed unit tests in gradebook | 17:26 |
aelkner | the idea with flourish was to only change things that would not break the old skin | 17:27 |
th1a | That was aelkner's idea of flourish... | 17:27 |
aelkner | and i only added attributes to the dictionary entries in the table() method of GradebookOverview | 17:28 |
aelkner | attributes that the old skin template was not looking for | 17:28 |
aelkner | this way the old template would render the same, and the new templates had more info | 17:28 |
aelkner | problem is test_pdf_views.py unit tests the pdf views, so table() changing forced a change there | 17:29 |
aelkner | i have a proposal though | 17:29 |
aelkner | since replaceafill created functional tests of the pdf views a while back (nice one, btw) | 17:29 |
aelkner | could we agree to scrap test_pdf_views.py all together? | 17:30 |
aelkner | it seems stupid to have to spend time fixing that stupid tests every time a change is made to table() | 17:30 |
aelkner | and the functional tests will allow us to catch things | 17:31 |
aelkner | i never understood the purpose of unit testing view anyway, but was forced to | 17:31 |
aelkner | before we had functional testing capability with pdfs | 17:31 |
aelkner | may i bzr remove that file? | 17:32 |
* th1a has no opinion. | 17:32 | |
aelkner | yvl? | 17:32 |
yvl | looking | 17:32 |
aelkner | th1a, "That was aelkner's idea of flourish", i don't agree | 17:33 |
aelkner | didn't we create a flourish skin to avoid breaking the old skin?! | 17:33 |
aelkner | otherwise, why create the new skin | 17:33 |
yvl | sure, kill test_pdf_views.py | 17:33 |
th1a | aelkner: You put it more strongly the first time. | 17:34 |
aelkner | yvl, thanks | 17:34 |
yvl | unit testing the views may make sense | 17:34 |
yvl | where they mangle a lot of data | 17:34 |
yvl | it may be too difficult/cumbersome to functionally test corner cases | 17:34 |
th1a | I wouldn't say the idea was to only change things that didn't break the skin. I would say we wanted to avoid it. | 17:34 |
aelkner | wy did we want to avoid it? | 17:35 |
aelkner | wy bother? | 17:35 |
th1a | We really don't need to rehash this. In a few cases where the change would also improve the old skin, we made those changes and fixed the tests. It is over. | 17:35 |
aelkner | ok, moving on | 17:36 |
aelkner | so i also looked into the functional tests for gradebook which meant i needed to change it's buildout.cfg to | 17:36 |
aelkner | point to the other flourish checkouts (branches) in my sandbox | 17:37 |
aelkner | because the eggs are not flourish | 17:37 |
yvl | right | 17:37 |
aelkner | i get a zcml configuration error trying to load the f_gradebook.css resource library | 17:38 |
aelkner | yvl, could you see what might be the problem there | 17:38 |
aelkner | could there be something that needs to be added to setup.py in the gradebook plugin | 17:38 |
yvl | ok, I can look at that\ | 17:39 |
aelkner | thanks, but don't fix any broken tests that you reach after successfully resolving that | 17:39 |
aelkner | i can take care of that since i probably was the one that broke them | 17:39 |
aelkner | although, there is a chance that nothing broke since i was careful as i said earlier only to add attributes | 17:40 |
aelkner | but it would be nice to know | 17:40 |
yvl | sure | 17:40 |
aelkner | ok, also, i added Done links to all the views that are reached from /manage to take you back | 17:41 |
aelkner | rather than cloning the templates in a couple cases, i added a done_link attribute to TableContainerView | 17:41 |
aelkner | and change the template to conditionally render it (it defaults to '') | 17:42 |
yvl | well, the whole Done link situation has gone totally out-of-hand now | 17:42 |
yvl | so we'll clean this up some time later I guess | 17:43 |
replaceafill | i liked yvl content provider for it | 17:43 |
yvl | thanks for the fix, aelkner | 17:43 |
yvl | and thanks replaceafill ;) | 17:44 |
aelkner | yvl, you mean you are ok with how i did it? | 17:44 |
th1a | There are only a few views that need smart Done's. | 17:44 |
yvl | sure | 17:45 |
aelkner | ok, cool | 17:45 |
th1a | I guess we didn't have them there because we used to have a cancel button. | 17:45 |
yvl | something like 10-20 views I'd guess | 17:45 |
th1a | But I prefer Done to cancel in that case. | 17:45 |
aelkner | lastly, i went over all the bugs in my queue and got rid of those that were fixed by flourish version of views | 17:46 |
aelkner | i changed them to Invalid and poste a comment | 17:46 |
aelkner | posted | 17:46 |
aelkner | th1a, there isn't any bug in my queue that couldn't be addressed without discussion with you | 17:46 |
aelkner | can we do that after the meeting? | 17:46 |
th1a | Why did you change them to invalid? | 17:47 |
th1a | Didn't we fix them? | 17:47 |
th1a | Agh. | 17:47 |
aelkner | sorry, Invalid was the wrong choice on my part, Fixed would have been better | 17:47 |
aelkner | either way they are gone, so... | 17:47 |
th1a | Change them to fix committed -- https://bugs.launchpad.net/schooltool-project/+bugs?field.searchtext=&orderby=-importance&field.status%3Alist=INVALID&field.status%3Alist=CONFIRMED&assignee_option=choose&field.assignee=aelkner&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used= | 17:48 |
th1a | &field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search | 17:48 |
th1a | Oh, lp urls... | 17:48 |
th1a | Is this still a bug? https://bugs.launchpad.net/schooltool.intervention/+bug/637189 | 17:50 |
th1a | Is this still a bug? https://bugs.launchpad.net/schooltool/+bug/585119 | 17:50 |
th1a | Please tidy the rest of these up, and then you can start on the contacts import | 17:51 |
yvl | 1) no, fixed I think | 17:51 |
aelkner | we need to discuss what the contacts sheet look like | 17:51 |
yvl | 2) yes, no changes | 17:51 |
th1a | Each field in the add form can get a column in the sequence it is listed. | 17:52 |
th1a | And then... | 17:53 |
th1a | Maybe just a separate sheet actually doing the linking. | 17:53 |
th1a | OK, I have to go or my children will starve in my wrecked kitchen. | 17:53 |
yvl | you can duplicate entries in the same sheet | 17:53 |
th1a | That should get you started aelkner. I'll catch up this afternoon. | 17:53 |
* th1a drops the bag of gravel. | 17:53 | |
yvl | student1, parent, John, etc. | 17:54 |
yvl | student1, sibling, Cate, etc. | 17:54 |
yvl | student2, ... | 17:54 |
yvl | thanks, th1a | 17:54 |
yvl | replaceafill, aelkner | 17:55 |
yvl | if you do have any ideas of what you want selenium tests to be able to do, please voice them! | 17:55 |
aelkner | menesis, you fixed the Invalids for me? | 17:55 |
menesis | the bugs are now fixed, why you marked those invalid? | 17:56 |
aelkner | no, that was good of you, thanks | 17:56 |
yvl | for example - "I want an option to optionally run with HtmlUnit" | 17:56 |
aelkner | my mistake | 17:56 |
yvl | "I want a headless set-up on xvfb" | 17:56 |
yvl | "I want Chromium" | 17:57 |
yvl | and so on | 17:57 |
replaceafill | yvl headless = no gui? | 17:57 |
yvl | yes, but it's more of a gui rendered in a vritual frame buffer | 17:57 |
yvl | so it's there, just hidden | 17:57 |
aelkner | i just need it to work on Firefox with the package and file filter as i mentioned before | 17:58 |
yvl | maybe, maybe our buildbot will run that way | 17:58 |
aelkner | also, being able to manager.serve() was always important | 17:58 |
replaceafill | +1 on serve | 17:58 |
yvl | ok | 17:58 |
aelkner | but the filter is important, too | 17:58 |
yvl | ok | 17:59 |
replaceafill | we'll still use the xpath approach, right? | 17:59 |
replaceafill | a la printQuery | 17:59 |
aelkner | we can't have to run the whole suite of core tests just to fix on test file | 17:59 |
yvl | right | 17:59 |
aelkner | right to which one? :) | 17:59 |
yvl | yes, xpath will be available, Selenium has that and more built-in | 17:59 |
yvl | yes to both ;) | 17:59 |
replaceafill | css selectors :) | 18:00 |
yvl | screenshots will also be available on demand | 18:00 |
aelkner | glad that you are getting this going | 18:00 |
yvl | depending on how it goes, you may have to do some manual setups in your system | 18:01 |
yvl | install stuff and such | 18:01 |
yvl | so if you happen to think up something you want, please email or IRC me | 18:02 |
yvl | ok... see you guys Thu! | 18:03 |
replaceafill | thanks yvl | 18:03 |
aelkner | cya yvl | 18:05 |
th1a | aelkner: In terms of linking contacts, basically what yvl has above should work. | 18:28 |
th1a | But we might also have to let the user set the contact ID's from the spreadsheet. | 18:28 |
th1a | And they may have to specify whether the contact is a contact or person so the ID's don't collide. | 18:28 |
*** aks has joined #schooltool | 19:08 | |
*** aks has joined #schooltool | 19:08 | |
*** aks has quit IRC | 19:27 | |
*** menesis has quit IRC | 20:00 | |
*** alga has quit IRC | 20:00 | |
th1a | replaceafill: We have some new colors to try. | 20:12 |
replaceafill | th1a ah ok | 20:12 |
replaceafill | should i start from yvl last design? | 20:13 |
th1a | y | 20:13 |
replaceafill | k, let me set up that branch | 20:13 |
replaceafill | ok, yvl's schwa branch at: http://69.164.203.135:6661/calendar | 20:20 |
* replaceafill looks at the new colors | 20:20 | |
replaceafill | th1a http://69.164.203.135:6661/persons/teacher001 | 20:30 |
replaceafill | hover on the tabs | 20:31 |
replaceafill | and on the inactive accordions | 20:31 |
th1a | I don't want the top up there. | 20:31 |
th1a | I guess you missed that conversation yesterday. | 20:31 |
replaceafill | oh, i thought yvl had updated it | 20:32 |
replaceafill | oops, moving to #485455 | 20:33 |
replaceafill | that's for links, right? | 20:33 |
th1a | ? | 20:34 |
th1a | y | 20:34 |
th1a | well... maybe | 20:34 |
replaceafill | done | 20:34 |
replaceafill | i don't like the underline :( | 20:35 |
th1a | no | 20:35 |
replaceafill | got rid of it | 20:35 |
th1a | try the breadcrumbs bar as teal | 20:36 |
replaceafill | done | 20:37 |
replaceafill | better | 20:37 |
th1a | Did you get the new weblogo? | 20:39 |
replaceafill | ah, let me put it in | 20:40 |
replaceafill | hhmm the server is responding very slow... | 20:46 |
replaceafill | th1a logo replaced | 20:48 |
*** alga has joined #schooltool | 20:48 | |
th1a | Do we have the same grays in our gradebook grid now? | 20:52 |
replaceafill | hhm i don't think so | 20:52 |
replaceafill | no we do | 20:54 |
replaceafill | ah the header | 20:54 |
replaceafill | done | 20:55 |
replaceafill | adding the hover effect would require JS because the gradebook is made of 3 tables instead of just one :( | 20:56 |
th1a | OK. | 20:58 |
th1a | Can you switch the "tool" to the darker teal? | 20:58 |
replaceafill | ah ok | 20:58 |
replaceafill | done | 20:59 |
th1a | OK... that was driving me crazy. | 21:01 |
th1a | I didn't really realize it was wrong. | 21:01 |
th1a | I mean, I knew, but did think it. | 21:02 |
th1a | I'm feeling better about teal now. | 21:02 |
replaceafill | my only concern is links colors :( | 21:03 |
replaceafill | it's hard to tell what's a link and what's regular text | 21:03 |
th1a | What about the dark teal for that? | 21:09 |
replaceafill | ah | 21:10 |
replaceafill | let me try | 21:10 |
replaceafill | hhmm | 21:10 |
replaceafill | refresh | 21:10 |
*** jboisture has joined #schooltool | 21:20 | |
th1a | That could just go darker. | 21:20 |
th1a | #003a3d | 21:20 |
replaceafill | for the links? | 21:21 |
th1a | sure | 21:21 |
replaceafill | it looks blackish | 21:21 |
replaceafill | refresh | 21:21 |
th1a | #00686e | 21:22 |
replaceafill | refresh | 21:22 |
replaceafill | better, i can tell it's not regular text | 21:22 |
th1a | #005c61 | 21:23 |
replaceafill | refresh | 21:24 |
th1a | That's pretty good I think. | 21:25 |
replaceafill | check the gradebook header | 21:26 |
replaceafill | maybe we could use another color for those links? | 21:26 |
th1a | Why? | 21:26 |
th1a | The tertiary nav? | 21:26 |
replaceafill | no the activity headers | 21:27 |
replaceafill | hhmm it looks better in chrome :D | 21:27 |
replaceafill | ah! the ubuntu font :) | 21:28 |
replaceafill | never mind, the header looks ok | 21:28 |
th1a | Did we set up the web font thing? Shouldn't that be working on Debian? | 21:28 |
replaceafill | yes, it's there, maybe it's a firefox issue | 21:29 |
replaceafill | because my chrome uses it | 21:29 |
th1a | Right. It is a Google initiative, I think. | 21:30 |
*** James_ has joined #schooltool | 21:33 | |
*** James_ has quit IRC | 21:35 | |
*** James_ has joined #schooltool | 21:37 | |
James_ | jelkner: did you see my email? | 21:38 |
*** James_ has quit IRC | 21:50 | |
*** jboisture has quit IRC | 21:50 | |
*** jelkner has quit IRC | 23:05 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!