| *** alga has quit IRC | 00:01 | |
| *** ignas has quit IRC | 00:07 | |
| replaceafill | change pushed to gradebook trunk: "Removed activity and gradebook-total CSS classes" | 00:42 |
|---|---|---|
| replaceafill | change pushed to gradebook trunk: "Added placeholder for empty worksheets and moved width calculation to window load event" | 02:14 |
| *** replaceafill has quit IRC | 02:34 | |
| *** aks has joined #schooltool | 06:05 | |
| *** aks has quit IRC | 07:20 | |
| *** th1a has quit IRC | 07:25 | |
| *** aks has joined #schooltool | 07:26 | |
| *** aks has joined #schooltool | 07:26 | |
| *** yvl has joined #schooltool | 09:24 | |
| *** alga has joined #schooltool | 10:22 | |
| *** alga has quit IRC | 11:14 | |
| *** alga has joined #schooltool | 12:15 | |
| *** alga has quit IRC | 13:03 | |
| *** alga has joined #schooltool | 13:42 | |
| *** aks has quit IRC | 14:21 | |
| *** menesis has joined #schooltool | 15:06 | |
| *** replaceafill has joined #schooltool | 15:58 | |
| *** th1a has joined #schooltool | 16:21 | |
| th1a | hi aelkner, replaceafill, yvl, menesis. | 16:30 |
| replaceafill | good morning/afternoon | 16:31 |
| aelkner | morning | 16:31 |
| yvl | hey guys | 16:31 |
| th1a | OK. Calendar. | 16:32 |
| th1a | I'm looking at http://69.164.203.135:6660/persons/tom/calendar/2011-08 | 16:32 |
| th1a | Should this be up to date? | 16:32 |
| replaceafill | th1a it is | 16:33 |
| replaceafill | oh no | 16:33 |
| replaceafill | updating... | 16:33 |
| replaceafill | now it is :) | 16:33 |
| replaceafill | tom:tom btw | 16:33 |
| th1a | The More... link isn't working for me. | 16:34 |
| yvl | ok | 16:34 |
| th1a | Is that a known bug/unfinished? | 16:35 |
| yvl | forgot to implement | 16:35 |
| th1a | kk | 16:35 |
| yvl | will do | 16:35 |
| th1a | Also I noticed on the event view I can see a pencil even if I don't have edit permission. | 16:36 |
| yvl | ok | 16:36 |
| yvl | I think we made the same mistake in more places | 16:37 |
| yvl | copy-paste bug | 16:37 |
| th1a | I'm sure we did. | 16:37 |
| th1a | What else is up yvl? | 16:38 |
| yvl | Did contacts | 16:38 |
| yvl | also some breadcrumbs | 16:38 |
| yvl | in progress of groups/courses/sections/timteables breadcrumbs | 16:38 |
| yvl | they're kind of the same | 16:38 |
| th1a | Which contacts? | 16:39 |
| yvl | non-bound | 16:39 |
| yvl | see School | 16:39 |
| yvl | (section "Contacts") | 16:40 |
| th1a | Also, I can see "School" as a tab but not the view. | 16:40 |
| yvl | yes, those permissions/redirects were postponed and never fixed | 16:40 |
| th1a | Well, now's the time. | 16:41 |
| th1a | Or... soon. | 16:41 |
| yvl | oh, right! | 16:41 |
| yvl | days off | 16:41 |
| th1a | Lithuanian holidays? | 16:41 |
| yvl | yes! | 16:42 |
| yvl | we have a lot of those :) | 16:42 |
| yvl | this time - Monday | 16:42 |
| th1a | OK. Thanks for reminding me. | 16:42 |
| yvl | also - I'm going away a bit early Fri, so won't be able to make the meeting | 16:42 |
| th1a | OK. | 16:42 |
| yvl | I can do "School" on... Tue probably | 16:42 |
| th1a | What is an "external contact person?" | 16:43 |
| yvl | stub naming - not sure how to name non-users | 16:43 |
| yvl | or even if we should | 16:43 |
| yvl | parents and so on | 16:43 |
| aelkner | '10 contacts who or not users'? | 16:43 |
| th1a | I don't think it is necessary to make the distinction. | 16:44 |
| yvl | ok | 16:44 |
| yvl | will remove the line | 16:44 |
| yvl | contacts were really unfinished btw, hence the slow development. | 16:45 |
| th1a | ok | 16:45 |
| th1a | Seems like you have enough loose ends to keep you busy tomorrow. | 16:47 |
| yvl | yes, and on Tue morning | 16:47 |
| th1a | OK. Cool. | 16:48 |
| th1a | Thanks yvl. | 16:49 |
| th1a | aelkner? | 16:49 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/20102011/sections/1/activities/Worksheet/gradebook/index.html?show=average | 16:49 |
| aelkner | oh no | 16:49 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/20102011/sections/1/activities/Worksheet/gradebook | 16:50 |
| aelkner | there you will see that the Name meu has Show/Hide column options now | 16:50 |
| aelkner | i installed the journal on my test instance to show the journal columns as well | 16:50 |
| aelkner | i could also add Hide Total to the Total column and the other three columns as well | 16:51 |
| th1a | Can you add Hide to the calculated column menus as well? | 16:51 |
| aelkner | what do you think? | 16:51 |
| aelkner | :) | 16:51 |
| aelkner | you were a step ahead of me | 16:51 |
| th1a | Make a separate row for "Total Points" below "Name" | 16:52 |
| th1a | Maximum Points | 16:52 |
| th1a | I guess. | 16:52 |
| aelkner | ? | 16:52 |
| th1a | Don't want to use total two ways. | 16:52 |
| th1a | A separate row for the "100" etc. | 16:53 |
| aelkner | oh, a row label for the max points | 16:53 |
| aelkner | Maximum points is your final decision? | 16:53 |
| aelkner | Points with a capital P | 16:54 |
| th1a | Maybe "Points" ? | 16:54 |
| aelkner | ok, Points | 16:54 |
| aelkner | actually, i think Max. Points might be better | 16:55 |
| aelkner | Points sounds vague because there's no mention of the fact that the numbers are a max possible | 16:55 |
| aelkner | I'll put something there for now, and you can always change you mind when you see it | 16:56 |
| th1a | Well... you can exceed the max possible though. | 16:56 |
| th1a | So let's start with "Points" | 16:56 |
| aelkner | ok | 16:56 |
| aelkner | now for scoresystem preference | 16:56 |
| th1a | I still have to go through the whole gradebook and make a lot of changes and additions to wording. | 16:56 |
| aelkner | looking at the Preferences vew, it only seems that the user can set the scoresystem for Ave. | 16:57 |
| aelkner | none of the other three columns | 16:57 |
| aelkner | does that sound right? | 16:57 |
| aelkner | well, it should because that's the way it always worked | 16:58 |
| aelkner | anyway | 16:58 |
| aelkner | i could add that dropdown to the Ave. column | 16:58 |
| th1a | Yes. | 16:58 |
| aelkner | if the user changes it in the menu, it applies immediately | 16:58 |
| th1a | How hard would it be to add nested menus to your menu code? | 16:58 |
| aelkner | just like the Show/Hide choices | 16:58 |
| aelkner | nested menus? | 16:59 |
| th1a | Oh... we need to add the score system management screen. | 16:59 |
| th1a | That might end up on replaceafill's list. | 16:59 |
| aelkner | that's admin stuff, like report sheet templates | 16:59 |
| aelkner | we can discuss that, too, if you like | 17:00 |
| aelkner | but i'm not sure what you want with nested menus | 17:00 |
| th1a | No, that's an aside. | 17:00 |
| aelkner | i don't see why we can't just add the drop down as another <li> | 17:00 |
| th1a | A nested menu, like you go to Score Systems > and that opens up the list of scrore systems. | 17:00 |
| aelkner | please explain 'go to Score Systems' | 17:01 |
| th1a | For example, go to your Ubuntu Applications menu. | 17:01 |
| th1a | Nested menus! | 17:01 |
| th1a | Score Systems > is in the Ave menu. | 17:02 |
| th1a | "is" meaning "should be" | 17:02 |
| aelkner | i see | 17:02 |
| aelkner | so Score Systems is in the menu, when the user hovers over it a submenu appears | 17:04 |
| aelkner | with all the choices and if the user clicks one the choice takes effect | 17:04 |
| aelkner | we loose the feature of dopdowns that way | 17:04 |
| th1a | Hm? | 17:05 |
| aelkner | that is, a dopdown always shows you what is already chosen | 17:05 |
| aelkner | then you click on it, and you see the other choices | 17:05 |
| aelkner | it seems like a lot of effort to make it do the same thing in a different way | 17:05 |
| th1a | I don't know what you mean, aelkner. | 17:06 |
| aelkner | if we use the dropdown, then the job is very close to being done | 17:06 |
| aelkner | if not, we need to discuss how the user knows what is already chosen | 17:06 |
| th1a | How does he now? | 17:06 |
| aelkner | that's my point | 17:06 |
| aelkner | how indeed | 17:06 |
| aelkner | with the dropdown, it's easy to know | 17:07 |
| aelkner | users understand what dropdowns communicate | 17:07 |
| th1a | OK, don't worry about it aelkner. | 17:07 |
| aelkner | ok, here's the thing | 17:07 |
| th1a | aelkner: Everyone has been using nested menus -- dropdowns, if you will -- for decades. | 17:07 |
| aelkner | for instance, the ubuntu menu you refer to has no examples of a setting choice | 17:08 |
| aelkner | all the menu choices lead to an action | 17:09 |
| aelkner | mostly opening up an application | 17:09 |
| aelkner | but simply changing a preference choice | 17:09 |
| aelkner | we need another example of that | 17:09 |
| th1a | We don't have one now? | 17:09 |
| aelkner | you tell me, do we? | 17:10 |
| th1a | I've not found one. | 17:10 |
| th1a | And you haven't told me what it is. | 17:10 |
| aelkner | me neither | 17:10 |
| aelkner | i'm not saying it can't be done | 17:10 |
| aelkner | it's just that id we don't go with the dropdown, we need to discuss a visual queue of what is already chosen | 17:11 |
| aelkner | like a checkmark or somthing | 17:11 |
| aelkner | not out of the question | 17:11 |
| th1a | aelkner: Yes, of course. | 17:11 |
| th1a | wtf else would we do? | 17:11 |
| aelkner | so the user hovers | 17:11 |
| th1a | Click on Ave. | 17:11 |
| th1a | dropdown comes up. | 17:11 |
| th1a | hover over Score Systems > | 17:12 |
| th1a | see the list with the active one checked. | 17:12 |
| th1a | pick one, click. | 17:12 |
| aelkner | ok, sounds like a plan | 17:12 |
| * th1a facepalms. | 17:12 | |
| th1a | OK. | 17:12 |
| th1a | Fantastic. | 17:12 |
| aelkner | checkmark before or after the score system name? | 17:13 |
| th1a | Then we can get rid of Preferences. | 17:13 |
| th1a | Before. | 17:14 |
| aelkner | replaceafill, we still have the menu-clipping issues, right? | 17:14 |
| replaceafill | aelkner yes | 17:14 |
| aelkner | what are we going to do about that? | 17:14 |
| replaceafill | i'll work on that today | 17:15 |
| replaceafill | i made some other fixes yesterday | 17:15 |
| aelkner | i saw, already merged | 17:15 |
| replaceafill | but i'll start with that issue today | 17:15 |
| aelkner | ok, i noticed somthing | 17:15 |
| aelkner | you use jquery when you probably don't need to | 17:15 |
| aelkner | for the tr:odd thing | 17:15 |
| replaceafill | i prefer jquery to markup if that's what you mean | 17:16 |
| aelkner | you can use css for that: | 17:16 |
| aelkner | http://www.w3.org/Style/Examples/007/evenodd | 17:16 |
| replaceafill | is that csss2? | 17:17 |
| replaceafill | oops, css2? :) | 17:17 |
| aelkner | isn't it still valid? | 17:17 |
| aelkner | why would they get rid of a feature and force the programmer to replace it with executable js?! | 17:17 |
| aelkner | it doesn't seem to make sense | 17:18 |
| th1a | I'm sure you can do it either way. | 17:18 |
| replaceafill | http://reference.sitepoint.com/css/pseudoclass-nthchild | 17:18 |
| replaceafill | i try to stay away from css3 | 17:19 |
| yvl | or http://www.w3schools.com/cssref/sel_nth-child.asp | 17:19 |
| aelkner | yvl, is css3 a bad idea for us? | 17:19 |
| replaceafill | aelkner but i'll look into it | 17:19 |
| aelkner | is it bad for browser support? | 17:20 |
| yvl | http://www.quirksmode.org/css/contents.html | 17:20 |
| yvl | search for nth-child | 17:20 |
| yvl | (quirksmode is awesome) | 17:20 |
| replaceafill | yvl +1 | 17:20 |
| aelkner | looks it | 17:21 |
| yvl | IMHO that should f up most of Critical links deployments | 17:21 |
| aelkner | so IE6, 7 and 8 would not support it | 17:21 |
| aelkner | so js is probably best here, right? | 17:22 |
| yvl | (but that's just a hunch, I think they're using old browsers) | 17:22 |
| yvl | better, aelkner | 17:22 |
| aelkner | ok | 17:22 |
| aelkner | yvl, a question | 17:22 |
| aelkner | why did you change one of the view python sources to include flourish classes explicitly? | 17:23 |
| yvl | well | 17:23 |
| yvl | if you do from schooltool.skin import flourish | 17:23 |
| aelkner | i have found that from schooltool.skin import flourish is enough | 17:23 |
| yvl | python will not import flourish modules | 17:23 |
| yvl | yes, but you have not tried running tests | 17:24 |
| yvl | if the module is imported somewhere, all works | 17:24 |
| aelkner | i'm able to use flourish.page.PAge | 17:24 |
| yvl | yes | 17:24 |
| yvl | since when zope is starting up | 17:24 |
| yvl | all manner of things is imported | 17:24 |
| yvl | but if you run stand-alone unit tests, the import may or may not happen | 17:25 |
| aelkner | yeah, but we haven't been unit testing views for years now | 17:25 |
| yvl | so? | 17:25 |
| aelkner | so why the issue? | 17:25 |
| yvl | because I run tests | 17:25 |
| aelkner | unit tests on these view classes? | 17:25 |
| yvl | yes | 17:26 |
| yvl | on others | 17:26 |
| yvl | old ones | 17:26 |
| yvl | if you write the tests though, you will not be able to run them | 17:26 |
| yvl | because imports are wrong | 17:26 |
| yvl | even if they work when the whole system is up | 17:26 |
| aelkner | functional tests? | 17:26 |
| yvl | unit tests | 17:26 |
| yvl | let's put it this way: | 17:26 |
| yvl | yes, it works | 17:27 |
| yvl | yes, it is plain wrong not to do those includes | 17:27 |
| aelkner | ok, but we don't have any plans to unit tests views in the near future | 17:27 |
| yvl | your choice | 17:27 |
| aelkner | we don't even have time alloted for functional tests, so... | 17:27 |
| yvl | if you want to write bad code, it's your choice | 17:27 |
| yvl | I'll fix it | 17:27 |
| yvl | from time to time | 17:27 |
| replaceafill | is there anything wrong with using 'from schooltool.skin.flourish.form import Form'? | 17:27 |
| aelkner | nah, that's ok | 17:27 |
| yvl | replaceafill, no | 17:27 |
| replaceafill | yvl phew! | 17:27 |
| replaceafill | :D | 17:28 |
| * yvl is playing with flourish.something.something notation | 17:28 | |
| replaceafill | ah | 17:28 |
| aelkner | i'd say, don't bother with these imports if the tests that we have are not broken | 17:28 |
| yvl | but the imports bite a bit | 17:28 |
| yvl | they. are. broken. | 17:28 |
| aelkner | but if they are, then we need those imports | 17:28 |
| yvl | that's why I fixed those | 17:28 |
| yvl | I was fixing the tests | 17:28 |
| aelkner | i see | 17:28 |
| yvl | and they were not working | 17:28 |
| aelkner | never mind | 17:28 |
| yvl | ok :) | 17:29 |
| aelkner | yvl, thanks for indulging the discussion | 17:29 |
| yvl | apologies for lack of patience on my part. really. | 17:29 |
| aelkner | np | 17:29 |
| aelkner | th1a, i have plenty to do for now, but we should discuss management things soon | 17:30 |
| aelkner | like report sheet templates and managing score systems | 17:30 |
| aelkner | tomorrow, perhaps? | 17:30 |
| th1a | Sure. | 17:31 |
| aelkner | ok, that's it for me | 17:31 |
| th1a | Note that replaceafill might do those views while you start interventions, or vice versa. | 17:31 |
| th1a | replaceafill: Have you touched interventions at all? | 17:31 |
| th1a | Ever? | 17:32 |
| replaceafill | th1a hhmm no | 17:32 |
| th1a | OK, so probably replaceafill should do those management views. | 17:32 |
| th1a | We'll see. | 17:32 |
| th1a | Thanks aelkner. | 17:32 |
| th1a | replaceafill? | 17:32 |
| replaceafill | ok, yesterday i cleaned the gradebook overview template and created three parts | 17:33 |
| replaceafill | students on the left | 17:33 |
| replaceafill | grades on the center | 17:33 |
| replaceafill | and totals on the right | 17:33 |
| replaceafill | added some js to calculate the width of the grades area | 17:33 |
| replaceafill | that's what gives you the central scroll | 17:33 |
| replaceafill | also added a placeholder for empty worksheets | 17:33 |
| replaceafill | and fixed the window.onload issue that was preventing FF5 to work | 17:34 |
| replaceafill | it was the use of 'class' in a js file | 17:34 |
| replaceafill | FF5 seems picky :) | 17:34 |
| replaceafill | ah, and updated the zoom buttons to this changes | 17:34 |
| replaceafill | as aelkner noticed, also added even/odd row colors | 17:35 |
| replaceafill | today, i'll work on the menu clipping issue | 17:35 |
| th1a | Can you add a line to the right margin in "Name" so that it doesn't flow into the first column sometimes when scrolling? | 17:35 |
| th1a | How much Journal related stuff is there now? | 17:36 |
| replaceafill | well, i've been updating the journal template every time i change something in the gradebook, and yesterday the gradebook template changed a lot, so i have to sync again | 17:36 |
| replaceafill | and i need the 'section preferences' feature in core to fix the Journal tab | 17:37 |
| replaceafill | so we know where to redirect the user to | 17:37 |
| th1a | OK. | 17:37 |
| replaceafill | th1a could you please explain a little about the line to the right margin in Name? | 17:38 |
| replaceafill | you mean an empty column? | 17:38 |
| replaceafill | or a border? | 17:38 |
| th1a | Border. | 17:38 |
| th1a | It is just that if you scroll the center area right a few pixels, then there is no line between name and the first column. | 17:38 |
| replaceafill | ah | 17:39 |
| replaceafill | right | 17:39 |
| replaceafill | i'll fix it | 17:39 |
| th1a | OK. Wrapping up. | 17:39 |
| th1a | I'm hoping to have a screencast done tomorrow. | 17:40 |
| replaceafill | i also have to fix this scenario: http://69.164.203.135:6660/schoolyears/2010/q1/sections/1/activities/Another%20Worksheet/gradebook | 17:40 |
| replaceafill | tom:tom | 17:40 |
| th1a | Today was our feature freeze deadline. We did pretty well. A few loose ends, but I'm not worried. | 17:40 |
| th1a | replaceafill: OK. | 17:42 |
| replaceafill | that's it from me | 17:42 |
| th1a | Thanks, replaceafill. | 17:42 |
| th1a | Last important thing: | 17:42 |
| th1a | The REAL serious deadline is two weeks -- August 25. | 17:43 |
| th1a | I want that to be string freeze so we can give people a chance to do translations. | 17:43 |
| th1a | So actually that's mostly on me. | 17:43 |
| th1a | But obviously all the views have to be in pretty much final form. | 17:43 |
| th1a | But there will be a lot of changes in the translations, and we need to give people time. | 17:44 |
| th1a | OK. That's it. | 17:44 |
| th1a | Thanks guys. Great work getting us within striking distance and looking good for on-time release. | 17:44 |
| * th1a drops the bag of gravel. | 17:45 | |
| *** aks has joined #schooltool | 18:40 | |
| replaceafill | th1a zyt? | 18:48 |
| th1a | y | 18:48 |
| replaceafill | http://69.164.203.135:6660/schoolyears/2010/q1/sections/1/activities/Worksheet/gradebook | 18:48 |
| replaceafill | tom:tom | 18:48 |
| replaceafill | check the borders | 18:48 |
| replaceafill | i want to see if you note something that it's bothering me :D | 18:48 |
| replaceafill | you using FF or Chrome? | 18:48 |
| th1a | Chrome | 18:48 |
| replaceafill | ah ok | 18:49 |
| replaceafill | you'll notice then | 18:49 |
| th1a | Uh? | 18:49 |
| replaceafill | it's the collapsing of the right border of students with left border of grades | 18:49 |
| replaceafill | do you see it? | 18:49 |
| replaceafill | and right border of grades with left border of totals | 18:50 |
| replaceafill | not a big deal though | 18:50 |
| th1a | I'm not sure what you mean. | 18:50 |
| th1a | Collapsing? | 18:50 |
| replaceafill | yes, since they're different divs, you get two borders like || | 18:51 |
| th1a | Where? | 18:51 |
| replaceafill | between student name and the first activity | 18:51 |
| replaceafill | or maybe it's just my chrome :P | 18:51 |
| replaceafill | FF 3.5 - 5 show it right | 18:51 |
| th1a | I'm not seeing it. | 18:51 |
| replaceafill | ah ok | 18:51 |
| replaceafill | never mind then | 18:52 |
| replaceafill | th1a are we putting back the cell color notation for scores: green -> good, yellow -> extracredit, red->bad? | 18:54 |
| replaceafill | or could that wait until we get schwas design? | 18:55 |
| th1a | Wait. | 18:56 |
| replaceafill | kk | 18:56 |
| replaceafill | aelkner you there? | 19:05 |
| replaceafill | changed pushed to gradebook trunk: "Fixed popup menu issue and set border appropriately" | 19:10 |
| aelkner | replaceafill, looking... | 19:14 |
| aelkner | replaceafill, so when does updateWidths get called? | 19:20 |
| aelkner | and how does it know what to do? | 19:20 |
| aelkner | in other words, it looks complex and hacky, so some code comments might help | 19:22 |
| aelkner | i know it's a complex problem you're needing to solve there, but it would help if you communicated | 19:22 |
| aelkner | your logic with some simple comments | 19:22 |
| replaceafill | aelkner any comments on the fix for the popup issue? ;) | 19:24 |
| replaceafill | aelkner updateWidths (not the best name) is called on window's load event | 19:25 |
| replaceafill | it needs to be there instead of $(document).ready(), because some browsers like chrome cannot calculate the widths before | 19:26 |
| replaceafill | like in $(document).ready() | 19:26 |
| replaceafill | that ^ should be the XXX comment :) | 19:26 |
| aelkner | indeed, very fragile | 19:27 |
| replaceafill | fragile? | 19:27 |
| aelkner | i mean, if code can't be moved easily, then it's fragile and should have some comment | 19:28 |
| replaceafill | it's because we're setting window.onload INSIDE the <body>! | 19:28 |
| aelkner | saying, don't move this | 19:28 |
| aelkner | rally? | 19:28 |
| aelkner | really? | 19:28 |
| replaceafill | window.onload should be set on <head> | 19:28 |
| aelkner | ah, the div is inside body | 19:28 |
| replaceafill | ;) | 19:28 |
| aelkner | you know, it doesn't need to be there | 19:29 |
| aelkner | how do we put things in head at this point? | 19:29 |
| aelkner | we used to use macros and fill extrahead | 19:29 |
| replaceafill | file resource | 19:29 |
| aelkner | ah | 19:29 |
| replaceafill | we already have js for that | 19:29 |
| replaceafill | i'll wait until we decide what to keep from f_gradebook_overview.js | 19:30 |
| aelkner | is there any reason that we can't move all the jqeury stuff to the js file? | 19:30 |
| replaceafill | for instance, maybe we don't need the coloring stuff | 19:30 |
| aelkner | the old js stuff would be harder to move | 19:30 |
| aelkner | because it depends on stuff in the view class | 19:30 |
| aelkner | but the $(window).load(function() { | 19:31 |
| aelkner | $(document).ready(function() { | 19:31 |
| aelkner | that studd could be moved to the js file, right? | 19:31 |
| replaceafill | yep | 19:31 |
| aelkner | then the problem that you are working around goes away, right? | 19:31 |
| replaceafill | yep | 19:31 |
| aelkner | could you do that, then? | 19:31 |
| replaceafill | now? | 19:31 |
| replaceafill | sure | 19:32 |
| replaceafill | just look for all gradebook js, there ok | 19:32 |
| aelkner | while the hack is fresh in your mind | 19:32 |
| aelkner | easier to remove it now than later is all i'm thinking | 19:32 |
| aelkner | also, why not get into the habit of adding stuff like that to the js file | 19:32 |
| replaceafill | we should, since we have it | 19:33 |
| aelkner | or start the habit, more simply put | 19:33 |
| replaceafill | it's ok if we don't have js resources in some views, but we do in the gradebook | 19:33 |
| aelkner | the old js that depends on the view class could be moved to a viewlet, but that's more involved | 19:33 |
| aelkner | and it's older stuff, less helpfl to touch | 19:33 |
| replaceafill | nah! i'll just add a comment XXX: old stuff | 19:34 |
| replaceafill | old skin functions ;) | 19:34 |
| aelkner | oh, you think we can move that, too? | 19:34 |
| replaceafill | flourish code | 19:34 |
| aelkner | when the file resource is being included | 19:34 |
| replaceafill | i was thinking of using yvl's flourish js | 19:34 |
| aelkner | does it have access to the view class at that point? | 19:35 |
| replaceafill | no | 19:35 |
| aelkner | so how could you move it? | 19:35 |
| replaceafill | that needs to stay in the template | 19:35 |
| aelkner | right, that'sw what i was saying | 19:35 |
| aelkner | but you sounded like you didn't think so | 19:35 |
| replaceafill | no, not at all | 19:35 |
| replaceafill | i was tihnking of $document.read() and window.load | 19:35 |
| replaceafill | only | 19:35 |
| aelkner | right, so that needs to go to the end of the js file | 19:36 |
| replaceafill | correct | 19:36 |
| aelkner | because it calls into the motheds defined earlier | 19:36 |
| replaceafill | have you synced with trunk? | 19:36 |
| aelkner | i have | 19:36 |
| replaceafill | did you check the popups? | 19:36 |
| replaceafill | do they look ok? | 19:36 |
| aelkner | not yet, i was here with you :) | 19:36 |
| aelkner | looking... | 19:36 |
| aelkner | nice! | 19:37 |
| aelkner | i was gong to ask you about the css i saw | 19:37 |
| replaceafill | yes? | 19:37 |
| aelkner | .schooltool > .grid:after { | 19:37 |
| aelkner | content: " "; | 19:38 |
| aelkner | could you explain the logic involved with these? | 19:38 |
| aelkner | and anything else that explains how you got the menus to overlay the containing div | 19:38 |
| replaceafill | ah ok | 19:39 |
| aelkner | :after | 19:39 |
| aelkner | what is that, firstly | 19:39 |
| aelkner | .grid > .body { overflow: visible | 19:39 |
| replaceafill | pseudo class for defining something "after" a element | 19:39 |
| replaceafill | hold on, let me explain | 19:39 |
| replaceafill | 1. there were some old overflow: auto's that i removed | 19:40 |
| replaceafill | the gradebook is composed now by 3 divs | 19:40 |
| replaceafill | students, grades and totals, right? | 19:40 |
| aelkner | ok | 19:40 |
| replaceafill | again, done that way to get the central scrollbar | 19:40 |
| replaceafill | but the divs had some overflow: auto | 19:41 |
| aelkner | which does what? | 19:41 |
| replaceafill | which prevented students and totals to "expand" | 19:41 |
| replaceafill | overflow: auto is what gives us the scrollbar in grades | 19:41 |
| aelkner | auto difers to the containing element css? | 19:41 |
| replaceafill | when the content is wider than the width | 19:41 |
| aelkner | defers | 19:41 |
| replaceafill | for example if we set a width: 40px in an element | 19:42 |
| replaceafill | and set overflow: auto on it | 19:42 |
| replaceafill | but its content has like 80px wide | 19:42 |
| replaceafill | you get the scrollbar | 19:42 |
| replaceafill | so we want that property only on grades | 19:42 |
| replaceafill | not on students and totals | 19:42 |
| *** menesis has quit IRC | 19:43 | |
| replaceafill | that was the first change | 19:43 |
| replaceafill | after doing that you get the popup in the last student for example | 19:43 |
| aelkner | wait | 19:43 |
| replaceafill | vertical overflow | 19:43 |
| replaceafill | yes? | 19:43 |
| aelkner | you get the scrollbar when the content gets too wide with auto | 19:43 |
| replaceafill | yes | 19:44 |
| aelkner | so the students div had that setting? | 19:44 |
| replaceafill | yes | 19:44 |
| replaceafill | but the div doesnt need it | 19:44 |
| replaceafill | its content does | 19:44 |
| aelkner | then why no scrollbarwhen the menu overflowed | 19:44 |
| replaceafill | like the th, tds in the table inside | 19:44 |
| aelkner | i'm trying to understand the old problem | 19:44 |
| replaceafill | because the menu is absolute positioned | 19:45 |
| aelkner | oh | 19:45 |
| replaceafill | it gets out of the flow | 19:45 |
| replaceafill | you can set something absolut positioned anywhere | 19:45 |
| replaceafill | (almost) | 19:45 |
| aelkner | positioning and overflow are tricky | 19:45 |
| aelkner | the way they work together, i mean | 19:45 |
| aelkner | but i think i see what you're saying | 19:45 |
| th1a | A good book on CSS is helpful. | 19:46 |
| aelkner | the absolute position is a luzury | 19:46 |
| replaceafill | :D | 19:46 |
| aelkner | luxury | 19:46 |
| aelkner | which you need from time to time | 19:46 |
| replaceafill | i recomend erick meyer's ;) | 19:46 |
| replaceafill | anyway | 19:46 |
| aelkner | link? | 19:46 |
| replaceafill | for your first question | 19:46 |
| replaceafill | for the book? hold on | 19:46 |
| replaceafill | it's called smashing css | 19:46 |
| replaceafill | google it :) | 19:46 |
| replaceafill | there you can read about some of the stuff we've been using :P | 19:47 |
| replaceafill | like overflow instead of clearfix | 19:47 |
| replaceafill | which is the answer to your first question | 19:47 |
| replaceafill | the :after pseudoclass | 19:47 |
| replaceafill | in the old times that was the way to make divs expand vertically according to its content | 19:48 |
| replaceafill | now, there are tecniques like containing floats | 19:48 |
| replaceafill | if you have one div taht contains another | 19:48 |
| replaceafill | the first div height wont' be calculated according to the second one | 19:48 |
| replaceafill | only according to its content | 19:49 |
| replaceafill | so, you if you set float properties on both | 19:49 |
| replaceafill | the container div height is calculated correctly | 19:49 |
| replaceafill | thanks to the float specification, iirc | 19:49 |
| replaceafill | in our case | 19:50 |
| replaceafill | we have a header | 19:50 |
| replaceafill | a body | 19:50 |
| replaceafill | and a footer | 19:50 |
| replaceafill | the body needs to calculate its height according to all our content | 19:50 |
| replaceafill | forms,, tables, etc | 19:50 |
| replaceafill | we use overflow: auto to do that :) | 19:51 |
| replaceafill | since we set widths precisely | 19:51 |
| replaceafill | on all our elements | 19:51 |
| replaceafill | (well, almost :D) | 19:51 |
| replaceafill | so, we don't get the horizontal scrollbar | 19:51 |
| replaceafill | (sometimes we do...) | 19:51 |
| replaceafill | (when something gets broken) | 19:52 |
| replaceafill | like an unclosed <div> | 19:52 |
| replaceafill | anyway, :after allow us to set empty content after the element | 19:52 |
| replaceafill | that's why you see content: " " | 19:52 |
| replaceafill | but you dont want to show it | 19:53 |
| replaceafill | so visibility hidden | 19:53 |
| replaceafill | you don't use display: none | 19:53 |
| replaceafill | because that would take it out of the flow | 19:53 |
| aelkner | display effects flow | 19:53 |
| aelkner | visibility, not | 19:53 |
| replaceafill | correct | 19:54 |
| replaceafill | so the trick (as you say) is extra content not visible with clear both | 19:54 |
| aelkner | the flow is like a math equation being calulated as the browser scans the elements | 19:54 |
| replaceafill | that makes the container div to expand vertically | 19:54 |
| replaceafill | and calculate its height appropriately | 19:54 |
| replaceafill | and that's it :D | 19:54 |
| replaceafill | sorry for the long rant | 19:54 |
| aelkner | no, i appreciate it | 19:55 |
| aelkner | and it underscores how complex and hacky the problem/solution is | 19:55 |
| replaceafill | it's been used for years aelkner :) | 19:55 |
| aelkner | fair enough | 19:55 |
| aelkner | one has to be fluent in the whole flow math and the css properties that effect it and how | 19:56 |
| replaceafill | i hope html5 solves all these issues someday | 19:56 |
| aelkner | anyway, thanks for the explanation | 19:56 |
| replaceafill | to finish, that last "hack" was needed for the right popup | 19:57 |
| replaceafill | on average | 19:57 |
| replaceafill | so it can come up all its parents | 19:57 |
| aelkner | which hack? | 19:57 |
| replaceafill | the :after | 19:57 |
| th1a | aelkner: It is ultimately too complicated to just pick up by osmosis. You need to grok the underlying principles. | 19:57 |
| aelkner | th1a, i can see that | 19:57 |
| aelkner | i'm going to get the smashing css book | 19:58 |
| replaceafill | +1 | 19:58 |
| * replaceafill always keeps looking for css books | 19:58 | |
| replaceafill | :) | 19:58 |
| replaceafill | more after portugal ;) | 19:59 |
| replaceafill | anyway, let me know if something gets broken visually | 19:59 |
| replaceafill | i'll make the js changes | 19:59 |
| aelkner | will do, thanks | 19:59 |
| *** aelkner_ has joined #schooltool | 20:21 | |
| *** aelkner has quit IRC | 20:27 | |
| replaceafill | change pushed to trunk "Moved static JS code out of the gradebook overview template" | 20:43 |
| replaceafill | it is not possible to remove the $(window).load(...) :( | 20:43 |
| replaceafill | chrome loads js and css in parallel! | 20:44 |
| * replaceafill goes to get lunch | 21:01 | |
| *** replaceafill has quit IRC | 21:01 | |
| *** alga has quit IRC | 21:09 | |
| *** aks has quit IRC | 21:12 | |
| *** replaceafill has joined #schooltool | 21:46 | |
| th1a | replaceafill: We probably need an additional step in pack database. | 21:59 |
| th1a | That is, the dialog should let you pack or cancel. | 21:59 |
| replaceafill | ah ok | 21:59 |
| th1a | Primarily so that we can explain what is happening. | 21:59 |
| replaceafill | yes | 22:00 |
| th1a | (Since there is really no reason not to) | 22:00 |
| replaceafill | ok, i'll change the dialog | 22:00 |
| replaceafill | th1a text for the dialog? | 22:00 |
| th1a | Do you remember if packing automatically makes a backup? | 22:00 |
| replaceafill | not really | 22:00 |
| replaceafill | i can check | 22:00 |
| th1a | I will. | 22:01 |
| th1a | Ooh. | 22:02 |
| th1a | It doesn't like it if you try to pack the database when not logged in. | 22:02 |
| th1a | (you get a login in the dialog) | 22:02 |
| replaceafill | ah yes | 22:02 |
| replaceafill | the time out issue | 22:03 |
| replaceafill | th1a it does create Data.fs.old | 22:03 |
| th1a | OK. | 22:03 |
| replaceafill | th1a now that you're in Server :) | 22:03 |
| replaceafill | i have a comment | 22:03 |
| replaceafill | about Calendar | 22:03 |
| replaceafill | when you go to Calendar | 22:03 |
| replaceafill | make a change | 22:03 |
| replaceafill | there's no way to tell the user the change was applied | 22:04 |
| replaceafill | like in other forms, when they redirect the user usually sees something changed | 22:04 |
| th1a | No way to or doesn't? | 22:04 |
| replaceafill | sorry, doesn't | 22:04 |
| th1a | There is no view. | 22:05 |
| replaceafill | correct, just edit form | 22:05 |
| replaceafill | should we add the Calendar settings to the /server? | 22:05 |
| th1a | Oh... | 22:05 |
| th1a | I guess. | 22:06 |
| replaceafill | Calendar (pencil) | 22:07 |
| replaceafill | and remove the left link | 22:07 |
| th1a | Yes. | 22:07 |
| replaceafill | kk | 22:07 |
| th1a | I almost don't want people to find that because I'm afraid they'll mess up the calendar timezone. | 22:08 |
| replaceafill | hhmmm we could make a view then | 22:08 |
| replaceafill | Calendar takes you to the index view and we put the pencil in it | 22:08 |
| th1a | Well, they do need to adjust the other things though anyhow. | 22:10 |
| th1a | So I just have to let go of my fear. | 22:10 |
| replaceafill | :) | 22:10 |
| replaceafill | k, i'll add the calendar settings to /server then | 22:10 |
| replaceafill | another small papercut: | 22:11 |
| replaceafill | - /demographics and /resource_demographics show non translatable text for Type. The values are extracted from the python class names. Should we make them translatable? It will show Bool instead of Yes/No. | 22:11 |
| th1a | Bool? | 22:12 |
| th1a | We really can't get around that? | 22:13 |
| replaceafill | we have classes like BoolFieldDescription, EnumFieldDescription | 22:13 |
| replaceafill | and the column shows Bool, Enum, etc | 22:13 |
| replaceafill | in the UI the label is Yes/No field for instance | 22:13 |
| th1a | Why is that more translatable? | 22:13 |
| replaceafill | i think we should use the same wording of the Add menu | 22:15 |
| replaceafill | Text, Description, Date | 22:15 |
| th1a | I don't understand. | 22:15 |
| th1a | I just don't want bool. | 22:15 |
| replaceafill | that what we get right now | 22:15 |
| th1a | Why is it easier to translate if the english is bool? | 22:15 |
| replaceafill | http://69.164.203.135:6660/demographics | 22:15 |
| replaceafill | see ethnicity | 22:16 |
| th1a | I just don't want bool. | 22:16 |
| replaceafill | you're ok with Enum? | 22:16 |
| th1a | No. | 22:16 |
| replaceafill | ah ok | 22:16 |
| th1a | I don't know why you said "it will show bool instead of yes/no" | 22:17 |
| th1a | That's if we fix it? | 22:17 |
| replaceafill | ah no | 22:17 |
| replaceafill | that's what it does | 22:17 |
| *** menesis has joined #schooltool | 22:17 | |
| replaceafill | sorry, my english is getting you confused :( | 22:17 |
| th1a | OK. Your use of future tense is what confused me. | 22:17 |
| replaceafill | "It shows Bool instead of Yes/No" | 22:17 |
| replaceafill | i write my papercuts usually in a hurry ;) | 22:18 |
| replaceafill | just to not forgetting them | 22:18 |
| replaceafill | :D | 22:18 |
| th1a | Yes, make it translatable, and also not jargon in English. | 22:18 |
| replaceafill | don't you think we could use the expanded page for this page? | 22:19 |
| replaceafill | to get more space for the table | 22:19 |
| replaceafill | hhmm actually, the other columns are just check marks... so maybe not | 22:19 |
| replaceafill | i'm just thinking of "Selection List" | 22:19 |
| th1a | It could go either way. | 22:21 |
| th1a | Selection List instead of enum, correct? | 22:21 |
| replaceafill | yes | 22:21 |
| th1a | Or just list. | 22:21 |
| replaceafill | it could expand to two lines, like Place of birth does currently | 22:21 |
| replaceafill | ah | 22:22 |
| replaceafill | k, i'll use List | 22:22 |
| replaceafill | list sounds multiple-ish | 22:22 |
| replaceafill | "several ethnicities" | 22:22 |
| replaceafill | option list or something...? | 22:23 |
| th1a | several ethnicities? | 22:25 |
| replaceafill | List makes you think of multiple values | 22:25 |
| replaceafill | but that's just me maybe | 22:25 |
| th1a | Oh... can we remove that from the default, btw. | 22:25 |
| replaceafill | ? | 22:26 |
| th1a | Ethnicity. | 22:26 |
| replaceafill | ah | 22:26 |
| replaceafill | ok | 22:26 |
| th1a | Just hack it right out. | 22:26 |
| replaceafill | th1a are we putting the Errors views under /server? | 22:33 |
| th1a | Yes. | 22:33 |
| replaceafill | (i'm just reviewing my TODO) | 22:34 |
| replaceafill | ah ok | 22:34 |
| * th1a goes to the grocery store. | 22:46 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!