| *** asharma has quit IRC | 00:01 | |
| th1a | replaceafill: Yeah, make add black. | 00:36 |
|---|---|---|
| replaceafill | ok | 00:36 |
| replaceafill | done | 00:37 |
| th1a | You know, this is looking pretty good. | 00:38 |
| * replaceafill is happy th1a is kind of happy :) | 00:38 | |
| replaceafill | hey! | 00:38 |
| *** jelkner has quit IRC | 00:39 | |
| replaceafill | the breadcrumbs! | 00:39 |
| th1a | Yes? | 00:39 |
| replaceafill | i forgot about them | 00:39 |
| replaceafill | i have to move them right? | 00:39 |
| th1a | Also, if you need something to do, fix the login screen. | 00:39 |
| th1a | You can. | 00:39 |
| replaceafill | can i port the edit view for persons? | 00:39 |
| replaceafill | and put the "Edit" link in the person view? | 00:39 |
| replaceafill | :) | 00:39 |
| th1a | Well, we can't view a person yet. | 00:40 |
| replaceafill | ok | 00:40 |
| th1a | So you could do that first! | 00:42 |
| replaceafill | th1a we can view persons | 00:42 |
| replaceafill | that's the accordion page | 00:42 |
| replaceafill | isnt it? | 00:42 |
| th1a | Demographics. | 00:43 |
| th1a | And other info. | 00:43 |
| replaceafill | ah, ok | 00:43 |
| replaceafill | true | 00:43 |
| replaceafill | ok, so 1. breadcrumbs, 2. login screen | 00:43 |
| replaceafill | if you remember something else let me know | 00:43 |
| aelkner | th1a, should we create a viewlet for demographics? | 00:54 |
| aelkner | i was thinking if the demographics viewlet had core attributes followed by demos | 00:57 |
| aelkner | it would always have at least the core attributes to display, and we could make it the default opened accordion | 00:58 |
| aelkner | it could also be a table like the ones we've been using in sections and groups | 00:58 |
| aelkner | Field | Value | 00:58 |
| aelkner | last_name | Smith | 00:59 |
| aelkner | my_demo | some value | 00:59 |
| aelkner | as it is, we changed the person edit views recently to have two fieldsets, core and demos | 01:00 |
| aelkner | so the viewlet would be rendering the same fields in the same order, just in a table | 01:01 |
| replaceafill | th1a http://69.164.203.135:6660/persons breacrumbs | 01:15 |
| replaceafill | feels like a css hack :/ | 01:15 |
| th1a | replaceafill: What's the hack? | 01:24 |
| th1a | aelkner: I think we're on the same page. | 01:25 |
| replaceafill | the breadcrumbs are inside the secondary navigation as a <li> | 01:25 |
| th1a | So? | 01:25 |
| replaceafill | i used absolute positioning for take them out | 01:25 |
| replaceafill | the right solution should be having two <ul> :) | 01:25 |
| replaceafill | at the same level | 01:26 |
| th1a | aelkner: Advisors should also be tables. | 01:27 |
| th1a | And advisees... | 01:27 |
| *** alga has quit IRC | 01:49 | |
| replaceafill | th1a http://69.164.203.135:6660/auth/@@login.html | 01:52 |
| replaceafill | th1a http://69.164.203.135:6660/persons/addAdministrator.html raise an error | 02:35 |
| * replaceafill goes out | 02:35 | |
| *** replaceafill has quit IRC | 02:36 | |
| *** th1a has quit IRC | 02:53 | |
| *** aelkner has quit IRC | 02:53 | |
| *** th1a has joined #schooltool | 02:59 | |
| *** aelkner has joined #schooltool | 02:59 | |
| *** ignas has quit IRC | 03:16 | |
| *** issyl0 has quit IRC | 04:46 | |
| *** issyl0 has joined #schooltool | 04:47 | |
| *** issyl0 is now known as Guest96732 | 04:47 | |
| *** fsufitch has joined #schooltool | 04:49 | |
| *** replaceafill has joined #schooltool | 06:04 | |
| *** aks has joined #schooltool | 06:06 | |
| *** aks has joined #schooltool | 06:06 | |
| *** replaceafill has quit IRC | 06:09 | |
| *** th1a has quit IRC | 07:21 | |
| *** yvl has joined #schooltool | 09:18 | |
| *** alga has joined #schooltool | 09:41 | |
| *** alga has quit IRC | 10:00 | |
| *** alga has joined #schooltool | 10:51 | |
| *** ignas has joined #schooltool | 11:14 | |
| *** menesis has joined #schooltool | 11:40 | |
| *** menesis has quit IRC | 14:08 | |
| *** aks has quit IRC | 14:19 | |
| *** menesis has joined #schooltool | 14:40 | |
| *** th1a has joined #schooltool | 15:02 | |
| *** replaceafill has joined #schooltool | 15:19 | |
| *** replaceafill has quit IRC | 15:23 | |
| *** replaceafill has joined #schooltool | 15:23 | |
| * replaceafill updates the testing instance | 16:25 | |
| th1a | hi replaceafill, aelkner, yvl, menesis. | 16:30 |
| th1a | I have some good news and some bad news. | 16:30 |
| replaceafill | good morning/afternoon | 16:30 |
| th1a | Good news, I'm going to hard limit the "official" meetings the next two days to an hour. | 16:30 |
| th1a | Bad news, I think we need to keep having daily meetings for at least another week. | 16:31 |
| th1a | replaceafill: Did you get an error when you tried to run flourish trunk? | 16:31 |
| aelkner | morning | 16:31 |
| yvl | good morning guys | 16:31 |
| replaceafill | th1a NO | 16:31 |
| th1a | oh... it is me I guess... | 16:32 |
| menesis | hi | 16:32 |
| th1a | That's right, I was messing with the buildout yesterday. | 16:33 |
| th1a | That's right, I was messing with the buildout yesterday. | 16:33 |
| th1a | Oops. | 16:33 |
| th1a | Anyhow. | 16:33 |
| th1a | yvl: What did you do on the night shift? | 16:33 |
| yvl | well | 16:34 |
| yvl | reversed person name order | 16:34 |
| yvl | created flourish branches for intervention, journal and gradebook | 16:34 |
| yvl | put links for each in top bar | 16:34 |
| yvl | ported intervention to use updated traverser directives | 16:35 |
| yvl | that's about it | 16:35 |
| th1a | Should I be seeing that in the testing instance? | 16:36 |
| replaceafill | i think in need to include those new branches in the testing instance buildout | 16:36 |
| replaceafill | correct, yvl? | 16:36 |
| yvl | yes | 16:36 |
| * replaceafill goes to do it | 16:37 | |
| yvl | I did not merge Douglas or Alan work | 16:37 |
| yvl | there were no commits in your branches | 16:37 |
| replaceafill | sorry that i've been pushing to trunk :( | 16:37 |
| yvl | that's ok | 16:38 |
| th1a | So basically my goal for this week -- the next two days, is to get the core set of person views done. | 16:38 |
| th1a | And then we need to turn the corner and just start grinding through the rest of the app. | 16:39 |
| th1a | Do you guys have any thoughts or feelings about how that should be organized? | 16:39 |
| th1a | Do you each just want to take a component and do the whole thing? | 16:40 |
| th1a | Or should we do this assembly line fashion? | 16:40 |
| th1a | yvl plumbs; aelkner puts up the walls; replaceafill paints? | 16:40 |
| aelkner | replaceafill, just pushed some changes to trunk, please pull to instance | 16:40 |
| replaceafill | aelkner ok | 16:40 |
| th1a | assembly line might be better for consistency. | 16:41 |
| aelkner | got the advisrory tables to work | 16:41 |
| th1a | Ah. Good. | 16:42 |
| replaceafill | testing instance updated with all the plugins enabled | 16:44 |
| th1a | OK, things to do today. | 16:44 |
| th1a | Switch to using the LP edit icon. | 16:45 |
| th1a | Next to the relevant table labels. | 16:45 |
| th1a | This should of course only show up when appropriate by permission. | 16:45 |
| th1a | I guess I'll give that task to replaceafill. | 16:46 |
| th1a | We need to create UWG views for editing advisors, advisees, groups. | 16:46 |
| th1a | We need a UWG compliant dialog (they call them overlays, I think) for preferences. | 16:47 |
| replaceafill | aelkner please remove that <div> </div> in advisoryViewlet.pt | 16:47 |
| th1a | WAAAA! | 16:47 |
| th1a | https://spreadsheets.google.com/spreadsheet/ccc?key=0AnUw5wdlJ-oLdERaX0c3OHBiSzJfUFVBWHViM0hmTnc&hl=en_US | 16:48 |
| th1a | Look at the person page. | 16:48 |
| aelkner | i didn't even see it | 16:48 |
| th1a | Ah, aelkner can work on making all the add person pages capable of going directly to adding another person. | 16:49 |
| th1a | Need a reports view (table) | 16:50 |
| aelkner | replaceafill, pushed to trunk | 16:50 |
| th1a | (consider this the official todo list, guys) | 16:50 |
| replaceafill | aelkner thanks :) | 16:50 |
| th1a | Need a section in the sidebar for $USERNAME's ... | 16:51 |
| th1a | That will have: | 16:51 |
| th1a | - Intervention center | 16:51 |
| th1a | - Reports | 16:51 |
| th1a | I'm not sure what the header is in whatever section Preferences goes in. | 16:52 |
| th1a | Misc. | 16:52 |
| th1a | Is all this making sense? | 16:52 |
| th1a | I have to run around this morning because it is the last day of preschool for Vivian. | 16:53 |
| th1a | So I need replaceafill and aelkner to pick what of the above they're going to work on. | 16:53 |
| replaceafill | i'll work on changing the "edit" links to the icon | 16:54 |
| yvl | I'll work on whatever's left ;) | 16:54 |
| * th1a taps the microphone. | 16:54 | |
| th1a | OK. | 16:55 |
| replaceafill | btw, can you visit: http://69.164.203.135:6660/persons/add.html | 16:55 |
| replaceafill | and hit the Add button with no data | 16:55 |
| aelkner | has anyone noticed that the school view is broken | 16:55 |
| replaceafill | to see the error formatting | 16:55 |
| th1a | Yes, those are going to require some love too. | 16:55 |
| aelkner | it doesn't show the persons link or any links for that matter | 16:55 |
| replaceafill | i want to know if that icon is ok for "error" | 16:55 |
| yvl | also | 16:55 |
| th1a | Everything is broken by default. | 16:56 |
| yvl | the status messages are hidden at the moment | 16:56 |
| yvl | display: none | 16:56 |
| yvl | was not sure how to style them quickly | 16:56 |
| th1a | The orange one? | 16:56 |
| th1a | replaceafill? | 16:56 |
| replaceafill | and the hints add a little space | 16:56 |
| replaceafill | th1a it's supposed to be red | 16:56 |
| replaceafill | (the error messages) | 16:56 |
| *** menesis has quit IRC | 16:56 | |
| th1a | Making orange things red is low priority. | 16:57 |
| th1a | Just go ahead with the orange one. | 16:57 |
| th1a | We don't need to worry about color until we're sure we like the shape. | 16:57 |
| th1a | Is there too much space between the label and the field? | 16:58 |
| replaceafill | just a little extra | 16:59 |
| th1a | OK. | 16:59 |
| replaceafill | there's hint in between | 16:59 |
| replaceafill | check date of birth | 16:59 |
| th1a | Now, as a for example about how we want to think about labeling things. | 16:59 |
| replaceafill | or username | 16:59 |
| replaceafill | they have hints displayed | 16:59 |
| th1a | What should the fieldset title be? | 16:59 |
| th1a | What information would be helpful to the user? | 16:59 |
| * th1a looks expectantly at the class. | 17:00 | |
| * replaceafill failed user interface design last semester... | 17:00 | |
| yvl | new person / new administrator / etc. | 17:00 |
| yvl | remove subtitle form the view | 17:00 |
| yvl | basically - make it smaller | 17:01 |
| yvl | or else there's not much to put ther | 17:01 |
| yvl | e | 17:01 |
| th1a | Well, what information is the user going to be entering. | 17:01 |
| th1a | What should the user be thinking about? | 17:01 |
| replaceafill | aelkner somethings wrong with the advisory accordion | 17:01 |
| aelkner | how so? | 17:01 |
| replaceafill | aelkner i'll explain after the meeting | 17:01 |
| aelkner | ok | 17:02 |
| th1a | Stay on topic class. | 17:02 |
| replaceafill | :) | 17:02 |
| replaceafill | sorry sir | 17:02 |
| yvl | you can also split the form into several fieldsets | 17:02 |
| yvl | like personal information | 17:02 |
| yvl | contact information | 17:02 |
| th1a | Yes. | 17:02 |
| yvl | demographics | 17:03 |
| th1a | The example form in the UWG is actually a good model. | 17:03 |
| replaceafill | About you, Address | 17:03 |
| th1a | We'd be a bit more formal, but basically the fieldset title should tell the user what kind of information they'll be entering in each section. | 17:04 |
| th1a | Are there examples of hints in these forms? | 17:05 |
| yvl | hints? | 17:05 |
| replaceafill | i dont think so | 17:05 |
| replaceafill | just errors | 17:05 |
| * yvl is sensing th1a is leading us to the answer | 17:06 | |
| th1a | Oh, sorry. | 17:07 |
| yvl | like, show hints where the errors are shown | 17:07 |
| th1a | *I* had moved onto a new subject. ;-) | 17:07 |
| yvl | or something | 17:07 |
| th1a | :-D | 17:07 |
| th1a | Anyway, the add person page should have fieldsets more or less like | 17:08 |
| th1a | Full name | 17:08 |
| th1a | ... | 17:09 |
| th1a | Actually, this is just going to take some experimentation. | 17:09 |
| th1a | How many sets is too many. | 17:09 |
| th1a | The last four counting Ethnicity should actually be the first four in a "demographics" fieldset. | 17:10 |
| aelkner | that's the way it is in the old skin | 17:10 |
| th1a | That'll take some fiddling. | 17:11 |
| th1a | yvl: Do you want to work on that tomorrow? | 17:12 |
| yvl | if you specify exactly what I need to do, yes | 17:12 |
| th1a | Well, let's say | 17:12 |
| th1a | Full Name | 17:12 |
| yvl | Details (gender, birth date) | 17:13 |
| yvl | Demographics | 17:13 |
| th1a | Yeah. | 17:13 |
| yvl | SchoolTool user | 17:13 |
| yvl | and thats'it | 17:13 |
| yvl | no group | 17:13 |
| yvl | no advisor | 17:13 |
| yvl | or leave them in? | 17:13 |
| th1a | I mean, this kind of has to marinate for a while. | 17:13 |
| th1a | OH! | 17:13 |
| th1a | Hm. | 17:13 |
| th1a | Yes, leave them in. | 17:14 |
| yvl | separate section? | 17:14 |
| th1a | They probably should have their own fieldset. | 17:14 |
| yvl | yes, I meant fieldset | 17:14 |
| th1a | We really just have to try it and see how it looks. | 17:14 |
| yvl | ok | 17:14 |
| th1a | ATM I feel like that would be called "Relationships" | 17:14 |
| th1a | But basically, we just need to rough it out and get a sense of the whole thing. | 17:15 |
| th1a | See how it feels. | 17:15 |
| yvl | I'll do some trying then ;) | 17:15 |
| th1a | Get our new calendar widget in there. | 17:16 |
| yvl | I should probably also do the add-and-add-next | 17:16 |
| th1a | We probably need to style that a bit too. | 17:16 |
| th1a | OK, yvl can do that. | 17:16 |
| yvl | sounds like a plan | 17:16 |
| th1a | Cool. | 17:17 |
| th1a | OK, so really, do you guys have any wishes about how to organize changing the rest of the app? | 17:17 |
| th1a | Or should I just decide? | 17:17 |
| yvl | well | 17:17 |
| th1a | It will determine how the next six weeks go. | 17:17 |
| yvl | first and most important - whatever way is the easiest for you to manage | 17:17 |
| * yvl would like to do plumbing | 17:18 | |
| yvl | but I can whatever | 17:19 |
| yvl | hmm | 17:19 |
| yvl | probably it would be best to get the core working for now | 17:20 |
| yvl | it's annoying that I can't add courses | 17:20 |
| replaceafill | +1 | 17:20 |
| th1a | Well, yes. | 17:20 |
| * replaceafill has to use an external instance to update the Data.fs :) | 17:20 | |
| * yvl too | 17:20 | |
| replaceafill | :D | 17:20 |
| yvl | copy Data.fs | 17:20 |
| yvl | start the instance | 17:20 |
| yvl | click click | 17:20 |
| replaceafill | :D | 17:20 |
| yvl | stop, copy back | 17:21 |
| yvl | start the one I'm working on | 17:21 |
| th1a | Would you guys prefer to just be assigned pages to do from start to finish? | 17:21 |
| yvl | remember something | 17:21 |
| yvl | repeat | 17:21 |
| yvl | slow! | 17:21 |
| *** asharma has joined #schooltool | 17:21 | |
| * yvl would prefer a mixed model | 17:21 | |
| yvl | th1a got our roles right, I think | 17:22 |
| yvl | replaceafill paints awesomely | 17:22 |
| replaceafill | :) | 17:22 |
| th1a | OK. | 17:22 |
| th1a | Any objections? | 17:22 |
| yvl | aelkner, I'm really interested in your opinion on this | 17:23 |
| *** AndChat has joined #schooltool | 17:23 | |
| aelkner | on which task which of us gets next, on what colors to use, please ask again | 17:24 |
| *** AndChat is now known as Guest89616 | 17:24 | |
| th1a | Huh? | 17:24 |
| *** Guest89616 is now known as menesis | 17:24 | |
| aelkner | as far as what to do next, i'd say getting core add/edit views to work would be high priority | 17:24 |
| aelkner | myself, i have a demographics viewlet to write | 17:25 |
| aelkner | also, action links | 17:25 |
| aelkner | clicking on School now yields an empty view | 17:25 |
| aelkner | it used to have Persons | 17:25 |
| aelkner | and other link, i can't remember | 17:25 |
| th1a | aelkner... the entire rest of the application doesn't work. | 17:25 |
| aelkner | so those are the two categories as i see them, add/edit, action link | 17:26 |
| aelkner | links | 17:26 |
| aelkner | these viewlet managers should start being used | 17:26 |
| th1a | What's on the table now is are you going to do whatever is required between yvl setting up the plumbing for each view and replaceafill tweaking the presentation? | 17:27 |
| aelkner | yvl went through the trouble of creating them after all | 17:27 |
| th1a | If you're ok with that, we're done for today. | 17:27 |
| th1a | And if you're not ok, we're still done, but we'll have to keep talking about the issue. | 17:27 |
| aelkner | what about the demographics viewlet? | 17:28 |
| th1a | Yes. Do that. | 17:28 |
| aelkner | should that be a sortable table | 17:28 |
| aelkner | the columns are: Field | Value | 17:28 |
| th1a | Sortable by what? | 17:28 |
| aelkner | good point | 17:28 |
| th1a | :-D | 17:29 |
| aelkner | the fields might as well stay in the same order | 17:29 |
| th1a | Yes. | 17:29 |
| th1a | We're just generally formatting more things as tables. | 17:29 |
| aelkner | so i won't be creating a table formatter for it | 17:29 |
| th1a | aelkner: you've got one minute to object to your new role. | 17:29 |
| aelkner | i'll just code the html table directly in the viewlet | 17:29 |
| th1a | aelkner: Fine. | 17:29 |
| yvl | that's ok | 17:30 |
| aelkner | define this new role | 17:30 |
| th1a | I did above. | 17:30 |
| yvl | mostly - porting views | 17:30 |
| th1a | OK, we're done here. I'll flesh out the plan for tomorrow. | 17:30 |
| * th1a drops the bag of gravel. | 17:30 | |
| yvl | and poking me when stuff is missing or inconvenient :) | 17:30 |
| yvl | ok | 17:30 |
| replaceafill | yvl i have a request | 17:31 |
| yvl | th1a, if you happen to arrive at some revelations about person views, please email | 17:31 |
| yvl | listening, replaceafill | 17:31 |
| aelkner | guys what about the School tab? | 17:31 |
| replaceafill | could you take the breadcrumbs list out of the secondary navigation? | 17:31 |
| replaceafill | i mean | 17:32 |
| replaceafill | it's ok to have it as a viewlet | 17:32 |
| aelkner | are you guys having to type persons in the url like i have to? | 17:32 |
| yvl | yes, aelkner | 17:32 |
| replaceafill | but i don't like the css hack i did | 17:32 |
| replaceafill | by hack i mean absolute positioning :) | 17:32 |
| replaceafill | aelkner yes | 17:32 |
| yvl | well, that's why I kindly left that to you | 17:33 |
| th1a | yvl: I will. | 17:33 |
| *** jelkner has joined #schooltool | 17:33 | |
| yvl | to position it the way we want is a b*tch | 17:33 |
| replaceafill | yvl i thought "yvl should do this" :D | 17:33 |
| yvl | or to be more precise, I don't know how to do that cleanly | 17:33 |
| replaceafill | i'd vote for: <ul class="breadcrumbs"> <ul class="secondary_nav"> | 17:34 |
| * th1a runs some errands. | 17:34 | |
| replaceafill | as siblings | 17:34 |
| replaceafill | but it's not a big deal | 17:34 |
| yvl | see you tomorrow, th1a | 17:34 |
| yvl | you can do that, replaceafill | 17:34 |
| yvl | you got the powa! | 17:34 |
| replaceafill | no! | 17:34 |
| replaceafill | i want you to do it :D | 17:34 |
| * replaceafill plays the plumbing card!!! | 17:35 | |
| yvl | it was done that way, actually | 17:35 |
| replaceafill | i know :( | 17:35 |
| * yvl plays the painter-that-is-some-times-also-a-plumber-actually card :P | 17:35 | |
| yvl | but ok | 17:35 |
| yvl | I can do that | 17:35 |
| replaceafill | :)) | 17:35 |
| yvl | but you'll have to do the styling | 17:35 |
| replaceafill | sure, np | 17:35 |
| replaceafill | it's only that i dont like absolute positioning much | 17:36 |
| yvl | hmm, better yet! | 17:36 |
| yvl | I'll tell you how to do that :D | 17:36 |
| replaceafill | the styling? | 17:36 |
| replaceafill | sure | 17:36 |
| yvl | no, how to make them siblings | 17:36 |
| replaceafill | ah | 17:36 |
| replaceafill | hhmm ok | 17:36 |
| yvl | just put it in the main pt | 17:36 |
| replaceafill | as it used to be? | 17:36 |
| yvl | yes | 17:37 |
| yvl | tal block | 17:37 |
| yvl | view/providers/breadcrumbs | 17:37 |
| yvl | and - tada! | 17:37 |
| replaceafill | yes | 17:37 |
| yvl | it worky | 17:37 |
| yvl | and yes, unregister the breadcrubms viewlet | 17:37 |
| replaceafill | cool | 17:37 |
| replaceafill | but now i have your permission ;) | 17:37 |
| replaceafill | i've been commenting stuff in case you're not ok with the changes :D | 17:37 |
| yvl | you had it yesterday ;) | 17:38 |
| replaceafill | :D | 17:38 |
| replaceafill | thanks yvl | 17:38 |
| yvl | :D | 17:38 |
| yvl | for the permission, right? :D | 17:38 |
| *** menesis has quit IRC | 17:38 | |
| *** menesis1 has joined #schooltool | 17:38 | |
| *** menesis1 is now known as menesis | 17:38 | |
| replaceafill | for the permission and the advicing :) | 17:38 |
| yvl | well, if that's that, I've got a birthday party to attend ;) | 17:39 |
| yvl | see you guys | 17:39 |
| yvl | happy coding! | 17:39 |
| replaceafill | have fun | 17:39 |
| replaceafill | bring some cake ;) | 17:39 |
| aelkner | guys, please ping me when your conversation thread is over | 17:39 |
| replaceafill | it's over aelkner | 17:39 |
| aelkner | just as i was typing :) | 17:39 |
| aelkner | so what's the deal with the persons flourish.zcml having the viewlets commented out? | 17:40 |
| aelkner | for ManageSchoolLinks, that is | 17:40 |
| replaceafill | aelkner th1a decided to disable them | 17:40 |
| replaceafill | to make the School links disappear | 17:40 |
| replaceafill | (the ones you were asking about before) | 17:40 |
| aelkner | what are we doing in its place to get navigation working? | 17:41 |
| replaceafill | for the moment nothing | 17:41 |
| replaceafill | we have to type urls momentarily | 17:42 |
| replaceafill | or you can use bookmarks!! ;) | 17:42 |
| replaceafill | aelkner regarding the advisory viewlet, fix the advisees property | 17:42 |
| replaceafill | you have: | 17:42 |
| replaceafill | @property | 17:43 |
| replaceafill | def advisees(self): | 17:43 |
| replaceafill | return list(self.context.advisors) | 17:43 |
| replaceafill | which is wrong | 17:43 |
| aelkner | got it | 17:43 |
| replaceafill | all right | 17:43 |
| aelkner | what are you doing next? | 17:43 |
| replaceafill | moving breadcrumbs and changing "edit" links in the accordions | 17:43 |
| aelkner | what after that? | 17:44 |
| replaceafill | hhmm will ask th1a :) | 17:44 |
| replaceafill | but i want to fix a few styles in the forms too | 17:44 |
| aelkner | yvl will be fixing add/edit person, right? | 17:45 |
| replaceafill | aelkner i think so | 17:46 |
| replaceafill | and adding multiple (students, teachers, etc) | 17:46 |
| replaceafill | i like the way yvl designed the multiple person add form :) | 17:46 |
| replaceafill | very clever | 17:46 |
| replaceafill | i exploited it in cambodia :P | 17:46 |
| replaceafill | btw, aelkner | 17:46 |
| replaceafill | is this necessary: | 17:46 |
| replaceafill | template = ViewPageTemplateFile('templates/advisoryViewlet.pt') | 17:47 |
| replaceafill | render = lambda self, *a, **kw: self.template(*a, **kw) | 17:47 |
| replaceafill | cant you just: | 17:47 |
| replaceafill | render = ViewPageTemplateFile('templates/advisoryViewlet.pt') | 17:47 |
| aelkner | let me check | 17:47 |
| yvl | aelkner, no, you will not be fixing person forms | 17:48 |
| yvl | at least for now | 17:48 |
| aelkner | what are you doing next? | 17:49 |
| yvl | person forms | 17:49 |
| yvl | at least I think | 17:49 |
| yvl | please check with th1a when he gets back | 17:49 |
| aelkner | what about the code snippet directly above, i got those lines from following one of our viewlets | 17:50 |
| aelkner | i was going to ask you about that | 17:50 |
| aelkner | replaceafill, as far as i can see, that wouldn't work | 17:51 |
| replaceafill | ok | 17:51 |
| aelkner | because the first line creates the template | 17:51 |
| aelkner | the second one calls it | 17:51 |
| aelkner | though, if we added () to your idea.maybe it would work | 17:52 |
| aelkner | trying now... | 17:52 |
| * replaceafill goes to have breakfast | 17:52 | |
| yvl | I think you can also just specify the template | 17:53 |
| yvl | and add render="template" to your viewlet registrations | 17:53 |
| *** ignas has quit IRC | 17:53 | |
| yvl | I sincerely don't remember now | 17:53 |
| aelkner | i needed to override render(), like you did in one of your viewlets | 17:53 |
| yvl | need to write documentation at some point! | 17:53 |
| aelkner | because render has just pass in it | 17:53 |
| aelkner | and that gets called even if you override it in your own class | 17:54 |
| yvl | yes | 17:54 |
| yvl | personally, I'd keep template variable named template | 17:54 |
| aelkner | couldn't we have the base class do the same thing the lambda does | 17:55 |
| yvl | since directives can override that variable by specifying template="" | 17:55 |
| aelkner | so that the deriving class doesn't need to worry about rendering | 17:55 |
| aelkner | and can control things by defining the template | 17:55 |
| aelkner | these base classes should do most of the work for us | 17:56 |
| aelkner | controllable via attributes like template | 17:56 |
| yvl | you're right aelkner | 17:56 |
| aelkner | and any others we decide we need in the future | 17:56 |
| yvl | that one is a bit of unfinished business | 17:56 |
| aelkner | so can we finish it simply like i suggested above | 17:56 |
| aelkner | putting the call to the template in the render method of the base class? | 17:57 |
| * yvl hasn't decided that | 17:57 | |
| aelkner | btw, yvl, we said we were going to play around with this stuff a while first | 17:57 |
| yvl | yes? | 17:58 |
| aelkner | but if th1a wants us to start changing many views in the same manner | 17:58 |
| aelkner | wouldn't it be prudent to get this stuff out of the way soon? | 17:58 |
| yvl | good point | 17:58 |
| aelkner | you and i cold pair program on it | 17:58 |
| aelkner | we could even use skype if you'd like | 17:59 |
| yvl | hmm | 17:59 |
| yvl | I think it would be quicker if that was just done | 17:59 |
| yvl | (if it was a live sprint, we would definitely pair-program) | 18:00 |
| yvl | so, here's the thing | 18:00 |
| aelkner | i'm not sure we should rule out pairing even remptely | 18:00 |
| aelkner | remotely | 18:00 |
| aelkner | i did so with filip over the weeks leading up to our live sprint | 18:00 |
| yvl | I slightly don't want to put template = None into most base classes | 18:01 |
| yvl | I'd rather have meta directives imply render="template" and put that lambdas into class dict | 18:01 |
| yvl | if the template is specified | 18:01 |
| yvl | what would you think about that? | 18:02 |
| aelkner | do you mean render="templates/some_template.pt'? | 18:02 |
| yvl | no | 18:03 |
| yvl | I mean - if you specify a template="..." in the directive | 18:03 |
| aelkner | litterally render'template"? | 18:03 |
| yvl | or there is a template in the base dict | 18:03 |
| yvl | and given class' render is not implemented | 18:03 |
| yvl | it's replaced with lambda that renders the template | 18:03 |
| aelkner | i'm assuming you are introducing this confusing flexibility for a reason | 18:04 |
| yvl | currently you can actually specify render="XXX" and update="XXX" in some directives | 18:04 |
| yvl | actually, yes :) | 18:04 |
| aelkner | you were just saying | 18:05 |
| aelkner | go on | 18:05 |
| yvl | imagine you want to register the page that should render only the content_template | 18:05 |
| yvl | for some modal dialog or other | 18:05 |
| yvl | copy the directive | 18:05 |
| yvl | and add | 18:05 |
| yvl | render="content_template" | 18:05 |
| aelkner | ah, got it | 18:05 |
| yvl | in reality that injects "render = lambda ****: self.content_template(***)" | 18:06 |
| aelkner | the same precise python view class can be used to render full page | 18:06 |
| aelkner | or just content_template | 18:06 |
| yvl | right | 18:06 |
| aelkner | what are the full list of choices for render? | 18:06 |
| aelkner | template, content_template | 18:06 |
| yvl | actually - anything | 18:06 |
| yvl | it just forwards to another method, or template | 18:07 |
| yvl | if a class has | 18:07 |
| yvl | say | 18:07 |
| aelkner | ok, so instead of the lambda for render i used, i should just use the zcml? | 18:07 |
| yvl | def render_modified(self, *args, **kw) | 18:07 |
| yvl | you can say render="render_modified" | 18:07 |
| yvl | it should work | 18:07 |
| yvl | never tested that :/ | 18:07 |
| yvl | but that was the intent | 18:07 |
| aelkner | i'l do that now | 18:08 |
| aelkner | could you stick around another fve minutes | 18:08 |
| yvl | sure | 18:08 |
| aelkner | thanks | 18:08 |
| *** alga has quit IRC | 18:09 | |
| aelkner | yvl, it works! | 18:10 |
| aelkner | here's something to consider | 18:11 |
| aelkner | oh, you know what, never mind | 18:11 |
| aelkner | i think that directive will come in handy | 18:11 |
| yvl | great, aelkner | 18:12 |
| yvl | sorry again for no documentation | 18:12 |
| yvl | it *needs* to be written | 18:12 |
| yvl | well, /me goes home | 18:13 |
| yvl | good luck! | 18:13 |
| aelkner | thanks, see you tomorrow | 18:13 |
| yvl | and if you run into some weird behaviour or bugs | 18:13 |
| yvl | please email | 18:13 |
| yvl | I'll look into that | 18:13 |
| yvl | see you tomorrow :) | 18:13 |
| replaceafill | aelkner you should rename advisoryViewlet.pt to f_advisoryViewlet.pt | 18:28 |
| jelkner | th1a, are you here? | 18:29 |
| jelkner | i just tried to call | 18:29 |
| replaceafill | jelkner i think he went out | 18:29 |
| jelkner | i left a message on his phone | 18:30 |
| th1a | What's up jelkner? | 18:54 |
| replaceafill | th1a security question | 18:55 |
| replaceafill | the accordions are protected with schooltool.edit | 18:55 |
| replaceafill | so the user can't see his own accordions | 18:55 |
| replaceafill | if he's not a manager | 18:55 |
| replaceafill | so, we need to change that to schooltool.view | 18:55 |
| th1a | Well, that's wrong, obviously. | 18:55 |
| replaceafill | yes | 18:55 |
| replaceafill | but | 18:55 |
| replaceafill | should other non-manager users view able to view his data? | 18:56 |
| replaceafill | i think that's an access control setting ,correct? | 18:56 |
| * replaceafill goes look | 18:56 | |
| th1a | That should be an established issue. | 18:56 |
| * th1a goes to take a shower. | 18:59 | |
| th1a | I'll be back around 1:30. | 18:59 |
| *** menesis has quit IRC | 19:03 | |
| *** menesis has joined #schooltool | 19:12 | |
| jelkner | th1a, are you back? | 19:20 |
| jelkner | i tried to call you | 19:20 |
| jelkner | but no answer | 19:20 |
| jelkner | asharma has completed the book | 19:20 |
| jelkner | she is looking for her next task ;-) | 19:20 |
| jelkner | and i want to know where to put it? | 19:21 |
| replaceafill | aelkner sync with trunk, i fixed the advisees problem, renamed the template and changed the permission of all the accordions | 19:21 |
| jelkner | it should be on the ST site, yes? | 19:21 |
| * jelkner tries ringing th1a again... no answer | 19:23 | |
| replaceafill | jelkner he said he will be back at 1:30 | 19:23 |
| jelkner | ok, replaceafill, thanks! | 19:23 |
| replaceafill | aelkner pushed edit icons for accordions to trunk | 19:35 |
| aelkner | replaceafill, ok, thanks | 19:37 |
| replaceafill | th1a http://69.164.203.135:6660/persons/alvaro | 19:38 |
| replaceafill | log in as alvaro and then as manager | 19:38 |
| replaceafill | i decided to let "edit" next to the pencil | 19:38 |
| aelkner | replaceafill, i pushed a small fix to trunk | 19:48 |
| aelkner | just got rid of some unnecessary view attributes | 19:49 |
| replaceafill | aelkner sync with trunk :) | 19:56 |
| replaceafill | "Cleaned flourish templates and added file resource for javascript code" | 19:57 |
| replaceafill | javascript code for flourish is now under skin/flourish/resources/flourish.js | 19:57 |
| replaceafill | wow, resource library is smart :D | 19:58 |
| aelkner | replaceafill, flourish.js seems like a general name | 20:01 |
| replaceafill | it is :) | 20:01 |
| aelkner | and you put person info stuff there | 20:02 |
| aelkner | not general | 20:02 |
| replaceafill | let's not have this discussion again... | 20:02 |
| aelkner | ok, forget it | 20:02 |
| replaceafill | we can change it later ;) | 20:02 |
| aelkner | yeah, you and yvl have been saying that for a while now | 20:03 |
| replaceafill | :D | 20:03 |
| aelkner | and when later comes and it's 5000 lines that need to change, i'll just laugh | 20:03 |
| replaceafill | cool! | 20:03 |
| replaceafill | and then you say: "see!??! i told you this would happen" | 20:03 |
| replaceafill | (i'm talking about flourish.js) | 20:03 |
| replaceafill | ok, now breadcrumbs... | 20:04 |
| replaceafill | th1a hhmm i wonder if we should float those edit icons to the right, ala LP | 20:06 |
| replaceafill | th1a never mind, LP doesnt float them to the right as i thought :) | 20:07 |
| replaceafill | it's "above" the bug description to the right | 20:07 |
| th1a | replaceafill, You can take out the "edit" | 20:38 |
| replaceafill | ah ok | 20:39 |
| th1a | Also, the icon is riding a little low. | 20:39 |
| th1a | Basically, it is only a usability issue the first time you use the application. | 20:39 |
| th1a | Which I think we can deal with. | 20:39 |
| th1a | Can you make it say "Edit" when you mouseover? | 20:39 |
| replaceafill | ok | 20:40 |
| replaceafill | th1a you want the Edit as a tooltip? right now the tooltip says "Manage this persons'..." | 20:43 |
| th1a | Tooltip, yes. | 20:43 |
| replaceafill | ok | 20:43 |
| th1a | Can we make it different for each icon? | 20:44 |
| th1a | Edit advisors | 20:44 |
| th1a | Edit or manage? | 20:44 |
| th1a | Manage advisors... | 20:44 |
| th1a | Yes, like it is now is fine. | 20:45 |
| replaceafill | th1a so, same messages then? | 20:46 |
| replaceafill | what about the last one? | 20:46 |
| replaceafill | for groups? | 20:46 |
| replaceafill | "Manage this person's memberships" | 20:46 |
| th1a | Sure. | 20:47 |
| replaceafill | ok, removing the "edit" link | 20:47 |
| th1a | We need to deal with what to display if there is nothing in the table but the user has edit permission. | 20:48 |
| th1a | In that case they should see the label and the edit link and... ? | 20:48 |
| th1a | Empty table? | 20:48 |
| replaceafill | th1a refresh | 20:54 |
| replaceafill | aelkner sync with trunk, "Moved breadcrumbs out and changed edit links for accordions" | 20:54 |
| th1a | I'm not happy with just the table header. | 20:55 |
| replaceafill | conditional "There is none"? | 20:56 |
| th1a | Well... | 20:57 |
| replaceafill | what i'm unhappy with is: | 20:57 |
| replaceafill | check alvaro | 20:57 |
| replaceafill | see Sections | 20:57 |
| replaceafill | see the table headers | 20:57 |
| th1a | y? | 20:57 |
| replaceafill | they're not aligned | 20:57 |
| th1a | I see. | 20:57 |
| th1a | Why? | 20:57 |
| replaceafill | we need to class those two at least | 20:57 |
| th1a | ok | 20:57 |
| replaceafill | their width is automatic | 20:57 |
| th1a | Yes, that can be manual. | 20:58 |
| replaceafill | what would be appropriate widths for the columns? 33% each? | 20:58 |
| th1a | Perhaps. | 21:00 |
| th1a | We can't really say how big each one is. | 21:00 |
| replaceafill | aelkner sync with trunk: "Fixed widths of section tables in person view" | 21:09 |
| replaceafill | we need a bot to track flourish trunk in IRC ;) | 21:09 |
| th1a | I would say make years narrow but some people give them long names. | 21:10 |
| replaceafill | longer texts will flow in the cell | 21:11 |
| th1a | ok | 21:12 |
| replaceafill | th1a i'm going out to run some errands, will be back in an hour or so | 21:12 |
| replaceafill | need something to do next :) | 21:12 |
| replaceafill | (i think my queue is empty...) | 21:12 |
| aelkner | th1a, a question about the demographics | 21:13 |
| aelkner | the accordion should be labeled Demographics, i imagine | 21:13 |
| aelkner | what would the header of the content be? | 21:14 |
| th1a | I don't know what else I'd label it. | 21:14 |
| *** asharma has quit IRC | 21:14 | |
| th1a | Hm... | 21:14 |
| th1a | Maybe just Label | Value ? | 21:14 |
| aelkner | i have Field | Value for the table, but i can change that | 21:15 |
| th1a | label is a little less tech. | 21:15 |
| aelkner | thing is, if there's nothing before the table, it's a bit toppy | 21:15 |
| aelkner | ok, label it is | 21:15 |
| aelkner | so the heading would help visually, but also provide a place to put the pencil | 21:16 |
| aelkner | what do you think? | 21:16 |
| * replaceafill goes out | 21:16 | |
| *** replaceafill has quit IRC | 21:16 | |
| th1a | Yes... | 21:16 |
| th1a | Maybe just "Demographic and other data" | 21:17 |
| aelkner | ah, a sentence :) | 21:17 |
| th1a | We can't really meaningfully label something that is customizable. | 21:17 |
| aelkner | and the pencil? | 21:18 |
| th1a | Well... it isn't necessarily all demographic data anyhow. | 21:18 |
| th1a | Yes, use it. | 21:18 |
| aelkner | right, not all demographics | 21:18 |
| aelkner | how about not calling the accordion Demo.., but Attributes or something general | 21:19 |
| aelkner | how about breaking up the fields into two tables, following the pattern already established | 21:19 |
| aelkner | in the edit and add views | 21:19 |
| th1a | Actually, good point. | 21:20 |
| aelkner | accordion: General Information | 21:20 |
| th1a | No... | 21:20 |
| aelkner | But the headings for the tables cold match those of the fieldsets in the edit views | 21:20 |
| th1a | If anything more generic like Attributes | 21:20 |
| th1a | Yes, they should. | 21:21 |
| aelkner | Attributes is fine for me, how about the headings | 21:21 |
| aelkner | oh, you answered that | 21:23 |
| th1a | Basically, nothing is set in stone at this point anyhow. | 21:23 |
| th1a | And since we're not breaking tests when we change verbiage at this point, assume it is a draft. | 21:24 |
| aelkner | ok, i know enough to code it now | 21:26 |
| *** menesis has quit IRC | 21:48 | |
| aelkner | th1a, i pushed the demographics person info viewlet to trunk | 22:58 |
| aelkner | you can pull to your own instance if you want to look before douglas gets bacm | 22:58 |
| th1a | YEah, I have to start over on mine though. | 22:58 |
| aelkner | i was thinking that Attributes should be the first accordion, and thus, open by default | 23:00 |
| aelkner | but if the content is long (lots of demos) then the other accordions will not be | 23:00 |
| aelkner | visible unless you scroll down | 23:01 |
| th1a | No attributes shouldn't be first. | 23:02 |
| aelkner | what should the order of the accordions be | 23:03 |
| aelkner | right now they are arbitrary | 23:03 |
| th1a | You could send me a screenshot while I download eggs. | 23:03 |
| aelkner | i need to learn out how the viewlet manager sorting works | 23:03 |
| *** replaceafill has joined #schooltool | 23:05 | |
| * replaceafill is back and soaked... | 23:06 | |
| * replaceafill updates the testing instance | 23:07 | |
| th1a | OK, take out the edit text. | 23:07 |
| th1a | Move the value over to about 1/3rd instead of 2/3rds. | 23:07 |
| th1a | Don't we have human readable labels? | 23:08 |
| th1a | placeofbirth? | 23:08 |
| th1a | information should not be caps. ;-) | 23:08 |
| replaceafill | aelkner copy the edit button from the other viewlets | 23:08 |
| replaceafill | (advisory and groups) | 23:09 |
| th1a | This is pretty much where aelkner will be handing things off to replaceafill and I for the next two months. | 23:09 |
| aelkner | replaceafill, what do you think i did? | 23:09 |
| th1a | btw. | 23:09 |
| replaceafill | aelkner the updated version ;) | 23:09 |
| aelkner | replaceafill, could you be more specific about the change? | 23:11 |
| replaceafill | aelkner the edit link | 23:11 |
| replaceafill | in General information | 23:11 |
| replaceafill | and Demographics | 23:11 |
| aelkner | yes? | 23:11 |
| replaceafill | have you sync'ed with trunk? | 23:12 |
| replaceafill | look Advisors and Advisees | 23:12 |
| aelkner | i did twn minutes ago | 23:12 |
| replaceafill | see that there's no text? | 23:12 |
| replaceafill | just the pencil | 23:12 |
| aelkner | i see edit | 23:12 |
| aelkner | wait | 23:13 |
| replaceafill | :/ | 23:13 |
| replaceafill | again, have you sync'ed WITH trunk... | 23:13 |
| * replaceafill goes see aelkners branch | 23:13 | |
| aelkner | i merged my changes to trunk, not the other way around | 23:13 |
| replaceafill | every time i suggest "sync with trunk" i mean, pull changes from trunk to your personal branch | 23:14 |
| replaceafill | i call "merging to trunk", push :) | 23:14 |
| aelkner | ok, got it | 23:14 |
| replaceafill | th1a what's next? | 23:15 |
| * replaceafill reviews the logs in case he forgot something | 23:16 | |
| aelkner | replaceafill, pushed edit change to trunk | 23:19 |
| replaceafill | k, pulling | 23:19 |
| replaceafill | refresh | 23:20 |
| replaceafill | i wonder if we should use an fragment identifier for those Attribute edit links | 23:20 |
| replaceafill | like @@edit.html#demographics | 23:20 |
| replaceafill | so when the user changes to the form, he's put right in the demographics space | 23:21 |
| replaceafill | nah, too much :/ | 23:21 |
| replaceafill | is the change to [Cancel] [Apply] intentional? | 23:23 |
| aelkner | not such a bad idea at all, i could add that to the link for demographics | 23:23 |
| replaceafill | aelkner nah, we would have to modify the form | 23:24 |
| aelkner | right, forget it then :) | 23:24 |
| replaceafill | or... we could use jquery ;) | 23:24 |
| aelkner | nah | 23:24 |
| replaceafill | nah, forget it too :d | 23:24 |
| replaceafill | :D | 23:24 |
| aelkner | there are plenty of other things to do | 23:24 |
| replaceafill | right | 23:25 |
| th1a | So... what's the deal with the label text for attributes? | 23:27 |
| aelkner | th1a, i'll change that now | 23:32 |
| th1a | Gender is part of demographics. | 23:34 |
| th1a | Well... | 23:34 |
| th1a | The other things are all "demographics" demographics though, right? | 23:35 |
| th1a | See, I was thinking "General Information" as its own accordion. | 23:36 |
| replaceafill | +1 | 23:37 |
| replaceafill | first accordion | 23:37 |
| th1a | the "Attributes" accordion as a second one. | 23:37 |
| th1a | What should be open is just "who is this person." | 23:37 |
| th1a | That is, that's what you should see when the page loads. | 23:37 |
| aelkner | replaceafill, pushed label fix to trunk | 23:43 |
| replaceafill | pulled, refresh | 23:44 |
| aelkner | th1a, ok i see you want general information as separate accordion | 23:44 |
| aelkner | Demographics as another accordion? | 23:44 |
| th1a | OK: | 23:47 |
| th1a | Accordion #1 -- General Information | 23:47 |
| aelkner | we will need heading for the content are for appearance and the pencel | 23:47 |
| aelkner | pencil | 23:47 |
| aelkner | same for the heading? | 23:47 |
| th1a | Label: | 23:48 |
| th1a | Make the label the full name. | 23:48 |
| th1a | prefix + first + middle + last + suffix | 23:48 |
| th1a | Accordion #2 -- Attributes | 23:49 |
| th1a | Label: Demographics and other personal data | 23:49 |
| th1a | That'll do for now. | 23:49 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!