*** dadeng has quit IRC | 00:05 | |
*** dadeng has joined #schooltool | 00:26 | |
*** dadeng has quit IRC | 00:41 | |
*** replaceafill has quit IRC | 01:17 | |
*** menesis has quit IRC | 01:41 | |
*** replaceafill has joined #schooltool | 02:07 | |
*** aks has joined #schooltool | 06:17 | |
*** th1a has quit IRC | 06:56 | |
*** yvl has quit IRC | 07:09 | |
*** yvl has joined #schooltool | 07:16 | |
aelkner | yvl, ayt? | 07:33 |
---|---|---|
yvl | good evening, aelkner | 07:33 |
aelkner | wow, it's early for you | 07:33 |
aelkner | what time is it there? | 07:33 |
yvl | 7:30 | 07:34 |
aelkner | early bird, are we? | 07:34 |
yvl | I love my job that much ;) | 07:35 |
aelkner | :) | 07:35 |
aelkner | i assume that you will merge every morning, right? | 07:35 |
aelkner | so i don't have to ask you needlessly | 07:35 |
yvl | of course | 07:35 |
aelkner | just making sure | 07:35 |
yvl | actually I tend to do that by the end of my day | 07:35 |
aelkner | which is still the beginning of ours | 07:36 |
yvl | right | 07:36 |
aelkner | well, have a good one, and see you at the meeting! | 07:36 |
yvl | see you soon | 07:37 |
* yvl goes to look at your latest changes | 07:38 | |
*** dadeng has joined #schooltool | 08:57 | |
*** ignas has joined #schooltool | 10:19 | |
ignas | yvl, ping! | 10:29 |
yvl | pong, ignas | 10:29 |
ignas | you prolly solved the security policy reporting problem already | 10:30 |
ignas | but still | 10:30 |
ignas | wanted to share an awesome solution to it | 10:30 |
* yvl listens :) | 10:30 | |
*** menesis has joined #schooltool | 10:31 | |
ignas | https://github.com/Pylons/pyramid/blob/5484e3e9be61b82b55e6e1e94365cfb3cd4d3a94/pyramid/security.py | 10:31 |
ignas | ACLDenied and ACLAllowed classes | 10:31 |
ignas | simple and quite elegant | 10:31 |
ignas | and kind of *duh* | 10:31 |
*** menesis has quit IRC | 10:33 | |
*** menesis has joined #schooltool | 10:36 | |
yvl | very elegant! | 10:37 |
yvl | and it is a *duh* moment | 10:38 |
yvl | jeez | 10:38 |
yvl | thanks :) | 10:38 |
* ignas still is having, 4 years, 4 friggin years, and I could not come up with this! | 10:39 | |
*** replaceafill has quit IRC | 10:43 | |
yvl | so obvious now | 10:45 |
* yvl is ashamed | 10:45 | |
*** alga has joined #schooltool | 10:46 | |
ignas | credit goes to Chris McDonough (repoze, pyramid) | 10:56 |
yvl | that guy is quite awesome himself, I agree ;) | 11:01 |
*** dadeng has quit IRC | 12:03 | |
*** dadeng has joined #schooltool | 13:40 | |
*** dadeng has quit IRC | 14:03 | |
*** aks has quit IRC | 14:19 | |
*** menesis has quit IRC | 14:24 | |
*** dadeng has joined #schooltool | 14:34 | |
*** dadeng has quit IRC | 15:09 | |
*** dadeng has joined #schooltool | 15:25 | |
*** jelkner has joined #schooltool | 15:26 | |
*** th1a has joined #schooltool | 15:27 | |
jelkner | good morning th1a! | 15:28 |
th1a | hi jelkner. | 15:28 |
*** fsufitch has joined #schooltool | 15:30 | |
jelkner | good morning fsufitch! | 15:30 |
fsufitch | jelkner: morning to you too :) | 15:30 |
*** menesis has joined #schooltool | 15:34 | |
yvl | th1a, all latest work pushed to central branch | 15:52 |
th1a | thanks yvl. | 15:52 |
yvl | if you're up for it, you can check it out before the meeting | 15:52 |
th1a | I am up (for it). | 15:52 |
yvl | :) | 15:52 |
yvl | there are too much person links ATM | 15:53 |
yvl | especially "Add Person" and "Add Persons" | 15:53 |
yvl | so you could compare multi-add and simple add side by side | 15:53 |
yvl | oh, and if you have a data fs with sections and their members set up | 15:55 |
yvl | you can also check out Alans work (better) | 15:55 |
th1a | Yes... I thought I tried to explain that... all of the add forms should be changed to allow you to add multiple students. | 15:55 |
*** replaceafill has joined #schooltool | 16:06 | |
* th1a is getting his populated Data.fs in the right spot... | 16:13 | |
th1a | AGH. | 16:13 |
th1a | File "/home/hoffman/Desktop/flourish/eggs/zope.app.appsetup-3.14.0-py2.6.egg/zope/app/appsetup/bootstrap.py", line 77, in ensureUtility | 16:14 |
th1a | if (reg.provided.isOrExtends(interface) and reg.name == name)] | 16:14 |
th1a | AttributeError: type object 'ICustomScoreSystem' has no attribute 'isOrExtends' | 16:14 |
th1a | What might that be? | 16:21 |
replaceafill | the testing instance with current trunk + small css changes we made yesterday: | 16:21 |
replaceafill | http://69.164.203.135:6660/persons | 16:21 |
replaceafill | good morning all, btw :) | 16:21 |
th1a | That error is from using a .deb Data.fs with flourish branch. | 16:21 |
th1a | People! | 16:22 |
replaceafill | :D | 16:22 |
th1a | aelkner: Looking pretty good! | 16:23 |
* th1a goes to get more coffee. | 16:28 | |
yvl | th1a, you can put schooltool.gradebook at eggs= in buildout.cfg of your flourish branch | 16:29 |
aelkner | morning all | 16:30 |
yvl | right, coffee! | 16:30 |
yvl | 3 mins | 16:30 |
th1a | [package] | 16:34 |
th1a | eggs = schooltool schooltool.gradebook ? | 16:34 |
yvl | eggs = schooltool | 16:34 |
yvl | <some spaces> schooltool.gradebook | 16:34 |
yvl | that's the old "once you plug it in, you've plugged it in" thing | 16:35 |
th1a | ValueError: ('Expected version spec in', 'schooltool, schooltool.gradebook', 'at', ', schooltool.gradebook') | 16:35 |
th1a | Do I need to make clean or something? | 16:35 |
th1a | Anyhow... | 16:37 |
th1a | replaceafill: Cambodia squared away for now? | 16:37 |
replaceafill | th1a yes | 16:37 |
th1a | Good. | 16:37 |
th1a | aelkner: status? | 16:37 |
aelkner | well, i made new versions of the viewlets and made tables for groups and courses | 16:38 |
aelkner | i guess now we should just look it over together and make any adjustments you want | 16:38 |
th1a | OK. | 16:38 |
aelkner | replaceafill, is the latest instance loaded? | 16:38 |
replaceafill | aelkner yes | 16:38 |
yvl | it looks a bit weird | 16:39 |
aelkner | what's the ip again? | 16:39 |
th1a | OK, let's all look at http://69.164.203.135:6660/persons | 16:39 |
yvl | for example, in the login screen, there's some empty bar visible at the left column | 16:39 |
menesis | th1a: strange error. send me full traceback later. | 16:39 |
th1a | kk | 16:40 |
yvl | same in person's index.html | 16:40 |
yvl | just FYI | 16:40 |
th1a | Yes, we're in a weird state atm. | 16:40 |
replaceafill | yvl you mean the padding in the content container? | 16:40 |
th1a | We kind of threw things off trying to separate the sidebar and the main content. | 16:41 |
th1a | How do we feel about the basic look (sidebar and content separated this way)? | 16:41 |
replaceafill | i don't like the 32px padding at the top of the main content | 16:42 |
th1a | This will almost certainly change before the final version, but is the basic look ok? | 16:42 |
replaceafill | but that's the uwg :/ | 16:42 |
th1a | I'm not going to sweat the vertical spacing at this point. | 16:42 |
replaceafill | cool | 16:43 |
th1a | I'd say our natural tendency would be to cram stuff too tightly. | 16:43 |
th1a | And it is easy enough to cram later. | 16:43 |
yvl | true | 16:43 |
th1a | So basically we're going to nitpick these two views for a while. | 16:44 |
th1a | In case you were wondering about the agenda. | 16:44 |
th1a | replaceafill: adding that white divider threw a lot of other stuff off. | 16:45 |
th1a | Are we going to be able to fix that? | 16:45 |
th1a | Or is it a whole cascade of issues? | 16:45 |
replaceafill | th1a we can revert it easily | 16:46 |
replaceafill | want me to revert it? | 16:46 |
th1a | I'm just getting the feeling that we did a quick change to one part that will require a whole sequence of complicated changes. | 16:47 |
th1a | And perhaps there is another approach we should have taken. | 16:47 |
th1a | But yes, maybe we should revert for now. | 16:48 |
th1a | Although I like the spacing now. | 16:48 |
th1a | So don't revert everything. | 16:48 |
replaceafill | reverted | 16:48 |
replaceafill | :/ | 16:48 |
replaceafill | ok, putting it back... | 16:48 |
replaceafill | spaces back | 16:49 |
th1a | Can we have the new spacing and old background? | 16:50 |
* yvl does not understand the choice not to follow the guidelines here - or Ubuntu pages themselves for that matter - but that's ok ;) | 16:51 | |
th1a | There are no guidelines for sidebars. | 16:51 |
replaceafill | th1a like this? | 16:52 |
yvl | if you say so | 16:52 |
th1a | yvl: I would be happy if there were. | 16:52 |
th1a | This is the kind of futzing around we're trying hard to avoid. | 16:52 |
th1a | Can we just fake a divider here with, say, a 16px white left border on the main content area? | 16:53 |
yvl | page.. 10 maybe? | 16:53 |
th1a | That wouldn't mess up the rest of the margins? | 16:53 |
yvl | (btw, replaceafill there's a bug in page 21... can you spot it? ;) ) | 16:55 |
yvl | apologies for interruption | 16:56 |
th1a | replaceafill? | 16:56 |
th1a | OK, replaceafill, I need you to talk some. | 16:57 |
replaceafill | hold on, i'm trying to put the white dividier | 16:57 |
th1a | kk. | 16:57 |
replaceafill | :) | 16:57 |
th1a | I don't literally want to spend the meeting time doing this. | 16:57 |
replaceafill | we shouldn't... | 16:57 |
replaceafill | i'd like to revert everything and do it after the meeting | 16:58 |
replaceafill | yvl bug? | 16:58 |
* replaceafill looks | 16:58 | |
yvl | please don't do that now ;) | 16:58 |
th1a | OK. | 16:58 |
yvl | oh, and please remeber the CSS box model | 16:58 |
th1a | Moving on. | 16:58 |
yvl | when doing borders | 16:58 |
yvl | if you add a 1 px bottom border, you need to take 1 px from something else | 16:59 |
replaceafill | ah yes, width = border + padding + content | 17:00 |
th1a | OK here's one issue: I'm feeling like we should switch to first name last name in most cases (say, in the secondary navbar). | 17:00 |
th1a | Top of person page, etc. | 17:00 |
yvl | or else you get twitchy error messages in forms when you select the fields with errors | 17:00 |
th1a | BUT tables should put lastname in leftmost column. | 17:00 |
* yvl is up for the task | 17:01 | |
th1a | yvl: name switchery? | 17:01 |
yvl | yes | 17:01 |
th1a | Like, today? | 17:01 |
yvl | ok | 17:01 |
th1a | I guess it doesn't matter. | 17:01 |
th1a | Mark won't be thinking about that. | 17:01 |
yvl | :) | 17:01 |
th1a | But yes, yvl can do that. | 17:02 |
yvl | thanks | 17:02 |
th1a | OK though -- NEW RULE. | 17:02 |
th1a | aelkner, got it? | 17:02 |
aelkner | got what? | 17:02 |
th1a | Firstname Lastname in most displays. | 17:02 |
th1a | Lastname in leftmost column in tables. | 17:03 |
th1a | OK? | 17:03 |
yvl | I'd like if people used something centralized | 17:03 |
yvl | it's not like that rule applies to the whole world | 17:03 |
aelkner | yeah, we need a new title attribute | 17:03 |
yvl | so the rule should be - don't invent your own | 17:03 |
replaceafill | i remember yvl writing a blueprint about that | 17:03 |
replaceafill | :) | 17:03 |
yvl | it bugs me still | 17:03 |
th1a | Yes.. | 17:04 |
th1a | . | 17:04 |
th1a | surname in leftmost column. | 17:04 |
yvl | agreed | 17:04 |
th1a | Title can just be first last as entered. | 17:04 |
th1a | We don't have to reverse it. ;-) | 17:04 |
yvl | I want to make it easy to add that option to ST app settings | 17:05 |
th1a | I think that was originally just for sorting reasons. | 17:05 |
th1a | OK. | 17:05 |
th1a | Otherwise, let's look at the secondary nav bar. | 17:05 |
th1a | The problem is that it feels like the breadcrumbs should be align left and name/log out align right. | 17:06 |
th1a | But I don't want to hide the logout on narrow screens. | 17:06 |
th1a | So I'm a little stumped. | 17:06 |
th1a | The way it is now works but feels a little off. | 17:06 |
th1a | Thoughts, feelings? | 17:07 |
th1a | (aren't you glad we figured out a way to avoid 90% of these conversations) | 17:07 |
yvl | :) | 17:08 |
menesis | of course breadcrumbs should be on the left and Name (logout) right | 17:08 |
menesis | :) | 17:08 |
yvl | http://shop.canonical.com/ | 17:08 |
yvl | :D | 17:08 |
menesis | there's no breadcrumbs | 17:08 |
th1a | I think we'll just do that. | 17:08 |
th1a | For now. | 17:08 |
th1a | And basically we'll make a list of questions to ask one of the designers at our disposal. | 17:09 |
* yvl hates that type of CSS | 17:09 | |
yvl | can replaceafill do it? :) | 17:09 |
th1a | Yes. | 17:09 |
th1a | replaceafill: That's on your list for later today. | 17:09 |
replaceafill | ok | 17:09 |
th1a | Otherwise I'm feeling ok about that space. | 17:10 |
th1a | We can take out the School section in the sidebar since we have other stuff to hold the sidebar open. | 17:11 |
replaceafill | yvl can we take out the breadcrumbs ul from the secondary_nav? | 17:11 |
th1a | yvl: Does everyone see "Application" in the top bar or just the manager? | 17:11 |
yvl | should be just the manager | 17:11 |
menesis | yvl: about the display name. that should be a property, person.display_name or something, and a preference in app settings. | 17:11 |
yvl | sorry, just administrators | 17:11 |
th1a | yvl: right | 17:12 |
menesis | also something is wrong with security | 17:12 |
yvl | menesis - maybe | 17:12 |
yvl | yes? | 17:12 |
menesis | some people cannot access other people names | 17:12 |
yvl | probably | 17:12 |
menesis | will find a bug | 17:12 |
th1a | menesis: some people aren't supposed to be able to access other people's names. | 17:13 |
menesis | not a crash | 17:13 |
yvl | replaceafill - you can do whatever you want with breadcrumbs, as long as th1a is ok with it :) | 17:13 |
th1a | I'm not sure what the question is. | 17:13 |
replaceafill | yvl understood | 17:13 |
th1a | OK. | 17:14 |
menesis | https://bugs.launchpad.net/schooltool/+bug/683286 | 17:14 |
th1a | I'm on a need to know basis. | 17:14 |
th1a | menesis: Thanks. | 17:14 |
yvl | thanks, menesis | 17:15 |
menesis | to reproduce, try cando with schooltool trunk | 17:16 |
yvl | just remember, that breadcrumbs ten to be long | 17:16 |
menesis | test | 17:16 |
yvl | and some people also have long first / last names | 17:17 |
th1a | Well, we have a nice wide bar up there. | 17:17 |
th1a | OK, more sidebar. | 17:17 |
menesis | breadcrumbs... I would just put name/logout on the right now | 17:17 |
menesis | and see what happens later | 17:17 |
menesis | there's nothing else to put in secondary nav for now | 17:18 |
th1a | Lets go with: | 17:18 |
th1a | Add... | 17:18 |
th1a | Person | 17:18 |
th1a | etc. | 17:18 |
th1a | And style it like http://ubuntu-news.org/ | 17:18 |
th1a | replaceafill can do that later too. | 17:18 |
replaceafill | :) | 17:19 |
th1a | And in the very near future we need to change all the add person views to include the "add persons" functionality (by adding another button). | 17:19 |
th1a | kk? | 17:19 |
yvl | k | 17:20 |
th1a | Anyone else have any thoughts before we move to the person page? | 17:20 |
th1a | OK, onto alvaro alvarez. | 17:21 |
replaceafill | the hover for accordions show the orange border | 17:21 |
th1a | lol | 17:22 |
replaceafill | ah, and i need to change the icons to be white... | 17:22 |
th1a | What style is "Sections Taught?" | 17:23 |
yvl | h3 | 17:23 |
yvl | no style | 17:23 |
aelkner | that is still an <h3> | 17:23 |
th1a | Where is the margin bottom? | 17:24 |
replaceafill | header elements dont have margins at the moment | 17:24 |
replaceafill | h1.. h6 | 17:24 |
aelkner | it doesn't have to be an h3 if we already styled a different h | 17:24 |
th1a | fix that. | 17:24 |
aelkner | ah | 17:24 |
th1a | Can we make all tables sortable? | 17:25 |
aelkner | we need the same type of thing as table.css for headers? | 17:25 |
replaceafill | aelkner ? | 17:25 |
aelkner | table.css makes it so that one doesn't even need classes anymore | 17:26 |
aelkner | because the table has standard styles for the elements | 17:26 |
replaceafill | yes | 17:26 |
aelkner | i'm just asking if we can have the same for headers | 17:26 |
replaceafill | aelkner we should :) | 17:26 |
th1a | I think that's the point of all this. | 17:26 |
aelkner | headers.css? | 17:26 |
replaceafill | aelkner, headers are defined in flourish.css | 17:27 |
aelkner | i like the idea of breaking this stuff down by easy to follow file names | 17:27 |
aelkner | yvl said we had no styles for headers | 17:27 |
replaceafill | i was tempted to include the table css in the flourish.css file :P | 17:27 |
aelkner | replaceafill, don't entertain such temptations | 17:28 |
aelkner | let's use easy to follow/find file names for css | 17:28 |
th1a | replaceafill: You're CSS Czar. | 17:28 |
th1a | Do we want one big one or lots of little ones? | 17:29 |
yvl | +1 for table.css with decent table classes | 17:29 |
aelkner | so if replaceafill says, 'put everyth9ing in one css file', you'd be ok with that | 17:29 |
aelkner | th1a, you think maybe having a little input from your developers may be a good idea? | 17:30 |
replaceafill | :/ | 17:30 |
th1a | For basic elements that all components use, it is plausible. | 17:30 |
th1a | replaceafill has your input, aelkner. | 17:30 |
replaceafill | can we take the css czar title away from me :) | 17:30 |
th1a | There seems to be no objection to multiple css files. | 17:30 |
aelkner | what is with the whole tzar concept, are we lovers of Bush 1 | 17:31 |
aelkner | or was it Carter? | 17:31 |
aelkner | anyway, my point is, i'm pushing for ease of code reading | 17:32 |
th1a | The idea is to avoid tedious arguments and keep moving along. | 17:32 |
aelkner | which helps improve productivity of developers | 17:32 |
th1a | Look, lots of little files is not inherently better than one central one. They both have their times and places. | 17:32 |
* replaceafill remembers to use the minified version of jquery-ui.js :) | 17:33 | |
th1a | And dividing a big CSS file into several is not hard if it is well organized. | 17:33 |
th1a | SO... | 17:33 |
th1a | replaceafill: Are you OK with the multiple file approach? | 17:34 |
replaceafill | sure | 17:34 |
th1a | OK, settled. | 17:34 |
th1a | Moving on. | 17:34 |
th1a | Can we make all tables sortable? | 17:34 |
replaceafill | we need to use table formatters for that | 17:35 |
replaceafill | everywhere | 17:35 |
aelkner | right, i didn't use that for the viewlets | 17:35 |
th1a | Is that hard? | 17:35 |
aelkner | well, yes | 17:35 |
replaceafill | i'd say tedious, not hard | 17:36 |
replaceafill | :) | 17:36 |
aelkner | table formatters are tedious, ues | 17:36 |
aelkner | yes | 17:36 |
th1a | What's the difference? | 17:36 |
aelkner | right, tedious = hard | 17:36 |
aelkner | in that it takes time, is expensive | 17:36 |
aelkner | if we could create more convenient base classes for tables... | 17:37 |
yvl | that also takes time ;) | 17:37 |
yvl | and it's plumbing ;) | 17:37 |
th1a | What do you need to do with the table formatters? | 17:38 |
th1a | A bunch of registrations? | 17:38 |
replaceafill | th1a i think the registration is easy, building the columns is not | 17:38 |
aelkner | and some tedious plumbing in each view that uses them | 17:39 |
replaceafill | you need getters for every column | 17:39 |
aelkner | right, a real pain | 17:39 |
aelkner | the thing is, if we looked into improving the class structure for this stuff | 17:40 |
yvl | keep in mind, that they're also registered on context,request at the moment | 17:40 |
aelkner | the payoff would be hig | 17:40 |
aelkner | high | 17:40 |
th1a | yvl: What are the implications of that? | 17:40 |
yvl | hmm | 17:41 |
yvl | they're crappy and inconvenient now, that is obvious | 17:41 |
yvl | also, they're quite pesky when it comes to registering stuff for views, IIRC | 17:41 |
th1a | Basically I want to use tables more in general (as opposed to, say, lists) and I'd like them to be consistent in their functionality. | 17:42 |
th1a | Not some sortable, some not. | 17:42 |
yvl | +1 on the approach | 17:42 |
aelkner | yes | 17:42 |
yvl | I don't know how much that would take and what needs to be done ATM | 17:42 |
th1a | OK, yvl, you could take a look into that. | 17:42 |
yvl | will do | 17:43 |
aelkner | we could pair program on that | 17:43 |
yvl | sorry, no | 17:43 |
th1a | I don't want to go there right now. | 17:43 |
yvl | unless you want to go thinking about catalogs and other stuff also | 17:43 |
th1a | OK... moving on... | 17:44 |
th1a | Just want to hit a couple more points here. | 17:44 |
aelkner | just as long as you come up with someting convenient :) | 17:44 |
yvl | aelkner - of course! They bug me a lot :) | 17:44 |
* yvl always forgets the quirks and gets annoyed by them | 17:44 | |
th1a | So something like "edit advisors," in the body of the accordion should be bare links, not buttons, right? | 17:44 |
th1a | Buttons should be for submitting forms. | 17:44 |
th1a | Or cancelling. | 17:45 |
yvl | sounds right | 17:45 |
yvl | and those links can do modal dialogs | 17:46 |
yvl | IMHO | 17:46 |
yvl | where needed | 17:46 |
th1a | Yes. | 17:47 |
th1a | Also, here's a long running paper-cut. | 17:47 |
th1a | Can we just make the default capitalization of random snippets: | 17:47 |
th1a | First word caps, later words not. | 17:47 |
th1a | Including table headers. | 17:48 |
th1a | ? | 17:48 |
yvl | +2? :) | 17:48 |
yvl | no, +3 maybe? | 17:48 |
yvl | I don't know which capitalization rules are better | 17:49 |
yvl | but I'm all for consistency in that matter | 17:49 |
aelkner | isn't the literary rule appropriate here | 17:50 |
aelkner | all first letters caps for titles | 17:50 |
aelkner | except preositions and articles | 17:50 |
th1a | Well, what's a title. | 17:50 |
aelkner | a heading of a table is like a title for that column | 17:50 |
menesis | http://developer.gnome.org/hig-book/stable/design-text-labels.html.en#layout-capitalization | 17:50 |
menesis | capitalization rules | 17:51 |
th1a | Ah. | 17:51 |
aelkner | so i was right | 17:51 |
yvl | can we adopt them? | 17:51 |
yvl | please? :) | 17:51 |
th1a | OK, those are the rules. | 17:51 |
replaceafill | how important are those rules for translated content? | 17:51 |
th1a | Yes aelkner, you're right. | 17:51 |
yvl | aelkner - WIN ;) | 17:52 |
menesis | just something to have in mind when adding text | 17:52 |
aelkner | it has to happen once a year :) | 17:52 |
menesis | replaceafill: each language has their own rules | 17:52 |
th1a | Something to keep in mind as we review EVERY PAGE IN THIS APPLICATION. | 17:52 |
th1a | So... aelkner has plenty to do on the person view still, correct? | 17:53 |
th1a | modal dialogs, etc. | 17:53 |
menesis | in Lithuanian everything is sentence capitalization, no Capital Letter in a Middle of Phrase | 17:53 |
aelkner | definitely that is going to be language dependent | 17:53 |
replaceafill | i guess my point is that we can put lot of efforts on "code" capitalization, we dont have entire control on the output | 17:54 |
th1a | Sure. | 17:54 |
th1a | But for English, we'll follow GNOME. | 17:54 |
aelkner | th1a, i thought today, you and i would first look at what we have and nitpick the viewlets | 17:54 |
aelkner | then i cold do some modal dialogs | 17:55 |
aelkner | but i need links for that | 17:55 |
menesis | for edit advisors, edit groups... etc I would just replace those links with an edit icon, like in launchpad | 17:55 |
th1a | You need links? | 17:56 |
th1a | menesis: What, a little pencil? | 17:57 |
menesis | th1a: yes | 17:57 |
th1a | I guess we could, since we're already taking the space to label them. | 17:58 |
th1a | Sections taught (edit) | 17:58 |
th1a | Good idea menesis. | 17:59 |
th1a | aelkner: what do you need links for? | 18:00 |
aelkner | well, i was was thinking about the action buttons that are not in the sidebar yet | 18:02 |
aelkner | although we have links (or a pencil) in the viewlets already | 18:02 |
aelkner | or is the sidebar only fro navigating away from the person? | 18:03 |
th1a | The sidebar is for things that don't go elsewhere. | 18:03 |
aelkner | so for editing things, right? | 18:03 |
th1a | It is for things that wouldn't be better off going someplace else. | 18:03 |
aelkner | changing the thing you're looking at in the content | 18:03 |
aelkner | nice non-statement, you should enter politics | 18:04 |
aelkner | :) | 18:04 |
th1a | aelkner: it is for "other." | 18:04 |
menesis | Advisors: Bob, Jim (edit) | 18:04 |
aelkner | anyway, that's what i meant about links for calling p modal dialogs | 18:04 |
menesis | certainly one of links that goes near the content, not in sidebar | 18:05 |
th1a | I think we've got them, pretty much. | 18:05 |
aelkner | th1a, you mean the viewlets will have the links we need? | 18:06 |
replaceafill | take into account that all those links (in accordions) are for relationship views | 18:06 |
replaceafill | and i think it's really hard to make that view modal | 18:07 |
replaceafill | as it is right now | 18:07 |
th1a | I thought we'd made progress on that. | 18:07 |
yvl | I'd say - some | 18:08 |
th1a | aelkner: I'm looking at the links on your current implementation, and that's basically how they should be. | 18:08 |
replaceafill | yvl does flourish have a new relationship view? | 18:08 |
th1a | I guess that would be step 1. | 18:09 |
yvl | replaceafill, no | 18:09 |
aelkner | oh, what about person preferences? that needs a link | 18:09 |
th1a | That goes in the sidebar. | 18:09 |
yvl | indeed | 18:10 |
th1a | OK, but we need to make a decision about these relationship views. | 18:10 |
th1a | We can (aside from updating the styles): | 18:10 |
th1a | 1) do nothing; | 18:10 |
th1a | 2) keep the same functionality but make them modal, which I think would moderately improve the user experience; | 18:11 |
th1a | 3) just re-implement the view from scratch to make it better (modal or not). | 18:11 |
th1a | 3) would include, say, drag and drop functionality. | 18:11 |
yvl | maybe we can do all three? | 18:11 |
th1a | Or some other inspiration I don't have. | 18:11 |
yvl | step-by-step | 18:11 |
th1a | Well... it is not worth doing 2) if we're doing 3). | 18:12 |
aelkner | step 1) is already done :) | 18:12 |
yvl | no, it's not | 18:12 |
replaceafill | :D | 18:12 |
yvl | they're not working now, are they | 18:12 |
yvl | or did I miss something | 18:12 |
th1a | They probably need tweaking. | 18:12 |
menesis | for Person, in sidebar would go: Preferences, Calendar, Gradebook, Reports, Interventions, Export... and this is the right sidebar (related), not left. | 18:12 |
th1a | menesis: If that goes in the right the left is empty. | 18:13 |
th1a | I think we only need one sidebar. | 18:13 |
yvl | I don't, but that's another matter ;) | 18:13 |
th1a | Also, probably most of that goes on top. | 18:13 |
replaceafill | i'd like two sidebars, but i dont like they're too tiny | 18:13 |
menesis | that's how yvl explained the organization of the page to me | 18:14 |
menesis | on left go filters, navigation | 18:14 |
th1a | Well, I'm not convinced I've got yvl on the same page. | 18:14 |
yvl | I'm pretty sure we're not | 18:14 |
menesis | on right go actions | 18:14 |
yvl | but I'll follow th1a :) | 18:14 |
th1a | As of this point there is no right sidebar. | 18:15 |
th1a | It does not exist. | 18:15 |
th1a | And, at this point, the primary function of the top navigation is the same as it is now. | 18:15 |
yvl | anyway | 18:16 |
yvl | for relntionship views | 18:16 |
fsufitch | so, there is no unit testing of the adapters in schooltool.course.course | 18:16 |
yvl | I vote - port them and do nothing more now | 18:16 |
fsufitch | just dropping this thought in | 18:16 |
aelkner | fsufitch, we're not in a place to discuss that right now | 18:17 |
yvl | damn, you had to notice that | 18:17 |
fsufitch | i know, which is why i'm not pushing it | 18:17 |
th1a | Thank you fsufitch. | 18:17 |
fsufitch | but it came up in writing my own tests, and i had to write a silly stub to make the course adapters work | 18:17 |
fsufitch | anyway, carry on | 18:17 |
fsufitch | :) | 18:17 |
th1a | OK, so we won't worry about the relationship modals. | 18:17 |
th1a | We'll just make those regular links. | 18:18 |
th1a | All right, let's break this up, take a 10 minute break, and then replaceafill, aelkner and I will just continue with specific changes to the views we've been working on. | 18:19 |
th1a | OK. | 18:19 |
th1a | ? | 18:19 |
replaceafill | cool | 18:19 |
* th1a drops the bag of gravel. | 18:20 | |
replaceafill | yvl the bug in page 21 is the total width of the form, right? | 18:20 |
replaceafill | it's wider than 544px | 18:20 |
yvl | we can work on them more later | 18:24 |
*** yvl has quit IRC | 18:24 | |
th1a | aelkner: Ready? | 18:31 |
aelkner | ready | 18:34 |
aelkner | what does excess flood mean? | 18:35 |
th1a | OK. | 18:35 |
th1a | Ejaculation. | 18:35 |
replaceafill | :)) | 18:36 |
aelkner | thaks for the sarcastic non-answer, i always like that | 18:36 |
aelkner | but it doens't matter | 18:36 |
aelkner | what do we want to look at first | 18:36 |
th1a | OK, aelkner, can you start by getting our header styles in line with what's on page 17? | 18:36 |
aelkner | replaceafill, headers.css, pretty please | 18:37 |
replaceafill | then we'll have paragraphs.css | 18:37 |
replaceafill | divs.css | 18:37 |
replaceafill | just think as headers as "general" styles | 18:38 |
replaceafill | and general styles go into flourish.css | 18:38 |
aelkner | ok | 18:38 |
aelkner | so i see they don't have everything they need yet | 18:38 |
aelkner | like spacing | 18:38 |
replaceafill | correct | 18:38 |
th1a | replaceafill: You can try to sort out the sidebar/main issue. | 18:39 |
replaceafill | ok | 18:39 |
replaceafill | so, we're getting rid of the right sidebar, correct? | 18:39 |
replaceafill | i'll remove it from the template and adjust the css | 18:40 |
th1a | As far as I knew it never existed. | 18:40 |
aelkner | replaceafill, now would be a good time to sort our the h5 h3 thing | 18:40 |
th1a | I think h5 no longer exists to us. | 18:40 |
replaceafill | aelkner definitely | 18:40 |
aelkner | does the accordion need to use an h element for the header? | 18:40 |
replaceafill | aelkner just go in descending order according to p17 | 18:40 |
replaceafill | the accordion can use anything | 18:41 |
replaceafill | you define that selector when you're setting it up | 18:41 |
aelkner | well, perhaps we should avoid using an h for that | 18:41 |
aelkner | since we will want h elements to style a certain way | 18:41 |
replaceafill | aelkner i think the issue is Sections Taught | 18:41 |
aelkner | i know, but | 18:41 |
replaceafill | and that's not an accordion header | 18:42 |
aelkner | in order to choose the h element for that, i wanted to sort out the accordion header | 18:42 |
th1a | I'm not clear on what aelkner is referring to. | 18:42 |
th1a | "Sections" or "Sections taught"? | 18:42 |
aelkner | Sections | 18:42 |
aelkner | we should use an element there that doesn't already have style choices assigned to it | 18:43 |
th1a | We're following the standard already, right? | 18:43 |
replaceafill | aelkner it doesnt matter, you styled the accordion heaeders already | 18:43 |
replaceafill | aelkner suppose i use <h1>s for the accordion header, it doesn't matter because .ui-accordion-header sets it up completely | 18:44 |
aelkner | by class, right | 18:44 |
replaceafill | my problem is the content of the accordion | 18:45 |
aelkner | so if we use h1 for the accordion header | 18:45 |
replaceafill | that needs to use "general" styles | 18:45 |
aelkner | then the general styles will not apply to it? | 18:45 |
th1a | ... the accordion widget styles we can't do much with. | 18:45 |
aelkner | because the class styles will override it? | 18:45 |
replaceafill | aelkner correct | 18:46 |
th1a | So that's fine as is. | 18:46 |
replaceafill | aelkner for the content of the accordion you just decide what standard style you need | 18:46 |
replaceafill | according to page 17 | 18:46 |
aelkner | we're getting to that | 18:46 |
aelkner | first, i'm going to change the accordion, hence, the viewlets | 18:47 |
th1a | ... | 18:47 |
th1a | Can we get the header styles correct first? | 18:47 |
aelkner | ok, fine | 18:47 |
replaceafill | to me, accordion content should use Header 3 (as it is) | 18:47 |
aelkner | what h elemet do we want for Sections Taught | 18:47 |
replaceafill | page 16 | 18:47 |
replaceafill | we just need margin-bottoms for headers | 18:48 |
th1a | Yes. | 18:48 |
aelkner | so th1a, about the tables | 18:48 |
th1a | Yes? | 18:49 |
aelkner | remember we changed the according header styles because we thought we would need sub-headings for the tables | 18:49 |
aelkner | but we don't if we use h3 instead | 18:49 |
aelkner | but i stil like the color choices for the accordions | 18:49 |
aelkner | and we don't need to use table heading/sub-heading | 18:50 |
th1a | Yes... I see. | 18:50 |
aelkner | if you like the h3 in its place | 18:50 |
th1a | Oh... | 18:50 |
aelkner | personnaly, i'm not crasy about the look of the tables in the guidelines | 18:51 |
aelkner | i mean with the subheadings | 18:51 |
aelkner | but that's your call | 18:51 |
th1a | Well... since we need two edit links anyhow, the current implementation is probably better. | 18:51 |
aelkner | yeah, i was thinking the same | 18:52 |
* th1a is trying to figure out how to capture Launchpad's edit icon. | 18:52 | |
th1a | The web used to be simpler... | 18:52 |
replaceafill | th1a can you refresh the person page? | 18:52 |
th1a | Yes. | 18:52 |
aelkner | i'm not crazy about the pencil, but i'm sure i'll lose that one :) | 18:52 |
replaceafill | that's 8px for margin-bottom | 18:52 |
th1a | Yes, that's better. | 18:52 |
replaceafill | for headers | 18:52 |
aelkner | i don't have an alternative suggestion anyway | 18:52 |
replaceafill | and "paragraph" style for the links | 18:52 |
aelkner | actually, some interfaces use a word AND an icon | 18:53 |
aelkner | like 'edit' with a pencel | 18:53 |
th1a | There's a table body specification. | 18:53 |
replaceafill | i also applied "paragraph" style for list items | 18:54 |
replaceafill | like the advisor/advisees names | 18:54 |
aelkner | speaking of advisory | 18:54 |
aelkner | should that we a table? | 18:54 |
aelkner | probably a dumb suggestion | 18:54 |
aelkner | considering it's just the one column | 18:55 |
th1a | No, I'm thinking "yes." | 18:55 |
th1a | It could be more than one column. | 18:55 |
aelkner | there's also the question of the heading for the column | 18:55 |
replaceafill | id' like first name, last name | 18:55 |
aelkner | ah | 18:55 |
replaceafill | or last name, first name as the correct order is now :) | 18:55 |
aelkner | so we want two columns for all persons displayed in table? | 18:55 |
replaceafill | and sortable! :D | 18:56 |
replaceafill | (kidding) | 18:56 |
aelkner | it's something to think about at this point | 18:56 |
replaceafill | table formatters! | 18:56 |
replaceafill | sorry aelkner, go on :) | 18:56 |
th1a | In my mind, it should be the same widget as on the people view, just filtered differently. | 18:56 |
th1a | It should just be that. | 18:56 |
aelkner | i want to work with yvl on better pythn classes for table formatters | 18:56 |
aelkner | we could use them in the short term | 18:57 |
th1a | Why can't we reuse that? | 18:57 |
aelkner | making it easier for us to say, 'we'll just add a column' | 18:57 |
replaceafill | we can | 18:57 |
th1a | OK, lets do that. | 18:57 |
aelkner | th1a, could we table the idea until tomorrow morning, and | 18:57 |
aelkner | discuss the possibility of pair programming it | 18:57 |
th1a | Well, what's the problem? | 18:58 |
th1a | We've already got a person table. | 18:58 |
th1a | Sortable. | 18:58 |
th1a | We can't re-use it? | 18:58 |
aelkner | no | 18:58 |
aelkner | every view that uses a table | 18:58 |
replaceafill | aelkner you can | 18:58 |
aelkner | needs a couple pages worth of python code to set it up | 18:58 |
replaceafill | i disagree | 18:59 |
replaceafill | it's not that hard | 18:59 |
replaceafill | it's tedious | 18:59 |
replaceafill | but not hard | 18:59 |
aelkner | you like tedium, i don't | 18:59 |
aelkner | my head explodes and i shut down | 19:00 |
replaceafill | can i give it a try? | 19:00 |
aelkner | i don't think th1a wants that | 19:00 |
aelkner | it would make much ore sense for tables to be built in views with simple dictionaries | 19:00 |
replaceafill | if my head explodes doing it i quit the idea :) | 19:00 |
replaceafill | aelkner i agree, it should be simpler | 19:00 |
aelkner | that the base class sorts out | 19:01 |
th1a | I can't imagine that we can't just make a reusable sortable person table that will display whichever list of people you give it. | 19:01 |
aelkner | well, in a simple case | 19:01 |
th1a | Isnt' this a simple case? | 19:02 |
replaceafill | it is | 19:02 |
aelkner | we can just imbed a template in the template, like our page template/class already does | 19:02 |
th1a | Precisely. | 19:02 |
replaceafill | here's a lousy example from cambodia: | 19:02 |
replaceafill | persons = ISchoolToolApplication(None)['persons'] | 19:02 |
replaceafill | self.table = getMultiAdapter((persons, self.request), ITableFormatter) | 19:02 |
replaceafill | items = [member for member in self.group.members] | 19:02 |
replaceafill | self.table.setUp(table_formatter=table.StandaloneFullFormatter, | 19:02 |
replaceafill | items=items) | 19:02 |
replaceafill | 4 lines of python | 19:02 |
replaceafill | and you just render view/tablei n the template | 19:02 |
replaceafill | and that's it! | 19:03 |
replaceafill | no zcml | 19:03 |
replaceafill | and you get first name, last name | 19:03 |
aelkner | well, that's more like it | 19:03 |
th1a | Exactly. | 19:03 |
replaceafill | and if you want to change the sorting of columns to: last name, first name | 19:03 |
replaceafill | one factory class and one zcml registration | 19:03 |
replaceafill | that's it! | 19:03 |
replaceafill | again!!! tedious | 19:03 |
replaceafill | not hard | 19:03 |
th1a | Not even tedious. | 19:04 |
replaceafill | :D | 19:04 |
aelkner | in that case, not even tedious | 19:04 |
aelkner | right | 19:04 |
replaceafill | ;) | 19:04 |
replaceafill | i've learned a few things thanks to Cambodia :P | 19:04 |
replaceafill | and you live with them | 19:04 |
replaceafill | ok, back to css for me | 19:04 |
aelkner | one can learn to love the magic :) | 19:04 |
aelkner | but the magic upsets the newbie | 19:05 |
aelkner | as long as we have some docs that point to live examples | 19:05 |
aelkner | then the magic isn't so bad | 19:05 |
replaceafill | all i'm saying is, try it out | 19:05 |
replaceafill | i can help | 19:06 |
replaceafill | i know it's doable | 19:06 |
aelkner | i know it is now, and i will | 19:06 |
th1a | OK. Great. | 19:06 |
aelkner | i was just saying on the subject of magic in general | 19:06 |
aelkner | so what about this sortable persons table | 19:06 |
th1a | What's up with the spacing under the sections taught table? | 19:06 |
aelkner | th1a, i'm not done | 19:07 |
replaceafill | th1a the accordions use the same height by default | 19:07 |
replaceafill | th1a there's an option to override | 19:07 |
replaceafill | autoHeight: false | 19:07 |
aelkner | ok, i'll come back to the tables discussion later | 19:07 |
replaceafill | i remember i told aelkner about it | 19:07 |
replaceafill | sorry aelkner go on | 19:07 |
replaceafill | i'll try not to interrupt anymore :) | 19:08 |
aelkner | i don't remember autoHeagith | 19:08 |
replaceafill | http://schooltool.pov.lt/irclogs/%23schooltool.2011-06-08.log.html#t2011-06-08T20:48:41 | 19:08 |
th1a | replaceafill, So they'll all be the height of the tallest one? | 19:08 |
replaceafill | :) | 19:08 |
replaceafill | th1a correct | 19:08 |
aelkner | so what are we doing right now? am i changing css? | 19:08 |
th1a | We're returning to the Sections accordion. | 19:09 |
th1a | We should turn autoheight off because occasionally one of these will get much bigger than the rest. | 19:09 |
th1a | So do that aelkner. | 19:10 |
aelkner | reading the docs... | 19:13 |
replaceafill | aelkner could you convert the <script></script> element to a file resource? | 19:13 |
th1a | replaceafill: do you know how to track down the LP edit icon. | 19:13 |
th1a | I can't track this stuff down anymore. | 19:14 |
aelkner | replaceafill, while i'm at it, should i keep header as h5? | 19:16 |
aelkner | keeping it the same means not having to change the viewlets | 19:16 |
replaceafill | i'd like a <div> with a class there | 19:17 |
aelkner | but it's your call | 19:17 |
replaceafill | and tell the accordion the selector instead | 19:17 |
th1a | I don't think there should be any h4 or h5's. | 19:17 |
aelkner | ok, h1 then? | 19:17 |
replaceafill | aelkner forget it, use h2 | 19:17 |
th1a | Which header? | 19:17 |
aelkner | the accordion | 19:17 |
th1a | ... | 19:18 |
th1a | like "Advisory?" | 19:18 |
aelkner | i'm changing behaviour, so it was the time o ask | 19:18 |
replaceafill | aelkner think of it as this: suppose there are no accordions :) | 19:18 |
replaceafill | i mean, styled | 19:18 |
aelkner | then picking the element matters | 19:18 |
replaceafill | <h2>Advisors</h2> | 19:18 |
th1a | Aaagh. | 19:18 |
th1a | What about this is different than Sections? | 19:18 |
replaceafill | sorry | 19:19 |
replaceafill | that should be | 19:19 |
aelkner | Advisory | 19:19 |
replaceafill | <h2>Advisory</h2> | 19:19 |
aelkner | yes | 19:19 |
replaceafill | sorry : | 19:19 |
replaceafill | :) | 19:19 |
th1a | All these should be exactly the same. | 19:19 |
aelkner | ok, so i'll change the viewlets to render h2 | 19:19 |
th1a | Sections is h3, right? | 19:19 |
th1a | Didn't we like that? | 19:19 |
aelkner | and change the accordion js to use h2 | 19:19 |
replaceafill | Sections should be h2 | 19:19 |
replaceafill | Sections taught is h3 | 19:19 |
aelkner | is that a final decision? | 19:20 |
th1a | NO. | 19:20 |
aelkner | :) | 19:20 |
replaceafill | http://img69.imageshack.us/img69/9241/pantallazopd.png | 19:21 |
replaceafill | look at the page with no javascript | 19:21 |
replaceafill | i'm not saying we should care | 19:21 |
th1a | Lovely. | 19:21 |
replaceafill | i'm just saying that's a good indicator of how to structure content | 19:21 |
replaceafill | to me Adivosry should be <h2> | 19:21 |
replaceafill | Advisors <h3> | 19:21 |
th1a | replaceafill: just try it on the live server so i can see. | 19:21 |
replaceafill | ok | 19:22 |
th1a | It might make the accordions too big. | 19:22 |
*** dadeng has quit IRC | 19:22 | |
aelkner | so am i making the change or not? | 19:22 |
th1a | We're going to take a look. | 19:23 |
th1a | replaceafill is the one with a live server running. | 19:23 |
aelkner | ok | 19:23 |
th1a | As far as I'm concerned, the way sections looks now is fine. | 19:23 |
th1a | But maybe bigger will be better. | 19:24 |
th1a | Are we talking about making it h2 but keeping the same presentation? | 19:24 |
th1a | replaceafill is making my brain explode. | 19:25 |
replaceafill | a sec | 19:25 |
aelkner | th1a, what i was referring to was the accordion header element | 19:26 |
th1a | Yes. | 19:26 |
th1a | Those look fine to me already. | 19:26 |
aelkner | that can be anything since it is styled via acoordion css class | 19:26 |
aelkner | but i thought it best to let replaceafill choose the element | 19:26 |
aelkner | right now Sections Taught is <h3> | 19:26 |
aelkner | so that wouldn't need to change | 19:27 |
aelkner | replaceafill suggested using <h2> for the accordion header | 19:27 |
replaceafill | ok, done | 19:27 |
aelkner | which sounds as good as anything else | 19:27 |
replaceafill | sorry that i dont respond | 19:27 |
replaceafill | but i'm coding :) | 19:27 |
aelkner | np, was glad to get a word in edgewise :) | 19:27 |
replaceafill | see any "visual" change???? | 19:27 |
th1a | Looks the same. | 19:27 |
replaceafill | th1a exactly ;) | 19:27 |
th1a | Unless we turn JS off? | 19:28 |
aelkner | th1a, another thing, this playing with styles thing is probably done best as a pair | 19:28 |
th1a | Yes, you and me. | 19:28 |
th1a | A pair. | 19:28 |
aelkner | i cold be better used off doing something unrelated | 19:28 |
aelkner | you and replaceafill are the ones pairing here | 19:28 |
th1a | I have two pairs. | 19:28 |
replaceafill | look with no javascript: http://img607.imageshack.us/img607/3963/pantallazo1zm.png | 19:28 |
aelkner | i've got three of a kind | 19:29 |
replaceafill | not pretty, but better | 19:29 |
th1a | OK, good. | 19:29 |
th1a | Thanks. | 19:29 |
th1a | Moving on. | 19:29 |
aelkner | btw | 19:29 |
replaceafill | lol | 19:29 |
th1a | replaceafill: Do you know how to find the edit icon? | 19:29 |
replaceafill | (on the 2 pairs) :) | 19:29 |
replaceafill | ah i did | 19:29 |
aelkner | you guys talk to fast | 19:29 |
replaceafill | (im multitasking here...) | 19:30 |
aelkner | i can't get a word in | 19:30 |
replaceafill | th1a wget https://code.launchpad.net/+icing/rev13216/icon-sprites | 19:30 |
replaceafill | rename to png | 19:30 |
th1a | Cool. Thanks. | 19:30 |
aelkner | so i'll go off and think about modal dialogs | 19:30 |
replaceafill | dont point your browser, it has a wrong content-type | 19:30 |
th1a | No... | 19:30 |
th1a | aelkner: We're a pair! | 19:30 |
aelkner | a pair of what? :) | 19:30 |
th1a | Manager/managed. | 19:30 |
replaceafill | a pair of people who care about schooltool ;) | 19:31 |
th1a | OK aelkner, grab that icon. | 19:31 |
replaceafill | it's a sprite | 19:31 |
replaceafill | several icons in there | 19:31 |
th1a | Just to complexify things. | 19:31 |
replaceafill | want me to take the pencil out? | 19:32 |
th1a | Please. | 19:32 |
th1a | aelkner needs it. | 19:32 |
replaceafill | http://69.164.203.135/pencil.png | 19:34 |
th1a | Grab that ad add it as a resource, aelkner. | 19:34 |
replaceafill | what was i doing... | 19:35 |
replaceafill | th1a ok, i'll start reverting the margin changes | 19:37 |
replaceafill | (what we did yesterday) | 19:37 |
replaceafill | and taking the right sidebar out | 19:37 |
replaceafill | and then adding the appropriate whitespace | 19:37 |
th1a | replaceafill: kk. | 19:37 |
th1a | aelkner: Got that? | 19:40 |
aelkner | replaceafill, i made the header element and autoHeight setting change | 19:40 |
aelkner | pushed | 19:40 |
aelkner | please merge and get running | 19:40 |
replaceafill | can you merge to trunk? | 19:40 |
replaceafill | aelkner and dont forget to remove the orange hover | 19:41 |
aelkner | replaceafill, please merge and start server, you already have that paradigm down | 19:41 |
replaceafill | aelkner i've set up like a million instances with a million changes | 19:42 |
replaceafill | please update trunk | 19:42 |
replaceafill | it's easier for me | 19:42 |
replaceafill | i have a trunk instance running | 19:42 |
aelkner | is that the one that we have been sing? | 19:42 |
aelkner | using | 19:42 |
replaceafill | no | 19:42 |
replaceafill | that's one of mine with trunk merged | 19:43 |
replaceafill | but with uncommited changes too | 19:43 |
th1a | How we doing, aelkner? | 19:49 |
th1a | ... | 19:50 |
* th1a goes to take a shower. | 19:52 | |
aelkner | replaceafill, trunk has my changes now | 19:54 |
replaceafill | great, pulling | 19:54 |
aelkner | note how the view itself flickers when the size of the accordion section changes | 19:55 |
replaceafill | yep | 19:55 |
aelkner | as long as that's ok with th1a | 19:55 |
*** alga has quit IRC | 19:56 | |
replaceafill | actually, it flickers even if you dont use autoHeight | 19:56 |
replaceafill | aelkner orange hover next :) | 19:56 |
aelkner | what about it? | 19:57 |
replaceafill | remove it | 19:58 |
aelkner | let me look | 20:00 |
replaceafill | aelkner you need border: none; for .ui-state-hover | 20:00 |
aelkner | ok | 20:03 |
replaceafill | aelkner btw, try using px insted of ems | 20:04 |
replaceafill | it seems like we've left ems out :( | 20:05 |
replaceafill | i liked ems :) | 20:05 |
aelkner | so did i | 20:07 |
aelkner | but the guidelines are all in px, so... | 20:07 |
replaceafill | just for moving the text in the header to the right | 20:07 |
replaceafill | padding-left: 2em; | 20:07 |
aelkner | ah, that | 20:07 |
aelkner | that's because of the iocn | 20:08 |
replaceafill | i know | 20:08 |
replaceafill | :) | 20:08 |
aelkner | so you want that in px | 20:08 |
replaceafill | please | 20:08 |
replaceafill | and for the last rule: | 20:08 |
replaceafill | .ui-accordion-content | 20:08 |
replaceafill | change it to: | 20:08 |
replaceafill | .ui-accordion .ui-accordion-content | 20:08 |
replaceafill | we may want to change the padding of the accordion content | 20:09 |
replaceafill | i'll ask th1a | 20:09 |
th1a | Hm? | 20:09 |
th1a | Are you guys seeing the flicker in firefox? | 20:10 |
th1a | I don't see it in chrome. | 20:10 |
replaceafill | not really | 20:10 |
th1a | OK. | 20:11 |
replaceafill | i saw it with autoHeight: true | 20:11 |
replaceafill | th1a question | 20:11 |
replaceafill | do you like the padding for the accordion content | 20:11 |
th1a | The spacing should be consistent with the rest of the guidelines. | 20:11 |
replaceafill | left and right padding | 20:11 |
replaceafill | ah ok | 20:11 |
replaceafill | however, should we use rules for forms for the content of the accordion? | 20:12 |
replaceafill | like 8px in each side? | 20:12 |
th1a | We should start wit that. | 20:12 |
replaceafill | look at 8px left and right | 20:12 |
replaceafill | padding top and bottom should be set by jquery | 20:13 |
replaceafill | because of the autoHeight | 20:13 |
aelkner | replaceafill, pushed to trunk | 20:14 |
replaceafill | thanks, will pull | 20:14 |
*** menesis has quit IRC | 20:16 | |
replaceafill | pulling | 20:16 |
th1a | I'm afraid we my have to set up a real system for doing this with aelkner... | 20:16 |
th1a | Or maybe I can just pull his branch to my machine. | 20:16 |
th1a | Or something. | 20:16 |
th1a | These five minute gaps are not very sprinty. | 20:18 |
th1a | Perhaps we could just post screenshots... | 20:19 |
th1a | Anything... | 20:19 |
replaceafill | aelkner my bad | 20:20 |
replaceafill | border: none; makes hovering flickers | 20:20 |
replaceafill | .ui-state-hover { | 20:20 |
replaceafill | border: 1px solid #540000; | 20:20 |
replaceafill | } | 20:20 |
replaceafill | can borders be transparent.... | 20:21 |
th1a | aelkner: Are we waiting for something? | 20:22 |
aelkner | taking a quick break | 20:23 |
th1a | Look, aelkner, you need to talk to me here. | 20:23 |
aelkner | let me finish my chicken | 20:25 |
* th1a ponders how difficult it would be to replace aelkner with three Indians. | 20:25 | |
aelkner | sorry, picked a bad time to grab a quick bite | 20:29 |
aelkner | you were discussing changing the instance? | 20:29 |
aelkner | for quicker turnaround? | 20:30 |
th1a | Let's just do screenshots for what we're doing now. | 20:30 |
replaceafill | aelkner sync with trunk | 20:30 |
aelkner | unfortunately, accordions have animation | 20:30 |
aelkner | that can't be expressed in a screenshot | 20:30 |
th1a | aelkner: Would you please do what I ask? | 20:31 |
replaceafill | aelkner i applied the header styles to trunk and a fix for the flickering | 20:32 |
replaceafill | th1a refresh please | 20:33 |
replaceafill | and check the padding of the accordion | 20:33 |
replaceafill | used 8px as for forms | 20:33 |
aelkner | how are we going to proceed here: | 20:34 |
aelkner | 1) start using screenshots | 20:34 |
aelkner | 2) continue to update the instance with changes | 20:34 |
th1a | aelkner: What did I ask you to do? | 20:34 |
th1a | replaceafill: I'm a little dubious about the narrow margin, but lets keep it for now. | 20:35 |
replaceafill | th1a ok | 20:35 |
th1a | Considering the tables are supposed to fill the whole content area. | 20:35 |
th1a | Maybe they should have no margin. | 20:35 |
replaceafill | hhmm | 20:35 |
th1a | (left and right) | 20:35 |
th1a | OK, aelkner. | 20:36 |
th1a | We want that edit icon next to "Sections Taught" | 20:36 |
replaceafill | th1a also, the accordion will be wider once we remove the right sidebar :D | 20:36 |
th1a | OK. | 20:36 |
th1a | Just move onto that stuff please, replaceafill. | 20:36 |
th1a | That's more pressing. | 20:36 |
replaceafill | ok | 20:36 |
aelkner | so th1a, why don't you set up an instance on your own machine for trunk | 20:37 |
aelkner | i can merge any changes i make to that | 20:37 |
th1a | I have one aelkner. | 20:37 |
replaceafill | sync your trunks | 20:37 |
th1a | Look, I'm not asking you. | 20:37 |
th1a | I'm telling you to send me screenshots. | 20:37 |
th1a | When I ask for them, ok? | 20:37 |
aelkner | ok | 20:38 |
th1a | Hm, actually, I guess there isn't literally a section edit view is there? | 20:39 |
th1a | That is, you can only add people to sections right now from the section's view. | 20:39 |
replaceafill | no, there isn't | 20:39 |
th1a | OK, so let's wrap up sections for now then and move onto groups. | 20:40 |
th1a | "Taught" should not be capitalized. | 20:40 |
th1a | It is a label. | 20:40 |
aelkner | page 16 of the guidelines | 20:41 |
th1a | Hm? | 20:41 |
aelkner | but if by disagreeing i'm only going to make you mad, forget about it | 20:41 |
th1a | I'm looking at the GNOME spec. | 20:42 |
th1a | It is a label above a table. | 20:42 |
aelkner | we're not talking about the ubuntu guidlines? | 20:42 |
th1a | There is no capitalization in the Ubuntu guidelines. | 20:42 |
aelkner | page 16 | 20:42 |
aelkner | Global Provider | 20:43 |
th1a | Yes...? | 20:43 |
th1a | How to join | 20:43 |
aelkner | ah | 20:43 |
th1a | I mean, it is a toss up. | 20:43 |
aelkner | yeah, and a slef-contrdictory guideline in that case | 20:43 |
th1a | But the closest thing I can find in GNOME is a sentence. | 20:43 |
aelkner | i guess it's saying both are ok | 20:44 |
th1a | The Ubuntu guidelines have nothing to say about capitalization. | 20:44 |
aelkner | what do mean by find in GNOME? | 20:44 |
th1a | http://developer.gnome.org/hig-book/stable/design-text-labels.html.en#layout-capitalization | 20:44 |
th1a | We talked about this this morning. | 20:44 |
aelkner | yes, i had shut down the tab so i lost it | 20:45 |
th1a | This is why I just wanted to make everything the same. | 20:45 |
aelkner | anyway, it's funny how that section uses sentence capitalization in the red headings | 20:45 |
aelkner | but that's what you're saying | 20:46 |
aelkner | ok, now that i've read further down, i see the table | 20:46 |
th1a | I'm really just trying to apply the guidelines. | 20:46 |
th1a | I have no dogma in this fight. | 20:46 |
aelkner | It's a hard decision to make because we want to apply it globally no matter which one we choose | 20:47 |
aelkner | so the impact of the choice is great even though the choice itself is not so important | 20:47 |
th1a | Well, let's just try it lower case. | 20:48 |
aelkner | i'd be comfortable going by the GNOME table | 20:48 |
th1a | Which element would you call this? | 20:49 |
aelkner | yeah, that's the problem | 20:49 |
aelkner | i just like the idea of having the table, but i don't understand it all | 20:50 |
th1a | Let's just call it a sentence and move on. | 20:50 |
aelkner | ok | 20:50 |
th1a | Now... column ordering. | 20:50 |
th1a | This is a little tricky because this should be consistent. | 20:50 |
th1a | So it makes sense that what we're sorting by should be at left. | 20:51 |
th1a | But it doesn't make sense that what the user cares about is at right. | 20:51 |
th1a | Moreso in Groups than Sections. | 20:51 |
th1a | So I'm thinking the sequence should be reversed. | 20:51 |
th1a | Section | Term | School Year | 20:52 |
th1a | aelkner? | 20:53 |
aelkner | makes sense | 20:53 |
th1a | OK. | 20:53 |
th1a | I'm also thinking that maybe rather than coming up with new architecture for tables, we really just need about five standard ones that it might be easier to just go ahead and write. | 20:54 |
th1a | So sortable: | 20:54 |
th1a | 1) person | 20:54 |
th1a | 2) groups | 20:54 |
th1a | 3) sections | 20:54 |
th1a | ... | 20:55 |
th1a | 4) resources | 20:55 |
th1a | Maybe a couple more. | 20:55 |
th1a | What do you think? | 20:56 |
th1a | We might have that done before yvl can figure out an estimate for a big refactor. | 20:56 |
aelkner | do you mean those tables rendered as a standalone view that can | 20:57 |
aelkner | be inserted into another | 20:57 |
th1a | Like we were discussing for people earlier. | 20:57 |
th1a | Sortable tables. | 20:57 |
th1a | There's just a limited number of combinations we need to reuse. | 20:58 |
aelkner | i like the idea of creating reuable views | 20:58 |
aelkner | sections, do we want course there? | 20:59 |
aelkner | i mean if it is to be reusable | 20:59 |
th1a | Yes. | 20:59 |
aelkner | Section | Course | Term | School Year | 20:59 |
th1a | Now we're running into a width issue. | 20:59 |
th1a | We need to fix these crazy default section titles. | 21:00 |
th1a | But not now for that. | 21:00 |
aelkner | why not now | 21:02 |
aelkner | that's a good idea for the tale | 21:02 |
aelkner | table | 21:02 |
th1a | Well... | 21:02 |
aelkner | well, the issue is, the section title is geneeated | 21:03 |
th1a | If you want to take a quick look at it. | 21:03 |
aelkner | unless the user overrides it | 21:03 |
aelkner | so if the user changed it, we wouldn't want to try and remove the course before rendering it | 21:03 |
replaceafill | th1a sorry to interrupt http://69.164.203.135:6660/persons/alvaro | 21:04 |
aelkner | i should look at section ttle method reall quick | 21:04 |
replaceafill | do you want the accordions to expand? | 21:04 |
replaceafill | th1a same for http://69.164.203.135:6660/persons ? | 21:04 |
replaceafill | (i need to insert the paddings back btw) | 21:04 |
replaceafill | and are those dimension ok for the sidebar and content? | 21:05 |
replaceafill | 250px, 16px, 678px | 21:05 |
replaceafill | copied sidebar width from ubuntu news | 21:05 |
replaceafill | :) | 21:05 |
replaceafill | but they use a larger font | 21:05 |
th1a | That's wider than I want. | 21:06 |
th1a | I want it as narrow as we can reasonably make it. | 21:06 |
replaceafill | yesterday we made it 160px | 21:06 |
th1a | That's fine with me for now. | 21:07 |
th1a | It is kind of a yagni situation. | 21:07 |
th1a | Except for pixels. | 21:07 |
replaceafill | refresh | 21:07 |
replaceafill | 160px | 21:07 |
replaceafill | Add Administrator looks good | 21:07 |
replaceafill | i wonder about "Añadir Administrador" :) | 21:08 |
replaceafill | hey we have firebug ;) | 21:08 |
replaceafill | spanish version fits almost perfect | 21:08 |
th1a | If by "perfect" you mean "just barely" then boost it up another 16 or so. ;-) | 21:09 |
replaceafill | cool | 21:09 |
replaceafill | yes, just barely :) | 21:09 |
replaceafill | expanded accordion | 21:10 |
aelkner | th1a, from the section add view: | 21:10 |
aelkner | # overwrite section title. | 21:10 |
aelkner | section.title = "%s (%s)" % (course.title, section.__name__) | 21:10 |
aelkner | there's a note in the code referring to this bug: | 21:10 |
aelkner | https://bugs.launchpad.net/schooltool/+bug/389283 | 21:10 |
aelkner | where an interesting discussion of section titles and terms took place | 21:11 |
th1a | what is section.__name__ ? | 21:11 |
aelkner | the arbitrary id in the container, not interesting to the user unless | 21:11 |
aelkner | they are importing from XLS | 21:11 |
aelkner | then we force them to specify it | 21:11 |
aelkner | actually, maybe forced is wrong | 21:12 |
aelkner | i have to check | 21:12 |
aelkner | yes, it is required in the import | 21:13 |
th1a | These titles are always redundant. Can we just get rid of the first part | 21:13 |
th1a | so it is "Chemistry (1)" instead of "Chemistry -- Chemistry (1)" | 21:13 |
th1a | In the default case? | 21:13 |
aelkner | "Chemistry (1)" is what the section title should have in it | 21:14 |
th1a | Yes, that's what I'm saying. | 21:14 |
aelkner | so it must be the renderer of the link that is adding the course | 21:14 |
aelkner | let me check | 21:14 |
th1a | Oh... I see. | 21:14 |
th1a | Probably. | 21:14 |
aelkner | ah, it is the view code that does it | 21:15 |
aelkner | so i can change it to not include the course ttle | 21:15 |
aelkner | especally if we have a course column | 21:15 |
aelkner | courses actuelly | 21:15 |
th1a | PLEASE. | 21:15 |
aelkner | Section | Course | Term | School Year? | 21:16 |
th1a | Well, let's try. | 21:17 |
replaceafill | th1a http://69.164.203.135:6660/persons | 21:21 |
th1a | We still need right margins, correct? | 21:22 |
aelkner | th1a, a problem with the courses | 21:22 |
th1a | Multiples? | 21:22 |
aelkner | typically a cell refers to one thing, so it being a link makes sense | 21:23 |
th1a | Maybe we should keep this simple. | 21:23 |
aelkner | but if we take the course titles and join them with ',' | 21:23 |
aelkner | then what link? | 21:23 |
aelkner | we could have consecutive links, no commas | 21:23 |
th1a | Well... the link should really be the text anyhow. | 21:23 |
th1a | Like in /persons now. | 21:24 |
replaceafill | th1a more margin between the sidebar and content? | 21:24 |
aelkner | th1a, don't understand, the link is always the text | 21:24 |
th1a | Looks ok ro mw replaceafill. | 21:24 |
replaceafill | :) | 21:24 |
aelkner | that's what i mean, with courses, it can't be just one link | 21:24 |
th1a | Why couldn't each course link to the relevant course page? | 21:25 |
aelkner | let me see how sections container view in old skin works | 21:25 |
th1a | Identifying sections is a recurring nightmare. | 21:27 |
replaceafill | ok, sync trunk guys | 21:27 |
replaceafill | th1a what's next? | 21:27 |
th1a | Right margins? | 21:28 |
th1a | Bottom margin? | 21:28 |
th1a | We had those and seem to have lost them. | 21:29 |
replaceafill | it's because i removed the background of the body container | 21:29 |
replaceafill | but the right margin is 16px | 21:29 |
replaceafill | according to the guidelines | 21:29 |
replaceafill | i do have to take 16 from below though | 21:30 |
th1a | What about that 224 at the right. | 21:30 |
th1a | ? | 21:30 |
th1a | aelkner: You know, Section | Term | Year might just be best. | 21:30 |
replaceafill | th1a you mean, you still want the whitespace of the right sidebar?!?!? | 21:31 |
replaceafill | :( | 21:31 |
th1a | grayspace. | 21:31 |
th1a | I'm just talking about the spec. | 21:31 |
replaceafill | ah! | 21:31 |
th1a | Yes. | 21:32 |
replaceafill | hold on, let me do a mock to see if that's what you want | 21:32 |
th1a | Remember? | 21:32 |
th1a | We probably should narrow it by the extra width at left. At least. | 21:32 |
aelkner | th1a, ok, then keep the courses in the section title? | 21:34 |
th1a | Cut the first half off anyhow. | 21:34 |
th1a | It is still redundant, or displayed as redundant. Or whatever. | 21:35 |
th1a | Make it stop repeating itself. | 21:35 |
th1a | I don't care how. | 21:35 |
aelkner | what if the section title is different than the course? | 21:35 |
th1a | Fine. | 21:35 |
aelkner | we'll keep it the way it is | 21:35 |
th1a | AAAGHGHGHGHGHG. | 21:35 |
aelkner | just changing the column order | 21:35 |
th1a | Keep the title the way it is? | 21:35 |
aelkner | well, if the user importe the section and the section title does not have the course in it | 21:36 |
aelkner | than removing the course from the section title | 21:36 |
th1a | That is his damn problem. | 21:36 |
aelkner | and not displying the courses wold be confusing | 21:36 |
th1a | Look, please, aelkner. | 21:36 |
aelkner | ok | 21:36 |
aelkner | getting rid of the courses | 21:37 |
th1a | I don't completely understand what is going on here, but surely there is some way we can prevent the default title of every section from being twice as long as it needs to be. | 21:37 |
th1a | Can we just take out the SECOND course title in the default section name then? | 21:37 |
th1a | Why is that one there? | 21:37 |
th1a | One of those is completely unnecessary. | 21:38 |
th1a | Do you understand what I am saying aelkner? | 21:39 |
replaceafill | th1a http://69.164.203.135:6660/persons | 21:41 |
replaceafill | http://69.164.203.135:6660/persons/alvaro | 21:41 |
replaceafill | did i get it? :/ | 21:41 |
aelkner | i sent a screenshot | 21:42 |
* replaceafill hopes he's not making th1a's head to explode :) | 21:42 | |
th1a | That's as good as we're going to get without getting some input from a real designer. | 21:42 |
replaceafill | the real designer: "what's with that grayspace in the right" :D | 21:43 |
aelkner | th1a, if you like the screenshot i'll commit and push | 21:43 |
th1a | aelkner, That's fine. | 21:43 |
replaceafill | aelkner sync before pushing | 21:44 |
aelkner | too late | 21:44 |
aelkner | i just pushed to my branch | 21:45 |
replaceafill | ah, np then | 21:45 |
replaceafill | only sync before pushing to trunk | 21:45 |
replaceafill | i'm pushing to trunk | 21:45 |
th1a | We do need to tweak the spacing. | 21:45 |
th1a | Do we need the margin-tops in the headers as well? | 21:46 |
th1a | h3, etc. | 21:46 |
th1a | Is the line height in there too? | 21:46 |
*** ignas has quit IRC | 21:46 | |
replaceafill | yes, there's line-height in all of them | 21:47 |
*** asharma has joined #schooltool | 21:47 | |
replaceafill | th1a we can add top-margin, but how can we test it? | 21:48 |
replaceafill | porting something? | 21:48 |
th1a | Uh... reload the page? | 21:49 |
*** menesis has joined #schooltool | 21:49 | |
th1a | aelkner's table labels are jammed up against each other. | 21:49 |
th1a | Or, the table above,more specifically. | 21:49 |
replaceafill | th1a in the testing instance? | 21:50 |
th1a | In the screenshot. | 21:50 |
th1a | replaceafill: do you need something else to do? ;-) | 21:50 |
replaceafill | i thought you were going to tell me... | 21:50 |
replaceafill | but now i'm wondering if i want to know... ;) | 21:50 |
th1a | OK. YEs. | 21:50 |
aelkner | oh, sorry, forgot to lowercase Taught and Attended | 21:51 |
th1a | Get to work on the People sidebar, replaceafill. | 21:51 |
th1a | Kill the School thing. | 21:51 |
replaceafill | ah, i hadn't seen aelkner's screenshot | 21:51 |
replaceafill | true, we need margins for headers | 21:52 |
th1a | Yes, we had that conversation last week. | 21:52 |
replaceafill | 16px top, 8px bottom | 21:52 |
th1a | <div> </div> | 21:52 |
th1a | See, we're making progress! | 21:52 |
replaceafill | yikes! | 21:52 |
aelkner | pushed | 21:52 |
replaceafill | no more  's right? | 21:53 |
aelkner | :) | 21:53 |
th1a | Nooooooo! | 21:53 |
replaceafill | aelkner pushed to trunk? | 21:53 |
aelkner | no | 21:53 |
replaceafill | aelkner let me know when you push to trunk, ok? so i can update the isntance | 21:53 |
replaceafill | and see your changes | 21:53 |
aelkner | ok | 21:53 |
replaceafill | ty | 21:53 |
replaceafill | ok, killing School | 21:54 |
aelkner | replaceafill, pushed to trunk | 21:55 |
replaceafill | pulling | 21:56 |
replaceafill | restarting... | 21:56 |
replaceafill | i need to put Álvaro in a section as a student :) | 21:57 |
th1a | Oh! Section size! That's a good one to include too since it is small. | 21:58 |
aelkner | th1a, are you saying add a column to the sections viewlet? | 21:59 |
aelkner | column two, Size | 21:59 |
th1a | I just actually looked at what we have now. | 21:59 |
aelkner | the sections container view, right? | 21:59 |
th1a | Yes. | 21:59 |
th1a | The actual width of the columns is not set by the UWG, correct? | 22:00 |
aelkner | how could it? | 22:01 |
*** replaceafill_ has joined #schooltool | 22:01 | |
th1a | ? | 22:01 |
th1a | OK. | 22:01 |
replaceafill_ | sorry got disconnected | 22:01 |
aelkner | except maybe if each column width had to be a multiple of some numbe of pixels | 22:01 |
*** replaceafill has quit IRC | 22:01 | |
*** replaceafill_ is now known as replaceafill | 22:01 | |
th1a | So this is sorted by year, then term, then section title? | 22:02 |
aelkner | yes | 22:02 |
th1a | OK, let's move on. | 22:03 |
th1a | Hrm. | 22:04 |
th1a | Groups. | 22:04 |
th1a | OK, I think we need to make the labels standard. | 22:05 |
th1a | So try "Group memberships" | 22:05 |
th1a | For a label. | 22:05 |
th1a | Flip the columns. | 22:06 |
th1a | and then we can try the edit icon next to "Group memberships" that'll link to the group relationship edit page. | 22:06 |
th1a | make sense, aelkner? | 22:07 |
replaceafill | th1a http://69.164.203.135:6660/persons/alvaro | 22:07 |
replaceafill | check the spacing for the table and header | 22:08 |
th1a | Sections? | 22:08 |
replaceafill | yes | 22:08 |
th1a | Isn't that what aelkner just changed? | 22:08 |
* replaceafill looks | 22:09 | |
aelkner | yeah, what heppened to the spacing? | 22:09 |
aelkner | th1a, i can add the h3 and flip the columns groups now | 22:09 |
th1a | ok | 22:10 |
replaceafill | no revisions to pull in trunk... | 22:11 |
replaceafill | i'll stop working on what aelkner is changing | 22:11 |
replaceafill | i'll go fix the sidebar | 22:11 |
th1a | please | 22:11 |
aelkner | replaceafill, pushed to trunk | 22:14 |
replaceafill | pulling | 22:14 |
*** fsufitch has quit IRC | 22:17 | |
replaceafill | th1a http://69.164.203.135:6660/persons | 22:24 |
replaceafill | School viewlet manager gone | 22:24 |
th1a | OK. | 22:25 |
th1a | Now make it more Ubuntu news style. | 22:25 |
th1a | WIthout making the fonts bigger... | 22:25 |
replaceafill | :| | 22:25 |
replaceafill | ok | 22:25 |
replaceafill | th1a http://69.164.203.135:6660/persons | 22:29 |
replaceafill | should i make those action links red? | 22:29 |
replaceafill | or underlined? | 22:30 |
th1a | Just standard links for now. | 22:30 |
*** alga has joined #schooltool | 22:31 | |
replaceafill | refresh | 22:32 |
* replaceafill goes to have lunch, will be back in an hour | 22:37 | |
th1a | Make the header bigger, red (underline too), and not bold. | 22:38 |
replaceafill | ok | 22:38 |
th1a | Tighten up the line spacnig for the links. | 22:38 |
th1a | Also... | 22:38 |
replaceafill | ah ok | 22:38 |
th1a | Add... instead of "People" | 22:38 |
th1a | And just Person, Administrator, Student etc. | 22:38 |
replaceafill | ok | 22:38 |
th1a | And take Persons out for now. | 22:38 |
replaceafill | got it | 22:39 |
replaceafill | will start with that when i come back | 22:39 |
*** ignas has joined #schooltool | 22:39 | |
* replaceafill is back | 23:20 | |
replaceafill | th1a http://69.164.203.135:6660/persons | 23:28 |
replaceafill | i don't like the red "Add" | 23:28 |
replaceafill | it looks like a link | 23:28 |
replaceafill | ah! i'll change those orange icons in the accordions | 23:36 |
*** menesis has quit IRC | 23:40 | |
replaceafill | aelkner pushed new jquery icons to trunk | 23:51 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!