| *** menesis has quit IRC | 00:20 | |
| *** alga has quit IRC | 04:44 | |
| replaceafill | aelkner, you around? | 05:20 |
|---|---|---|
| *** th1a has quit IRC | 07:35 | |
| aelkner | replaceafill, you there? | 08:08 |
| *** replaceafill has quit IRC | 08:54 | |
| *** yvl has quit IRC | 10:39 | |
| *** yvl has joined #schooltool | 10:42 | |
| *** menesis has joined #schooltool | 11:32 | |
| *** alga has joined #schooltool | 12:45 | |
| *** menesis has quit IRC | 14:40 | |
| *** replaceafill has joined #schooltool | 16:00 | |
| *** menesis has joined #schooltool | 16:11 | |
| *** th1a has joined #schooltool | 16:19 | |
| th1a | replaceafill: zyt? | 17:19 |
| replaceafill | th1a, yes | 17:19 |
| th1a | I think I'll go through the bugs and assign a bunch to you. | 17:21 |
| replaceafill | th1a, ah cool | 17:21 |
| th1a | Unless you have a better idea of what to do. | 17:21 |
| replaceafill | well, i just wanted that the gradebook had good functional test coverage, so i can add the preferences feature safely, and do the score refactoring needed for cambodia | 17:22 |
| replaceafill | and it helped me find a few bugs too | 17:22 |
| replaceafill | even in cando | 17:22 |
| th1a | How much more work it there in the above? | 17:22 |
| replaceafill | finishing adding tests, this week, adding the preference feature + score refactoring, 2 days next week i guess | 17:23 |
| replaceafill | the first bugs i was going to focus next week, were some small ones about report sheets | 17:24 |
| replaceafill | that are already assigned to me | 17:25 |
| th1a | OK. | 17:25 |
| replaceafill | btw, i had a question about the fck editor widget | 17:25 |
| th1a | I'll probably shift some that are currently assigned to other people. | 17:25 |
| replaceafill | ok | 17:25 |
| replaceafill | why do we need rich text support? | 17:25 |
| replaceafill | i havent seen it used yet, at least in the gradebook, do you know where it's used? | 17:26 |
| th1a | Comments. | 17:27 |
| th1a | Yes, we do need it. | 17:27 |
| replaceafill | yes | 17:27 |
| replaceafill | ok | 17:27 |
| replaceafill | yes, i saw the comments scores | 17:27 |
| th1a | I *wish* we didn't. | 17:27 |
| replaceafill | :) | 17:27 |
| replaceafill | th1a, in linked columns you pick activities, totals or averages from other worksheets, correct? | 17:32 |
| replaceafill | is there a reason why deployed activities from report sheets are not pickable? | 17:32 |
| th1a | Oh, sorry. | 17:38 |
| th1a | Covered you up. :-) | 17:38 |
| replaceafill | th1a, http://img214.imageshack.us/img214/2695/pantallazocj.png | 17:39 |
| th1a | replaceafill, I suppose no reason. | 17:39 |
| replaceafill | Report Activity 1.1 is a comment | 17:39 |
| th1a | Do we need to unescape there? | 17:39 |
| replaceafill | wonder how do you translate html to rml... | 17:39 |
| th1a | Oh... does RML use <b> instead of <strong>? | 17:42 |
| th1a | Where did the strong tag come from? | 17:42 |
| replaceafill | i guess the strong is stored by the fck widget | 17:42 |
| replaceafill | i put bold on that line | 17:42 |
| th1a | Probably we can change that in fck. | 17:42 |
| th1a | That would be the thing to do. | 17:42 |
| replaceafill | but then you lose the rich functionality, right? | 17:43 |
| replaceafill | you mean store just plain text, or change fck to spit things rml understands? | 17:43 |
| th1a | Change fck to use <b> instead of <strong> | 17:44 |
| th1a | assuming that's what rml expects. | 17:44 |
| replaceafill | hhmm i think rml does <strong> using paragraph styles... | 17:46 |
| th1a | You might need to setFont to bold. | 17:50 |
| th1a | Inside the story, you can also do a number of things that you can't do with the drawString commands. For a | 17:50 |
| th1a | start, you can use bold, italics and underlining. If you are familiar with HTML, you will recognize these tags - | 17:50 |
| th1a | <i> and </i> start and stop italics, <b> and </b> start and stop the text being set as bold, and <u> and | 17:50 |
| th1a | </u> start and stop underlining. | 17:50 |
| replaceafill | th1a, i reported it, so we dont forget: https://bugs.launchpad.net/schooltool.gradebook/+bug/702918 | 17:52 |
| th1a | We just need to change it to <b> | 17:52 |
| th1a | What is fck called now? | 17:52 |
| th1a | http://cksource.com/forums/viewtopic.php?f=5&t=14301 | 17:53 |
| replaceafill | at least in the gradebook code i see references to it like: _unescape_FCKEditor_HTML | 17:53 |
| th1a | Well, that may be necessary too. | 17:53 |
| th1a | As usual I think I've drifted onto a different question. | 17:54 |
| replaceafill | :D | 17:54 |
| th1a | Yes, regardless it needs to be unescaped. | 17:54 |
| th1a | Or never escaped. | 17:55 |
| th1a | But also, fck should be set to use <b> and <i> | 17:55 |
| replaceafill | hhmm, maybe 'HTML code for Comment scores is not escaped in report card' is not the right title for the bug... | 17:55 |
| replaceafill | 'is not interpreted...' | 17:56 |
| th1a | Switch it to <b> first. | 17:56 |
| th1a | See what happens. | 17:56 |
| replaceafill | ok | 17:56 |
| * replaceafill goes hacking fck | 17:57 | |
| * th1a goes to get lunch. | 18:18 | |
| replaceafill | aelkner, zyt? | 18:53 |
| aelkner | hey replaceafill | 18:56 |
| replaceafill | hey aelkner | 18:56 |
| replaceafill | question | 18:56 |
| replaceafill | did you create gradebook.browser.report_utils? | 18:56 |
| replaceafill | specifically buildHMTLParagraph | 18:57 |
| replaceafill | *buildHTMLParagraphs | 18:57 |
| * th1a is back. | 18:58 | |
| aelkner | that was originally custom code yvl wrote for the sla narrative report | 18:59 |
| replaceafill | th1a, even if we switch it to <b> there's a escaping function that is supposed to remove invalid tags before rendering the paragraph | 18:59 |
| aelkner | i used it in the gradebook reports, so yes | 18:59 |
| replaceafill | aelkner, these two lines got my attention: | 18:59 |
| replaceafill | # Unescape some of the tags which are also valid in Reportlab | 18:59 |
| replaceafill | valid_text = escaped_reportlab_tags_re.sub(u'<\g<1>>', fixed_escaping) | 18:59 |
| th1a | Does <b> give you bold? | 18:59 |
| replaceafill | th1a, the change in the editor you pointed me to didnt work, maybe it's the version of the editor | 19:00 |
| replaceafill | we're using fckeditor 2.6.4.1 | 19:01 |
| th1a | hm | 19:01 |
| replaceafill | i found this: http://drupal.org/node/457576 | 19:01 |
| replaceafill | specifically, http://drupal.org/node/457576#comment-2008110 | 19:01 |
| replaceafill | i was going to test: FCKConfig.CoreStyles['Bold'] = {Element : 'b', Overrides : 'strong' }; | 19:02 |
| replaceafill | th1a, yep, that worked | 19:04 |
| th1a | cool. | 19:04 |
| replaceafill | th1a, now i get: http://img832.imageshack.us/img832/9453/pantallazo5e.png | 19:05 |
| replaceafill | :( | 19:05 |
| replaceafill | <b>Mundo</b> | 19:05 |
| th1a | I figured there was also some kind of escaping problem. | 19:05 |
| *** alga has quit IRC | 19:06 | |
| th1a | aelkner: Phone? | 19:23 |
| replaceafill | th1a, YES! | 19:25 |
| replaceafill | it's the rml template, it needs content="structure ..." | 19:25 |
| replaceafill | th1a, http://img96.imageshack.us/img96/8926/pantallazo6a.png | 19:26 |
| replaceafill | boy, that was confusing for me :P | 19:26 |
| th1a | ah | 19:47 |
| aelkner | replaceafill, are you saying you found a change needed in schooltool core's ReportBase class? | 19:56 |
| replaceafill | nope | 19:57 |
| replaceafill | it's the rml template for the report card | 19:57 |
| aelkner | where is the structure thing you to? | 19:57 |
| replaceafill | Even though the <strong>, <b>, <em> and <i> tags are valid in Reportlab, the rml template (schooltool/gradebook/browser/rml/report_card_rml.pt) needs a content="structure ..." attribute. This seems to fix the problem. | 19:57 |
| aelkner | schooltool.gradebook core doesn't have your reorg yet, right? | 19:58 |
| replaceafill | nope | 19:58 |
| aelkner | so i can't see the rml directory cause there isn't one there yet | 19:58 |
| replaceafill | working in my branch | 19:58 |
| aelkner | so i can't see what you're saying | 19:59 |
| replaceafill | you can, let me get the file for you | 19:59 |
| replaceafill | schooltool.gradebook/src/schooltool/gradebook/browser/report_card_rml.pt | 20:00 |
| replaceafill | in trunk | 20:00 |
| replaceafill | line 115 | 20:00 |
| aelkner | ah, the score | 20:06 |
| aelkner | so it just need structure there? | 20:06 |
| replaceafill | yes | 20:07 |
| replaceafill | this is why i think it's worth adding ftest to the gradebook :) | 20:07 |
| th1a | Yes, it is a good time. | 20:10 |
| th1a | replaceafill: Some of the bugs I'm reassigning to you might not be bugs anymore. | 21:03 |
| replaceafill | ah, ok, ill check them | 21:08 |
| th1a | I think a lot are fixed. | 21:08 |
| replaceafill | i saw one about zope.html being upgraded | 21:08 |
| replaceafill | ah no, i guess it's stil valid: https://bugs.launchpad.net/schooltool/+bug/485898 | 21:09 |
| replaceafill | ...although we're using the latest version: 2.2.0... | 21:10 |
| replaceafill | oh, zope.html-2.2.0-py2.6.egg/zope/html/ckeditor/3.2.1/ | 21:11 |
| th1a | replaceafill: I'm giving you plenty to choose from. ;-) | 21:15 |
| replaceafill | :| <- whatever that means :P | 21:15 |
| replaceafill | ah, interesting, zope.html has both, fckeditor and ckeditor | 21:20 |
| replaceafill | the gradebook is using fck | 21:20 |
| th1a | Yes, menesis is looking at that issue. | 21:21 |
| *** menesis has quit IRC | 21:29 | |
| replaceafill | th1a, any objection if i try to make this: http://img80.imageshack.us/img80/4300/pantallazodu.png | 21:45 |
| replaceafill | look more like this: http://img593.imageshack.us/img593/8807/pantallazo1zf.png | 21:45 |
| replaceafill | aelkner, in which case the source for an ILinkedColumnActivity wont provide IActivity or IWorksheet? | 21:54 |
| replaceafill | i can't think of any | 21:55 |
| *** menesis has joined #schooltool | 22:19 | |
| *** dadeng has joined #schooltool | 22:57 | |
| th1a | replaceafill: That sounds fine. | 22:58 |
| replaceafill | th1a, cool, i'll put it on my todo | 22:58 |
| replaceafill | nice weight values ;) http://img408.imageshack.us/img408/3685/pantallazocl.png | 23:20 |
| *** dadeng has quit IRC | 23:29 | |
| *** replaceafill has quit IRC | 23:35 | |
| *** alga has joined #schooltool | 23:42 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
