| *** dwelsh has quit IRC | 00:07 | |
| *** replaceafill has quit IRC | 00:10 | |
| *** replaceafill has joined #schooltool | 00:47 | |
| *** replaceafill has quit IRC | 00:58 | |
| *** fsufitch has joined #schooltool | 01:36 | |
| jelkner | fsufitch: good evening! | 02:05 |
|---|---|---|
| fsufitch | jelkner: hi | 02:06 |
| fsufitch | wat's up? | 02:06 |
| jelkner | fsufitch: we need to get you and ccarey to coordinate with dwelsh your trip to philly | 02:21 |
| fsufitch | yeah | 02:22 |
| fsufitch | i was gonna ask you guys what we're doing xD | 02:22 |
| jelkner | here is how i imagine it will go: | 02:22 |
| jelkner | you (and/or chris) will get one of your parents to drop you off at ACC early friday morning | 02:23 |
| jelkner | (around 8 am) | 02:36 |
| jelkner | then you leave with dave and jason and drive to philly | 02:36 |
| jelkner | someone picks you up on Sunday evening | 02:37 |
| jelkner | around 9 pm | 02:37 |
| fsufitch | sounds fun | 02:37 |
| fsufitch | fri 23 jan rite? | 02:38 |
| fsufitch | or was it 30 | 02:38 |
| fsufitch | i rememberd 27 for some reason | 02:38 |
| fsufitch | but that's a tue | 02:38 |
| jelkner | 23rd | 02:38 |
| fsufitch | k | 02:38 |
| jelkner | http://educon21.wikispaces.com | 02:38 |
| fsufitch | yeah i was too lazy to go the page XD | 02:39 |
| fsufitch | do we get listed on the schedule/events? | 02:40 |
| fsufitch | or are we so small we dont matter? | 02:40 |
| jelkner | we need to have a pre discussion about what goals you have for tjTalk | 02:40 |
| fsufitch | yeah | 02:41 |
| fsufitch | i need to get two things done before the conference | 02:41 |
| fsufitch | 1. bookmarking questions | 02:41 |
| fsufitch | 2. the search | 02:41 |
| fsufitch | 2 is the hardest | 02:41 |
| fsufitch | and btw, any writing on tjTalk we do will have to be in a separate branch that I will merge into the trunk later | 02:41 |
| fsufitch | because i'm not allowed to use outside help coding my school proj | 02:42 |
| fsufitch | that, or i'll transfer tjtalk to a school branch | 02:42 |
| *** th1a has joined #schooltool | 02:42 | |
| jelkner | fsufitch: i'm glad you brought that up | 02:43 |
| jelkner | because we need to have a clear plan for working around that | 02:44 |
| jelkner | i have an idea | 02:44 |
| jelkner | what about focusing on the integration with the schooltool gradebook? | 02:44 |
| jelkner | that is not part of your project | 02:44 |
| th1a | jelkner! | 02:44 |
| fsufitch | jelkner: no it is not | 02:47 |
| fsufitch | so we can do that :) | 02:47 |
| fsufitch | sry for delay, i had to take a call from the president of tj nhs about nhssl :) | 02:48 |
| fsufitch | th1a! | 02:48 |
| jelkner | cool | 02:48 |
| jelkner | how are they liking it? | 02:49 |
| fsufitch | we're actually just launching it tomorrow | 02:49 |
| jelkner | ah, good | 02:49 |
| jelkner | please let me know how it goes | 02:49 |
| fsufitch | yup yup | 02:49 |
| fsufitch | they love the whole design | 02:49 |
| fsufitch | yet to see how it'll work live ;) | 02:49 |
| jelkner | btw. have you heard from aaron schuetz? | 02:49 |
| fsufitch | no | 02:49 |
| jelkner | ok | 02:49 |
| jelkner | yorktown is in their second year using it | 02:50 |
| jelkner | and they really like it | 02:50 |
| fsufitch | awesome | 02:50 |
| jelkner | so i expect you won't have too many problems | 02:50 |
| fsufitch | it looks pretty stable | 02:50 |
| jelkner | certainly none that you can't handle ;-) | 02:50 |
| fsufitch | heh :-P | 02:50 |
| fsufitch | indeed | 02:50 |
| fsufitch | i did make a separate branch for the tjhsst version though, if u saw | 02:50 |
| fsufitch | because we need 3, not 2 types of activities | 02:51 |
| jelkner | that's what aaron wanted to know | 02:51 |
| fsufitch | and different names | 02:51 |
| jelkner | what changes you needed | 02:51 |
| fsufitch | if our changes will influence his stuff? | 02:51 |
| fsufitch | oh | 02:51 |
| fsufitch | the changes were | 02:51 |
| jelkner | yes | 02:51 |
| jelkner | i'll put you in touch with him again | 02:51 |
| jelkner | i don't want to be in the middle of that | 02:51 |
| fsufitch | before: there were individual and group activities | 02:51 |
| jelkner | and now? | 02:52 |
| fsufitch | we need: nhs-sponsored, in-school, and individual out of school | 02:52 |
| fsufitch | (or something close to that in names) | 02:52 |
| jelkner | ah | 02:52 |
| jelkner | interesting | 02:52 |
| fsufitch | it's the way our chapter works | 02:52 |
| fsufitch | i dunno | 02:52 |
| jelkner | a few more use cases like that and it would be time to implement configurable activity types | 02:53 |
| jelkner | so we start with two branches | 02:53 |
| jelkner | and see later if there is a way later to write code that handles both cases | 02:54 |
| jelkner | ok, i need to run | 02:54 |
| jelkner | fsufitch: i'm putting you in charge of getting in touch with ccarey | 02:55 |
| fsufitch | ookay | 02:55 |
| jelkner | i've got a lot on my plate | 02:55 |
| jelkner | i'll email everyone the schedule now that we have worked it out | 02:55 |
| fsufitch | np | 02:55 |
| fsufitch | he's on my bus | 02:55 |
| fsufitch | so it's okay | 02:55 |
| fsufitch | yup | 02:55 |
| jelkner | but i'm leaving implementation to you | 02:55 |
| jelkner | cool | 02:55 |
| fsufitch | :) | 02:56 |
| fsufitch | have a nice evening | 02:56 |
| jelkner | say hi for me | 02:56 |
| fsufitch | yup | 02:56 |
| jelkner | and talk to you soon | 02:56 |
| fsufitch | u too | 02:56 |
| *** jelkner has quit IRC | 02:56 | |
| *** th1a has quit IRC | 05:19 | |
| *** balor has joined #schooltool | 10:50 | |
| *** fsufitch has quit IRC | 13:51 | |
| *** replaceafill has joined #schooltool | 14:10 | |
| *** ignas has joined #schooltool | 15:27 | |
| replaceafill | ignas, the context to a ivocabularyfactory call changes according to the view, right? | 15:35 |
| replaceafill | ignas, btw, good morning :) | 15:36 |
| ignas | replaceafill: good morning :D | 15:36 |
| ignas | replaceafill: yeah, it changes according to the view | 15:36 |
| ignas | replaceafill: which is why we do detection "is it person or person container" in some sources | 15:36 |
| replaceafill | ignas, so detection is ok, right? | 15:37 |
| ignas | so we could use the same source for both add and edit forms | 15:37 |
| ignas | well, most of the time it is, you can use different sources for add and edit forms | 15:37 |
| replaceafill | i've been using some ifs and didnt feel confortable | 15:37 |
| ignas | so you would not need detection | 15:37 |
| ignas | if you want | 15:37 |
| replaceafill | btw, the integration now works | 15:38 |
| ignas | which is Ok too, though you will need 2 different interfaces for form definition, or have to set up form fields manually in each form | 15:38 |
| ignas | integration of what? | 15:38 |
| replaceafill | schooltool.gradebook with external activities | 15:38 |
| ignas | ahh | 15:39 |
| replaceafill | did U write demographics? | 15:39 |
| ignas | replaceafill: which one? | 15:49 |
| replaceafill | i mean the package | 15:50 |
| ignas | nope | 15:50 |
| ignas | not my fault | 15:50 |
| ignas | don't use it anyway | 15:50 |
| replaceafill | :D | 15:50 |
| ignas | look at SLA demographics | 15:50 |
| *** jelkner has joined #schooltool | 15:51 | |
| replaceafill | ignas, i need ASCII tokens for my terms | 15:51 |
| replaceafill | any example in schooltool? | 15:52 |
| ignas | ? | 15:52 |
| ignas | like another ID | 15:52 |
| ignas | you want an additional ASCII field in term | 15:52 |
| ignas | like extend terms | 15:52 |
| ignas | so terms would have Title, Description, __name__ and some ASCII token | 15:53 |
| replaceafill | wow | 15:53 |
| replaceafill | i always use SimpleTerm | 15:53 |
| ignas | ahhh | 15:54 |
| ignas | you mean non -schooltool terms | 15:54 |
| ignas | but terms as in Vocabulary terms | 15:54 |
| replaceafill | yes | 15:54 |
| replaceafill | :D | 15:54 |
| replaceafill | ah sorry, i didnt remember the word term | 15:54 |
| replaceafill | has meaning in st | 15:54 |
| replaceafill | :) | 15:54 |
| ignas | so you need tokens, what about them? | 15:54 |
| ignas | i mean - what's the problem? | 15:56 |
| replaceafill | i mean, activities have __name__ attributes, right? they're numbers | 15:57 |
| replaceafill | integers | 15:57 |
| replaceafill | i guess it's safe to use that as a token for a term representing activities | 15:58 |
| ignas | yeah | 16:01 |
| ignas | i'd guess so too | 16:01 |
| *** replaceafill has quit IRC | 16:31 | |
| *** jstraw has joined #schooltool | 16:32 | |
| *** th1a has joined #schooltool | 16:39 | |
| *** mgedmin has joined #schooltool | 17:05 | |
| *** replaceafill has joined #schooltool | 17:21 | |
| *** balor has quit IRC | 17:39 | |
| *** alga has joined #SchoolTool | 17:44 | |
| *** jstraw has quit IRC | 19:01 | |
| replaceafill | ignas, what's the best way to detect the viewmeta.+ object? | 19:23 |
| ignas | replaceafill: emm, no idea | 19:23 |
| ignas | replaceafill: do two different forms and 2 sources | 19:23 |
| ignas | hmm | 19:23 |
| ignas | i'd just not use the adding views | 19:23 |
| replaceafill | the <addform..> directive looked old :) | 19:24 |
| ignas | it is old | 19:25 |
| *** jelkner has quit IRC | 19:26 | |
| *** mgedmin has quit IRC | 20:48 | |
| *** replaceafill has quit IRC | 20:56 | |
| *** alga has quit IRC | 21:05 | |
| *** ignas has quit IRC | 21:09 | |
| *** elarson_ has joined #schooltool | 21:19 | |
| *** aelkner has quit IRC | 21:23 | |
| *** elarson_ has quit IRC | 21:24 | |
| *** jcrowley has joined #schooltool | 21:25 | |
| *** jcrowley has left #schooltool | 21:26 | |
| *** rbra has joined #schooltool | 21:26 | |
| *** rbra has quit IRC | 21:27 | |
| *** replaceafill has joined #schooltool | 21:55 | |
| *** aelkner has joined #schooltool | 21:58 | |
| *** jelkner has joined #schooltool | 21:59 | |
| jelkner | replaceafil: hey man! | 22:00 |
| jelkner | i mean, replaceafill | 22:00 |
| replaceafill | :) | 22:00 |
| replaceafill | mr. elkner | 22:00 |
| jelkner | which one? | 22:01 |
| jelkner | there are 2 | 22:01 |
| replaceafill | :O | 22:01 |
| replaceafill | the older one ;) | 22:01 |
| jelkner | so, let's talk | 22:01 |
| aelkner | the jelkner one | 22:01 |
| replaceafill | hey aelkner | 22:02 |
| aelkner | hey | 22:02 |
| jelkner | what do we need to do to get me using cando with schooltool gradebook? | 22:02 |
| aelkner | first of all, i need to see what replaceafill did with his gradebook branch | 22:02 |
| replaceafill | https://code.launchpad.net/~replaceafill/schooltool/schooltool.gradebook | 22:03 |
| aelkner | thanks | 22:03 |
| aelkner | replaceafill: first question, why do you 'replace' New Wroksheet' with 'New Activity | 22:26 |
| replaceafill | u mean the title of the anchor? | 22:26 |
| aelkner | the ancjor | 22:26 |
| aelkner | how does one create new worksheets if you got rid of the anchor for it? | 22:27 |
| replaceafill | u sure? | 22:27 |
| aelkner | i'm just gong by the diff | 22:27 |
| replaceafill | i mean, u sure i got rid of the anchor | 22:27 |
| aelkner | i looked at the file, and it is there, higher up | 22:28 |
| aelkner | but your diff suggests that it was at line 45 | 22:28 |
| aelkner | that's weird | 22:29 |
| aelkner | http://bazaar.launchpad.net/~replaceafill/schooltool/schooltool.gradebook/revision/3?start_revid=5 | 22:29 |
| aelkner | did you add it there by accident befoer changing it | 22:30 |
| replaceafill | no | 22:30 |
| aelkner | can you explain the diff? | 22:30 |
| aelkner | the red part i mean | 22:31 |
| replaceafill | opening it | 22:31 |
| replaceafill | ok | 22:31 |
| replaceafill | this was before: | 22:31 |
| replaceafill | well the red part, right? | 22:32 |
| replaceafill | check the content of the "old" anchor | 22:32 |
| replaceafill | it says "NEW ACTIVITY" | 22:32 |
| replaceafill | ;) | 22:32 |
| replaceafill | that's the link that lets you add a New Activity | 22:32 |
| replaceafill | it had its title wrong :) | 22:32 |
| replaceafill | New Worksheet is alive and safe | 22:33 |
| jelkner | replaceafill: from where does upgrade grades get its data? | 22:33 |
| aelkner | oh, the title doesn't impact the view, so we never caught it until you did, right? | 22:33 |
| jelkner | is that the mock you were talking about? | 22:33 |
| replaceafill | jelkner, yes | 22:33 |
| replaceafill | aelkner, yes | 22:33 |
| aelkner | wiat | 22:34 |
| aelkner | i was going to get to that next | 22:34 |
| aelkner | so why should the user need to update the external activity grades manually | 22:34 |
| aelkner | we already have an update button in the gradebook | 22:34 |
| aelkner | why would that button do the work of updating the grades for ALL external activities | 22:34 |
| aelkner | wouldn't | 22:35 |
| replaceafill | good idea! | 22:35 |
| replaceafill | the Update button in the gradebook should Update All External Activities | 22:35 |
| aelkner | i'm sure jelkner would prefer that | 22:35 |
| replaceafill | jelkner, thoughts? | 22:35 |
| jelkner | i wouldn't | 22:35 |
| jelkner | for the reasons we talked about this morning | 22:36 |
| jelkner | we need to make it difficult to accidentally update an external activity | 22:36 |
| jelkner | or teachers will mess things up on a regular basis | 22:37 |
| jelkner | i'm about to submit 2 bugs: | 22:37 |
| aelkner | but jelkner, you want the integration to be seemless for the user | 22:37 |
| aelkner | that means, they change the data in cando | 22:37 |
| aelkner | and then it gets reflected in schooltool with minimal user intervention | 22:38 |
| jelkner | at first i thought so | 22:38 |
| aelkner | admittedly, one button need to be pushed | 22:38 |
| jelkner | after our discussion at the sprint i realized i was wrong | 22:38 |
| jelkner | the problem lies with the way that competencies are dynamic and grades are fixed | 22:38 |
| jelkner | imagine this happening: | 22:39 |
| jelkner | johnny gets a D on his report card | 22:39 |
| jelkner | his parents are pissed and schedule an appointment to come in and see me (his teacher -- this is not meant to be a likely story ;-) | 22:39 |
| jelkner | i pull up my gradebook to show them | 22:40 |
| jelkner | and low and behold, johnny has a C | 22:40 |
| jelkner | how did that happen? | 22:40 |
| jelkner | this would be a big problem | 22:40 |
| aelkner | i understand | 22:40 |
| aelkner | the timing of the update is important | 22:40 |
| replaceafill | :O | 22:40 |
| aelkner | and if it were automatic | 22:40 |
| jelkner | exactly | 22:40 |
| aelkner | it would be bad | 22:40 |
| aelkner | ok | 22:40 |
| jelkner | very bad | 22:40 |
| aelkner | replaceafill: that means you don't need to change anything about that, yey! | 22:41 |
| replaceafill | aelkner, damn! i wanted to :D | 22:41 |
| aelkner | heh | 22:41 |
| aelkner | hehe | 22:41 |
| jelkner | so, while i have the two of you | 22:42 |
| jelkner | can i run these bug by you before i file them? | 22:42 |
| jelkner | bug1: Identifier (optional) should not appear to the teacher at all | 22:43 |
| jelkner | bug2: some big yellow warning should be given to anyone who tries to create two activities with the same name | 22:43 |
| replaceafill | aelkner, do u know if the optional identifier is used in the activities? i guess it comes from the old form machinery, right? | 22:44 |
| jelkner | what do you think? | 22:44 |
| aelkner | jelkner: bug1 makes sense | 22:44 |
| aelkner | bug2 needs to not allow it at all, rather than warning | 22:44 |
| jelkner | fine | 22:44 |
| jelkner | i'm down with that | 22:44 |
| aelkner | that woudl go for changing activites as well | 22:45 |
| aelkner | both views would need the same code | 22:45 |
| jelkner | it is interesting that this bug became apparent with the new machinery replaceafill just added | 22:45 |
| aelkner | and the error message could be 'Activity Name already in use' | 22:45 |
| aelkner | so that's how i'd write it up | 22:46 |
| jelkner | since there are only a small number of possible names for external activities (you get them from a drop down, you don't enter them) | 22:46 |
| jelkner | i stumbled on this bug right away | 22:46 |
| jelkner | (confirming once again that I'm the best damed idiot user around these parts! ;-) | 22:47 |
| replaceafill | :D | 22:47 |
| replaceafill | ah come on man | 22:47 |
| aelkner | i'm confused, how are you using replaceafill's branch? | 22:47 |
| jelkner | he has a test machine | 22:47 |
| aelkner | ah | 22:47 |
| replaceafill | http://168.243.216.33:8000 | 22:47 |
| aelkner | cool | 22:47 |
| replaceafill | aelkner, it's the httpcaller in the functional test :) | 22:48 |
| replaceafill | the debug procedure u taugth me | 22:48 |
| aelkner | so you have to have the functional test running? | 22:48 |
| replaceafill | yes | 22:48 |
| aelkner | that's funny | 22:49 |
| aelkner | but i see that it does the trick for jelkner to see what you're doing | 22:49 |
| jelkner | and find bugs | 22:49 |
| jelkner | cool | 22:49 |
| replaceafill | what's that phrase: poor man's .... something | 22:50 |
| aelkner | yeah, poor man's something something, sure that's it :) | 22:51 |
| jelkner | ok, bugs are filed. | 22:56 |
| jelkner | https://bugs.edge.launchpad.net/schooltool/+bug/314857 | 22:56 |
| jelkner | and | 22:57 |
| jelkner | https://bugs.edge.launchpad.net/schooltool/+bug/314856 | 22:57 |
| jelkner | aelkner: should i assign these to you? | 22:57 |
| aelkner | yes | 22:57 |
| jelkner | done | 22:59 |
| jelkner | i made both priorities medium | 22:59 |
| jelkner | but the duplicate one really has a higher priority | 23:00 |
| jelkner | i would think | 23:00 |
| jelkner | well, since activities can be removed | 23:00 |
| jelkner | the app is still perfectly usable with both bugs intact | 23:00 |
| replaceafill | :) | 23:00 |
| aelkner | true | 23:01 |
| aelkner | replaceafill: i just checked out your branch and tried to run the tests, and it fails on line 66 of the ftests | 23:15 |
| replaceafill | traceback? | 23:15 |
| replaceafill | u sure u have my branch? | 23:16 |
| replaceafill | that line had trouble before | 23:16 |
| replaceafill | i reported it to ignas and he fixed it | 23:16 |
| replaceafill | before i pulled the trunk | 23:16 |
| aelkner | so you pulled the trunk, but did you commit the changes to your branch? | 23:17 |
| replaceafill | yes | 23:17 |
| replaceafill | i have the new line here | 23:17 |
| aelkner | so why do i get the problem? | 23:18 |
| aelkner | i just checked out your branch | 23:18 |
| aelkner | so i should have the latest | 23:18 |
| aelkner | why don't i? | 23:18 |
| aelkner | i just did the checkout now | 23:18 |
| replaceafill | i'm checking revision 5 | 23:19 |
| replaceafill | of my branch | 23:19 |
| replaceafill | http://bazaar.launchpad.net/~replaceafill/schooltool/schooltool.gradebook/annotate/head%3A/src/schooltool/gradebook/browser/README.txt | 23:20 |
| replaceafill | it's the latest | 23:20 |
| replaceafill | maybe u need to pull the other branches? | 23:21 |
| aelkner | why would i need to do that? | 23:21 |
| aelkner | if you have a branch that works, i should just use that | 23:21 |
| replaceafill | i'm using rev 5 and that test pass here | 23:22 |
| aelkner | so i'm not sure what you're saying i shold do | 23:24 |
| aelkner | replaceafill: ? | 23:25 |
| replaceafill | why don't you go to the schooltool branch and make "bzr pull" | 23:25 |
| replaceafill | i remember i had the same error with the lyceum.journal too | 23:26 |
| aelkner | what schooltool branch? | 23:26 |
| replaceafill | in order to get a sandbox u need four branches, right? | 23:26 |
| aelkner | oh, you did this in a sandbox | 23:26 |
| replaceafill | schooltool.gradebook, schooltool.lyceum.journal, schooltool | 23:26 |
| replaceafill | yes? | 23:26 |
| replaceafill | is that bad? | 23:26 |
| aelkner | i was just using your branch by itself | 23:26 |
| aelkner | no, it's not bad | 23:27 |
| replaceafill | i followed the procedure u taught me :) | 23:27 |
| aelkner | i just didn't want to set up yet another sandbox, but i guess i'll have to | 23:27 |
| aelkner | this will take a couple of hours | 23:28 |
| replaceafill | yes, lp is really slow | 23:28 |
| replaceafill | alkner, is it time for touching cando? | 23:29 |
| replaceafill | after you review my code of course | 23:30 |
| aelkner | um | 23:33 |
| aelkner | you'll need to svn copy https://svn.schooltool.org/cando/branches/cmr-6-plus-schoolyears to a branch of your own | 23:34 |
| replaceafill | ok | 23:34 |
| replaceafill | i have never used the "copy" command | 23:35 |
| aelkner | me neither | 23:36 |
| replaceafill | :| | 23:36 |
| aelkner | i don't know if you have access either | 23:36 |
| replaceafill | i dont think so | 23:36 |
| aelkner | how about sending jason straw a note asking him to do it for you | 23:36 |
| replaceafill | ok | 23:37 |
| aelkner | replaceafill: i built the new sandbox, funny how quickly lp was | 23:38 |
| aelkner | quick | 23:38 |
| replaceafill | :O | 23:38 |
| replaceafill | yesterday took me 3 hours!!! | 23:38 |
| replaceafill | to get the damn sandbox | 23:38 |
| aelkner | maybe they fixed something on lp | 23:41 |
| replaceafill | did the ftest pass? | 23:41 |
| aelkner | yes, now that i used the sandbox :) | 23:42 |
| replaceafill | :) | 23:42 |
| aelkner | so did you set up a separate sandbox for the instance that jelkner uses? | 23:43 |
| aelkner | so that you could aadd the httpcall? | 23:43 |
| replaceafill | no, it's the same sandbox | 23:43 |
| replaceafill | i just add the httpcaller at the end of the ftest | 23:43 |
| replaceafill | and the i revert it | 23:44 |
| aelkner | so it's only temporarily available to jelkner anytime he asks to look at it? | 23:44 |
| replaceafill | he wants it on his production instance!! | 23:45 |
| replaceafill | he says "he'll test it by using it" | 23:45 |
| aelkner | i see | 23:45 |
| replaceafill | aelkner, one question | 23:46 |
| replaceafill | external activities should be available in a vocabulary | 23:46 |
| replaceafill | for using a choice field | 23:46 |
| replaceafill | i dont know how to create a token for it | 23:47 |
| aelkner | i saw you ask ignas about this earlier | 23:47 |
| replaceafill | i mean for every term | 23:47 |
| replaceafill | yes | 23:47 |
| aelkner | and i've looked at your stubs | 23:47 |
| replaceafill | i thought about the __name__ attribute | 23:47 |
| aelkner | but i couldn't tell you how that stuff works | 23:47 |
| aelkner | i just follow examples | 23:47 |
| replaceafill | :( | 23:47 |
| replaceafill | ok | 23:48 |
| aelkner | but let's think about this together | 23:48 |
| aelkner | what are you needing to acomplish specifically? | 23:48 |
| replaceafill | a term needs a value (the external activity), a title (the external activity title) and a token (?) | 23:48 |
| replaceafill | the token has to be an ascii string | 23:48 |
| replaceafill | so i cannot use the external activity title | 23:49 |
| replaceafill | because it's unicode | 23:49 |
| aelkner | i haven't had a chance to look at the app running, just your tests | 23:49 |
| aelkner | are you saying | 23:49 |
| replaceafill | sometimes i see people using the id() function | 23:49 |
| aelkner | that you don't have a pulldown for the external activities? | 23:49 |
| replaceafill | in my projects i use the intid utility | 23:50 |
| replaceafill | yes i do | 23:50 |
| replaceafill | the problem is the token | 23:50 |
| aelkner | but your tests pass | 23:50 |
| replaceafill | <option value="token_goes_here">Title goes here</option> | 23:50 |
| replaceafill | because i crafted them | 23:50 |
| replaceafill | (if that's the right expression) | 23:50 |
| aelkner | where? | 23:50 |
| aelkner | what file? | 23:51 |
| replaceafill | hold on | 23:51 |
| replaceafill | looking... | 23:51 |
| replaceafill | src/schooltool/gradebook/browser/activity.py | 23:52 |
| replaceafill | the end of the file | 23:52 |
| replaceafill | method getTerm | 23:52 |
| replaceafill | getValue is innefficient too | 23:52 |
| replaceafill | token=value.title.lower() | 23:53 |
| aelkner | but it works, right? | 23:54 |
| aelkner | using SimpleTerm as you do | 23:54 |
| replaceafill | yes but it's not safe | 23:54 |
| aelkner | how? | 23:54 |
| replaceafill | if somebody sets a title like u"Este niño está bien" | 23:54 |
| replaceafill | could fail | 23:55 |
| replaceafill | because the unicode caracters | 23:55 |
| aelkner | what would be the failure | 23:55 |
| aelkner | isn't everything unicode? | 23:55 |
| aelkner | so comparisons should succeed | 23:56 |
| replaceafill | i guess the vocabulary specification says that the token has to be an ASCII string | 23:56 |
| aelkner | tell you what | 23:56 |
| replaceafill | being ascii you have guaranteed that will be the same in every browser | 23:56 |
| aelkner | let's table that for now | 23:56 |
| aelkner | jelkner's the only one using it at first | 23:57 |
| replaceafill | i you use unicode, the browser encoding can bite u | 23:57 |
| replaceafill | ok | 23:57 |
| aelkner | and he can avoid bad unicode chars | 23:57 |
| aelkner | that could be a bug to fix later | 23:57 |
| aelkner | after we've gotten everything integrated | 23:57 |
| replaceafill | cool | 23:57 |
| replaceafill | i'll write jstraw asking for the branch | 23:58 |
| replaceafill | thanks alan | 23:58 |
| aelkner | almost finished reviewing you diffs | 23:59 |
| aelkner | at revision 5 | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!