*** pcardune has quit IRC | 00:01 | |
*** jinty has quit IRC | 02:03 | |
*** tiredbones has quit IRC | 02:42 | |
*** tiredbones has joined #schooltool | 02:42 | |
*** tristil has joined #schooltool | 05:02 | |
*** tristil has quit IRC | 06:09 | |
*** tristil has joined #schooltool | 06:41 | |
tristil | I'm getting a mysterious traceback relating to the new securitypolicy meta.zcml after the recent merge: http://paste.plone.org/4563 | 06:56 |
---|---|---|
*** tristil has quit IRC | 07:44 | |
*** gintas has joined #schooltool | 10:26 | |
*** ignas has joined #schooltool | 11:01 | |
povbot | /svn/commits: * gintas committed revision 6184: | 11:18 |
povbot | /svn/commits: Removed trailing whitespace. | 11:18 |
povbot | /svn/commits: * gintas committed revision 6185: | 11:20 |
povbot | /svn/commits: More trailing whitespace. | 11:20 |
povbot | /svn/commits: * gintas committed revision 6186: | 11:26 |
povbot | /svn/commits: Whitespace nazism. | 11:26 |
*** vidasp has joined #schooltool | 11:30 | |
*** thisfred has joined #schooltool | 11:31 | |
*** faassen has joined #schooltool | 11:32 | |
povbot | /svn/commits: * gintas committed revision 6187: | 11:47 |
povbot | /svn/commits: Added a setting for public access to the person list, uncommented related test in demographics. | 11:47 |
povbot | /svn/commits: * vidas committed revision 6188: | 11:51 |
povbot | /svn/commits: Evolution script - remove all local grants. | 11:51 |
povbot | /svn/commits: * gintas committed revision 6189: | 11:55 |
povbot | /svn/commits: Removed obsolete branch. | 11:55 |
povbot | /svn/commits: * gintas committed revision 6190: | 12:17 |
povbot | /svn/commits: Allow only the administration to edit access control. | 12:17 |
povbot | /svn/commits: * ignas committed revision 6191: | 12:26 |
povbot | /svn/commits: Replaced OpenOffice writer odt with an Microsoft Excel 97 xls. | 12:26 |
povbot | /svn/commits: XLS because both OpenOffice and Gnumeric support it flawlessly. | 12:26 |
povbot | /svn/commits: * gintas committed revision 6192: | 12:27 |
povbot | /svn/commits: Security views are now longer available to everyone. | 12:27 |
*** vidasp has quit IRC | 12:31 | |
faassen | hm. | 12:41 |
faassen | I'm trying to evolve a sample data database of a february schooltool checkout | 12:41 |
faassen | to the current trunk | 12:42 |
faassen | but evolve10.py fails. | 12:42 |
faassen | because the application object for some reason cannot be adapted to ITimeTables | 12:42 |
faassen | anyone have any clue? | 12:42 |
ignas | can i see a traceback ? | 12:45 |
faassen | Traceback (most recent call last): | 12:45 |
faassen | File "/home/faassen/working/schooltool/schooltool/Zope3/src/zope/app/generations/generations.py", line 404, in evolve | 12:45 |
faassen | manager.evolve(context, generation) | 12:45 |
faassen | File "/home/faassen/working/schooltool/schooltool/Zope3/src/zope/app/generations/generations.py", line 133, in evolve | 12:45 |
faassen | evolver.evolve(context) | 12:45 |
faassen | File "/home/faassen/working/schooltool/schooltool/src/schooltool/generations/evolve10.py", line 45, in evolve | 12:45 |
faassen | for tt in ITimetables(app).timetables.values(): | 12:45 |
faassen | TypeError: ('Could not adapt', <schooltool.app.app.SchoolToolApplication object at 0xb73ef7ac>, <InterfaceClass schooltool.timetable.interfaces.ITimetables>) | 12:45 |
faassen | Traceback (most recent call last): | 12:45 |
faassen | so, it tries to do ITimeTables on a schooltool application object and fails. | 12:45 |
ignas | maybe IHaveTimetables was removed from schooltool App | 12:47 |
ignas | oh | 12:47 |
ignas | i think it was | 12:47 |
faassen | hm. | 12:49 |
faassen | so what now? | 12:49 |
ignas | a sec | 12:49 |
ignas | looking | 12:49 |
povbot | /svn/commits: * gintas committed revision 6193: | 12:49 |
povbot | /svn/commits: Small cleanups. | 12:50 |
povbot | /svn/commits: * gintas committed revision 6194: | 12:50 |
povbot | /svn/commits: Changed wording. | 12:51 |
*** mgedmin has joined #schooltool | 12:51 | |
ignas | it would be nice if you would make a copy of that Data.fs | 12:52 |
ignas | and for now as not to hinder your progress i think using TimetablesAdapter directly on the application should do the trick | 12:53 |
faassen | um. | 12:53 |
faassen | what do you mean, make a copy of the Data.fs for what? | 12:54 |
faassen | I'm testing my own evolution scripts. | 12:54 |
faassen | I have a copy of that Data.fs obviously. | 12:54 |
faassen | I just created it for this purpose. | 12:54 |
faassen | so I could import TimeTablesAdapter and then apply it directly, not doing the adapter lookup? | 12:54 |
faassen | I should check that in, right? | 12:54 |
ignas | yes | 12:55 |
faassen | I just want it to evolve up to the point where it breaks for reasons of my own wrong-doing. :) | 12:55 |
ignas | doing an adapter lookup in an evolution scriptis a bad idea | 12:55 |
ignas | :D | 12:55 |
povbot | /svn/commits: * gintas committed revision 6195: | 12:56 |
povbot | /svn/commits: Allowed leaders to view and edit groups. | 12:56 |
ignas | i would even go as far as to not use the adapter but twiddle with "real" attributes of the object | 12:56 |
ignas | as the code in the adapter might change in the future | 12:56 |
faassen | yucky. | 12:56 |
ignas | and evolution scripts should not "evolve" themselves | 12:56 |
faassen | yea. | 12:56 |
faassen | though in case of IAnnotations and such I might want to still use an adapter. :) | 12:56 |
faassen | but yeah, messing with data directly seems to be the way to go. it's nto going to make evolution easier. | 12:57 |
ignas | yes, but evolution scripts should be 1. stable 2. stable 3. stable | 12:57 |
ignas | can't see easy to write in the list :( | 12:58 |
ignas | and yes i hate it | 12:58 |
ignas | :/ | 12:58 |
faassen | yeah, they're awful. they're definitely not easy to write. | 12:58 |
ignas | have you noticed the new security policy ? | 13:01 |
faassen | yeah. | 13:01 |
faassen | now generation11 fails. | 13:01 |
faassen | I haven't looked at it yet. | 13:01 |
faassen | I just want to get the evolution script for demographics working. | 13:01 |
faassen | I mean, I briefly glanced over it. | 13:01 |
ignas | i mean from the UI perspective | 13:01 |
faassen | Traceback (most recent call last): | 13:01 |
faassen | File "/home/faassen/working/schooltool/schooltool/Zope3/src/zope/app/generations/generations.py", line 404, in evolve | 13:01 |
faassen | manager.evolve(context, generation) | 13:01 |
faassen | File "/home/faassen/working/schooltool/schooltool/Zope3/src/zope/app/generations/generations.py", line 133, in evolve | 13:01 |
faassen | evolver.evolve(context) | 13:01 |
faassen | File "/home/faassen/working/schooltool/schooltool/src/schooltool/generations/evolve11.py", line 39, in evolve | 13:01 |
faassen | roles = IPrincipalRoleManager(app) | 13:01 |
faassen | TypeError: ('Could not adapt', <schooltool.app.app.SchoolToolApplication object at 0xb74487ac>, <InterfaceClass zope.app.securitypolicy.interfaces.IPrincipalRoleManager>) | 13:02 |
faassen | haven't even booted the UI yet. :) | 13:02 |
faassen | since this is security related, I don't know what to do now. | 13:02 |
ignas | i'd even say dump it (we don't have permissions that should get migrated anymore) | 13:02 |
ignas | though i am not sure it is correct approach | 13:03 |
povbot | /svn/commits: * gintas committed revision 6196: | 13:03 |
povbot | /svn/commits: Shuffled security declarations around. | 13:03 |
faassen | dump the whole evolution script? | 13:03 |
faassen | it only seems to be tweaking with roles and permissions. | 13:03 |
ignas | yep | 13:04 |
ignas | these roles do not exist anymore | 13:04 |
faassen | I put a return on top, see which evolution it fails on now :) | 13:04 |
ignas | :) | 13:04 |
faassen | I expected this. | 13:04 |
faassen | I mean, I expected the evolutions wouldn't work and I needed to spend a lot of time fixing existing ones. :) | 13:04 |
faassen | i had a horrible time writing the one evolution I did. | 13:04 |
faassen | replacing objects with instances of another class, yuck. | 13:05 |
ignas | you should not base your opinion on the "VERY WORST CASE i could imagine" ;) | 13:05 |
faassen | of course I should! :) | 13:06 |
ignas | can i say "we told you should use annotations" now ? :) | 13:07 |
faassen | well, I realized that drawback a montha go when I wrote that script. :) | 13:08 |
faassen | it's a question of tradeoffs. | 13:08 |
faassen | and evolution scripts are horrible to write anyway. | 13:08 |
ignas | most of the time, yes | 13:09 |
ignas | as there aren't many unit tests for evolve14, is the __annotations missing trailing "__" intentionally in "new_person.__annotations = person.__annotations__" ? | 13:11 |
faassen | ick, I imagine not. | 13:12 |
faassen | I'll extend the test for that. | 13:13 |
faassen | good catch! | 13:14 |
*** vidasp has joined #schooltool | 13:26 | |
povbot | /svn/commits: * gintas committed revision 6197: | 13:27 |
povbot | /svn/commits: Added settings for group view permission. | 13:27 |
povbot | /svn/commits: * vidas committed revision 6198: | 13:41 |
povbot | /svn/commits: Restore manager user with new permissions (manager group). | 13:41 |
povbot | /svn/commits: * gintas committed revision 6199: | 13:42 |
povbot | /svn/commits: Added a setting for members editing group calendars. | 13:42 |
povbot | /svn/commits: * gintas committed revision 6200: | 13:46 |
povbot | /svn/commits: Everyone can view courses. | 13:46 |
*** Aiste has quit IRC | 13:56 | |
faassen | argh. | 14:07 |
faassen | I really have no idea what I'm doing with evolve10.py | 14:07 |
faassen | I changed it so that evolution doesn't crash | 14:07 |
faassen | but the tests fail now | 14:07 |
faassen | and I have no idea what the tests are even intended to test. | 14:07 |
faassen | I mean, the tests for evolve10 fail. | 14:08 |
faassen | and I don't know what's going on. | 14:08 |
ignas | faassen: the adapter was being stubbed and now as you are not using adaptation it breaks | 14:10 |
faassen | where does it provide the stubbed adapter? | 14:10 |
faassen | I'm trying to figure out where this stubbing takes place. | 14:10 |
faassen | I'd happily use a stubbed adapter. | 14:11 |
ignas | oh sorry | 14:11 |
ignas | it's implements(ITimetables) | 14:11 |
ignas | part | 14:11 |
ignas | not nice | 14:11 |
ignas | you will probably have to add fake annotations | 14:11 |
faassen | but where is it stubbing an adapter? oh, you mean these things implement the interface themselves. | 14:11 |
faassen | instead of going through.. | 14:11 |
faassen | I already did that. | 14:11 |
faassen | it still breaks. | 14:11 |
ignas | faassen: send me a diff for that evolution script | 14:12 |
ignas | and i'll look into it | 14:12 |
faassen | I'll just send you the whole two files. | 14:12 |
ignas | ok | 14:12 |
faassen | ignas@pov.lt, right? | 14:12 |
ignas | yes | 14:12 |
faassen | I'm sending you the code I have now. | 14:12 |
faassen | which adds the annotations (in the tests) | 14:13 |
faassen | and uses the TimetablesAdapter directly. | 14:13 |
ignas | ok | 14:13 |
faassen | though of course that won't be correct. | 14:13 |
faassen | as these things pretend to implement their own adapter. | 14:13 |
faassen | sorto f. :) | 14:13 |
faassen | on their way. | 14:16 |
*** Aiste has joined #schooltool | 14:21 | |
*** alga has joined #SchoolTool | 14:26 | |
povbot | /svn/commits: * gintas committed revision 6201: | 14:27 |
povbot | /svn/commits: Fixed permissions on resources. | 14:27 |
*** vidasp has quit IRC | 14:38 | |
povbot | /svn/commits: * gintas committed revision 6202: | 14:39 |
povbot | /svn/commits: Fixed permissions for terms. | 14:39 |
povbot | /svn/commits: * gintas committed revision 6203: | 14:51 |
povbot | /svn/commits: Oops. | 14:51 |
povbot | /svn/commits: * gintas committed revision 6204: | 15:09 |
povbot | /svn/commits: Added a setting to disallow a user to change preferences. | 15:09 |
povbot | /svn/commits: Currently although access control actually works, there is no good way to hide the preferences view from the user. | 15:09 |
povbot | /svn/commits: * ignas committed revision 6205: | 15:11 |
povbot | /svn/commits: Not very elegant but working fix for an evolution script that relied on adapterst that might not exist anymore in the future. | 15:11 |
ignas | faassen: fixed the script | 15:11 |
faassen | ignas: cool | 15:14 |
faassen | ignas: thanks | 15:14 |
povbot | /svn/commits: * gintas committed revision 6206: | 15:19 |
povbot | /svn/commits: Cosmetic fixes. | 15:19 |
povbot | /svn/commits: * gintas committed revision 6207: | 15:19 |
povbot | /svn/commits: Tabs! | 15:19 |
povbot | /svn/commits: * faassen committed revision 6208: | 15:24 |
povbot | /svn/commits: evolve11 used to set up roles and permissions, but since the new security policy is now in place this has become obsolete (and in fact breaks evolution). | 15:24 |
povbot | /svn/commits: * faassen committed revision 6209: | 15:25 |
povbot | /svn/commits: There was a bug in the carrying over of annotations. Fixed and extended the tests to catch this issue. | 15:25 |
povbot | /svn/commits: * gintas committed revision 6210: | 15:40 |
povbot | /svn/commits: Ouch, our security settings were not persistent ;( | 15:40 |
povbot | /svn/commits: I this that developer sandboxes may also be polluted with nonpersistent dicts... | 15:40 |
*** tiredbones has quit IRC | 15:42 | |
*** tiredbones has joined #schooltool | 15:43 | |
povbot | /svn/commits: * gintas committed revision 6211: | 15:47 |
povbot | /svn/commits: The preference view is now registered on IPersonPreferences, as it should be. The view can now be properly secured. However, the external menu item can not be hidden automatically as it is. | 15:47 |
povbot | /svn/commits: * vidas committed revision 6212: | 16:01 |
povbot | /svn/commits: Evolution script - restore all manager users (permissions, not passwords). | 16:01 |
*** pcardune has joined #schooltool | 16:03 | |
pcardune | srichter: ayt? | 16:05 |
srichter | pcardune: yeah, but for long ;-) | 16:05 |
pcardune | for long? or not for long? | 16:05 |
srichter | pcardune: yeah, but not for long ;-) | 16:06 |
pcardune | We have an impenetrable infinite recursion bug which I can't figure out. I can get it to happen through a python prompt, but only through the web interface | 16:06 |
pcardune | I'm going to set up an instance for you | 16:06 |
pcardune | with the bug in place | 16:07 |
srichter | ok | 16:07 |
pcardune | and I would love it if you could take a look at it at some point | 16:07 |
srichter | sure | 16:07 |
pcardune | (doesn't have to be right now of course) | 16:07 |
pcardune | ok, thanks | 16:07 |
srichter | even better would be to tell me how I can reproduce it on my local machine | 16:07 |
*** gintas has quit IRC | 16:08 | |
pcardune | Ok, it is kind of complicated, so I'll try and write it down somewhere | 16:08 |
srichter | cool | 16:08 |
povbot | /svn/commits: * faassen committed revision 6213: | 16:15 |
povbot | /svn/commits: Added some more documentation. | 16:15 |
*** pcardune_ has joined #schooltool | 16:16 | |
ignas | srichter: maybe you know some easy way of adding an zmi "action" that would be visible when looking at person while at the same time it's permissions would be determined based on person.preferences object ? | 16:16 |
mgedmin | a custom menu item perhaps? | 16:17 |
srichter | I agree with MArius | 16:18 |
srichter | in another project I actually started to not use menus at all anymore | 16:19 |
srichter | we just use viewlets, like I did for some parts of ST | 16:19 |
srichter | ok, I am out of here; time to go teaching | 16:19 |
*** pcardune has quit IRC | 16:29 | |
pcardune_ | does anyone know what the deal is with the dashboard package? Is it staying around? I don't see it attached anywhere in the UI | 16:34 |
*** Aiste_ has joined #schooltool | 16:40 | |
*** Aiste has quit IRC | 16:42 | |
pcardune_ | ignas: do you know if the dashboard is sticking around? and is the original Person index.html available anywhere? | 16:51 |
ignas | no don't really know | 16:51 |
ignas | there was a story for that in some contract but it got postponed i think | 16:51 |
pcardune_ | Maybe I should ask th1a | 16:52 |
ignas | probably yes | 16:52 |
povbot | /svn/commits: * ignas committed revision 6214: | 16:53 |
povbot | /svn/commits: Fix a failing unit test. | 16:53 |
pcardune_ | th1a: ayt? | 17:18 |
*** ignas has quit IRC | 17:39 | |
faassen | pcardune_: concerning the Person index.html, I removed it as it was not necessary anymore. | 17:42 |
faassen | pcardune_: of course your use case is valid, it's just that we keep going between "Person should be usable independently and all customizations should be on the outside" and "we can't really test that at this stage and we need to get features done" positions. | 17:43 |
faassen | if I see stuff like this.. | 17:43 |
faassen | ComponentLookupError: (<persistent broken schooltool.timetable.term.TermContainer instance '\x00\x00\x00\x00\x00\x00\x00\x05'>, <InterfaceClass schooltool.securitypolicy.interfaces.ICrowd>, 'schooltool.view') | 17:43 |
faassen | after an upgrade. | 17:44 |
faassen | then that's not good, right? :) | 17:44 |
pcardune_ | faassen: that doesn't look good... | 17:50 |
*** pcardune_ is now known as pcardune | 17:50 | |
pcardune | faassen: I had registered some viewlets that were used on that Person page template, and i'm wondering if I should move them elsewhere? | 17:51 |
pcardune | where do you think stuff like that should Go | 17:51 |
mgedmin | persistent broken -- the class moved, and no one added a BBB link? | 17:52 |
faassen | pcardune: some of those viewlets moved to the .. | 18:00 |
faassen | mgedmin: I've no idea what this is all about. :) | 18:00 |
faassen | pcardune: the schooldata part of the demographics screens | 18:00 |
faassen | pcardune: but it was admittedly difficult to find a place for them. I tried to give it all a place somewhere, but it's quite likely things are missing. | 18:01 |
mgedmin | faassen: the 'schooltool.timetable.term' module does not have a TermContainer class, but Persistent objects stored in the ZODB want to import that module, and instantiate TermContainers | 18:01 |
faassen | pcardune: if you have suggestions on how it should go.. | 18:01 |
faassen | mgedmin: okay, this is all not good. :) | 18:01 |
faassen | mgedmin: it seems I'm the guy actually ending up testing the upgrade. :) | 18:01 |
faassen | mgedmin: inadventantly, I only want to get the demographics stuff working. :) | 18:01 |
faassen | pcardune: if you have suggestions, please write them up in an email to schooltool-dev and I'll see what I can do. | 18:02 |
pcardune | faassen: Well, I think I'll wait until we have some sort of scheme for a UI refactor... that is what it really depends on | 18:06 |
faassen | UI refactoring? :) | 18:07 |
faassen | the changes to the way persons are displayed already led to so much difficulty changing the tests, we'd need a good strategy there definitely. | 18:08 |
*** th1a has quit IRC | 18:24 | |
*** th1a_desk has joined #schooltool | 18:24 | |
*** Aiste_ is now known as Aiste | 18:45 | |
povbot | /svn/commits: * vidas committed revision 6215: | 18:59 |
povbot | /svn/commits: Fix broken unit test. | 18:59 |
*** th1a_desk is now known as th1a | 19:01 | |
povbot | /svn/commits: * vidas committed revision 6216: | 19:25 |
povbot | /svn/commits: Added new person preferences option to make calendar public. | 19:25 |
pcardune | faassen: do you know what a "crowd" is? | 19:43 |
faassen | pcardune: not yet, it's a security thing. | 19:59 |
pcardune | It looks pretty cool | 20:04 |
*** thisfred has quit IRC | 20:10 | |
*** faassen has quit IRC | 20:26 | |
pcardune | mgedmin: could you explain to me something about relationships? | 21:20 |
mgedmin | ask away | 21:20 |
pcardune | sections have a members=relationshipProperty(URIMembership, URIGroup, URIMember)... | 21:21 |
pcardune | mgedmin: when i try to do this with another content component, it says "InvalidRelationship: Groups must provide IGroup." ... but section doesn't provide IGroup? | 21:22 |
mgedmin | class ISection(IGroup): | 21:22 |
pcardune | oh... | 21:23 |
pcardune | i thought I had looked at that already | 21:23 |
pcardune | thanks | 21:24 |
mgedmin | np | 21:25 |
*** mgedmin has quit IRC | 22:37 | |
*** tristil has joined #schooltool | 23:01 | |
*** jinty has joined #schooltool | 23:03 | |
tristil | I get a mysterious ImportError on startup with zope 3.3 beta 1 and most recent svn, relating to the new securitypolicy code. http://paste.plone.org/4610 | 23:06 |
povbot | /svn/commits: * pcardune committed revision 6217: | 23:32 |
povbot | /svn/commits: Added IBaseGroup to distinguish from IGroup. IBaseGroup is only functionality that is used in other components (cando), while IGroup is for the actual Group content component. | 23:32 |
pcardune | tristil: did you perform a make update? | 23:34 |
tristil | pcardune, it's just the schooltool directory from /src in a zope 3.3 instance. I know that's not a support issue, but the error is completely opaque to me, since it seems to be contradicting what's actually the case, and I have no idea how to debug it. | 23:37 |
pcardune | It might have to do with zope package includes | 23:39 |
tristil | Drives me crazy :) | 23:39 |
jinty | th1a: ayt? it's a difficult today, mind if we chat next week about the new servr? | 23:39 |
pcardune | you need to make sure there is a slug for the securitypolicy package in the right place | 23:39 |
tristil | pcardune, I included the site.zcml at the end of the traceback. | 23:40 |
pcardune | I think "make update" will handle all that | 23:40 |
pcardune | tristil: hmmm, I'm not really sure where the problem is | 23:41 |
th1a | jinty: Oh, I'm here. | 23:49 |
th1a | That's fine. | 23:49 |
*** alga has quit IRC | 23:55 | |
th1a | pcardune: I need to see if my Skype actually works on my new laptop. | 23:55 |
th1a | Can I try calling you? | 23:55 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!