| *** ignas has joined #schooltool | 00:12 | |
| bskahan | srichter: with a new checkout of your branch, make seems to fail on the svn checkout of zope | 02:09 |
|---|---|---|
| bskahan | % make test +tor/schooltool@pigpen | 02:09 |
| bskahan | svn co svn+ssh://svn.zope.org/repos/main/Zope3/branches/testbrowser-integration/src/zope/testbrowser Zope3/src/zope/testbrowser | 02:09 |
| bskahan | Permission denied (publickey,keyboard-interactive). | 02:09 |
| bskahan | svn: Connection closed unexpectedly | 02:09 |
| *** bskahan has quit IRC | 03:30 | |
| *** jinty has quit IRC | 03:55 | |
| *** th1a has quit IRC | 04:05 | |
| *** povbot has joined #schooltool | 19:52 | |
| povbot | /svn/commits: * ignas committed revision 4935: | 19:57 |
| povbot | /svn/commits: Added caching to dayEvents function in the CalendarViewBase. Added a missing unit test. Removed cpu hogging tal:define from the inner loop in the daily template. | 19:57 |
| ignas | th1a, ping | 19:57 |
| th1a | Hi ignas | 20:00 |
| povbot | /svn/commits: * ignas committed revision 4936: | 20:07 |
| povbot | /svn/commits: Change the name of the calendar cache attribute in CalendarViewBase to make unit tests look better. | 20:07 |
| *** gintas has joined #schooltool | 20:07 | |
| ignas | th1a, an issue - navigation protlet in calendar views is hogging quite a lot of resources at the moment, most probably we will optimize it to be as fast as possible | 20:13 |
| th1a | Which part of the portlet? | 20:13 |
| ignas | though - the code not run will always be faster :D | 20:13 |
| ignas | the 3 months | 20:13 |
| ignas | with busy days | 20:13 |
| th1a | Hm. Perhaps we should just shitcan that feature. | 20:14 |
| ignas | the bottle neck is - showing which days are busy which are not | 20:14 |
| th1a | What do you guys think? | 20:15 |
| mgedmin | ignas, can you quantify the cost? | 20:15 |
| mgedmin | 50% rendering time? 30 milliseconds? | 20:15 |
| ignas | at the moment - more than 50% | 20:16 |
| ignas | after yearly view optimizations might get reduced to 20-30 maybe 50 :/ | 20:16 |
| ignas | can't predict reliably | 20:16 |
| th1a | Is that something that could be cached? | 20:17 |
| ignas | well, everything can be cached ... | 20:18 |
| ignas | yet that might take more time ... | 20:19 |
| ignas | depends on the yearly view code | 20:19 |
| ignas | actually | 20:19 |
| th1a | How does it depend on the yearly view code? | 20:20 |
| th1a | Are we keeping the yearly view? | 20:20 |
| ignas | yes | 20:22 |
| ignas | yearly view is similar to the protlet - they both need only info whether a day is busy or not | 20:22 |
| ignas | so after optimizing the yearly view to generate such a mask (busy,busy, free) | 20:23 |
| ignas | we can apply the same methof (even the same code) | 20:23 |
| ignas | to the protlet | 20:23 |
| th1a | OK. | 20:24 |
| th1a | Right now we have the current month and the next two? | 20:24 |
| ignas | i think previous, current, next | 20:25 |
| th1a | Definitely cut the previous month. | 20:25 |
| th1a | And do some work on optimizing the portlet. | 20:26 |
| th1a | If it is still slowing down the page too much, we'll retract the feature, at least for now. | 20:26 |
| th1a | Does that sound reasonable? | 20:27 |
| mgedmin | I think that's what ignas wanted to find out | 20:27 |
| mgedmin | whether removing that feature is acceptable | 20:27 |
| th1a | :-) | 20:27 |
| mgedmin | if we just disable the free/busy day calculation, that should give us 99% of the speedup we'd get by removing the calendar portlet altogether | 20:27 |
| th1a | Yeah, I'd say take a pass at optimizing the portlet, | 20:28 |
| mgedmin | we can also calculate the time cost of the free/busy after we've finished optimizing the yearly view -- which solves the same problem | 20:28 |
| th1a | and if it is going to take a long time to get a significant speedup, keep the calendar but drop the free/busy feature. | 20:28 |
| mgedmin | ok | 20:28 |
| mgedmin | thanks | 20:28 |
| *** gintas has quit IRC | 20:56 | |
| *** jinty has left #schooltool | 22:12 | |
| *** jinty has quit IRC | 22:12 | |
| *** mgedmin has quit IRC | 22:33 | |
| *** bskahan has quit IRC | 22:56 | |
| *** ignas has quit IRC | 23:01 | |
| *** dasmm has quit IRC | 23:08 | |
| povbot | /svn/commits: * alga committed revision 4937: | 23:32 |
| povbot | /svn/commits: Optimized weekly and monthly recurrence rules to fast-forward to the interesting time period instead of expanding all recurrences from the very start. | 23:32 |
| *** tvon has quit IRC | 23:38 | |
| *** tvon has joined #schooltool | 23:43 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!