IRC log of #schooltool for Thursday, 2004-12-16

« Wednesday, 2004-12-15 Index Friday, 2004-12-17 »
<--Aiste (~aiste@adsl-213-190-44-43.takas.lt) has left #schooltool (":wq")00:25
-->Aiste (~aiste@adsl-213-190-44-43.takas.lt) has joined #schooltool00:25
-->tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool00:32
**** ENDING LOGGING AT Thu Dec 16 08:43:31 2004
**** BEGIN LOGGING AT Thu Dec 16 08:44:12 2004
-->You are now talking on #schooltool08:44
---Topic for #schooltool is http://schooltool.org08:44
---Topic for #schooltool set by Aiste at Mon Oct 18 11:47:26 200408:44
-->jinty (~jinty@213.151.107.243) has joined #schooltool10:14
<--jinty has quit (Client Quit)10:18
-->jinty (~jinty@213.151.107.243) has joined #schooltool10:18
<--jinty has quit (Client Quit)10:18
-->jinty (~jinty@213.151.107.243) has joined #schooltool10:19
<--bska|mobile has quit (Read error: 110 (Connection timed out))11:12
-->SteveA (~steve@213.151.107.243) has joined #schooltool11:35
<--tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has left #schooltool ("Leaving")13:07
<--SteveA has quit (Read error: 110 (Connection timed out))13:21
-->SteveA (~steve@213.151.107.243) has joined #schooltool14:00
-->tvon|x31 (~tvon@h-68-166-70-93.mclnva23.dynamic.covad.net) has joined #schooltool15:26
-->kpk9 (~kpk@p5089217A.dip0.t-ipconnect.de) has joined #schooltool16:31
-->kpk12 (~kpk@p50892066.dip0.t-ipconnect.de) has joined #schooltool16:38
-->kpk14 (~kpk@p508921FC.dip0.t-ipconnect.de) has joined #schooltool16:38
-->kpk15 (~kpk@p50890B24.dip0.t-ipconnect.de) has joined #schooltool16:40
-->kpk16 (~kpk@p50891D64.dip0.t-ipconnect.de) has joined #schooltool16:42
<--kpk14 has quit (Read error: 60 (Operation timed out))16:48
-->bska|mobile (~bskahan@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool16:48
<--kpk9 has quit (Read error: 110 (Connection timed out))16:53
<--kpk16 has quit (Read error: 60 (Operation timed out))16:54
<--kpk12 has quit (Read error: 110 (Connection timed out))16:54
<--kpk15 has quit (Read error: 110 (Connection timed out))16:59
tvon|x31mgedmin: Is there any reason why request/authenticated_user would turn up as a string in some of the tests?17:47
tvon|x31meaning, is that an error in the way the tests or something that should be accounted for in code?17:47
mgedminhuh?17:48
mgedminit might be that some tests assign an arbitrary value (one that is not None) to request.authenticated user17:49
mgedminwhen the code in question just does "if request.authenticated_user is None" type check17:49
tvon|x31I'm using request/authenticated_user/__name__ in the schoolbell-ui branch, however it fails a few tests due to request/authenticated_user coming up as a string instead of a Person17:49
mgedminif that breaks with your new page macros or something17:49
mgedminfeel free to fix the tests17:49
tvon|x31alright17:49
mgedminthe simplest way would be to use a UserStub or PersonStub and just replace17:49
mgedminrequest.authenticated_user = 'foo'17:49
mgedminwith17:49
mgedminrequest.authenticated_user = UserStub('foo')17:50
mgedminwith17:50
tvon|x31I didnt want to start "fixing" things that were correct 17:50
tvon|x31alright17:50
mgedminthey were correct17:50
mgedminbut now assumptions changed17:50
mgedminor, rather, new assumptions were added17:50
mgedminor maybe not17:50
mgedmindidn't we show the name of the authenticated user in our page macros?17:51
mgedminyes, we did:17:52
tvon|x31I think it always pulls it from context in the existing code17:52
mgedmin  request/authenticated_user/title17:52
tvon|x31ah17:52
mgedminin macros.pt17:52
mgedmininside tal:condition="request/authenticated_user"17:52
mgedminI am surprised17:52
tvon|x31peculiar, I'm not sure why mine fails and that passes17:54
tvon|x31I have it wrapped in the conditional as well17:54
tvon|x31well, its not the conditional that confuses me17:54
mgedminwhich test is it?17:55
tvon|x314 of em, test_app.TestAppView.test_render_already_logged_in, test_browser.TestView.test_unauthorized_forbidden, test_model.TestGroupView.test, and test_model.TestPhotoView.test_nophoto17:57
tvon|x31all in browser17:57
*mgedmin goes to look17:57
tvon|x31all with 'string indicies must be integers', except TestGroupView which kicks an attribute error on __name__17:57
mgedminheh, authenticated_user='not None'17:57
tvon|x31heh17:58
tvon|x31I dont get why r/auth/title wold work in the existing code though, it's in the main macro17:58
mgedmind'oh!17:59
mgedminstrings have a title method17:59
mgedminthat's why it does not fail17:59
tvon|x31ahh17:59
mgedminthe test itself is buggy17:59
*mgedmin slaps himself on the forehead17:59
tvon|x31heh17:59
<--bska|mobile has quit (Read error: 110 (Connection timed out))18:01
-->bska|mobile (~bskahan@66.93.119.120) has joined #schooltool18:16
---Disconnected ().19:10
**** ENDING LOGGING AT Thu Dec 16 19:10:18 2004
**** BEGIN LOGGING AT Thu Dec 16 19:10:39 2004
-->You are now talking on #schooltool19:10
---Topic for #schooltool is http://schooltool.org19:10
---Topic for #schooltool set by Aiste at Mon Oct 18 11:47:26 200419:10
<--tvon|x31 (~tvon@h-68-166-70-93.mclnva23.dynamic.covad.net) has left #schooltool ("Leaving")19:33
-->bskahan_ (~bskahan@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool19:42
<--bska|mobile has quit (Read error: 60 (Operation timed out))19:42
-->tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool19:50
<--jinty has quit ("Leaving")19:54
<--hazmat has quit ("Leaving")20:35
-->freakazoid (~seanl@pat100.wirelesssecuritycorp.com) has joined #schooltool21:16
**** ENDING LOGGING AT Thu Dec 16 21:26:27 2004
« Wednesday, 2004-12-15 Index Friday, 2004-12-17 »

Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!