| <--Aiste (~aiste@adsl-213-190-44-43.takas.lt) has left #schooltool (":wq") | 00:25 | |
| -->Aiste (~aiste@adsl-213-190-44-43.takas.lt) has joined #schooltool | 00:25 | |
| -->tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool | 00:32 | |
| **** ENDING LOGGING AT Thu Dec 16 08:43:31 2004 | ||
| **** BEGIN LOGGING AT Thu Dec 16 08:44:12 2004 | ||
| -->You are now talking on #schooltool | 08:44 | |
| ---Topic for #schooltool is http://schooltool.org | 08:44 | |
| ---Topic for #schooltool set by Aiste at Mon Oct 18 11:47:26 2004 | 08:44 | |
| -->jinty (~jinty@213.151.107.243) has joined #schooltool | 10:14 | |
| <--jinty has quit (Client Quit) | 10:18 | |
| -->jinty (~jinty@213.151.107.243) has joined #schooltool | 10:18 | |
| <--jinty has quit (Client Quit) | 10:18 | |
| -->jinty (~jinty@213.151.107.243) has joined #schooltool | 10:19 | |
| <--bska|mobile has quit (Read error: 110 (Connection timed out)) | 11:12 | |
| -->SteveA (~steve@213.151.107.243) has joined #schooltool | 11:35 | |
| <--tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has left #schooltool ("Leaving") | 13:07 | |
| <--SteveA has quit (Read error: 110 (Connection timed out)) | 13:21 | |
| -->SteveA (~steve@213.151.107.243) has joined #schooltool | 14:00 | |
| -->tvon|x31 (~tvon@h-68-166-70-93.mclnva23.dynamic.covad.net) has joined #schooltool | 15:26 | |
| -->kpk9 (~kpk@p5089217A.dip0.t-ipconnect.de) has joined #schooltool | 16:31 | |
| -->kpk12 (~kpk@p50892066.dip0.t-ipconnect.de) has joined #schooltool | 16:38 | |
| -->kpk14 (~kpk@p508921FC.dip0.t-ipconnect.de) has joined #schooltool | 16:38 | |
| -->kpk15 (~kpk@p50890B24.dip0.t-ipconnect.de) has joined #schooltool | 16:40 | |
| -->kpk16 (~kpk@p50891D64.dip0.t-ipconnect.de) has joined #schooltool | 16:42 | |
| <--kpk14 has quit (Read error: 60 (Operation timed out)) | 16:48 | |
| -->bska|mobile (~bskahan@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool | 16:48 | |
| <--kpk9 has quit (Read error: 110 (Connection timed out)) | 16:53 | |
| <--kpk16 has quit (Read error: 60 (Operation timed out)) | 16:54 | |
| <--kpk12 has quit (Read error: 110 (Connection timed out)) | 16:54 | |
| <--kpk15 has quit (Read error: 110 (Connection timed out)) | 16:59 | |
| tvon|x31 | mgedmin: Is there any reason why request/authenticated_user would turn up as a string in some of the tests? | 17:47 |
|---|---|---|
| tvon|x31 | meaning, is that an error in the way the tests or something that should be accounted for in code? | 17:47 |
| mgedmin | huh? | 17:48 |
| mgedmin | it might be that some tests assign an arbitrary value (one that is not None) to request.authenticated user | 17:49 |
| mgedmin | when the code in question just does "if request.authenticated_user is None" type check | 17:49 |
| tvon|x31 | I'm using request/authenticated_user/__name__ in the schoolbell-ui branch, however it fails a few tests due to request/authenticated_user coming up as a string instead of a Person | 17:49 |
| mgedmin | if that breaks with your new page macros or something | 17:49 |
| mgedmin | feel free to fix the tests | 17:49 |
| tvon|x31 | alright | 17:49 |
| mgedmin | the simplest way would be to use a UserStub or PersonStub and just replace | 17:49 |
| mgedmin | request.authenticated_user = 'foo' | 17:49 |
| mgedmin | with | 17:49 |
| mgedmin | request.authenticated_user = UserStub('foo') | 17:50 |
| mgedmin | with | 17:50 |
| tvon|x31 | I didnt want to start "fixing" things that were correct | 17:50 |
| tvon|x31 | alright | 17:50 |
| mgedmin | they were correct | 17:50 |
| mgedmin | but now assumptions changed | 17:50 |
| mgedmin | or, rather, new assumptions were added | 17:50 |
| mgedmin | or maybe not | 17:50 |
| mgedmin | didn't we show the name of the authenticated user in our page macros? | 17:51 |
| mgedmin | yes, we did: | 17:52 |
| tvon|x31 | I think it always pulls it from context in the existing code | 17:52 |
| mgedmin | request/authenticated_user/title | 17:52 |
| tvon|x31 | ah | 17:52 |
| mgedmin | in macros.pt | 17:52 |
| mgedmin | inside tal:condition="request/authenticated_user" | 17:52 |
| mgedmin | I am surprised | 17:52 |
| tvon|x31 | peculiar, I'm not sure why mine fails and that passes | 17:54 |
| tvon|x31 | I have it wrapped in the conditional as well | 17:54 |
| tvon|x31 | well, its not the conditional that confuses me | 17:54 |
| mgedmin | which test is it? | 17:55 |
| tvon|x31 | 4 of em, test_app.TestAppView.test_render_already_logged_in, test_browser.TestView.test_unauthorized_forbidden, test_model.TestGroupView.test, and test_model.TestPhotoView.test_nophoto | 17:57 |
| tvon|x31 | all in browser | 17:57 |
| *mgedmin goes to look | 17:57 | |
| tvon|x31 | all with 'string indicies must be integers', except TestGroupView which kicks an attribute error on __name__ | 17:57 |
| mgedmin | heh, authenticated_user='not None' | 17:57 |
| tvon|x31 | heh | 17:58 |
| tvon|x31 | I dont get why r/auth/title wold work in the existing code though, it's in the main macro | 17:58 |
| mgedmin | d'oh! | 17:59 |
| mgedmin | strings have a title method | 17:59 |
| mgedmin | that's why it does not fail | 17:59 |
| tvon|x31 | ahh | 17:59 |
| mgedmin | the test itself is buggy | 17:59 |
| *mgedmin slaps himself on the forehead | 17:59 | |
| tvon|x31 | heh | 17:59 |
| <--bska|mobile has quit (Read error: 110 (Connection timed out)) | 18:01 | |
| -->bska|mobile (~bskahan@66.93.119.120) has joined #schooltool | 18:16 | |
| ---Disconnected (). | 19:10 | |
| **** ENDING LOGGING AT Thu Dec 16 19:10:18 2004 | ||
| **** BEGIN LOGGING AT Thu Dec 16 19:10:39 2004 | ||
| -->You are now talking on #schooltool | 19:10 | |
| ---Topic for #schooltool is http://schooltool.org | 19:10 | |
| ---Topic for #schooltool set by Aiste at Mon Oct 18 11:47:26 2004 | 19:10 | |
| <--tvon|x31 (~tvon@h-68-166-70-93.mclnva23.dynamic.covad.net) has left #schooltool ("Leaving") | 19:33 | |
| -->bskahan_ (~bskahan@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool | 19:42 | |
| <--bska|mobile has quit (Read error: 60 (Operation timed out)) | 19:42 | |
| -->tvon|x31 (tvon@dsl093-119-225.blt1.dsl.speakeasy.net) has joined #schooltool | 19:50 | |
| <--jinty has quit ("Leaving") | 19:54 | |
| <--hazmat has quit ("Leaving") | 20:35 | |
| -->freakazoid (~seanl@pat100.wirelesssecuritycorp.com) has joined #schooltool | 21:16 | |
| **** ENDING LOGGING AT Thu Dec 16 21:26:27 2004 | ||
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!