IRC log of #schooltool for Wednesday, 2012-03-07

*** alga has quit IRC02:24
*** replaceafill has quit IRC02:44
*** replaceafill has joined #schooltool02:57
*** replaceafill has joined #schooltool02:57
*** menesis has quit IRC04:05
*** replaceafill has quit IRC04:36
*** yvl has joined #schooltool09:33
*** menesis has joined #schooltool11:42
*** ignas has joined #schooltool14:19
*** menesis has quit IRC14:38
*** menesis has joined #schooltool15:19
*** replaceafill has joined #schooltool16:10
*** menesis has quit IRC16:11
*** menesis has joined #schooltool16:16
*** th1a has joined #schooltool16:21
th1ahi replaceafill, aelkner, menesis, yvl.16:31
replaceafillgood morning/afternoon16:31
menesisyvl will be late 20 mins16:32
th1aThanks menesis.16:33
th1aWould you like to start, replaceafill?16:34
th1aHow's your electricity/connectivity?16:35
replaceafilli've been working on ajaxing the gradebook16:35
replaceafillusing yvl's table model from the /persons and relationships views16:35
replaceafillth1a, electricity ok, connectivity sucks16:35
replaceafilli'm seriously thinking about switching ISP16:36
replaceafilli cannot do sh** in the vps using ssh during the afternoons16:37
replaceafilli've copied most of the functionality to create the main content part in the gradebook16:37
replaceafilltertiary nav + grades part + submit button16:37
replaceafillusing the new viewlets approach16:37
th1aSo the grid is being created in the browser?16:38
replaceafillbut then i started to realize that the selectors should also use the same logic16:38
replaceafillfor year, term, and section16:38
replaceafillso when you change one of them only the grid is reloaded16:39
replaceafillnow, i'm working on the activity menu links16:39
replaceafillsome of them also reload the grid16:39
replaceafilllike Sort by16:39
replaceafillMove left and right16:39
replaceafilland probably the Show/Hide total columns16:40
replaceafilli think i got it, it's just a matter of finishing it16:40
th1aDoes it seem faster?  I guess we should be benchmarking this...16:40
replaceafillwell, yes, since i don't have the full page reload, it *seems* faster16:41
replaceafilli hope to have it working tomorrow or on friday to show you16:41
th1aHave you tried profiling in Chrome or Firefox?16:41
replaceafillnot really16:41
replaceafilli just have yslow in my firefox but i dont know if thats the right tool or how to use it :)16:42
th1aYou could try it in Chrome.16:42
replaceafillah ok16:42
replaceafilli should use Chrome more :)16:43
replaceafillanyway, another thing i wanted to mention16:43
replaceafillis the selenium test runner16:43
replaceafilli tried it on monday16:43
replaceafilland now it works with the datepicker, thanks to some helpers yvl set16:44
replaceafillso our tests that create years and terms finally work16:44
replaceafilli think we should go back to our old way of working when16:44
replaceafillwe always created a test for new functionality16:44
replaceafilland i'd like to write tests for this ajax stuff16:45
replaceafilli think that's why we picked selenium right?16:45
th1aWrite tests.16:45
replaceafillgreat, will do then16:46
th1aI feel like we're starting to suffer from a lack of tests.16:46
replaceafilland i have a question for yvl, but i'll wait for him :)16:46
replaceafillwell we wrote the whole flourish part without functional tests16:46
replaceafill(i think)16:46
replaceafilland we wrote a lot of new stuff back then16:47
replaceafillth1a, so i should be done with this task this week16:47
replaceafilland start the cando gradebook next week16:47
replaceafill(that's my question for yvl)16:47
th1aSounds good.16:47
replaceafillthat's it from me16:48
th1aThanks replaceafill.16:48
aelkneri finished the intervention email task16:48
th1aLet's take a last look at it...16:49
aelknerthat included various cleanup tasks we discussed on monday16:49
aelkneras teacher00116:49
aelkneri had to add the same notification modal to section interventions as well16:50
aelkneralso, i made the modal use the modal: True flag to make the background fade out16:51
aelknerfiguring that it was important for the user to see the notification16:51
aelknerthe gradebook modal doesn't have this faded background, but perhaps that's ok16:51
th1aIt is fine, because you might want to see that while you're using the gradebook dialog.16:52
th1aI don't get this message: "The server ( rejected the following recipient addresses: invalid"16:52
aelknerand yvl said that the journal has a legend that works the same way, too16:52
th1ais that supposed to be telling me which ones are invalid?16:53
th1aSo... which?16:53
aelknerinvalid is the address that i set the contact to have16:53
aelknerit is not a valid email address16:53
th1aThe invalid email address is "invalid"16:53
th1aI guess I should file a bug about accepting invalid email addresses in the first place.16:54
replaceafillwe need an email field with a regexp validator16:54
aelknerwell, how would the person edit views check for email address validity other than format?16:55
aelkneri mean, the address could have the @ and the .com stuff, but still be invalid16:55
th1aIn what sense?16:55
aelknera non-existent account16:55
yvlhi guys16:56
yvlsorry I'm late today16:56
aelknerbut true, the @ and . checks could be made16:56
replaceafillhey yvl16:56
th1aYou've managed to completely confuse this issue through your choice of example aelkner.16:57
th1aSo this is not telling me the email is "invalid," but that it doesn't exist.16:58
aelkneri disagree, i didn't confuse anything, the email utility works like it works16:59
aelknerif you didn't like the way it worked in the past, why didn't you say anything then16:59
th1aI'm just saying using "invalid" as your example text completely threw me off the trail.16:59
th1aIt is like if you used "Syntax Error" or "Core Dump" as the invalid email address.16:59
aelknerwell, heck, it's just an example17:00
aelkneryou can play around with it all you want17:00
th1aOK, so getting back to the point.17:00
th1aDoes this dialog only come up if there is an error?17:01
th1aThat is, can the title be more specific than "notification."17:01
aelknerwhat would you suggest?17:02
th1aOK, I see it does.17:02
aelknerwhy don't you play around with it and file any bugs if you find them17:02
th1aYou know, it is fine.  can you just make it "The email could not be delivered to all recipients." and we'll just move on.17:03
aelkneroops, you did say recipients on monday, i now remember, after yvl suggested people17:04
aelkneri could change that now17:04
aelkneranyway, i submitted a comment for the demo import bug, did you see?17:05
th1aI'm not sure what's going on with that.17:06
aelknerwe can leave that or mark it as invalid, your call17:06
th1aOr... we could ask another question.17:07
aelkneryou have one in mind?17:07
th1aDid you happen to try deleting the other worksheets other than people?17:07
th1aYou're going to be doing a lot of that very soon for this CanDo import stuff anyhow.17:08
aelknerno, i didn't figure that would make a difference, but i could try that right now17:08
th1aTry that to make sure.17:08
th1aSince the whole CanDo import thread is going to be about making sure importing one sheet at a time works.17:08
aelknerbtw, we seem to have Persons and Contact Persons as sheets17:10
aelknerthey both have demos, and the export doesn't seem to add the custom demo column17:11
th1aI guess that could cause some confusion.17:11
th1aWell, contacts have the contact information.17:11
th1aThat doesn't change.17:11
aelkneroops, sorry, i confused the phone/email stuff with the ID, ethnicity stuff17:12
aelknernot the same thing17:12
aelknerso that's a red herring17:12
th1aExcept insofar as it might be the source of the users' problem.17:13
aelknerperhaps, yes17:14
aelkneri just tested getting rid of all the other sheets, still works fine17:14
th1aOK.  I'll try to come up with a follow-up.17:15
th1aHad you started section locations?17:15
aelkneryeah, so i started back on that17:15
aelknerit would be nice to be able to push through that before working in something else17:16
aelkneryvl, can we meet tomorrow morning, standard meeting time?17:17
yvlumm, yes17:17
th1aAbout section locations?17:17
aelkneryeah, i'll have questions about the new ajax tables17:18
aelknerfor now, i've been absorbing the new js files17:18
aelkneryvl, have you basically moved on from that stuff, or are there any loose ends?17:18
* yvl done with that for now17:19
aelkneranyway, that's it for me17:19
th1aThanks aelkner.17:20
yvlI'm doing the skill document model17:21
yvlit will take a while ;)17:21
th1aDo you need your memory jogged?17:21
yvlI'll be fine :)17:21
yvlreally :)17:22
yvlwell, that's it from me17:22
replaceafillyvl, can i ask you a question?17:23
th1aSo I guess there's nothing in the pipeline for menesis to wait for.17:23
replaceafillin my sprint notes, for the cando flourishing task17:23
replaceafilloops, sorry, i can wait for menesis to finish17:23
menesistests are failing.17:24
th1aLots of red.17:25
menesisth1a, aelkner: so you are done with intervention/email changes17:25
replaceafilli didnt undestand why the scriptlocal directive in flourish is being used in the old skin17:25
th1aThere's one word to change.17:25
yvlmy fault, replaceafill17:25
aelknermenesis, yes, i just need to make the one minor message text change right now17:26
replaceafillyvl, i mean, i dont understand why the old skin is trying to access main.pt17:26
aelknermerging now...17:26
menesisaelkner: good then17:26
replaceafilli think so17:27
replaceafillor maybe i'm wrong17:27
replaceafilli tried to fix that one17:27
replaceafillbut got confused by it17:28
yvlit's not in main.pt17:28
yvlprobably filter17:28
replaceafillso i was looking at the wrong scriptlocal :D17:29
replaceafillah, it's probably a table container view17:30
aelknermenesis, merged17:30
aelkneryou see i put a lot of text in CHANGES.txt to explain the many changes17:31
replaceafillyvl, is it worth to create new helpers to print the gradebooks, like printGradebookTable for flourish?17:32
aelknersounds like a good idea17:32
yvlit's up to you17:32
yvlbut it looks like time well spent ;)17:33
replaceafillyvl, i remember your explanation about not testing the html output with selenium17:33
replaceafillbut the functionality17:33
replaceafill(or maybe i got that wrong) :)17:33
replaceafilland to me, printGradebookTable tests output17:33
yvlwell, one thing is to test if a <div> contains a <p> with a space17:34
yvland the <p> has class = "foo"17:34
yvland id ="boo"17:34
yvland it has a <a>17:34
yvland so on and so forth17:34
yvlanother thing is to extract grades visible in table17:34
replaceafillgot it17:34
replaceafilli'll probably add those helpers then17:35
yvlthanks man17:35
replaceafillyvl continuing with my cando gradebook question17:35
replaceafillyou told me that i could start writing the cando gradebook using the same model of the current gradebook, correct?17:36
replaceafillactivity -> competency17:36
replaceafilleven have options to add competencies at the beginning17:36
replaceafillin my notes:17:36
replaceafill"use the same gradebook model/options to create the new cando gradebook"17:36
yvlworksheet == project17:37
replaceafilldoes that mean that i should use the gradebook interfaces/models?17:37
replaceafillah yes17:37
yvlor worksheet == tasklist17:37
yvlfor now, yes17:37
yvlI would think...17:37
replaceafillbecause i can create new interfaces/models with better names maybe for cando17:37
replaceafillalways using the same hierarchy17:38
replaceafilli think it would be faster if i used the existing gradebook stuff though17:38
yvlthat code will likely be updated anyways17:40
yvlso I'd vote for fastest prototype17:40
replaceafillgot it17:40
replaceafillok, thanks yvl17:41
th1amenesis:  Should we get all hands on deck for fixing tests?  Say, starting Monday?17:41
menesisth1a: no17:42
* yvl can fix some today17:42
yvl(and I actually intend to ;) )17:42
menesisthere are only a few failures. one is expected (search corner cases not handled)17:42
menesisanother with scriptlocal I don't know17:43
menesisand journal does not print the table because some css classes changed17:43
yvlI refactored and forgot the old skin.  Will reintroduce old code without scriptlocal17:43
th1aAnything else menesis?17:46
th1aOK.  Thanks guys.17:46
th1aI'll get the invoices out today.17:46
th1aWorking on the competency completion report.17:47
th1aHave a great week and weekend!17:47
* th1a drops the bag of gravel.17:47
replaceafillthanks everybody17:49
* replaceafill goes to get breakfast17:49
aelknergreat week everyone17:49
yvlgood luck guys!17:50
*** yvl has quit IRC18:24
*** yvl has joined #schooltool18:29
*** ignas has quit IRC18:41
*** menesis has quit IRC19:14
*** yvl has quit IRC19:54
*** menesis has joined #schooltool21:03
*** alga has joined #schooltool22:13

Generated by 2.15.1 by Marius Gedminas - find it at!