IRC log of #schooltool for Monday, 2012-01-16

*** ignas has joined #schooltool02:04
*** menesis has quit IRC02:27
*** ignas has quit IRC02:38
*** aks has joined #schooltool05:19
*** aks has quit IRC09:11
*** alga_ has joined #schooltool12:06
*** alga has quit IRC12:07
*** 13WAAAAMD has joined #schooltool12:08
*** 13WAAAAMD is now known as aks12:47
*** aks has joined #schooltool12:47
*** menesis has joined #schooltool12:52
*** ignas has joined #schooltool13:10
*** aks has quit IRC13:28
*** menesis has quit IRC13:44
*** alga_ has quit IRC13:45
*** alga has joined #schooltool13:49
*** alga has quit IRC13:55
*** alga has joined #schooltool15:33
*** th1a has joined #schooltool16:14
*** menesis has joined #schooltool16:18
*** replaceafill has joined #schooltool16:19
th1ahi aelkner, replaceafill, menesis.16:32
replaceafillgood morning/afternoon16:32
th1aWould you like to start replaceafill?16:33
replaceafilllast week i fixed a couple of bugs:16:33
replaceafillwrote some instructions for Jean16:34
replaceafillseemed like they worked :)16:34
th1aYes, good.16:35
replaceafillalso fixed this:
th1aWill that cause a problem when he tries to upgrade?16:35
replaceafillth1a, i was wondering the same16:35
th1aI think it will.16:35
replaceafillmenesis, if i modify a module in a deb package, will that prevent me from upgrading?16:35
menesisreplaceafill: no. the file will be overwritten on next update16:36
menesisunless it is a config file in /etc16:36
replaceafilllike the warnings you get when you upgrade apache16:36
replaceafillwell, i hope Jean doesn't have much trouble then16:37
menesisno. if the fix is merged it will be in next release so will have the same code16:37
replaceafillok, i needed limited demographics to be available on edit for cambodia16:37
replaceafillso i fixed that16:38
replaceafillmenesis, thanks for checking and merging the integer demographics fields change16:38
replaceafilli can take that out from cambodia too16:38
th1aI added a comment to that effect.16:38
th1a(to the bug)16:38
replaceafillth1a, on the cambodia side, i finally was able to move the code to use global levels16:39
replaceafillinstead of year-by-year16:40
replaceafillnow, i just have to finish "classes"16:40
replaceafillgroups linked to sections16:40
replaceafilland create a global view /classes or something16:40
replaceafilllike what we have for everything else16:40
replaceafilland now it's easier to find stuff16:41
replaceafillyou don't have to dig in the hierarchy16:41
replaceafilli also checked this one:16:42
replaceafillit's the same problem we have with courses with non-unicode characters16:42
replaceafilland their cancel action in links16:43
replaceafillwe need to encode those urls properly16:43
replaceafilli remember yvl told me to try the IDNA encoding or something like that16:43
replaceafillwill try that later16:43
menesismaybe urls in request parameters can be avoided there..16:44
replaceafilli'll investigate16:44
replaceafillthat's it from me16:45
replaceafillbtw, aelkner16:45
replaceafillcheck the project you assigned to your bugs16:45
replaceafillit's CanDo16:45
replaceafillby default, i mean16:46
aelknerwhy is that?16:46
replaceafillwhen you hit "report a new bug button"16:46
replaceafillyou get a dropdown with the subprojects of schooltool-project16:46
replaceafillcando is the first alphabetically16:46
aelknerah, i see16:46
* replaceafill done16:47
th1aDo you think you can wrap up Cambodia by Wednesday?16:47
replaceafillth1a, yes16:47
th1aOK.  I don't want it lingering forever.16:48
replaceafillgot it, it will be done by wed16:48
th1aAnything to throw in, menesis?  I know you're working on other projects.16:48
menesisreviewed some code and bugs16:49
menesisbut haven't looked at aelkner's course worksheets branch yet16:49
aelknerwell, i can merge it anyway, and you can look at it at your convenience16:50
aelkneri just don't want to have weeks worth of work diverge from trunk anymore16:50
aelknerespecially if i need to do more work on trunk16:51
th1aAt this point if replaceafill would merge it with his work you'd be pretty safe.16:51
th1aSince yvl is on vacation.16:51
aelknermenesis, how soon will you be able to look at it?16:52
menesisaelkner: soon16:52
aelknerok, in the meantime, i can write some functional tests16:53
menesismaybe today16:53
menesisI will look next after the meeting16:53
aelknerok, thanks16:54
th1aSo where are you aelkner?16:55
aelkneri wanted to show you the empty message from the bug fx i did last week16:56
menesisaelkner: thank you for the bugs created that explain the features16:56
aelkneri'm loading the demo instance with data right now16:57
aelknermenesis, np, i will try to do more of that in the future16:57
aelknerthe thing i need to do is even if th1a just says 'fix this'16:57
aelkneri need to create a lp bug and then add a ref to it in CHANGEStxt16:57
aelknerit is the best way for us to communicate with each other16:58
aelknerth1a, as teacher001 (teacher001):16:59
aelkneri know the font is maybe too big16:59
aelknerbut it seemed to small to use the default16:59
aelkneralso, any text changes?16:59
aelknerreplaceafill, thanks for catching the conflict with the default17:00
aelkneri fixed that by applying the css class only to the elements that needed styling17:00
replaceafillsure, i'm using trunk in cambodia, so it's easy to see :)17:00
th1aJust use the default size.17:01
th1aPut the links on the sma line.17:01
aelknerso, after the : with no line break?17:02
th1aOtherwise that seems fine.17:02
replaceafillwhy not "you can also <a ...>add a new worksheet</a>"?17:03
replaceafillwithout the "using this link" part17:03
th1aI'd probably do it replaceafill's way.17:03
th1aIt is kind of a toss up.17:03
replaceafilllike we do in empty schoolyears17:03
aelknerso, 'This section contains only <a ..>Worksheets</a> that are hidden17:04
aelknerYou could also <a ...>Add</a> a new worksheet17:04
aelknerperiods included, of course17:04
aelknerth1a, what do you think?17:05
aelknerreplaceafill, empty schoolyears, how do you mean, no schoolyears or a schoolyear that is empty?17:06
th1aI think it is ok as is because it is kind of a confusing situation for the user.17:06
replaceafillaelkner, no schoolyears17:06
th1aSo being a little more pedantic than usual is not a bad idea.17:06
aelknerok th1a17:06
aelkneri'll show you in a minute the change17:06
aelknerreplaceafill, can you help me get started with flourish functional tests after the meeting?17:07
aelkneri believe you are the only one who wrote any, right?17:07
replaceafilli advise you not to write them yet17:07
th1aIf not now when?17:07
replaceafillor no, maybe you should :)17:07
replaceafillhere's the thing17:08
replaceafilllet me get the bug17:08
replaceafillto me, the runner it's too unstable17:08
aelknerok, i can wait for you to sort that out first17:09
replaceafillyou can try and report if you find the same issues17:10
th1aYes, it seems like those are somewhat isolated issues.17:10
aelkneri can avoid datepicker17:10
replaceafillhhmm how?17:10
th1aI think aelkner should get started and we'll fix some things as we go.17:10
aelkneroh, i don't know, can't i?17:10
replaceafillaelkner, i mean, you need to set up schoolyears and terms, right?17:11
aelkneris even setting up a schoolyear not possible?17:11
aelknerok, so tests can't be written just yet17:11
aelknerreplaceafill, but you'll look into this right away?17:11
replaceafillaelkner, yvl will fix this17:12
replaceafillnot me17:12
aelknerdo we know how soon he will be able to?17:12
th1aWhy can't you just enter dates into the field?17:13
replaceafilli dont17:13
replaceafillth1a, the datepicker blocks the buttons17:13
replaceafilland the test fails17:13
th1aBut it doesn't in real life?17:13
replaceafillbecause we're slow enough :)17:14
replaceafillbut selenium isn't17:14
th1aOK... this probably shouldn't be one big bug report.17:14
th1aAll right then...17:15
* replaceafill was expecting something from th1a after btw :D17:16
* aelkner too17:16
th1aThat was modifying the previous sentence.  ;-)17:16
replaceafillth1a, well, the bug report was just a reminder yvl asked me to write17:17
aelknerit's a good bug report because the problem is that big17:17
th1aIt is no big deal, but it doesn't really communicate the severity of the situation to me.17:17
replaceafillth1a, ah, got it17:17
th1aIt seems to be that it is 2/3rds very severe.17:18
aelknerSelenium test runner issues could be changed to Selenium tests don't run17:18
th1aSince we can't write any functional tests.17:18
th1aAnyhow, I told yvl to work on other equally important stuff, so it isn't a huge deal.17:18
replaceafillyvl said he would jump into this one after he finishes the relationships views17:18
th1a(as signified by "btw")  ;-)17:18
th1aI think we're fine.17:19
replaceafillbtw, i requested the khmer translation to be included in jquery core:
replaceafillso, it lands in the jquery debs someday17:20
th1aThanks replaceafill.17:21
th1aOK, so we need something for aelkner to do?17:22
aelknerthere are two things that i have on my plate17:24
aelknerok, just one17:24
aelknerdo more manual testing of report/course sheets17:24
aelknerit seems that i can't hide them at the moment, something that wasn't true just before17:24
aelkneri just was able to hide things before, so this is strange17:25
th1aOK, do that.17:25
aelknerbut besides figuring that out, i could use more bug prioritization17:25
aelknerth1a, perhaps we could go over my list after the meeting?17:26
th1aWe need to shift to transcripts soon, so we may just do that.17:27
th1aSo, have a good week gentlemen, and17:27
* th1a drops the bag of gravel.17:28
aelknerthanks guys17:28
aelknerrefresh your css with shit ctrl r17:28
aelkneri still have the 10px padding style there, is that wrong?17:29
th1aaelkner, We have defaults which you should always use by default.17:31
th1aI just made a bunch of small gradebook bugs critical for you.17:31
th1aDo those first.17:31
aelknerth1a, try cltr shift r again, i got rid of the padding so that it uses all the default styles17:33
aelknerhow does that look to you:?17:33
th1aProbably we should wrap it in a warning thing.17:34
aelknerwarning thing?17:35
aelknerreplaceafill, do you know what th1a means?17:35
replaceafillaelkner, hhmm no17:35
th1aDon't we have a red warning box style?17:35
replaceafillfor form errors17:36
aelknerreplaceafill, can you follow the link and ctrl shift r please17:36
replaceafillaelkner, ok17:36
th1aWe could use that.17:36
aelkneruse what?17:37
replaceafillaelkner, when you get an error in a form, you get the "please correct the errors below" message17:37
replaceafillat the top of the form17:37
th1aIt isn't an error in the form.17:38
th1aIt is just a question of using existing styles instead of custom ones if possible.17:38
th1aUsing any custom style at all is a last resort.17:38
aelknerreplaceafill, your styles are dependent on element containment, right?17:39
replaceafillaelkner, yes17:39
aelknerso i need to move the div back into the form17:39
aelknerand then the <span> within that, right?17:40
replaceafillor you can modify the rule17:40
replaceafillalthough i don't know how good link will look in red17:40
aelknerand i just made the form itself dependent on all_hidden :(17:41
aelknerreplaceafill, if i modify rules, there's no telling whether i'll break something that i didn't even know i broke17:42
aelknerlike what you caught late last week17:42
th1aCan you just make it style like regular content?17:42
th1aThat would be fine.17:42
aelknerlet me try putting the empty message in it's own form and divs to see what happens17:44
aelknerreplaceafill, could you look at this with me please17:46
aelknerdo i need form, div class="gradebook", span?17:46
aelknerf_gradebook.css has lots of table rules17:47
replaceafilllet me check17:47
aelknerdo i need to put a table in my gradebook div?17:47
replaceafillaelkner, those table rules are for the score system form17:47
th1aI guess the only reason I'm dragging this out is that it seems to me you should be able to style it like a regular content area pretty easily.17:48
th1aI would think it wouldn't need to be styled like a gradebook at all.17:49
aelknerreplaceafill, is it possible to not even need the form element?17:49
th1aIt isn't a form.17:50
aelkneri know, i'm just assuming that the styles are based on form elements17:50
th1aJust style it like regular content and I'll shut up.17:51
replaceafillaelkner, the warning box is used only in forms so far17:52
aelknerreplaceafill, do we have such a concept, regular content17:52
aelkneraren't most of the styles based on a set of possible element heirarchies?17:52
th1aI threw the whole damn thing off bringing up the warning box.17:52
aelknerreplaceafill, if you could point me to the style that i need, i can create the needed elements17:53
replaceafillaelkner, ok17:53
replaceafillaelkner, check a course with no leaders17:54
replaceafillThis course has no responsible parties17:54
replaceafilli think that's regular content17:54
replaceafilla regular p17:54
replaceafilli mean, <p>17:54
aelknerand <h3> including a <p>, right?17:55
aelkneran <h3>, i mean17:55
replaceafilljust a p17:55
replaceafillcontent > body > p17:55
replaceafillno h3 as container17:55
aelkneroh, the h3 is not inclouding it, i'm seeing things17:56
replaceafillaelkner, i think your <p> seems strange just because the gradebook has 0 padding17:56
aelkneri can move the div outside of the div class="schooltool.gradebook"17:57
aelknerat the very top17:57
replaceafillor you could add the 16px padding to it17:58
th1aI could have suggested that and saved a half hour.17:58
th1aBut can't we just make it not styled like a gradebook at all?17:58
aelknerth1a is trying to get us to use less custom css, and i agree17:59
aelknerout rules should work universally17:59
replaceafillok, move out from the gradebook style then17:59
aelknerreplaceafill, check out the link again:18:01
replaceafillok, im on it18:02
replaceafillyou're still using the gradebook styles: grid for page_class18:02
aelknermy <p> is now in main > content > body18:03
replaceafillthat's fine18:03
replaceafillbut you're page class is applying 0 padding18:03
replaceafilllook for the class="page grid" container18:04
replaceafilllook at how it looks after i take the "grid" class out:
aelknerdamn, that's determined at the view class level18:05
replaceafillyou can make it dynamic18:05
replaceafillif not empty: 'page grid' else 'page'18:06
aelknertrying now18:08
aelknerreplaceafill, try the demo link again18:11
aelknerit seems we've lost some padding above18:11
replaceafillit's because you need a title in the view18:11
replaceafillregular views use it18:11
aelknerthis is not a regular view18:12
aelknerthere is no title on purpose18:12
th1aThere could be a title.18:12
replaceafillthen you can't use "regular" styles, right?18:12
aelkneri don't know, if you say so18:12
aelkneris there a small fix i can make to what i have loaded on the demo"?18:13
th1aTitle "No Visible Worksheets"18:13
aelkneryou mean change the view class in the same manner as with the page_class?18:15
aelknertitle property, conditional on all_hidden?18:15
th1aI'm just saying, if the problem is there is no title, can't you add a title?18:15
aelknerreplaceafill, the gradebook already has a title, 'Enter Grades', but it doesn't render18:19
replaceafillaelkner, do you have has_header set to True?18:19
aelknerah, yes, that needs to be conditional18:21
aelknerreplaceafill, th1a, check out the demo:18:24
aelknerswitch to a different section to see the difference18:24
replaceafillthat looks more like a "regular" view ;)18:25
th1aOK, that's fine.18:25
th1aOur work is done.  ;-)18:25
aelknerok, cool, glad that's behind me18:25
aelknerthanks guys18:25
th1aHopefully you learned some useful things...18:25
replaceafillnext task is to make those dialogs :P18:25
replaceafillgood job aelkner18:26
aelknerthanks to your help regarding changing view attributes18:26
aelknermenesis, thanks for the merge!18:55
*** alga has quit IRC20:11
*** th1a has quit IRC20:18
*** menesis has quit IRC20:31
*** th1a has joined #schooltool20:44
*** ignas has quit IRC21:05
*** alga has joined #schooltool21:10
*** replaceafill has quit IRC21:31
*** menesis has joined #schooltool21:50
*** th1a has quit IRC21:52
*** th1a has joined #schooltool22:24
*** replaceafill has joined #schooltool22:24
*** th1a has quit IRC23:54

Generated by 2.15.1 by Marius Gedminas - find it at!