| *** replaceafill has quit IRC | 02:22 | |
| *** jorgevazquez87 has joined #schooltool | 03:21 | |
| jorgevazquez87 | Hi everyone! | 03:21 |
|---|---|---|
| jorgevazquez87 | Anyone here? | 03:22 |
| *** jorgevazquez87 has quit IRC | 03:24 | |
| *** aks has joined #schooltool | 05:05 | |
| *** aks has joined #schooltool | 05:05 | |
| *** replaceafill has joined #schooltool | 08:40 | |
| *** replaceafill has quit IRC | 09:37 | |
| *** menesis has joined #schooltool | 11:08 | |
| *** aks has quit IRC | 11:20 | |
| *** aks has joined #schooltool | 12:03 | |
| *** aks has joined #schooltool | 12:03 | |
| *** aks has quit IRC | 13:23 | |
| *** aelkner has quit IRC | 13:43 | |
| *** aelkner has joined #schooltool | 13:47 | |
| *** menesis has quit IRC | 13:51 | |
| *** ignas has joined #schooltool | 14:12 | |
| *** povbot has joined #schooltool | 15:09 | |
| *** th1a has joined #schooltool | 16:15 | |
| *** menesis has joined #schooltool | 16:30 | |
| th1a | hi aelkner, menesis... | 16:30 |
| aelkner | morning | 16:30 |
| th1a | Well, we don't have to worry about what we're going to do if there is a Pittsburgh v. Philly Super Bowl during the sprint. | 16:32 |
| aelkner | neither, nor | 16:33 |
| th1a | Indeed. | 16:33 |
| aelkner | though your team had the best chance this year | 16:33 |
| aelkner | i think a broken ankle is too much for any star quarterback | 16:34 |
| th1a | Well, just a high ankle sprain. | 16:34 |
| th1a | It only LOOKED like he broke it. | 16:34 |
| aelkner | looked like number 24's ankle got broken a couple times there :) | 16:35 |
| aelkner | but seriously, tebow did make some good throws | 16:35 |
| th1a | Yeah. | 16:35 |
| th1a | They challenged him to beat them with his arm and he did. | 16:36 |
| th1a | OK, on to business. | 16:36 |
| aelkner | we have the right three here | 16:36 |
| aelkner | i have a list of 5 items to discuss | 16:36 |
| th1a | OK. | 16:36 |
| aelkner | regarding the bug, https://bugs.launchpad.net/schooltool.gradebook/+bug/913055 | 16:36 |
| aelkner | first menesis took this to start | 16:37 |
| aelkner | he wrote some fail-safe code that hides any time the IWorksheet adapter | 16:37 |
| aelkner | lookup fails, would like to try to recreate bug and fix adapter instead | 16:37 |
| aelkner | haven't been able to yet, menesis, does your comment about deployment mean you could? | 16:38 |
| aelkner | comment #1, that is | 16:38 |
| th1a | menesis has not actually responded to anything yet. | 16:38 |
| aelkner | he posted coment #1 | 16:39 |
| aelkner | ending with Will fix this buf, of course | 16:39 |
| aelkner | bug | 16:39 |
| aelkner | then i noticed a bug fix in the trunk | 16:39 |
| th1a | I mean, he doesn't seem to be here now. | 16:40 |
| aelkner | http://bazaar.launchpad.net/~schooltool-owners/schooltool.gradebook/flourish/revision/417 | 16:40 |
| aelkner | ok, we can discuss for now | 16:40 |
| aelkner | 2) simply hiding Sheet1 causes problems because of bug in ensureAtLeastOneWorksheet | 16:40 |
| th1a | Did you try writing a test? | 16:40 |
| aelkner | bug didn't test right len function, written pre-hide feature | 16:40 |
| aelkner | no, test writing is another issue, not ready to tackle that yet | 16:41 |
| th1a | Well, we should at least be writing tests as we fix bugs. | 16:42 |
| aelkner | was just trying to recreate manually | 16:42 |
| th1a | I don't think we're going to be stopping for a month and writing tests for everything, but we should be writing more tests as we go. | 16:42 |
| aelkner | tests, as they are designed curretly, are super expensive to write | 16:43 |
| aelkner | first, there is the length of time to run | 16:43 |
| aelkner | that comes from always setting up data and tearing it down | 16:43 |
| aelkner | we'd be better of if we could start any tests with one function call that sets up sample_data.xls | 16:44 |
| aelkner | or something even smaller | 16:44 |
| aelkner | without taking so long to run | 16:44 |
| aelkner | over time, we have always been writing long tests that manually click around | 16:44 |
| th1a | OK, well, there is no point in talking to me about it. | 16:44 |
| aelkner | and this is very expensive in another way, developer time | 16:45 |
| *** replaceafill has joined #schooltool | 16:45 | |
| replaceafill | good morning/afternoon | 16:45 |
| th1a | ah, here's someone. | 16:45 |
| th1a | hi replaceafill. | 16:45 |
| replaceafill | sorry i'm late | 16:45 |
| th1a | You're not the only one. | 16:46 |
| replaceafill | i didn't hear the alarm for some reason :( | 16:46 |
| * replaceafill reads the logs | 16:47 | |
| th1a | We make replaceafill get up early. | 16:47 |
| replaceafill | is aelkner done with his report? | 16:48 |
| aelkner | only got started | 16:48 |
| replaceafill | ah, ok | 16:48 |
| aelkner | th1a opened up a discussion about testing, but i think that can wait | 16:48 |
| aelkner | i have lots of other issues to discuss | 16:48 |
| th1a | Go ahead aelkner. | 16:49 |
| aelkner | back to 2) | 16:49 |
| aelkner | although the original report had to due with report sheets, as menesis pointed out in the bug comment | 16:49 |
| aelkner | problems occur even if you just hide Sheet1, not report sheets involved | 16:50 |
| aelkner | i wrote ensureAtLeastOneWorksheet before we had hiding feature | 16:50 |
| aelkner | so it didn't create a new Sheet1 when the user hid Sheet1 | 16:50 |
| aelkner | first decision involves saying, if user hides Sheet1, we need to create another one, right? | 16:51 |
| aelkner | that is, if there isn't any others | 16:51 |
| th1a | Well, we could just have a "There are no worksheets, please create one." message. | 16:52 |
| th1a | That's probably better. | 16:52 |
| aelkner | when | 16:52 |
| th1a | (where "create one" is a link to create one. | 16:52 |
| aelkner | would that message show up? | 16:52 |
| th1a | I'm not sure we literally need to ensure there is a worksheet so much as ensure there is one by default. | 16:52 |
| th1a | I'm only concerned that new users have a worksheet the first time. | 16:53 |
| th1a | After that, it is probably more confusing than helpful to create a new "Sheet1" each time they hide the original. | 16:54 |
| aelkner | the scenarios are numerous, for instance, if the manager deploys a report sheet before any teacher visits a gradebook | 16:54 |
| aelkner | then no Sheet1 is created with current logic | 16:54 |
| aelkner | also, if user is in a report sheet only gradebook | 16:54 |
| aelkner | and manager hides it | 16:55 |
| aelkner | then refreshing shows a gradebook view with no tabs or activities | 16:55 |
| aelkner | in a way, this is good | 16:55 |
| th1a | Probably the whole thing should be changed so that you get a default sheet when the section is created (or whatever makes sense) and then we just display a "There are no worksheets." if it ends up there aren't any. | 16:55 |
| th1a | It is simpler. | 16:55 |
| aelkner | i don't know it it was replaceafill who made that work at one point | 16:55 |
| aelkner | but it seems self-explanatory for the user | 16:55 |
| aelkner | to see nothing, and be able to hit the Worksheets button | 16:56 |
| aelkner | they can find out that threy didn't want to hide Sheet 1, and unhide it | 16:56 |
| th1a | If there is no (unhidden) sheet, they should just be prompted to make a new one. | 16:57 |
| aelkner | the weird part about it is that the worksheet is hidden, yet the gradebook is visiable | 16:57 |
| aelkner | albiet, empty | 16:57 |
| aelkner | oh | 16:57 |
| aelkner | you're suggesting that we merely add a popup to the empty gradebook | 16:58 |
| aelkner | if the user refuses, ok, show the empty gradbook | 16:58 |
| aelkner | if they choose to, a new sheet wil be added, right? | 16:58 |
| th1a | It doesn't even need to be a popup. | 16:58 |
| th1a | Just a message with a link. | 16:58 |
| aelkner | even better | 16:59 |
| aelkner | a red message with a link, like GMail | 16:59 |
| aelkner | so, can we remove the whole idea of ensureAtLeastOneWorksheet | 16:59 |
| th1a | I'd say pretty much. | 17:00 |
| aelkner | and just have the red message for empty gradebooks | 17:00 |
| th1a | It doesn't even need to be red. | 17:00 |
| aelkner | blue maybe? | 17:00 |
| aelkner | i can start with black and we could look at it then | 17:00 |
| aelkner | your executive decision to get rid of ensureAtLeastOneWorksheet logic makes many of my issues go away | 17:01 |
| th1a | Yes. | 17:02 |
| aelkner | although i can see a lot of tests getting broken, just a warning, it will take some time | 17:02 |
| aelkner | but i like getting rid of it because of the many side-effects | 17:03 |
| th1a | Yes. | 17:03 |
| th1a | OK, next? | 17:03 |
| aelkner | the funny thing is, that the gradebook is based on a worksheet | 17:03 |
| aelkner | if the worksheet is hidden, and there are no other non-hidden, we have an empty gradebook | 17:03 |
| aelkner | though it's parent context is a worksheet | 17:04 |
| aelkner | just a bit strange conceptually | 17:04 |
| aelkner | just realized, i could render the message/link in the place of the tabs | 17:04 |
| menesis | aelkner: I don't think it is a problem with ensureAtLeastOneWorksheet. leave it. but the views need to handle better the case not thought before, that all sheets are hidden. | 17:05 |
| th1a | It would be better to put it in the content area. | 17:05 |
| aelkner | menesis, i could see that getting rid of it would make you nervous | 17:05 |
| aelkner | testing issues, release issues and all | 17:05 |
| menesis | do not display the table, only a message There are no worksheets. _Add worksheet_ | 17:06 |
| th1a | Getting rid of it is a cleaner implementation. | 17:06 |
| aelkner | i agree with th1a that such a refactoring for more simplicity would be a good thing | 17:06 |
| menesis | aelkner. no, you are looking too deep | 17:06 |
| menesis | just have to fix a corner case | 17:06 |
| th1a | Or... I mean, if it would save two days of work to leave it hanging around but largely irrelevant, that might be a good idea. | 17:06 |
| menesis | is it bad that one sheet is created by default? don't think so | 17:07 |
| menesis | so why remove it | 17:07 |
| aelkner | it is obviously less work to leave the code with side-effects | 17:07 |
| aelkner | and to just add a few patches | 17:07 |
| aelkner | but that means i need to return to my intended discussion points of the scenarios | 17:08 |
| aelkner | what i mean is, | 17:08 |
| aelkner | we have two markedly different discussions possible | 17:09 |
| aelkner | depending on the decision to keep or remove ensureAtLeastOneWorksheet | 17:09 |
| aelkner | one is where the magic of creating a sheet is well defined | 17:09 |
| th1a | I don't want the system to be continually automatically making new worksheets if one is hidden. | 17:09 |
| aelkner | that needs to happen if we keep ensureAtLeastOneWorksheet | 17:10 |
| aelkner | because it already is called from a number of places | 17:10 |
| th1a | I don't want the user to have one default worksheet, hide it, and then there is ANOTHER ONE by magic. | 17:10 |
| aelkner | and may need to be called from some new places | 17:10 |
| aelkner | here's a case, the manager creates a report sheet, no Sheet1 is created n teacher visit | 17:11 |
| menesis | ensureAtLeastOneWorksheet creates one only if there are no sheets | 17:11 |
| aelkner | then manager hides | 17:11 |
| menesis | does not care if they are hidden or not | 17:11 |
| aelkner | menesis, i know that, that's the first thing i would change | 17:11 |
| menesis | so no, another one is not magically added | 17:11 |
| th1a | And I would prefer if each gradebook had the same default worksheet in the beginning, even if there is also a report sheet deployed before the users sees it. | 17:11 |
| th1a | So we just need a "There is no visible worksheet." message? | 17:12 |
| aelkner | that was waht i was thinking about in the other scenario | 17:12 |
| aelkner | what if the auto-creation of Sheet1 depended on personal sheets | 17:12 |
| aelkner | so even if a report sheet is deployed, a new one is created | 17:12 |
| aelkner | but | 17:12 |
| menesis | th1a: yes | 17:12 |
| aelkner | if the user hides Sheet1, none is created | 17:13 |
| aelkner | and if that means an empty gradebook, so be it | 17:13 |
| menesis | and fix SectionGradebookLinkViewlet so that there is a link to Gradebook from Section in that case | 17:13 |
| aelkner | we would just have the message and creation link therin | 17:13 |
| aelkner | menesis, to the hidden one, right? | 17:13 |
| aelkner | which would have the message with link | 17:14 |
| aelkner | th1a, let me confirm one thing first | 17:15 |
| aelkner | can ensureAtLeastOneWorksheet logic be as follows: | 17:15 |
| menesis | the link to gradebook, not a sheet | 17:15 |
| aelkner | menesis, wait | 17:15 |
| aelkner | if there are no personal sheets (hidden or otherwise) | 17:16 |
| aelkner | create Sheet1 | 17:16 |
| aelkner | if there are any, even if all are hidden, don't create one ay more | 17:16 |
| aelkner | ignore report sheets for this logic | 17:16 |
| th1a | Yes. | 17:16 |
| aelkner | ok, good, then, if all sheets are hidden | 17:16 |
| aelkner | regardless of type | 17:16 |
| aelkner | then any of the hidden worksheets (the base of the gradebook adapter) | 17:17 |
| aelkner | would display an empty gradebook with message and create link | 17:17 |
| th1a | y | 17:17 |
| aelkner | so back to menesis' point from before | 17:17 |
| aelkner | in the section, even if all worksheets are hidden | 17:18 |
| aelkner | we need a gradebook link | 17:18 |
| aelkner | and we can base it off the first hidden worksheet in the section | 17:18 |
| aelkner | since all are hidden, it doesn't matter which | 17:18 |
| th1a | ok | 17:18 |
| aelkner | and the view is empty anyway, with create link | 17:18 |
| aelkner | menesis, does that sound ok? | 17:18 |
| menesis | yes | 17:19 |
| aelkner | nice | 17:19 |
| aelkner | looks like a clear path to fix many problems | 17:19 |
| th1a | OK. Good. | 17:20 |
| th1a | Next? | 17:20 |
| aelkner | so i'm done | 17:20 |
| th1a | OK. | 17:21 |
| th1a | Thanks aelkner. | 17:21 |
| th1a | replaceafill? | 17:21 |
| replaceafill | ok | 17:21 |
| replaceafill | i made good progress on cambodia's flourishing | 17:21 |
| replaceafill | which allowed me to find some issues | 17:21 |
| replaceafill | 1. dates | 17:22 |
| replaceafill | cambodia was very explicit about needing this format in all places: DD-MM-YYYY | 17:22 |
| replaceafill | unfortunately, that's not part of the standard preferences | 17:22 |
| th1a | It isn't a choice? | 17:23 |
| replaceafill | and in the old skin was kind of easier to "override" | 17:23 |
| th1a | Or just isn't followed everywhere? | 17:23 |
| replaceafill | th1a, both | 17:23 |
| replaceafill | it's not in the choices | 17:23 |
| replaceafill | and flourish doesn't follow it everywhere | 17:23 |
| th1a | What does the widget use? | 17:23 |
| replaceafill | fixing the first one is simple, you just override the application preferences | 17:23 |
| replaceafill | but for example the datepicker | 17:24 |
| th1a | I'd say we should be adding this to core, btw. | 17:24 |
| replaceafill | its format is hardcoded in the flourish.js resource | 17:24 |
| th1a | What does it use? | 17:24 |
| replaceafill | yyyy-mm-dd | 17:24 |
| replaceafill | well, just 2 yy :) | 17:24 |
| replaceafill | yy-mm-dd | 17:24 |
| replaceafill | but that produces 2010-11-23 | 17:25 |
| replaceafill | it's kind of the standard across the whole app | 17:25 |
| replaceafill | that's another issue | 17:25 |
| menesis | date format preferences are not followed, and that needs to be fixed in core. | 17:25 |
| replaceafill | in the old skin it was easier to override the date field behaviour | 17:25 |
| th1a | I wonder if we could leave it in that format in the widget but display the preferred format as a hint. | 17:25 |
| menesis | I see date display widgets show 2011.12.23, and not sure where that comes from. maybe locale | 17:26 |
| replaceafill | menesis, in some places like the year index view | 17:26 |
| replaceafill | we just use unicode(some_date) | 17:27 |
| replaceafill | in some places we use the medium date view | 17:27 |
| replaceafill | which uses the locale instead of the preference | 17:27 |
| replaceafill | so, basically i wanted cambodia to use the preference everywhere | 17:27 |
| replaceafill | and the last wall i hit was the zc.datetimewidget! | 17:28 |
| replaceafill | i thought we had gotten rid of it | 17:28 |
| menesis | no. | 17:28 |
| replaceafill | but its logic remains in some field validators used in year/term forms | 17:28 |
| menesis | the underlying widget is still zc.datetimewidget | 17:28 |
| menesis | only the display is different to use jQuery datepicker | 17:29 |
| menesis | that's because z3c.form does not have a DateWidget | 17:29 |
| menesis | at all | 17:29 |
| replaceafill | menesis, i think we could get rid of it if we used z3c.form converters in the validators | 17:29 |
| replaceafill | i mean, data converters | 17:29 |
| replaceafill | that's all what we use the zc.datetimewidget for afaict | 17:30 |
| th1a | My instinct is that getting the formats right in the forms that use the datepicker is likely to be a giant pain in the ass. | 17:30 |
| menesis | there are some dateformat adapters, but not sure when they are used | 17:30 |
| menesis | but I see different formats in different places | 17:30 |
| replaceafill | at the end, i was able to make cambodia to work the way i wanted :) | 17:31 |
| replaceafill | but i had to jump a lot of hoops | 17:31 |
| th1a | What if the actual text box that the date goes into was hidden and the date was rendered as text? | 17:31 |
| th1a | Would that be easier? | 17:32 |
| replaceafill | th1a, what would be the advantage of that? | 17:32 |
| menesis | it is probably more irritating to you americans because you are used to a mm/dd/yy format. we are ok with yyyy-mm-dd, it is standard. although the same format with dots or spaces is also used. | 17:32 |
| th1a | Basically what I'm trying to say is that because people usually use the calendar widget it isn't so important that they be able to input in their preferred format as much as read in it. | 17:32 |
| menesis | no, please, let the user enter date | 17:32 |
| menesis | without using the datepicker | 17:32 |
| replaceafill | menesis, +1 | 17:32 |
| menesis | especially when you enter birthdays | 17:33 |
| th1a | Reading yyyy-mm--dd doesn't bother me at all. | 17:33 |
| menesis | and have to click previous year many times | 17:33 |
| th1a | Just the Cambodians, apparently. | 17:33 |
| replaceafill | th1a, correct | 17:33 |
| th1a | So... is fixing this *correctly* even plausible? | 17:34 |
| replaceafill | my conclusion about all these issue was: we should use the preference more | 17:34 |
| replaceafill | i mean, maybe not everywhere, just more | 17:34 |
| replaceafill | not replacing the yyyy-mm-dd, which i think we only use to satisfy zc.datetimewidget | 17:34 |
| menesis | if all the views used date widget | 17:34 |
| menesis | then only the widget needed to be fixed | 17:35 |
| menesis | (two widgets, for display and input) | 17:35 |
| th1a | I think my conclusion is do whatever you can do in less than two days. | 17:35 |
| replaceafill | th1a, ok, just won't do it now | 17:36 |
| replaceafill | i can go back to it later | 17:36 |
| replaceafill | ok, continuing my report | 17:36 |
| replaceafill | cambodia also uses a lot of custom demographics | 17:36 |
| * th1a hates dates. | 17:36 | |
| replaceafill | so i've been working on that too | 17:36 |
| replaceafill | :D | 17:36 |
| replaceafill | i fixed this one: https://bugs.launchpad.net/schooltool/+bug/898219 | 17:37 |
| replaceafill | you can see it here: http://69.164.203.135:6603/persons/add.html | 17:37 |
| replaceafill | see the Demographics fieldset | 17:37 |
| replaceafill | Programming Language is a required selection list | 17:37 |
| replaceafill | and shows "select a value..." | 17:37 |
| replaceafill | Income is an optional selection list | 17:37 |
| replaceafill | displays "no value" like the rest | 17:38 |
| replaceafill | in this regard i also found this: https://bugs.launchpad.net/schooltool/+bug/914609 | 17:38 |
| replaceafill | it's not possible to edit limited custom fields | 17:38 |
| replaceafill | limited as in only for a group | 17:38 |
| menesis | that was strange | 17:38 |
| replaceafill | menesis, it used to be possible? | 17:39 |
| menesis | I think so.. | 17:39 |
| replaceafill | ah | 17:39 |
| replaceafill | well, i need to fix that for cambodia | 17:40 |
| replaceafill | menesis, i requested: https://code.launchpad.net/~replaceafill/schooltool/flourish/+merge/87987 | 17:40 |
| menesis | there was a bug that empty fieldsets were displayed. maybe this was broken when fixing that one | 17:40 |
| replaceafill | if you could take a look at it, i'd appreciate it | 17:40 |
| menesis | haven't seen the merge request | 17:41 |
| replaceafill | menesis, i'll investigate | 17:41 |
| menesis | strange.. | 17:41 |
| menesis | but its ok | 17:41 |
| replaceafill | that's also needed in cambodia btw, integer custom fields | 17:41 |
| menesis | the feature | 17:41 |
| replaceafill | and i had one question for yvl about an appropriate way to disable viewlets in flourish | 17:42 |
| replaceafill | but that can wait | 17:42 |
| replaceafill | i hacked a disabled viewlet class to render '' | 17:42 |
| replaceafill | and that works for now | 17:42 |
| th1a | We could add integer custom fields. | 17:43 |
| th1a | Not exactly an oddball case. | 17:43 |
| replaceafill | th1a +1 | 17:43 |
| replaceafill | if menesis says that the diff is ok, i'll merge that change | 17:44 |
| menesis | I haven't looked at the diff | 17:44 |
| menesis | only at your demo | 17:44 |
| replaceafill | menesis :) | 17:44 |
| replaceafill | np, i can wait, i'm working with a merged trunk meanwhile | 17:44 |
| menesis | there is a disabled viewlet class | 17:44 |
| replaceafill | menesis, yes, but that's not used in flourish | 17:45 |
| replaceafill | i mean the viewletmanagers in flourish dont use it as in the old skin | 17:45 |
| menesis | in schooltool.skin.flourish.page.DisabledViewlet | 17:45 |
| replaceafill | menesis, ah1?!?!? | 17:45 |
| menesis | but it does the asme as you said | 17:45 |
| menesis | :) | 17:45 |
| replaceafill | doh! | 17:45 |
| replaceafill | :D | 17:45 |
| replaceafill | great, then that's the way ;) | 17:45 |
| replaceafill | i'll use that, thanks menesis! | 17:46 |
| replaceafill | i found the old one :P | 17:46 |
| replaceafill | but didnt find the flourish one | 17:46 |
| replaceafill | th1a, i'll work on these "issues" and keep working in cambodia, next i'll adjust the change to global levels | 17:46 |
| replaceafill | instead of year contained ones | 17:47 |
| th1a | OK. | 17:47 |
| * replaceafill done | 17:47 | |
| th1a | Thanks replaceafill. | 17:47 |
| th1a | menesis: Any news? | 17:47 |
| menesis | I uploaded the newer zope packages | 17:48 |
| menesis | and am done with them | 17:48 |
| aelkner | menesis, please check with me bofore you finish your report | 17:48 |
| menesis | although today I see that cando tests have been broken :( | 17:48 |
| menesis | other news.. | 17:49 |
| menesis | I will be working on another project for pov the next two weeks | 17:49 |
| menesis | so little news coming from me | 17:50 |
| th1a | OK. | 17:50 |
| menesis | of course, I will be available and read mail & launchpad | 17:50 |
| menesis | just don't think will do much for schooltool | 17:50 |
| aelkner | can i ask my question related to that | 17:51 |
| menesis | aelkner: yes | 17:51 |
| aelkner | right before vacation, i made a change to gradebook trunk which you needed to revert | 17:51 |
| aelkner | problem there was too many new feature, broken tests | 17:52 |
| th1a | menesis: Understood. | 17:52 |
| aelkner | i take the blame for not seeing the broken tests | 17:52 |
| aelkner | this is my question: | 17:52 |
| aelkner | is there a way for us to keep doing what we did coming out of the summer sprint | 17:52 |
| th1a | replaceafill: I just gave you https://bugs.launchpad.net/schooltool/+bug/913581. Can you fix that and also try to come up with a workaround for the user? | 17:52 |
| aelkner | that is, allowing us to merge our fixes to trunk | 17:52 |
| aelkner | but keeping in mind | 17:52 |
| aelkner | that some merges are two big and need to be put in a special branch with merge request | 17:53 |
| replaceafill | th1a, ah ok, i'll investigate | 17:53 |
| aelkner | firstly, i'd like us to agree on a criterion for that | 17:53 |
| th1a | replaceafill: Yes, look at it today. | 17:53 |
| replaceafill | th1a, kk | 17:53 |
| menesis | aelkner: yes, you can merge to trunk (the flourish branch) | 17:54 |
| aelkner | and secondly, what do i do with the create worksheets branch while menesis is gone for two weeks | 17:54 |
| menesis | replaceafill does that | 17:54 |
| aelkner | i just should have had better CHANGES.txt messages? | 17:54 |
| aelkner | and working tests? | 17:54 |
| menesis | I only reverted deploy course sheets because it was not ready | 17:55 |
| menesis | yes, tests have to work | 17:55 |
| aelkner | the broken tests had to do with me changeing the appearance of total/ave | 17:55 |
| menesis | it was also a big and obscure feature | 17:55 |
| aelkner | which i did because of the consequenses of the new course worksheet logic | 17:55 |
| aelkner | the thing that threw me was that you said the words, 'merge request' | 17:56 |
| menesis | by obscure I mean we did not understand what you are working on, so wanted to see what it is | 17:56 |
| aelkner | but we don't need merge requests if we merge ourselves | 17:56 |
| replaceafill | th1a, i assume you're more interested in a workaround for the user, since he's using debs from the ppa | 17:56 |
| replaceafill | th1a, not that you don't care of that being fixed :D | 17:56 |
| th1a | replaceafill: I want it fixed but I guess we won't be pushing a release for a few weeks. | 17:57 |
| aelkner | menesis, so i'll continue to assume there is no need for merge requests, right | 17:57 |
| replaceafill | i request merges when i want another pair of eyes checking what i've done | 17:57 |
| replaceafill | to get feedback, etc | 17:57 |
| aelkner | and i'll be more desciptive in CHANGES.txt when the change is so big | 17:57 |
| replaceafill | th1a, understood | 17:57 |
| menesis | aelkner: you have to judge yourself. if changes are simple you may merge without asking | 17:57 |
| menesis | or even commit to trunk | 17:58 |
| menesis | but if it is big you may want to have the code reviewed | 17:58 |
| aelkner | what about course worksheets branch? | 17:58 |
| aelkner | you are not going to be around | 17:58 |
| menesis | I will be on vacation only for two work days | 17:59 |
| menesis | other times I will be available | 17:59 |
| aelkner | oh, thought you said two weeks, my bad | 17:59 |
| menesis | just don't think I will develop anything myself | 17:59 |
| aelkner | can you turn around my course worksheets merge request quickly, don't want the code to diverge | 18:00 |
| aelkner | i would be making that request at the end of the week or early next week | 18:01 |
| menesis | yes, will review | 18:01 |
| aelkner | ok, thanks | 18:02 |
| th1a | btw, menesis, is yvl still sick? | 18:03 |
| menesis | th1a: yes | 18:03 |
| menesis | this week | 18:03 |
| th1a | OK. | 18:03 |
| th1a | Guess that's it then. | 18:03 |
| th1a | I sent in your invoices yesterday. | 18:03 |
| th1a | Have a good week and weekend! | 18:04 |
| * th1a drops the bag of gravel. | 18:04 | |
| menesis | and yvl will be on vacation Jan 13-20 | 18:04 |
| th1a | menesis: Yes. | 18:07 |
| *** ignas has quit IRC | 18:23 | |
| replaceafill | th1a, got it, it's a "obscure" issue, at least for me :) | 18:42 |
| replaceafill | related to proxy objects | 18:42 |
| replaceafill | should i advise the user to modify the code? send a patch to him? | 18:42 |
| replaceafill | well, it's less obscure when you read the docs :) | 18:53 |
| *** menesis has quit IRC | 19:25 | |
| replaceafill | th1a, don't know if you got this, but could you take this one: https://answers.launchpad.net/cando/+question/184401? | 20:55 |
| replaceafill | hhmm, i can't install schooltool in oneiric from the ppa... | 21:54 |
| replaceafill | "Requires installation of unstrusted packages" | 21:55 |
| *** menesis has joined #schooltool | 21:58 | |
| *** aelkner has quit IRC | 22:11 | |
| *** aelkner has joined #schooltool | 22:24 | |
| *** menesis has quit IRC | 23:43 | |
| *** replaceafill has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!