| *** jelkner has quit IRC | 01:42 | |
| *** menesis has quit IRC | 01:44 | |
| *** menesis has joined #schooltool | 01:56 | |
| *** alga has quit IRC | 02:01 | |
| *** replaceafill has quit IRC | 02:39 | |
| *** menesis has quit IRC | 02:48 | |
| *** hoffman has joined #schooltool | 04:37 | |
| *** aks has joined #schooltool | 06:17 | |
| *** hoffman has quit IRC | 07:05 | |
| *** yvl has joined #schooltool | 09:22 | |
| *** alga has joined #schooltool | 11:04 | |
| *** menesis has joined #schooltool | 11:17 | |
| *** aks has quit IRC | 11:55 | |
| *** menesis has quit IRC | 13:12 | |
| *** menesis has joined #schooltool | 14:02 | |
| *** hoffman has joined #schooltool | 14:50 | |
| *** hoffman has quit IRC | 15:29 | |
| *** ignas has joined #schooltool | 15:54 | |
| *** yvl has quit IRC | 16:00 | |
| *** yvl has joined #schooltool | 16:30 | |
| yvl | morning, guys? :) | 16:34 |
|---|---|---|
| yvl | well, since nobody seems to be here, I'll assume that everything is going well ;) | 16:39 |
| *** yvl has quit IRC | 16:57 | |
| *** asharma has joined #schooltool | 17:09 | |
| *** asharma has quit IRC | 17:40 | |
| *** jakecamara has joined #schooltool | 17:45 | |
| *** jakecamara has left #schooltool | 17:48 | |
| *** asharma has joined #schooltool | 18:51 | |
| *** menesis has quit IRC | 19:08 | |
| *** alga has quit IRC | 19:13 | |
| *** replaceafill has joined #schooltool | 19:20 | |
| * replaceafill is back home with his daughter :) | 19:20 | |
| *** aks has joined #schooltool | 19:23 | |
| th1a | Great news replaceafill. | 19:27 |
| replaceafill | :) | 19:28 |
| aks | asharma: how are the translations going on? | 19:34 |
| asharma | all right | 19:35 |
| asharma | I'm doing the manual right now | 19:35 |
| aks | asharma: ok, any problems till now? | 19:35 |
| asharma | not really, I'm still testing them | 19:36 |
| aks | asharma: i see | 19:36 |
| aks | th1a, replaceafill: I'll be building RPM packages for the new release | 19:36 |
| asharma | getting the pictures and replacing them is quite time consuming | 19:37 |
| asharma | sorry aelkner: I accidentally typed your name | 19:38 |
| aks | asharma: so you are copying pictures from the *.doc file I sent you? | 19:38 |
| asharma | yes. I have to resize them though | 19:39 |
| aks | asharma: ok | 19:39 |
| aks | asharma: I'll try to find the images in png format, and if I find them, i'll mail them to you | 19:39 |
| asharma | sure. thanks! | 19:40 |
| asharma | aks, I have something like this for one file file :///home/asharma/st-book-nep/build/years.html | 19:41 |
| aks | asharma: sorry I can't browse that link because it is local to your machine and inaccessible on the internet | 19:42 |
| asharma | oh..kay | 19:42 |
| th1a | aks: Good to hear. | 19:45 |
| th1a | asharma: I've actually automated some of the screenshot process, but it might still be dependent on the links being in English. | 19:45 |
| aks | th1a: I have also shared inclusion of SchoolTool in OLPC XS (my wishlist), see http://asingh.com.np/blog/olpc-xs-my-wishlist/ | 19:48 |
| th1a | Ah, thanks. | 19:49 |
| asharma | th1a, I have the Nepali screenshots in a text file...I'm saving them and replacing the english ones with those...is there another way to do that? | 19:51 |
| th1a | Are you using Selenium at all? | 19:52 |
| asharma | no | 19:54 |
| asharma | I'm doing the translations in gedit | 19:54 |
| th1a | So... this may be overkill. | 19:54 |
| th1a | There are selenium scripts -- for english -- that will step through the examples in the schooltool book automatically, letting you stop and take screenshots. | 19:55 |
| th1a | But they'd probably (almost certainly) take fiddling to work in Nepali. | 19:55 |
| asharma | I already have the screenshots | 19:56 |
| th1a | And also, I've started working on Python scripts that actually automate the whole process, including taking the screenshots. | 19:56 |
| th1a | OK, I'm wasting your time then. ;-) | 19:56 |
| aks | th1a: asharma already had the screenshots for the Nepali interface (as a part of the Nepali manual that I sent her) :) | 19:56 |
| *** jelkner has joined #schooltool | 19:57 | |
| jelkner | th1a: to use selenium we would need a running instance of ST set to use the Napil locale, yes? | 19:58 |
| jelkner | asharma has the screenshot for now | 19:58 |
| jelkner | so she doesn't need to worry about that | 19:58 |
| th1a | Yes... just forget I ever said anything. | 19:58 |
| jelkner | ok | 19:58 |
| jelkner | th1a, btw asharma will have a bzr branch on launchpad with the sphinx work she has been doing by end of work today | 19:59 |
| jelkner | we talked to the sphinx-dev folks yesterday | 19:59 |
| th1a | Excellent. | 20:00 |
| jelkner | to ask if they could get her Napli support into sphinx before her internship ends | 20:00 |
| jelkner | they will try to accommodate that | 20:00 |
| *** aks has quit IRC | 20:17 | |
| *** asharma has quit IRC | 20:29 | |
| aelkner | replaceafill, hey | 20:29 |
| replaceafill | hey aelkner | 20:30 |
| aelkner | so what happened this morning | 20:31 |
| replaceafill | sorry i was out, coming back home | 20:31 |
| aelkner | i decided to go back to sleep, so i feel really well rested now | 20:31 |
| replaceafill | good for you :) | 20:32 |
| aelkner | so did you look at my commits | 20:32 |
| aelkner | and how's the relationship thing coming? | 20:32 |
| replaceafill | got stuck with the relationship base view | 20:33 |
| replaceafill | too many controls to handle | 20:33 |
| aelkner | yeah, it is a complex view | 20:33 |
| replaceafill | if we're going to do it a dialog, we should better implement a new view with the same functionality | 20:33 |
| replaceafill | instead of porting the current one | 20:33 |
| aelkner | i'd do that | 20:35 |
| replaceafill | i'm pulling your changes | 20:35 |
| aelkner | we have that freedom i think | 20:35 |
| th1a | I'm ok with that. | 20:36 |
| replaceafill | good | 20:36 |
| aelkner | since we're taking advantage of modalness and buttons next to things that need changing | 20:36 |
| replaceafill | th1a that view uses table functionality | 20:36 |
| aelkner | could we have two different dialogs for adding removing? | 20:36 |
| replaceafill | and allows you to display several pages | 20:36 |
| aelkner | would that make it easier to code | 20:36 |
| aelkner | perhaps the user would like it, too | 20:37 |
| aelkner | the dialog would be simpler if it just was about one thing | 20:37 |
| replaceafill | th1a that makes it hard to port to JS | 20:37 |
| replaceafill | but it's possible, i just didnt know if i should do it | 20:37 |
| replaceafill | but i will | 20:37 |
| aelkner | replaceafill, what are you responding to, 'th1a that makes it hard to port to JS' | 20:38 |
| aelkner | he just said 'I'm ok with that' | 20:38 |
| replaceafill | aelkner i just was explaining what i found | 20:38 |
| replaceafill | :/ | 20:39 |
| replaceafill | anyway... i pulled your changes aelkner, starting my instance | 20:39 |
| aelkner | th1a, what do you think about the idea of having one dialog for adding | 20:40 |
| aelkner | and one for removing relationships? | 20:40 |
| aelkner | i always thought those views were too big | 20:40 |
| replaceafill | aelkner why two dialogs? | 20:40 |
| replaceafill | i see it as an edit view | 20:41 |
| aelkner | i was thinking because we had agreed that we didn't want our modals to be too big | 20:41 |
| aelkner | the idea was that they were for quick things | 20:41 |
| replaceafill | i always forget this: is the teacher supposed to see the student's index view? | 20:42 |
| aelkner | yes | 20:42 |
| replaceafill | hhmm i'm getting the not allowed form... | 20:42 |
| aelkner | btw, i made the permission on the advisory viewlet schoooltool.edit | 20:42 |
| th1a | Oh... | 20:43 |
| aelkner | as manager? | 20:43 |
| aelkner | th1a, are you browsing the instance? | 20:44 |
| th1a | I was looking at something else. | 20:44 |
| replaceafill | i'm going to pull the changes to the testing instance | 20:44 |
| th1a | My vague feeling is that adding and removing relationships should be one view. | 20:45 |
| replaceafill | i agree | 20:45 |
| replaceafill | ok, instance updated, http://69.164.203.135:54111/ | 20:46 |
| th1a | Also, in re-doing this form, we'll need to *completely* step away from the current implementation. | 20:46 |
| th1a | Which is strange, but works. | 20:46 |
| th1a | But I suspect a *completely different* implementation is out there that is much better. | 20:46 |
| aelkner | which form? | 20:47 |
| th1a | Relationship editing. | 20:47 |
| aelkner | so what about splitting i up into two spearate forms | 20:47 |
| aelkner | adding/removing | 20:47 |
| th1a | That sounds weird to me. | 20:47 |
| aelkner | most of the time, the user only wants to do one | 20:47 |
| replaceafill | we're getting rid of home.html, correct? | 20:47 |
| th1a | Eh... | 20:47 |
| th1a | I don't think so, aelkner, also then you need two links. | 20:48 |
| th1a | I can't think of another application that works that way. | 20:48 |
| replaceafill | aelkner you need autoHeight in the accordion settings | 20:48 |
| aelkner | ok | 20:48 |
| aelkner | yeah, right now it seems to always have the same hright, even if empty | 20:49 |
| th1a | We could have a two-column drag and drop interface. | 20:49 |
| replaceafill | http://jqueryui.com/demos/accordion/#option-autoHeight | 20:49 |
| replaceafill | th1a hhmm... | 20:49 |
| replaceafill | interesting :) | 20:49 |
| aelkner | what is interesting? | 20:50 |
| replaceafill | but would that work for selecting persons? | 20:50 |
| replaceafill | like students in a section | 20:50 |
| aelkner | would what work for selecting purposes? | 20:50 |
| th1a | Adding students to a section? | 20:50 |
| aelkner | are you guys private chatting or something?! | 20:51 |
| replaceafill | the two-column drag and drop interface | 20:51 |
| aelkner | what two-column drag and drop interface? | 20:51 |
| th1a | We could have a two-column drag and drop interface. | 20:51 |
| replaceafill | aelkner if i'm following the chat correctly, th1a is suggesting drag and drop for editing relationships | 20:52 |
| replaceafill | am i right? | 20:52 |
| aelkner | oh, sorry, i see his comment on two columns | 20:53 |
| th1a | Yes. | 20:53 |
| replaceafill | so, when you enroll students, that view is editing relationships | 20:53 |
| *** menesis has joined #schooltool | 20:53 | |
| aelkner | th1a, remember when we discussed two column with selection and arrow keys way back in Dallas? | 20:54 |
| replaceafill | i see drag and drop functional for small lists, like groups | 20:54 |
| aelkner | fo some reason ignas didn't like it | 20:54 |
| aelkner | but i always thought that two columns with the < << > >> what eas to usey | 20:54 |
| aelkner | perhaps << and >> would be two much for adding persons to a section | 20:55 |
| aelkner | but the main reason for the complexity of the current views is the use BatchTable | 20:55 |
| aelkner | which they need to in order to handle the tousands of candidates and filtering | 20:56 |
| replaceafill | so, the student cannot see his advisors? | 20:56 |
| replaceafill | (i'm coming back to the accordions btw, sorry) | 20:56 |
| th1a | Their contact info, etc? | 20:56 |
| replaceafill | no, his advisors accordion | 20:57 |
| replaceafill | is protected with schooltool.edit | 20:57 |
| th1a | On the student's page? | 20:57 |
| replaceafill | not displayed when the student sees his profile | 20:57 |
| replaceafill | yes | 20:57 |
| replaceafill | person index of a student | 20:57 |
| replaceafill | sorr, person index view of a student | 20:57 |
| th1a | The student should be able to see the name of his advisor, yes. | 20:57 |
| th1a | But not demographic or contact info about the advisor. | 20:57 |
| replaceafill | aelkner, that's not possible with schooltool.edit | 20:57 |
| replaceafill | on the advisory accordion | 20:58 |
| aelkner | taking a step back a moment | 20:58 |
| aelkner | who can see a student's index.html view? | 20:59 |
| aelkner | and if they can, are there parts that need to be protected? | 20:59 |
| aelkner | perhaps i was mistaken to protect the advisory viewlet wth schooltool.edit | 21:00 |
| th1a | You need to differentiate between view and edit. | 21:01 |
| th1a | You need to protect the edit buttons with edit. | 21:01 |
| replaceafill | aelkner yes, if the person has advisees, she cannot see them either | 21:01 |
| th1a | That is, hide the buttons if the person doesn't have edit. | 21:01 |
| aelkner | so who the student has as advisor is not to be protected, right? | 21:01 |
| replaceafill | aelkner check the groups viewlet, works that way | 21:01 |
| aelkner | i'm just asking if the advisors is more private info than groups | 21:02 |
| th1a | It is not. | 21:02 |
| aelkner | ok, than jsut the edit buttons are protected | 21:02 |
| th1a | in particular, hidden. | 21:03 |
| aelkner | right, not even there | 21:03 |
| replaceafill | can we go back to edit relatioships? :) | 21:04 |
| aelkner | sure | 21:04 |
| replaceafill | so, we need a new view, hopefully one that makes easy to convert it to a dialog | 21:04 |
| replaceafill | like we do with z3c.forms | 21:04 |
| replaceafill | the current view has services like search and batching (limited number of items in a single page) | 21:05 |
| replaceafill | we still need those in the new view, correct? | 21:05 |
| th1a | I should note here that also one of the reasons I thought this would be good to do in a modal dialog is the nature of the current design. | 21:06 |
| th1a | So another alternative is just a better whole-page implementation. | 21:06 |
| th1a | One problem is that I don't know the generic name for this kind of selector. | 21:07 |
| * replaceafill is looking how many relationship views we have | 21:11 | |
| replaceafill | leaders?!?! | 21:12 |
| th1a | Yes. | 21:12 |
| th1a | Someone has to be in charge of a group. | 21:12 |
| replaceafill | "Edit Leaders"! | 21:13 |
| replaceafill | i see the link for courses | 21:13 |
| * replaceafill goes see the zcml | 21:13 | |
| th1a | Don't worry about that now replaceafill... | 21:14 |
| replaceafill | ok, just curious :) | 21:14 |
| replaceafill | i have never noticed that concept | 21:14 |
| replaceafill | ok, relationship views for: advisor/advisees, leaders, section instructors/members, group membership, groups of a person | 21:16 |
| replaceafill | did i forget anything? | 21:16 |
| th1a | Not that I can think of. | 21:18 |
| replaceafill | th1a, http://jqueryui.com/demos/draggable/#sortable | 21:19 |
| replaceafill | with two columns :) | 21:20 |
| th1a | Yes. | 21:20 |
| aelkner | nice! | 21:20 |
| replaceafill | if we keep the search functionality, it could work | 21:20 |
| th1a | It is possible. | 21:20 |
| replaceafill | i look for all the "elkners" and the drag jelkner and aelkner and loui :) | 21:21 |
| th1a | Basically. | 21:23 |
| jelkner | cool, dragging elkners, what will you think of next?! | 21:23 |
| aelkner | hopefully not through the mud! | 21:24 |
| replaceafill | :D | 21:24 |
| th1a | replaceafill: calendar_selection.html? | 21:25 |
| replaceafill | th1a i see the view in code, but how do i get there through the UI? | 21:27 |
| replaceafill | ah, Manage button | 21:28 |
| th1a | I had that one flagged to make modal. | 21:29 |
| replaceafill | i think i'm going to load the sample xls to see all these options enabled | 21:31 |
| replaceafill | i need Resources | 21:31 |
| *** jelkner has quit IRC | 21:32 | |
| *** dadeng has joined #schooltool | 21:34 | |
| dadeng | oh, it's a full house! | 21:35 |
| dadeng | aelkner, r u there? | 21:35 |
| dadeng | and th1a, i'm still having some challenges with niepa branch installation | 21:36 |
| th1a | Yes... you pulled menesis's update? | 21:37 |
| dadeng | no, i still used aelkner | 21:37 |
| dadeng | do u mean i should menesis's instead? | 21:38 |
| *** alga has joined #schooltool | 21:38 | |
| th1a | menesis made change for you. | 21:38 |
| th1a | Did you get the email? | 21:39 |
| th1a | (this was a while ago) | 21:39 |
| dadeng | oh, i did not understand that when i read the email on update or something like that | 21:39 |
| menesis | dadeng: bzr pull lp:~menesis/schooltool/schooltool.niepa | 21:39 |
| menesis | in your niepa branch | 21:39 |
| menesis | its two small fixes | 21:39 |
| dadeng | oh, this is where the problem came from | 21:40 |
| menesis | I also built cando eggs | 21:40 |
| dadeng | ok, i'll make that adjustment and get back to u | 21:40 |
| replaceafill | th1a that Resources list in calendar_selection.html can get pretty large :) | 21:42 |
| replaceafill | th1a, but yes, i think we can do it modal | 21:42 |
| menesis | dadeng: do 'make update' to rebuild using the latest cando | 21:47 |
| dadeng | ok | 21:50 |
| aelkner | dadeng, hi | 21:52 |
| dadeng | hi aelkner | 21:52 |
| aelkner | i'm letting menesis help you because he has the answers for these package building issues | 21:52 |
| dadeng | i'm just effecting the changes | 21:53 |
| dadeng | and i think everything is ok for now | 21:53 |
| aelkner | good to hear | 21:53 |
| dadeng | i've just log in with one of the teachers account now | 21:53 |
| dadeng | and it was successful | 21:53 |
| dadeng | i'll look through it and get back | 21:53 |
| dadeng | i also saw the reporting modules | 21:54 |
| dadeng | and i have some questions concerning them | 21:54 |
| dadeng | but that would be later | 21:54 |
| aelkner | ok, we'll be looking for your email | 21:54 |
| dadeng | ok | 21:55 |
| dadeng | aelkner everything is ok for now, | 22:10 |
| dadeng | but how can i assign a common password to all the students in the db? | 22:11 |
| aelkner | if you create an new XLS file with just a sheet for persons | 22:15 |
| aelkner | you could reimport the students with the passwords set to the new identical ones | 22:16 |
| aelkner | but what you are asking for is a new view that allows the administrator to assign the password | 22:16 |
| aelkner | to all persons in the 'students' group | 22:17 |
| aelkner | or something like that | 22:17 |
| dadeng | well... i guess doing it that way is also possible but | 22:17 |
| dadeng | will the existing persons be overwritten? | 22:18 |
| dadeng | if import thrugh xls? | 22:18 |
| aelkner | any fields in the XLS file will replace the ones in the existing persons | 22:19 |
| aelkner | but the objects themselves will not be replaced, just some of the attributes | 22:19 |
| aelkner | so no grades, for instance, would be lost | 22:19 |
| dadeng | ok, then i guess that is the easier way to go then | 22:19 |
| aelkner | please make a backup of your Data.fs file before doing the import | 22:20 |
| dadeng | yeah, i have that already | 22:20 |
| aelkner | ok, good, let us know how it goes in your email | 22:20 |
| dadeng | ok, and thanks! | 22:20 |
| aelkner | np | 22:20 |
| * th1a returns from his unannounced siesta. | 22:33 | |
| dadeng | aelkner, i got "A system error occurred" | 22:34 |
| dadeng | while exporting the exprt.xls file back | 22:34 |
| dadeng | sorry importing | 22:35 |
| aelkner | can you send the traceback in an email please | 22:35 |
| dadeng | i i've just sent it | 22:41 |
| aelkner | i responded, please read | 22:44 |
| dadeng | ok, i just saw it | 22:47 |
| dadeng | but i think we had this error before, | 22:47 |
| dadeng | and u asked me to modify the demographics | 22:48 |
| dadeng | and it solved the problem | 22:48 |
| dadeng | can u remember? | 22:48 |
| dadeng | ok, i'll send u all the file and u can just remove whatever is not necessary | 22:49 |
| aelkner | i don't remember, but let me look... | 22:52 |
| aelkner | anyway, in the meantime, why don't just remove the worksheets yourself until you are down to just Persons | 22:55 |
| aelkner | i mean, make a copy first, and do it to the copy | 22:55 |
| *** dadeng has quit IRC | 22:57 | |
| aelkner | th1a, ayt? | 23:01 |
| th1a | I am here. | 23:01 |
| th1a | Are you wondering what to do? | 23:02 |
| aelkner | question: while importing sections, there is a timetable section | 23:02 |
| aelkner | for each timetable, there is a row with day id, period id and location id | 23:02 |
| * replaceafill is making calendar_selection.html to submit using JS | 23:03 | |
| aelkner | should resource id be required there? | 23:03 |
| th1a | No. | 23:03 |
| aelkner | we need the activity, even if the resource is blank, right? | 23:03 |
| aelkner | so it's just an optional thing to assign a resource for a given activity | 23:05 |
| aelkner | i'll file a bug so that we change it to not crash if they leave it blank | 23:05 |
| aelkner | and by we i mean me of course | 23:06 |
| th1a | Yes. | 23:06 |
| th1a | activity? | 23:06 |
| aelkner | timetable activity is the class name for when the class meets | 23:09 |
| th1a | ok. | 23:09 |
| aelkner | anyway, i'll be fixing the advisory permissions and hiding the edit buttons | 23:10 |
| aelkner | also, i'll work on the demographics viewlet | 23:10 |
| aelkner | have you looked at the instance yet? | 23:10 |
| aelkner | about the top part of hte person index.html view, | 23:11 |
| aelkner | should we put that stuff in a viewlet that is the top one, and thus, by default expanded? | 23:11 |
| th1a | What's the url again? | 23:11 |
| aelkner | replaceafill? | 23:12 |
| replaceafill | yes? | 23:12 |
| replaceafill | ah | 23:12 |
| replaceafill | http://69.164.203.135:54111/ | 23:12 |
| replaceafill | aelkner <div> </div>, really? :/ | 23:12 |
| aelkner | yeah, well | 23:13 |
| aelkner | we don't have a system yet for creating css classes | 23:13 |
| aelkner | that's supposed to be done during this sprint! | 23:13 |
| aelkner | anyway, i hesitate to create a class, in this case for spacing | 23:14 |
| aelkner | and put it into schooltool.css | 23:14 |
| replaceafill | +1 on a new class | 23:14 |
| replaceafill | why do you hesitate? | 23:14 |
| replaceafill | you don't like classes? | 23:14 |
| aelkner | it's an overcrowded, everything and the kitchen sink file, don't you think? | 23:15 |
| th1a | What's the issue? | 23:15 |
| aelkner | to me, classes should be well thought out at the global level | 23:15 |
| replaceafill | not, really, i prefer the class 100 times over <div> </div> | 23:15 |
| th1a | Adding spaces? | 23:15 |
| th1a | Padding? | 23:15 |
| aelkner | i need a spacing div in the advisory viewlet | 23:15 |
| replaceafill | aelkner you can add the class *now* and we fix it when we get to that part during this sprint ;) | 23:15 |
| aelkner | ok, i'll do that | 23:16 |
| replaceafill | ty | 23:16 |
| aelkner | when will we be getting to that?! | 23:16 |
| aelkner | one the last day | 23:16 |
| replaceafill | when we have flourish? | 23:16 |
| aelkner | next friday | 23:16 |
| aelkner | well, whenever | 23:17 |
| th1a | Spacing div where? | 23:17 |
| th1a | Separating the rows? | 23:17 |
| aelkner | are you looking at the advisory viewlet? | 23:17 |
| th1a | Yes. | 23:17 |
| aelkner | after edit advisors | 23:17 |
| replaceafill | th1a to separte advisors from advisees | 23:17 |
| aelkner | and before Advisees, the h3 | 23:18 |
| aelkner | they were scrunched together without the spacing div | 23:18 |
| aelkner | and replaceafill just objected to me taking advantage of the fact that a div with just one space | 23:18 |
| th1a | Doesn't our h3 have spacing before and after? | 23:18 |
| aelkner | i guess not | 23:19 |
| th1a | THAT'S THE BUG. | 23:19 |
| aelkner | well, there's all kinds of bugs with our css, that's just one of them | 23:19 |
| aelkner | so i was working around it with a spacing div | 23:19 |
| th1a | OK, don't. | 23:19 |
| replaceafill | we should also consider that these accordions change our style rules | 23:19 |
| th1a | We need to start fixing those right now. | 23:19 |
| aelkner | and i could have coded it <div class="my_on_time_spacing_class" /> | 23:20 |
| th1a | No, we need to fix the base css classes. | 23:20 |
| aelkner | but we don't have a flourish branch to build on | 23:20 |
| th1a | like, h3. | 23:20 |
| aelkner | i don't think you can always know how you want h3 to behave in all views | 23:21 |
| th1a | To be clear... it would be much better for this to look wrong and cause us to fix the base css than any workaround. | 23:21 |
| aelkner | that's what classes are for | 23:21 |
| th1a | An h3 should ALWAYS have padding. | 23:21 |
| th1a | That's part of what makes it an h3. | 23:21 |
| aelkner | where do you get that? | 23:21 |
| aelkner | h4, not so much, h2, neither? | 23:22 |
| aelkner | people use hn for titles of views, for instance | 23:22 |
| th1a | Apparently this is a fundamental flaw in our CSS. | 23:22 |
| aelkner | they don't want padding-top necessarily | 23:22 |
| aelkner | i think you want the css class to do the pading, not the element css | 23:23 |
| replaceafill | and we also have h1 -> h2 -> h5 -> h3 | 23:23 |
| aelkner | but that's just my opinion | 23:23 |
| th1a | I guess Ubuntu does this with line-height, not padding. | 23:23 |
| th1a | Well, both: | 23:23 |
| th1a | Header 2 | 23:23 |
| th1a | Font-size: 24px | 23:23 |
| th1a | Line-height: 28px | 23:23 |
| th1a | Font-weight: normal | 23:23 |
| th1a | Color: #333333 | 23:23 |
| th1a | Margin-top: 16px | 23:24 |
| th1a | Margin-bottom: 8px | 23:24 |
| th1a | Bam. | 23:24 |
| th1a | Page 17. | 23:24 |
| th1a | Anyhow, that's the wave of the future. | 23:24 |
| replaceafill | aelkner why did you change the h5s to h3s? | 23:24 |
| aelkner | well, ok then :) | 23:24 |
| aelkner | replaceafill, i did not | 23:24 |
| replaceafill | http://bazaar.launchpad.net/~aelkner/schooltool/modal_test/revision/2812 | 23:25 |
| replaceafill | coursesviewlet | 23:25 |
| replaceafill | .pt | 23:25 |
| th1a | But basically, if you find yourself thinking you need to add a new class for something like this, or some workaround, then that is a RED FLAG. | 23:25 |
| replaceafill | +1 | 23:25 |
| aelkner | replaceafill, those are headings within and accordion, not heading OF an accordion | 23:25 |
| aelkner | the same is true for advisory | 23:25 |
| aelkner | if they were h5s, then each would accordion, not what we want | 23:26 |
| replaceafill | i dont like h5 being higher than h3 | 23:26 |
| aelkner | we can fix that | 23:26 |
| replaceafill | i think we can screw it accidentally this way | 23:27 |
| replaceafill | please | 23:27 |
| aelkner | we can change the accordion to h3 and change all the viewlets | 23:27 |
| aelkner | and use h5 for sub-sections | 23:27 |
| aelkner | will do | 23:27 |
| replaceafill | ty | 23:27 |
| aelkner | th1a, what about my point about the top of person index.html | 23:27 |
| aelkner | we don't want that form look there anymore do we | 23:28 |
| aelkner | shouldn't that info go in the first accordion, open by default? | 23:28 |
| * replaceafill wonders why the first accordion doesnt have icon... | 23:29 | |
| aelkner | you're right, weird | 23:30 |
| th1a | Well, yes, that will be completely different. | 23:30 |
| aelkner | i didn't even see it, i guess the eye sees what it expects to see sometimes | 23:30 |
| aelkner | will be? how about right now? | 23:30 |
| th1a | Groups also has a little line above it and is indented. | 23:30 |
| replaceafill | th1a yes | 23:31 |
| replaceafill | .info-block style | 23:31 |
| replaceafill | RED FLAG ;) | 23:31 |
| th1a | aelkner: It will probably just be h1, First Name, Last Name. | 23:32 |
| th1a | But that's running ahead of the CSS work. | 23:32 |
| th1a | Which we kinda need to get replaceafill started on. | 23:32 |
| replaceafill | th1a we're doing that when we move to flourish, correct? | 23:32 |
| replaceafill | since i think flourish will restrict our css | 23:32 |
| replaceafill | because the layout | 23:33 |
| aelkner | yes, flourish will have viewlets for css local to a page | 23:33 |
| th1a | At this point I'm not particularly worried about the styling of the js work. | 23:33 |
| aelkner | registered conveniently with zcml | 23:33 |
| th1a | Aside from adding cruft and workarounds. | 23:33 |
| th1a | We want replaceafill to shift to working on changing the CSS in yvl's branch. | 23:34 |
| aelkner | well replaceafill and i were working on getting jquey-ui stuff working | 23:34 |
| aelkner | in preparation with using flourish features | 23:34 |
| aelkner | with > for | 23:35 |
| th1a | I was hoping the js handover to aelkner would be simpler. | 23:35 |
| aelkner | how do you mean? | 23:35 |
| th1a | Like, "ok aelkner, do x, y, z to turn a regular form into a modal dialog. See ya!" | 23:35 |
| th1a | Apparently it is more involved than that. | 23:36 |
| aelkner | replaceafill wanted to teach me by doing one small change at a time | 23:36 |
| aelkner | that's how we have been working this week | 23:36 |
| th1a | That something takes longer than the manager hopes is not surprising. | 23:37 |
| aelkner | besides, we were supposed to be sprinting this week | 23:37 |
| aelkner | it doesn't feel like a sprint | 23:37 |
| replaceafill | aelkner is the icons you inserted that break the styles | 23:38 |
| replaceafill | aelkner why are those needed? | 23:38 |
| th1a | If nothing else we're talking a lot more, which has certainly been helpful. | 23:38 |
| replaceafill | +1 on removing those icons | 23:38 |
| aelkner | you asked me to put them there | 23:38 |
| replaceafill | i asked you to move the text to the right ;) | 23:39 |
| aelkner | before i put them there, there were no icons | 23:39 |
| replaceafill | so we could see the icons | 23:39 |
| aelkner | oh | 23:39 |
| replaceafill | :/ | 23:39 |
| th1a | Is there something in particular that would make this feel more sprint-like, aelkner? | 23:40 |
| aelkner | a central branch that we all work with | 23:41 |
| aelkner | replaceafill, change pushed | 23:41 |
| th1a | Well, we're a little behind with that but there is still plenty to do. | 23:42 |
| replaceafill | i've been happily merging your changes aelkner | 23:42 |
| th1a | The western hemisphere has been sprinting. | 23:42 |
| aelkner | if you guys are happy, i'm happy | 23:42 |
| replaceafill | :D | 23:42 |
| th1a | I'm not unhappy. | 23:43 |
| th1a | And look -- the h2 discussion we just had was extremely important. | 23:43 |
| aelkner | i just thought we were going to be working tighted with the pther hemisphere | 23:43 |
| aelkner | tighter, other | 23:43 |
| th1a | Well, you guys weren't there this morning. | 23:43 |
| th1a | So... | 23:43 |
| replaceafill | my bad :( | 23:43 |
| replaceafill | i apologize | 23:44 |
| aelkner | i was, but the question was, 'any questions?' | 23:44 |
| th1a | Apparently you had no questions. | 23:44 |
| aelkner | i suppose, when are we all going to be working on the same branch could have been the question | 23:44 |
| aelkner | but never mind | 23:45 |
| th1a | OK, moving on. | 23:45 |
| th1a | Basically, on this pass we're not really worrying about the styling of the js widgetry. | 23:45 |
| th1a | We just want to get the parts plugged in. | 23:46 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!