| *** fsufitch has quit IRC | 00:17 | |
| *** fsufitch has joined #schooltool | 03:43 | |
| *** yvl has joined #schooltool | 07:51 | |
| *** Aiste has joined #schooltool | 08:54 | |
| *** fsufitch has quit IRC | 09:24 | |
| *** wgrant has quit IRC | 09:52 | |
| *** mgedmin has joined #schooltool | 10:44 | |
| *** balor has joined #schooltool | 11:18 | |
| *** ignas has quit IRC | 12:44 | |
| *** aelkner has joined #schooltool | 16:15 | |
| *** th1a has joined #schooltool | 16:27 | |
| th1a | good morning aelkner, yvl. | 16:30 |
|---|---|---|
| th1a | Have we seen ignas? | 16:30 |
| aelkner | morning | 16:31 |
| th1a | Well, you might as well do your update, aelkner. | 16:32 |
| aelkner | ok | 16:33 |
| aelkner | as you saw last week, i worked with douglas on the problem he had with persistence | 16:33 |
| aelkner | then this weekend, i reviewed his solution, and also reviewed his cando code changes | 16:34 |
| aelkner | he'll have to move his work to the skilldriver package, but that shouldn't take long | 16:34 |
| aelkner | i should be able to get that deployed to jelkner's machine this week week as he has hoped | 16:35 |
| aelkner | regarding the bugs assigned to me | 16:35 |
| aelkner | i looked over all the bugs, and some of them i changed to invalid becuase they were really old | 16:35 |
| aelkner | and the navagation issues were no longer valid | 16:36 |
| aelkner | one of the schooltool.gradebook bugs has to do with the identifier not being needed on the add/edit forms | 16:37 |
| aelkner | but that's really a schooltool issue becuase schooltool.gradebook uses schooltool's templates for add/edit | 16:37 |
| aelkner | so if you think i should change schooltool to no longer have this field on any form, i could do that | 16:38 |
| th1a | No, that's fine. | 16:38 |
| aelkner | no, don't change schooltool? | 16:38 |
| *** ignas has joined #schooltool | 16:38 | |
| aelkner | i mean, do we reallly need that field? | 16:39 |
| ignas | hi | 16:39 |
| th1a | Hi ignas. | 16:39 |
| ignas | sorry i'm late | 16:39 |
| aelkner | hey ignas | 16:39 |
| th1a | I would rather have it around. | 16:39 |
| aelkner | i was just discussing the identifier field on add/edit forms | 16:39 |
| aelkner | the question is: | 16:39 |
| aelkner | do we really need that field any more? | 16:39 |
| ignas | no idea, ask users ;) | 16:40 |
| aelkner | it only causes users to get confused | 16:40 |
| aelkner | jelkner submitted a bug to that effect | 16:40 |
| ignas | it's not database related, so removing it won't cause any backwards compatibility headaches | 16:40 |
| aelkner | that's true | 16:40 |
| ignas | re adding it if people complain is alse doable | 16:40 |
| *** jstraw1 has joined #schooltool | 16:41 | |
| aelkner | so i'd be happy to get rid of the field in schooltool and fix any funcitonal tests | 16:41 |
| th1a | Hm. | 16:41 |
| th1a | Well, it leaves you with a place you can park some meaningful data, but I suppose it is not a place where you can do anything useful with it. | 16:42 |
| th1a | I mean, if I'm doing courses, I like to put the course id in there. | 16:42 |
| th1a | CS-101 or whatever. | 16:42 |
| aelkner | identifiers should always be built from the name choosers | 16:42 |
| th1a | But I suppose that doesn't accomplish anything. | 16:42 |
| aelkner | doesn't the course container allow you to do what you're talking about? | 16:43 |
| * jstraw1 did not expect people talking about schooltool this morning ;) | 16:43 | |
| th1a | Also, I like to be able to make pretty URL's, which most people don't care about. | 16:43 |
| *** jstraw1 is now known as jstraw | 16:43 | |
| aelkner | hm | 16:44 |
| aelkner | well, that's your call | 16:44 |
| ignas | th1a: you being a US citizen get pretty urls for free anyway ;) | 16:44 |
| ignas | our default name choosers do it pretty well | 16:44 |
| th1a | Let's table that for the moment. We should probably change it but it doesn't seem like a priority. | 16:45 |
| th1a | What else, aelkner? | 16:45 |
| aelkner | so looking into the schooltool issue caused me to realize that sla is still not school years capable | 16:46 |
| aelkner | so i started by updating the schooltool branch in my sandbox to be up to date | 16:46 |
| aelkner | and that exposed some bugs in the sla code | 16:47 |
| aelkner | for instance | 16:47 |
| aelkner | narrative report cards are kept in the narratives container under the student's intervention container | 16:48 |
| aelkner | and the __name__ attribute of the narrative has been the section id | 16:48 |
| aelkner | i then used that to get the section from the sections container | 16:48 |
| aelkner | with school years there isn't just the one sections container | 16:48 |
| yvl | yes, but isn't the InterventionStudent re-created for each school year? | 16:49 |
| aelkner | well, i created the concept of school years for interventions even before there were school years in schooltool | 16:49 |
| aelkner | so that's one issue in itself | 16:50 |
| yvl | so the InterventionSchoolYear should be bound to SchoolTool school years | 16:51 |
| aelkner | it would make sense | 16:51 |
| yvl | and that would provide a way to unambiguously retrieve a section from narative's __name__ | 16:51 |
| yvl | ok, your're right - there's still some work to be done :) | 16:51 |
| aelkner | well, can the same section id be used in two different terms for the same school year? | 16:52 |
| ignas | yes | 16:52 |
| aelkner | so there lies the problem | 16:53 |
| yvl | good point | 16:53 |
| aelkner | unless we store the narratives in the terms container | 16:53 |
| aelkner | or in the term, that is | 16:53 |
| aelkner | side by side with the sections container | 16:54 |
| aelkner | or is the term a sections container, ic can't remember | 16:54 |
| aelkner | i just checked | 16:55 |
| aelkner | the term contains the sections container | 16:55 |
| aelkner | so it could contain the narratives container as well | 16:55 |
| ignas | yep it could | 16:55 |
| aelkner | then, then narrative itself wouldn't need to change, or the add form | 16:56 |
| aelkner | we would just need to evolve the data to move the container to the term | 16:56 |
| yvl | and what about goals/messages ? | 16:56 |
| ignas | aelkner: actually | 16:56 |
| ignas | aelkner: just change the ids | 16:56 |
| ignas | well ok, probably make it double hierarchy also | 16:57 |
| aelkner | goals/messages | 16:57 |
| ignas | app -> narrativeContainerContainer -> narrativeContainerForTerm -> Narratives | 16:57 |
| aelkner | right now it's app -> interventionsContainer -> studentInterventions -> narrativesContainer | 16:58 |
| aelkner | i'm suggesting that we should move the interventions stuff out of the root | 16:58 |
| aelkner | and put them with the school years/terms | 16:59 |
| ignas | i'd suggest you not doing it | 16:59 |
| *** replaceafill has joined #schooltool | 16:59 | |
| replaceafill | good morning everybody | 16:59 |
| aelkner | morning replaceafill | 17:00 |
| th1a | good morning replaceafill. | 17:00 |
| aelkner | ignas: what would you sugggest, then? | 17:00 |
| ignas | i mean - you have everything in place already, you only need to add one more container keyed by term | 17:00 |
| ignas | doing it the way sections work | 17:00 |
| ignas | section containers are not in terms | 17:00 |
| aelkner | they aren't? | 17:01 |
| ignas | nope | 17:01 |
| aelkner | it sure looks that way in the UI | 17:01 |
| ignas | YES | 17:01 |
| ignas | it sure does | 17:01 |
| aelkner | ah, the traversal adapter | 17:01 |
| aelkner | belies the true data structure? | 17:01 |
| ignas | yep | 17:01 |
| ignas | app['schooltool.course.section'] is a sectioncontainercontainer | 17:02 |
| ignas | keys are term int ids | 17:02 |
| ignas | so each item there is a sectioncontainer | 17:02 |
| ignas | which has all the sections | 17:02 |
| aelkner | ah, so the id of the term could be used in the narratives container container | 17:02 |
| aelkner | as you suggested above? | 17:03 |
| ignas | well, wherever it fits | 17:03 |
| aelkner | so we would need to evolve the narratives containers to insert the terms level | 17:04 |
| yvl | yes | 17:05 |
| aelkner | but this would need to happen AFTER the evolution that schooltool does to insert terms | 17:05 |
| aelkner | can we rely on schooltool's evolution to occur first, then sla's | 17:06 |
| th1a | Evolution always goes in sequence, doesn't it? | 17:06 |
| ignas | th1a: no control really | 17:07 |
| ignas | th1a: if you have 1 evolution utility | 17:07 |
| ignas | then - yes | 17:07 |
| ignas | if you have multiple | 17:07 |
| ignas | like zope, schooltool, cando | 17:07 |
| ignas | then they are executed in alphabetical order | 17:07 |
| th1a | Or am I thinking of database generations? | 17:07 |
| th1a | Or is that the same thing. | 17:07 |
| ignas | yes and yes | 17:08 |
| ignas | the problem is that I don't know at the moment | 17:08 |
| ignas | whether SLA utility or schooltool utility will get executed first | 17:08 |
| ignas | and you can't really control it | 17:08 |
| ignas | inside of each utility | 17:08 |
| ignas | it goes sequentially | 17:08 |
| aelkner | th1a: could we have yvl work on this with ignas' help? | 17:09 |
| ignas | but among utilities - zope can choose to migrate SLA before schooltool | 17:09 |
| aelkner | ignas: right now we only have on deployment of sla | 17:09 |
| aelkner | so we could use brute force | 17:10 |
| aelkner | evolve schooltool first | 17:10 |
| aelkner | then do the bzr up of sla | 17:10 |
| aelkner | and then it wold be able to evolve from there | 17:10 |
| ignas | yeah, it is possible to do it during deployment | 17:10 |
| th1a | Yes, we don't really need the right answer in this case. | 17:10 |
| ignas | so if you upgrade schooltool first | 17:10 |
| ignas | and run the application | 17:10 |
| ignas | (even if not fully functional) | 17:11 |
| ignas | and then update sla | 17:11 |
| ignas | and run the application again | 17:11 |
| aelkner | exactly | 17:11 |
| ignas | it will work | 17:11 |
| aelkner | th1a: i wanted to call you to discuss the list of bugs assigned to me after the meeting | 17:12 |
| th1a | Let's see what yvl is up to. | 17:12 |
| th1a | aelkner: Sure. I have one to discuss with you as well. | 17:12 |
| aelkner | ok, that's my report | 17:12 |
| yvl | th1a, I was sick last week, so no update from me today :| | 17:12 |
| yvl | and plan increased number of hours this week to catch up | 17:13 |
| th1a | What are you planning on working on? | 17:13 |
| th1a | Also, what about that riot in Vilnius last week? | 17:13 |
| yvl | same - report headers, a bit of sprint planning with Ignas, | 17:13 |
| yvl | then bugs | 17:13 |
| yvl | as for the riot... it was not that big :) | 17:14 |
| yvl | ~100 people, and very short | 17:14 |
| th1a | Ah. | 17:14 |
| yvl | and 7000 watching and shouting ;) | 17:14 |
| th1a | One of those. | 17:14 |
| aelkner | sounds like a soccer game :) | 17:14 |
| yvl | still, it's the biggest in years.. :) | 17:14 |
| yvl | yes | 17:14 |
| yvl | they played with tear gas balls a bit :) | 17:15 |
| yvl | throwing back to police :) | 17:15 |
| aelkner | what was the issue? | 17:15 |
| yvl | taxes, basically | 17:15 |
| ignas | and salaries | 17:16 |
| yvl | they were increased as a counter-measure for the crisis | 17:16 |
| th1a | Once again th1a distracts his employees from the task at hand. | 17:16 |
| yvl | we don't mind ;) | 17:16 |
| th1a | I have to discipline myself. | 17:16 |
| aelkner | i'll stop asking questions | 17:16 |
| th1a | ignas? | 17:16 |
| ignas | nothing too much | 17:16 |
| ignas | sprint planning | 17:16 |
| ignas | refactoring import/export even more | 17:16 |
| ignas | and made a passport | 17:17 |
| th1a | On your laser printer? | 17:17 |
| yvl | [me too] | 17:17 |
| ignas | which took me most of 2 days | 17:17 |
| ignas | (had to go home, which is 3+ hour trip on a buss) | 17:17 |
| ignas | *bus | 17:17 |
| ignas | and go back when i had a passport | 17:17 |
| th1a | We need to beat out a finalish proposal for the sprint. | 17:17 |
| ignas | but did some refactoring while at home | 17:17 |
| th1a | I just have to go to the post office for a passport, which is convenient, except when I'm trying to mail a letter and half my neighborhood is trying to get a passport. | 17:18 |
| ignas | well - if i had my own flat in Vilnius | 17:19 |
| ignas | i'd not have to go anywhere far | 17:19 |
| ignas | but legaly i am still living with my parents | 17:19 |
| yvl | you can always register as homeless :) | 17:19 |
| th1a | Here every conversation is like "No, you need your birth certificate from the Dominican Republic." | 17:19 |
| ignas | and yeah - i don't really want to register as a "person without defined place of habitation" | 17:20 |
| th1a | Can't you just get a Great Wildlands passport? | 17:20 |
| ignas | :P | 17:20 |
| th1a | What's the next step in beating out a sprint plan? | 17:20 |
| ignas | but new Lithuanian passports are awesome | 17:20 |
| ignas | th1a: seeing if we can really do it | 17:21 |
| ignas | th1a: I'll have yvl estimate how long some of the things would take him to do | 17:21 |
| ignas | also see if I know all the details that can bite us | 17:21 |
| ignas | and come up with some degradation plan | 17:21 |
| ignas | for safety | 17:21 |
| ignas | don't want to get stuck with a table querying mechanism that we spend 3 days implementing without finishing it | 17:22 |
| th1a | OK. | 17:22 |
| th1a | replaceafill: How are you doing? | 17:23 |
| ignas | oh yeah | 17:23 |
| ignas | i'll be reviewing replaceafill's branch | 17:23 |
| ignas | this week | 17:23 |
| ignas | too | 17:23 |
| replaceafill | i guess i'm almost done with the integration | 17:23 |
| aelkner | replaceafill: you got my note? | 17:23 |
| replaceafill | i just need to move some code around in cando | 17:23 |
| replaceafill | aelkner, yes, i agree | 17:24 |
| replaceafill | aelkner, external activities feel more natural in the skilldriver package | 17:24 |
| replaceafill | 1 extact for 1 skilldriver | 17:24 |
| aelkner | yes | 17:24 |
| aelkner | jelkner agreed that external activities were only necessary for skill drivers | 17:25 |
| aelkner | not for the sections themselves | 17:25 |
| replaceafill | i also wanted to ask, can i have some bug assigned, maybe one from the gradebook package? | 17:25 |
| replaceafill | i mean i got familiar with the package and i'd like to continuing working | 17:25 |
| aelkner | th1a: if i'm going to be making extensive changes to schooltool.gradebook this quarter | 17:26 |
| th1a | Here's a meta-bug: make the SchoolTool gradebook more consistent with the CanDo gradebook UI. | 17:26 |
| aelkner | i was going to discuss this with you later | 17:27 |
| th1a | Yes. | 17:27 |
| aelkner | but for now, could we keep the gradebook on my plate | 17:27 |
| aelkner | and not get involved with too many cooks? | 17:27 |
| replaceafill | :) | 17:27 |
| th1a | Not really. | 17:27 |
| th1a | It'll be ok. | 17:27 |
| aelkner | i see many hours reolving conflicts in my future | 17:28 |
| th1a | We'll keep it straight. | 17:29 |
| aelkner | the first thing i want to do is merge replaceafill's branch to the trunk | 17:29 |
| th1a | One thing that might help is not planning things on the phone. | 17:29 |
| aelkner | or is ignas the gatekeeper there as well | 17:30 |
| ignas | aelkner: yep | 17:30 |
| ignas | aelkner: i'll look at his branch first anyway | 17:30 |
| ignas | aelkner: want to see what he did | 17:30 |
| th1a | Which trunk? | 17:30 |
| th1a | CanDo? | 17:30 |
| th1a | BOth? | 17:30 |
| aelkner | schooltool.gradebook trunk | 17:30 |
| aelkner | and cando, of course | 17:30 |
| aelkner | but i'm the gatekeep for cando, not ignas, right? | 17:31 |
| th1a | As far as I know. | 17:31 |
| aelkner | ignas: how soon will you be able to do the merge? | 17:32 |
| ignas | aelkner: don't know, depends on how good replaceafill code is | 17:33 |
| replaceafill | ignas, if u find code that u don't like, u send me an email and i fix it? | 17:34 |
| ignas | yeah | 17:34 |
| replaceafill | ignas, cool | 17:34 |
| th1a | OK... | 17:34 |
| * th1a drops the bag of gravel. | 17:34 | |
| aelkner | th1a: shall i call now? | 17:35 |
| th1a | aelkner: Let's try continuing our discussion here. | 17:35 |
| th1a | If we're worried about coordination, having the two of us talking on the phone doesn't help. | 17:35 |
| aelkner | so did you and jelkner discuss the gradebook when you saw each other? | 17:35 |
| th1a | Actually, we didn't have time. | 17:36 |
| aelkner | i kind of figured becuase i didn't see any new gradebook bugs | 17:36 |
| th1a | Anything else about the existing bugs? | 17:36 |
| aelkner | first, could you please look over the one that i changed to fix commited and close them out if you think they're ready | 17:37 |
| aelkner | ones | 17:37 |
| th1a | Um... | 17:39 |
| th1a | So, like, 148503 (broken link permissions)... what's going on with it? | 17:40 |
| th1a | Adding a comment to the bug would help. | 17:40 |
| aelkner | ok, i'll do that now | 17:41 |
| aelkner | comment added | 17:42 |
| aelkner | th1a: for bug 284100, i could add an event handler for section add to create a single worksheet called 'Default' | 17:45 |
| th1a | Is https://bugs.edge.launchpad.net/schooltool/+bug/160567 released? | 17:45 |
| aelkner | a while back, yes | 17:45 |
| aelkner | i just didn't get around to changeing the bug status | 17:45 |
| th1a | Is https://bugs.edge.launchpad.net/schooltool/+bug/80001 fixed and released? | 17:46 |
| ignas | replaceafill: ouch, you did a very interesting thing with branches | 17:46 |
| th1a | uh oh | 17:47 |
| replaceafill | ignas, ? | 17:47 |
| *** fsufitch has joined #schooltool | 17:47 | |
| ignas | replaceafill: well - instead of branching gradebook | 17:47 |
| ignas | replaceafill: you seem to have created an empty bzr branch and pulled gradebook trunk into your branch | 17:47 |
| aelkner | i thought something looked strange when i viewd the branch on-line | 17:48 |
| ignas | replaceafill: will see how I can fix it | 17:48 |
| replaceafill | ignas, anyway I can fix it? | 17:48 |
| replaceafill | i can branch trunk | 17:49 |
| replaceafill | and make my changes there | 17:49 |
| replaceafill | i thought i would need my own branch | 17:49 |
| ignas | replaceafill: will take you more time, and will lose the history | 17:49 |
| ignas | replaceafill: i'll look at it | 17:49 |
| th1a | For 284100 I'd like to create default sheets that correspond to terms in the active year. | 17:50 |
| aelkner | hm | 17:51 |
| aelkner | the gradebook is traversed from a section | 17:51 |
| aelkner | i don't see how we could have cross-term grading | 17:51 |
| th1a | Oh, right. | 17:51 |
| ignas | th1a: i'd think terms and sheets should be separate things | 17:51 |
| aelkner | but i could name the default worksheet to be the name of the term that the section belongs to | 17:52 |
| th1a | Sure. | 17:52 |
| th1a | We're really going to have to get linking going between multi-term sections. | 17:53 |
| th1a | That seems like a must for 1.0. | 17:54 |
| aelkner | strikly speaking shooltool doesn't allow for multi-term sections | 17:54 |
| ignas | yeah, sorry about stalling that, will nudge up in my priority list | 17:54 |
| aelkner | becuase sections go in the term | 17:54 |
| ignas | aelkner: you still can connect sections | 17:54 |
| th1a | Right, so we're just going to let them know they're all part of a larger whole. | 17:54 |
| aelkner | ignas: explain 'connect sections' | 17:55 |
| ignas | aelkner: add attributes "previous" and "next" to a section | 17:55 |
| ignas | and when you need to display a gradebook view | 17:55 |
| ignas | you can add links to the sections from the previous terms | 17:55 |
| ignas | so even if you have more than 1 section, you still can aggregate them in views if that is more convenient for your users | 17:56 |
| ignas | as long as they are linked during term initialization | 17:56 |
| aelkner | ignas: are you suggesting that i change sections in schooltool to have two new attributes? | 17:57 |
| th1a | We're not suggesting you do it at this point. | 17:57 |
| aelkner | i see, down the road | 17:57 |
| ignas | aelkner: no, i am suggesting that i should have done that a couple weeks ago, but got too involved with export/import and sprint | 17:57 |
| th1a | But we do need it soonish. | 17:57 |
| ignas | and the Christmas stuff | 17:57 |
| ignas | so more like a month ago | 17:58 |
| th1a | Otherwise, you can't do, say a sane end of year report card. | 17:58 |
| aelkner | we could discuss this at the upcoming sprint | 17:58 |
| th1a | It's already all planned out. | 17:58 |
| aelkner | could you give me link to the planning doc? | 17:59 |
| th1a | It might be in ignas's brain. | 17:59 |
| aelkner | oh, that doc :) | 17:59 |
| aelkner | once again, the upcoming sprint could be a good time to do some mind-share on the subject | 18:00 |
| th1a | We had to have a plan for this when we came up with the new term implementation. | 18:00 |
| ignas | 1.1.11 TODO Make Add new term give an option of copying sections | 18:00 |
| ignas | * Make this operation link new sections to old sections | 18:00 |
| ignas | also Show linked sections in the UI and make schooltool.lyceum.journal use this information. | 18:00 |
| th1a | We either had to create multi-term sections, or a way to link single term sections into a larger, um, super-section. | 18:01 |
| aelkner | sounds scary | 18:01 |
| th1a | It is the simpler approach. | 18:02 |
| ignas | aelkner: the linking bit is simple, I just have to do the "copying" and the "give option to copy" bits | 18:02 |
| th1a | I mean, in the gradebook case, you either need a gradebook that juggles different terms, or separate term gradebooks that know the others exist. | 18:02 |
| aelkner | the second option is the simplest to implement | 18:03 |
| th1a | Indeed. | 18:03 |
| th1a | Actually, replaceafill, here's a thought. | 18:03 |
| replaceafill | th1a, yes? | 18:03 |
| th1a | Can you implement gradebook activities as "external" to other gradebooks? | 18:04 |
| th1a | That is, instead of Cando -> SchoolTool, SchoolTool > SchoolTool? | 18:04 |
| aelkner | th1a: ? | 18:05 |
| aelkner | cando is a schooltool plug-n | 18:05 |
| aelkner | like sla | 18:05 |
| th1a | To import a score from another worksheet or gradebook? | 18:05 |
| th1a | Into another? | 18:05 |
| aelkner | oh | 18:06 |
| replaceafill | interesting | 18:06 |
| th1a | Actually, it is probably broadly necessary. | 18:06 |
| replaceafill | th1a, with the "Update Grades" mechanism? | 18:07 |
| th1a | Yes. | 18:07 |
| th1a | I think... | 18:07 |
| th1a | It is a bit of a CanDo workaround, but it is probably safer in general. | 18:08 |
| replaceafill | th1a, i could give it a shot :) | 18:08 |
| th1a | OK. Take a look at it. Hopefully now that you've set up the utilities, etc. once, doing it again won't be too hard. Really. ;-) | 18:09 |
| replaceafill | :) | 18:09 |
| th1a | OK, so aelkner -- do the default page thing. | 18:10 |
| th1a | As I mentioned earlier, making the SchoolTool gradebook more consistent with the CanDo gradebook is a broadly defined bug. | 18:12 |
| aelkner | th1a: you mean css/js type stuff? | 18:12 |
| th1a | I mean from the user's point of view. | 18:13 |
| aelkner | well, schooltool.gradebook users don't deal with competencies | 18:14 |
| aelkner | so you'll need to be more specific | 18:14 |
| *** alga has joined #SchoolTool | 18:14 | |
| th1a | Well, for example, after a person changes a score in the CanDo gradebook, the cell turns green, right? | 18:15 |
| th1a | Does the SchoolTool gradebook do that? | 18:15 |
| aelkner | css/js, as i was saying | 18:15 |
| aelkner | it would work differently of course | 18:16 |
| aelkner | as gradebook activities have varying score systems | 18:16 |
| aelkner | whereas cando has just the one | 18:16 |
| th1a | OK, but I'm not talking about the css/js code per se, although ideally we can share more. | 18:16 |
| th1a | I'm saying we want a consistent user experience. | 18:17 |
| aelkner | cando is not dependent on schooltool.gradebook, so any code share would have to happen in schooltool itself | 18:17 |
| aelkner | but i understand the point | 18:17 |
| aelkner | i could proceed with copying/tailoring code from cando into schooltool.gradebook | 18:18 |
| aelkner | and not worry about sharing at first | 18:18 |
| th1a | So basically, either you can go through two interfaces yourself and come up with a set of changes, or I can and tell you what to do. But you're a lot more familiar with both of them than I am anyhow. | 18:20 |
| th1a | I think it will be more efficient for you to come up with a plan yourself. | 18:20 |
| aelkner | i'll figure it out. could you please create a bug for this and assign to me | 18:20 |
| th1a | You might want to subsequently make a bunch of related sub-bugs for the specific issues. | 18:22 |
| th1a | But basically you | 18:22 |
| th1a | are moving CanDo improvements to SchoolTool gradebook, since CanDo's has gotten way more attention. | 18:22 |
| th1a | Focus on the most common use cases. | 18:23 |
| th1a | I'm adding scores > how are they different? | 18:23 |
| aelkner | the only one that comes to mind is the score validation | 18:23 |
| aelkner | the role-ever competency to see its title is not relevant | 18:24 |
| th1a | Why not? | 18:24 |
| th1a | Don't activities have titles? | 18:24 |
| aelkner | yes, and they appear already | 18:25 |
| th1a | In the same way? | 18:25 |
| aelkner | as the column heading | 18:25 |
| aelkner | it's not the same issue | 18:25 |
| th1a | Didn't we have to narrow them? | 18:25 |
| aelkner | in schooltool.gradebook | 18:25 |
| aelkner | the use selects the activity title | 18:25 |
| aelkner | in cando, the competncies titles are really long, selected by the state of virginia | 18:26 |
| aelkner | but, no, we didn't narrow the titles | 18:26 |
| th1a | I need to get my fake gradebook up to speed. | 18:26 |
| th1a | It is going to have to work exactly the same way in SchoolTool. | 18:27 |
| aelkner | i was hoping you would be asigning me many gradebook bugs after discussing with jelkner | 18:27 |
| th1a | Well, here's a bug: columns have to be of uniform width regardless of the length of the title. | 18:28 |
| th1a | And you have to be able to mouse over the title to get the whole thing. | 18:28 |
| aelkner | makes sense | 18:28 |
| aelkner | so there's really just the two features | 18:29 |
| aelkner | 1) js score validation | 18:29 |
| aelkner | 2) fixed-width columns with roll-over titles | 18:29 |
| aelkner | could you please create one bug for each? | 18:30 |
| aelkner | and assign to me | 18:30 |
| th1a | Sure. | 18:31 |
| *** balor has quit IRC | 18:31 | |
| aelkner | thanks | 18:31 |
| aelkner | ignas: i want to get into the spirit of this whole feature branch concept | 18:31 |
| replaceafill | th1a, could I ask for a blueprint for the schooltool -> schooltool external activities task? | 18:32 |
| aelkner | could you please give me the exact command i'd use to create a feature branch of schooltool, for instance | 18:32 |
| aelkner | commnads | 18:32 |
| aelkner | i mean, first i branch using bzr branch | 18:32 |
| aelkner | then i need to push, right? | 18:33 |
| ignas | bzr branch http://staging.schooltool.org/bzr2/schooltool/schooltool/trunk/ | 18:33 |
| ignas | and then you just work there | 18:33 |
| ignas | and bzr push it to launchpad | 18:33 |
| ignas | when you want me to see what you have done | 18:33 |
| ignas | though - people in #bzr could explain it in more detail | 18:33 |
| replaceafill | ignas, is this the same i should have done? | 18:34 |
| aelkner | well, i think i could figure it out from using you sandbox instructions | 18:34 |
| ignas | replaceafill: yep | 18:34 |
| th1a | aelkner: What about fill-down? | 18:34 |
| aelkner | replaceafill: remember ignas' sandbox instructions? | 18:34 |
| aelkner | th1a: ah, fill-down | 18:35 |
| aelkner | you want that, too? | 18:35 |
| aelkner | remember, cando really needs that becuase of the millions of comps to score | 18:35 |
| th1a | This is what I mean by consistent user experience. | 18:35 |
| th1a | I want them to work the same way. | 18:36 |
| replaceafill | aelkner, no, could u share the url? | 18:36 |
| aelkner | th1a: agreed, that could be third bug | 18:36 |
| aelkner | replaceafill: http://ignas.pov.lt/setting_up_bzr_schooltool_sandbox.html | 18:36 |
| th1a | That should be enough to get you started... | 18:36 |
| replaceafill | aelkner, thanks | 18:37 |
| aelkner | th1a: indeed | 18:37 |
| aelkner | replaceafill: look at the section 'Publish you changes' | 18:37 |
| aelkner | this is where you [push your branch to launchpad so that ignas can then merge to trunk at his convenience | 18:38 |
| aelkner | it would be a good idea to name the branch you publish with a hint as to the feature | 18:38 |
| replaceafill | aelkner, wow cool | 18:38 |
| replaceafill | aelkner, ok | 18:38 |
| replaceafill | branch_feature | 18:39 |
| aelkner | let's consider your schooltool.gradebook integration work | 18:39 |
| aelkner | first you branch the schooltool.gradebook trunk | 18:40 |
| aelkner | then you make yoru changes | 18:40 |
| aelkner | then you publish it to say: | 18:40 |
| aelkner | bzr push lp:~douglas/schooltool/schooltool.gradebook_integration_feature | 18:40 |
| aelkner | if douglas is indeed you lp account name | 18:41 |
| replaceafill | :) | 18:41 |
| aelkner | ignas: does replaceafill have access to do this? | 18:42 |
| ignas | aelkner: yeah, he should, i mean - schooltool branches are public | 18:42 |
| aelkner | ignas: as long as he does it in his folder, right? | 18:43 |
| aelkner | i.e., lp:~replacefil/... | 18:43 |
| replaceafill | ignas, should i push a new schooltool.gradebook branch using this method? | 18:43 |
| replaceafill | ignas, and leave the old one? | 18:44 |
| *** wgrant has joined #schooltool | 18:46 | |
| aelkner | ignas, th1a: do we agree that i'm going to remove the identifier field from the add form in schooltool skin? | 18:47 |
| th1a | Um... I'm ambivalent. | 18:48 |
| ignas | replaceafill: well - i am reviewing your branch at the moment, so no need really, but you can try to see how it goes | 18:48 |
| th1a | aelkner: I'd rather you work on the gradebook. | 18:50 |
| aelkner | ok | 18:51 |
| ignas | replaceafill: why did you pick the named utility approach instead of named adapters? | 18:56 |
| aelkner | ignas: that was my suggestion | 18:57 |
| aelkner | explain to me how one could get it done with adapters | 18:57 |
| ignas | well getAdaptersFor((section, ), IExternalActivities) | 18:58 |
| aelkner | the problem at hand is | 18:58 |
| aelkner | hm | 18:59 |
| replaceafill | should i change it to use adapters? | 19:00 |
| aelkner | well, my thinking was that the user was going to decide which external activities to 'publish' | 19:00 |
| aelkner | you can't do that with adapters | 19:00 |
| ignas | ok, sorry, must run now, will write an email probably | 19:01 |
| aelkner | but since we decided that all skilldrivers are to be published automatically | 19:01 |
| aelkner | maybe adapters would work after all | 19:01 |
| aelkner | replaceafill: and it would simplify your code i think | 19:02 |
| aelkner | becuase you would remove the utility step | 19:02 |
| replaceafill | yes | 19:02 |
| aelkner | i just always considered adapter to be something that works automatically | 19:02 |
| aelkner | and utilities to be something more client-based | 19:02 |
| replaceafill | aelkner, want me to change it? | 19:03 |
| aelkner | you're going to create a new branch, right? | 19:03 |
| replaceafill | sure | 19:04 |
| aelkner | so why don't you do the adpater thing there, and keep your other branch around for comparison | 19:04 |
| replaceafill | ah ok | 19:04 |
| aelkner | the cando part is small enough that it won't take long to change back to utilities if we decide we need it | 19:05 |
| replaceafill | yes | 19:05 |
| replaceafill | just 1 component should be change in cando | 19:05 |
| aelkner | i suppose, that even outside of cando, where we are safe to assume all skill drivers are available as extacts | 19:06 |
| aelkner | if a different plug-in wants to publish | 19:06 |
| aelkner | external activities | 19:06 |
| aelkner | and it is not so automatic, but rather, under user control | 19:06 |
| aelkner | it could be the responsibility of that plug-in | 19:06 |
| replaceafill | yes | 19:07 |
| aelkner | to know how to deliver the extacts using the user choices | 19:07 |
| aelkner | so i think ignas is right | 19:07 |
| replaceafill | aelkner, did u check the way i handle jelkner' | 19:08 |
| replaceafill | s request | 19:08 |
| aelkner | which one? | 19:08 |
| replaceafill | of not having the same extact twice | 19:08 |
| replaceafill | i dont like that part :( | 19:08 |
| aelkner | i saw that you throw and exception, right? | 19:08 |
| replaceafill | i takes all the activities in the worksheet and compares their title | 19:09 |
| replaceafill | schooltool.gradebook.browser.activity | 19:09 |
| replaceafill | ExternalActivityAddView | 19:09 |
| replaceafill | def activityExists | 19:10 |
| aelkner | yeah, it looks good to me | 19:11 |
| aelkner | did you test it? | 19:11 |
| replaceafill | yes | 19:11 |
| aelkner | good | 19:12 |
| replaceafill | browser/README.txt -> line 1025 | 19:12 |
| aelkner | i see | 19:13 |
| aelkner | so all's well on that front | 19:13 |
| replaceafill | :) | 19:13 |
| replaceafill | i'm going to move cando's code to the skilldriver package today | 19:13 |
| *** ignas has quit IRC | 19:19 | |
| replaceafill | aelkner, just sent u the new diff | 20:23 |
| *** replaceafill has quit IRC | 20:35 | |
| *** mgedmin has quit IRC | 21:02 | |
| *** alga has quit IRC | 21:31 | |
| *** jelkner has joined #schooltool | 22:12 | |
| *** replaceafill has joined #schooltool | 22:41 | |
| jelkner | hola | 22:42 |
| *** jelkner has quit IRC | 23:12 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!