| *** bskahan has quit IRC | 00:17 | |
| *** bskahan has joined #schooltool | 00:21 | |
| *** bskahan has quit IRC | 01:16 | |
| *** bskahan has joined #schooltool | 01:26 | |
| *** JStrike has joined #schooltool | 01:43 | |
| *** JStrike has left #schooltool | 01:43 | |
| *** bskahan has quit IRC | 01:48 | |
| *** bskahan has joined #schooltool | 01:54 | |
| *** munkee_ has joined #schooltool | 02:05 | |
| *** munkee has quit IRC | 02:05 | |
| *** munkee_ has quit IRC | 02:15 | |
| *** munkee has joined #schooltool | 02:18 | |
| *** bskahan has quit IRC | 02:20 | |
| *** bskahan has joined #schooltool | 02:23 | |
| *** tvon has quit IRC | 04:48 | |
| *** th1a has joined #schooltool | 04:51 | |
| *** bskahan has quit IRC | 05:28 | |
| *** bskahan has joined #schooltool | 08:28 | |
| *** tvon has joined #schooltool | 08:49 | |
| *** bskahan has quit IRC | 09:24 | |
| *** bskahan has joined #schooltool | 09:26 | |
| povbot` | /svn/commits: * bskahan committed revision 3969: | 09:40 |
|---|---|---|
| povbot` | /svn/commits: you can schedule sections in time periods now. | 09:40 |
| povbot` | /svn/commits: * bskahan committed revision 3970: | 09:52 |
| povbot` | /svn/commits: removing a marker XXX | 09:52 |
| *** bskahan has quit IRC | 09:59 | |
| povbot` | /svn/commits: * bskahan committed revision 3971: | 10:00 |
| povbot` | /svn/commits: fleshing out unit tests | 10:00 |
| *** bskahan has joined #schooltool | 10:02 | |
| *** SteveA_ has joined #schooltool | 10:10 | |
| *** SteveA has quit IRC | 10:11 | |
| *** SteveA_ is now known as SteveA | 10:28 | |
| *** bskahan has quit IRC | 10:36 | |
| *** bskahan has joined #schooltool | 10:38 | |
| *** thisfred has joined #schooltool | 11:01 | |
| *** bskahan has quit IRC | 11:01 | |
| povbot` | /svn/commits: * bskahan committed revision 3972: | 11:03 |
| povbot` | /svn/commits: add a cancel button to the section schedule form | 11:03 |
| *** SteveA_ has joined #schooltool | 12:16 | |
| *** SteveA has quit IRC | 12:17 | |
| *** SteveA_ is now known as SteveA | 12:17 | |
| povbot` | /svn/commits: * gintas committed revision 3973: | 13:25 |
| povbot` | /svn/commits: Added functional tests for CSV import, and a few other things along the way. | 13:25 |
| *** gintas has joined #schooltool | 13:26 | |
| *** bskahan has joined #schooltool | 13:32 | |
| *** bska|mobile has joined #schooltool | 13:55 | |
| *** bskahan has quit IRC | 13:57 | |
| *** gintas has quit IRC | 14:11 | |
| povbot` | /svn/commits: * gintas committed revision 3974: | 14:16 |
| povbot` | /svn/commits: Fixed places in SchoolTool templates which were throwing i18n deprecation warnings, at least the ones revealed by functional tests. | 14:16 |
| *** alga has joined #SchoolTool | 14:17 | |
| *** gintas has joined #schooltool | 14:17 | |
| povbot` | /svn/commits: * bskahan committed revision 3975: | 14:22 |
| povbot` | /svn/commits: added a Welcome to SchoolTool index page. | 14:22 |
| povbot` | /svn/commits: I left ttschema and term links off intentionally because I don't think they're going to be what people are trying to access often (probably just once a year). | 14:22 |
| povbot` | /svn/commits: Side note, as soon as we have a sitewide configuration option, the "Welcome to SchoolTool" should probably be a configurable string. | 14:22 |
| *** ignas has joined #schooltool | 14:35 | |
| povbot` | /svn/commits: * gintas committed revision 3976: | 14:38 |
| povbot` | /svn/commits: A few more missing i18n:translates. | 14:38 |
| povbot` | /svn/commits: * gintas committed revision 3977: | 14:39 |
| povbot` | /svn/commits: Added missing i18n:translate attributes. | 14:39 |
| povbot` | /svn/commits: * gintas committed revision 3978: | 14:48 |
| *** gintas_ has joined #schooltool | 14:48 | |
| povbot` | /svn/commits: Some more of those pesky i18n:translates. Functional tests pass cleanly now, provided that you're testing SchoolTool trunk with SchoolBell's trunk. | 14:48 |
| povbot` | /svn/commits: Jinty, I think it would be nice to backport the fixes to SchoolBell templates to the 1.1.x branch. I don't think they could possibly introduce a bug, but it's your call. Those warnings really annoy me ;) | 14:48 |
| *** gintas has quit IRC | 14:54 | |
| *** Aiste has joined #schooltool | 15:28 | |
| bska|mobile | http://www.schooltool.org/Members/bskahan/sc-ui-stories | 15:28 |
| bska|mobile | some current thought on UI improvments | 15:28 |
| *** gintas_ has quit IRC | 15:37 | |
| *** bska|mobile has quit IRC | 15:44 | |
| *** bskahan has joined #schooltool | 15:49 | |
| povbot` | /svn/commits: * ignas committed revision 3979: | 16:28 |
| povbot` | /svn/commits: A fix for issue 197. | 16:28 |
| *** gintas_ has joined #schooltool | 16:50 | |
| *** bska|mobile has joined #schooltool | 17:05 | |
| *** bskahan has quit IRC | 17:05 | |
| *** mgedmin has joined #schooltool | 17:13 | |
| gintas_ | bska|mobile, tvon, are you there? | 17:42 |
| gintas_ | I have a question regarding timezones | 17:42 |
| bska|mobile | gintas_: hey | 17:43 |
| gintas_ | in the calendar views, when should I combine datetimes with UTC and when with self.timezone? | 17:44 |
| povbot` | /svn/commits: * bskahan committed revision 3980: | 17:44 |
| povbot` | /svn/commits: make overlay portlet use labels for sections. fixes http://issues.schooltool.org/issue244 | 17:45 |
| gintas_ | to be more precise, what kind of datetimes should the calendarRows() method return? | 17:45 |
| gintas_ | in UTC or in the user's timezone | 17:45 |
| gintas_ | ? | 17:45 |
| mgedmin | srichter, can you mail me your publish SSH key? (gpg-signed mail preferred) | 17:45 |
| bska|mobile | gintas_: I set the preferences in the view immediately if they exist and default to UTC if the principal doesn't have perferences so (iirc) you have view.timezone and you apply that to all times | 17:46 |
| gintas_ | well, in schoolbell.app.browser.cal.DailyCalendarView.calendarRows you have this line: | 17:47 |
| gintas_ | today = datetime.combine(self.cursor, time(tzinfo=utc)) | 17:47 |
| gintas_ | so I'm wondering, is this right? | 17:47 |
| bska|mobile | no, it probably should be combine(seld.cursor, time(tzinfo=self.timezone) | 17:48 |
| bska|mobile | looking now | 17:48 |
| gintas_ | I have implemented viewing by periods and have overridden the method | 17:48 |
| gintas_ | there are more instances of the same thing there | 17:48 |
| gintas_ | since you did the timezones, could you perhaps take a look? Shouldn't be too hard (see browser/cal.py in SchoolTool) | 17:49 |
| * bska|mobile nods | 17:49 | |
| bska|mobile | I need to for 242 | 17:49 |
| mgedmin | (meeting time) | 18:00 |
| * tvon yawns | 18:00 | |
| th1a | Hi all. | 18:00 |
| gintas_ | hi | 18:00 |
| bska|mobile | hello | 18:00 |
| th1a | I got back in town late last night, so I'm still a bit behind on the precise status of things. | 18:01 |
| th1a | bskahan: How do things look from your perspective? | 18:02 |
| bska|mobile | pretty good, I got the browser view for adding timetables to sections done | 18:03 |
| bska|mobile | after I finished it I thought of a better UI for it, but its fully functional and not ugly | 18:04 |
| th1a | Sorry about the confusion about that. | 18:04 |
| ignas | hi | 18:04 |
| * bska|mobile nods | 18:04 | |
| th1a | So are there any other loose ends from Etria's perspective? | 18:04 |
| bska|mobile | issue242 | 18:05 |
| tvon | that should be it | 18:05 |
| bska|mobile | timezone aware events rendering incorrectly | 18:05 |
| bska|mobile | I think is impacting gintas's bug | 18:05 |
| bska|mobile | as far as I know that's it | 18:05 |
| th1a | Do we know the underlying cause of the bug? | 18:05 |
| tvon | I don't | 18:06 |
| bska|mobile | I think gintas just pointed it out | 18:06 |
| * mgedmin looks at the bug | 18:06 | |
| bska|mobile | looking into it | 18:07 |
| th1a | So the date is being stored correctly but not displayed right? | 18:07 |
| bska|mobile | right | 18:07 |
| bska|mobile | we're going to work on it right after the meeting | 18:08 |
| th1a | OK. We'd better not take time on it right this second. | 18:08 |
| th1a | How do things look from Vilnius? | 18:08 |
| gintas_ | I finished the CSV import | 18:09 |
| gintas_ | basically had to rewrite it because the format changed completely | 18:09 |
| ignas | I am working on Seting of default schema in schema container view | 18:09 |
| bska|mobile | gintas_: its much nicer now | 18:09 |
| ignas | deleting ofschemas must be handled so it's in my list of tasks | 18:09 |
| ignas | and the last one is writing some functional tests for shceduling of a student | 18:09 |
| ignas | then i guess i'll look for bugs in roundup | 18:10 |
| alga | ;-) | 18:10 |
| mgedmin | there are some loose ends | 18:10 |
| mgedmin | e.g. the interaction of timetables and timezones | 18:11 |
| ignas | the list in roundup is way too long, and someone with the authority to do so should up the bugs that must be fixed untill release as critical | 18:11 |
| alga | actually, the should be marked with a release tag | 18:11 |
| th1a | We should probably spend the rest of the time sorting bugs. | 18:12 |
| th1a | I think we should just go down the list together, because looking at it independently while on IRC seems muddled. | 18:13 |
| gintas_ | I'm working on #241 | 18:13 |
| th1a | We should get all these bugs assigned to the appropriate people. | 18:14 |
| ignas | what about 245 ? | 18:14 |
| th1a | OK, so 241 assigned to gintas? | 18:15 |
| bska|mobile | ignas: there wasn't consensus on how to handle that | 18:15 |
| bska|mobile | I like the idea of forcing at the container level | 18:15 |
| * mgedmin downgrades 235 ("add" button in container views) to wish | 18:15 | |
| ignas | well a user can't remove a section from his overlay at the moment so it should get fixed untill release | 18:15 |
| ignas | mgedmin, thank you | 18:16 |
| ignas | i have postponed it because well - it should go into schoolbell | 18:16 |
| * mgedmin downgrades 237 (adaptation to ISchoolToolApplication) to wish | 18:16 | |
| bska|mobile | sections can be deleted from the SectionContainer and sections are removed from instructors overlays when the instructor is removed from the section | 18:16 |
| ignas | bska|mobile, how does one get into SectionContainer view ? | 18:17 |
| th1a | ignas: Courses are rarely removed. In this release, just deleting sections makes more sense. | 18:17 |
| bska|mobile | ignas: good point | 18:18 |
| * mgedmin marks 141 (timezone in iCalendar files) as resolved | 18:18 | |
| th1a | bska|mobile: What do you mean by "forcing at the container level." | 18:18 |
| bska|mobile | th1a: I was working on browser view code to delete sections from the ContainerDelete view, ignas pointed out that that didn't handle RESTive deletion | 18:19 |
| mgedmin | bska|mobile, event handlers? | 18:19 |
| * bska|mobile nods | 18:19 | |
| bska|mobile | IObjectRemovedEvents | 18:19 |
| alga | +1 | 18:20 |
| bska|mobile | I was trying to override the __delitem__ method in the container, but that was dumb | 18:20 |
| mgedmin | why? | 18:20 |
| bska|mobile | doing it on event handlers seems less likely to be circumvented | 18:21 |
| *** jinty has joined #schooltool | 18:21 | |
| th1a | Who gets #246? | 18:21 |
| mgedmin | hi, jinty | 18:21 |
| bska|mobile | I'm not sure that the __delitem__ way wouldn't have worked, but I got sidetracked with the section/timetable UI | 18:21 |
| th1a | jinty: Hi. | 18:21 |
| alga | it would have | 18:22 |
| mgedmin | bska|mobile, I think either __delitem__ or event handlers would work equally well | 18:22 |
| * jinty hates #$@%$ hardware #%%$# ndiswrapper %##$% cafe wlan!!!! | 18:22 | |
| mgedmin | I think the primary difference is the setup necessary in unit tests | 18:22 |
| alga | but events is a cleaner way to plug in such policy-making functionality | 18:22 |
| bska|mobile | mgedmin: ok, maybe I'll finish the __delitem__ code then | 18:22 |
| mgedmin | not sure which one would be easier to test | 18:22 |
| bska|mobile | hi jinty | 18:22 |
| mgedmin | err, not test, I meant, not sure which one would require larger test fixtures | 18:23 |
| jinty | hi all | 18:23 |
| * bska|mobile nods | 18:23 | |
| * jinty catches up on logs | 18:23 | |
| gintas_ | th1a, I have fixed #246 | 18:24 |
| bska|mobile | the next question is, is 245 release critical | 18:24 |
| gintas_ | sorry, I just forgot to update the bug status | 18:24 |
| bska|mobile | or should I provide a manager only link to app/sections | 18:24 |
| th1a | gintas_: Excellent. Should I mark 246 as resolved? | 18:24 |
| gintas_ | I just did | 18:25 |
| bska|mobile | th1a: seems to think that's appropriate, I'll add the course deletion stuff for the next release | 18:25 |
| gintas_ | I forgot that there was an issue filed for that problem ;) | 18:25 |
| th1a | In my opinion, just not allowing courses to be deleted is ok for this release, as long as sections can be deleted. | 18:25 |
| bska|mobile | courses can be deleted, currently | 18:26 |
| bska|mobile | do you want that removed? | 18:26 |
| bska|mobile | it leaves unassociated sections floating around | 18:26 |
| th1a | Or, for that matter, it doesn't necessarily follow that sections _should_ be deleted when a course is deleted. | 18:26 |
| th1a | It just screws up the UI metaphor. | 18:27 |
| ignas | well i haven't seen a button to delete a section anywhere ... | 18:27 |
| bska|mobile | (they're easy to pick off in the section container since they have labels that end with ' --') | 18:27 |
| th1a | Anyhow, the easiest satisfactory solutions in my mind are: | 18:27 |
| bska|mobile | ignas: http://localhost:7080/sections | 18:27 |
| th1a | a) don't allow courses to be deleted | 18:27 |
| th1a | b) don't allow non-empty courses to be deleted, only. | 18:28 |
| ignas | th1a, b) well you see, pisking out all sections of a course in one view just to delete it in another view seems a bit hacky to me :/ | 18:29 |
| ignas | s/pisking/picking | 18:29 |
| ignas | i'd like having ability to disconnect/delete sections in the course view | 18:29 |
| th1a | ignas: That makes sense. | 18:30 |
| th1a | Deleting the course itself is what doesn't make sense. | 18:30 |
| th1a | Perhaps it isn't entirely clear that courses, by their nature, remain fairly constant over long periods of time, whereas sections are inherently short-lived. | 18:31 |
| tvon | bskahan want's you all to know that he just lost net and is trying to get back on | 18:32 |
| th1a | tvon: Thanks. | 18:32 |
| th1a | OK... other bugs that need assignment/fixing? | 18:32 |
| ignas | well disabling deletion of courses is evil when people make mistypes in course names ... | 18:33 |
| povbot` | /svn/commits: * gintas committed revision 3981: | 18:33 |
| povbot` | /svn/commits: Fixed #241 (Cancel button not working in resource booking view). | 18:33 |
| th1a | ignas: I suppose it probably isn't much harder to limit deletion to empty courses. | 18:34 |
| ignas | so IMHO the perfect case - Deletion of sections in CourseView, And allow removing only Empty Courses | 18:34 |
| th1a | ignas: right. | 18:34 |
| tvon | bskahan will be back in 5-10 mins | 18:35 |
| povbot` | /svn/commits: * gintas committed revision 3982: | 18:36 |
| th1a | Issue 239 isn't critical, but annoying if you want anonymous users to be able to use the site. | 18:36 |
| povbot` | /svn/commits: Backported revision 3981 (issue #241, Cancel button not working in the resource booking view). | 18:36 |
| th1a | We need some kind of procedure for getting rid of these kind of nagging bugs. | 18:37 |
| * mgedmin notices a broken ftest in schooltool | 18:37 | |
| * mgedmin does svn up and reruns all tests again | 18:37 | |
| mgedmin | app_txt fails here | 18:38 |
| mgedmin | loooong incomprehensible diff | 18:38 |
| mgedmin | something to do with sections and labels | 18:39 |
| mgedmin | relevant bit of the diff | 18:39 |
| mgedmin | - <td style="width: 100%">Section</td> | 18:39 |
| mgedmin | + <td style="width: 100%"><security proxied zope.i18nmessageid.messageid.MessageID instance at 0xb6e4777c> | 18:39 |
| mgedmin | eek! | 18:39 |
| mgedmin | tvon, bska|mobile, do you know anything about this? | 18:39 |
| tvon | mgedmin: I don't, bska|mobile might.. he's working on finding another coffee shop with wifi at the moment | 18:40 |
| th1a | What needs to be done about 243: Calendars with identical titles are throwing system error | 18:41 |
| mgedmin | th1a, I just added a comment | 18:41 |
| *** jinty_ has joined #schooltool | 18:41 | |
| mgedmin | basically it's a missing security declaration | 18:42 |
| mgedmin | should be very easy to fix | 18:42 |
| th1a | Can we assign that to you then ;-) | 18:42 |
| ignas | jinty_, 243 should be backported to ST | 18:42 |
| jinty_ | ignas:ok, I'll have a look | 18:43 |
| ignas | at the moment - having to persons with identical title ruins the overlay widget | 18:43 |
| jinty_ | I'll try to backport a few at once from now on to avoid cluttering commits | 18:43 |
| mgedmin | ignas, do you want to say that 243 has been fixed already, but not updated in the issue tracker? | 18:44 |
| *** bska|mobile has quit IRC | 18:44 | |
| mgedmin | has it been fully fixed -- i.e. for _all_ content objects? | 18:45 |
| jinty_ | Can I ask what the general opinion in, weather I will be able to branch the release branch tomorrow? | 18:46 |
| jinty_ | s/in/is | 18:46 |
| th1a | jinty_: I was going to ask the same thing. | 18:46 |
| jinty_ | I don't think this is my decision... | 18:47 |
| th1a | Well, specifically, can we release SchoolBell 1.1 tomorrow? | 18:47 |
| ignas | mgedmin, yes i refered to the Issue in the Commit message yet forgot to rewfer to the revision in the Issue tracker | 18:47 |
| jinty_ | Whatever happens afterwards to the release branch, yes | 18:47 |
| tvon | anyone know a non-DST tz off-hand? | 18:47 |
| jinty_ | th1a: I think it is a bad idea because schooltool bugs sometimes | 18:47 |
| jinty_ | need to be fixed in SchoolBell | 18:48 |
| *** jinty has quit IRC | 18:48 | |
| *** bskahan has joined #schooltool | 18:49 | |
| th1a | But it doesn't look like the outstanding SchoolTool bugs should need changes in SchoolBell. | 18:49 |
| * jinty_ is afraid of the unknown | 18:49 | |
| mgedmin | ignas just told me that 243 wasn't fixed for all content types | 18:49 |
| bskahan | damn, sorry about that | 18:49 |
| bskahan | reading logs | 18:49 |
| th1a | Well, se should probably summarize release blockers at this point and see what we've got. | 18:50 |
| mgedmin | yes, please | 18:50 |
| th1a | 242 blocks SchoolBell | 18:50 |
| bskahan | tvon: 'Europe/Oslo' | 18:50 |
| tvon | bskahan: thanks | 18:50 |
| th1a | 245 blocks SchoolTool, I'd say. | 18:50 |
| bskahan | 'US/Eastern' | 18:50 |
| * tvon is workgin on 242 | 18:51 | |
| tvon | er, working | 18:51 |
| bskahan | th1a: I got dropped in the middel of the 245 discussion | 18:51 |
| * jinty_ moves 242 to priority critical | 18:51 | |
| th1a | I pasted in the concluding point on the Roundup page. | 18:51 |
| bskahan | Is adding a link to /app/sections for managers sufficient to give access to deleting sections? | 18:52 |
| th1a | I would regard that as sufficient. | 18:52 |
| * bskahan nods | 18:52 | |
| th1a | Realistically, in this release you'll just delete all of them at once at the end of the term. | 18:52 |
| * ignas would be unhappy ;( | 18:52 | |
| bskahan | ignas: why? | 18:53 |
| * ignas is an UI nazi sometimes | 18:53 | |
| th1a | ignas: This whole issue has to be revisited in much greater detail later on. | 18:54 |
| bskahan | we don't have a clear idea of when we want deleting courses to delete sections | 18:54 |
| mgedmin | ignas, since you already fixed part of 243, would you object if I assigned that issue to you? | 18:54 |
| ignas | mgedmin, i'd be happy if you would do so :_ | 18:54 |
| jinty_ | re 245: please do this in a way that does not leave the database in a bad way, also remember that schooltool 0.11 will be out in a few months. Is deleting courses/sections really necessary in that timeframe? | 18:54 |
| th1a | So I'm not concerned about getting it precisely right in this iteration. | 18:54 |
| * mgedmin makes ignas happy | 18:54 | |
| ignas | bskahan, well i would suggest an elaborate solution yet we don't have time for it in this release ... | 18:55 |
| bskahan | ignas: :) | 18:55 |
| th1a | ignas: The correct solution is quite elaborate, and we'll be undertaking it soon enough. | 18:55 |
| mgedmin | re deleting things: deleting timetable schemas and terms may mess up the system as well, if you have nonempty timetables for those terms/schemas you deleted | 18:55 |
| bskahan | I'm all for an elaborate solution, but its memorial day ;) | 18:55 |
| th1a | mgedmin: That's an important point, too. | 18:56 |
| jinty_ | so, no elaborate solutions, just solutions that are simple and safe. We can delete things in schooltool 0.11 | 18:56 |
| th1a | OK, any other release blockers? | 18:56 |
| ignas | th1a, so should we just disable deletion of containers, or add event handlers ? for this release i mean ... | 18:57 |
| mgedmin | timezones and timetables | 18:57 |
| bskahan | ignas: containers? | 18:57 |
| ignas | in containers i mean | 18:58 |
| th1a | Disabling deletion of timetable schemas and terms is probably a good idea. | 18:58 |
| jinty_ | +1 | 18:58 |
| th1a | It is a minor inconvenience, compared to a badly timed deletion, which will b0rk your whole setup. | 18:58 |
| mgedmin | timezones and timetables: imho timetable schemas should store time + tz (always UTC as everywhere); timetable schema views should convert from user's tz to utc | 18:59 |
| mgedmin | this concludes my personal "known issue" list (tomboy rules!) | 18:59 |
| th1a | So... in conclusion. I feel ok with SchoolBell 1.1 and SchoolTool 0.10rc1 tomorrow, if those are resolved. | 18:59 |
| bskahan | mgedmin: that makes sense, since the events will be stored in UTC | 18:59 |
| th1a | Any final fears or complaints? | 19:00 |
| bskahan | I came up with a list of UI issues, ignas want to add to it :-D | 19:00 |
| bskahan | http://www.schooltool.org/Members/bskahan/sc-ui-stories | 19:00 |
| jinty_ | th1a: I am not happy with SchoolBell 1.1 tomorrow. perhaps rc2 + distribution of debian/ubuntu packages? | 19:01 |
| * jinty_ almost had a heart attack when he read bskahan's stories thinking they were for 0.10 | 19:02 | |
| th1a | jinty_: Is there something specific you're worried about? | 19:02 |
| bskahan | rofl | 19:03 |
| th1a | We can't just blow off deadlines for vague fears. | 19:03 |
| jinty_ | th1a: Very specifically unknown bugs in SchoolTool requiring fixes in SchoolBell. I wish to leave the door open for changes to SchoolBell. | 19:03 |
| th1a | Missing one deadline and making one is a lot better than missing two. | 19:03 |
| jinty_ | I can make it clear in my announcement that SchoolBell is in _deep_ freeze and will not change except for that. | 19:04 |
| th1a | SchoolBell just isn't in _deep_ freeze. | 19:05 |
| * mgedmin glances at a clock and coughs discretely | 19:05 | |
| * th1a bangs the gavel. | 19:05 | |
| tvon | Can someone check behaviour related to #242? Just add an event at some time and tell me how the display relates to what the time displayed is and what you entered. | 19:05 |
| jinty_ | iow: a final release, but with some small print. | 19:05 |
| bskahan | tvon: to test you have to set your preffered TZ to non-UTC | 19:05 |
| jinty_ | iow - in other words | 19:06 |
| tvon | bskahan: I know | 19:06 |
| bskahan | ;) | 19:06 |
| tvon | bskahan: is us/eastern right now and I'm getting the same behaviour as europe/o..whatever. | 19:06 |
| ignas | bskahan, well i do not have user in the schooltool.org | 19:06 |
| bskahan | can someone/several someone run though section scheduling | 19:06 |
| bskahan | so someone other than me has looked at it before the release | 19:06 |
| tvon | I'm showing that the display is correct but 1hr off from the time specified when creating the event | 19:06 |
| th1a | jinty_: We really need to release SchoolBell 1.1 tomorrow. There will always be more bugs in the future. | 19:07 |
| bskahan | tvon: your right, that's the behavior I get too | 19:09 |
| tvon | bskahan: ah, okay | 19:09 |
| bskahan | it was different before, really | 19:09 |
| tvon | heh | 19:09 |
| bskahan | it was off by offset | 19:09 |
| gintas_ | jinty_, by the way, what do you think about backporting the fix for i18n:translate warnings? | 19:09 |
| bskahan | I have to run for a little while, I'll commit a fix for 245 today | 19:10 |
| tvon | I have to run for a few, I'll bbiab working on 242 | 19:10 |
| jinty_ | th1a: ok. | 19:11 |
| th1a | jinty_: Thanks for the compromise. | 19:11 |
| jinty_ | gintas_: no, I am not willing to port a patch that big and release tomorrow, sorry. | 19:11 |
| gintas_ | ok | 19:12 |
| th1a | jinty_: Well, where does that leave us, then? | 19:13 |
| povbot` | /svn/commits: * gintas committed revision 3983: | 19:13 |
| povbot` | /svn/commits: Event more of those pesky i18n:translate attributes. | 19:13 |
| th1a | If 242 blocks the release and you don't want to port it? | 19:13 |
| th1a | Oh, wait, looking at the wrong issue. | 19:14 |
| th1a | jinty: You were talking to gintas about the i18n warnings? | 19:14 |
| jinty_ | th1a: SchoolBell 1.1 when 242 is fixed+reviewed. SchoolTool 0.10rc1 when 245 is fixed. | 19:14 |
| jinty_ | th1a: yep. they are not essential. | 19:15 |
| th1a | OK. Scared me there for a second. | 19:15 |
| gintas_ | why? | 19:15 |
| th1a | I'm going to quit while I'm ahead and get lunch. | 19:15 |
| * jinty_ starts laughing manically "power, power more power!!!!!" | 19:15 | |
| th1a | gintas_: I thought jinty_ was refusing to port a release blocker. | 19:15 |
| gintas_ | ;) | 19:15 |
| gintas_ | nah, it's just a minor itch | 19:16 |
| *** th1a is now known as th1a|unch | 19:16 | |
| gintas_ | we bound ourselves to a Zope 3 revision which already had the i18n warnings, so we could as well get them fixed | 19:16 |
| povbot` | /svn/commits: * gintas committed revision 3984: | 19:18 |
| povbot` | /svn/commits: The composite timetable calendar is now overlaid unconditionally when you are viewing someone else's calendar. | 19:18 |
| jinty_ | gintas_: If we weren't releasing tomorrow, I would have backported it. but now... | 19:18 |
| gintas_ | argh, I was too late then ;) | 19:19 |
| jinty_ | yep, the bar for patches goes up as release date approaches. It's all risk-reward analysis. | 19:20 |
| * jinty_ 's battery is about to die, so he shuts down... | 19:20 | |
| *** jinty_ has left #schooltool | 19:20 | |
| povbot` | /svn/commits: * gintas committed revision 3985: | 19:27 |
| povbot` | /svn/commits: Fixed typo. | 19:27 |
| *** thisfred has quit IRC | 19:32 | |
| povbot` | /svn/commits: * ignas committed revision 3986: | 19:33 |
| povbot` | /svn/commits: Final fixes for Issue243. | 19:33 |
| *** bskahan has quit IRC | 19:34 | |
| *** gintas_ has quit IRC | 19:43 | |
| *** erchache has joined #schooltool | 19:54 | |
| erchache | hi | 19:56 |
| erchache | where i can get readme and install to translate to spanish and join to final 1.1 release? | 19:56 |
| erchache | eeeoooo | 20:00 |
| erchache | tvon | 20:00 |
| erchache | and jinti? | 20:01 |
| povbot` | /svn/commits: * ignas committed revision 3987: | 20:01 |
| povbot` | /svn/commits: Added __cmp__ attribute to content objects in schooltool. Issue243. | 20:01 |
| mgedmin | erchache, try http://source.schooltool.org/viewcvs/branches/schoolbell-1.1.x/ | 20:02 |
| mgedmin | that's where the English README lives | 20:03 |
| erchache | ok | 20:05 |
| *** th1a|unch is now known as th1a | 20:15 | |
| erchache | arrrrrrrgghhh | 20:29 |
| erchache | english README smell very very bad | 20:29 |
| erchache | who writes this? a klingong? | 20:29 |
| Aiste | what kind of paper did you print it on, that it smells so bad? :) | 20:32 |
| alga | please, to be providing patches | 20:32 |
| Aiste | on the second thought -- don't :) | 20:32 |
| ignas | It is a goodday to write documentation! | 20:32 |
| th1a | OK, I'll have a look at it. | 20:33 |
| *** gintas_ has joined #schooltool | 20:46 | |
| erchache | installing and configuring schoolbell was written by marx's brothers | 20:46 |
| erchache | :P | 20:46 |
| *** gintas_ is now known as gintas | 20:46 | |
| th1a | Well, it seems like the most complicated approach to installing SchoolBell... | 20:47 |
| erchache | i dont translate testing..... | 20:48 |
| erchache | if any wants to do it....maybe knows english | 20:48 |
| erchache | i dont know any programmer who doesnt understand english :P | 20:48 |
| th1a | Yeah. | 20:48 |
| th1a | Well, I should clean the README up. | 20:49 |
| gintas | by the way, how will we handle evolution in SchoolTool? | 20:50 |
| *** bskahan has joined #schooltool | 20:50 | |
| th1a | Evolution? | 20:50 |
| th1a | Generations? | 20:50 |
| gintas | we have a generations marker for SchoolBell, but I don't see one in SchoolTool | 20:50 |
| gintas | don't we need one? | 20:50 |
| th1a | I certainly think so. | 20:50 |
| bskahan | gintas: good catch | 20:53 |
| erchache | well | 20:53 |
| erchache | i finish | 20:53 |
| erchache | i add on spanish readme a lines for the unpatient ok? | 20:53 |
| bskahan | ignas: I just added you to the sharing on that UI stories document | 20:54 |
| bskahan | alga: what's the correct way to test if a user is a manager in view code? | 20:56 |
| erchache | arrrrrghhh this readme make me feel a headache.....who writes it? | 20:56 |
| mgedmin | the machine that hosts schooltool's SVN repository is going down for 5-10 minutes | 21:02 |
| mgedmin | (one of the disks in the RAID array decided to fail last night) | 21:02 |
| bskahan | mgedmin: ok | 21:02 |
| bskahan | thanks | 21:02 |
| erchache | well | 21:03 |
| erchache | i rewrite readme this night | 21:03 |
| erchache | where i send it? | 21:03 |
| povbot` | /svn/commits: * gintas committed revision 3988: | 21:03 |
| povbot` | /svn/commits: Added missing i18n:translate attributes on some tags in CSV import. | 21:03 |
| th1a | erchache: You can send it to the dev list. | 21:04 |
| th1a | schooltool-dev | 21:04 |
| erchache | ok | 21:04 |
| th1a | I have been letting jinty do the README. | 21:04 |
| erchache | i will do it now....because i want to include other readme for non-geeks you know? | 21:04 |
| th1a | Sure. | 21:04 |
| *** povbot has joined #schooltool | 21:20 | |
| ignas | IMHO implementing some meaningfull title for Sections would have been a lot better way to implement it | 21:25 |
| ignas | Section titles aretotaly useless now | 21:25 |
| th1a | There are no meaningful titles for sections. | 21:25 |
| th1a | If you have any idea of what they might be, I'd like to hear it. | 21:25 |
| ignas | well so why not make titles a property that returns the label | 21:26 |
| ignas | is there a reason for that ? | 21:26 |
| th1a | Label? | 21:26 |
| ignas | then we would not need the ugly getLabelOrTitle method | 21:26 |
| ignas | getTitleOrLabel | 21:26 |
| ignas | i mean | 21:26 |
| ignas | + if ISection.providedBy(object): | 21:27 |
| ignas | + return object.label | 21:27 |
| ignas | + else: | 21:27 |
| ignas | + return item.calendar.title | 21:27 |
| ignas | seemsevil to me | 21:28 |
| mgedmin | I haven't reviewed that checkin yet | 21:28 |
| th1a | The best solution I've heard at this point is to make it a user preference to decide which info is returned to describe a section. | 21:28 |
| tvon | bskahan: do you see it setting it in the edit view? | 21:28 |
| mgedmin | it seems to me that sections now have a completely useless 'title' attribute and a useful 'label' attribute | 21:28 |
| mgedmin | why? | 21:28 |
| mgedmin | why not have a useful 'title' attribute? | 21:28 |
| th1a | What would it be? It depends on your context. | 21:29 |
| ignas | bskahan said that making a separate portlet would be better than using title or label or even a user preference | 21:29 |
| th1a | Portlet? | 21:29 |
| ignas | th1a, same as label | 21:29 |
| povbot | /svn/commits: * gintas committed revision 3989: | 21:29 |
| povbot | /svn/commits: Added missing i18n:translate tags. | 21:29 |
| ignas | issue244 | 21:30 |
| th1a | mgedmin & ignas: Do you guys understand the underlying problem here -- that to the student it is "mathematics II," but the mathematics teacher might teach five sections of "mathematics II," so it needs a different label in that context. | 21:31 |
| ignas | th1a, well currently Label is used for that | 21:31 |
| bskahan | ignas: schooltool allready had a seperate overlay portlet it turned out | 21:32 |
| ignas | and you just used label in the portlet, so why not jsut make title identical to label ? | 21:32 |
| th1a | OK. I don't have any particular concern about how it is implemented, as long as we understand what the problem is. | 21:32 |
| bskahan | because that was how the story was written | 21:33 |
| bskahan | I don't mind changing it after the release | 21:33 |
| ignas | the same problem could have been solved in a better way | 21:35 |
| bskahan | tvon: the __init__ method of CalendarEventAddView sets the timezone to the preference | 21:35 |
| tvon | bskahan: edit view doesnt, I'm fixing it now | 21:36 |
| bskahan | tvon: ah | 21:36 |
| ignas | because the way it was solved seems well bad object oriented programming style | 21:36 |
| bskahan | ignas: I'm happy to change it to title, but I won't be able to do it in time for the release | 21:37 |
| bskahan | at one point the title was a property similar to the label and it was suggested not to do that | 21:38 |
| bskahan | i don't remember the argument against it | 21:38 |
| ignas | well the title now is "Section" | 21:39 |
| ignas | allways | 21:39 |
| bskahan | correct | 21:39 |
| povbot | /svn/commits: * tvon committed revision 3990: | 21:39 |
| povbot | /svn/commits: half a fix for 242. This makes the edit view show the same time as the one displayed in the calendar. This should be backported. | 21:39 |
| bskahan | I've replaced the title with the label in the UI everywhere I saw it | 21:39 |
| ignas | imho changing title into property wouldhave saved you an hour or two ... | 21:40 |
| bskahan | ignas: I had it that way | 21:40 |
| ignas | and would have been a much better way to solve the problem | 21:40 |
| povbot | /svn/commits: * gintas committed revision 3991: | 21:41 |
| povbot | /svn/commits: Added some missing i18n:translate tags. | 21:41 |
| povbot | /svn/commits: * gintas committed revision 3992: | 21:41 |
| povbot | /svn/commits: More i18n fixes. | 21:41 |
| povbot | /svn/commits: * gintas committed revision 3993: | 21:43 |
| povbot | /svn/commits: One interface used to create a form was not i18nalized properly. | 21:43 |
| povbot | /svn/commits: * gintas committed revision 3994: | 21:43 |
| povbot | /svn/commits: Spacing fix. | 21:43 |
| povbot | /svn/commits: * gintas committed revision 3995: | 21:44 |
| povbot | /svn/commits: Added an i18n:domain marker, without which i18n wouldn't work at all in the overlay portlet. | 21:44 |
| *** gintas has quit IRC | 21:44 | |
| erchache | see tomorrow | 21:48 |
| erchache | limite time to send files? | 21:48 |
| th1a | Hm... that's up to jinty. | 21:49 |
| erchache | my files :P | 21:49 |
| erchache | arrrgghhh | 21:50 |
| erchache | jinty are frozen files now? | 21:50 |
| th1a | He's not here. | 21:50 |
| erchache | eerrr wrong question | 21:51 |
| erchache | are to was | 21:51 |
| erchache | was frozen files now? | 21:51 |
| th1a | For something like a README, I don't think it should be a problem. | 21:51 |
| th1a | You're not going to introduce any new bugs. | 21:52 |
| erchache | ok | 21:52 |
| erchache | see tomorrow | 21:52 |
| erchache | bye | 21:52 |
| *** erchache has quit IRC | 21:52 | |
| bskahan | mgedmin: what was the security declaration you were talking about with regard to the broken ftest? | 21:55 |
| bskahan | for some reason it works in the browser but not in the ftest | 21:56 |
| mgedmin | bskahan, I wasn't | 21:56 |
| mgedmin | the broken ftest has nothing to do with security declarations | 21:56 |
| bskahan | oh, nm I must have been confused | 21:57 |
| bskahan | mgedmin: I see what you were referring to now | 22:01 |
| povbot | /svn/commits: * bskahan committed revision 3996: | 22:08 |
| povbot | /svn/commits: adding section navigation to the menu for users who can delete from the sections container. Its ftested, but not unit tested, not sure I can track down the appropriate test setup in time, sorry about that. | 22:08 |
| mgedmin | that's bad :( | 22:10 |
| alga | no test = no feature | 22:10 |
| Aiste | unfortunately POV is saddled with code quality control | 22:10 |
| Aiste | so, tough | 22:10 |
| bskahan | ok | 22:11 |
| * tvon wants to know when this extra hour started showing up in events | 22:14 | |
| ignas | tvon, svn revision binary search | 22:15 |
| ignas | 10 checkouts sohuld be enough :) | 22:15 |
| tvon | hah | 22:16 |
| mgedmin | is that one extra hour, or 2*timezone_offset? | 22:16 |
| tvon | mgedmin: I believe it's just one hour off | 22:16 |
| tvon | unless you are seeing something different | 22:16 |
| bskahan | I have to go find a power outlet | 22:16 |
| bskahan | bbiab | 22:16 |
| tvon | hrm | 22:16 |
| tvon | tis in parse_timetz | 22:17 |
| *** bskahan has quit IRC | 22:20 | |
| tvon | or not | 22:21 |
| povbot | /svn/commits: * ignas committed revision 3997: | 22:21 |
| povbot | /svn/commits: Had some ViewErrors left. Will have to review functional tests of restive views. | 22:22 |
| povbot | /svn/commits: * ignas committed revision 3998: | 22:22 |
| povbot | /svn/commits: Updated TimetableSchemaContainerView so it would not allow deleting schemas. And would let you choose a default ttschema. | 22:23 |
| tvon | Europe/Oslo does *not* observe DST, correct? | 22:28 |
| tvon | er, no, it does | 22:29 |
| tvon | I need a tz that doesnt | 22:29 |
| alga | saudi arabia? | 22:31 |
| alga | parts of india? | 22:31 |
| alga | *shrug* | 22:31 |
| alga | wikipedia: | 22:33 |
| alga | Hawaii, the only U.S. state in the tropics, does not observe DST. | 22:34 |
| tvon | ah | 22:34 |
| tvon | thanks :) | 22:34 |
| tvon | wtf | 22:42 |
| tvon | wtf indeed | 22:42 |
| tvon | We need to not have releases the day after a holiday weekend | 22:43 |
| *** bskahan has joined #schooltool | 22:45 | |
| th1a | Yes, I apologize. | 22:47 |
| *** Aiste has quit IRC | 22:52 | |
| *** ignas has quit IRC | 22:56 | |
| *** mgedmin has quit IRC | 22:56 | |
| povbot | /svn/commits: * bskahan committed revision 3999: | 22:57 |
| povbot | /svn/commits: reverted the conditional part of 3996, sections container is now treated like the other containers for the pupose of view and delete. | 22:57 |
| *** alga has quit IRC | 22:58 | |
| bskahan | can anyone point to where schooltool.browser.app.ContainerView is doc/unit tested? | 23:11 |
| bskahan | that would have the same test fixtures I'm looking for | 23:11 |
| *** Aiste has joined #schooltool | 23:19 | |
| *** Aiste has quit IRC | 23:19 | |
| *** bskahan has quit IRC | 23:33 | |
| *** bskahan has joined #schooltool | 23:46 | |
| *** bska|mobile has joined #schooltool | 23:53 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!