IRC log of #schooltool for Monday, 2005-05-30

*** bskahan has quit IRC00:17
*** bskahan has joined #schooltool00:21
*** bskahan has quit IRC01:16
*** bskahan has joined #schooltool01:26
*** JStrike has joined #schooltool01:43
*** JStrike has left #schooltool01:43
*** bskahan has quit IRC01:48
*** bskahan has joined #schooltool01:54
*** munkee_ has joined #schooltool02:05
*** munkee has quit IRC02:05
*** munkee_ has quit IRC02:15
*** munkee has joined #schooltool02:18
*** bskahan has quit IRC02:20
*** bskahan has joined #schooltool02:23
*** tvon has quit IRC04:48
*** th1a has joined #schooltool04:51
*** bskahan has quit IRC05:28
*** bskahan has joined #schooltool08:28
*** tvon has joined #schooltool08:49
*** bskahan has quit IRC09:24
*** bskahan has joined #schooltool09:26
povbot`/svn/commits: * bskahan committed revision 3969:09:40
povbot`/svn/commits: you can schedule sections in time periods now.09:40
povbot`/svn/commits: * bskahan committed revision 3970:09:52
povbot`/svn/commits: removing a marker XXX09:52
*** bskahan has quit IRC09:59
povbot`/svn/commits: * bskahan committed revision 3971:10:00
povbot`/svn/commits: fleshing out unit tests10:00
*** bskahan has joined #schooltool10:02
*** SteveA_ has joined #schooltool10:10
*** SteveA has quit IRC10:11
*** SteveA_ is now known as SteveA10:28
*** bskahan has quit IRC10:36
*** bskahan has joined #schooltool10:38
*** thisfred has joined #schooltool11:01
*** bskahan has quit IRC11:01
povbot`/svn/commits: * bskahan committed revision 3972:11:03
povbot`/svn/commits: add a cancel button to the section schedule form11:03
*** SteveA_ has joined #schooltool12:16
*** SteveA has quit IRC12:17
*** SteveA_ is now known as SteveA12:17
povbot`/svn/commits: * gintas committed revision 3973:13:25
povbot`/svn/commits: Added functional tests for CSV import, and a few other things along the way.13:25
*** gintas has joined #schooltool13:26
*** bskahan has joined #schooltool13:32
*** bska|mobile has joined #schooltool13:55
*** bskahan has quit IRC13:57
*** gintas has quit IRC14:11
povbot`/svn/commits: * gintas committed revision 3974:14:16
povbot`/svn/commits: Fixed places in SchoolTool templates which were throwing i18n deprecation warnings, at least the ones revealed by functional tests.14:16
*** alga has joined #SchoolTool14:17
*** gintas has joined #schooltool14:17
povbot`/svn/commits: * bskahan committed revision 3975:14:22
povbot`/svn/commits: added a Welcome to SchoolTool index page.14:22
povbot`/svn/commits: I left ttschema and term links off intentionally because I don't think they're going to be what people are trying to access often (probably just once a year).14:22
povbot`/svn/commits: Side note, as soon as we have a sitewide configuration option, the "Welcome to SchoolTool" should probably be a configurable string.14:22
*** ignas has joined #schooltool14:35
povbot`/svn/commits: * gintas committed revision 3976:14:38
povbot`/svn/commits: A few more missing i18n:translates.14:38
povbot`/svn/commits: * gintas committed revision 3977:14:39
povbot`/svn/commits: Added missing i18n:translate attributes.14:39
povbot`/svn/commits: * gintas committed revision 3978:14:48
*** gintas_ has joined #schooltool14:48
povbot`/svn/commits: Some more of those pesky i18n:translates.  Functional tests pass cleanly now, provided that you're testing SchoolTool trunk with SchoolBell's trunk.14:48
povbot`/svn/commits: Jinty, I think it would be nice to backport the fixes to SchoolBell templates to the 1.1.x branch.  I don't think they could possibly introduce a bug, but it's your call.  Those warnings really annoy me ;)14:48
*** gintas has quit IRC14:54
*** Aiste has joined #schooltool15:28
bska|mobilesome current thought on UI improvments15:28
*** gintas_ has quit IRC15:37
*** bska|mobile has quit IRC15:44
*** bskahan has joined #schooltool15:49
povbot`/svn/commits: * ignas committed revision 3979:16:28
povbot`/svn/commits: A fix for issue 197.16:28
*** gintas_ has joined #schooltool16:50
*** bska|mobile has joined #schooltool17:05
*** bskahan has quit IRC17:05
*** mgedmin has joined #schooltool17:13
gintas_bska|mobile, tvon, are you there?17:42
gintas_I have a question regarding timezones17:42
bska|mobilegintas_: hey17:43
gintas_in the calendar views, when should I combine datetimes with UTC and when with self.timezone?17:44
povbot`/svn/commits: * bskahan committed revision 3980:17:44
povbot`/svn/commits: make overlay portlet use labels for sections.  fixes
gintas_to be more precise, what kind of datetimes should the calendarRows() method return?17:45
gintas_in UTC or in the user's timezone17:45
mgedminsrichter, can you mail me your publish SSH key? (gpg-signed mail preferred)17:45
bska|mobilegintas_: I set the preferences in  the view immediately if they exist and default to UTC if the principal doesn't have perferences so (iirc) you have view.timezone and you apply that to all times17:46
gintas_well, in you have this line:17:47
gintas_today = datetime.combine(self.cursor, time(tzinfo=utc))17:47
gintas_so I'm wondering, is this right?17:47
bska|mobileno, it probably should be combine(seld.cursor, time(tzinfo=self.timezone)17:48
bska|mobilelooking now17:48
gintas_I have implemented viewing by periods and have overridden the method17:48
gintas_there are more instances of the same thing there17:48
gintas_since you did the timezones, could you perhaps take a look?  Shouldn't be too hard (see browser/ in SchoolTool)17:49
* bska|mobile nods17:49
bska|mobileI need to for 24217:49
mgedmin(meeting time)18:00
* tvon yawns18:00
th1aHi all.18:00
th1aI got back in town late last night, so I'm still a bit behind on the precise status of things.18:01
th1abskahan:  How do things look from your perspective?18:02
bska|mobilepretty good, I got the browser view for adding timetables to sections done18:03
bska|mobileafter I finished it I thought of a better UI for it, but its fully functional and not ugly18:04
th1aSorry about the confusion about that.18:04
* bska|mobile nods18:04
th1aSo are there any other loose ends from Etria's perspective?18:04
tvonthat should be it18:05
bska|mobiletimezone aware events rendering incorrectly18:05
bska|mobileI think is impacting gintas's bug18:05
bska|mobileas far as I know that's it18:05
th1aDo we know the underlying cause of the bug?18:05
tvonI don't18:06
bska|mobileI think gintas just pointed it out18:06
* mgedmin looks at the bug18:06
bska|mobilelooking into it18:07
th1aSo the date is being stored correctly but not displayed right?18:07
bska|mobilewe're going to work on it right after the meeting18:08
th1aOK.  We'd better not take time on it right this second.18:08
th1aHow do things look from Vilnius?18:08
gintas_I finished the CSV import18:09
gintas_basically had to rewrite it because the format changed completely18:09
ignasI am working on Seting of default schema in schema container view18:09
bska|mobilegintas_: its much nicer now18:09
ignasdeleting ofschemas must be handled so it's in my list of tasks18:09
ignasand the last one is writing some functional tests for shceduling of a student18:09
ignasthen i guess i'll look for bugs in roundup18:10
mgedminthere are some loose ends18:10
mgedmine.g. the interaction of timetables and timezones18:11
ignasthe list in roundup is way too long, and someone with the authority to do so should up the bugs that must be fixed untill release as critical18:11
algaactually, the should be marked with a release tag18:11
th1aWe should probably spend the rest of the time sorting bugs.18:12
th1aI think we should just go down the list together, because looking at it independently while on IRC seems muddled.18:13
gintas_I'm working on #24118:13
th1aWe should get all these bugs assigned to the appropriate people.18:14
ignaswhat about 245 ?18:14
th1aOK, so 241 assigned to gintas?18:15
bska|mobileignas: there wasn't consensus on how to handle that18:15
bska|mobileI like the idea of forcing at the container level18:15
* mgedmin downgrades 235 ("add" button in container views) to wish18:15
ignaswell a user can't remove a section from his overlay at the moment so it should get fixed untill release18:15
ignasmgedmin, thank you18:16
ignasi have postponed it because well - it should go into schoolbell18:16
* mgedmin downgrades 237 (adaptation to ISchoolToolApplication) to wish18:16
bska|mobilesections can be deleted from the SectionContainer and sections are removed from instructors overlays when the instructor is removed from the section18:16
ignasbska|mobile, how does one get into SectionContainer view ?18:17
th1aignas:  Courses are rarely removed.  In this release, just deleting sections makes more sense.18:17
bska|mobileignas: good point18:18
* mgedmin marks 141 (timezone in iCalendar files) as resolved18:18
th1abska|mobile:  What do you mean by "forcing at the container level."18:18
bska|mobileth1a: I was working on browser view code to delete sections from the ContainerDelete view, ignas pointed out that that didn't handle RESTive deletion18:19
mgedminbska|mobile, event handlers?18:19
* bska|mobile nods18:19
bska|mobileI was trying to override the __delitem__ method in the container, but that was dumb18:20
bska|mobiledoing it on event handlers seems less likely to be circumvented18:21
*** jinty has joined #schooltool18:21
th1aWho gets #246?18:21
mgedminhi, jinty18:21
bska|mobileI'm not sure that the __delitem__ way wouldn't have worked, but I got sidetracked with the section/timetable UI18:21
th1ajinty:  Hi.18:21
algait would have18:22
mgedminbska|mobile, I think either __delitem__ or event handlers would work equally well18:22
* jinty hates #$@%$ hardware #%%$# ndiswrapper %##$% cafe wlan!!!!18:22
mgedminI think the primary difference is the setup necessary in unit tests18:22
algabut events is a cleaner way to plug in such policy-making functionality18:22
bska|mobilemgedmin: ok, maybe I'll finish the __delitem__ code then18:22
mgedminnot sure which one would be easier to test18:22
bska|mobilehi jinty18:22
mgedminerr, not test, I meant, not sure which one would require larger test fixtures18:23
jintyhi all18:23
* bska|mobile nods18:23
* jinty catches up on logs18:23
gintas_th1a, I have fixed #24618:24
bska|mobilethe next question is, is 245 release critical18:24
gintas_sorry, I just forgot to update the bug status18:24
bska|mobileor should I provide a manager only link to app/sections18:24
th1agintas_:  Excellent.  Should I mark 246 as resolved?18:24
gintas_I just did18:25
bska|mobileth1a: seems to think that's appropriate, I'll add the course deletion stuff for the next release18:25
gintas_I forgot that there was an issue filed for that problem ;)18:25
th1aIn my opinion, just not allowing courses to be deleted is ok for this release, as long as sections can be deleted.18:25
bska|mobilecourses can be deleted, currently18:26
bska|mobiledo you want that removed?18:26
bska|mobileit leaves unassociated sections floating around18:26
th1aOr, for that matter, it doesn't necessarily follow that sections _should_ be deleted when a course is deleted.18:26
th1aIt just screws up the UI metaphor.18:27
ignaswell i haven't seen a button to delete a section anywhere ...18:27
bska|mobile(they're easy to pick off in the section container since they have labels that end with '  --')18:27
th1aAnyhow, the easiest satisfactory solutions in my mind are:18:27
bska|mobileignas: http://localhost:7080/sections18:27
th1aa) don't allow courses to be deleted18:27
th1ab) don't allow non-empty courses to be deleted, only.18:28
ignasth1a, b) well you see, pisking out all sections of a course in one view just to delete it in another view seems a bit hacky to me :/18:29
ignasi'd like having ability to disconnect/delete sections in the course view18:29
th1aignas:  That makes sense.18:30
th1aDeleting the course itself is what doesn't make sense.18:30
th1aPerhaps it isn't entirely clear that courses, by their nature, remain fairly constant over long periods of time, whereas sections are inherently short-lived.18:31
tvonbskahan want's you all to know that he just lost net and is trying to get back on18:32
th1atvon:  Thanks.18:32
th1aOK... other bugs that need assignment/fixing?18:32
ignaswell disabling deletion of courses is evil when people make mistypes in course names ...18:33
povbot`/svn/commits: * gintas committed revision 3981:18:33
povbot`/svn/commits: Fixed #241 (Cancel button not working in resource booking view).18:33
th1aignas:  I suppose it probably isn't much harder to limit deletion to empty courses.18:34
ignasso IMHO the perfect case - Deletion of sections in CourseView, And allow removing only Empty Courses18:34
th1aignas:  right.18:34
tvonbskahan will be back in 5-10 mins18:35
povbot`/svn/commits: * gintas committed revision 3982:18:36
th1aIssue 239 isn't critical, but annoying if you want anonymous users to be able to use the site.18:36
povbot`/svn/commits: Backported revision 3981 (issue #241, Cancel button not working in the resource booking view).18:36
th1aWe need some kind of procedure for getting rid of these kind of nagging bugs.18:37
* mgedmin notices a broken ftest in schooltool18:37
* mgedmin does svn up and reruns all tests again18:37
mgedminapp_txt fails here18:38
mgedminloooong incomprehensible diff18:38
mgedminsomething to do with sections and labels18:39
mgedminrelevant bit of the diff18:39
mgedmin    -         <td style="width: 100%">Section</td>18:39
mgedmin    +         <td style="width: 100%">&lt;security proxied zope.i18nmessageid.messageid.MessageID instance at 0xb6e4777c&gt;18:39
mgedmintvon, bska|mobile, do you know anything about this?18:39
tvonmgedmin: I don't, bska|mobile might.. he's working on finding another coffee shop with wifi at the moment18:40
th1aWhat needs to be done about 243:  Calendars with identical titles are throwing system error18:41
mgedminth1a, I just added a comment18:41
*** jinty_ has joined #schooltool18:41
mgedminbasically it's a missing security declaration18:42
mgedminshould be very easy to fix18:42
th1aCan we assign that to you then ;-)18:42
ignasjinty_, 243 should be backported to ST18:42
jinty_ignas:ok, I'll have a look18:43
ignasat the moment - having to persons with identical title ruins the overlay widget18:43
jinty_I'll try to backport a few at once from now on to avoid cluttering commits18:43
mgedminignas, do you want to say that 243 has been fixed already, but not updated in the issue tracker?18:44
*** bska|mobile has quit IRC18:44
mgedminhas it been fully fixed -- i.e. for _all_ content objects?18:45
jinty_Can I ask what the general opinion in, weather I will be able to branch the release branch tomorrow?18:46
th1ajinty_:  I was going to ask the same thing.18:46
jinty_I don't think this is my decision...18:47
th1aWell, specifically, can we release SchoolBell 1.1 tomorrow?18:47
ignasmgedmin, yes i refered to the Issue in the Commit message yet forgot to rewfer to the revision in the Issue tracker18:47
jinty_Whatever happens afterwards to the release branch, yes18:47
tvonanyone know a non-DST tz off-hand?18:47
jinty_th1a: I think it is a bad idea because schooltool bugs sometimes18:47
jinty_need to be fixed in SchoolBell18:48
*** jinty has quit IRC18:48
*** bskahan has joined #schooltool18:49
th1aBut it doesn't look like the outstanding SchoolTool bugs should need changes in SchoolBell.18:49
* jinty_ is afraid of the unknown18:49
mgedminignas just told me that 243 wasn't fixed for all content types18:49
bskahandamn, sorry about that18:49
bskahanreading logs18:49
th1aWell, se should probably summarize release blockers at this point and see what we've got.18:50
mgedminyes, please18:50
th1a242 blocks SchoolBell18:50
bskahantvon: 'Europe/Oslo'18:50
tvonbskahan: thanks18:50
th1a245 blocks SchoolTool, I'd say.18:50
* tvon is workgin on 24218:51
tvoner, working18:51
bskahanth1a: I got dropped in the middel of the 245 discussion18:51
* jinty_ moves 242 to priority critical18:51
th1aI pasted in the concluding point on the Roundup page.18:51
bskahanIs adding a link to /app/sections for managers sufficient to give access to deleting sections?18:52
th1aI would regard that as sufficient.18:52
* bskahan nods18:52
th1aRealistically, in this release you'll just delete all of them at once at the end of the term.18:52
* ignas would be unhappy ;(18:52
bskahanignas: why?18:53
* ignas is an UI nazi sometimes18:53
th1aignas:  This whole issue has to be revisited in much greater detail later on.18:54
bskahanwe don't have a clear idea of when we want deleting courses to delete sections18:54
mgedminignas, since you already fixed part of 243, would you object if I assigned that issue to you?18:54
ignasmgedmin, i'd be happy if you would do so :_18:54
jinty_re 245: please do this in a way that does not leave the database in a bad way, also remember that schooltool 0.11 will be out in a few months. Is deleting courses/sections really necessary in that timeframe?18:54
th1aSo I'm not concerned about getting it precisely right in this iteration.18:54
* mgedmin makes ignas happy18:54
ignasbskahan, well i would suggest an elaborate solution yet we don't have time for it in this release ...18:55
bskahanignas: :)18:55
th1aignas:  The correct solution is quite elaborate, and we'll be undertaking it soon enough.18:55
mgedminre deleting things: deleting timetable schemas and terms may mess up the system as well, if you have nonempty timetables for those terms/schemas you deleted18:55
bskahanI'm all for an elaborate solution, but its memorial day ;)18:55
th1amgedmin:  That's an important point, too.18:56
jinty_so, no elaborate solutions, just solutions that are simple and safe. We can delete things in schooltool 0.1118:56
th1aOK, any other release blockers?18:56
ignasth1a, so should we just disable deletion of containers, or add event handlers ? for this release i mean ...18:57
mgedmintimezones and timetables18:57
bskahanignas: containers?18:57
ignasin containers i mean18:58
th1aDisabling deletion of timetable schemas and terms is probably a good idea.18:58
th1aIt is a minor inconvenience, compared to a badly timed deletion, which will b0rk your whole setup.18:58
mgedmintimezones and timetables: imho timetable schemas should store time + tz (always UTC as everywhere); timetable schema views should convert from user's tz to utc18:59
mgedminthis concludes my personal "known issue" list (tomboy rules!)18:59
th1aSo... in conclusion.  I feel ok with SchoolBell 1.1 and SchoolTool 0.10rc1 tomorrow, if those are resolved.18:59
bskahanmgedmin: that makes sense, since the events will be stored in UTC18:59
th1aAny final fears or complaints?19:00
bskahanI came up with a list of UI issues, ignas want to add to it :-D19:00
jinty_th1a: I am not happy with SchoolBell 1.1 tomorrow. perhaps rc2 + distribution of debian/ubuntu packages?19:01
* jinty_ almost had a heart attack when he read bskahan's stories thinking they were for 0.1019:02
th1ajinty_:  Is there something specific you're worried about?19:02
th1aWe can't just blow off deadlines for vague fears.19:03
jinty_th1a: Very specifically unknown bugs in SchoolTool requiring fixes in SchoolBell. I wish to leave the door open for changes to SchoolBell.19:03
th1aMissing one deadline and making one is a lot better than missing two.19:03
jinty_I can make it clear in my announcement that SchoolBell is in _deep_ freeze and will not change except for that.19:04
th1aSchoolBell just isn't in _deep_ freeze.19:05
* mgedmin glances at a clock and coughs discretely19:05
* th1a bangs the gavel.19:05
tvonCan someone check behaviour related to #242? Just add an event at some time and tell me how the display relates to what the time displayed is and what you entered.19:05
jinty_iow: a final release, but with some small print.19:05
bskahantvon: to test you have to set your preffered TZ to non-UTC19:05
jinty_iow - in other words19:06
tvonbskahan: I know19:06
tvonbskahan: is us/eastern right now and I'm getting the same behaviour as europe/o..whatever.19:06
ignasbskahan, well i do not have user in the schooltool.org19:06
bskahancan someone/several someone run though section scheduling19:06
bskahanso someone other than me has looked at it before the release19:06
tvonI'm showing that the display is correct but 1hr off from the time specified when creating the event19:06
th1ajinty_:  We really need to release SchoolBell 1.1 tomorrow.  There will always be more bugs in the future.19:07
bskahantvon: your right, that's the behavior I get too19:09
tvonbskahan: ah, okay19:09
bskahanit was different before, really19:09
bskahanit was off by offset19:09
gintas_jinty_, by the way, what do you think about backporting the fix for i18n:translate warnings?19:09
bskahanI have to run for a little while, I'll commit a fix for 245 today19:10
tvonI have to run for a few, I'll bbiab working on 24219:10
jinty_th1a: ok.19:11
th1ajinty_:  Thanks for the compromise.19:11
jinty_gintas_: no, I am not willing to port a patch that big and release tomorrow, sorry.19:11
th1ajinty_:  Well, where does that leave us, then?19:13
povbot`/svn/commits: * gintas committed revision 3983:19:13
povbot`/svn/commits: Event more of those pesky i18n:translate attributes.19:13
th1aIf 242 blocks the release and you don't want to port it?19:13
th1aOh, wait,  looking at the wrong issue.19:14
th1ajinty:  You were talking to gintas about the i18n warnings?19:14
jinty_th1a: SchoolBell 1.1 when 242 is fixed+reviewed. SchoolTool 0.10rc1 when 245 is fixed.19:14
jinty_th1a: yep. they are not essential.19:15
th1aOK.  Scared me there for a second.19:15
th1aI'm going to quit while I'm ahead and get lunch.19:15
* jinty_ starts laughing manically "power, power more power!!!!!"19:15
th1agintas_:  I thought jinty_ was refusing to port a release blocker.19:15
gintas_nah, it's just a minor itch19:16
*** th1a is now known as th1a|unch19:16
gintas_we bound ourselves to a Zope 3 revision which already had the i18n warnings, so we could as well get them fixed19:16
povbot`/svn/commits: * gintas committed revision 3984:19:18
povbot`/svn/commits: The composite timetable calendar is now overlaid unconditionally when you are viewing someone else's calendar.19:18
jinty_gintas_: If we weren't releasing tomorrow, I would have backported it. but now...19:18
gintas_argh, I was too late then ;)19:19
jinty_yep, the bar for patches goes up as release date approaches. It's all risk-reward analysis.19:20
* jinty_ 's battery is about to die, so he shuts down...19:20
*** jinty_ has left #schooltool19:20
povbot`/svn/commits: * gintas committed revision 3985:19:27
povbot`/svn/commits: Fixed typo.19:27
*** thisfred has quit IRC19:32
povbot`/svn/commits: * ignas committed revision 3986:19:33
povbot`/svn/commits: Final fixes for Issue243.19:33
*** bskahan has quit IRC19:34
*** gintas_ has quit IRC19:43
*** erchache has joined #schooltool19:54
erchachewhere i can get readme and install to translate to spanish and join to final 1.1 release?19:56
erchacheand jinti?20:01
povbot`/svn/commits: * ignas committed revision 3987:20:01
povbot`/svn/commits: Added __cmp__ attribute to content objects in schooltool. Issue243.20:01
mgedminerchache, try
mgedminthat's where the English README lives20:03
*** th1a|unch is now known as th1a20:15
erchacheenglish README smell very very bad20:29
erchachewho writes this? a klingong?20:29
Aistewhat kind of paper did you print it on, that it smells so bad? :)20:32
algaplease, to be providing patches20:32
Aisteon the second thought -- don't :)20:32
ignasIt is a goodday to write documentation!20:32
th1aOK, I'll have a look at it.20:33
*** gintas_ has joined #schooltool20:46
erchacheinstalling and configuring schoolbell was written by marx's brothers20:46
*** gintas_ is now known as gintas20:46
th1aWell, it seems like the most complicated approach to installing SchoolBell...20:47
erchachei dont translate testing.....20:48
erchacheif any wants to do it....maybe knows english20:48
erchachei dont know any programmer who doesnt understand english :P20:48
th1aWell, I should clean the README up.20:49
gintasby the way, how will we handle evolution in SchoolTool?20:50
*** bskahan has joined #schooltool20:50
gintaswe have a generations marker for SchoolBell, but I don't see one in SchoolTool20:50
gintasdon't we need one?20:50
th1aI certainly think so.20:50
bskahangintas: good catch20:53
erchachei finish20:53
erchachei add on spanish readme a lines for the unpatient ok?20:53
bskahanignas: I just added you to the sharing on that UI stories document20:54
bskahanalga: what's the correct way to test if a user is a manager in view code?20:56
erchachearrrrrghhh this readme make me feel a headache.....who writes it?20:56
mgedminthe machine that hosts schooltool's SVN repository is going down for 5-10 minutes21:02
mgedmin(one of the disks in the RAID array decided to fail last night)21:02
bskahanmgedmin: ok21:02
erchachei rewrite readme this night21:03
erchachewhere i send it?21:03
povbot`/svn/commits: * gintas committed revision 3988:21:03
povbot`/svn/commits: Added missing i18n:translate attributes on some tags in CSV import.21:03
th1aerchache:  You can send it to the dev list.21:04
th1aI have been letting jinty do the README.21:04
erchachei will do it now....because i want to include other readme for non-geeks you know?21:04
*** povbot has joined #schooltool21:20
ignasIMHO implementing some meaningfull title for Sections would have been a lot  better way to implement it21:25
ignasSection titles aretotaly useless now21:25
th1aThere are no meaningful titles for sections.21:25
th1aIf you have any idea of what they might be, I'd like to hear it.21:25
ignaswell so why not make titles a property that returns the label21:26
ignasis there a reason for that ?21:26
ignasthen we would not need the ugly getLabelOrTitle method21:26
ignasi mean21:26
ignas+            if ISection.providedBy(object):21:27
ignas+                return object.label21:27
ignas+            else:21:27
ignas+                return item.calendar.title21:27
ignasseemsevil to me21:28
mgedminI haven't reviewed that checkin yet21:28
th1aThe best solution I've heard at this point is to make it a user preference to decide which info is returned to describe a section.21:28
tvonbskahan: do you see it setting it in the edit view?21:28
mgedminit seems to me that sections now have a completely useless 'title' attribute and a useful 'label' attribute21:28
mgedminwhy not have a useful 'title' attribute?21:28
th1aWhat would it be?  It depends on your context.21:29
ignasbskahan said that making a separate portlet would be better than using title or label or even a user preference21:29
ignasth1a, same as label21:29
povbot/svn/commits: * gintas committed revision 3989:21:29
povbot/svn/commits: Added missing i18n:translate tags.21:29
th1amgedmin & ignas:  Do you guys understand the underlying problem here -- that to the student it is "mathematics II," but the mathematics teacher might teach five sections of "mathematics II," so it needs a different label in that context.21:31
ignasth1a, well currently Label is used for that21:31
bskahanignas: schooltool allready had a seperate overlay portlet it turned out21:32
ignasand you just used label in the portlet, so why not jsut make title identical to label ?21:32
th1aOK.  I don't have any particular concern about how it is implemented, as long as we understand what the problem is.21:32
bskahanbecause that was how the story was written21:33
bskahanI don't mind changing it after the release21:33
ignasthe same problem could have been solved in a better way21:35
bskahantvon: the __init__ method of CalendarEventAddView sets the timezone to the preference21:35
tvonbskahan: edit view doesnt, I'm fixing it now21:36
bskahantvon: ah21:36
ignasbecause the way it was solved seems well bad object oriented programming style21:36
bskahanignas: I'm happy to change it to title, but I won't be able to do it in time for the release21:37
bskahanat one point the title was a property similar to the label and it was suggested not to do that21:38
bskahani don't remember the argument against it21:38
ignaswell the title now is "Section"21:39
povbot/svn/commits: * tvon committed revision 3990:21:39
povbot/svn/commits: half a fix for 242.  This makes the edit view show the same time as the one displayed in the calendar. This should be backported.21:39
bskahanI've replaced the title with the label in the UI everywhere I saw it21:39
ignasimho changing title into property wouldhave saved you an hour or two ...21:40
bskahanignas: I had it that way21:40
ignasand would have been a much better way to solve the problem21:40
povbot/svn/commits: * gintas committed revision 3991:21:41
povbot/svn/commits: Added some missing i18n:translate tags.21:41
povbot/svn/commits: * gintas committed revision 3992:21:41
povbot/svn/commits: More i18n fixes.21:41
povbot/svn/commits: * gintas committed revision 3993:21:43
povbot/svn/commits: One interface used to create a form was not i18nalized properly.21:43
povbot/svn/commits: * gintas committed revision 3994:21:43
povbot/svn/commits: Spacing fix.21:43
povbot/svn/commits: * gintas committed revision 3995:21:44
povbot/svn/commits: Added an i18n:domain marker, without which i18n wouldn't work at all in the overlay portlet.21:44
*** gintas has quit IRC21:44
erchachesee tomorrow21:48
erchachelimite time to send files?21:48
th1aHm...  that's up to jinty.21:49
erchachemy files :P21:49
erchachejinty are frozen files now?21:50
th1aHe's not here.21:50
erchacheeerrr wrong question21:51
erchacheare to was21:51
erchachewas frozen files now?21:51
th1aFor something like a README, I don't think it should be a problem.21:51
th1aYou're not going to introduce any new bugs.21:52
erchachesee tomorrow21:52
*** erchache has quit IRC21:52
bskahanmgedmin: what was the security declaration you were talking about with regard to the broken ftest?21:55
bskahanfor some reason it works in the browser but not in the ftest21:56
mgedminbskahan, I wasn't21:56
mgedminthe broken ftest has nothing to do with security declarations21:56
bskahanoh, nm I must have been confused21:57
bskahanmgedmin: I see what you were referring to now22:01
povbot/svn/commits: * bskahan committed revision 3996:22:08
povbot/svn/commits: adding section navigation to the menu for users who can delete from the sections container.  Its ftested, but not unit tested, not sure I can track down the appropriate test setup in time, sorry about that.22:08
mgedminthat's bad :(22:10
algano test = no feature22:10
Aisteunfortunately POV is saddled with code quality control22:10
Aisteso, tough22:10
* tvon wants to know when this extra hour started showing up in events22:14
ignastvon, svn revision binary search22:15
ignas10 checkouts sohuld be enough :)22:15
mgedminis that one extra hour, or 2*timezone_offset?22:16
tvonmgedmin: I believe it's just one hour off22:16
tvonunless you are seeing something different22:16
bskahanI have to go find a power outlet22:16
tvontis in parse_timetz22:17
*** bskahan has quit IRC22:20
tvonor not22:21
povbot/svn/commits: * ignas committed revision 3997:22:21
povbot/svn/commits: Had some ViewErrors left. Will have to review functional tests of restive views.22:22
povbot/svn/commits: * ignas committed revision 3998:22:22
povbot/svn/commits: Updated TimetableSchemaContainerView so it would not allow deleting schemas. And would let you choose a default ttschema.22:23
tvonEurope/Oslo does *not* observe DST, correct?22:28
tvoner, no, it does22:29
tvonI need a tz that doesnt22:29
algasaudi arabia?22:31
algaparts of india?22:31
alga Hawaii, the only U.S. state in the tropics, does not observe DST.22:34
tvonthanks :)22:34
tvonwtf indeed22:42
tvonWe need to not have releases the day after a holiday weekend22:43
*** bskahan has joined #schooltool22:45
th1aYes, I apologize.22:47
*** Aiste has quit IRC22:52
*** ignas has quit IRC22:56
*** mgedmin has quit IRC22:56
povbot/svn/commits: * bskahan committed revision 3999:22:57
povbot/svn/commits: reverted the conditional part of 3996, sections container is now treated like the other containers for the pupose of view and delete.22:57
*** alga has quit IRC22:58
bskahancan anyone point to where is doc/unit tested?23:11
bskahanthat would have the same test fixtures I'm looking for23:11
*** Aiste has joined #schooltool23:19
*** Aiste has quit IRC23:19
*** bskahan has quit IRC23:33
*** bskahan has joined #schooltool23:46
*** bska|mobile has joined #schooltool23:53

Generated by 2.15.1 by Marius Gedminas - find it at!