| *** replaceafill has quit IRC | 01:30 | |
| *** robb_nl has joined #schooltool | 13:51 | |
| *** robb_nl has quit IRC | 15:24 | |
| *** replaceafill has joined #schooltool | 18:27 | |
| th1a | hi replaceafill. | 18:28 |
|---|---|---|
| replaceafill | hey th1a | 18:29 |
| th1a | Did you make any progress on the bugs... I'm sure it isn't very motivating at this point... | 18:29 |
| replaceafill | right | 18:29 |
| replaceafill | i checked the date "issue" | 18:30 |
| replaceafill | it's caused by the unenroll view | 18:30 |
| replaceafill | well | 18:30 |
| replaceafill | let me try to explain... | 18:30 |
| replaceafill | when the student is unenrolled they get inactive from their sections/groups | 18:31 |
| replaceafill | and their level, also inactive | 18:31 |
| replaceafill | but re-enrolled only sets the level and students group membership back | 18:32 |
| th1a | Because you wouldn't know the stream. | 18:32 |
| th1a | ? | 18:32 |
| replaceafill | because we just didn't i guess | 18:33 |
| replaceafill | i mean | 18:33 |
| replaceafill | there could be a lot of ways of doing it i guess | 18:33 |
| th1a | It would be another step. | 18:33 |
| replaceafill | activate everything from the reenroll date, etc | 18:33 |
| th1a | But basically, adding someone to a stream (and thus sections) is always a different step than enrolling them in the school. | 18:34 |
| replaceafill | i mean, some complex date logic on their old memberships | 18:34 |
| th1a | Well, ok, but it is not part of this feature. | 18:34 |
| th1a | There is no difference between re-enroll and just enroll. Does it say "re-enroll" on the link? | 18:35 |
| replaceafill | yes | 18:35 |
| th1a | So the answer is that they just need to manually put the person back in the stream. | 18:35 |
| replaceafill | i think so | 18:36 |
| th1a | OK. | 18:37 |
| replaceafill | the streams would fire the handlers to enroll the person back into their sections | 18:37 |
| th1a | Yes, I can handle that reply. | 18:37 |
| replaceafill | but i haven't tested it yet | 18:37 |
| replaceafill | ok | 18:37 |
| th1a | I don't think it is complicated. | 18:37 |
| replaceafill | the other "problem" | 18:37 |
| replaceafill | is the reports | 18:37 |
| replaceafill | so, the student is not appearing back in the reports | 18:37 |
| replaceafill | well, Piyali has reported two different issues | 18:37 |
| replaceafill | i was able to understad the "student not appearing" after being reenrolled | 18:38 |
| replaceafill | it's because the student has been removed from their SECTIONS | 18:38 |
| replaceafill | so, the report thinks they're inactive students | 18:38 |
| replaceafill | even if their level is set | 18:39 |
| replaceafill | again, adding the student back to the stream, and assuming the stream is correctly linked to the sections | 18:39 |
| replaceafill | would fix it | 18:39 |
| th1a | OK. | 18:39 |
| th1a | I suspect this whole thing is something Fran might have filtered out. | 18:39 |
| th1a | I can answer these. | 18:40 |
| replaceafill | i think the leave school, come back thing was designed mainly for peas | 18:40 |
| replaceafill | but now isli and rising have used/tested it | 18:40 |
| th1a | I'm going to say the main thing is that the main use case is not, oh, I pressed the wrong button, undo that. | 18:41 |
| replaceafill | right | 18:41 |
| th1a | It is for a student who has actually left for a potentially longer period of time. | 18:41 |
| th1a | It is really just one more step anyhow. | 18:41 |
| th1a | OK. | 18:42 |
| replaceafill | i think "a" bug is | 18:43 |
| replaceafill | unenrolled should make your streams inactive | 18:44 |
| replaceafill | it doesn't | 18:44 |
| replaceafill | because we didn't have streams at the time | 18:44 |
| replaceafill | and the "feature" was never updated | 18:44 |
| th1a | Oh... | 18:44 |
| th1a | OK. | 18:44 |
| th1a | So, the person isn't added to the sections because there is no stream change event. | 18:45 |
| th1a | And they'll have to remove the person from the stream and put them back in. | 18:45 |
| replaceafill | yes | 18:46 |
| replaceafill | but let me try that | 18:46 |
| replaceafill | before suggesting it | 18:46 |
| th1a | OK, so can you make a change to the unenroll to take them out of the stream. | 18:46 |
| replaceafill | yes | 18:46 |
| th1a | OK. | 18:46 |
| th1a | Let me know when you're settled on that. | 18:47 |
| replaceafill | give me a moment | 18:49 |
| replaceafill | th1a, no, it won't work | 18:55 |
| replaceafill | removing the student from the stream and putting them back | 18:55 |
| th1a | *sigh* | 18:55 |
| replaceafill | yeah, sigh | 18:56 |
| replaceafill | they need to put the student back in their SECTIONs | 18:56 |
| th1a | Agh... | 18:57 |
| th1a | Do you have any idea why it doesn't work? | 18:57 |
| replaceafill | yeah | 18:57 |
| replaceafill | remember the relationship views have Current and Available tables | 18:57 |
| replaceafill | areas, or whatever | 18:58 |
| replaceafill | the current assumes "we're removing items" | 18:58 |
| *** yvl has quit IRC | 18:58 | |
| replaceafill | and available assumes "we're adding items" | 18:58 |
| th1a | This may be a lower level aspect of relationships than I actually know about, or at least remember. | 18:58 |
| th1a | Keep going. | 18:59 |
| replaceafill | well, it's like "add this student to this section, when the student is already there" | 18:59 |
| th1a | Ah, the stream doesn't know they've been removed? | 19:00 |
| replaceafill | the view should just update | 19:00 |
| th1a | From the sections? | 19:00 |
| replaceafill | the status | 19:00 |
| replaceafill | yes | 19:00 |
| th1a | OK... I guess we should fix that? | 19:00 |
| replaceafill | when the stream goes through all its sections | 19:00 |
| replaceafill | it first checks the student is not there, before adding them | 19:00 |
| replaceafill | yes, it's a bug | 19:01 |
| replaceafill | but, this whole thing stinks | 19:01 |
| th1a | Well, I'm not worried about the whole thing. | 19:01 |
| th1a | I think the whole thing is fine, but we have two small bugs. | 19:01 |
| replaceafill | ok | 19:02 |
| th1a | As long as I can say "You have to add them back to the stream after you re-enroll" and it works, that's fine. | 19:02 |
| replaceafill | yeah | 19:02 |
| th1a | Re-enroll should *not* try to guess which stream the person belongs in. | 19:03 |
| replaceafill | i guess we could tell Francisco just to add the student back to their sections individually | 19:04 |
| replaceafill | a work around obviously | 19:04 |
| th1a | Yes. | 19:04 |
| replaceafill | the student hasn't been removed from their streams (because the other bug) | 19:04 |
| replaceafill | ok, i'll file these bugs | 19:04 |
| th1a | OK. | 19:05 |
| th1a | I'll send an update. | 19:05 |
| th1a | And let you get to it. It doesn't seem like I'm going to resolve where Dinwiddie is going myself, so I'm just going to email them about our closing and point them to Glenda. | 19:06 |
| th1a | Thanks replaceafill. | 19:06 |
| replaceafill | ok | 19:06 |
| th1a | All set? | 19:12 |
| replaceafill | i wish i just could drop this shit and leave... | 19:20 |
| th1a | Well, you are going to. | 19:20 |
| replaceafill | syncing all of this crap this way just doesn't make sense | 19:20 |
| replaceafill | i mean, now! | 19:20 |
| replaceafill | today! | 19:20 |
| replaceafill | great, streams work now (HOPEFULLY!)... | 19:21 |
| th1a | OK, I'll write the email. | 19:22 |
| replaceafill | there are so many things i hate about all of this | 19:25 |
| replaceafill | (venting time) | 19:25 |
| replaceafill | but the one i think i hate the most is: me (the developer) has no fucking idea how this should work... | 19:26 |
| replaceafill | there's no a single blueprint/doc/txt file with a spec about any of this | 19:26 |
| replaceafill | granted, this was a dumb bug | 19:27 |
| replaceafill | "easy" to track | 19:27 |
| replaceafill | but it's the same issue over and over | 19:27 |
| replaceafill | i guess we can tell Piyali to try "her issues" in the testing instances now that streams are supposed to work | 19:28 |
| replaceafill | the issue she raised about the streams list and the gradebook not being the same was caused by the same bug | 19:29 |
| replaceafill | (i think...) | 19:29 |
| th1a | OK. | 19:39 |
| th1a | Yeah, I mean, we knew this would be a problem without Fran. | 19:39 |
| th1a | OK, so I can tell her to test on the instance, manually adding the person to the stream. | 19:40 |
| replaceafill | yeah | 19:40 |
| th1a | OK, I assume you've tried putting unenrol / re-enrol / re-streaming on the demo instance? | 19:57 |
| th1a | replaceafill? | 19:57 |
| th1a | OK. | 19:57 |
| th1a | Yes, I'll tell them to try it. | 19:57 |
| replaceafill | th1a, hm? | 19:57 |
| th1a | I'm just repeating myself. | 19:57 |
| replaceafill | you mean if i updated it with the stram bugs fix | 19:58 |
| replaceafill | ah ok | 19:58 |
| replaceafill | the remaining bug is about unenroll not removing streams | 19:58 |
| replaceafill | but i guess that's not a priority... | 19:58 |
| th1a | Oh, uh, well, it depends on "how hard it is." | 19:59 |
| replaceafill | it's like everything, you can fix it in an hour | 19:59 |
| th1a | But what else have you broken... ? | 19:59 |
| replaceafill | but it'll probably break under heavy testing | 19:59 |
| replaceafill | yeah | 19:59 |
| replaceafill | not that "invasive" though | 20:00 |
| replaceafill | it's just adding logic | 20:00 |
| replaceafill | not modifying | 20:00 |
| th1a | Yeah, it SEEMS straightforward enough. | 20:00 |
| th1a | I'd rather you fix that then so we can at least give them a clean version without a hacky workaround. | 20:00 |
| th1a | They're all done for the day anyhow. | 20:01 |
| replaceafill | workaround? | 20:01 |
| th1a | remove this person from the stream and immediately re-ad them? | 20:01 |
| replaceafill | what's your "dream" solution to their current situation? | 20:02 |
| th1a | Pretty much just making sure they're removed from the stream when they're un-enroled. | 20:02 |
| th1a | Otherwise it is behaving correctly. | 20:02 |
| th1a | You really DON'T want re-enrol to act like 'undo.' | 20:02 |
| replaceafill | ok... | 20:04 |
| th1a | You should just be mad at me for not wrapping my head around that immediately. | 20:04 |
| th1a | It is easy to cruise along with the users's interpretation of the functionality. | 20:05 |
| replaceafill | no, i'm mad at us (developers of this crap) not having a stinky document about any of this | 20:06 |
| replaceafill | "where's the user doc for streams..." | 20:06 |
| replaceafill | "never done..." | 20:06 |
| replaceafill | "how's supposed to work" | 20:06 |
| replaceafill | "shrugs.." | 20:07 |
| replaceafill | i'm 100% clear *YOU* know how all of this should work | 20:07 |
| th1a | Well, the users didn't really have a clear idea either when we did the first implementation. | 20:07 |
| th1a | The problem is that as I programmer I just figure out shit as I go. | 20:07 |
| th1a | So if I try to think like a programmer I just think "Oh, just wade in..." | 20:09 |
| replaceafill | ok | 20:10 |
| th1a | OK, so if you'd like to clean up the unenrol and ping me I've got the email written. | 20:10 |
| replaceafill | ok | 20:10 |
| replaceafill | give me a couple of hours | 20:10 |
| replaceafill | i have to go get Camila now | 20:10 |
| replaceafill | it *should* be quick... :/ | 20:11 |
| replaceafill | (fixing it) | 20:11 |
| th1a | OK. Thanks replaceafill. | 20:11 |
| replaceafill | thanks th1a | 20:11 |
| replaceafill | th1a, fixed | 20:15 |
| replaceafill | do you mind doing some QA...? | 20:16 |
| replaceafill | unenroll *should* remove streams now | 20:16 |
| * replaceafill gone for a bit | 20:17 | |
| *** zwelch has joined #schooltool | 20:44 | |
| zwelch | i've installed schooltool on my server (ubuntu 16.04), and I have noticed a couple of discrepencies between the docs and the version i have installed. If I had to guess (and IIRC), I think the docs cover a slightly newer version which contains a couple of new features. Which begs the question, how do i get said latest version? i'm also asking because i seem to have hit a bug trying to delete a timeline. | 21:14 |
| zwelch | more ambitiously, i expect to be able to contribute new features, so i'll want to run/deploy a custom version at some point | 21:15 |
| *** zwelch has quit IRC | 21:22 | |
| *** zwelch has joined #schooltool | 21:48 | |
| * zwelch slowly realizes that joining IRC from a laptop that autosuspends probably wasn't the brightest idea of his day | 21:48 | |
| zwelch | incidentally, well done on the ubuntu integration and documentation. aside from the minor mismatch (above), i've been seriously impressed with what i've seen so far, and i'm still working my way through the tutorial. :) | 23:08 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!