| *** robb_nl has joined #schooltool | 14:31 | |
| *** replaceafill has joined #schooltool | 17:09 | |
| th1a | I'm replying to Glenda's ZODB email now (sorry I forgot yesterday). | 17:11 |
|---|---|---|
| replaceafill | th1a, kk | 17:12 |
| replaceafill | she sent a new email today | 17:12 |
| replaceafill | that shows where zope is located at least | 17:12 |
| replaceafill | /home/zope | 17:12 |
| th1a | Ah. | 17:13 |
| th1a | I wasn't sure how to answer that, so if you'd take a crack at it now. | 17:13 |
| replaceafill | i have no idea about that one | 17:13 |
| th1a | OK, perhaps you could tell her that. | 17:14 |
| replaceafill | done | 17:22 |
| replaceafill | couldn't find what janus is | 17:22 |
| th1a | np | 17:23 |
| th1a | Not actually our job... | 17:23 |
| th1a | OK, shall we look at Fran's list? | 17:24 |
| replaceafill | ok | 17:25 |
| replaceafill | i haven't looked the databases she sent yet | 17:25 |
| th1a | OK, unenrolled students. | 17:26 |
| th1a | Is she just talking about graduated students (not unenroll link students)? | 17:27 |
| replaceafill | both | 17:27 |
| th1a | OK. | 17:27 |
| th1a | So essentially that was never an explicit requirement? | 17:27 |
| th1a | I mean, I think we discussed it being essentially harmless, except now apparently for some reports? | 17:28 |
| replaceafill | i'm going to start playing a card: | 17:28 |
| replaceafill | if it's not in the blueprint, it was not a requirement | 17:28 |
| th1a | Right. | 17:28 |
| replaceafill | all i can understand from the first two bullets is: | 17:28 |
| replaceafill | uneroll needs to remove active levels (i remember it does) | 17:29 |
| replaceafill | unenroll and graduate view needs to remove from students group | 17:29 |
| replaceafill | i started to fix bullet 3 (All Students) when i noticed the level fuck up | 17:30 |
| th1a | Yes. | 17:30 |
| replaceafill | bullet 4 was caused by the fuck up | 17:30 |
| replaceafill | students lost their old level | 17:30 |
| th1a | Let's stick with one and two. | 17:31 |
| replaceafill | so the report doesn't find anyone that match | 17:31 |
| replaceafill | ok | 17:31 |
| th1a | Fran doesn't quite understand that the reason there is an "unenroll" link is that it does several things. | 17:31 |
| th1a | There are separate, unrelated steps. | 17:31 |
| th1a | So, the original link on the student's page currently *DOES* change the level setting when it removes the student from the group. | 17:33 |
| th1a | ? | 17:33 |
| replaceafill | eh, can you rephrase that? | 17:33 |
| replaceafill | i assume you're talking about the "uneroll" link? | 17:34 |
| th1a | Does the unenroll link do anything to the student's level? | 17:34 |
| replaceafill | yes, it's supposed to remove the current active one | 17:34 |
| th1a | Just so I understand this... what do we mean by "remove" there? | 17:34 |
| replaceafill | set as inactive | 17:34 |
| th1a | As if the effective date. | 17:35 |
| replaceafill | yes, it uses the same unenroll date | 17:35 |
| th1a | OK. | 17:35 |
| th1a | So... | 17:35 |
| th1a | What she's really saying is that the graduate form wasn't setting the level to inactive. | 17:35 |
| th1a | Which we discussed last week. | 17:35 |
| replaceafill | yeah | 17:36 |
| th1a | OK, and we're billing for that. | 17:36 |
| th1a | But you haven't done it yet. | 17:37 |
| th1a | ? | 17:37 |
| replaceafill | no | 17:37 |
| replaceafill | and didn't we agree we're not billing for promote/graduate stuff? | 17:38 |
| th1a | Oh, shit. Right. | 17:38 |
| th1a | Sorry. | 17:38 |
| th1a | *sigh* | 17:38 |
| th1a | OK. | 17:38 |
| th1a | Hopefully you won't have to keep reminding me of that. | 17:38 |
| th1a | OK. | 17:38 |
| replaceafill | :/ | 17:39 |
| th1a | So the answer to the first bullet is -- you're going to fix that. | 17:39 |
| replaceafill | wait | 17:39 |
| replaceafill | to me the first bullet is about the unenroll view | 17:40 |
| replaceafill | "so any students that we graduated into the next level and then unenrolled from Dec 2015" | 17:40 |
| th1a | OK, let me ask a clarifying question, because I think she's being imprecise. | 17:40 |
| replaceafill | ok | 17:41 |
| th1a | It doesn't make sense to graduate then unenroll. | 17:41 |
| th1a | "In other words, when a student graduates -- through the graduate view -- their level is not also set to inactive. That is the bug, correct?" | 17:42 |
| replaceafill | that's what you're writing? | 17:43 |
| th1a | Yes. | 17:43 |
| replaceafill | seems fine | 17:43 |
| th1a | OK. | 17:43 |
| th1a | Is the second one because they are graduated-active? | 17:43 |
| th1a | Second bullet? | 17:44 |
| replaceafill | no, because they're not removed from the students group | 17:44 |
| th1a | OK. | 17:44 |
| replaceafill | sorry | 17:44 |
| replaceafill | i mean, they're not marked as inactive :) | 17:44 |
| th1a | ? | 17:44 |
| th1a | There is just no change? | 17:45 |
| replaceafill | graduated/inactive to be precise | 17:45 |
| replaceafill | yeah, graduate just modifies the level | 17:45 |
| * th1a is completely baffled. | 17:45 | |
| th1a | What does graduate modify the level to currently? | 17:46 |
| replaceafill | graduate/inactive | 17:46 |
| replaceafill | but it doesn't touch group memberships | 17:46 |
| replaceafill | so when she goes back to the School page | 17:46 |
| replaceafill | she looks the Students box | 17:46 |
| replaceafill | with the same number | 17:46 |
| replaceafill | she was expecting all those graduated people to not be students anymore i guess | 17:47 |
| th1a | OK, but if the view currently modifies the level, what is the bug in the first bullet point. | 17:47 |
| replaceafill | sigh... | 17:48 |
| th1a | The problem here is that we've lost all track of what "common sense" is in this case. | 17:48 |
| replaceafill | sure, because your common sense, her common sense and my common sense is nowhere documented... | 17:48 |
| replaceafill | again: | 17:48 |
| replaceafill | bullet 1 | 17:48 |
| replaceafill | level is supposed to be modified | 17:49 |
| replaceafill | bullet 2 | 17:49 |
| replaceafill | students membership supposed to be modified | 17:49 |
| th1a | Yes, but you just said above "graduate just modifies the level" | 17:50 |
| replaceafill | that's the bug, right? | 17:50 |
| replaceafill | she ran it | 17:50 |
| replaceafill | it didn't happen the way it's supposed to | 17:50 |
| th1a | OK. | 17:50 |
| replaceafill | now i need to dig into the db to see what's going on | 17:50 |
| th1a | So that's a bug bug. | 17:50 |
| replaceafill | lol | 17:51 |
| replaceafill | ?!?! | 17:51 |
| replaceafill | bug bug? | 17:51 |
| th1a | Not a misunderstanding bug. | 17:51 |
| th1a | Not a requirements bug. | 17:51 |
| replaceafill | yeah | 17:51 |
| replaceafill | lol | 17:51 |
| replaceafill | a bug bug | 17:51 |
| th1a | OK, fine. | 17:51 |
| th1a | First one is a bug bug, second is a small added feature. | 17:52 |
| replaceafill | yeah | 17:52 |
| th1a | That's what had me really thrown off. | 17:52 |
| th1a | OK. | 17:52 |
| th1a | Now... | 17:52 |
| replaceafill | glad you're in sync now ;) | 17:53 |
| replaceafill | i always expect th1a with lots of cards on the wall | 17:53 |
| replaceafill | moving and updating | 17:53 |
| replaceafill | :) | 17:53 |
| th1a | I try not to have that many balls in there air. | 17:54 |
| th1a | It isn't like I can juggle tasks between developers. | 17:54 |
| replaceafill | anyway | 17:54 |
| th1a | OK, we need all hands on... oh wait. | 17:54 |
| replaceafill | moving on | 17:54 |
| th1a | Next four are the aforementioned "report bugs." | 17:54 |
| replaceafill | yeah | 17:54 |
| replaceafill | that'll be a heavy change | 17:55 |
| replaceafill | but needed i'm afraid | 17:55 |
| replaceafill | and this time | 17:55 |
| replaceafill | i'll just suck the tests | 17:55 |
| replaceafill | it's enough | 17:55 |
| th1a | How much beyond the level fix? | 17:55 |
| replaceafill | ! | 17:55 |
| replaceafill | i mean, i'll do it gradually | 17:55 |
| replaceafill | starting with the ones she's listing here | 17:55 |
| replaceafill | but most of the levels regarding levels | 17:56 |
| replaceafill | attendance mostly | 17:56 |
| replaceafill | need to change | 17:56 |
| th1a | Oh, just generally making the tests smarter about years? | 17:56 |
| replaceafill | first, having the tests... | 17:56 |
| replaceafill | we have 0!!!! | 17:56 |
| th1a | I mean, reports, sorry. | 17:56 |
| th1a | ! | 17:56 |
| replaceafill | yeah | 17:56 |
| th1a | Any thoughts about the individual report card issue? | 17:57 |
| replaceafill | same issue | 17:57 |
| replaceafill | ok | 17:57 |
| replaceafill | let me try to explain | 17:57 |
| replaceafill | the request view | 17:57 |
| replaceafill | has a level dropdown | 17:57 |
| replaceafill | so you can create report cards for the whole level | 17:57 |
| replaceafill | so, last year Tom was in level 1 | 17:58 |
| replaceafill | in sections: Math-Level-1, Physics-Level-1, etc | 17:58 |
| replaceafill | the report first looks for persons in level one to filter | 17:58 |
| replaceafill | the report card was empty becuase that level history was lost | 17:58 |
| th1a | Ah, so it is also related to levels. | 17:59 |
| replaceafill | yes | 17:59 |
| th1a | OK. | 17:59 |
| replaceafill | that's why Fran wrote "level issue" | 17:59 |
| replaceafill | i kind of replied already to these issues | 17:59 |
| th1a | Sorry, I meant "• Action to generate an individual student report card not found on student profile – need to mention to schooltool" | 17:59 |
| replaceafill | are we schooltool? :D | 18:00 |
| replaceafill | yeah | 18:00 |
| replaceafill | that's a new feature imho | 18:00 |
| replaceafill | again | 18:00 |
| replaceafill | sorry for being pedantic | 18:00 |
| replaceafill | but you probably forget history on this... | 18:00 |
| replaceafill | we first developed a report card | 18:01 |
| replaceafill | for uganda | 18:01 |
| replaceafill | when peas was the only project | 18:01 |
| replaceafill | remember that? | 18:01 |
| replaceafill | that report was by student | 18:01 |
| th1a | OK. | 18:01 |
| replaceafill | in this last couple of iterations fran came up with this new awesome report card | 18:01 |
| replaceafill | the old one (first) probably was never used | 18:01 |
| replaceafill | the new one is by year | 18:02 |
| replaceafill | there's no option to get it for a single student | 18:02 |
| replaceafill | that's what she means here i think | 18:02 |
| replaceafill | we don't need just the "action", we need the adapt the current (by level, stream) report for a single student | 18:02 |
| th1a | I guess we've got a blueprint? | 18:03 |
| replaceafill | hm? | 18:03 |
| th1a | I'm not clear on why the new one does not have a single student version. | 18:04 |
| replaceafill | https://blueprints.launchpad.net/schooltool.peas/+spec/report-card | 18:04 |
| replaceafill | see the first line | 18:04 |
| replaceafill | the estimate one | 18:04 |
| th1a | OK, right, so it is very clear that they did not want that at the time. | 18:05 |
| replaceafill | yep | 18:05 |
| th1a | They might say "Oh, we just want the old one for individuals?" | 18:05 |
| replaceafill | i don't think so | 18:05 |
| replaceafill | the old one doesn't work for them anymore | 18:05 |
| th1a | OK. | 18:05 |
| th1a | So basically I should say "We discussed this option at the time and you deferred paying for it, see..." | 18:06 |
| replaceafill | ok | 18:06 |
| th1a | OK, next bullet. | 18:07 |
| replaceafill | lol | 18:07 |
| th1a | Do you think they want per-year school information? | 18:07 |
| replaceafill | "schools won't want to generate the report cards one by one" | 18:08 |
| replaceafill | ok | 18:08 |
| replaceafill | that's a bug bug | 18:08 |
| replaceafill | they were able to | 18:08 |
| replaceafill | the change to schooltool.ark probably messed that up | 18:08 |
| replaceafill | ark overrides the school info view too | 18:09 |
| replaceafill | sorry, it looks like a left over | 18:09 |
| replaceafill | i don't think they need per-year school info for this | 18:09 |
| replaceafill | (phone, contact, etc) | 18:09 |
| th1a | "Ok, that's probably a bug introduced when we merged the code." | 18:09 |
| replaceafill | yep | 18:09 |
| replaceafill | sigh... | 18:09 |
| replaceafill | it's 2016.... | 18:10 |
| th1a | No biggie, really. | 18:10 |
| replaceafill | next bullet? | 18:10 |
| th1a | Look, she needed it in 3 days, we said we'd do it in three days. | 18:10 |
| replaceafill | moving on th1a | 18:10 |
| th1a | Yes. | 18:10 |
| replaceafill | sorry i'm crabby today | 18:10 |
| th1a | There's nothing to get excited about here, but nothing terrible. | 18:11 |
| replaceafill | last bullet is a new feature | 18:11 |
| replaceafill | similar to what we added for rising | 18:11 |
| replaceafill | a Streams fieldset | 18:11 |
| replaceafill | rising shows 3 stream dropdowns | 18:11 |
| replaceafill | peas has to show only one | 18:11 |
| th1a | OK, I'll create a blueprint and link to it. | 18:11 |
| replaceafill | kk | 18:12 |
| th1a | In terms of instances affected, basically just if they'd all try to promote/graduate tomorrow, they'd have the same issue? | 18:12 |
| th1a | Have you pushed a fix to not erase the level data? | 18:13 |
| replaceafill | yes | 18:13 |
| replaceafill | if they run it today, there's no issue | 18:14 |
| th1a | OK, so you wouldn't expect ISLI/Rising to see new errors. | 18:14 |
| replaceafill | but i think rising ran it a month ago or so | 18:14 |
| replaceafill | that's when we packaged it the first time | 18:14 |
| th1a | Oh... | 18:14 |
| replaceafill | i have no news on that | 18:14 |
| replaceafill | if they did, the bug is there too | 18:14 |
| th1a | What day did you fix the level issue? | 18:15 |
| replaceafill | the day i realized about it | 18:16 |
| th1a | I just want to say "If you promoted before..." | 18:17 |
| th1a | Wednesday? | 18:17 |
| replaceafill | 2016-02-05 | 18:17 |
| replaceafill | https://launchpad.net/~sielibre/+archive/ubuntu/ark-project | 18:17 |
| replaceafill | fix is in 2.10.9 | 18:18 |
| th1a | If any school used the promote view before last Friday, they'll have the same level bug. If any school currently uses the graduation view, they'll run into the graduation related bugs, until we push a fix for the grad view. Otherwise, they should not be seeing new bugs. | 18:18 |
| replaceafill | ok... | 18:19 |
| th1a | And the same fixes will apply across all 3. Basically, the versions are in much closer sync now, on the same core PPA. | 18:20 |
| replaceafill | yeah | 18:21 |
| th1a | OK, guess that's it. | 18:21 |
| replaceafill | ok | 18:22 |
| th1a | Nothing too scary. ;-) | 18:22 |
| replaceafill | :/ | 18:22 |
| th1a | Should I let you go? | 18:24 |
| replaceafill | ok | 18:24 |
| th1a | Thanks replaceafill. | 18:25 |
| replaceafill | thanks th1a | 18:25 |
| *** yvl has quit IRC | 18:56 | |
| *** robb_nl has quit IRC | 19:51 | |
| *** zerkalo has joined #schooltool | 23:44 | |
| *** zerkalo_ has quit IRC | 23:48 | |
| *** replaceafill has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!