*** yvl has joined #schooltool | 10:19 | |
*** khildin has joined #schooltool | 14:06 | |
*** khildin has quit IRC | 14:11 | |
*** replaceafill has joined #schooltool | 17:37 | |
replaceafill | hey th1a | 17:37 |
---|---|---|
replaceafill | sorry i'm late | 17:37 |
th1a | Perfect timing. | 17:39 |
th1a | Just got my paper layout call in. | 17:40 |
replaceafill | ah | 17:40 |
replaceafill | :) | 17:40 |
th1a | OK, just a sec... | 17:41 |
replaceafill | kk | 17:41 |
th1a | OK. | 17:42 |
th1a | How was your weekend? | 17:42 |
replaceafill | good | 17:43 |
replaceafill | went exercising after a while | 17:43 |
replaceafill | and studied progress messages | 17:43 |
replaceafill | :) | 17:43 |
replaceafill | for the progress bars | 17:43 |
th1a | Ah. | 17:43 |
th1a | OK, shall we start with Proximity? | 17:44 |
replaceafill | sure | 17:44 |
th1a | How long can you talk now, btw? | 17:44 |
replaceafill | well, i'd like to get breakfast | 17:45 |
replaceafill | you want to walk through the functionality? | 17:45 |
th1a | We have a long walk. | 17:46 |
th1a | Go ahead and get breakfast then. | 17:46 |
th1a | Do you have any pickups? | 17:46 |
replaceafill | kk, give me 10 mins | 17:46 |
replaceafill | pickups? | 17:46 |
th1a | You can take more than that. | 17:46 |
replaceafill | brb in 10 | 17:47 |
replaceafill | th1a, ready | 17:59 |
th1a | OK. | 18:00 |
th1a | I mean, do you have to take off to get your daughter? | 18:00 |
replaceafill | yes, but in around 2.5 hours | 18:01 |
th1a | OK. | 18:01 |
*** yvl has quit IRC | 18:30 | |
th1a | ayt replaceafill? | 21:28 |
replaceafill | hey th1a | 21:43 |
th1a | I'm writing Denise an email. | 21:44 |
th1a | Have you looked at her bugs yet? | 21:44 |
replaceafill | no, had to install a windows vm | 21:45 |
replaceafill | it works on chrome | 21:45 |
th1a | OK. | 21:45 |
replaceafill | and ff | 21:45 |
th1a | OK, I just remembered I need to send her an invoice, so I need to generate that. | 21:46 |
th1a | I'll ping you before I send. | 21:46 |
th1a | any news replaceafill? | 22:26 |
replaceafill | no not yet | 22:26 |
th1a | OK. | 22:26 |
replaceafill | was able to reproduce | 22:26 |
replaceafill | in IE8 | 22:26 |
replaceafill | but don't understand it yet | 22:26 |
th1a | OK. | 22:26 |
replaceafill | it complains about an if... | 22:26 |
replaceafill | found the issue | 22:32 |
replaceafill | ok | 22:32 |
replaceafill | fixing | 22:32 |
replaceafill | first time in my life i've used IE developer tools :S | 22:38 |
replaceafill | i feel... not me | 22:38 |
th1a | lol | 22:38 |
replaceafill | th1a we should add that to the contract | 22:38 |
replaceafill | ff and chrome only supported browsers :P | 22:38 |
replaceafill | f**k IE | 22:38 |
replaceafill | to be fair, it was not IE fault :( | 22:39 |
th1a | What was the problem? | 22:41 |
replaceafill | bad prototype function registry | 22:41 |
replaceafill | for emulating "startsWith" | 22:41 |
replaceafill | when comparing strings | 22:41 |
th1a | OK... is that something buried in jquery? | 22:42 |
replaceafill | no, it's the logic on that page to refresh the Name dropdowns | 22:42 |
replaceafill | after you have picked a type | 22:42 |
replaceafill | ok | 22:43 |
replaceafill | packaging... | 22:43 |
th1a | OK, no problem. | 22:43 |
th1a | What about the other thing? | 22:43 |
th1a | Didn't she have two issues? | 22:43 |
replaceafill | i wasn't able to reproduce the other one | 22:44 |
replaceafill | even IE worked | 22:44 |
th1a | OK. | 22:44 |
replaceafill | and it's a standard form | 22:44 |
replaceafill | no JS or anything | 22:44 |
th1a | Maybe an agressive cache? | 22:44 |
replaceafill | unlikely, the whole page gets rendered at once | 22:45 |
replaceafill | i mean, form | 22:45 |
th1a | OK, so this is what you can't reproduce: Under “College”, when I enter a major for the test student, Sarah Pattonstudent, and hit Apply, it shows up on her record. Once I navigate away from her record and then go back, no entry is there. I tried it a couple of times and each time it happened. | 22:48 |
replaceafill | hold on | 22:49 |
replaceafill | let me try something | 22:49 |
replaceafill | ah, got it | 22:51 |
replaceafill | well, reproduced | 22:51 |
* replaceafill blames the base viewlet | 22:51 | |
th1a | OK, good. | 22:51 |
replaceafill | ok th1a found the issue | 23:01 |
replaceafill | but it'll take a little time to clean | 23:02 |
th1a | What was it? | 23:02 |
replaceafill | problem was the split | 23:02 |
replaceafill | of a single form into small ones | 23:02 |
replaceafill | the fields in the college accordion come from the same base form | 23:02 |
replaceafill | and all the fields get included in the subforms | 23:02 |
replaceafill | i just need to filter the unsued fields out | 23:03 |
replaceafill | the user sees only one field | 23:03 |
replaceafill | but the form is carrying/updating the rest | 23:03 |
th1a | OK. | 23:03 |
replaceafill | ok fixed th1a | 23:19 |
th1a | Cool. | 23:19 |
replaceafill | this shows we need tests for this :( | 23:19 |
replaceafill | i'll package the fix | 23:19 |
th1a | Well, yeah... | 23:19 |
replaceafill | let me rephase that, we need better coverage :) | 23:20 |
th1a | https://docs.google.com/document/d/13ep_n1yxr-G0S7E2dR7y5UbIcCZaujEJdx52wo_Gv20/edit?usp=sharing | 23:25 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!