*** replaceafill has quit IRC | 00:33 | |
*** menesis has left #schooltool | 00:39 | |
*** yvl has joined #schooltool | 07:47 | |
*** menesis has joined #schooltool | 09:25 | |
*** khildin has joined #schooltool | 13:34 | |
*** menesis has quit IRC | 13:41 | |
*** yvl has quit IRC | 14:06 | |
*** yvl has joined #schooltool | 14:19 | |
*** yvl has quit IRC | 14:34 | |
*** yvl has joined #schooltool | 14:39 | |
*** menesis has joined #schooltool | 14:50 | |
*** khildin has quit IRC | 15:02 | |
*** khildin has joined #schooltool | 15:15 | |
*** khildin has quit IRC | 15:43 | |
*** khildin has joined #schooltool | 16:04 | |
*** replaceafill has joined #schooltool | 16:29 | |
replaceafill | th1a, i need to go downstairs, i'll be back in 5-10 mins | 16:30 |
---|---|---|
th1a | ok | 16:31 |
replaceafill | back | 16:38 |
replaceafill | hi th1a | 16:38 |
th1a | hey | 16:38 |
th1a | How is ckedit hell? | 16:39 |
replaceafill | ok, hold on | 16:39 |
replaceafill | first thing | 16:40 |
replaceafill | we're not really using ckeditor 3.6.1 | 16:40 |
replaceafill | in the deb packages | 16:41 |
replaceafill | neither 3.6.2 as the sandboxes use | 16:41 |
replaceafill | we're actually using 4.3, which is the packaged version in trusty | 16:41 |
replaceafill | http://baia.sielibre.com/@@/ckeditor/3.6.1/ckeditor/ckeditor.js | 16:41 |
replaceafill | even though the path says 3.6.1 | 16:41 |
replaceafill | you can see: | 16:41 |
th1a | OK. | 16:41 |
replaceafill | a={timestamp:"DAED",version:"4.3",revision:"d2184ac" | 16:42 |
replaceafill | then i found that the widget works in other places | 16:43 |
replaceafill | like the calendar | 16:43 |
replaceafill | so it's specifically a problem in the gradebook with comments | 16:43 |
th1a | Ah. | 16:43 |
replaceafill | by googling i found that the issue is that we combine jquery ui dialogs with the widget | 16:43 |
replaceafill | the widget acts weird when the DOM of the page changes | 16:44 |
replaceafill | and the DOM changes when the dialog is displayed (inserted) | 16:44 |
replaceafill | so, the "optimal" solution involves recreating the widget AFTER the dialog has been displayed | 16:45 |
replaceafill | unfortunately i didn't get that far | 16:45 |
replaceafill | i thought of a not-optimal solution just for baia | 16:45 |
replaceafill | not sandboxes | 16:46 |
replaceafill | since zope.html is actually using the packaged ckeditor | 16:46 |
replaceafill | that 3.6.1/ckeditor you see in the path above | 16:46 |
replaceafill | is actually a symlink | 16:46 |
replaceafill | to /usr/share/javascript/ckeditor | 16:46 |
replaceafill | (in the packaged version) | 16:46 |
replaceafill | we can "bzr branch ubuntu:precise/ckeditor" | 16:47 |
replaceafill | which would get us 3.6.1 source | 16:47 |
replaceafill | and put it there | 16:47 |
replaceafill | and the widget would work again without changing the gradebook code | 16:48 |
replaceafill | i know it's a hack and not an actual solution | 16:48 |
replaceafill | but we could move on | 16:48 |
replaceafill | and fix it "right" later | 16:48 |
th1a | Go ahead. I'll file a bug. | 16:48 |
replaceafill | kk | 16:48 |
th1a | We can't actually directly test it on their gradebook, right? | 16:49 |
replaceafill | no, we don't have their password | 16:49 |
th1a | OK. Let me know when it is set and I'll have them test it. | 16:50 |
replaceafill | kk, give me a few minutes, i'll do it right now | 16:50 |
replaceafill | ok, changed | 16:55 |
replaceafill | http://baia.sielibre.com/@@/ckeditor/3.6.1/ckeditor/ckeditor.js | 16:55 |
replaceafill | var a={timestamp:'B5GJ5GG',version:'3.6.1',revision:'7072' | 16:55 |
th1a | ok. | 16:57 |
replaceafill | this is the bug btw: http://bugs.jqueryui.com/ticket/4727 | 16:58 |
replaceafill | and a few solutions http://bugs.jqueryui.com/ticket/9087 | 16:59 |
replaceafill | i tried those but didn't work | 16:59 |
th1a | Hm... can we deal with this in the release by essentially doing what you did for BAIA? | 17:02 |
replaceafill | yeah, hold on | 17:03 |
replaceafill | if i understand the package correctly: http://bazaar.launchpad.net/~menesis/ubuntu/trusty/zope.html/trusty/view/head:/debian/rules | 17:04 |
th1a | It doesn't sound fun to deal with "correctly." | 17:04 |
replaceafill | line 20 | 17:04 |
replaceafill | is what we need to remove in the package | 17:04 |
replaceafill | well | 17:05 |
replaceafill | it's nice to have a recent version imho | 17:05 |
replaceafill | 4.3 vs 3.6.1 | 17:05 |
replaceafill | let's wait to hear for baia | 17:06 |
th1a | OK. | 17:06 |
replaceafill | and see if it works | 17:06 |
th1a | And let's get ARK set now. | 17:06 |
replaceafill | kk | 17:06 |
replaceafill | i'll switch back :) | 17:06 |
replaceafill | that's it from me | 17:07 |
th1a | OK, I'm glad that wasn't a complete time suck. | 17:07 |
replaceafill | fixing it right will need more time, but at least i know the reason now | 17:07 |
replaceafill | the 3.6.1 path with 4.3 version was really confusing :D | 17:08 |
th1a | Yeah. | 17:08 |
th1a | Thanks replaceafill. | 17:10 |
replaceafill | ok, thanks th1a | 17:10 |
th1a | Final edits on the paper today. :-) | 17:10 |
replaceafill | ah | 17:10 |
replaceafill | when it's the "release"? | 17:10 |
replaceafill | lol, nice work on the bug comment th1a | 17:12 |
th1a | Goes to the printer tomorrow. | 17:13 |
replaceafill | good luck | 17:14 |
* replaceafill goes to get breakfast, bb in ~30 | 17:14 | |
*** khildin has quit IRC | 17:27 | |
*** yvl has quit IRC | 17:34 | |
*** khildin has joined #schooltool | 17:40 | |
*** khildin has quit IRC | 18:46 | |
th1a | replaceafill: ayt? | 19:16 |
replaceafill | th1a, yeah | 19:17 |
replaceafill | will leave in ~10 mins though | 19:17 |
th1a | frded email | 19:17 |
th1a | on phone | 19:18 |
replaceafill | th1a, sent a confusing reply | 19:40 |
replaceafill | hope he's able to do it | 19:40 |
replaceafill | according to apache logs it seems like he's still getting the 4.3 version of the file | 19:40 |
th1a | cache? | 19:41 |
replaceafill | yeah | 19:41 |
replaceafill | i didn't suggest fully reloading the page because i'd like to know if the teachers will get the same problem | 19:42 |
replaceafill | ok, i have to run | 19:43 |
replaceafill | bb in ~45 | 19:43 |
*** menesis has quit IRC | 21:51 | |
*** menesis has joined #schooltool | 21:54 | |
*** th1a_ has joined #schooltool | 22:41 | |
*** th1a has quit IRC | 22:42 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!