*** replaceafill has quit IRC | 00:32 | |
*** th1a has joined #schooltool | 02:18 | |
*** th1a has quit IRC | 02:31 | |
*** th1a has joined #schooltool | 02:51 | |
*** th1a has quit IRC | 03:30 | |
*** th1a has joined #schooltool | 04:53 | |
*** th1a has quit IRC | 05:03 | |
*** th1a has joined #schooltool | 05:11 | |
*** th1a has quit IRC | 05:31 | |
*** th1a has joined #schooltool | 06:00 | |
*** th1a has quit IRC | 06:26 | |
*** th1a has joined #schooltool | 07:02 | |
*** th1a has quit IRC | 07:44 | |
*** yvl has joined #schooltool | 08:50 | |
*** yvl has quit IRC | 10:37 | |
*** yvl has joined #schooltool | 10:41 | |
*** duende has quit IRC | 14:33 | |
*** th1a has joined #schooltool | 16:00 | |
*** replaceafill has joined #schooltool | 16:07 | |
replaceafill | hey th1a | 16:07 |
---|---|---|
th1a | Hi replaceafill. | 16:08 |
th1a | Good morning... | 16:08 |
* th1a is a bit sleepy. | 16:08 | |
replaceafill | morning :) | 16:08 |
* replaceafill too ;) | 16:08 | |
th1a | Remind me if we know what this is and if it is fixed: https://answers.launchpad.net/schooltool/+question/250444 | 16:09 |
replaceafill | maybe it's taking a while to evolve the database | 16:10 |
th1a | Oh! | 16:10 |
replaceafill | ACC db takes around 1 h 10 minutes to evolve | 16:11 |
replaceafill | if you ask the service, everything is listed as RUNNING | 16:11 |
th1a | Yeah. | 16:11 |
th1a | OK, so for that, the reply is "It seems like everything is working... perhaps it was taking a long time to evolve?" | 16:12 |
replaceafill | i think so | 16:13 |
th1a | OK. | 16:13 |
th1a | OK, so where are you in general at this point? | 16:13 |
replaceafill | ok, i checked the ARK fixes/features, as single commits | 16:14 |
replaceafill | and these are the ones i plan to merge today | 16:14 |
replaceafill | - Added leave school view and stest for students | 16:14 |
replaceafill | - Added relationship states to jstree for groups accordion in person view | 16:14 |
replaceafill | - Fixed row indexing in group importer after relationship change in sample data | 16:14 |
replaceafill | - Used student-enrollment states in remove temporal relationship table and state dialog | 16:15 |
replaceafill | - Set None as default for integer columns in importer | 16:15 |
replaceafill | - student/teacher adapter | 16:15 |
replaceafill | and my question here | 16:15 |
replaceafill | you wanted to move the custom.css change into core, right? | 16:15 |
replaceafill | that's in schooltool.peas now | 16:15 |
replaceafill | are we going to do it in this release? | 16:16 |
th1a | Yes. | 16:16 |
replaceafill | ah ok | 16:16 |
replaceafill | and these are the changes i don't plan to merge, unless you want me to: | 16:16 |
th1a | Sure | 16:16 |
replaceafill | - Substitute teachers | 16:16 |
replaceafill | - Teacher attendance states | 16:16 |
replaceafill | - Set log in/out messages in access log (requires change in debian folder?) | 16:17 |
replaceafill | - Student level changes | 16:17 |
replaceafill | - Set active accordion on person view | 16:17 |
replaceafill | - Made gender required | 16:17 |
replaceafill | - zrs configuration template | 16:17 |
replaceafill | - Added viewlet extra parameter to reports links manager | 16:17 |
replaceafill | done | 16:17 |
replaceafill | i think the student level changes could land | 16:17 |
replaceafill | i have a sublist: | 16:18 |
replaceafill | + Added view for editing student level | 16:18 |
replaceafill | + Added accordion to list student level | 16:18 |
replaceafill | + Showed level subtitle only for students | 16:18 |
replaceafill | + Removed parentheses around grade level subtitle in person view | 16:18 |
th1a | Yes... those would be good. | 16:18 |
replaceafill | cool, i'll include those | 16:18 |
th1a | What about the active accordion? | 16:18 |
replaceafill | nothing uses it and i'd like to improve it by using the viewlet id | 16:19 |
replaceafill | instead of a number | 16:19 |
th1a | ok | 16:19 |
replaceafill | correct me if i'm wrong | 16:19 |
replaceafill | but the idea is to move these to core | 16:19 |
replaceafill | and change the ARK branches to use that? | 16:19 |
th1a | Yes. | 16:20 |
th1a | Not immediately. | 16:20 |
replaceafill | ok | 16:20 |
replaceafill | for october, right? | 16:20 |
th1a | I'd say by the end of the year. | 16:20 |
th1a | I mean, at the latest. | 16:20 |
replaceafill | ah ok | 16:20 |
th1a | We just don't want to trip ourselves up either rushing it or taking too long. | 16:21 |
replaceafill | got it | 16:21 |
replaceafill | so, most of the commits are easily "extractable" | 16:21 |
replaceafill | i should be done today | 16:22 |
replaceafill | and will create a ppa under replaceafill to test | 16:22 |
th1a | OK. | 16:22 |
replaceafill | that's it i guess | 16:23 |
replaceafill | oh | 16:23 |
replaceafill | i investigated about sending you the page | 16:23 |
replaceafill | i'll try to send it this afternoon | 16:23 |
replaceafill | it should take 3 days to get there | 16:23 |
th1a | Keep the receipt. | 16:23 |
replaceafill | ah ok | 16:24 |
th1a | If it takes three days you could wait until Wed or Thurs and send it to Providence. | 16:24 |
replaceafill | i was thinking the same | 16:24 |
th1a | Better to get it there on Tuesday than some other out of sync thing. | 16:24 |
replaceafill | cool | 16:24 |
replaceafill | i'll wait then | 16:24 |
th1a | Did you see this: https://bugs.launchpad.net/bugs/1328108 ? | 16:25 |
replaceafill | hhmm font issue? | 16:26 |
th1a | Apparently. | 16:26 |
th1a | Somehow they just don't have the fonts installed? | 16:27 |
replaceafill | and i think report errors do appear in logs... | 16:27 |
replaceafill | i thought that font was a core package | 16:28 |
* replaceafill checks | 16:28 | |
replaceafill | oh | 16:28 |
replaceafill | maybe it's not in the server version? | 16:28 |
th1a | Ah, could be. What is it called? | 16:29 |
replaceafill | ttf-ubuntu-font-family | 16:29 |
th1a | I mean, I would have thought menesis would have kept it in mind. | 16:29 |
th1a | I'll suggest they just try installing that package? | 16:29 |
replaceafill | yeah | 16:30 |
th1a | OK. | 16:31 |
th1a | I just forwarded an email to you. | 16:32 |
replaceafill | i was recently checking schooltool.rest | 16:34 |
replaceafill | by accident i found the lazr packages | 16:34 |
th1a | Oh yeah... | 16:34 |
replaceafill | and somehow i remembered you discussing it at some point | 16:35 |
replaceafill | thanks for the logs ;) | 16:35 |
th1a | Yes. | 16:35 |
replaceafill | i didn't try it though | 16:35 |
replaceafill | maybe that's the way to go | 16:35 |
th1a | Sure... if things are quiet we should have a run at a basic API. | 16:36 |
replaceafill | adding activities to the gradebook is not difficult | 16:36 |
replaceafill | that's what we did with pyquiz | 16:36 |
replaceafill | but using xmlrpc | 16:36 |
th1a | Right. | 16:36 |
th1a | But getting to the specific question. | 16:36 |
th1a | Adding an average row to the gradebook. | 16:37 |
th1a | I guess it is straightforward. | 16:37 |
replaceafill | yeah | 16:37 |
replaceafill | i didnt remember that bug :) | 16:38 |
th1a | I tried to look at it last night while exhausted and it made it confusing... | 16:38 |
replaceafill | well, "extra column" should be "extra row" i think | 16:38 |
replaceafill | in the bug description | 16:38 |
th1a | Yes. | 16:38 |
replaceafill | should this include the average of the average column? | 16:39 |
th1a | I guess? Why not? | 16:39 |
replaceafill | is that the "class average"? | 16:39 |
th1a | It is all class average for the activity. | 16:39 |
replaceafill | ah | 16:39 |
replaceafill | got it | 16:39 |
replaceafill | it would be a nice feature | 16:40 |
th1a | Yeah... I'm just trying to think of if we could do it next week and push it to them. | 16:41 |
replaceafill | yeah probably | 16:41 |
replaceafill | if we're not doing ark | 16:41 |
replaceafill | and we release cando tomorrow | 16:41 |
th1a | We haven't gotten their reports yet. | 16:41 |
th1a | OK, so I'll tell them this month. | 16:42 |
replaceafill | for the average row, right? | 16:42 |
replaceafill | not the API | 16:42 |
replaceafill | or both? | 16:42 |
th1a | Yes, just the row! | 16:42 |
replaceafill | ok | 16:42 |
replaceafill | phew | 16:42 |
replaceafill | :P | 16:42 |
th1a | ;-) | 16:42 |
th1a | OK. Cool. | 16:44 |
th1a | Keep me posted. | 16:44 |
th1a | Anything else? | 16:44 |
replaceafill | no, that's it | 16:44 |
th1a | We can meet an hour later tomorrow. | 16:44 |
replaceafill | sure | 16:45 |
th1a | OK, I'll reply to these things. | 16:46 |
th1a | Thanks replaceafill . | 16:46 |
replaceafill | thanks th1a | 16:46 |
th1a | Oh, I didn't see that Gediminas replied to Patrick Dela Cruz already. | 16:50 |
replaceafill | yeah | 16:52 |
*** th1a has quit IRC | 17:05 | |
*** th1a has joined #schooltool | 17:07 | |
*** th1a has quit IRC | 17:30 | |
*** th1a has joined #schooltool | 18:27 | |
*** nedosa has joined #schooltool | 18:42 | |
*** th1a has quit IRC | 18:42 | |
nedosa | @replaceafill would it be hard to make a schoolyear report accessible by users in another group ? | 18:46 |
*** hotwebmatter_ has joined #schooltool | 18:48 | |
replaceafill | nedosa, you'd need to add some python code and zcml | 18:48 |
nedosa | sure, can you point me to a sample if it exists already ? | 18:50 |
*** hotwebmatter__ has quit IRC | 18:51 | |
nedosa | it's the request_absences_by_day report that i'm trying to make available to a group | 18:52 |
replaceafill | http://bazaar.launchpad.net/~schooltool-owners/schooltool/trunk/view/head:/src/schooltool/securitypolicy/crowds.py#L285 | 18:52 |
replaceafill | that's how group crowds are defined | 18:52 |
replaceafill | then you give it a name: | 18:53 |
replaceafill | http://bazaar.launchpad.net/~schooltool-owners/schooltool/trunk/view/head:/src/schooltool/securitypolicy/configure.zcml#L20 | 18:53 |
replaceafill | and finally, you set the permission on something for the crowd: | 18:53 |
replaceafill | http://bazaar.launchpad.net/~schooltool-owners/schooltool.gradebook/trunk/view/head:/src/schooltool/gradebook/browser/flourish.zcml#L956 | 18:54 |
replaceafill | nedosa, i hope i'm not forgetting something :) | 18:54 |
replaceafill | use carefully ;) | 18:54 |
nedosa | awesome :) thanks a mil | 18:54 |
replaceafill | np | 18:54 |
nedosa | I might have a couple of follow-up questions :) | 18:55 |
replaceafill | :) | 18:56 |
replaceafill | hope i can answer them :P | 18:56 |
nedosa | so, if I wanted to enable the request_absences_by_day.html link to administrators | 19:12 |
nedosa | would it suffice to add a security:allow directive | 19:13 |
nedosa | short answer is it doesn't :) but there are probably things that I'm missing | 19:13 |
replaceafill | imho what you describe is a bug | 19:15 |
replaceafill | we do allow access to the failing report | 19:15 |
nedosa | failing report == absences by day ? | 19:18 |
replaceafill | no | 19:18 |
replaceafill | nedosa, did you register the new crowd? | 19:20 |
nedosa | ah sorry, i see what you mean, you allow access to the failing reports, therefore you should have allowed access to the absences by day | 19:20 |
nedosa | do I really need to register a new crowd ? I would like to give adminstrators access to the report | 19:21 |
replaceafill | but they have access, don't they? | 19:21 |
replaceafill | what version are you using? | 19:21 |
nedosa | only managers have access afaics | 19:21 |
nedosa | 2.8.1 | 19:22 |
replaceafill | brb | 19:36 |
*** replaceafill has quit IRC | 19:36 | |
*** th1a has joined #schooltool | 19:52 | |
nedosa | @replaceafill bbl | 19:57 |
*** nedosa has left #schooltool | 19:57 | |
*** replaceafill has joined #schooltool | 19:59 | |
replaceafill | th1a, we need to review our report accesses | 20:05 |
th1a | ok | 20:05 |
replaceafill | what nedosa just reported is a bug | 20:05 |
replaceafill | clerks have access to the "link" | 20:05 |
replaceafill | but not the viewlet manager | 20:06 |
replaceafill | and they even can get to the school year view | 20:06 |
replaceafill | can't* | 20:06 |
th1a | OK, those are bugs. | 20:07 |
th1a | Do you want me to try to find more? | 20:07 |
replaceafill | please | 20:08 |
th1a | Is there some particular reason for these? | 20:08 |
replaceafill | yeah, we used to protect everything with schooltool.edit | 20:08 |
replaceafill | i mean, before roles have any functionality | 20:09 |
replaceafill | clerks, etc | 20:09 |
replaceafill | had* | 20:09 |
replaceafill | now, we need security:allow directives for specific thing | 20:09 |
replaceafill | s | 20:09 |
th1a | And the default manager just powers through? | 20:09 |
replaceafill | yeah | 20:09 |
replaceafill | but clerks can't | 20:10 |
replaceafill | and sometimes administrators | 20:10 |
th1a | reports specifically? | 20:10 |
replaceafill | yeah | 20:10 |
replaceafill | i also just tested the one Rena reported | 20:10 |
replaceafill | and even the teacher can't get the printable worksheet | 20:10 |
replaceafill | didn't go deeper though | 20:10 |
replaceafill | it's just a permission problem with the task __name__ | 20:11 |
replaceafill | which i don't understand yet because the interface subclasses IContained | 20:11 |
replaceafill | an idea | 20:12 |
replaceafill | nah, it's not that :( | 20:13 |
replaceafill | i'll need to pdb through it | 20:13 |
*** nedosa has joined #schooltool | 20:15 | |
replaceafill | nedosa, http://pastebin.com/fMQjHrF5 | 20:25 |
replaceafill | that should give admins access to the report | 20:25 |
replaceafill | first part is for schooltool and the second for schooltool.gradebook | 20:26 |
replaceafill | (this is from a dev sandbox btw) | 20:26 |
replaceafill | but i hope it gives you an idea :) | 20:26 |
nedosa | awesome, will try it out | 20:27 |
*** th1a_ has joined #schooltool | 20:35 | |
th1a_ | replaceafill: Do I need to actually generate the reports or just get to the dialog? | 20:38 |
replaceafill | for the printable worksheet issue, yes you need to generate it | 20:39 |
replaceafill | it's at the task level | 20:39 |
replaceafill | for issues like the one nedosa reported, you just don't see the options enabled | 20:39 |
replaceafill | i mean, visible links | 20:39 |
replaceafill | clerks can't access the school year view for example | 20:40 |
replaceafill | because the link above People in /manage | 20:40 |
replaceafill | is protected | 20:40 |
th1a_ | OK. | 20:42 |
*** th1a has quit IRC | 20:44 | |
* replaceafill goes to get lunch | 20:47 | |
*** th1a has joined #schooltool | 20:59 | |
nedosa | that's really cool, it worked | 21:09 |
nedosa | will you put it on the next release or you want me to send a patch/issue pull request/whatever lp uses :) | 21:10 |
th1a | We'll put it in the bug fix release we're making this week. | 21:10 |
th1a | Thanks for the report nedosa. | 21:11 |
nedosa | np, thanks for the pointers and the patch actually | 21:12 |
*** th1a has quit IRC | 21:37 | |
*** th1a has joined #schooltool | 21:53 | |
th1a | hi replaceafill | 21:53 |
replaceafill | hey th1a | 21:53 |
th1a | I found one thing. | 21:53 |
replaceafill | noticed you began finding issues | 21:53 |
replaceafill | yeah | 21:53 |
th1a | As usual it is kind of tricky because you don't know of the lack of data is influencing things. | 21:54 |
replaceafill | true | 21:54 |
th1a | But aside from the things you mentioned (no years for clerks and admins), and the bug I reported, I didn't see any other issues. | 21:55 |
th1a | I don't think there are a LOT of these. | 21:55 |
replaceafill | i remember filing a similar bug some time ago | 21:55 |
replaceafill | let me check | 21:55 |
replaceafill | https://bugs.launchpad.net/schooltool.gradebook/+bug/1108283 | 21:56 |
replaceafill | not sure if it's still an issue | 21:56 |
th1a | Ah. | 21:57 |
replaceafill | https://bugs.launchpad.net/schooltool.virginia/+bug/1243783 kind of similar | 21:57 |
*** nedosa has quit IRC | 22:04 | |
*** nedosa has joined #schooltool | 22:17 | |
*** th1a has quit IRC | 22:35 | |
*** th1a has joined #schooltool | 22:38 | |
*** nedosa has quit IRC | 22:53 | |
*** th1a has quit IRC | 23:18 | |
*** th1a has joined #schooltool | 23:23 | |
*** th1a_ has quit IRC | 23:27 | |
*** th1a has quit IRC | 23:38 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!