| *** replaceafill has quit IRC | 01:17 | |
| *** menesis has quit IRC | 01:30 | |
| *** khildin has joined #schooltool | 09:22 | |
| *** ignas has joined #schooltool | 11:55 | |
| *** menesis has joined #schooltool | 11:58 | |
| *** ignas has quit IRC | 12:24 | |
| *** replaceafill has joined #schooltool | 15:02 | |
| th1a | hi replaceafill, yvl, menesis. | 15:31 |
|---|---|---|
| yvl | good morning | 15:31 |
| replaceafill | good morning/afternoon | 15:31 |
| menesis | hi | 15:31 |
| th1a | First off, was the last email I sent to Thailand accurate? | 15:32 |
| *** ignas has joined #schooltool | 15:32 | |
| menesis | th1a: yes | 15:33 |
| th1a | OK, I'll fix the book. | 15:33 |
| th1a | yvl: Go ahead. | 15:34 |
| yvl | I'll make it short | 15:34 |
| yvl | fixed journal, menesis merged it | 15:34 |
| yvl | it includes evolution | 15:34 |
| yvl | now got back on reports | 15:34 |
| yvl | that is all | 15:35 |
| th1a | replaceafill: Can we test the journal fix with jelkner's data? | 15:35 |
| replaceafill | ah sure | 15:36 |
| replaceafill | i'll update his "unstable" instance | 15:36 |
| replaceafill | (we have two types of instances running for them now) :) | 15:36 |
| replaceafill | unstable is the one running the sprint code | 15:37 |
| th1a | Also... jelkner also had the duplicate periods issue, correct? | 15:37 |
| th1a | Is that another manifestation of the same bug? | 15:37 |
| replaceafill | yes, i think he did | 15:38 |
| replaceafill | but i don't remember seeing it in his journal views | 15:38 |
| replaceafill | i'll look | 15:38 |
| th1a | yvl: Do you know what I'm talking about? | 15:39 |
| yvl | no | 15:39 |
| menesis | duplicate periods bug: https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/1131793 | 15:39 |
| replaceafill | he either fixed the timetable/schedules or it was a different instance, i don't see it in the HILT instance | 15:40 |
| th1a | They had it in Thailand too. | 15:41 |
| th1a | Could the journal sometimes have been taking the periods from the overlapping terms? | 15:41 |
| yvl | it's probably adjacent sections | 15:42 |
| yvl | but I can't tell from the bug description | 15:42 |
| th1a | OK, well, regardless we should see if it goes away now. | 15:42 |
| replaceafill | i tried to reproduce it but i wasn't able to | 15:42 |
| menesis | I think that's similar issue that yvl has fixed | 15:43 |
| th1a | yvl: You'll have to show me the report system at some point. | 15:43 |
| yvl | sure | 15:43 |
| menesis | periods from somewhere else visible in the journal | 15:44 |
| yvl | as for adjacent section | 15:44 |
| yvl | journals used to mash up sections with same instructors and courses for any of the students of the section you're looking at | 15:45 |
| yvl | and I mean any | 15:45 |
| yvl | schoolyears don't matter | 15:45 |
| th1a | Ah. | 15:46 |
| replaceafill | oh | 15:47 |
| yvl | so if there was some test data or something - it could cause that | 15:47 |
| yvl | I think I also saw a bug recently with schedules | 15:47 |
| yvl | when school year is copied | 15:47 |
| yvl | didn't double check | 15:47 |
| yvl | but I think it copies the dates | 15:47 |
| th1a | Oh... | 15:47 |
| yvl | that means - section is scheduled for the *previous* year | 15:47 |
| th1a | Right... it shouldn't try to schedule them at all. | 15:48 |
| yvl | right | 15:48 |
| th1a | Shouldn't try to move them, that is. | 15:48 |
| yvl | just a place we need to check at some point | 15:48 |
| yvl | copying the timetables | 15:48 |
| th1a | OK. | 15:48 |
| yvl | just saying - you might have witnessed an undocumented behaviour exposed by a bug :) | 15:49 |
| yvl | behaviour now fixed. | 15:49 |
| th1a | OK. | 15:50 |
| th1a | Thanks yvl. | 15:50 |
| th1a | replaceafill? | 15:51 |
| replaceafill | ok, small comment on the thailand journal issue | 15:51 |
| replaceafill | after i tried to reproduce | 15:51 |
| replaceafill | pujendra sent me his admin login credentials for their instance | 15:52 |
| replaceafill | i just logged in and noticed the "duplicated periods" bug | 15:52 |
| replaceafill | but it's because in his schedule | 15:52 |
| replaceafill | he has two consecutive periods marked for the same day | 15:52 |
| replaceafill | and he hasn't checked the "Treat consecutive periods as one meeting" option | 15:53 |
| replaceafill | so, he gets two "08 08" for march | 15:53 |
| replaceafill | etc | 15:53 |
| replaceafill | not sure what would happen if we tell him "check that option"... | 15:54 |
| th1a | Ah! | 15:54 |
| th1a | Oh, retroactively? | 15:54 |
| replaceafill | yes | 15:54 |
| replaceafill | but the period is clear | 15:54 |
| th1a | We should probably find out. :-S | 15:54 |
| * replaceafill goes to see the bug | 15:54 | |
| th1a | I don't know that I filed a separate one. | 15:55 |
| replaceafill | i remember we had some screenshot... | 15:55 |
| * replaceafill looks for the section in the screenshot | 15:55 | |
| menesis | that's correct behavior, and with the option checked, only one period would be displayed | 15:55 |
| replaceafill | (i can do this after the meeting if you want) :) | 15:55 |
| replaceafill | oh my! lots of math sections :D | 15:56 |
| replaceafill | right | 15:57 |
| replaceafill | i think that's the issue | 15:57 |
| replaceafill | i mean | 15:57 |
| yvl | oh, btw, remembered a small thing about Jeffs data | 15:57 |
| th1a | Yes, that's why the box is there. | 15:57 |
| replaceafill | it's correct behaviour | 15:57 |
| yvl | he teaches some section over 4 quarters | 15:57 |
| yvl | and Q1 is streched over a year | 15:58 |
| yvl | some student dropped out, and he is only in section of Q1, but not in Q2-Q4 | 15:58 |
| yvl | then again, he has attendance marked in dates that should be Q2 :) | 15:58 |
| th1a | Is that because he made Q1 first and changed it? | 15:58 |
| yvl | yes | 15:58 |
| th1a | So ideally... what? If you change a term's range all the sections should update? | 15:59 |
| th1a | That's a little scary in itself. | 15:59 |
| yvl | now that I do not know | 15:59 |
| * yvl is a bit uncomfortable with automation like that | 16:00 | |
| yvl | scary | 16:00 |
| th1a | You could destroy a lot of data that way. | 16:00 |
| yvl | right | 16:00 |
| replaceafill | hhmm looking at pujendra's dates it seems like a bug though, he should have repeated periods just for one day | 16:00 |
| th1a | Well, that gets into year statuses. | 16:00 |
| th1a | Do that during the setup period. | 16:00 |
| th1a | Don't allow it to be changed once active. | 16:00 |
| replaceafill | and he has repeated periods in consecutive days, which don't match the section schedule setup | 16:00 |
| replaceafill | well, i hope yvl's change to adjacent sections fixes pujendras duplication | 16:02 |
| replaceafill | i don't see it in jelkner's hilt anymore | 16:02 |
| th1a | I'll make sure and ask. | 16:03 |
| replaceafill | i'll check his other instances (nvcc, amhs) | 16:03 |
| replaceafill | lots of "acronyms?" :D | 16:03 |
| replaceafill | ok | 16:03 |
| replaceafill | i fixed the current section logic in the gradebook | 16:03 |
| replaceafill | yvl, i have a question here | 16:03 |
| replaceafill | http://bazaar.launchpad.net/~schooltool-owners/schooltool.gradebook/flourish/revision/550/src/schooltool/gradebook/browser/gradebook.py | 16:03 |
| replaceafill | i decided not to touch the actual function | 16:04 |
| replaceafill | and put the check on the views | 16:04 |
| replaceafill | do you think this is ok? | 16:04 |
| replaceafill | ah, and i added a stest for it | 16:04 |
| yvl | why? | 16:04 |
| yvl | (only views, not why stests :) ) | 16:04 |
| replaceafill | :D | 16:05 |
| replaceafill | because views had access to the user sections already | 16:05 |
| replaceafill | i could move that to a function in the gradebook module itself | 16:05 |
| yvl | hmm | 16:06 |
| replaceafill | i also considered it's the only place it's being used right now, and that limiting the actual function was a bad idea | 16:06 |
| yvl | yes, if dependencies are there | 16:06 |
| yvl | well, there is a duplicate of the function in journal | 16:07 |
| replaceafill | :| | 16:07 |
| replaceafill | oops, i thought the journal was using this same one :( | 16:07 |
| replaceafill | ok | 16:07 |
| replaceafill | i need to fix *that* too | 16:08 |
| th1a | CanDo? | 16:08 |
| replaceafill | i checked cando and it uses the same view | 16:08 |
| replaceafill | as the gradebook | 16:08 |
| yvl | there is a duplicate there too though | 16:08 |
| yvl | (rudimentary probably) | 16:08 |
| replaceafill | hhmm maybe me using grep was a mistake | 16:09 |
| replaceafill | ah! | 16:10 |
| replaceafill | got them | 16:10 |
| yvl | oh, and the reason I asked was that | 16:10 |
| yvl | name setCurrentSectionTaught | 16:10 |
| yvl | kind of implies that you have to teach the section to make it current taught | 16:11 |
| yvl | current taught section that you do not teach | 16:11 |
| yvl | is not something that makes sense | 16:11 |
| replaceafill | got it | 16:11 |
| * yvl would vote for limiting the function itself :) | 16:11 | |
| replaceafill | and i considered it to be just a preference | 16:11 |
| replaceafill | something to remember | 16:12 |
| replaceafill | not the "taught" part | 16:12 |
| yvl | (and when you have functions that do not make sense, you have bugs that do not make sense ;) ) | 16:12 |
| yvl | we could always rename it to setCurrentSectionToRemember :) | 16:12 |
| replaceafill | :D | 16:12 |
| replaceafill | ok, i'll move the limiting part to the function itself | 16:13 |
| replaceafill | and will get the IInstructor and ILearner sections there | 16:13 |
| replaceafill | as well | 16:13 |
| yvl | kk | 16:13 |
| replaceafill | thanks yvl | 16:13 |
| * replaceafill done | 16:14 | |
| th1a | OK, so we'll be waiting for that to do a bugfix release. | 16:14 |
| th1a | Thanks replaceafill. | 16:14 |
| menesis | current section only matters for the views... I would say the set/getCurrentSection would better fit in browser | 16:14 |
| th1a | menesis: Remind me of what our release deadline is for universe. | 16:14 |
| menesis | you fixed the places where the set function is used, so I think this change is all ok | 16:15 |
| menesis | only have to fix the equivalent function in journal | 16:15 |
| menesis | th1a: final freeze is April 18 | 16:16 |
| menesis | in three weeks | 16:17 |
| th1a | OK. | 16:17 |
| replaceafill | i wonder, if all of the three packages (gradebook, cando and journal) are using the same annotation key, why don't we move this to core? | 16:18 |
| yvl | because journal works without gradebook? | 16:19 |
| replaceafill | right, but it would work from core, right? | 16:19 |
| yvl | ??? | 16:19 |
| replaceafill | i mean, the journal sets the annotation key as the same of the gradebook | 16:19 |
| replaceafill | (or maybe i'm missing something) | 16:19 |
| yvl | yes | 16:19 |
| replaceafill | so does cando | 16:20 |
| replaceafill | cando depends on the gradebook, but not the journal | 16:20 |
| yvl | yes | 16:20 |
| replaceafill | why don't we move the annotation key (and functions) to core and make the gradebook ,cando and journal to use them from there | 16:20 |
| replaceafill | hhmm i think it's the same story as with the js resources shared by all of them | 16:21 |
| replaceafill | and i probably know how we all think about it :D | 16:21 |
| yvl | ;) | 16:21 |
| replaceafill | it would just be nice to have what causes the bug centralized in a single place | 16:22 |
| replaceafill | but ok, i'll let it go :) | 16:22 |
| * replaceafill goes to update jelkner's instance | 16:23 | |
| yvl | you can move it ;) | 16:23 |
| replaceafill | i know you don't like that idea, right? | 16:23 |
| yvl | well | 16:23 |
| yvl | if we do make journal use requirements | 16:23 |
| yvl | it will become dependent on gradebook anyway | 16:24 |
| th1a | Which we will very soon. | 16:24 |
| menesis | cando has a copy of getCurrentSection functions, but does not use them | 16:24 |
| yvl | unless we split out the requirement from gradebok - which we will not | 16:24 |
| th1a | Requirement should probably be in core. ;-) | 16:24 |
| yvl | :) | 16:24 |
| yvl | in any case | 16:25 |
| yvl | it could reside in gradebook, but it would need to make journal dependent on gradebook | 16:25 |
| yvl | in both eggs and debs | 16:25 |
| replaceafill | i have no problem maintaining the three versions... as long as we have tests for all of them :) | 16:26 |
| yvl | it's the only reason I would postpone this until the next release | 16:26 |
| replaceafill | sure | 16:26 |
| replaceafill | i understand | 16:26 |
| th1a | Yeah... now is not the moment. | 16:26 |
| replaceafill | hhmm th1a i'll better wait to talk to jelkner to update his instance | 16:28 |
| replaceafill | just in case he's giving a quiz or something | 16:28 |
| menesis | currently gradebook depends on journal, but only because there are some reports that mix grades with absences | 16:28 |
| menesis | attendance-only reports can be moved. | 16:29 |
| menesis | journal external source (for report sheets), too | 16:29 |
| menesis | then only journal depends on gradebook, because it uses some of its features | 16:30 |
| menesis | .. | 16:31 |
| th1a | OK. Anything else menesis? | 16:33 |
| menesis | replaceafill: of the three versions, cando does not set current section, and does not use getCurrentSection methods it redefines | 16:34 |
| menesis | me... | 16:34 |
| replaceafill | menesis, right | 16:34 |
| replaceafill | i'll add a stest and try to get rid of them | 16:35 |
| menesis | I have looked at the new issues posted, replied about translations and installation | 16:35 |
| menesis | marked duplicates and where the 2.1 branch ended for another bugfix that would be good to include | 16:36 |
| menesis | wanted to paste a link to install from ppa instructions, but there is no such page in the book? | 16:37 |
| menesis | so I updated the Installation instructions, added install-dev page for installing development version | 16:37 |
| menesis | updated links in the book and PPA descriptions on launchpad | 16:38 |
| th1a | Well there's this: http://book.schooltool.org/dev_sandbox.html | 16:38 |
| menesis | no, this is install from bzr branches | 16:38 |
| menesis | (needs updating, too) | 16:39 |
| menesis | I was talking about dev PPA | 16:39 |
| menesis | http://book.schooltool.org/install-dev.html | 16:39 |
| menesis | more, looked at yvl's journal merge request | 16:40 |
| menesis | was puzzled by test output changes, but after looking closer I undestood what was being done | 16:41 |
| menesis | so merged it | 16:41 |
| menesis | other than that, was writing/refactoring the schooltool.paste and the main script in my celery branch | 16:44 |
| th1a | OK. Sounds good. | 16:44 |
| th1a | replaceafill: I guess still re-doing old reports next. Well, move the graphical reports into main CanDo first. | 16:45 |
| replaceafill | th1a, understood | 16:45 |
| th1a | Also, we need to talk about the autism stuff. I want that in main CanDo too. | 16:45 |
| replaceafill | ah ok | 16:46 |
| replaceafill | i should test that with new code | 16:46 |
| th1a | That may take a score systems update though. | 16:46 |
| replaceafill | or update it | 16:46 |
| th1a | OK. | 16:46 |
| th1a | Keep me in the loop. | 16:46 |
| th1a | Thanks guys. | 16:46 |
| * th1a drops the bag of gravel. | 16:46 | |
| th1a | Have a good week/end. | 16:47 |
| yvl | thanks guys | 16:47 |
| th1a | Happy Easter. | 16:47 |
| yvl | Happy Easter :) | 16:47 |
| th1a | Who's working Monday? | 16:47 |
| replaceafill | thanks everybody | 16:47 |
| replaceafill | i am :) | 16:47 |
| menesis | not me | 16:48 |
| * replaceafill might take a couple of days off at the end of april... i'll let you know :) | 16:48 | |
| th1a | OK replaceafill. | 16:48 |
| yvl | ok :) | 16:49 |
| * yvl not working too it turns out | 16:49 | |
| th1a | OK. So... see you next Wednesday then. | 16:50 |
| th1a | replaceafill: We can just meet whenever on Monday. You don't have to get up. ;-) | 16:51 |
| replaceafill | thanks! :D | 16:51 |
| *** yvl has quit IRC | 16:52 | |
| *** ignas has quit IRC | 19:11 | |
| *** khildin has quit IRC | 22:32 | |
| *** replaceafill has quit IRC | 23:28 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!