| *** menesis has quit IRC | 00:45 | |
| *** veloutin has quit IRC | 02:50 | |
| *** Lumiere has quit IRC | 02:50 | |
| *** th1a has quit IRC | 02:50 | |
| *** paulproteus has quit IRC | 02:50 | |
| *** paulproteus has joined #schooltool | 09:26 | |
| *** th1a has joined #schooltool | 09:26 | |
| *** Lumiere has joined #schooltool | 09:26 | |
| *** veloutin has joined #schooltool | 09:26 | |
| *** yvl has joined #schooltool | 10:29 | |
| *** replaceafill has joined #schooltool | 16:11 | |
| th1a | hi replaceafill, yvl. | 16:30 |
|---|---|---|
| yvl | good morning | 16:31 |
| replaceafill | good morning/afternoon | 16:31 |
| yvl | it's bank holiday here so I guess menesis won't be around | 16:32 |
| th1a | OK. It is the second day of daylight savings time here. | 16:32 |
| th1a | Should we shift an hour earlier next week? | 16:33 |
| yvl | sure | 16:34 |
| replaceafill | fine with me | 16:35 |
| th1a | OK. | 16:35 |
| *** ChanServ sets mode: +o yvl | 16:35 | |
| *** yvl changes topic to "SchoolTool development | IRC logs at http://source.schooltool.org/irclogs/ | SchoolTool Dev meetings Mon, 13:30 UTC (15:30 EET, 9:30 EST) | Use http://pastebin.com/ for pasting." | 16:35 | |
| *** yvl changes topic to "SchoolTool development | IRC logs at http://source.schooltool.org/irclogs/ | SchoolTool Dev meetings Mon, 13:30 UTC (15:30 EET, 9:30 EDT) | Use http://pastebin.com/ for pasting." | 16:35 | |
| th1a | OK, yvl, how are reports coming? | 16:36 |
| yvl | hmm | 16:37 |
| yvl | well :) | 16:37 |
| yvl | umm | 16:37 |
| yvl | I did get few reports to render in celery | 16:38 |
| yvl | without reporting back to ST | 16:38 |
| yvl | and I'm somewhat happy with "message sending" | 16:39 |
| yvl | so on Wed I expect to have at least one report available for demonstration | 16:39 |
| th1a | OK. | 16:40 |
| yvl | writing new reports will be essentially the same as the old ones | 16:40 |
| yvl | just change the report request dialog class name | 16:41 |
| yvl | and specify which request parameters you want to pass on to the report | 16:41 |
| yvl | pictures will be a bit different | 16:42 |
| yvl | (because I'd like to do without traversal if possible) | 16:42 |
| th1a | Pictures? | 16:43 |
| th1a | For ID's? | 16:43 |
| yvl | so, for example, url to a static resource like schooltool logo | 16:43 |
| yvl | is rendered as data: instead of http: | 16:43 |
| yvl | I think we should avoid getting files with urllib where possible in general | 16:44 |
| yvl | (for reports) | 16:44 |
| yvl | well, anyway | 16:45 |
| yvl | that was just FYI | 16:45 |
| th1a | OK. | 16:46 |
| th1a | Well, keep it moving forward. | 16:46 |
| yvl | ok | 16:46 |
| *** ChanServ sets mode: -o yvl | 16:46 | |
| th1a | Thanks yvl. | 16:47 |
| th1a | replaceafill? | 16:47 |
| replaceafill | ok | 16:47 |
| replaceafill | last week i basically gave up on the journal bug | 16:48 |
| replaceafill | sorry about that | 16:48 |
| replaceafill | but i wasn't able to reproduce at all | 16:48 |
| replaceafill | (from scratch) | 16:48 |
| replaceafill | i did identify the problem (i think) | 16:48 |
| replaceafill | the section journal adapter sometimes retrieves the wrong meetings | 16:49 |
| th1a | Well... I don't know that we've given up on it. Set it aside for the moment... | 16:49 |
| replaceafill | sure | 16:49 |
| replaceafill | i just switched ;) | 16:50 |
| replaceafill | so i started on glenda's changes to the VA skills reports | 16:50 |
| replaceafill | i've finished the pdf of the completion one | 16:51 |
| replaceafill | the progress one doesn't need a pdf | 16:51 |
| replaceafill | i added some JS to set the header of the table fixed | 16:51 |
| replaceafill | same way we do it in the book with the navbar | 16:51 |
| replaceafill | and now i need to work on the totals of the columns | 16:52 |
| replaceafill | yvl, do you have a recommendation on how to create a total row for a column in a table formatter? | 16:52 |
| replaceafill | probably at the bottom of the table | 16:53 |
| yvl | add an extra item? | 16:53 |
| replaceafill | i thought of that, but how do we prevent sorting on it | 16:53 |
| th1a | We should probably show Glenda what you have and double check what she means there anyhow. | 16:53 |
| replaceafill | th1a, ah ok | 16:53 |
| replaceafill | sure | 16:53 |
| replaceafill | i think the rest of her requests are easy enough | 16:55 |
| replaceafill | i'll make the report not to render initially | 16:55 |
| replaceafill | th1a, i was thinking we need a submit button after all for that | 16:55 |
| replaceafill | or showing the filters with '-------' values maybe? | 16:55 |
| replaceafill | i like the submit button idea better, you can set several filters and then run once | 16:56 |
| th1a | To keep it from timing out? | 16:56 |
| replaceafill | well, at least the user will get to the report generation page | 16:56 |
| replaceafill | it may timeout with the spinner showing :) | 16:57 |
| th1a | OK. | 16:57 |
| replaceafill | so, i'll work on this and have it ready for showing it to glenda tomorrow | 16:57 |
| replaceafill | ah btw | 16:57 |
| replaceafill | i'm flying on wednesday to santa clara to meet with jelkner | 16:57 |
| replaceafill | and paul and david | 16:57 |
| th1a | Right. | 16:57 |
| replaceafill | and work on quiz | 16:57 |
| th1a | Yes. | 16:57 |
| replaceafill | and attend pycon :) | 16:58 |
| th1a | When will you be back? | 16:58 |
| replaceafill | but i plan to work normally the rest of this week | 16:58 |
| replaceafill | next thursday 21 | 16:58 |
| replaceafill | i also plan to attend the dev meetings next week | 16:58 |
| yvl | btw, replaceafill, a quick hack would be adding an invisible column that has False for all items, True for totals and sort by it | 16:58 |
| replaceafill | yvl, in addition to the current sorting? | 16:59 |
| yvl | yes | 16:59 |
| replaceafill | ah | 16:59 |
| replaceafill | that will work! :D | 16:59 |
| yvl | but that's more of a hack | 16:59 |
| replaceafill | my kind of solution ;) | 17:00 |
| replaceafill | i'll give it a try | 17:00 |
| replaceafill | thanks yvl | 17:00 |
| * replaceafill done | 17:00 | |
| th1a | yvl: Have you worked at all on this area: "section journal adapter sometimes retrieves the wrong meetings" | 17:02 |
| th1a | I think the problematic code my reach back to ignas' days. | 17:02 |
| yvl | not recently | 17:02 |
| th1a | Do you know if you ever touched it at all? | 17:03 |
| yvl | I did | 17:03 |
| yvl | when rewriting timetables | 17:03 |
| yvl | well, after that | 17:03 |
| th1a | Perhaps replaceafill should explain the issue further then. | 17:03 |
| yvl | what are the "wrong meetings"? | 17:04 |
| replaceafill | ok | 17:04 |
| yvl | meetings from another section of same teacher? | 17:04 |
| replaceafill | yes | 17:04 |
| replaceafill | sometimes not even from the teacher | 17:05 |
| replaceafill | i remember i couldn't find a few in any of the teacher's section calendars | 17:05 |
| yvl | well, the place I want to blame is getCurrentSectionTaught | 17:05 |
| yvl | but that's just because I don't like that code ;) | 17:06 |
| replaceafill | but that would send me to the wrong section, right? | 17:06 |
| replaceafill | i mean, url-wise | 17:06 |
| yvl | umm | 17:07 |
| replaceafill | i was blaming more the adjacent_sections logic | 17:07 |
| yvl | aren't parts of journal retrieved with jquery? | 17:07 |
| replaceafill | popups, yes | 17:07 |
| replaceafill | but this happens even if i disable all js in it | 17:07 |
| replaceafill | so no validation, no popup code, etc | 17:08 |
| replaceafill | so, when you load the section journal view | 17:08 |
| replaceafill | columns have ids set to the __name__ of the meeting | 17:09 |
| replaceafill | what i realized is that when the bug happens | 17:09 |
| replaceafill | those __name__s don't belong to the calendar of the current section | 17:09 |
| replaceafill | in jelkner's case, somehow, the first term spans from first day to last day IN THE SCHOOLYEAR | 17:09 |
| replaceafill | sorry | 17:10 |
| yvl | :) | 17:10 |
| replaceafill | i meant the first term schedule | 17:10 |
| yvl | yes, I remember | 17:10 |
| yvl | weird configuration | 17:10 |
| replaceafill | i mean, the schedule of the first term section :) | 17:10 |
| replaceafill | (just to be clear) ;) | 17:10 |
| replaceafill | but to add more weirdness, sometimes the __name__s don't come from that first term schedule anyway :( | 17:11 |
| replaceafill | so, that's why i blame journal.journal.adjacent_sections | 17:11 |
| replaceafill | i think it retrieves other sections (taken from instructors, students) | 17:12 |
| replaceafill | then the journal view just uses dates in order to filter | 17:12 |
| yvl | that is it's purpose | 17:12 |
| yvl | btw, the way it's done is a bit outdated nowadays | 17:13 |
| replaceafill | yvl, that's pre-linked sections, correct? | 17:13 |
| yvl | yes | 17:14 |
| replaceafill | i mean, that's what's trying to do? | 17:14 |
| yvl | almost | 17:14 |
| replaceafill | so, if i understand this correctly, then in browser.journal.allMeetings | 17:15 |
| yvl | it tries to mash up journals of course taught by instructor to any of the students | 17:15 |
| replaceafill | events are filtered by e.dtstart.date() in term | 17:15 |
| replaceafill | and here: | 17:16 |
| replaceafill | meetings = [by_uid[e.unique_id] for e in sorted(insecure_events)] | 17:16 |
| replaceafill | it's when sorting happens | 17:17 |
| replaceafill | but sometimes that list has way more events than what's displayed in the journal view | 17:17 |
| replaceafill | i was getting 185 meetings for one term in jelkner's data | 17:18 |
| replaceafill | (which i don't trust ofc) :D | 17:18 |
| yvl | and there were less meetings in all months of the term? | 17:19 |
| replaceafill | yes | 17:20 |
| yvl | displayed in the journal I mean | 17:20 |
| replaceafill | yes | 17:20 |
| replaceafill | the journal usually displays the scheduled periods right | 17:20 |
| replaceafill | that's why you don't notice the bug easily | 17:20 |
| replaceafill | if you'd get like 80 columns you'd probably say "that's too many periods" | 17:21 |
| yvl | hmm | 17:21 |
| replaceafill | at some point i was tempted to break the subclassing of LyceumSectionJournalView | 17:21 |
| replaceafill | in the flourish view | 17:21 |
| yvl | it displays only the scheduled periods? | 17:21 |
| replaceafill | yvl, apparently | 17:22 |
| replaceafill | same date | 17:22 |
| replaceafill | same period name | 17:22 |
| replaceafill | so you get | 17:22 |
| replaceafill | 03 | 17:22 |
| replaceafill | ---- | 17:22 |
| replaceafill | A | 17:22 |
| replaceafill | but if you inspect the id of the 03 cell, you'll see a different __name__ | 17:22 |
| replaceafill | yvl, question | 17:23 |
| replaceafill | if i do sorted(calendar_events) | 17:24 |
| replaceafill | could you point me to the calendar event methods that handle that? | 17:24 |
| replaceafill | i was looking for some __cmp__ there | 17:24 |
| replaceafill | but couldn't get to it | 17:25 |
| yvl | hmm | 17:26 |
| * yvl can't see that too | 17:26 | |
| replaceafill | that's one of my reasons to not trust the sorting line above | 17:26 |
| replaceafill | it's like we're relying on randomness there | 17:26 |
| replaceafill | yvl, if you have any advice on all of this, i could try anything :( | 17:27 |
| replaceafill | if you want to "see" it, i have jelkner's database | 17:27 |
| replaceafill | which you have to F5 F5 F5 F5 F5... | 17:28 |
| replaceafill | and at some point you'll see it :D | 17:28 |
| yvl | well | 17:28 |
| yvl | there's not much I can advise without looking at it | 17:28 |
| replaceafill | right | 17:28 |
| yvl | if you could pass me a database and instructions where to look and what to do to reproduce :) | 17:29 |
| yvl | and what to look for, ofc. | 17:29 |
| yvl | I could try debugging | 17:29 |
| yvl | it may be something simple | 17:29 |
| replaceafill | the reproduce part is hard | 17:30 |
| replaceafill | ok, i'll send you all of i got | 17:31 |
| yvl | well at least you could tell me exactly what happened where instead of what was expected | 17:31 |
| replaceafill | sure | 17:31 |
| yvl | something sometimes is wrong is not the best bug description ;) | 17:31 |
| th1a | They are also having serious journal issues in Thailand, this exact bug and one where duplicate periods appear in the journal. That's probably related, I'd think. | 17:31 |
| yvl | replaceafill, could you also paste links to those bugs in email too? | 17:32 |
| replaceafill | sure | 17:32 |
| replaceafill | one of my fears is: user recorded grades on wrong meetings | 17:35 |
| replaceafill | now we display the right meetings | 17:35 |
| replaceafill | grades are gone :( | 17:35 |
| yvl | they are not gone | 17:35 |
| replaceafill | right | 17:35 |
| yvl | they may be not visible though :) | 17:35 |
| th1a | If you want to take a look at this yvl, that's fine, but don't put more than, say a day into it without telling me. | 17:35 |
| replaceafill | i mean, visually | 17:35 |
| yvl | ok, th1a | 17:35 |
| th1a | That is, I'm HAPPY for you to take a look at it now, just don't derail the release. | 17:36 |
| th1a | This is a serious bug though. | 17:36 |
| yvl | understood | 17:36 |
| yvl | frankly, I was waiting for a similar bug for a while now | 17:36 |
| yvl | something does not feels right to me with journal's meeting code | 17:37 |
| th1a | Also, I was telling replaceafill, it might be easier in the fix to dump the data into just a simple dictionary and then dump it back into a fixed journal. | 17:37 |
| th1a | Rather than something more magical. | 17:37 |
| yvl | true | 17:37 |
| th1a | Just something to keep in mind. | 17:39 |
| th1a | OK, that should do it gentlemen. Thanks! | 17:39 |
| yvl | thanks guys | 17:40 |
| th1a | See you Wednesday. | 17:40 |
| yvl | see you Wed | 17:40 |
| replaceafill | thanks everybody | 17:40 |
| * th1a drops the bag of gravel. | 17:40 | |
| *** yvl has quit IRC | 17:40 | |
| *** th1a has quit IRC | 19:44 | |
| *** th1a has joined #schooltool | 19:48 | |
| replaceafill | th1a, just sent yvl jelkner's database and how to "reproduce" | 20:46 |
| th1a | I see. | 20:47 |
| replaceafill | reproduce isn't the right word for this case :D | 20:47 |
| *** replaceafill has quit IRC | 21:31 | |
| *** replaceafill has joined #schooltool | 21:58 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!