*** khildin_ has joined #schooltool | 00:14 | |
*** khildin has quit IRC | 00:18 | |
*** replaceafill has joined #schooltool | 00:23 | |
*** menesis has quit IRC | 00:24 | |
*** khildin_ has quit IRC | 00:40 | |
*** replaceafill has quit IRC | 00:53 | |
*** ignas has quit IRC | 06:45 | |
*** menesis has joined #schooltool | 08:08 | |
*** menesis has quit IRC | 12:23 | |
*** khildin has joined #schooltool | 13:22 | |
*** menesis has joined #schooltool | 14:27 | |
*** ignas has joined #schooltool | 14:48 | |
*** replaceafill has joined #schooltool | 16:20 | |
th1a | hi replaceafill, menesis. | 16:31 |
---|---|---|
th1a | How's your internet, replaceafill? | 16:32 |
replaceafill | good morning/afternoon | 16:32 |
replaceafill | th1a, it's back :) | 16:32 |
replaceafill | they said it was a "general" failure in the ISP yesterday | 16:32 |
th1a | Ah, well, that's sort of good. | 16:33 |
replaceafill | their service in the whole country went down :/ | 16:33 |
replaceafill | including USB modems! | 16:33 |
replaceafill | th1a, thanks for contacting jelkner for me | 16:34 |
th1a | Sure. | 16:34 |
th1a | OK, so where are we with Glenda's various issues? | 16:34 |
replaceafill | ok | 16:35 |
replaceafill | i have the tables for the completion/progress reports working | 16:35 |
replaceafill | i have a question for you | 16:35 |
replaceafill | these two reports render the results on load | 16:35 |
replaceafill | i mean | 16:35 |
replaceafill | you click VA Progress Report on the term | 16:36 |
replaceafill | then you're redirected to it showing you the sections, right? | 16:36 |
replaceafill | but that takes a lot of time in big databases | 16:36 |
replaceafill | i mean, it takes a lot of time to get the page back | 16:36 |
replaceafill | i was thinking if we should start those report empty | 16:37 |
replaceafill | reports* | 16:37 |
replaceafill | i mean, with empty tables | 16:37 |
replaceafill | and add a Submit button to get the results ONCE you're in the page | 16:37 |
th1a | Yes, perhaps. | 16:37 |
th1a | Let's not get hung up on that atm though. | 16:37 |
replaceafill | sure | 16:37 |
th1a | Add it to the list. | 16:37 |
replaceafill | ok | 16:37 |
replaceafill | so, now i'm making both reports aware of multiple score systems | 16:38 |
replaceafill | that's kind of expensive | 16:38 |
replaceafill | performance-wise | 16:38 |
replaceafill | since these are by section | 16:38 |
replaceafill | but that's almost done | 16:39 |
replaceafill | and the last issue | 16:39 |
replaceafill | i was able to reproduce the problem with the svg's | 16:39 |
replaceafill | it's a general problem that could also show in the section summary report | 16:40 |
replaceafill | (glenda reported it in the skills completion report) | 16:40 |
th1a | Yes. | 16:40 |
replaceafill | and it's less likely for a username to have parenthesis in it | 16:40 |
replaceafill | but... we need to sanitize the id for the element anyway | 16:41 |
replaceafill | that's what breaks our d3 code | 16:41 |
th1a | Right. | 16:41 |
replaceafill | the report view doesn't break btw | 16:41 |
replaceafill | just doesn't show the charts | 16:41 |
th1a | Is that going to be a problem to fix? | 16:41 |
replaceafill | i *think* yvl already has some sanitizing code in flourish | 16:42 |
replaceafill | for generating html ids | 16:42 |
replaceafill | (for naming viewlets iirc) | 16:42 |
replaceafill | i just have to send the object __name__ through that | 16:43 |
replaceafill | so i don't think it'll be a problem | 16:43 |
replaceafill | that's it | 16:44 |
replaceafill | that's what i'm on it right now | 16:44 |
replaceafill | ah, i also discovered some bad i18n in cando | 16:45 |
replaceafill | where we get DYNAMIC_CONTENT in the .po file | 16:45 |
replaceafill | i'll fix those too | 16:45 |
th1a | Are you able to replicate Glenda's setup? | 16:46 |
th1a | She says she gets the project bug with a clean database. | 16:46 |
replaceafill | hhmm i understood she gets the bug after re-importing *skills* | 16:46 |
replaceafill | let me check her email again | 16:47 |
th1a | Oh, maybe. | 16:47 |
replaceafill | "After re-importing the correct verso_skills" | 16:47 |
replaceafill | i don't think she started fresh | 16:47 |
th1a | OK, which email is that? | 16:47 |
replaceafill | Tuesday, February 19, 2013 1:38 PM | 16:48 |
replaceafill | that's the last i have from her about "Project bug?" | 16:48 |
replaceafill | last one* | 16:48 |
replaceafill | yes, she definitely didn't start from scratch, i just logged in into her instance and she has the same scores, iep, etc | 16:49 |
th1a | Can you replicate it on her instance? | 16:49 |
replaceafill | yes | 16:49 |
replaceafill | but again, her ids are weird | 16:50 |
th1a | Well... | 16:50 |
replaceafill | i could ask her for her database and pdb it | 16:50 |
replaceafill | to know what's going on exactly | 16:50 |
replaceafill | but again, we have stests for that feature | 16:50 |
replaceafill | and starting fresh works | 16:51 |
th1a | OK, nonetheless, this should not happen, so let's think about that. | 16:51 |
th1a | She's got the skills assigned to the section. | 16:52 |
th1a | These are the old skills? | 16:52 |
th1a | Theoretically? | 16:52 |
replaceafill | not sure, probably | 16:52 |
th1a | So one problem really is we have no way of knowing? | 16:52 |
replaceafill | correct | 16:53 |
th1a | And now, you want to create a project, you select skills that appear to be the same ones in the section but you don't really know for sure they are? | 16:54 |
th1a | Perhaps they are different ones with the same title and label? | 16:54 |
replaceafill | that's why i'm stressing the IDs part | 16:54 |
replaceafill | it looks like a left-over from the whole get_verso_skills.py story | 16:55 |
replaceafill | to fix labels, etc | 16:55 |
th1a | It might have changed ID's? | 16:55 |
th1a | I mean, that's the most likely theory at this point. | 16:56 |
replaceafill | my point is, this is test data and we shouldn't trust it | 16:56 |
th1a | What if you just search by skill title? Do you get duplicates? | 16:56 |
replaceafill | i could try with the *current* acc data | 16:56 |
th1a | I think Glenda says someone else reported it. | 16:56 |
replaceafill | hhmm | 16:57 |
replaceafill | "Also evident in my demo,..." | 16:57 |
replaceafill | oh | 16:57 |
replaceafill | "...but have just been notified of another issue" | 16:57 |
th1a | Until this bug was reported by Henrico today, I didn't realize the same issue existed in my own system. | 16:57 |
th1a | Just try searching globally by title for Maintaining Computer Systems skillset and see what you get. | 16:59 |
replaceafill | hhmm i think that's the name of the project | 17:00 |
replaceafill | i think i'll be easier to ask her for her demo database | 17:01 |
replaceafill | i wonder if they were hit by the equivalences bug we had some time ago in the importer | 17:02 |
replaceafill | projects rely on equivalences | 17:02 |
th1a | Can you just humor me and try searching a bit. | 17:02 |
replaceafill | i am! | 17:02 |
replaceafill | that's why i'm saying that's the project title | 17:03 |
replaceafill | not a skillset | 17:03 |
replaceafill | hold on | 17:03 |
replaceafill | Maintaining Computer *System* | 17:03 |
replaceafill | :D | 17:04 |
replaceafill | singular ;) | 17:04 |
th1a | Extra letters don't help. | 17:05 |
replaceafill | ok, i have the skillset | 17:06 |
replaceafill | i should set this up in the testing instance... | 17:06 |
replaceafill | i mean, in the vps | 17:06 |
replaceafill | ok | 17:06 |
replaceafill | in glenda's instance | 17:06 |
replaceafill | 081 maintain printer | 17:07 |
replaceafill | in that skillset | 17:07 |
replaceafill | and it's id being 087 | 17:07 |
replaceafill | same as the last verso skill xls | 17:07 |
th1a | But there is only one. | 17:07 |
replaceafill | only one? | 17:08 |
th1a | There aren't two separate instances of the same skill. | 17:08 |
th1a | That's what I was afraid of. | 17:08 |
th1a | What's the link between the project skill and the section skill based on? | 17:09 |
replaceafill | equivalences | 17:09 |
replaceafill | the project skill lives in the project, right? | 17:09 |
replaceafill | but it considers the one in the skills gradebook equivalent toit | 17:09 |
replaceafill | to it* | 17:09 |
replaceafill | and at some point we detected the skills importer breaking those equivalences | 17:10 |
th1a | I mean, is that a relationship, ID reference, etc? | 17:11 |
replaceafill | yes, relationship | 17:11 |
th1a | OK. I'm afraid that after you fix the parentheses bug you're going to have to try to pdb this or something. | 17:12 |
replaceafill | sure | 17:13 |
replaceafill | skill_copy.equivalent.add(skill['obj']) | 17:14 |
replaceafill | that's what sets up the relationship | 17:14 |
th1a | OK, I'll update glenda. | 17:16 |
replaceafill | kk | 17:17 |
th1a | Do you need her to send her database? | 17:17 |
replaceafill | yes | 17:17 |
th1a | OK, I'll send an email. | 17:18 |
replaceafill | kk | 17:19 |
th1a | Anything else replaceafill? | 17:21 |
replaceafill | no, i'm done | 17:21 |
th1a | OK, thanks replaceafill. | 17:22 |
th1a | menesis? | 17:22 |
menesis | yes | 17:24 |
menesis | I have made releases and packages of everything | 17:24 |
menesis | updated release notes in the book | 17:25 |
menesis | & sent those to Glenda | 17:25 |
menesis | how well does it work for her? | 17:25 |
th1a | Ah, I guess you've been a bit out of the loop on that. | 17:26 |
th1a | As replaceafill and I have been discussing, there are a few bugs. | 17:26 |
th1a | But then again, I don't really think they are NEW bugs. | 17:26 |
menesis | I haven't read everything | 17:26 |
th1a | right replaceafill? | 17:26 |
menesis | (of the irclog) | 17:27 |
th1a | I think they're ones that have been there for a while. | 17:27 |
replaceafill | yes | 17:27 |
menesis | basically: did she test, did it work? | 17:27 |
menesis | some things were done late at night... 8-) | 17:28 |
menesis | :D | 17:28 |
th1a | There don't appear to be any new bugs. | 17:28 |
th1a | We do need to do a little better job of documenting how to actually use the new features listed in the release notes. That's really my job but we need a clear workflow. | 17:29 |
menesis | there's a place for that at the top of '2.4 release notes' book page | 17:30 |
menesis | What's new in this release with screenshots | 17:30 |
menesis | would be nice ;) | 17:30 |
menesis | then also since yesterday I was refactoring schooltool and merging branches together | 17:32 |
menesis | working on the manage script | 17:33 |
menesis | also upgraded and tested with package versions in ubuntu raring | 17:34 |
th1a | We'll probably need another quick bugfix release this week, if replaceafill makes progress. | 17:36 |
menesis | everything excluding reportlab upgrade works | 17:36 |
menesis | reportlab was upgraded to 2.6, and z3c.rml to 2.0.0 in raring | 17:36 |
replaceafill | i'm shooting friday, just like last week :) | 17:37 |
menesis | it was required | 17:37 |
menesis | by the newer z3c.rml | 17:37 |
th1a | Good news menesis. | 17:37 |
menesis | but that broke something in schooltool, last I checked | 17:38 |
menesis | I'll have to come back to that soon | 17:39 |
th1a | OK. | 17:39 |
menesis | after I'm done with the new scripts for celery | 17:40 |
menesis | oh | 17:40 |
menesis | when people report bugs through https://bugs.launchpad.net/schooltool-project | 17:41 |
menesis | have to choose a project | 17:41 |
menesis | the default was CanDo (first by alphabet) | 17:41 |
th1a | Yes. | 17:42 |
menesis | but since that project (https://launchpad.net/cando) is dead | 17:42 |
menesis | I have removed it from the Project | 17:42 |
menesis | so now the default is SchoolTool | 17:42 |
menesis | and there's only one cando | 17:43 |
menesis | quiz, too | 17:43 |
menesis | they are owned by CanDo developers anyway | 17:43 |
menesis | reviewed bugs clearly not belonging there | 17:44 |
th1a | Thanks, good thinking. | 17:44 |
menesis | and that's all what's finished | 17:44 |
th1a | OK, thanks menesis. | 17:46 |
th1a | I'm going to send in invoices today and revise the cando docs. I almost got through the whole skills setup process -- which is the most painful part -- until I discovered a bug in the end that I'll have to work around and re-do all the screenshots, etc. | 17:47 |
th1a | OK, thanks guys. | 17:48 |
th1a | Keep me posted replaceafill. | 17:48 |
th1a | Have a good week/end. | 17:48 |
* th1a drops the bag of gravel. | 17:48 | |
replaceafill | th1a, will do | 17:48 |
*** menesis has quit IRC | 18:41 | |
*** menesis has joined #schooltool | 18:48 | |
*** menesis has quit IRC | 19:34 | |
*** replaceafill has quit IRC | 20:15 | |
*** replaceafill has joined #schooltool | 20:27 | |
*** ignas has quit IRC | 20:58 | |
*** menesis has joined #schooltool | 21:45 | |
*** pgulley has joined #schooltool | 22:12 | |
pgulley | replaceafill, hey! | 22:13 |
replaceafill | hi pgulley | 22:13 |
pgulley | I'm here a little early, but won't be able to stick around until the normal time | 22:14 |
replaceafill | hhmm, isn't the normal time 3:00 pm? | 22:14 |
pgulley | I recall 3:30, but I may be wrong. | 22:15 |
replaceafill | anyway | 22:15 |
pgulley | either way | 22:15 |
replaceafill | how are you doing? | 22:15 |
replaceafill | have you been working with dreich? | 22:15 |
pgulley | Good- dreich sent me your list of fixes, and we've been working on them, yeah | 22:15 |
replaceafill | ah ok | 22:15 |
replaceafill | do you know what's next? | 22:16 |
pgulley | tests, I presume. | 22:16 |
replaceafill | ok | 22:16 |
replaceafill | do you have everything you need to do that? | 22:16 |
replaceafill | i mean, there's a lot of examples | 22:17 |
replaceafill | i hope it won't be an issue | 22:17 |
pgulley | I'm sure, yeah. We haven't looked at it yet, but I don't see it being an inssue. | 22:17 |
replaceafill | great | 22:18 |
replaceafill | any other question? | 22:18 |
pgulley | dreich may have talked to you about this, but we weren't totally sure how you wanted to handle the code for the validator function, just as far as placing it in the code | 22:18 |
pgulley | since putting it in a package with utils was a little unnecessary- should it just be src/RationalValidator ? | 22:20 |
replaceafill | hhmm | 22:20 |
replaceafill | let me check one thing | 22:20 |
replaceafill | you already have such a function, right? | 22:21 |
replaceafill | i mean | 22:21 |
replaceafill | it's here: | 22:21 |
replaceafill | https://code.launchpad.net/~ellimistd/schooltool.quiz/SchoolToolQuizDev/+merge/149160 | 22:21 |
replaceafill | in the utils.py module | 22:21 |
pgulley | yes, exactly- and it works and everything. We just weren't sure where the code for it should live | 22:22 |
replaceafill | ah ok | 22:23 |
replaceafill | utils is fine | 22:23 |
pgulley | okay, cool. | 22:23 |
replaceafill | also, you can move stuff around after you have good tests | 22:23 |
pgulley | right. | 22:23 |
replaceafill | the only thing i dont understand in that diff: | 22:23 |
replaceafill | why was the utils module removed and then added back? | 22:23 |
pgulley | I can't honestly say I know. | 22:26 |
replaceafill | ok | 22:26 |
replaceafill | the rest is fine | 22:26 |
replaceafill | and i manually tested the code and everything seems to work | 22:27 |
pgulley | *phew* | 22:28 |
pgulley | Is there anything else we may want to look at before tests, or are we safe to move on? | 22:29 |
replaceafill | sure | 22:29 |
replaceafill | go ahead and start adding tests | 22:29 |
pgulley | perfect, we'll get on that this weekend | 22:30 |
replaceafill | cool, let me know if you need any help | 22:31 |
pgulley | alright, will do. And this is good timing, I need to get going. | 22:35 |
replaceafill | see you pgulley | 22:36 |
pgulley | thanks! We'll push to our branch when we have tests running | 22:36 |
*** pgulley has quit IRC | 22:36 | |
th1a | Any progress on the project bug, replaceafill? | 22:36 |
replaceafill | th1a, haven't checked glenda's db yet | 22:36 |
replaceafill | i did download it | 22:37 |
th1a | OK. | 22:37 |
*** ignas has joined #schooltool | 23:07 | |
*** menesis has quit IRC | 23:12 | |
*** replaceafill_ has joined #schooltool | 23:23 | |
*** replaceafill_ has joined #schooltool | 23:23 | |
*** replaceafill has quit IRC | 23:23 | |
*** replaceafill_ is now known as replaceafill | 23:25 | |
*** replaceafill has quit IRC | 23:41 | |
*** ignas has quit IRC | 23:45 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!