| *** khildin has joined #schooltool | 00:08 | |
| *** replaceafill has quit IRC | 00:27 | |
| *** menesis has quit IRC | 00:48 | |
| *** khildin has quit IRC | 01:47 | |
| *** ignas has quit IRC | 03:22 | |
| *** vialde has quit IRC | 03:43 | |
| *** ignas has joined #schooltool | 04:53 | |
| *** ignas has quit IRC | 07:10 | |
| *** khildin has joined #schooltool | 08:47 | |
| *** yvl has joined #schooltool | 10:22 | |
| *** paulproteus has quit IRC | 10:32 | |
| *** paulproteus has joined #schooltool | 10:42 | |
| *** vialde has joined #schooltool | 11:10 | |
| *** menesis has joined #schooltool | 11:40 | |
| *** vialde has quit IRC | 12:25 | |
| *** vialde has joined #schooltool | 12:26 | |
| *** ignas has joined #schooltool | 13:05 | |
| *** menesis has quit IRC | 14:54 | |
| *** menesis has joined #schooltool | 16:23 | |
| th1a | hi yvl, menesis, aelkner. | 16:30 |
|---|---|---|
| menesis | hi | 16:30 |
| aelkner | morning | 16:31 |
| veloutin | good morning | 16:31 |
| yvl | hi guys | 16:31 |
| th1a | Glad to be out from under that election. | 16:32 |
| th1a | With the right result. ;-) | 16:32 |
| yvl | congratulations with a new president :) | 16:32 |
| th1a | Same as the old one. | 16:32 |
| aelkner | yay! | 16:32 |
| yvl | +1 :) | 16:32 |
| th1a | How's our fix looking yvl? | 16:33 |
| yvl | about to be done | 16:33 |
| yvl | it was quite fun actually | 16:34 |
| yvl | what's done if they apply the new code to an older database, scores will not be broken | 16:34 |
| yvl | what's about to be done - when they apply new code to new database + modified scores in some sections, old scores will reappear and not kill the fresh ones | 16:35 |
| th1a | Right. Good. | 16:35 |
| th1a | History! | 16:36 |
| yvl | yes | 16:36 |
| yvl | and I actually found one more bug while checking today | 16:36 |
| yvl | thank goodness I had the Data.fs | 16:36 |
| yvl | because when you're reading the code, it's almost impossible to spot variables that are named very similarly but wrong | 16:37 |
| yvl | even with Data.fs I spent some half our looking and thinking what the? | 16:37 |
| yvl | anyway | 16:37 |
| yvl | looking good | 16:37 |
| yvl | will finish today I think | 16:38 |
| yvl | (during the meeting) | 16:38 |
| th1a | I think replaceafill can test against dwelsh's instances. | 16:40 |
| th1a | Should we plan on pushing a .deb fix tomorrow? | 16:40 |
| yvl | sounds good to me | 16:41 |
| yvl | menesis? | 16:41 |
| menesis | yes | 16:41 |
| menesis | but you want to test it first? | 16:41 |
| aelkner | also, do we want it to include the search changes? | 16:41 |
| th1a | We can at least test it on dwelsh's data today. | 16:42 |
| th1a | I don't want to rush the search changes. | 16:42 |
| th1a | Let's just keep this a bugfix. | 16:42 |
| menesis | ok | 16:42 |
| th1a | So we know this works with Stephen's Data.fs, right? | 16:43 |
| th1a | (to confirm the obvious) | 16:43 |
| th1a | yvl: Is there any reason some people would have this bug and not others? Terms? | 16:43 |
| yvl | so, yes, this works with Stephen's Data.fs | 16:44 |
| yvl | his scenario that triggered the bug was | 16:44 |
| yvl | that they created new sections of courses | 16:45 |
| yvl | and those sections had same instructors | 16:45 |
| yvl | and they upgraded at that point | 16:45 |
| yvl | they were setting up spring 2013 sections it seems | 16:46 |
| yvl | so that's the scenario that breaks stuff | 16:47 |
| yvl | I would say it's a common one | 16:47 |
| th1a | OK. | 16:47 |
| th1a | Did you see the traceback I just forwarded? | 16:47 |
| yvl | yes, but didn't look closely | 16:48 |
| yvl | I think I saw that before somewhere | 16:48 |
| yvl | but can't recall it | 16:49 |
| yvl | looks a bit esoteric | 16:49 |
| th1a | OK. If it survives into tomorrow, you may have to field it. | 16:49 |
| th1a | I'll let you know. | 16:49 |
| th1a | Otherwise, I guess you can get back to reports. | 16:50 |
| th1a | Thanks yvl. | 16:51 |
| yvl | one more thing | 16:51 |
| aelkner | after yvl looks into the node index while testing issue, right? | 16:51 |
| yvl | Data.fs'es are always helpful in such cases, th1a | 16:51 |
| yvl | don't want to push it, but if they are in a mood to share... :) | 16:52 |
| yvl | btw, aelkner | 16:52 |
| yvl | do any of CanDo imports create/assign/modify persons or their groups? | 16:53 |
| aelkner | schooltool.virginia has a special section importer | 16:54 |
| aelkner | i think it assigns groups, but i have to check | 16:54 |
| yvl | it seems that some modified events were not fired and some of the objects were not indexed | 16:55 |
| yvl | and it is related to groups, persons or more likely their group membership | 16:55 |
| th1a | Do you want to take first crack at that aelkner? | 16:55 |
| yvl | if it keeps broken, please point me to a branch of schooltool.virigina they have deployed | 16:56 |
| aelkner | yvl, i don't think it has to do with schooltool.virginia | 16:58 |
| yvl | ok | 16:58 |
| yvl | so I don't know what they have deployed | 16:58 |
| yvl | but first place to look is at whatever imports they were dealing with | 16:58 |
| aelkner | wait, are we talking about the broken tests and the updateIndexes call? | 16:58 |
| yvl | that touched groups, persons, section membership and such | 16:58 |
| yvl | no aelkner | 16:59 |
| yvl | traceback th1a sent | 16:59 |
| aelkner | i just checked and schooltool.virginia importer doesn't touch group membership | 17:00 |
| aelkner | just section membership | 17:00 |
| aelkner | also, section courses and resources get updated | 17:01 |
| th1a | OK, well, let's table this for a minute. | 17:01 |
| th1a | So... we've got this "node index while testing issue?" yvl? | 17:02 |
| yvl | yes, the one we talked Monday | 17:03 |
| yvl | fix test set-up | 17:03 |
| yvl | I got aelkner's email -- thanks btw! | 17:03 |
| yvl | so I'll fix that once other things are done | 17:04 |
| aelkner | you asked, and you shall receive :) | 17:04 |
| th1a | kk | 17:04 |
| th1a | Anything else, yvl? | 17:04 |
| yvl | other things being only that traceback | 17:04 |
| yvl | I still want to be pointed to the code they have deployed :) | 17:04 |
| yvl | if they use schooltool.virginia - which revision or version or such and where I can find it :) | 17:05 |
| yvl | (assuming you want me to look into that traceback tomorrow) | 17:05 |
| th1a | Either aelkner or replaceafill should be able to have a first crack at it. | 17:06 |
| th1a | Thanks yvl. | 17:07 |
| th1a | menesis? | 17:07 |
| menesis | I have read juju docs and written a simple charm | 17:08 |
| menesis | also looked at some zope changes and what needs upgrading | 17:10 |
| th1a | I've been wondering about how one adds their own charms. | 17:10 |
| menesis | was trying to do that now | 17:12 |
| menesis | juju deploy --repository=. local:precise/schooltool | 17:14 |
| menesis | precise/schooltool is a directory where the charm is | 17:15 |
| th1a | Hm... | 17:15 |
| th1a | OK, well, let me know when you have something I can try. | 17:15 |
| menesis | but I am still waiting for it to do something | 17:16 |
| th1a | As in? | 17:16 |
| menesis | did not get an install to work yet | 17:17 |
| th1a | OK. | 17:17 |
| menesis | will tell when have one running | 17:17 |
| menesis | nothing interesting to say atm | 17:18 |
| th1a | All right. And shooting for a bugfix release tomorrow. | 17:18 |
| th1a | OK, thanks menesis. | 17:19 |
| th1a | aelkner? | 17:19 |
| aelkner | ok, i changed the search view filter to return no items when view is first called up | 17:20 |
| aelkner | then i added the No layers assigned checkbox and added the filter logic for it | 17:20 |
| aelkner | i fixed the broken tests that resulted from the changes, and sent word to yvl, as we discussed | 17:22 |
| aelkner | in so doing, i noticed one more thing about node layer filtering | 17:22 |
| aelkner | the import_skillls.xls test that i wrote a while ago was based on the original unit tests | 17:23 |
| aelkner | so some of the layers are not really rational, but they are theoretically possible | 17:24 |
| aelkner | so they still come up in the search | 17:25 |
| th1a | And? | 17:25 |
| aelkner | also, the checkboxes are based on the document layers | 17:25 |
| aelkner | so id a user adds a node with a layer that is not in a document, then it will not be findable | 17:26 |
| aelkner | unless we added yet another checkbox, 'nodes with weird layers' | 17:26 |
| aelkner | only kidding, ofc | 17:26 |
| aelkner | although i am seriously asking what you want to do about that case | 17:27 |
| th1a | There is no reason in particular not to list all layers in the system, right? | 17:27 |
| aelkner | ah, sorry, that wasn't it, i just realized something | 17:28 |
| aelkner | yes, all layers are listed as checkboxes, scratch what i just said about that | 17:28 |
| aelkner | the issue was this: | 17:28 |
| aelkner | in my silly test, again theoretically possible, a node was added | 17:28 |
| aelkner | and the layer was a skillset layer | 17:28 |
| aelkner | skillsets layers are grouped with the skillset checkbox | 17:29 |
| aelkner | so the current logic can never return those nodes | 17:29 |
| th1a | Because they are nodes and not skillsets? | 17:30 |
| aelkner | right | 17:30 |
| th1a | Maybe you should just prevent those from being created. | 17:30 |
| aelkner | and since the skillset layers are identified as such, they are removed from the nodes layer-based search | 17:31 |
| aelkner | i guess you mean have a check similar to cyclic relationship that throws an exception | 17:32 |
| aelkner | if a layer is chosen that is a skill or skillset layer | 17:32 |
| th1a | I suppose so. | 17:33 |
| aelkner | thing is, it's another place where the very idea of what is a skillset or skill layer is determined | 17:33 |
| aelkner | when the document heirarchy is set | 17:33 |
| aelkner | so, in theory, a layer could be added to a node that later turns out to be a skillset layer | 17:34 |
| aelkner | too late :( | 17:34 |
| th1a | OK, so basically, it is a bug. | 17:35 |
| aelkner | well, it's more like a situation that calls for a design decision | 17:36 |
| aelkner | i think we need to anticipate such weird nodes being created | 17:36 |
| aelkner | and have a way to find them | 17:36 |
| aelkner | as long as we allow the user to poke around nodes and change layers and such | 17:37 |
| aelkner | they have to be able to find nodes they may have broken | 17:37 |
| th1a | I'm pretty certain that when I first explained this requirement to you I suggested we just give documents simple attributes to remember aliases for "skillset" and "skill" but you didn't listen. | 17:37 |
| th1a | Anything other than that seems like a kludge. | 17:38 |
| aelkner | well, remember, the use case was to have a hierarchy of labels for adding the nodes down to the skills | 17:39 |
| th1a | But basically, I'm willing to just chalk these weird cases as a medium level bug and forget about it. | 17:39 |
| aelkner | and layers was the object that we had available for that purpose | 17:39 |
| th1a | The use case was always just to have different names for skillsets and skills in the context of the document. | 17:40 |
| th1a | That is all we ever wanted or needed. | 17:40 |
| aelkner | yeah, well, considering that it is only a theoretical case | 17:40 |
| aelkner | and using the document views will avoid it | 17:40 |
| aelkner | i can see chalking it as you suggest | 17:40 |
| th1a | I'm very much ready to put this behind us. | 17:41 |
| aelkner | regarding the design decision to use layers for skillsets and skills | 17:41 |
| aelkner | i'm surprised to hear raise an objection to that now | 17:42 |
| aelkner | it's not lke you haven't had two months since i did it to say something | 17:42 |
| aelkner | you know, restating a point until it is understood is not against the law | 17:42 |
| th1a | I wouldn't be complaining if it worked well. | 17:43 |
| aelkner | tbw, i would have loved to have not used layers, i just didn't see how | 17:43 |
| aelkner | i suppose we could have had the two special attributes as you suggest | 17:43 |
| th1a | OK, so when can we put this behind us? | 17:44 |
| aelkner | we kinda have to live with what we have regarding layers for skillsets and skills | 17:44 |
| aelkner | and yes, we can put behind us the issue with the funny nodes | 17:44 |
| aelkner | they are unlikely to happen in the real world, just possible in theory | 17:45 |
| aelkner | so, still to be done: | 17:45 |
| aelkner | 1) awaiting the indexing fix from yvl, then i'll incorporate it | 17:45 |
| aelkner | 2) i need to remove the skillset checkboxes from nodes-only search (edit child nodes view) | 17:46 |
| aelkner | 3) i need new tests, i only fixed existing ones, but we should have search tests that manipulate the checkboxes | 17:46 |
| aelkner | no more than a day, day and half or that | 17:47 |
| aelkner | all three that is | 17:47 |
| th1a | OK... | 17:47 |
| aelkner | we should try to get that into a release | 17:48 |
| aelkner | so welsh can have it? | 17:48 |
| aelkner | dev ppa, ofc | 17:48 |
| th1a | Can you start by triaging that import traceback today... try to get a handle on what its source is? | 17:48 |
| th1a | We'll get it out, but not immediately. | 17:49 |
| aelkner | i'm still wondering what you guys are referring to there | 17:49 |
| aelkner | was there a launchpad bug added | 17:49 |
| aelkner | or an email that i inadvertently deleted? | 17:49 |
| th1a | Fwd: CanDo Follow-up | 17:50 |
| aelkner | ah, the new one | 17:51 |
| aelkner | just noticed it | 17:52 |
| aelkner | so i see an id found in an index is corrupt, that's what yvl was talking about | 17:54 |
| aelkner | apparently the importer is suspected of corrupting an index?! | 17:54 |
| aelkner | i looked back at the chat and yvl asked if any of the importers change person group membership | 17:56 |
| aelkner | to answer the question in a more focused manner: | 17:56 |
| aelkner | schooltool.cando importers, no | 17:56 |
| aelkner | schooltool.virginia importer changes person section membership and section courses and resources | 17:57 |
| aelkner | schooltool core importer does change person group membership in various sheets | 17:57 |
| aelkner | but that's by design | 17:57 |
| aelkner | but i don't see how that would break an index | 17:58 |
| th1a | Well, take a look at it. | 18:00 |
| th1a | I'm going to wrap this up... | 18:00 |
| th1a | Thanks guys. | 18:00 |
| th1a | Have a good week and weekend. | 18:01 |
| * th1a drops the bag of gravel. | 18:01 | |
| aelkner | ok, thanks guys, great weekend | 18:01 |
| yvl | thanks guys | 18:07 |
| yvl | ok, th1a fix committed | 18:08 |
| th1a | Thanks yvl. | 18:20 |
| th1a | aelkner: ayt? | 18:55 |
| aelkner | th1a, yes? | 18:57 |
| th1a | I forwarded a bug from Welsh to you just now. | 18:57 |
| th1a | Since replaceafill is MIA. | 18:57 |
| aelkner | these tracebacks make me nervous, i mean how can one guess why they happen | 19:00 |
| th1a | Well, I guess replaceafill has access to the instance. | 19:02 |
| aelkner | yes, that always helps | 19:02 |
| aelkner | one needs to be able to match a version of codebase with a data file and recreate the problem on one's machine | 19:04 |
| aelkner | but you know what, i could make one guess | 19:04 |
| aelkner | could this have to do with the importer blowing away the skill equivalencies for project skills? | 19:05 |
| aelkner | i believe replaceafill coded a change to that import, but i doubt welsh has it | 19:06 |
| aelkner | also, even if he did, he would need to revert to the data.fs that was pre-reimport, if that's what happened | 19:06 |
| th1a | So basically we should wait for replaceafill to appear? | 19:07 |
| aelkner | you could ask menesis if he knows of the import change and if he can release it | 19:08 |
| th1a | Well, we're doing a release tomorrow. | 19:08 |
| aelkner | if that's commited, pushed yet or not | 19:08 |
| aelkner | perhaps it includes the import fix? | 19:08 |
| th1a | Yes, that will need to be in the release. | 19:08 |
| aelkner | ok, that's good, i would tell welsh that he needs to revert to pre-reimport data.fs | 19:09 |
| aelkner | and wait for the new release before reimporting | 19:09 |
| aelkner | if that is in fact what happened | 19:10 |
| th1a | I'll wait to see if replaceafill is alive since he can do whatever is necessary anyhow. | 19:10 |
| aelkner | ok, regarding the other traceback, who is the customer on that one? | 19:11 |
| aelkner | oh, glenda, right? | 19:11 |
| th1a | Yes. | 19:12 |
| aelkner | you know what, it could be the same reimport problem | 19:12 |
| aelkner | with the equivalcies | 19:12 |
| aelkner | because she says the gradebooks are broken | 19:12 |
| aelkner | but the traceback with the intid crash in the table formatter is not related to equivalencies | 19:13 |
| aelkner | that has something to do with group membership, a total mistery to me | 19:14 |
| aelkner | i don't see what the importing would do to break a intid in an index | 19:15 |
| aelkner | all the code does is do things like: students.remove(student) and students.add(student) | 19:16 |
| aelkner | that shouldn't break any index or item in an index | 19:16 |
| aelkner | yvl should probably look at that one, perhaps there's some tricky gotcha in schooltool.relationship? | 19:17 |
| aelkner | but i suspect you'll need to advise glenda to revert to pre-reimport data.fs as well | 19:21 |
| th1a | I think this is a fresh install anyhow. | 19:21 |
| aelkner | and to make sure that after restoring the data.fs, the problems go away | 19:21 |
| th1a | I'll send a follow-up. | 19:22 |
| aelkner | ok | 19:27 |
| *** ignas has quit IRC | 19:34 | |
| *** replaceafill has joined #schooltool | 20:13 | |
| replaceafill | th1a, zyt? | 20:13 |
| th1a | hi replaceafill. | 20:19 |
| replaceafill | hey th1a | 20:19 |
| replaceafill | i'm not MIA >:( | 20:19 |
| replaceafill | i'm traveling ;) | 20:19 |
| replaceafill | i'm in houston right now | 20:19 |
| th1a | oh yeah! | 20:19 |
| th1a | sorry | 20:19 |
| replaceafill | about to get into my next flight | 20:19 |
| replaceafill | but i wanted to ask you | 20:19 |
| replaceafill | i'm seeing a lot of tracebacks and errors | 20:19 |
| replaceafill | and fixes | 20:19 |
| replaceafill | i think i'll do some work when i get to the hotel | 20:20 |
| replaceafill | do you need me to do anything specific? | 20:20 |
| th1a | Mainly look at dwelsh's since you've got access to the server, I think. | 20:20 |
| replaceafill | yes | 20:20 |
| th1a | do that | 20:20 |
| replaceafill | the traceback he reported today, right? | 20:21 |
| replaceafill | kk, will do | 20:21 |
| th1a | yes | 20:22 |
| *** replaceafill has quit IRC | 20:36 | |
| *** paulproteus has quit IRC | 20:39 | |
| *** menesis has quit IRC | 20:46 | |
| *** paulproteus has joined #schooltool | 20:47 | |
| *** OTNexus has joined #schooltool | 22:54 | |
| OTNexus | ne1 online? | 22:54 |
| th1a | ne1? | 22:54 |
| OTNexus | anyone | 22:56 |
| OTNexus | :) | 22:56 |
| th1a | lol | 22:56 |
| th1a | hi OTNexus. | 22:56 |
| OTNexus | hey :) | 22:56 |
| th1a | Can I help you with something? | 22:58 |
| *** OTNexus has quit IRC | 23:24 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!