| replaceafill | and then the usual, lp:schooltool, etc | 00:00 |
|---|---|---|
| mattva01 | yep | 00:00 |
| * replaceafill thinks mattva01 remembers the last time he set this up :) | 00:00 | |
| mattva01 | kinda | 00:00 |
| replaceafill | ok, can we talk 3. now? | 00:01 |
| mattva01 | I think i'll be ok >.< | 00:01 |
| mattva01 | good with me | 00:01 |
| * replaceafill sees mattva01 starting to bleed :D | 00:01 | |
| replaceafill | ok pgulley dreich a few comments on my part | 00:01 |
| dreich | yep? | 00:02 |
| replaceafill | jelkner, asked me to review your work periodically | 00:02 |
| replaceafill | and it's way easier if you do 1 commit per feature | 00:02 |
| replaceafill | or per feature change | 00:02 |
| replaceafill | for example: | 00:02 |
| replaceafill | "fixed datetimeish, more random prettying" | 00:02 |
| replaceafill | makes me nervous because makes me think you found an issue with your changes | 00:03 |
| replaceafill | which makes me think the feature has no tests yet | 00:03 |
| replaceafill | and that's fine | 00:03 |
| replaceafill | there are also some debugging stuff you don't need to push to trunk | 00:04 |
| dreich | yeah, we've been doing it a bit piece-by-piece | 00:04 |
| replaceafill | that's ok, it's not a big deal | 00:04 |
| replaceafill | just take it into account | 00:04 |
| replaceafill | about randomness | 00:05 |
| replaceafill | that's maybe a jelkner question | 00:05 |
| replaceafill | but imho i think randomness should live in the deployment | 00:05 |
| replaceafill | instead of the quiz | 00:05 |
| replaceafill | but jelkner may have a different POV | 00:05 |
| replaceafill | the "Answers to Grade" table in the deployment view should be conditional | 00:05 |
| replaceafill | like, don't show it if no student has taken the quiz yet | 00:06 |
| jelkner | My answer will depend on cost for the moment | 00:06 |
| jelkner | if its cheap | 00:06 |
| jelkner | the deployment is better | 00:06 |
| jelkner | if it is expensive | 00:06 |
| jelkner | it's not that important | 00:06 |
| pgulley | it would be a cheap change. | 00:06 |
| replaceafill | absolutely | 00:06 |
| jelkner | cool, let's do it | 00:06 |
| replaceafill | i'd change the viewfunctions code to the utils module | 00:07 |
| replaceafill | and please, try to avoid "import *" | 00:07 |
| replaceafill | it makes debugging difficult | 00:07 |
| replaceafill | from my POV as a potential future maintainer of your work, the most valuable part will be tests | 00:08 |
| replaceafill | as long as you work with jelkner it's fine not having them, because he can reach you easily | 00:08 |
| mattva01 | i'll crack the whip at them over the summer :p | 00:09 |
| replaceafill | LOL! | 00:09 |
| replaceafill | the last part i don't understand | 00:09 |
| replaceafill | why do you need: Person(name='Bob')? | 00:10 |
| dreich | wait, I fixed that! | 00:10 |
| dreich | that was a debug thing | 00:10 |
| replaceafill | no | 00:10 |
| replaceafill | i mean, why do you need to pass the person's name? | 00:10 |
| dreich | because I was figuring out where to get people names from | 00:10 |
| dreich | oh, because I'm storing their real name as part of their user object | 00:10 |
| replaceafill | why? | 00:11 |
| replaceafill | here's my view of the issue: | 00:11 |
| replaceafill | jelkner register dreich in ST | 00:11 |
| replaceafill | as Davi Reich | 00:11 |
| replaceafill | he notices the typo in pyquiz | 00:11 |
| replaceafill | and says "oops" | 00:11 |
| replaceafill | goes back to ST and fixes it | 00:11 |
| replaceafill | gets back to pyquiz, still sees the typo | 00:11 |
| replaceafill | get my point? | 00:12 |
| dreich | how about it updates every time they log in? | 00:12 |
| dreich | which is easier than going over to schooltool each time we need it | 00:12 |
| replaceafill | dreich, under that logic we should store "everything" in pyquiz? | 00:13 |
| dreich | but we need the name unusually often | 00:13 |
| replaceafill | i know what you mean | 00:13 |
| dreich | whatever you think's the best design, though | 00:13 |
| replaceafill | but i've try to keep pyquiz as much unaware of data | 00:13 |
| replaceafill | that is not quiz related | 00:13 |
| replaceafill | dreich, if you really need it, you have sessions | 00:14 |
| dreich | ok, I get why then | 00:14 |
| replaceafill | just my 2 cents | 00:14 |
| replaceafill | and teachers have access to server.get_user_info(username) | 00:15 |
| replaceafill | following ST security model | 00:15 |
| replaceafill | but for the summer that may not be an issue | 00:15 |
| * replaceafill checks his notes | 00:15 | |
| dreich | ok, it still seems worth fixing | 00:16 |
| * replaceafill is done :) | 00:16 | |
| replaceafill | ok, now onto schooltool.pyquiz | 00:16 |
| replaceafill | dreich, pgulley do you have more pyquiz-only work to do? | 00:16 |
| replaceafill | i mean, did you run out of bugs yet? | 00:17 |
| dreich | yeah, there are a few more | 00:17 |
| dreich | images, writing tests, maybe something else | 00:17 |
| dreich | oh! | 00:17 |
| dreich | and sub-quizes | 00:17 |
| * mattva01 is gonna start checking out schooltool..... | 00:17 | |
| dreich | that was kinda wishlist though | 00:17 |
| pgulley | we still don't have proper gradebook integration, either. | 00:17 |
| pgulley | oh, not pyquiz only | 00:18 |
| replaceafill | pgulley, that's why i asked about pyquiz-only wokr | 00:18 |
| replaceafill | yes | 00:18 |
| replaceafill | :) | 00:18 |
| replaceafill | do me a favor | 00:19 |
| replaceafill | look in pyquiz bzr history | 00:19 |
| replaceafill | and enable the categories back | 00:19 |
| replaceafill | when you deploy a quiz | 00:19 |
| replaceafill | currently, it asks you "section", attempt and date" | 00:19 |
| replaceafill | right? | 00:19 |
| pgulley | right | 00:19 |
| dreich | yes | 00:19 |
| replaceafill | it used to ask you section, category, attempts and date | 00:20 |
| replaceafill | category was what made the link to the gradebook | 00:20 |
| replaceafill | enabled them back | 00:20 |
| replaceafill | enable( | 00:20 |
| replaceafill | gggrrr | 00:20 |
| replaceafill | enable them back :) | 00:20 |
| replaceafill | i think you should be able to do it looking at the code changes in bzr | 00:21 |
| replaceafill | or launchpad | 00:21 |
| dreich | yeah, ok | 00:21 |
| replaceafill | then you'll have that back | 00:21 |
| replaceafill | and we can start tweaking the gradebook | 00:21 |
| replaceafill | to have links and all the things jelkner wants | 00:21 |
| replaceafill | does that make sense? | 00:22 |
| pgulley | yessir | 00:22 |
| replaceafill | thanks | 00:22 |
| replaceafill | jelkner, i'm done | 00:22 |
| mattva01 | hmm, I haven't logged in to schooltool.gctaa.net except for automated stuff in ages | 00:23 |
| mattva01 | now to remember my username..... | 00:23 |
| mattva01 | it's just schooltool and that pyquiz branch right? | 00:32 |
| mattva01 | unless you changed the structure to not include that massive blob of zope dependencies? | 00:32 |
| replaceafill | let me see | 00:33 |
| mattva01 | oh right, cando gradebook and journal | 00:33 |
| mattva01 | can't remember the branches you want to for that.... | 00:34 |
| replaceafill | mattva01, you mean for the backup? | 00:34 |
| replaceafill | ah | 00:34 |
| replaceafill | for setting up the new instance | 00:34 |
| replaceafill | lp:pyquiz | 00:34 |
| replaceafill | lp:schooltool | 00:34 |
| replaceafill | lp:schooltool.gradebook | 00:34 |
| replaceafill | lp:schooltool.lyceum.journal | 00:34 |
| replaceafill | lp:~replaceafill/schooltool/schooltool.cando | 00:35 |
| mattva01 | ok cool | 00:35 |
| replaceafill | oops | 00:35 |
| replaceafill | sorry | 00:35 |
| replaceafill | that last one: | 00:35 |
| replaceafill | lp:~schooltool-owners/schooltool/schooltool.cando | 00:35 |
| mattva01 | ok so trunk for everything but cando | 00:35 |
| dreich | also schooltool.pyquiz, right? | 00:35 |
| replaceafill | lp:~replaceafill/schooltool/schooltool.pyquiz | 00:36 |
| replaceafill | mattva01, you create the branch from schooltool.pyquiz | 00:36 |
| replaceafill | and modify its buildout to include the others | 00:36 |
| replaceafill | (except pyquiz ofc) | 00:36 |
| mattva01 | yep, I remember that bit | 00:36 |
| mattva01 | just gonna tar up the whole directory, back it up, then rm -rf . | 00:38 |
| replaceafill | hhmm do we need the rm -rf part? | 00:39 |
| mattva01 | nah, but I don't want -old-old and -old .... | 00:39 |
| replaceafill | :D | 00:39 |
| replaceafill | ok | 00:39 |
| mattva01 | i'm fine with that though | 00:39 |
| replaceafill | i'd say new directory for new stuff | 00:40 |
| replaceafill | just in case jelkner loses the backup :P | 00:40 |
| mattva01 | good point | 00:40 |
| dreich | replaceafill, are we good on code discussion? | 00:45 |
| dreich | mattva01 can contact pgulley and I if there are problems with deployment | 00:45 |
| replaceafill | dreich, sure | 00:46 |
| dreich | alright, I think we're gonna head out then, we got some good work done here! | 00:46 |
| mattva01 | wait, last thing for replacefill: I checkout schooltool and checkout schooltool.pyquiz within it like last time? or checkout schooltool.pyquiz and put everything but pyquiz in the buildout.cfg? | 00:46 |
| *** pgulley has quit IRC | 00:47 | |
| *** dreich has quit IRC | 00:47 | |
| replaceafill | mattva01, a sec | 00:47 |
| replaceafill | sorry, phone call | 00:53 |
| replaceafill | mattva01, this time schooltool.pyquiz is the main branch | 00:53 |
| mattva01 | ok | 00:53 |
| replaceafill | it has a custom skin (that's why) | 00:53 |
| mattva01 | how do you set non-trunk branches in buildout.cfg? | 00:58 |
| jelkner | ok, replaceafill, mattva01, i need to run... thanks a 10**6! | 00:59 |
| *** jelkner has quit IRC | 00:59 | |
| replaceafill | develop = . /path/to/schooltool/trunk /path/to/schooltool.gradebook/trunk | 00:59 |
| replaceafill | and under [versions] put the packages: | 01:00 |
| replaceafill | schooltool = | 01:00 |
| replaceafill | schooltool.gradebook = | 01:00 |
| replaceafill | ... | 01:00 |
| replaceafill | that means, use the development checkouts | 01:00 |
| mattva01 | ah ok | 01:00 |
| mattva01 | so don't put anything in [package] ? | 01:01 |
| replaceafill | not necessary | 01:02 |
| replaceafill | /opt/summer2012, right? | 01:02 |
| mattva01 | yep | 01:03 |
| mattva01 | i'm gonna head home and finish this there, thanks for the help | 01:07 |
| replaceafill | sure | 01:07 |
| replaceafill | let me know if you need more help | 01:07 |
| mattva01 | ok | 01:07 |
| *** mattva01 has quit IRC | 01:11 | |
| *** th1a has quit IRC | 01:36 | |
| *** th1a has joined #schooltool | 02:57 | |
| *** newtonp has joined #schooltool | 03:25 | |
| *** newtonp has quit IRC | 03:26 | |
| *** ignas__ has joined #schooltool | 03:45 | |
| *** ignas__ has quit IRC | 05:06 | |
| *** th1a has quit IRC | 05:22 | |
| *** replaceafill has quit IRC | 06:34 | |
| *** th1a has joined #schooltool | 06:36 | |
| *** th1a has quit IRC | 07:51 | |
| *** menesis has quit IRC | 14:27 | |
| *** menesis has joined #schooltool | 15:29 | |
| *** replaceafill has joined #schooltool | 16:02 | |
| *** ignas_ has joined #schooltool | 16:08 | |
| *** pgulley has joined #schooltool | 16:12 | |
| *** th1a has joined #schooltool | 16:27 | |
| th1a | hi replaceafill, aelkner, menesis. | 16:30 |
| th1a | I guess yvl can't make it today. | 16:30 |
| replaceafill | good morning/afternoon | 16:31 |
| replaceafill | oh no :( | 16:31 |
| replaceafill | i had lots of questions for him | 16:31 |
| aelkner | morning | 16:31 |
| replaceafill | well, i'll write an email to the dev-list | 16:31 |
| th1a | OK. | 16:32 |
| aelkner | guys, we have issues with sections | 16:32 |
| menesis | hi. | 16:33 |
| aelkner | i believe the issues impact my imports/exports in a similar fashion as the sections view changes we discussed with welsh | 16:33 |
| th1a | Data model issues?!? | 16:33 |
| aelkner | indeed :) | 16:33 |
| aelkner | replaceafill, we should probably start by mentioning we met with welsh mon afternoon | 16:34 |
| replaceafill | right | 16:34 |
| aelkner | he gave us some feedback on the state of things, including changes he wanted in the sections view | 16:34 |
| replaceafill | i believe dwelsh and th1a have different opinions on that one | 16:35 |
| aelkner | i'm guessing you figured out that we have an issue when you went to make the changes, no? | 16:35 |
| replaceafill | aelkner, not really | 16:35 |
| replaceafill | what issue are you referring to? | 16:35 |
| aelkner | i just pulled trunk, and i see you haven't made the changes he wanted yet | 16:36 |
| replaceafill | lp:~replaceafill/schooltool/flourish_cando_fixes | 16:36 |
| aelkner | the fact that the same section appears twice | 16:36 |
| th1a | The thing about talking to Welsh is that he is usually right about the presence of problems but not the best solution. | 16:36 |
| aelkner | replaceafill, why haven't you put the changes in trunk? | 16:36 |
| replaceafill | aelkner, i talked to th1a about the "multiple sections" part | 16:36 |
| aelkner | oh | 16:36 |
| replaceafill | aelkner, because it's not definite yet | 16:36 |
| replaceafill | http://69.164.203.135:6660/sections | 16:37 |
| replaceafill | here | 16:37 |
| replaceafill | take a look | 16:37 |
| replaceafill | that's the way th1a suggested to do it | 16:37 |
| replaceafill | i was thinking i should add logic to make the checkboxes appear only if you have multiple terms in the year? | 16:38 |
| aelkner | so we are going to tell him that we can't avoid having the same section appear as many as four times? | 16:38 |
| th1a | If you filter you can. | 16:38 |
| th1a | Do you know what the overall use case is here? | 16:39 |
| replaceafill | th1a, is that the way you wanted it to work? | 16:39 |
| replaceafill | i mean, the checkboxes filtering | 16:39 |
| th1a | Yes, it looks good. Fancy update. | 16:39 |
| th1a | Newfangled javascript. | 16:39 |
| replaceafill | thanks yvl :) | 16:40 |
| aelkner | th1a, the use case is that the administrator, welsh, for instance, gets done with the imports and wants to check the sections | 16:40 |
| aelkner | he sees the same section four times and freaks out | 16:40 |
| th1a | OK, this should be fine then. | 16:40 |
| replaceafill | :D | 16:40 |
| aelkner | for instance, he has ten sections for MP1-MP2 | 16:40 |
| aelkner | twenty for MP3-MP4 | 16:41 |
| aelkner | he wants to see thirty sections, not sixty | 16:41 |
| aelkner | filtering by term does not help with this use case | 16:41 |
| th1a | Does the table do batching if necessary? | 16:41 |
| replaceafill | yes | 16:41 |
| replaceafill | stardard ajax table | 16:41 |
| replaceafill | standard* | 16:41 |
| th1a | aelkner: If you're talking about an administrator wanting to check the overall setup, you NEED filtering, so you can look at the terms separately. | 16:42 |
| th1a | If you hide any of them, you're defeating the purpose. | 16:42 |
| replaceafill | th1a, the part i couldnt think of a way to fix was the Sections accordion in the person index view | 16:42 |
| replaceafill | dwelsh complained of the same "issue" there | 16:43 |
| aelkner | exactly | 16:43 |
| th1a | Yes. Can't we just check which ones are linked? | 16:43 |
| replaceafill | let's take http://69.164.203.135:6660/persons/teacher001 | 16:43 |
| aelkner | if we can check which ones are linked in the accordion view, why not the sections view | 16:44 |
| aelkner | it's the same issue | 16:44 |
| th1a | It isn't the same issue insofar as a user and and administrator have different priorities. | 16:45 |
| th1a | We could just sort them by term here. | 16:45 |
| th1a | Put in a sub-accordion... | 16:45 |
| aelkner | if by administrator, you mean welsh, he sees his priority to be the same as his teachers | 16:46 |
| aelkner | namely, he doesn't need to see the same section more than once | 16:46 |
| th1a | aelkner: welsh does not necessarily see the big picture. | 16:46 |
| aelkner | well, if he fails to see it, and that continues to be the case, then you just have a pissed of user for no reason | 16:47 |
| th1a | a) so what; | 16:48 |
| th1a | b) there is a reason. | 16:48 |
| th1a | We don't have a flourished tree widget, do we? | 16:48 |
| replaceafill | no, we dont | 16:49 |
| replaceafill | th1a, the jstree library is still in our resources though | 16:50 |
| replaceafill | remember? the one we used for this in the old skin :) | 16:50 |
| th1a | I guess we can just use it for prototyping. | 16:51 |
| th1a | year > term > section | 16:51 |
| th1a | (prototyping and probably production) | 16:52 |
| th1a | Any objections to that? | 16:52 |
| replaceafill | so instead of the table in the Sections accordion, we would use a jstree widget | 16:52 |
| replaceafill | maybe displaying the active term by default? | 16:53 |
| th1a | A tree in the accordion. | 16:53 |
| replaceafill | right | 16:53 |
| th1a | So a tree instead of a table. | 16:53 |
| replaceafill | yes | 16:53 |
| th1a | Sure, show active term. | 16:53 |
| th1a | Do we have a method for determining that at this point? | 16:53 |
| replaceafill | yes, current term | 16:53 |
| aelkner | prior to a school year, there is no active term | 16:54 |
| replaceafill | aelkner, you mean like if you have persons and not sections? | 16:54 |
| aelkner | i mean, when you set up the data in august for a school year that starts in september | 16:55 |
| th1a | If there is no active term it is no big deal to show the tree collapsed. | 16:55 |
| aelkner | doesn't the first term only become active when september rolls around | 16:55 |
| replaceafill | aelkner, correct | 16:55 |
| replaceafill | ok, i'll work on the tree | 16:55 |
| replaceafill | for the Sections accordion | 16:56 |
| replaceafill | we may have another "data model issue" with skills | 16:56 |
| aelkner | ok, just realize that it will be a real complaint by welsh not to get what he requested on monday | 16:56 |
| aelkner | if that's ok, i don't have a problem either | 16:56 |
| aelkner | i can always say, talk to tom | 16:56 |
| aelkner | replaceafill, we meet with him today at 5:00, can you join us th1a? | 16:57 |
| th1a | It is probably cleaner than trying to collapse them, because then the user has the problem of actually seeing the section in the term he or she wants. | 16:57 |
| th1a | aelkner and replaceafill: It is not at all ok to schedule meetings with welsh without telling me. | 16:58 |
| aelkner | what the user, and by user i mean people we actually know here, wants is this: | 16:58 |
| aelkner | for admins and teachers, each section only appears once in a list | 16:58 |
| aelkner | its entry shows what terms the section is scheduled for | 16:59 |
| aelkner | so an example list for a teacher would be | 16:59 |
| aelkner | Math, MP1-MP2,... | 16:59 |
| aelkner | English, MP3-MP4 | 16:59 |
| th1a | What welsh wants is a completely redesigned term and section system. Failing that, we need to do what makes sense for SchoolTool. | 16:59 |
| aelkner | etc. | 16:59 |
| th1a | That then either requires the user to select the right link to get to the right section of the term or for us to guess right. | 17:00 |
| th1a | It is no more steps to have the user select the term first. | 17:00 |
| aelkner | we had an answer for that, remember replaceafill? | 17:00 |
| replaceafill | the current term, right? | 17:00 |
| aelkner | replaceafill, you seemed to have forgotten the things we agreed to with welsh | 17:00 |
| replaceafill | aelkner, i didnt | 17:01 |
| aelkner | th1a, sorry we had this meeting without you | 17:01 |
| th1a | What if that is not what the user wants? | 17:01 |
| th1a | I think a term-based tree is most clear and explicit. | 17:01 |
| replaceafill | aelkner, i just know that in this particular case th1a's opinion is different from dwelsh | 17:02 |
| th1a | If we expand the active tree by default the end result is the same anyhow. | 17:02 |
| aelkner | not exactly the same, as my example above demonstrates, MP3-MP4 class will not appear | 17:02 |
| aelkner | but i can't insist, only suggest | 17:03 |
| th1a | It will be in the tree. | 17:03 |
| th1a | This really needs to be a tree anyhow, because it will get big quickly. | 17:03 |
| th1a | We need to strike a balance where we aren't burdening the user with artifacts of our data model (every section is listed four times) but still make sure you're showing them all the data and giving them cues to the underlying structure. | 17:06 |
| aelkner | that's what the MP1-MP4 part was intended for, to cue the fact that the section is for those terms | 17:07 |
| aelkner | it would be listed just once but show the term range, and that's all that is interesting | 17:07 |
| aelkner | but, granted, it doesn't address the use case where enrollment varies from term to term | 17:08 |
| th1a | I think a tree is clearest. | 17:08 |
| th1a | Let's try that. | 17:08 |
| th1a | Can we do that today replaceafill? | 17:08 |
| replaceafill | that's what we had | 17:08 |
| replaceafill | sure | 17:08 |
| replaceafill | i'll try to have it ready by 5 | 17:08 |
| replaceafill | so dwelsh can see it | 17:08 |
| th1a | Ah, that's where I got the idea. ;-) | 17:09 |
| replaceafill | :P | 17:09 |
| replaceafill | ok | 17:09 |
| replaceafill | my data model issue? | 17:09 |
| th1a | Yes? | 17:09 |
| replaceafill | dwelsh also asked for two skills concepts: | 17:09 |
| replaceafill | core and additional | 17:09 |
| replaceafill | right now, we only have required/optional | 17:10 |
| replaceafill | core and additional relate to the "context" where the skill is assigned | 17:10 |
| replaceafill | like all skills related to a course may be core | 17:10 |
| replaceafill | and other skillls coming from different course lists may be additional | 17:10 |
| replaceafill | we don't have that in the current data model, afaik | 17:11 |
| replaceafill | also | 17:11 |
| replaceafill | dwelsh wants to be able to select a single skill from a course | 17:12 |
| replaceafill | and right now the data model only relates courses with "full" skillsets | 17:12 |
| replaceafill | i mean, it's not possible to select a single skill to relate to | 17:12 |
| th1a | This is the problem with you guys talking to welsh without me. | 17:13 |
| replaceafill | sorry th1a | 17:13 |
| th1a | We shouldn't be adding new features to CanDo now. | 17:13 |
| th1a | We don't need to do this until all the standard skill assignment functionality is solid. | 17:14 |
| replaceafill | i haven't added it, i just told welsh i'd ask yvl about it | 17:14 |
| th1a | OK. | 17:14 |
| replaceafill | i think these new concepts are part of skill assignment, aren't they? | 17:15 |
| aelkner | th1a, i wouldn't talk to welsh when you don't want, but then again, you did suggest that i handle things with him without bothering you, too, so we need to figure out when that is the case | 17:15 |
| th1a | We'll work it out but we can't get bogged down on new stuff. | 17:15 |
| th1a | aelkner: Pretty much only on his custom importers. | 17:15 |
| aelkner | ok | 17:15 |
| replaceafill | th1a, ok, so i should stick to required/optional for now to finish the view? | 17:16 |
| aelkner | i can't wait until 5:00 :) | 17:16 |
| replaceafill | :D | 17:16 |
| aelkner | sparks will be flying, and i'll just get a free show | 17:16 |
| th1a | The process is this: | 17:17 |
| th1a | Welsh detects a problem. | 17:17 |
| th1a | (he's right about that) | 17:17 |
| th1a | Welsh proposes a solution. | 17:18 |
| th1a | (which is not right for SchoolTool as a whole) | 17:18 |
| th1a | He and I argue about why he is wrong. | 17:18 |
| aelkner | :) | 17:18 |
| replaceafill | :D | 17:18 |
| th1a | I come up with a third solution. | 17:18 |
| th1a | He's fine with it. | 17:18 |
| aelkner | sounds like a happy ending | 17:18 |
| th1a | OK, so replaceafill has something to do. | 17:19 |
| replaceafill | yes | 17:19 |
| replaceafill | btw | 17:19 |
| th1a | aelkner: I'm getting worried that section importing is never going to end. | 17:19 |
| replaceafill | http://69.164.203.135:6660 | 17:20 |
| replaceafill | Done links now look like secondary buttons | 17:20 |
| replaceafill | let me know if you detect one i missed | 17:20 |
| replaceafill | (i haven't finished the gradebook/journal Done buttons) | 17:20 |
| replaceafill | th1a, i added better css to put the Done next to Search in filter widgets | 17:21 |
| th1a | OK. | 17:21 |
| th1a | I'll send an email with some shots to CL. | 17:21 |
| replaceafill | th1a, should i land this to trunk? | 17:22 |
| replaceafill | or wait for their feedback? | 17:22 |
| replaceafill | nm, i'll wait :) | 17:22 |
| th1a | We can wait as long as we don't forget we did it until I'm looking at the 12.10 release. | 17:22 |
| replaceafill | :D | 17:22 |
| th1a | replaceafill: Didn't we move those buttons!?!? | 17:23 |
| replaceafill | :D | 17:23 |
| th1a | OK. Thanks replaceafill. | 17:24 |
| th1a | So aelkner, where are we with section import? | 17:25 |
| aelkner | ok, so i finished writing and manually testing the importers as we discussed | 17:27 |
| aelkner | i went to write the corresponding exporters, and some issues came up | 17:27 |
| aelkner | i realized that our Sections sheet makes incorrect assumptions | 17:28 |
| aelkner | namely, that sections that are linked have the same section id in each term | 17:28 |
| aelkner | our data model does not enforce that, so generating a Sections sheet on export is problematic | 17:29 |
| aelkner | what if a section is encountered that is linked to another with different id in another term | 17:29 |
| th1a | OK. Good point. | 17:29 |
| aelkner | i'm bummed because i thought you had a good idea with the separate sheets | 17:30 |
| th1a | Just do the old way of designating before and after. | 17:30 |
| th1a | It doesn't change that aspect. | 17:30 |
| th1a | Just the term linking columns. | 17:30 |
| aelkner | the cols are Year, Courses, Start Ter,, End Term, Section ID, title, description | 17:31 |
| aelkner | oh, and teachers and resources | 17:31 |
| aelkner | what change are you suggesting? | 17:32 |
| th1a | The current version has... I don't know how they're labeled... previous and next? | 17:32 |
| th1a | Doesn't it? | 17:32 |
| aelkner | FlatSectionsTable, you mean, right? | 17:32 |
| th1a | Yes. | 17:33 |
| aelkner | that requires defining the section, with id, in each term | 17:33 |
| aelkner | and specifying the previous id and next id for linkage | 17:33 |
| aelkner | are you saying, get rid of Start Term, End Term, and replace wth just Term | 17:34 |
| aelkner | and have the section defined for each term with whatever id, and prov, next ids? | 17:34 |
| th1a | I think we have to. | 17:34 |
| th1a | Well, unless we want to give up on round tripping. | 17:35 |
| th1a | I don't think it is worth not being able to round trip. | 17:35 |
| aelkner | i would tend to agree | 17:35 |
| th1a | The overall splitting of section creation and enrollment I still think is important. | 17:35 |
| aelkner | dumping and loading is just a basic requirement for any robust database management system | 17:35 |
| th1a | Well, this isn't a robust database management system, but it is handy. | 17:37 |
| aelkner | thing is, we really were hoping for being able to have one occurrence of the section with students | 17:37 |
| aelkner | that's why you suggested the Start Term, End Term | 17:37 |
| aelkner | so that we didn't need four copies of the same list of thirty students | 17:38 |
| th1a | I don't think it is a big deal per se. | 17:38 |
| th1a | We could just allow you to specify multiple sections in the enrollment form. | 17:39 |
| th1a | That would just make it not a "flat" table. | 17:40 |
| aelkner | it's a sticky situation, can we discuss this via hangout | 17:40 |
| th1a | Sure. | 17:40 |
| *** dreich has joined #schooltool | 17:42 | |
| replaceafill | th1a, http://69.164.203.135:6660/persons/teacher001 | 18:10 |
| replaceafill | Sections accordion | 18:10 |
| th1a | Good. | 18:11 |
| th1a | Oh, if I'm not here at 5:00, you still can show David the changes to the section views. | 18:20 |
| replaceafill | kk | 18:20 |
| replaceafill | th1a, btw | 18:20 |
| th1a | I think they are both improvements he should be happy with. | 18:20 |
| replaceafill | we have another meeting with dwelsh on friday at 5:00 pm :) | 18:20 |
| aelkner | replaceafill, th1a, i forgot to mention | 18:21 |
| aelkner | i fond and fixed a bug in core | 18:21 |
| aelkner | the resource importer didn't import the description, it never has | 18:22 |
| th1a | We'll have to move the friday meeting. I have tee-ball. | 18:22 |
| replaceafill | th1a, ah ok | 18:22 |
| aelkner | so i changed that, but i haven't merged to trunk yet | 18:22 |
| th1a | OK, thanks aelkner. | 18:22 |
| aelkner | replaceafill, for now, just don't worry about it | 18:22 |
| * th1a drops the bag of gravel. | 18:22 | |
| replaceafill | aelkner, kk | 18:22 |
| aelkner | th1a, move the meeting to when? | 18:22 |
| th1a | Let's just move it to Monday. A friday evening meeting doesn't help much. | 18:23 |
| replaceafill | aelkner, i got the files, thanks! | 18:25 |
| * replaceafill goes to get breakfast | 18:26 | |
| * replaceafill back | 18:52 | |
| *** menesis has quit IRC | 19:36 | |
| aelkner | th1a, ayt? | 20:05 |
| th1a | yes | 20:05 |
| aelkner | i'm going to send you seom xls files and invite you to a hangout | 20:05 |
| th1a | ok | 20:06 |
| aelkner | did you get my invite? | 20:07 |
| th1a | just a sec. | 20:08 |
| *** menesis has joined #schooltool | 20:29 | |
| dreich | hey, replacefill, we're having a problem with selenium tests | 21:21 |
| replaceafill | yes? | 21:21 |
| pgulley | it's odd- They're running without issue now on my machine, however dreich's is producing error. | 21:21 |
| pgulley | our code is identical. | 21:22 |
| dreich | as in, I even re-branched pyquiz and it's still error-ing | 21:22 |
| replaceafill | what's the error? | 21:22 |
| dreich | rather, not error | 21:22 |
| dreich | failurs | 21:22 |
| dreich | *e | 21:22 |
| replaceafill | can you paste it pastebin.com | 21:23 |
| dreich | http://pastebin.com/t5v7GNzP | 21:24 |
| replaceafill | let me try running the tests | 21:25 |
| replaceafill | rev 51 | 21:26 |
| dreich | yep | 21:26 |
| replaceafill | tests pass here | 21:28 |
| pgulley | huh | 21:29 |
| dreich | ok | 21:29 |
| replaceafill | dreich, you sure you don't have any uncommited changes | 21:29 |
| dreich | that's what I'd thought it was, but it even fails in a fresh branch | 21:29 |
| replaceafill | with the same result | 21:29 |
| replaceafill | ? | 21:29 |
| dreich | yeah | 21:33 |
| replaceafill | dreich, what version of chromedriver are you using? | 21:35 |
| replaceafill | /usr/bin/chromedriver | 21:35 |
| dreich | it | 21:36 |
| dreich | 's the same one as pgulley, we downloaded from the same place | 21:37 |
| th1a | replaceafill: I'm getting a forbidden attribute when I try to add a project. | 21:42 |
| replaceafill | th1a, local instance? | 21:42 |
| th1a | Yes. | 21:43 |
| replaceafill | can you paste the error please? | 21:43 |
| th1a | It still creates it. | 21:43 |
| replaceafill | did it ask you to log in? | 21:43 |
| *** th1a_ has joined #schooltool | 21:44 | |
| th1a_ | http://pastebin.com/SQTNHSQc | 21:44 |
| replaceafill | th1a_, confirmed | 21:45 |
| replaceafill | the redirection from the add form is wrong | 21:45 |
| replaceafill | def nextURL(self): | 21:46 |
| replaceafill | return absoluteURL(self.worksheet, self.request) | 21:46 |
| replaceafill | should send you to the worksheet's gradebook | 21:46 |
| replaceafill | th1a, fixed | 21:48 |
| replaceafill | dreich, could you: | 21:51 |
| replaceafill | make dev | 21:51 |
| replaceafill | go to http://localhost:56544/setSessionData?username=userB | 21:51 |
| replaceafill | and then to http://localhost:565444 | 21:51 |
| replaceafill | "make dev" starts the test proxy server used in the tests | 21:52 |
| dreich | I just branched it again and am optimistically running tests, but I'll do that once it fails :) | 21:52 |
| replaceafill | :D | 21:52 |
| *** th1a_ has quit IRC | 21:54 | |
| dreich | yep, same deal | 21:54 |
| * th1a is heading over to http://www.fabacademy.org/ at AS220. | 21:55 | |
| dreich | and then I added userB that way, and it worked! | 21:55 |
| dreich | booted me to the login screen | 21:55 |
| replaceafill | looks like a sessions problem | 21:57 |
| dreich | is there a way to verify that it tears down between tests? | 21:57 |
| replaceafill | the order of tests! | 21:57 |
| replaceafill | it doesn't tear down | 21:57 |
| replaceafill | iirc | 21:57 |
| replaceafill | dreich, run: | 21:58 |
| replaceafill | bin/test -v | 21:58 |
| replaceafill | you should see the order of the tests | 21:58 |
| dreich | ok, thanks, I'll let it run. also, that dev server is really cool | 21:59 |
| dreich | also, I tried just running app.txt and none of the others, and it worked | 22:00 |
| replaceafill | right | 22:01 |
| replaceafill | here's how mine are run: | 22:03 |
| replaceafill | http://pastebin.com/eqT7EPgt | 22:03 |
| replaceafill | from the TODO.txt: | 22:05 |
| replaceafill | * Create a nice test environment: | 22:05 |
| replaceafill | - Change the use of tests views like addPerson and setSessionData | 22:05 |
| replaceafill | for good test setups | 22:05 |
| replaceafill | we need good test setups :D | 22:05 |
| dreich | yeah, mine's http://pastebin.com/DbHFyB89 | 22:07 |
| replaceafill | glad the app is not broken ;) | 22:08 |
| replaceafill | the test setup is :( | 22:08 |
| dreich | yeah | 22:08 |
| dreich | is there any reason not to restart the database/session between tests? | 22:08 |
| replaceafill | not really | 22:09 |
| replaceafill | tests dont depend on each other | 22:09 |
| replaceafill | they shouldnt | 22:09 |
| dreich | yeah | 22:09 |
| replaceafill | i can tackle that tonight | 22:10 |
| replaceafill | or you can do it now if you want | 22:10 |
| dreich | i'll look into it now, pgulley and I won't be around for too much longer | 22:10 |
| replaceafill | ok | 22:10 |
| dreich | but i'll see what I can get | 22:10 |
| replaceafill | sure | 22:10 |
| replaceafill | i think i can reproduce | 22:11 |
| replaceafill | using bin/test --shuffle | 22:11 |
| * replaceafill tries | 22:11 | |
| replaceafill | reproduced :) | 22:13 |
| dreich | nice, it's not just me! | 22:13 |
| dreich | where do you reccomend I look? | 22:13 |
| replaceafill | pyquiz/tests/pyquiz_selenium.py | 22:14 |
| replaceafill | SeleniumLayer.testSetup | 22:16 |
| replaceafill | give it a try or i'll make sure you have it working by tomorrow | 22:16 |
| * replaceafill goes to get lunch | 22:16 | |
| dreich | ok, I just found out I need to go to a class right now, so I'm not gonna be able to get anything done | 22:17 |
| dreich | thanks a lot though! see you tomorrow | 22:17 |
| *** dreich has quit IRC | 22:17 | |
| pgulley | I'm heading out now as well | 22:33 |
| *** pgulley has quit IRC | 22:33 | |
| *** mattva01 has joined #schooltool | 22:42 | |
| *** th1a has quit IRC | 23:01 | |
| *** mattva01 has quit IRC | 23:28 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!