*** th1a has joined #schooltool | 01:44 | |
*** alga has quit IRC | 02:19 | |
*** th1a has quit IRC | 02:56 | |
*** replaceafill has quit IRC | 03:04 | |
*** th1a has joined #schooltool | 03:34 | |
*** aks has joined #schooltool | 05:27 | |
th1a | aks: Just the person I need to talk to. | 05:28 |
---|---|---|
th1a | aks: I've been wondering what the status of SchoolTool in Nepal is. Do you have 2.0 running? | 05:40 |
*** aks has quit IRC | 06:00 | |
*** aks has joined #schooltool | 06:00 | |
*** paulproteus has quit IRC | 06:22 | |
*** paulproteus has joined #schooltool | 06:26 | |
*** th1a has quit IRC | 06:46 | |
*** alga has joined #schooltool | 11:58 | |
*** menesis has joined #schooltool | 13:57 | |
*** ignas has joined #schooltool | 14:15 | |
*** th1a has joined #schooltool | 15:24 | |
*** aks has quit IRC | 16:14 | |
*** replaceafill has joined #schooltool | 16:21 | |
th1a | hi replaceafill, aelkner. | 16:31 |
th1a | and menesis. | 16:31 |
replaceafill | good morning/afternoon | 16:31 |
th1a | yvl is apparently sick. | 16:31 |
th1a | ... has been sick. | 16:31 |
* replaceafill is sick too :( | 16:31 | |
aelkner | morning | 16:32 |
menesis | hello | 16:32 |
menesis | yes, yvl is sick | 16:33 |
menesis | and will likely be for the rest of the week | 16:33 |
th1a | Yes. | 16:33 |
th1a | OK, let's start by looking at: https://schwadesign.basecamphq.com/projects/7580415-2682-003-phase-1-2/posts/60927122/comments | 16:34 |
th1a | The fact of the matter is that other than report cards, almost all the other existing reports are just a header and a table. | 16:35 |
th1a | So I'll probably ask Vinny to do an example of a simpler tabular report. | 16:35 |
th1a | And fully annotate the examples. And that should be sufficient for us I think. | 16:35 |
th1a | Note that we don't literally have to include all these components (like the overview) but it is nice to have the style examples and ideas. | 16:37 |
th1a | I guess my question to aelkner and replaceafill is if you feel like you could start using the examples to create these reports and make others in the same style. | 16:39 |
replaceafill | th1a, i thought we were going to create a "central" style for reports | 16:39 |
replaceafill | stylesheet* | 16:39 |
replaceafill | and start using that | 16:40 |
replaceafill | the "css for reports" task | 16:40 |
th1a | Yes. | 16:40 |
aelkner | right | 16:40 |
replaceafill | or "css for pdfs" (don't remember the name) | 16:40 |
replaceafill | :) | 16:40 |
th1a | So... does anything in particular leap out as being missing to start doing that? | 16:40 |
aelkner | it looks like the comments section of the first report could be the outline activities in our layout | 16:41 |
replaceafill | i'd like to see a landscape version | 16:41 |
th1a | Good point! | 16:41 |
replaceafill | i think the gradebook should produce landscape reports | 16:41 |
replaceafill | (at least the worksheet pdf one) | 16:42 |
th1a | I think I should ask him for a generic table grid & textarea. | 16:42 |
th1a | OK. Do you feel like this is a good foundation replaceafill? | 16:44 |
replaceafill | th1a, i think so, i didn't get the Verdana change though | 16:44 |
replaceafill | we're still using the ubuntu font, right? | 16:45 |
th1a | Uh... Maybe this is a debian glitch... | 16:45 |
replaceafill | no, i mean "I used verdana for everything because I felt it’s a lot more websafe than ubuntu and it looks similar." | 16:45 |
th1a | Oh, well no, we aren't using verdana. | 16:46 |
replaceafill | kk | 16:46 |
th1a | Is that just in the web version? | 16:46 |
th1a | The printed examples use ubuntu anyhow don't they? | 16:46 |
* th1a didn't pay too much attention to the web example. | 16:46 | |
replaceafill | i think both use the same font | 16:47 |
replaceafill | and both seem like Verdana | 16:47 |
* replaceafill always watch the "l" :) | 16:47 | |
th1a | The J is different. | 16:47 |
th1a | Oh, he just uses it in the header. | 16:48 |
th1a | Well, anyhow, thanks for pointing that out. | 16:48 |
replaceafill | ah, true | 16:48 |
replaceafill | the report card is the most complex report we have, right? | 16:49 |
th1a | Or... maybe not. I guess that's not the Ubuntu J. | 16:49 |
th1a | But yes, the report card is the most complex one. | 16:49 |
th1a | We just need some simple generic examples. | 16:49 |
replaceafill | yes | 16:50 |
th1a | OK. | 16:50 |
th1a | I think we can move on. | 16:50 |
th1a | aelkner? | 16:51 |
aelkner | ok, so i took it upon myself (since i needed to add new tests to course) | 16:51 |
aelkner | to move all the export ftests to stests (except sample_data.txt) | 16:52 |
aelkner | the ftests only run at level 2, so if something gets broken, it isn't caught right away | 16:53 |
aelkner | now they are selenium tests, so they will run at the standard test level | 16:53 |
aelkner | this way, if someone does something to break the importer, they will catch it | 16:53 |
aelkner | anyway, i also coded the FlatSectionsTable export, replacing the old sections export | 16:54 |
aelkner | as we discussed, and added the unit tests for that | 16:54 |
aelkner | next, i will work on the report card xls export | 16:56 |
aelkner | what should the report request link be called? | 16:56 |
aelkner | Export Report Card XLS? | 16:56 |
aelkner | we have Export as XLS for the main one | 16:57 |
th1a | Oh, they're probably both wrong. | 16:57 |
aelkner | that being from the School tab, and exporting everything | 16:57 |
th1a | looking... | 16:58 |
th1a | Basically I'd like to move away from putting the format in the link. | 16:58 |
aelkner | people tend to think in terms of formats | 16:59 |
th1a | Put it under term and call it "Report Sheets" | 16:59 |
th1a | No... they don't think "I need to see an XLS." | 17:00 |
aelkner | if they are passing around files in email, they need to know what type of file to look for | 17:00 |
th1a | Basically going forward when there are multiple versions of the same report I'd like to have you choose in the dialog. | 17:00 |
aelkner | so they get into the habit of thinking of the file type that way | 17:00 |
th1a | Pick the data you want, then the format. | 17:00 |
aelkner | well, that's different | 17:01 |
replaceafill | users see the format in the request dialogs also, so they know | 17:01 |
aelkner | so, for now, it won't ask, but later it will | 17:01 |
th1a | As it becomes more necessary. | 17:01 |
th1a | The report system is going to get more complicated as needed. | 17:01 |
aelkner | so term view, Report Sheets, for now | 17:02 |
aelkner | we won't change the Export as XLS for now, right? | 17:02 |
th1a | It isn't a priority. | 17:02 |
aelkner | oh, one last thing, i realized that i hadn't added teachers and students to the groups | 17:03 |
aelkner | as i had just done for the old sections sheets | 17:03 |
aelkner | so i did that | 17:03 |
aelkner | that's tested as well | 17:03 |
aelkner | that's it for me | 17:03 |
th1a | So what's the time frame on the report sheet export? | 17:05 |
aelkner | that should take a day, so i'll need more tasks for the rest of the week | 17:06 |
th1a | OK, the question is what CanDo task would you be able to do without yvl around. | 17:07 |
th1a | Esp. since he's missing time, we need you rolling, but that's hard to start without him. | 17:07 |
th1a | But either skills import or ttw skills creation are the two obvious next steps. | 17:08 |
aelkner | skills import would be the best one to start with since my head in in import already | 17:08 |
aelkner | replaceafill, has yvl pushed a usable cando to trunk? | 17:09 |
th1a | Trunk? | 17:09 |
replaceafill | there's no trunk for cando yet | 17:09 |
th1a | It is in svn. | 17:09 |
aelkner | how do you keep in sync with yvl? | 17:10 |
replaceafill | aelkner, i haven't had the need to sync with him yet | 17:10 |
replaceafill | i took his branch when he left last time | 17:10 |
replaceafill | to do the gradebook work | 17:10 |
aelkner | yvl just pushed to lp:~justas-pov/schooltool/cando | 17:11 |
replaceafill | yes, but those don't affect what i'm doing | 17:11 |
replaceafill | he's working on models afaict | 17:11 |
aelkner | he just created an importer placeholder :) | 17:12 |
replaceafill | yep | 17:12 |
aelkner | titled Import Skills XLS :) | 17:12 |
th1a | Import Skills will do. | 17:12 |
replaceafill | he even made a little refactoring to the xls importer in core | 17:12 |
aelkner | i guess he didn't anticipate th1a's decision | 17:13 |
aelkner | it was idea to refactor core without communicating wth me | 17:13 |
aelkner | that's all i've been doing | 17:13 |
aelkner | unless it's a small change that i can easily merge | 17:14 |
replaceafill | i think it is aelkner | 17:14 |
aelkner | i'll have to see | 17:14 |
aelkner | i'll check out his core branch | 17:14 |
th1a | I would say the main thing is you should at least be ready to ask yvl some questions and hit the ground running on Monday with the importer. | 17:15 |
th1a | Ideally actually start it. But at least grok as much as you can about the new CanDo model. | 17:15 |
aelkner | that's exactly what i was about to suggest | 17:16 |
aelkner | sounds like a plan | 17:16 |
th1a | OK. Good. | 17:16 |
aelkner | the model he wrote is pretty solid, right? | 17:16 |
th1a | Ideally. | 17:16 |
aelkner | i mean, it has already come into shape | 17:17 |
th1a | The gradebook works. | 17:17 |
aelkner | what did he say he was about to do? | 17:17 |
th1a | So all the main pieces must exist. | 17:17 |
replaceafill | i added a couple of new attributes to skills though | 17:17 |
replaceafill | for the gradebook | 17:17 |
replaceafill | label and description | 17:17 |
replaceafill | there's also a difference in the worksheet base class | 17:18 |
replaceafill | yvl created a generic one for cando | 17:18 |
replaceafill | but my gradebook changes still depend on the old one | 17:18 |
aelkner | if i branched yvl's cando and merged your's i shouldn't get any conflicts, should i? | 17:19 |
th1a | I think there may be a couple loose ends in the model but I think the next step will be ttw skills creation. | 17:19 |
replaceafill | aelkner, the problem with my cando branch is that depends on my flourish and flourish.gradebook branches | 17:19 |
aelkner | replaceafill, it sounds like i will get conflicts | 17:19 |
aelkner | this is why i asked about trunk :) | 17:20 |
aelkner | we should have one | 17:20 |
aelkner | but anyway, i could start with yvl's branch, and look at yours some, too | 17:21 |
replaceafill | that's what i think you should do | 17:21 |
aelkner | perhaps on monday, we cold discuss getting a trunk together | 17:21 |
th1a | Why wouldn't you just use replaceafill's? | 17:21 |
replaceafill | th1a, i think that if aelkner doesn't need the gradebook functionality, he should start with yvl's | 17:22 |
replaceafill | and just look at my couple of attribute changes i mentioned | 17:22 |
replaceafill | or he'll get into the branches dependencies trouble | 17:22 |
replaceafill | for example: | 17:22 |
th1a | OK. | 17:22 |
replaceafill | my flourish branch has now jquery 1.9 | 17:22 |
aelkner | i could use a working gradebook, but it doesn't have to work at the stae of the arrt | 17:22 |
replaceafill | but i'm not sure if we're going to stick to that one | 17:22 |
aelkner | yvl's has a working gradebook, right? | 17:23 |
replaceafill | nope | 17:23 |
replaceafill | yvl's branch is just the data model | 17:23 |
aelkner | so your's is more up to date | 17:23 |
aelkner | i think th1a was right to suggest using yours | 17:23 |
replaceafill | from the gradebooks pov, yes | 17:23 |
replaceafill | if you do, remember to use my gradebook and trunk branches then | 17:23 |
replaceafill | but i suggest that if you don't need the gradebook functionality for your work, stick to yvl's | 17:24 |
th1a | It seems like replaceafill's will become the main working branch next week. | 17:24 |
replaceafill | th1a, correct | 17:24 |
replaceafill | but i'd like yvl's opinion on the jquery changes first | 17:24 |
replaceafill | the thing is that we decided to use the new jquery tooltip, in the unstable 1.9 version | 17:25 |
aelkner | replaceafill, i can create a new sandbox and branch your core, gradebook and cando | 17:25 |
replaceafill | aelkner, sure | 17:25 |
aelkner | as th1a said, that will probably end up as trunk, so it will create less conflicts | 17:25 |
replaceafill | th1a, but the way the tooltips are behaving now, seems like it can be done without the jquery's functionality | 17:26 |
replaceafill | so, that's a change i may revert at some point | 17:26 |
replaceafill | aelkner: | 17:27 |
replaceafill | lp:~replaceafill/schooltool/flourish | 17:27 |
replaceafill | lp:~replaceafill/schooltool/cando | 17:27 |
th1a | The whole thing seems like a toss up to me, but if I was doing it I'd just make a clean sandbox exactly like replaceafill's. | 17:27 |
replaceafill | lp:~replaceafill/schooltool.gradebook/flourish | 17:27 |
menesis | replaceafill: the releases will stick with jquery 1.7.1 and jqueryui 1.8.18 | 17:27 |
replaceafill | yes, i think it's a toss up too | 17:27 |
replaceafill | menesis, we discussed at the sprint that for the time cando was put into production, 1.9 could be out | 17:28 |
replaceafill | again, i don't think the tooltip change is strong enough for the move | 17:29 |
replaceafill | but we'll see | 17:29 |
replaceafill | i've been trying to implement the functionality the way th1a asked without tooltips from jquery | 17:29 |
replaceafill | just plain js | 17:29 |
menesis | maybe, but it is not released yet, so will not be available | 17:30 |
menesis | in ubuntu | 17:30 |
th1a | This would be in October release regardless. | 17:30 |
th1a | But it still might not be in Ubuntu by then. | 17:30 |
th1a | OK, aelkner, pick one. | 17:30 |
th1a | Six of one, half dozen of the other. | 17:31 |
aelkner | pick what? | 17:31 |
aelkner | i thought we agreed to me using replaceafill's | 17:31 |
aelkner | i had jsut suggested it and noone objected | 17:31 |
replaceafill | no objections frome me | 17:32 |
th1a | Settled. | 17:32 |
th1a | OK, thanks aelkner. | 17:32 |
th1a | menesis, anything to report? | 17:32 |
th1a | We are planning a final release before precise, correct? | 17:32 |
menesis | yes | 17:33 |
menesis | in fact, Final Freeze is tomorrow | 17:33 |
th1a | Ooh, so...? | 17:34 |
menesis | so I wanted to make a release today | 17:34 |
menesis | aelkner, replaceafill: anything you have finished but not yet merged to trunk? | 17:34 |
replaceafill | menesis, nothing from me | 17:35 |
menesis | th1a: it is two weeks until ubuntu release | 17:35 |
th1a | y | 17:35 |
aelkner | menesis, i have many importer changes | 17:35 |
th1a | That's for next release. | 17:35 |
menesis | during final freeze, all uploads have to be approved | 17:35 |
th1a | The CanDo style importer changes. | 17:35 |
aelkner | when is final freeze? | 17:35 |
th1a | aelkner: This would only be bugfixes. | 17:35 |
menesis | but since we are in universe, it is a formal approval | 17:36 |
aelkner | th1a, i made many changes to importer, but they are not only for cando | 17:36 |
th1a | Uh.... | 17:36 |
aelkner | well, the flat sections table could be considered only cando as they are only customer so far | 17:36 |
menesis | yes, Students and Teachers sheets are already merged | 17:36 |
th1a | The wholesale changes to the importer are NOT for this release. | 17:36 |
menesis | true | 17:37 |
th1a | It is just too late in the release process for such big changes. | 17:37 |
aelkner | well, i was about to merge to trunk by week's end, should i not? | 17:37 |
aelkner | menesis, would that throw you off? | 17:37 |
menesis | if it is big changes for cando/next release, then yes | 17:38 |
th1a | I'd like this done quickly by aelkner or menesis https://bugs.launchpad.net/schooltool.intervention/+bug/973679 | 17:38 |
aelkner | menesis, you could test merge with my branch to see | 17:39 |
aelkner | i haven't added to CHANGES.txt yet | 17:39 |
th1a | Is this resolved? https://bugs.launchpad.net/schooltool/+bug/944471 | 17:39 |
th1a | There is this https://bugs.launchpad.net/schooltool/+bug/967233 | 17:39 |
menesis | aelkner: will look, but I'd prefer to hold off merging features for one week | 17:40 |
aelkner | so i won't merge and push to trunk yet | 17:41 |
menesis | th1a: I can change the parents string 973679 | 17:41 |
aelkner | how about we talk about this again on monday | 17:41 |
aelkner | th1a, i haven't changed it yet | 17:41 |
th1a | This import stuff should not be going in. There isn't really any discussion. | 17:41 |
th1a | We need the fixes to 944471 but not the other import changes. | 17:42 |
th1a | I'd like this in https://bugs.launchpad.net/schooltool/+bug/967233 | 17:42 |
aelkner | into the release, yes, but it needs to get into trunk soon so that we can pile changes upon it | 17:42 |
aelkner | otherwise we build up the conflicts | 17:42 |
th1a | I'd like this in https://bugs.launchpad.net/schooltool/+bug/938825 | 17:43 |
th1a | This fix: https://bugs.launchpad.net/schooltool/+bug/963740 | 17:43 |
th1a | This fix: https://bugs.launchpad.net/schooltool/+bug/960367 | 17:43 |
th1a | This fix: https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/932508 | 17:43 |
menesis | I will create a stable branch for myself and you can merge everything to trunk | 17:44 |
aelkner | menesis, thanks | 17:44 |
menesis | but I'd like to be sure without doing work now, that what we have, works | 17:45 |
menesis | until I do final 2.1.0 release next week | 17:45 |
aelkner | i won't merge to trunk right away, we can discuss again monday, how about that? | 17:46 |
menesis | replaceafill: did not understand, have you solved 944471? does it need any code changes? | 17:46 |
menesis | aelkner: yes | 17:46 |
menesis | the custom demographic fields import | 17:47 |
th1a | Or did we not get to it? | 17:47 |
aelkner | are we discussing https://bugs.launchpad.net/schooltool/+bug/944471? | 17:47 |
aelkner | that one s assigned to me, but replaceafill is working with Carlos, no? | 17:47 |
th1a | I guess we only got the workaround? | 17:48 |
replaceafill | Carlos solved his problem afaik | 17:48 |
th1a | OK, now I'm remembering. | 17:48 |
menesis | as I understand custom demo fields work | 17:48 |
aelkner | so that is no longer a valid bug | 17:48 |
th1a | We talked about fixing it but I guess forgot aelkner? | 17:48 |
menesis | but there were issues | 17:48 |
th1a | NO IT IS A BUG. | 17:48 |
aelkner | oh | 17:48 |
th1a | Remember talking about needing a two-pass importer? | 17:49 |
aelkner | menesis just said they work, that's what i expect | 17:49 |
replaceafill | aelkner, you changed the importer to add the persons to the teachers/students group, right? | 17:49 |
th1a | Regardless, I guess we're not going to have the fix in the release since we haven't fixed it. | 17:49 |
replaceafill | i remember that was the issue with that bug | 17:49 |
aelkner | replaceafill, yes | 17:49 |
th1a | But that needs to be done before aelkner moves on to CanDo anyhow. | 17:49 |
replaceafill | iirc the data is importer, but not visible, because the person was not in the correct group | 17:50 |
replaceafill | so the limited demo fields were not shown | 17:50 |
replaceafill | imported* | 17:50 |
replaceafill | aelkner changed that, so the limited demo fields *should* now be shown | 17:51 |
aelkner | ah, yes, that lead to the idea to automatically add them to the groups | 17:51 |
replaceafill | yep | 17:51 |
aelkner | anyway, i found the merge to trunk with that feature, march 26 | 17:52 |
th1a | It doesn't solve the fundamental problem -- it still should work only with the persons sheet. | 17:52 |
replaceafill | hhmm | 17:52 |
th1a | Are the attributes just hidden until the group is set or are they not added at all? | 17:52 |
aelkner | the persons sheet has all demos | 17:52 |
replaceafill | th1a, just hidden | 17:52 |
replaceafill | th1a, you can't tell the groups from the person sheet | 17:53 |
aelkner | right | 17:53 |
replaceafill | unless you sniff the data or something | 17:53 |
aelkner | no, ot possible | 17:53 |
aelkner | the columns need to be fixed by group | 17:53 |
replaceafill | "this column should only be set for teachers, so if this person has data on it, it is a teacher" | 17:53 |
th1a | Can't we just make the person view show attributes that have values, even if the group isn't set? | 17:53 |
aelkner | th1a, the way it works now is correct | 17:54 |
replaceafill | th1a, i thought of that at the beginning, but then you loose the functionality of limited demo fields | 17:54 |
aelkner | all demos are columns after the standard columns | 17:54 |
th1a | There is no reason in particular to hide the values. | 17:54 |
aelkner | the only sheets that limit the columns are the new Teachers and Students sheets | 17:54 |
th1a | Don't we hide all demos that have no values? | 17:54 |
aelkner | those take the current limit groups into account | 17:55 |
aelkner | th1a, values are irrelevent during mport | 17:55 |
th1a | The bug is really just this -- I added an attribute, now I can't see it. | 17:55 |
aelkner | the columns have to be fixed | 17:55 |
aelkner | you have to export to see it | 17:55 |
aelkner | if they add a demo | 17:56 |
th1a | replaceafill: I don't understand what functionality we would lose if we'd show all attributes that *have values* | 17:56 |
th1a | Is it because some have default values? | 17:56 |
replaceafill | th1a, suppose your persons have attribute "foo", all with data | 17:56 |
aelkner | ok, what are we talking about 'show attributes'? exporting or importing? | 17:57 |
replaceafill | but then you decide, this should only be used for students | 17:57 |
th1a | Viewing the data! | 17:57 |
replaceafill | then you make it limited | 17:57 |
th1a | In the web interface. | 17:57 |
th1a | replaceafill: That's not really a use case. | 17:57 |
replaceafill | it was for cando | 17:57 |
replaceafill | and the teacher_id | 17:57 |
th1a | Making an existing value limited is not a use case. | 17:57 |
replaceafill | and the report_id for students | 17:57 |
th1a | Did students have teacher_id's assigned? | 17:58 |
replaceafill | yes, because it was the same demo field | 17:58 |
replaceafill | already with data | 17:58 |
th1a | Well, that's stupid and not a use case. | 17:58 |
replaceafill | :D | 17:58 |
th1a | Nobody is going to start using SchoolTool today with one field and different semantics by group. | 17:58 |
replaceafill | that's what i thought, but demo fields fix that | 17:58 |
aelkner | well, the important thing is that you two know what you're talking about | 17:58 |
aelkner | because you've lost me | 17:59 |
th1a | aelkner: The actual PROBLEM is that people are importing data and then they can't see it in the web interface. | 17:59 |
menesis | if persons are in correct groups then demo fields are shown correctly | 17:59 |
replaceafill | th1a, what about this: | 17:59 |
th1a | But it is there, so all we have to do is show it. | 17:59 |
replaceafill | you see the demo field in the person index view | 17:59 |
replaceafill | and you say, i'll edit it | 17:59 |
replaceafill | but you don't see it in the edit form | 17:59 |
replaceafill | because it's limited | 17:59 |
th1a | That is still an improvement. | 17:59 |
th1a | Add them to the right group and edit it. | 18:00 |
replaceafill | ok, i'm out :) | 18:00 |
th1a | Basically, this is a situation where a common case will generate confusion and bug reports -- importing people without groups. | 18:00 |
th1a | And there are some not very important corner cases that come up with the simple solution. | 18:00 |
aelkner | keep this in mind: | 18:01 |
th1a | I'd much rather handle the "How do I delete this "Teaching Certification: NO" field I accidentally imported for a student question than the "I can't import my demographic data" question. | 18:02 |
replaceafill | th1a, +1 | 18:02 |
aelkner | well, that | 18:02 |
aelkner | that's a different issue entirely | 18:02 |
th1a | No, THAT'S THE ISSUE. | 18:02 |
th1a | The problem is not that we aren't storing the data, right? We're just not displaying it. | 18:03 |
th1a | Correct? | 18:03 |
replaceafill | correct | 18:03 |
th1a | So just display it! | 18:03 |
aelkner | so even if the user i snot in the group, but has the demo value | 18:04 |
replaceafill | -1, but ok :P | 18:04 |
aelkner | display it in the person view | 18:04 |
replaceafill | aelkner, yes | 18:04 |
aelkner | i see what th1a means, it stops hiding the data issue :) | 18:04 |
aelkner | did i say issue? | 18:04 |
aelkner | i mean situation :) | 18:04 |
replaceafill | :D | 18:05 |
th1a | As long as it isn't a data MODEL issue. | 18:05 |
aelkner | :) | 18:05 |
th1a | Which it isn't. | 18:05 |
aelkner | so that's a small change to the person view, whose is it? | 18:05 |
aelkner | which bug is this? | 18:05 |
menesis | https://bugs.launchpad.net/schooltool/+bug/944471 | 18:05 |
th1a | The export should work the same way too: it should have demographic fields even if they aren't supposed to be there based on group. | 18:06 |
th1a | replaceafill: Can you do this? | 18:06 |
replaceafill | it should be ready for tomorrow right? | 18:06 |
aelkner | th1a, the export already does that | 18:06 |
th1a | aelkner: OK, great. | 18:06 |
th1a | OK, reassigned to replaceafill. | 18:06 |
menesis | th1a: other bugs you pasted are fix committed, and merged to trunk | 18:07 |
th1a | OK... where were we... ah, | 18:07 |
th1a | Thanks menesis! | 18:07 |
th1a | replaceafill? | 18:07 |
replaceafill | just one quick question | 18:07 |
th1a | For some reason I thought this would be a quick meeting. | 18:07 |
menesis | except import bug with school day names, https://bugs.launchpad.net/schooltool/+bug/901267 | 18:07 |
replaceafill | the person index view change has to be done by tomorrow, right? | 18:07 |
menesis | replaceafill: in a week | 18:08 |
replaceafill | menesis, ah ok, thanks | 18:08 |
replaceafill | ok, my report | 18:08 |
replaceafill | after i showed th1a my tooltip changes, we agreed on putting the tooltip above the navbar | 18:09 |
replaceafill | and do the same old functionality | 18:09 |
replaceafill | you hover the skill id and you get the div updated | 18:09 |
replaceafill | so i started doing that and i realized we don't need tooltips for that | 18:10 |
replaceafill | (as i mentioned earlier) | 18:10 |
replaceafill | and that would remove the jquery 1.9 dependency | 18:10 |
replaceafill | unless you guys see we could use tooltips in some other places | 18:10 |
replaceafill | ... | 18:11 |
replaceafill | th1a, do you? | 18:11 |
th1a | No. | 18:11 |
menesis | I'd like jqueryui 1.9 reverted | 18:12 |
replaceafill | kk | 18:12 |
replaceafill | done then | 18:12 |
replaceafill | i'll revert that change | 18:12 |
replaceafill | i also got rid of the vertical scrolling in the tertiary navbar | 18:12 |
menesis | tooltips - maybe, but I think in most cases title attr is enough | 18:12 |
replaceafill | when you have too many worksheets | 18:13 |
replaceafill | menesis, agree | 18:13 |
replaceafill | now, i'm in the middle of making that new tertiary nav scrollable | 18:13 |
replaceafill | the last unfinished task i started is auto save | 18:14 |
replaceafill | th1a, here i have a question | 18:14 |
replaceafill | if we implement auto-save on cells | 18:14 |
replaceafill | we're going to get rid of the Save button? | 18:14 |
replaceafill | or should we leave it for the user to save a bunch of changes "quickly" | 18:14 |
replaceafill | assumming auto save takes like 2-3 seconds on each cell after the last edit | 18:15 |
th1a | I think we decided it should still exist. | 18:15 |
menesis | Gmail autosaves drafts, but it has a Save now button | 18:15 |
replaceafill | ah ok | 18:15 |
replaceafill | i'll leave it then | 18:16 |
replaceafill | th1a, last question | 18:16 |
replaceafill | i can't find that bug | 18:16 |
th1a | We'll refine it after we look at it a while. | 18:16 |
menesis | I think it does not hurt if a user clicks just to make sure everything i saved before leaving | 18:16 |
replaceafill | but there's a bug about exporting the journal data into xls | 18:16 |
th1a | From jelkner? | 18:16 |
replaceafill | no, that's the pdf one :) | 18:16 |
th1a | Ah. | 18:17 |
replaceafill | it was someone who asked about it, i'm not sure if there's abug | 18:17 |
aelkner | jelkner asked for it | 18:17 |
aelkner | yes, he created a bug | 18:17 |
replaceafill | jelkner asked for the pdf one i think | 18:17 |
replaceafill | i'm talking about exporting the journal into xls | 18:18 |
menesis | https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/961854 | 18:18 |
menesis | is the xls bug | 18:18 |
replaceafill | ah menesis thanks | 18:18 |
aelkner | https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/977430 | 18:18 |
replaceafill | that's the one | 18:18 |
replaceafill | duh! it's under the journal project :D | 18:18 |
* replaceafill was looking at trunk bugs | 18:19 | |
replaceafill | th1a, should i finish that one this week too? | 18:19 |
th1a | you should use schooltool-project when looking at bugs. | 18:19 |
replaceafill | i remember you said you wanted it in this release | 18:19 |
replaceafill | th1a, i usually do, don't know how i was redirected to only schooltool bugs | 18:19 |
th1a | If you can do it in a day or two and menesis can get it in next week, sure. | 18:20 |
replaceafill | can i move to this two bugs now and leave my cando changes for a while | 18:20 |
replaceafill | i think my cando changes are not very important right now | 18:20 |
replaceafill | i mean, high priority | 18:21 |
replaceafill | i just want to get rid of these bugs before continuing :D | 18:21 |
th1a | Well, we need to get cracking on CanDo though. | 18:22 |
th1a | Esp. after this release. | 18:22 |
replaceafill | th1a, i think i'm just waiting for the skills hierarchy to start the skills gradebook | 18:22 |
th1a | If your gradebook changes are becoming trivial, there's certainly more substantial stuff to be done. | 18:22 |
replaceafill | *that's* the right wording | 18:23 |
replaceafill | they seem trivial | 18:23 |
replaceafill | cosmetic i'd say | 18:23 |
th1a | Oh yes, skills hierarchy. | 18:23 |
th1a | Are they not in a hierarchy now? | 18:24 |
th1a | Could you work on the skills tree view? | 18:24 |
th1a | That's certainly non-trivial. | 18:24 |
replaceafill | not without yvl's changes | 18:24 |
replaceafill | and i think he's on that | 18:24 |
th1a | OK... so that is the major loose end at this point. | 18:24 |
replaceafill | that's why i was thinking of doing bugs instead | 18:24 |
th1a | Which is essentially blocking aelkner now too. | 18:25 |
* th1a couldn't remember what that was. | 18:25 | |
th1a | So basically we're entering the worst case scenario after a good start. | 18:25 |
th1a | The data model isn't done and we're all stuck. | 18:25 |
replaceafill | or i could port the gradebook view to the generic worksheet | 18:26 |
replaceafill | that i can do! | 18:26 |
menesis | yvl won't finish the model while he's sick | 18:26 |
th1a | Well wait, what about gradebook ajax? | 18:26 |
th1a | Are you going to be done with that? | 18:26 |
replaceafill | th1a, true! i can make the tabs ajaxy | 18:27 |
replaceafill | i mean the worksheets | 18:27 |
th1a | Yes, do that. | 18:28 |
replaceafill | kk | 18:28 |
replaceafill | and that's not trivial :D | 18:28 |
replaceafill | ok, that's it from me | 18:28 |
th1a | aelkner should probably still prep for skills importer even though the hierarchy may not be done. | 18:28 |
th1a | OK... thanks guys. | 18:29 |
th1a | Have a great week & weekend! | 18:29 |
* th1a drops the bag of gravel. | 18:29 | |
replaceafill | thanks everybody | 18:29 |
menesis | :) | 18:30 |
aelkner | great weekend all | 18:30 |
*** replaceafill has quit IRC | 18:59 | |
*** replaceafill has joined #schooltool | 19:01 | |
replaceafill | hhmm, is it me or the selenium tests in the journal are being translated...? | 19:27 |
replaceafill | ah got it, the stesting.zcml is incorrect | 19:30 |
replaceafill | it's funny to see how stests have evolved when you update an old one :) | 19:35 |
*** menesis has quit IRC | 19:43 | |
*** ignas has quit IRC | 20:07 | |
replaceafill | th1a, zyt? | 21:15 |
th1a | si | 21:15 |
replaceafill | hola Tomás :) | 21:15 |
replaceafill | i'm working on this one: https://bugs.launchpad.net/schooltool.lyceum.journal/+bug/961854 | 21:15 |
replaceafill | and i was wondering about the header of the columns for the periods | 21:15 |
th1a | aelkner: ayt? | 21:15 |
replaceafill | should we use the same logic as the journal | 21:16 |
replaceafill | i mean | 21:16 |
th1a | We don't need to truncate them if that's what you're asking. | 21:16 |
replaceafill | if the period has its own title, use that for the export | 21:16 |
replaceafill | but we use the period title if the user has set the timetable like that, right? | 21:17 |
replaceafill | or export a date if he hasn't | 21:17 |
th1a | Uh... I'm not sure what the alternative is? | 21:18 |
replaceafill | use a date always | 21:18 |
replaceafill | that's what the journal uses for the tooltip (title atr) | 21:19 |
th1a | For this we can add two rows in the header if it makes things more explicit. | 21:19 |
replaceafill | ah | 21:19 |
replaceafill | ID, first name, last name, date, date date, date... | 21:20 |
replaceafill | period, period, period, period... | 21:20 |
replaceafill | something like that? | 21:20 |
th1a | periods below? | 21:20 |
replaceafill | or the other way around? | 21:21 |
replaceafill | dates below | 21:21 |
replaceafill | ah, i see | 21:21 |
replaceafill | the journal uses the short title always | 21:21 |
replaceafill | i need to set up a different timetable to see the other case | 21:23 |
th1a | Just bear in mind that we should be optimizing this for automated processing, right? | 21:23 |
replaceafill | ah true | 21:23 |
replaceafill | hhmm | 21:23 |
replaceafill | in that case we should use the date instead of just the day i think | 21:24 |
replaceafill | the journal view uses: | 21:24 |
replaceafill | 02 | 03 | 04 | ... | 21:24 |
replaceafill | the Day | 21:24 |
replaceafill | D | D | D | ... | 21:24 |
replaceafill | the Period | 21:24 |
replaceafill | when you said two rows i actually thought of 3 | 21:25 |
replaceafill | day, date and period | 21:25 |
replaceafill | my bad | 21:25 |
replaceafill | i'll code the date and the period and show it to you | 21:26 |
replaceafill | sorry for the (usual) confusion | 21:26 |
replaceafill | :) | 21:26 |
th1a | Oh... yes, for export, you really want the date in this case. | 21:26 |
replaceafill | ys | 21:26 |
replaceafill | yes | 21:26 |
th1a | Heck, maybe it should be the date all the time. | 21:26 |
replaceafill | if this is for automated processing, maybe "they" should take care of converting the date to a period ;) | 21:27 |
th1a | Because you don't want to get the wrong "C Day" | 21:27 |
replaceafill | how does the journal work if you teach the same section twice in a day in non-consecutive periods | 21:28 |
* replaceafill goes to see | 21:28 | |
replaceafill | i bet two columns with the same day, date and different periods... | 21:28 |
replaceafill | th1a, zyt? | 22:36 |
th1a | Si! | 22:36 |
replaceafill | :D | 22:36 |
replaceafill | 69.164.203.135:6664/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000/journal/ | 22:36 |
replaceafill | teacher004 | 22:36 |
replaceafill | help me with the XXX parts please | 22:37 |
replaceafill | Reports group in the sidebar | 22:37 |
th1a | Hm... | 22:38 |
th1a | Perhaps we could call this XLS Export. ;-) | 22:38 |
replaceafill | really? | 22:38 |
replaceafill | ok | 22:38 |
replaceafill | then there's a XXX in the request dialog | 22:39 |
th1a | I'm not sure what my rule of thumb is here. | 22:39 |
*** ignas has joined #schooltool | 22:40 | |
th1a | I guess I see a distinction between a report which is just a representation of the thing in a different format and a report that is pulling in a certain set of data. | 22:41 |
th1a | I think the dialog is fine. | 22:42 |
th1a | And maybe we should stick with Journal Export to keep aelkner from killing me. | 22:42 |
replaceafill | maybe we should create an Export group for representations | 22:42 |
replaceafill | :D | 22:42 |
replaceafill | kk | 22:43 |
replaceafill | i'll remove the XXXs then | 22:43 |
replaceafill | what about the content of the xls | 22:43 |
replaceafill | does it look ok? | 22:43 |
th1a | I guess the main point is I don't want to see growing lists of format identifiers in the reports sidebar. | 22:43 |
replaceafill | or we could put the export options (representations) in the gear menu someday :) | 22:44 |
th1a | Not there... | 22:44 |
th1a | The export looks ok to me. | 22:44 |
replaceafill | ok | 22:44 |
replaceafill | i'll clean it up and push to trunk then | 22:44 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!