| *** menesis has quit IRC | 00:35 | |
| *** jelkner has joined #schooltool | 01:44 | |
| *** jelkner has quit IRC | 01:48 | |
| *** jelkner has joined #schooltool | 01:50 | |
| *** jelkner has quit IRC | 01:52 | |
| *** jelkner has joined #schooltool | 01:56 | |
| *** mattva01 has quit IRC | 01:59 | |
| *** mattva01 has joined #schooltool | 01:59 | |
| *** jelkner has left #schooltool | 02:00 | |
| *** th1a has joined #schooltool | 02:24 | |
| *** th1a has quit IRC | 04:19 | |
| *** ignas has quit IRC | 04:40 | |
| *** alga has quit IRC | 04:45 | |
| *** aks has joined #schooltool | 04:54 | |
| *** aks has quit IRC | 04:57 | |
| *** aks has joined #schooltool | 04:57 | |
| *** replaceafill has quit IRC | 05:01 | |
| *** menesis has joined #schooltool | 10:41 | |
| *** alga has joined #schooltool | 11:18 | |
| *** menesis has quit IRC | 14:19 | |
| *** ignas has joined #schooltool | 15:05 | |
| *** menesis has joined #schooltool | 15:21 | |
| *** menesis has quit IRC | 15:29 | |
| *** menesis has joined #schooltool | 15:29 | |
| *** paulproteus has quit IRC | 15:33 | |
| *** paulproteus has joined #schooltool | 15:34 | |
| *** th1a has joined #schooltool | 16:17 | |
| *** replaceafill has joined #schooltool | 16:19 | |
| *** yvl has quit IRC | 16:34 | |
| *** aks has quit IRC | 16:48 | |
| *** replaceafill has quit IRC | 17:00 | |
| *** replaceafill has joined #schooltool | 17:13 | |
| *** replaceafill has joined #schooltool | 17:13 | |
| *** jelkner has joined #schooltool | 18:18 | |
| *** replaceafill has quit IRC | 18:18 | |
| *** replaceafill has joined #schooltool | 18:24 | |
| *** jelkner has quit IRC | 18:41 | |
| aelkner | th1a, hey | 20:29 |
|---|---|---|
| th1a | hey aelkner. | 20:30 |
| aelkner | so i've had a chance to go over the cte site | 20:30 |
| aelkner | and i looked at the install pdf and the saple csv files | 20:30 |
| aelkner | also, i fond the code where the importing gets done | 20:30 |
| aelkner | actually, the sample files are xls | 20:30 |
| aelkner | but the importer (as the instructions indicate) require csv | 20:31 |
| th1a | Hm... yes we discussed that at the sprint. | 20:31 |
| aelkner | anyway, the students csv is basically the standard basicperson with one exception, State Id | 20:31 |
| aelkner | which could just be a demo | 20:31 |
| th1a | Yes. | 20:32 |
| aelkner | would you like the students sheet to auto ad the persons to the the student group | 20:32 |
| th1a | Certainly. | 20:33 |
| th1a | Did you see the demographics import bug assigned to you yesterday? | 20:33 |
| aelkner | we don't do that yet anywhere, so this would be the first time we would need to consider the year | 20:33 |
| aelkner | one sec | 20:33 |
| th1a | What do we do in groups import? | 20:34 |
| th1a | Does that specify year or just guess? | 20:34 |
| aelkner | each group has a block that defines the title, description, id and year, so yes | 20:37 |
| aelkner | that's the only way we have imported people into groups thus far it seems | 20:38 |
| th1a | Realistically it could be set at the top of the form, or per row. | 20:38 |
| aelkner | the student needs to belong to a list of year, group pairs | 20:39 |
| aelkner | unless we assume the current year | 20:39 |
| aelkner | and just the student group could be assumed in the students sheet | 20:39 |
| aelkner | reimporting always has to be safe | 20:40 |
| aelkner | so what we do is only add things (and that shold include membership) | 20:40 |
| th1a | OK, for the student import sheet, defining the year at top probably makes the most sense. | 20:40 |
| aelkner | sure | 20:40 |
| aelkner | as for the bug, i'll have to talk with replaceafill because i wasn't able to reproduce | 20:41 |
| aelkner | perhaps it's a unicode thing with the ids or something | 20:41 |
| th1a | No... | 20:41 |
| th1a | Maybe the explanation is in the associated question. | 20:42 |
| th1a | Basically he's got demo fields limited by group, but the groups aren't assigned when the person import happens. | 20:42 |
| replaceafill | when section import happens | 20:43 |
| th1a | The student import sheet should be aware of limited fields, btw. | 20:43 |
| th1a | (when it exports/imports) | 20:43 |
| aelkner | ah, limit groups | 20:43 |
| aelkner | interesting | 20:43 |
| replaceafill | to me, the section importer should put people in their appropriate groups | 20:44 |
| replaceafill | so you'd be able to see limited demos, even if you didnt set the Groups sheet in the importer | 20:44 |
| th1a | I agree with replaceafill. | 20:46 |
| aelkner | problem is that the user object, with username key is created in the same sheet as the demo values | 20:47 |
| aelkner | the section importer relies on the person importer having completed | 20:47 |
| replaceafill | why is that a problem? | 20:48 |
| aelkner | you suggested the the section importer run first? | 20:48 |
| replaceafill | no | 20:48 |
| replaceafill | i suggest that it sets the Teachers or Students group on persons | 20:49 |
| replaceafill | the thing is that the person index view, takes into account limited demos, right? | 20:50 |
| replaceafill | so, if a student is not in the Students group, the person index view doesnt show the limited demo data | 20:50 |
| replaceafill | the data is there | 20:50 |
| replaceafill | it's imported | 20:50 |
| replaceafill | it's just not visible | 20:50 |
| aelkner | ah, so the import works, i see | 20:51 |
| aelkner | i'm still going over the code... | 20:51 |
| aelkner | interesting that we never worried about the limit fields until now | 20:52 |
| replaceafill | users! :) | 20:52 |
| replaceafill | and their use cases >:( | 20:52 |
| aelkner | there's nothing stopping the user from putting demos in the wrong gourps | 20:52 |
| aelkner | groups | 20:52 |
| aelkner | i'm thinking that demo value population should really be in a spearate sheet | 20:53 |
| aelkner | and that sheet must run after the groups are established | 20:53 |
| replaceafill | but supposed you dont set groups | 20:53 |
| replaceafill | suppose* | 20:53 |
| aelkner | yeah, it's an interesting question | 20:54 |
| replaceafill | my suggestion obviously fails for admins also | 20:54 |
| aelkner | i suppose, if we want to keep it flexible that we don't worry about demos in bad groups | 20:54 |
| replaceafill | you can have limited demos for admins | 20:54 |
| aelkner | i mean, in the ui, they can change the limits any time they wat | 20:54 |
| aelkner | want, and we don't remove the demo values at that time | 20:54 |
| aelkner | so we don't need to change allowing them to add demo values to the wrong groups i suppose | 20:55 |
| aelkner | so getting back to your section import suggestion | 20:55 |
| aelkner | i say, why not | 20:55 |
| aelkner | sections are already in years, so the year can be used to determine the group | 20:55 |
| replaceafill | yes | 20:56 |
| aelkner | and if a student happens to also be an instructor of one section they can belong to both groups | 20:56 |
| aelkner | btw, we don't have a place to define limit groups in the importer | 20:57 |
| aelkner | the only place demo fields are defined is in the Persons sheet | 20:57 |
| replaceafill | the importer doesnt create demo fields | 20:58 |
| aelkner | right | 20:58 |
| aelkner | it just assumes they are set up in exactly the same order as the sheet's columns | 20:58 |
| replaceafill | ah | 20:58 |
| replaceafill | one thing i noticed yesterday | 20:58 |
| replaceafill | but i didnt pay too much attention | 20:58 |
| replaceafill | see the part where the Required*** values are checked | 20:59 |
| replaceafill | dates have no a required equivalent, correct? | 20:59 |
| replaceafill | like bools and text | 20:59 |
| replaceafill | i didnt test it further | 20:59 |
| * th1a tries to catch up after spacing out... | 21:00 | |
| aelkner | um, see where? | 21:00 |
| aelkner | in the xls file? | 21:00 |
| aelkner | the png | 21:01 |
| th1a | aelkner: It seems to me that you could look at the same sheet twice in the importing. | 21:01 |
| replaceafill | aelkner, line 770 of the importer.py module | 21:01 |
| th1a | Get the basic person import, go do other imports, come back to demos. | 21:01 |
| aelkner | th1a, pass twice is always possible | 21:01 |
| th1a | You've got time allocated here to do some re-architecting. | 21:01 |
| th1a | I think you have two full weeks. | 21:02 |
| replaceafill | aelkner, i know it might not be a priority right now | 21:02 |
| replaceafill | but if you do some re-architecting | 21:02 |
| replaceafill | try to take out English words | 21:02 |
| replaceafill | :) | 21:02 |
| replaceafill | and change them to codes | 21:03 |
| replaceafill | in the xls file | 21:03 |
| replaceafill | again, not a priority | 21:03 |
| th1a | OH! | 21:03 |
| th1a | Yes... | 21:03 |
| th1a | it would be a good time to do that! | 21:03 |
| replaceafill | :) | 21:03 |
| aelkner | where are the english words you are referring to? | 21:03 |
| aelkner | one thing at a time anyway | 21:04 |
| aelkner | about line 770 | 21:04 |
| replaceafill | ah sure | 21:04 |
| replaceafill | see the if field.required check | 21:04 |
| aelkner | i see that i never coded a getRequiredDateFromCell | 21:04 |
| replaceafill | that's my point | 21:05 |
| aelkner | i don't remember why, perhaps i wanted to preserve the fail safe from the original coding | 21:05 |
| replaceafill | we should have one though | 21:05 |
| replaceafill | again, for required demos | 21:05 |
| aelkner | yes, that can we added | 21:06 |
| replaceafill | regarding the english words | 21:06 |
| replaceafill | see the Terms sheet in the sample data xls | 21:06 |
| replaceafill | Monday, Tuesday, ... | 21:06 |
| replaceafill | for marking weekends | 21:06 |
| aelkner | yes, what could go there instead? | 21:07 |
| replaceafill | some kind of coding | 21:07 |
| aelkner | it's a sample file, we don't know the language of the user | 21:07 |
| replaceafill | that's the point | 21:07 |
| th1a | This is pretty much always going to mean numeric codes, right? | 21:07 |
| aelkner | what kind of coding would you suggest | 21:07 |
| aelkner | 0 - 6 | 21:08 |
| aelkner | 1 - 7 | 21:08 |
| replaceafill | aelkner, something like that | 21:08 |
| th1a | We need to be able to produce spreadsheets in different languages with their own explanation of the keys. | 21:08 |
| replaceafill | day of the week or something | 21:08 |
| th1a | 1 -7 please. | 21:08 |
| aelkner | 1 - 7 it is | 21:08 |
| th1a | Or, tbh, you can include the English as long as the importer isn't dependent on it, right? | 21:09 |
| replaceafill | correct | 21:09 |
| th1a | You could put the text in a row above the number, as long as the importer wasn't dependent on the text. | 21:09 |
| replaceafill | the timetable importer does | 21:09 |
| th1a | Do you follow this, aelkner? | 21:09 |
| replaceafill | dows = ['Monday', 'Tuesday', 'Wednesday', 'Thursday', | 21:09 |
| replaceafill | 'Friday', 'Saturday', 'Sunday'] | 21:09 |
| th1a | This isn't magical -- the requirement is that a manually translated version of the sheet template should work. | 21:10 |
| aelkner | the importer doesn't look at that row | 21:10 |
| aelkner | it skips to the next one, assuming some row is filled in above it | 21:11 |
| aelkner | but it doesn't care what is in it | 21:11 |
| th1a | In that case this one might not be a problem. | 21:11 |
| replaceafill | aelkner, the timetable importer does | 21:11 |
| aelkner | well, we were talking about Terms | 21:11 |
| replaceafill | sorry, i used Terms as an example | 21:12 |
| replaceafill | of english words being used | 21:12 |
| replaceafill | in the xls | 21:12 |
| aelkner | again, those words that don't end up as data are ignored anyway | 21:13 |
| th1a | So basically what aelkner should be on the lookout for is not so much English in the spreadsheets, but english in the import code. | 21:13 |
| th1a | ? | 21:13 |
| replaceafill | th1a, +1 | 21:13 |
| replaceafill | this can help: https://bugs.launchpad.net/schooltool/+bug/901267 | 21:13 |
| th1a | They might not be used for data but for finding the data. | 21:13 |
| th1a | It's all yours now, aelkner. ;-) | 21:16 |
| aelkner | well, i'll come back to that one at some point | 21:18 |
| aelkner | i've got about ten things on my stack now | 21:18 |
| replaceafill | :D | 21:19 |
| th1a | No... | 21:19 |
| aelkner | but th1a, is it safe to assume that i'll be doing mostly import stuff for the next couple of weeks | 21:19 |
| th1a | Yes, but you're going to be going through this page by page, so just fix it as you go. | 21:19 |
| th1a | Rather than as a separate step at the end. | 21:20 |
| aelkner | i can't fix it as i'm discussing it | 21:20 |
| aelkner | so we have to decide what i'll look into first | 21:20 |
| aelkner | and that's after i finish the app stests | 21:20 |
| aelkner | i got them to work btw, replaceafill, after yvl helped with a stupid typo i had | 21:21 |
| replaceafill | :D | 21:21 |
| aelkner | so we now have oldskin and newskin stests in app | 21:21 |
| aelkner | i just need to add the server tabs tests and then i can push the whole thing | 21:22 |
| aelkner | th1a, you also asked me to look into period order in the student detail report | 21:22 |
| aelkner | oh, and the breadcrumbs on replaceafill's server for server tabs, replaceafill do you need the latest code? | 21:23 |
| replaceafill | uh? | 21:23 |
| aelkner | you could merge with my branch i suppose | 21:23 |
| replaceafill | breadcrumbs on my server? | 21:23 |
| aelkner | th1a sent me a note about it | 21:24 |
| replaceafill | ah probably he noticed something missing in one of my instances? | 21:24 |
| replaceafill | 6660 runs trunk | 21:25 |
| aelkner | and he asked me to get the latest code to you | 21:25 |
| aelkner | but i haven't pushed to trunk | 21:25 |
| aelkner | so it's up to him if he wants you to merge with my branch, i don't know | 21:25 |
| aelkner | replaceafill, i'll send you a note when i've merged to trunk | 21:27 |
| th1a | I don't really care if replaceafill has it. | 21:27 |
| th1a | I just wanted to know if it was a bug. | 21:28 |
| th1a | I figured it wasn't which is why I didn't file it first. | 21:28 |
| aelkner | just check out my instance | 21:28 |
| th1a | Just tell me it isn't a bug. | 21:28 |
| replaceafill | btw, the journal using the new gradebook stuff: http://69.164.203.135:6662/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000/journal | 21:29 |
| aelkner | what do you mean by no breadcrumbs, btw | 21:29 |
| th1a | But yes, make sure both reports have period order right. | 21:29 |
| replaceafill | teacher004 | 21:29 |
| aelkner | http://69.164.203.135:36660/hide_unhide_tabs.html | 21:29 |
| th1a | I think it just had Tab not Server > Tab | 21:29 |
| aelkner | ah, yes, that's true | 21:29 |
| th1a | Yeah, that's the problem. | 21:29 |
| aelkner | i'll look into that | 21:29 |
| replaceafill | th1a, have some minutes for some questions about the journal? | 21:30 |
| replaceafill | i can wait until monday :) | 21:30 |
| * th1a is sitting in his chair, spinning around looking at the ceiling... | 21:32 | |
| replaceafill | :)) | 21:32 |
| th1a | So I guess the answer is yes. ;-) | 21:32 |
| th1a | It is a pretty perfect Friday afternoon here... | 21:33 |
| replaceafill | ok, basically i was just wondering about the popup menus in the journal | 21:33 |
| replaceafill | they don't do much right now | 21:33 |
| replaceafill | and some of them dont even work :( | 21:34 |
| replaceafill | like order by student's name | 21:34 |
| replaceafill | sort by* | 21:34 |
| replaceafill | we have fill down now for the journal | 21:34 |
| th1a | They should work. | 21:35 |
| th1a | Right? | 21:35 |
| replaceafill | well, they dont work in the "trunk" version i think | 21:35 |
| replaceafill | neither in mine | 21:35 |
| replaceafill | i'll fix them | 21:35 |
| th1a | I mean, there is no reason to not make them work. | 21:35 |
| replaceafill | right | 21:35 |
| th1a | Like, they don't make sense anyhow. | 21:36 |
| replaceafill | but for instance | 21:36 |
| replaceafill | the student name link | 21:36 |
| replaceafill | why is it a link? | 21:36 |
| replaceafill | it doesnt bring up any popup | 21:36 |
| replaceafill | that's the reason we have the student name as a link in the gradebook | 21:36 |
| th1a | Well, there probably should be a report. | 21:36 |
| replaceafill | for Report|Score options | 21:36 |
| replaceafill | ah | 21:37 |
| th1a | Ooh... that would be a good one for me. | 21:37 |
| th1a | Nice SVG report... | 21:37 |
| replaceafill | :D | 21:37 |
| replaceafill | ok, i'll add an empty Report option | 21:37 |
| th1a | http://mbostock.github.com/d3/ex/calendar.html | 21:37 |
| replaceafill | wow | 21:38 |
| th1a | :-D | 21:38 |
| replaceafill | that would be cool | 21:38 |
| replaceafill | all the absences and tardies marked :D | 21:38 |
| replaceafill | i think that was my only question actually, the student link | 21:39 |
| replaceafill | ah cool | 21:40 |
| replaceafill | Carlos confirmed what we thought :) | 21:40 |
| replaceafill | about Groups | 21:40 |
| th1a | Yes, good job replaceafill. | 21:40 |
| * replaceafill goes to get lunch | 21:43 | |
| aelkner | th1a, regarding the section importer adding to groups | 21:47 |
| aelkner | is that a general change we want to do now? | 21:47 |
| aelkner | or more a custome thing | 21:47 |
| aelkner | i mean, if we decide to do it, then it will always happen | 21:48 |
| aelkner | unless we give them a way to block it or something | 21:48 |
| th1a | General change. | 21:48 |
| aelkner | ok | 21:49 |
| *** ignas has quit IRC | 22:29 | |
| *** replaceafill has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!