*** paulproteus has quit IRC | 03:07 | |
*** paulproteus has joined #schooltool | 03:13 | |
*** alga has quit IRC | 05:02 | |
*** aks has joined #schooltool | 05:08 | |
*** aks has quit IRC | 05:12 | |
*** aks has joined #schooltool | 05:12 | |
*** yvl has joined #schooltool | 09:21 | |
*** alga has joined #schooltool | 12:30 | |
*** alga has quit IRC | 14:01 | |
*** aks has quit IRC | 14:03 | |
*** ignas has joined #schooltool | 14:09 | |
*** th1a has joined #schooltool | 14:34 | |
*** ignas has quit IRC | 14:53 | |
th1a | yvl: It is still an hour until meeting time, right? | 15:25 |
---|---|---|
th1a | Are you guys on DST yet? | 15:25 |
*** alga has joined #schooltool | 15:49 | |
*** alga has quit IRC | 15:49 | |
*** alga has joined #schooltool | 15:49 | |
*** alga has quit IRC | 15:54 | |
*** alga has joined #schooltool | 15:54 | |
aelkner | hey th1a | 16:06 |
th1a | hi aelkner. | 16:06 |
yvl | hey th1a | 16:06 |
yvl | it's 16:06 here | 16:07 |
th1a | Yes, I thought so. | 16:07 |
aelkner | i expected us to met at 9:30, but i guess it's still earlier in el salvador | 16:07 |
yvl | (Unity is so unobtrusive that you don't notice personal messages even if you'd like to ;) ) | 16:07 |
aelkner | can we look at my section locations/equipment changes in my demo instance? | 16:09 |
aelkner | in other words, can we start the meeting with me while we wait for douglas? | 16:10 |
th1a | Give me a minute. | 16:10 |
th1a | OK. | 16:15 |
th1a | Go ahead aelkner. | 16:15 |
aelkner | as manager: | 16:16 |
aelkner | http://69.164.203.135:36660/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000 | 16:16 |
aelkner | i got the section locations and equipment views to work, but one thing | 16:16 |
aelkner | yvl, we don't have a way of overriding the table formatter that i can see | 16:17 |
aelkner | or the filter i mean | 16:17 |
aelkner | so the filter forms are appearing where i figure we wouldn't want them | 16:17 |
th1a | We don't need the search/filter views in the main page. | 16:17 |
aelkner | like in the seciton view itself | 16:17 |
th1a | We don't have them for anything else there. | 16:17 |
aelkner | my point exactly | 16:19 |
aelkner | yvl, ping | 16:19 |
th1a | So take them out. | 16:19 |
yvl | oh | 16:19 |
yvl | pong, aelkner | 16:19 |
th1a | I don't think there is any argument for them being there. | 16:19 |
aelkner | that's good since noone is arguing for it | 16:20 |
th1a | You're the one that put them there at all. ;-) | 16:20 |
aelkner | nope | 16:20 |
yvl | they're enabled by default | 16:20 |
yvl | they can be disabled | 16:20 |
aelkner | how? | 16:20 |
yvl | see group/browser/flourish.zcml | 16:21 |
yvl | search for DoNotFilter | 16:21 |
yvl | or see basicperson/browser/flourish.zcml | 16:22 |
aelkner | ah, interesting, i thought there should be some kind of viewlet for that | 16:22 |
*** menesis has joined #schooltool | 16:23 | |
th1a | OK, I see aelkner. | 16:23 |
yvl | aelkner, you can also inherit from table/table.py : DoNotFilter | 16:24 |
yvl | and modify filter do return only locations | 16:24 |
yvl | name it LocationsOnlyFilter or something | 16:24 |
aelkner | trying your first suggestion... | 16:24 |
yvl | that is not visible, but silently filters out everything that is not a location | 16:24 |
yvl | same for equipment | 16:25 |
yvl | If you want multiple tables that differ slightly, looking at group/browser/group.py | 16:27 |
yvl | GroupLeadersTable and GroupMembersTable may help | 16:27 |
*** alga has quit IRC | 16:28 | |
*** alga has joined #schooltool | 16:28 | |
*** replaceafill has joined #schooltool | 16:29 | |
aelkner | th1a, i got rid of the filter widgets: | 16:29 |
aelkner | http://69.164.203.135:36660/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000 | 16:29 |
th1a | OK. Cool. | 16:30 |
th1a | Looks fine to me. | 16:31 |
aelkner | so should i close the book on the bug and merge with trunk and all that? | 16:32 |
th1a | Did you write any tests? | 16:33 |
th1a | hi replaceafill. | 16:34 |
replaceafill | hey th1a | 16:34 |
aelkner | th1a, no, i really should i guess | 16:34 |
th1a | Yes, we do that now. ;-) | 16:34 |
aelkner | ok, will do | 16:34 |
th1a | It is the latest thing. | 16:34 |
yvl | btw, I can see you implemented filtering logic in the table itself somehow | 16:34 |
replaceafill | th1a reading the logs, are you now 1 more hour ahead? | 16:34 |
yvl | could you please move that to filters? | 16:34 |
yvl | (well, I can't see the code, but I'm guessing) | 16:35 |
aelkner | check out my personal branch for the last two diffs | 16:35 |
yvl | ok | 16:35 |
th1a | We're ahead. You're on time. | 16:36 |
aelkner | https://code.launchpad.net/~aelkner/schooltool/flourish | 16:36 |
replaceafill | th1a, ah ok | 16:36 |
aelkner | yvl, i didn't do anything with filters, i just got the views to work the way i needed them to | 16:36 |
yvl | ok aelkner | 16:37 |
aelkner | th1a, that's my report | 16:39 |
aelkner | i can work on a critical bug after i'm done with the section locations tests | 16:40 |
th1a | OK. | 16:40 |
th1a | Do you have any? | 16:40 |
aelkner | https://bugs.launchpad.net/~aelkner/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=&field. | 16:41 |
aelkner | tags_combinator=ANY&field.status_upstream-empty-marker=1&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on | 16:41 |
aelkner | sorry for the flooding | 16:41 |
aelkner | that url is long | 16:41 |
*** ignas has joined #schooltool | 16:42 | |
yvl | http://tinyurl.com/ ? | 16:42 |
th1a | I guess you have a few. So yeah, go ahead and work on those. | 16:42 |
th1a | https://bugs.launchpad.net/schooltool-project works too. ;-) | 16:43 |
yvl | :D | 16:43 |
th1a | Seriously though, I worry that you guys use such restrictive searches that if I forget one field the bug is completely missed. | 16:45 |
th1a | OK, thanks aelkner. | 16:45 |
th1a | yvl? | 16:45 |
yvl | I made the basic interfaces and the objects | 16:46 |
yvl | started kind of slow, had to remember some stuff | 16:46 |
yvl | picking up speed now | 16:47 |
yvl | working on some basic API atm | 16:48 |
th1a | Yes, it took me a while to dredge things up... we went over everything so many times I just felt like we couldn't forget it if we tried! | 16:48 |
yvl | on the downside, I'm in "it's done when it's done" mode | 16:49 |
yvl | if I knew all the little things that need to be done, it would be done already ;) | 16:49 |
yvl | but it's looking good | 16:49 |
yvl | I'll probably start looking at scoring on Wed | 16:50 |
yvl | see how that fits in | 16:50 |
yvl | looking at the planner... | 16:51 |
th1a | You're scheduled for 7 days on the document model, ending Wednesday. | 16:51 |
th1a | (8 days, actually) | 16:51 |
th1a | Then seven days on the evaluation model. | 16:51 |
yvl | yes | 16:51 |
th1a | So that seems reasonably accurate. | 16:52 |
yvl | right | 16:52 |
* yvl will shuffle the order a bit though | 16:52 | |
th1a | As long as the whole thing doesn't horribly slide I won't complain. | 16:52 |
yvl | right | 16:52 |
th1a | If this gets way off, there will be a serious cascade of fail. | 16:52 |
yvl | well, I'll aim for doing that before the deadline, say 3 work days | 16:53 |
yvl | it should get done roughly on time then ;) | 16:53 |
yvl | as it usually is with things like this | 16:54 |
yvl | it's not writing the actual implementation that's hard :) | 16:54 |
* yvl is rambling | 16:54 | |
yvl | done here. | 16:54 |
th1a | Sure. | 16:54 |
th1a | So... I guess you feel pretty confident you're remembering what we talked about accurately... | 16:55 |
yvl | yes | 16:55 |
yvl | at least I don't expect any major screw-ups | 16:55 |
th1a | OK. I'll trust you. | 16:55 |
yvl | thanks th1a | 16:55 |
th1a | And save the time in making you re-explain it to me remotely. | 16:56 |
yvl | I really appreciate it! | 16:56 |
th1a | Thanks yvl. | 16:56 |
th1a | menesis? | 16:56 |
menesis | I haven't done a release yet | 16:57 |
menesis | but I have done some steps towards that | 16:57 |
menesis | still see you all working on further fixes | 16:58 |
th1a | Don't wait for those at this point. | 16:58 |
menesis | ok | 16:58 |
menesis | I have work on other project | 16:59 |
menesis | so my time is divided | 16:59 |
menesis | but will do a schooltool release soon | 16:59 |
th1a | Yes, don't let it slide too long now. | 17:00 |
menesis | ok | 17:00 |
th1a | We don't want a last minute train wreck. | 17:00 |
th1a | Also, if you've already silently decided that we're screwed, please let me know. ;-) | 17:01 |
*** alga_ has joined #schooltool | 17:01 | |
menesis | no, all is ok | 17:01 |
menesis | :) | 17:01 |
* th1a has learned a little about menesis's internal monologue. | 17:01 | |
th1a | OK, thanks menesis. | 17:02 |
th1a | replaceafill? | 17:03 |
replaceafill | ok | 17:03 |
replaceafill | i've been cleaning the gradebook overview template | 17:03 |
replaceafill | i've removed some unnecessary elements <divs> <spans> that made it bigger than it needs to be | 17:04 |
replaceafill | i also worked on some related styling issues | 17:04 |
replaceafill | like the popup menus bug in chrome | 17:05 |
replaceafill | keeping the last (right) menu in the frame | 17:05 |
replaceafill | and finally, i got the gradebook to look (almost 100%) the same in chrome and firefox | 17:05 |
replaceafill | that was bothering me | 17:05 |
replaceafill | i also fixed a keyboard navigation issue with linked activities | 17:06 |
replaceafill | there are finally two things i want to get rid of in the template | 17:07 |
replaceafill | yvl, what's your opinion on this: | 17:07 |
replaceafill | remember the old skin section journal? | 17:07 |
replaceafill | it used a regular html table | 17:07 |
replaceafill | and allowed you to type the value and refreshed the view | 17:08 |
replaceafill | it even saved the values using ajax calls | 17:08 |
replaceafill | well i was thinking of getting rid of the <input type="text" /> in the gradebook | 17:08 |
replaceafill | use regular <td>85</td> cells | 17:08 |
replaceafill | and add the input until the user clicks on the cell | 17:09 |
replaceafill | if it's editable | 17:09 |
replaceafill | that would make the template even smaller | 17:09 |
yvl | +1 so far | 17:09 |
replaceafill | another thing i'd like to do is to move all those "Activity33_student234" ids | 17:09 |
replaceafill | to use row + column ids | 17:09 |
replaceafill | like the old journal did | 17:09 |
replaceafill | it attached the student id to the row | 17:10 |
replaceafill | and the activity id to the column | 17:10 |
replaceafill | and it generated the id/name of the cell from them | 17:10 |
replaceafill | again it would make the template smaller | 17:10 |
replaceafill | (maybe i'm trying to get rid of too much...?) | 17:10 |
yvl | +1 so far :) | 17:11 |
replaceafill | ah cool :) | 17:11 |
replaceafill | ah yvl | 17:11 |
replaceafill | also | 17:11 |
replaceafill | if i start writing the cando prototype | 17:11 |
replaceafill | i should use the branch you set for the sprint, correct? | 17:12 |
replaceafill | https://code.launchpad.net/~justas-pov/schooltool/cando | 17:12 |
yvl | that would be nice | 17:12 |
yvl | I'll push something there soon | 17:12 |
replaceafill | ah ok | 17:12 |
yvl | like a schooltool.cando.browser ;) | 17:12 |
replaceafill | i'll use that then | 17:12 |
replaceafill | yes | 17:12 |
replaceafill | th1a, my work is available in the vps | 17:13 |
replaceafill | http://69.164.203.135:6662/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000/activities/Worksheet/gradebook | 17:13 |
replaceafill | but dont look at it :) | 17:13 |
replaceafill | it's still broken | 17:13 |
th1a | ok. | 17:13 |
th1a | Did you look at the profiling etc. in Chrome dev tools? | 17:13 |
replaceafill | ah yes | 17:14 |
replaceafill | btw | 17:14 |
replaceafill | firefox is starting to dissapoint me :( | 17:14 |
replaceafill | since i've done a lot of firebug stuff latetly | 17:14 |
*** alga has quit IRC | 17:14 | |
replaceafill | i noticed it was getting really slow over time | 17:14 |
replaceafill | i had to restart it like 3 times | 17:14 |
replaceafill | so i moved to chrome :) | 17:14 |
aelkner | me, too | 17:15 |
replaceafill | but i still dont understand the environment very well | 17:15 |
aelkner | i don't even firebug anymore | 17:15 |
aelkner | chrome is more reliable and has all the same features | 17:15 |
replaceafill | i think i just have to get used to it | 17:15 |
aelkner | actually chrome's firebug is even cleaner looking | 17:15 |
replaceafill | anyway, the html produced is smaller | 17:15 |
replaceafill | but it can be even smaller | 17:15 |
replaceafill | i'll work on that today | 17:16 |
th1a | I'll be interested to know the before/after when you're done. | 17:16 |
replaceafill | and put the features i broke back | 17:16 |
replaceafill | th1a, sure, i'll prepare a demo with the old/new versions | 17:16 |
replaceafill | ah | 17:16 |
replaceafill | i also found some inconsistencies in the gradebook | 17:17 |
replaceafill | like missing breadcrumbs | 17:17 |
replaceafill | but the more important ones: | 17:17 |
replaceafill | Activity category should not be required for creating activities/course activities. If we keep it required we should make sure that the user has at least one category set. If we keep it required we should add a prompt to it. | 17:17 |
replaceafill | (from my notes) | 17:17 |
replaceafill | Why is due date required? | 17:17 |
th1a | Is it? | 17:17 |
th1a | It shouldn't be. | 17:17 |
replaceafill | For course worksheets hide_unhide_worksheets.html still uses a Hidden? column. Should we make it Visible. In the same view the word "Deployed" is still used. | 17:17 |
replaceafill | yes | 17:17 |
th1a | It definitely shouldn't be. | 17:18 |
aelkner | i thought i changed that | 17:18 |
th1a | You guys are out of sync. | 17:18 |
replaceafill | it would be good if course worksheets had better breadcrumbs too | 17:18 |
replaceafill | am i? | 17:19 |
th1a | I guess activity categories probably shouldn't be required. | 17:19 |
replaceafill | http://69.164.203.135:6661/schoolyears/2011-2012/2012-spring/sections/art_a_2012-spring_teacher004_000/activities/Advanced%20Topics/addActivity.html | 17:19 |
replaceafill | teacher004 | 17:19 |
replaceafill | Due Date is required | 17:19 |
replaceafill | and that's trunk | 17:19 |
replaceafill | aelkner, maybe you didnt push it? | 17:20 |
replaceafill | i mean, to trunk | 17:20 |
th1a | I think he was referring to the Hidden thing. | 17:20 |
replaceafill | ah | 17:20 |
replaceafill | ok, so | 17:21 |
aelkner | replaceafill, no, i only changed the Worksheets view | 17:21 |
aelkner | i thought i addresses both views | 17:21 |
aelkner | what happened was, i addressed the Server->tabs view | 17:21 |
aelkner | to use Visible rather than Hidden? | 17:21 |
aelkner | but i didn't do the same for course worksheets | 17:21 |
aelkner | do you want to do it? | 17:21 |
replaceafill | nope | 17:21 |
replaceafill | i'm on the gradebook now | 17:22 |
aelkner | that is the gradebook | 17:22 |
replaceafill | overview view :) | 17:22 |
aelkner | thats why i asked, since you were woring in that area | 17:22 |
aelkner | i can do it though | 17:22 |
replaceafill | go ahead | 17:22 |
aelkner | ok | 17:22 |
th1a | Yes, you can do it aelkner. | 17:22 |
replaceafill | th1a, i'll start with the cando prototype probably on wed | 17:22 |
replaceafill | i mean, the gradebook prototype | 17:23 |
th1a | OK. | 17:23 |
replaceafill | i have to sync the journal with my changes | 17:23 |
replaceafill | i guess i'm done | 17:23 |
th1a | Thanks replaceafill. | 17:23 |
th1a | Any opinions about the cando report sketch I sent out Friday? | 17:24 |
replaceafill | mine was just the black little bar | 17:25 |
*** alga has joined #schooltool | 17:25 | |
replaceafill | you could try the dark gray | 17:25 |
replaceafill | and "simulating" the scales through the table rows | 17:25 |
th1a | hm? | 17:26 |
replaceafill | in your mock the vertical scale line cross the table rows | 17:26 |
th1a | Yes. | 17:27 |
replaceafill | i just wonder how are you going to do that, but never mind, i'll wait for the real example :) | 17:27 |
th1a | Oh, I think I see what you mean. | 17:28 |
th1a | So I'm probably going to work on that a bit more but mostly leave it for once we have the real data now. | 17:29 |
th1a | I am going to look at an SVG hexagon background like the new business cards. | 17:29 |
replaceafill | yvl, can you help me with some jquery? | 17:29 |
th1a | Kind of like this (but with a fixed aspect ratio: http://www.alistapart.com/d/using-svg-for-flexible-scalable-and-fun-backgrounds-part-ii/example5.xhtml | 17:30 |
yvl | replaceafill, I can try :) | 17:30 |
replaceafill | yvl, it's about live/delegate/on :) | 17:30 |
replaceafill | if i create $('input[class=foo]').click(...) | 17:31 |
replaceafill | but i inserth the foos dynamically | 17:31 |
replaceafill | they dont get the handler registered, correct? | 17:31 |
replaceafill | (or whatever the right terminology is) :) | 17:31 |
yvl | the answer is probably no | 17:31 |
replaceafill | so you have to use live | 17:31 |
yvl | what do you mean by "insert the foos dynamically" | 17:31 |
yvl | oh | 17:32 |
yvl | the inputs | 17:32 |
replaceafill | like having a event that creates $('<input type="text" class="foo />') | 17:32 |
yvl | then no | 17:32 |
replaceafill | yes | 17:32 |
replaceafill | ok | 17:32 |
replaceafill | so you have to use live | 17:32 |
replaceafill | or delegate | 17:32 |
replaceafill | since they attach for curren use and the future :) | 17:32 |
replaceafill | current* | 17:32 |
replaceafill | but i've been reading that in version 1.7, they're kind of obsolete | 17:33 |
replaceafill | because of on() | 17:33 |
replaceafill | have you use it? | 17:33 |
replaceafill | any advice? | 17:34 |
yvl | one sec | 17:34 |
replaceafill | sure | 17:34 |
th1a | I will take this pause to... | 17:35 |
* th1a drops the bag of gravel. | 17:35 | |
th1a | See you Wednesday, gentlemen. Thanks! | 17:35 |
yvl | :) | 17:35 |
yvl | thanks guys | 17:36 |
yvl | replaceafill, /me back | 17:36 |
yvl | I haven't used it | 17:36 |
replaceafill | thanks everybody | 17:36 |
aelkner | cya guys wed | 17:36 |
yvl | but if you do, please use on | 17:36 |
replaceafill | yvl, ah ok | 17:36 |
yvl | or you can attach them manually | 17:36 |
yvl | foo = $('<input type="text" class="foo />') | 17:36 |
yvl | foo.click(...) | 17:36 |
replaceafill | ah! | 17:36 |
replaceafill | didnt think of that :) | 17:37 |
replaceafill | i'll try on(...) and if it's too much trouble i'll do it that way | 17:37 |
replaceafill | thanks | 17:37 |
replaceafill | i had another question... | 17:37 |
replaceafill | ... that i can't remember now :( | 17:37 |
yvl | (but probably you want to use .on) | 17:37 |
replaceafill | ah | 17:37 |
replaceafill | yes | 17:37 |
replaceafill | what's the name of the pattern you used for flourish.js/table.js? | 17:37 |
replaceafill | the private/public approach? | 17:38 |
replaceafill | i wanted to read about it | 17:38 |
replaceafill | i want to use it | 17:38 |
replaceafill | i wrote a lot of shitty code to make the features work, now i want to clean it up | 17:38 |
replaceafill | i mean js code | 17:39 |
replaceafill | and i thought the gradebook could use a public api like that | 17:39 |
replaceafill | but i'm not good at designing api's :( | 17:39 |
yvl | http://yuiblog.com/blog/2007/06/12/module-pattern/ ... | 17:41 |
*** alga_ has quit IRC | 17:41 | |
replaceafill | excellent! | 17:41 |
replaceafill | thanks yvl | 17:41 |
yvl | it's not that I like it *that* much | 17:41 |
yvl | but I somewhat like it ;) | 17:41 |
replaceafill | :) | 17:41 |
*** yvl has quit IRC | 18:05 | |
replaceafill | th1a, so meetings start at 9:30 your time now, correct? | 18:06 |
replaceafill | 7:30 am for me | 18:06 |
th1a | Oh, we forgot to discuss that. ;-) | 18:07 |
th1a | You never have DST, right, so you always have to switch to 7:30 in the summer, right? | 18:07 |
replaceafill | yes | 18:07 |
th1a | I guess it is time to do that then. | 18:08 |
replaceafill | kk | 18:08 |
*** olegb has joined #schooltool | 18:47 | |
*** paulproteus has quit IRC | 19:15 | |
*** paulproteus has joined #schooltool | 19:15 | |
replaceafill | yvl, interesting post http://lookfirst.com/2011/12/dont-use-jquery-data-method-use-attr.html | 19:36 |
*** ignas has quit IRC | 20:00 | |
*** menesis has quit IRC | 20:23 | |
*** th1a has quit IRC | 20:57 | |
*** menesis has joined #schooltool | 21:21 | |
*** th1a has joined #schooltool | 21:40 | |
*** ignas has joined #schooltool | 22:42 | |
replaceafill | th1a, zyt? | 22:59 |
*** ignas has quit IRC | 23:23 | |
*** th1a has quit IRC | 23:32 | |
*** ignas has joined #schooltool | 23:44 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!