| *** alga has quit IRC | 02:24 | |
| *** replaceafill has quit IRC | 02:44 | |
| *** replaceafill has joined #schooltool | 02:57 | |
| *** replaceafill has joined #schooltool | 02:57 | |
| *** menesis has quit IRC | 04:05 | |
| *** replaceafill has quit IRC | 04:36 | |
| *** yvl has joined #schooltool | 09:33 | |
| *** menesis has joined #schooltool | 11:42 | |
| *** ignas has joined #schooltool | 14:19 | |
| *** menesis has quit IRC | 14:38 | |
| *** menesis has joined #schooltool | 15:19 | |
| *** replaceafill has joined #schooltool | 16:10 | |
| *** menesis has quit IRC | 16:11 | |
| *** menesis has joined #schooltool | 16:16 | |
| *** th1a has joined #schooltool | 16:21 | |
| th1a | hi replaceafill, aelkner, menesis, yvl. | 16:31 |
|---|---|---|
| replaceafill | good morning/afternoon | 16:31 |
| aelkner | morning | 16:32 |
| menesis | hi | 16:32 |
| menesis | yvl will be late 20 mins | 16:32 |
| th1a | Thanks menesis. | 16:33 |
| th1a | Would you like to start, replaceafill? | 16:34 |
| replaceafill | ok | 16:35 |
| th1a | How's your electricity/connectivity? | 16:35 |
| replaceafill | i've been working on ajaxing the gradebook | 16:35 |
| replaceafill | using yvl's table model from the /persons and relationships views | 16:35 |
| replaceafill | th1a, electricity ok, connectivity sucks | 16:35 |
| replaceafill | i'm seriously thinking about switching ISP | 16:36 |
| replaceafill | i cannot do sh** in the vps using ssh during the afternoons | 16:37 |
| replaceafill | anyway | 16:37 |
| replaceafill | i've copied most of the functionality to create the main content part in the gradebook | 16:37 |
| replaceafill | tertiary nav + grades part + submit button | 16:37 |
| replaceafill | using the new viewlets approach | 16:37 |
| replaceafill | ajaxparts | 16:37 |
| th1a | So the grid is being created in the browser? | 16:38 |
| replaceafill | yes | 16:38 |
| replaceafill | but then i started to realize that the selectors should also use the same logic | 16:38 |
| replaceafill | for year, term, and section | 16:38 |
| replaceafill | so when you change one of them only the grid is reloaded | 16:39 |
| replaceafill | now, i'm working on the activity menu links | 16:39 |
| replaceafill | some of them also reload the grid | 16:39 |
| replaceafill | like Sort by | 16:39 |
| replaceafill | Move left and right | 16:39 |
| replaceafill | and probably the Show/Hide total columns | 16:40 |
| replaceafill | i think i got it, it's just a matter of finishing it | 16:40 |
| th1a | Does it seem faster? I guess we should be benchmarking this... | 16:40 |
| replaceafill | well, yes, since i don't have the full page reload, it *seems* faster | 16:41 |
| replaceafill | i hope to have it working tomorrow or on friday to show you | 16:41 |
| th1a | Have you tried profiling in Chrome or Firefox? | 16:41 |
| replaceafill | not really | 16:41 |
| replaceafill | i just have yslow in my firefox but i dont know if thats the right tool or how to use it :) | 16:42 |
| th1a | You could try it in Chrome. | 16:42 |
| replaceafill | ah ok | 16:42 |
| replaceafill | i should use Chrome more :) | 16:43 |
| replaceafill | anyway, another thing i wanted to mention | 16:43 |
| replaceafill | is the selenium test runner | 16:43 |
| replaceafill | i tried it on monday | 16:43 |
| replaceafill | and now it works with the datepicker, thanks to some helpers yvl set | 16:44 |
| replaceafill | so our tests that create years and terms finally work | 16:44 |
| replaceafill | i think we should go back to our old way of working when | 16:44 |
| replaceafill | we always created a test for new functionality | 16:44 |
| replaceafill | and i'd like to write tests for this ajax stuff | 16:45 |
| replaceafill | i think that's why we picked selenium right? | 16:45 |
| th1a | Yes. | 16:45 |
| th1a | Write tests. | 16:45 |
| replaceafill | great, will do then | 16:46 |
| th1a | I feel like we're starting to suffer from a lack of tests. | 16:46 |
| replaceafill | and i have a question for yvl, but i'll wait for him :) | 16:46 |
| replaceafill | well we wrote the whole flourish part without functional tests | 16:46 |
| replaceafill | (i think) | 16:46 |
| th1a | Yes. | 16:47 |
| replaceafill | and we wrote a lot of new stuff back then | 16:47 |
| replaceafill | th1a, so i should be done with this task this week | 16:47 |
| replaceafill | and start the cando gradebook next week | 16:47 |
| replaceafill | (that's my question for yvl) | 16:47 |
| th1a | OK. | 16:47 |
| th1a | Sounds good. | 16:47 |
| replaceafill | that's it from me | 16:48 |
| th1a | Thanks replaceafill. | 16:48 |
| th1a | aelkner? | 16:48 |
| aelkner | i finished the intervention email task | 16:48 |
| th1a | Let's take a last look at it... | 16:49 |
| aelkner | that included various cleanup tasks we discussed on monday | 16:49 |
| aelkner | http://69.164.203.135:36660/schooltool.interventions/2011-2012/student109 | 16:49 |
| aelkner | as teacher001 | 16:49 |
| aelkner | i had to add the same notification modal to section interventions as well | 16:50 |
| aelkner | also, i made the modal use the modal: True flag to make the background fade out | 16:51 |
| aelkner | figuring that it was important for the user to see the notification | 16:51 |
| aelkner | the gradebook modal doesn't have this faded background, but perhaps that's ok | 16:51 |
| th1a | It is fine, because you might want to see that while you're using the gradebook dialog. | 16:52 |
| aelkner | right | 16:52 |
| th1a | I don't get this message: "The server (smtp.gmail.com:587) rejected the following recipient addresses: invalid" | 16:52 |
| aelkner | and yvl said that the journal has a legend that works the same way, too | 16:52 |
| th1a | is that supposed to be telling me which ones are invalid? | 16:53 |
| aelkner | yes | 16:53 |
| th1a | So... which? | 16:53 |
| aelkner | invalid is the address that i set the contact to have | 16:53 |
| aelkner | it is not a valid email address | 16:53 |
| th1a | The invalid email address is "invalid" | 16:53 |
| th1a | ? | 16:53 |
| aelkner | yes | 16:53 |
| th1a | OK. | 16:53 |
| th1a | I guess I should file a bug about accepting invalid email addresses in the first place. | 16:54 |
| replaceafill | we need an email field with a regexp validator | 16:54 |
| aelkner | well, how would the person edit views check for email address validity other than format? | 16:55 |
| aelkner | i mean, the address could have the @ and the .com stuff, but still be invalid | 16:55 |
| th1a | In what sense? | 16:55 |
| aelkner | a non-existent account | 16:55 |
| yvl | hi guys | 16:56 |
| yvl | sorry I'm late today | 16:56 |
| aelkner | but true, the @ and . checks could be made | 16:56 |
| replaceafill | hey yvl | 16:56 |
| th1a | You've managed to completely confuse this issue through your choice of example aelkner. | 16:57 |
| th1a | So this is not telling me the email is "invalid," but that it doesn't exist. | 16:58 |
| aelkner | i disagree, i didn't confuse anything, the email utility works like it works | 16:59 |
| aelkner | if you didn't like the way it worked in the past, why didn't you say anything then | 16:59 |
| th1a | I'm just saying using "invalid" as your example text completely threw me off the trail. | 16:59 |
| th1a | It is like if you used "Syntax Error" or "Core Dump" as the invalid email address. | 16:59 |
| aelkner | well, heck, it's just an example | 17:00 |
| aelkner | you can play around with it all you want | 17:00 |
| th1a | OK, so getting back to the point. | 17:00 |
| th1a | Does this dialog only come up if there is an error? | 17:01 |
| th1a | That is, can the title be more specific than "notification." | 17:01 |
| th1a | ? | 17:01 |
| aelkner | what would you suggest? | 17:02 |
| th1a | OK, I see it does. | 17:02 |
| aelkner | why don't you play around with it and file any bugs if you find them | 17:02 |
| th1a | You know, it is fine. can you just make it "The email could not be delivered to all recipients." and we'll just move on. | 17:03 |
| aelkner | oops, you did say recipients on monday, i now remember, after yvl suggested people | 17:04 |
| aelkner | i could change that now | 17:04 |
| aelkner | anyway, i submitted a comment for the demo import bug, did you see? | 17:05 |
| th1a | Yeah. | 17:06 |
| th1a | I'm not sure what's going on with that. | 17:06 |
| aelkner | we can leave that or mark it as invalid, your call | 17:06 |
| th1a | Or... we could ask another question. | 17:07 |
| aelkner | you have one in mind? | 17:07 |
| th1a | Did you happen to try deleting the other worksheets other than people? | 17:07 |
| th1a | You're going to be doing a lot of that very soon for this CanDo import stuff anyhow. | 17:08 |
| aelkner | no, i didn't figure that would make a difference, but i could try that right now | 17:08 |
| th1a | Try that to make sure. | 17:08 |
| aelkner | ok | 17:08 |
| th1a | Since the whole CanDo import thread is going to be about making sure importing one sheet at a time works. | 17:08 |
| aelkner | sure | 17:09 |
| aelkner | btw, we seem to have Persons and Contact Persons as sheets | 17:10 |
| th1a | Yes. | 17:11 |
| aelkner | they both have demos, and the export doesn't seem to add the custom demo column | 17:11 |
| th1a | I guess that could cause some confusion. | 17:11 |
| aelkner | yes | 17:11 |
| th1a | Well, contacts have the contact information. | 17:11 |
| th1a | That doesn't change. | 17:11 |
| aelkner | oops, sorry, i confused the phone/email stuff with the ID, ethnicity stuff | 17:12 |
| aelkner | not the same thing | 17:12 |
| aelkner | so that's a red herring | 17:12 |
| th1a | Except insofar as it might be the source of the users' problem. | 17:13 |
| aelkner | perhaps, yes | 17:14 |
| aelkner | i just tested getting rid of all the other sheets, still works fine | 17:14 |
| th1a | OK. I'll try to come up with a follow-up. | 17:15 |
| th1a | Had you started section locations? | 17:15 |
| aelkner | yeah, so i started back on that | 17:15 |
| aelkner | it would be nice to be able to push through that before working in something else | 17:16 |
| aelkner | yvl, can we meet tomorrow morning, standard meeting time? | 17:17 |
| yvl | umm, yes | 17:17 |
| th1a | About section locations? | 17:17 |
| aelkner | yeah, i'll have questions about the new ajax tables | 17:18 |
| aelkner | for now, i've been absorbing the new js files | 17:18 |
| aelkner | yvl, have you basically moved on from that stuff, or are there any loose ends? | 17:18 |
| * yvl done with that for now | 17:19 | |
| aelkner | cool | 17:19 |
| aelkner | anyway, that's it for me | 17:19 |
| th1a | Thanks aelkner. | 17:20 |
| th1a | yvl? | 17:20 |
| yvl | I'm doing the skill document model | 17:21 |
| yvl | it will take a while ;) | 17:21 |
| th1a | Do you need your memory jogged? | 17:21 |
| yvl | I'll be fine :) | 17:21 |
| yvl | really :) | 17:22 |
| yvl | well, that's it from me | 17:22 |
| th1a | OK. | 17:22 |
| replaceafill | yvl, can i ask you a question? | 17:23 |
| yvl | sure! | 17:23 |
| th1a | So I guess there's nothing in the pipeline for menesis to wait for. | 17:23 |
| replaceafill | in my sprint notes, for the cando flourishing task | 17:23 |
| replaceafill | oops, sorry, i can wait for menesis to finish | 17:23 |
| menesis | tests are failing. | 17:24 |
| menesis | http://schooltool.pov.lt/buildbot/waterfall | 17:24 |
| th1a | Lots of red. | 17:25 |
| menesis | th1a, aelkner: so you are done with intervention/email changes | 17:25 |
| replaceafill | i didnt undestand why the scriptlocal directive in flourish main.pt is being used in the old skin | 17:25 |
| th1a | There's one word to change. | 17:25 |
| yvl | my fault, replaceafill | 17:25 |
| aelkner | menesis, yes, i just need to make the one minor message text change right now | 17:26 |
| replaceafill | yvl, i mean, i dont understand why the old skin is trying to access main.pt | 17:26 |
| aelkner | merging now... | 17:26 |
| menesis | aelkner: good then | 17:26 |
| yvl | wait, main.pt? | 17:27 |
| replaceafill | i think so | 17:27 |
| replaceafill | or maybe i'm wrong | 17:27 |
| replaceafill | i tried to fix that one | 17:27 |
| replaceafill | but got confused by it | 17:28 |
| yvl | it's not in main.pt | 17:28 |
| yvl | probably filter | 17:28 |
| replaceafill | ah | 17:29 |
| replaceafill | so i was looking at the wrong scriptlocal :D | 17:29 |
| replaceafill | ah, it's probably a table container view | 17:30 |
| aelkner | menesis, merged | 17:30 |
| aelkner | you see i put a lot of text in CHANGES.txt to explain the many changes | 17:31 |
| replaceafill | yvl, is it worth to create new helpers to print the gradebooks, like printGradebookTable for flourish? | 17:32 |
| aelkner | sounds like a good idea | 17:32 |
| yvl | it's up to you | 17:32 |
| yvl | but it looks like time well spent ;) | 17:33 |
| replaceafill | yvl, i remember your explanation about not testing the html output with selenium | 17:33 |
| replaceafill | but the functionality | 17:33 |
| replaceafill | (or maybe i got that wrong) :) | 17:33 |
| replaceafill | and to me, printGradebookTable tests output | 17:33 |
| yvl | well, one thing is to test if a <div> contains a <p> with a space | 17:34 |
| yvl | and the <p> has class = "foo" | 17:34 |
| yvl | and id ="boo" | 17:34 |
| yvl | and it has a <a> | 17:34 |
| yvl | and so on and so forth | 17:34 |
| yvl | another thing is to extract grades visible in table | 17:34 |
| replaceafill | got it | 17:34 |
| replaceafill | i'll probably add those helpers then | 17:35 |
| yvl | thanks man | 17:35 |
| replaceafill | yvl continuing with my cando gradebook question | 17:35 |
| replaceafill | you told me that i could start writing the cando gradebook using the same model of the current gradebook, correct? | 17:36 |
| replaceafill | activity -> competency | 17:36 |
| replaceafill | even have options to add competencies at the beginning | 17:36 |
| replaceafill | in my notes: | 17:36 |
| replaceafill | "use the same gradebook model/options to create the new cando gradebook" | 17:36 |
| replaceafill | :) | 17:36 |
| yvl | yes | 17:37 |
| yvl | worksheet == project | 17:37 |
| replaceafill | does that mean that i should use the gradebook interfaces/models? | 17:37 |
| replaceafill | ah yes | 17:37 |
| yvl | or worksheet == tasklist | 17:37 |
| yvl | for now, yes | 17:37 |
| yvl | I would think... | 17:37 |
| replaceafill | because i can create new interfaces/models with better names maybe for cando | 17:37 |
| replaceafill | always using the same hierarchy | 17:38 |
| replaceafill | i think it would be faster if i used the existing gradebook stuff though | 17:38 |
| yvl | that code will likely be updated anyways | 17:40 |
| yvl | so I'd vote for fastest prototype | 17:40 |
| replaceafill | rigth | 17:40 |
| replaceafill | got it | 17:40 |
| th1a | +1 | 17:41 |
| replaceafill | ok, thanks yvl | 17:41 |
| th1a | menesis: Should we get all hands on deck for fixing tests? Say, starting Monday? | 17:41 |
| menesis | th1a: no | 17:42 |
| * yvl can fix some today | 17:42 | |
| yvl | (and I actually intend to ;) ) | 17:42 |
| menesis | there are only a few failures. one is expected (search corner cases not handled) | 17:42 |
| menesis | another with scriptlocal I don't know | 17:43 |
| menesis | and journal does not print the table because some css classes changed | 17:43 |
| yvl | I refactored and forgot the old skin. Will reintroduce old code without scriptlocal | 17:43 |
| th1a | OK. | 17:44 |
| th1a | Anything else menesis? | 17:46 |
| menesis | no | 17:46 |
| th1a | OK. Thanks guys. | 17:46 |
| th1a | I'll get the invoices out today. | 17:46 |
| th1a | Working on the competency completion report. | 17:47 |
| th1a | Have a great week and weekend! | 17:47 |
| * th1a drops the bag of gravel. | 17:47 | |
| replaceafill | thanks everybody | 17:49 |
| * replaceafill goes to get breakfast | 17:49 | |
| aelkner | great week everyone | 17:49 |
| yvl | good luck guys! | 17:50 |
| *** yvl has quit IRC | 18:24 | |
| *** yvl has joined #schooltool | 18:29 | |
| *** ignas has quit IRC | 18:41 | |
| *** menesis has quit IRC | 19:14 | |
| *** yvl has quit IRC | 19:54 | |
| *** menesis has joined #schooltool | 21:03 | |
| *** alga has joined #schooltool | 22:13 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!