| *** menesis has quit IRC | 01:11 | |
| *** aks has joined #schooltool | 05:11 | |
| *** aks has quit IRC | 06:57 | |
| *** aks has joined #schooltool | 06:57 | |
| *** yvl has joined #schooltool | 09:29 | |
| *** alga has joined #schooltool | 11:27 | |
| *** menesis has joined #schooltool | 11:31 | |
| *** alga has quit IRC | 13:05 | |
| *** aks has quit IRC | 14:23 | |
| *** th1a has joined #schooltool | 15:57 | |
| th1a | hi aelkner_, yvl, menesis. | 16:30 |
|---|---|---|
| yvl | good morning | 16:31 |
| aelkner_ | morning | 16:31 |
| th1a | It is invoice time, gentlemen. | 16:33 |
| th1a | Oh, for the sprint... | 16:33 |
| th1a | What did we say yvl? | 16:33 |
| th1a | 8 hour days Mon - Fri, | 16:33 |
| th1a | plus two half days the first weekend? | 16:34 |
| yvl | yes | 16:35 |
| yvl | IIRC | 16:35 |
| th1a | OK with that aelkner_? | 16:35 |
| aelkner_ | i have just the five days on my invoice | 16:36 |
| aelkner_ | the first two weekend days i counted as a finish up of the task that i was working on the previous week | 16:37 |
| th1a | OK. | 16:37 |
| th1a | So I had a frustrating week with D3, but replaceafill finally figured out that I wasn't always loading the page before I tried to run my Javascript on it. | 16:38 |
| th1a | (that is, that issues screwed up a couple days, not the whole week ;-) | 16:38 |
| aelkner_ | isn't that what $(document).ready(function() is for? | 16:39 |
| th1a | In jquery. | 16:39 |
| th1a | I suppose I might be able to use it... | 16:39 |
| th1a | But I can also just put the script at the bottom of the page. | 16:39 |
| th1a | For now at least. | 16:39 |
| aelkner_ | we can use jquery anytime we wnat because we include it on all pages | 16:39 |
| th1a | I suppose I could use it at the beginning of the D3 script... I'm not trying to learn jquery at the same time though. | 16:40 |
| th1a | But yes, I'll look into that. | 16:41 |
| aelkner_ | but yes, the old way was to include stuff at the end | 16:41 |
| th1a | OK, yvl, would you like to start us off? | 16:41 |
| yvl | ok | 16:41 |
| yvl | I was smoothing the rough edges of our Selenium test runner | 16:42 |
| yvl | I took the liberty to work on that today also | 16:42 |
| yvl | but that's it | 16:43 |
| th1a | Do you want to keep working on that through Wednesday? | 16:43 |
| yvl | well, I can take a pause | 16:43 |
| yvl | and do the CanDo data model | 16:44 |
| yvl | which reminds me | 16:44 |
| yvl | can you send me photos of the nice drawings on the wall? :) | 16:44 |
| * yvl kind of remembers, but it would be nice to have them | 16:44 | |
| th1a | Oh... | 16:45 |
| th1a | Yes, I guess we didn't actually take pictures there? | 16:45 |
| yvl | did you throw them out? | 16:45 |
| th1a | I brought some home... which ones are you thinking of? | 16:46 |
| yvl | this one and the other one :) | 16:47 |
| yvl | umm | 16:47 |
| th1a | I might have not brought the right ones. :-( | 16:47 |
| yvl | any would do | 16:47 |
| * yvl can work from memory btw | 16:47 | |
| th1a | I think I only have the task lists. | 16:48 |
| yvl | I think you didn't send us any pictures (because I remeber some photos being taken) | 16:48 |
| th1a | Which is not what you want, I don't think. | 16:48 |
| th1a | aelkner_? | 16:48 |
| th1a | Anything on your phone? | 16:48 |
| th1a | This is what yvl and I get for being phone luddites. | 16:49 |
| aelkner_ | nothing on my phone, sorry | 16:49 |
| th1a | I think you're out of luck yvl. | 16:50 |
| th1a | My bad. | 16:50 |
| yvl | ok | 16:51 |
| yvl | don't worry guys :) | 16:51 |
| *** alga has joined #schooltool | 16:52 | |
| th1a | OK, so starting on CanDo Thursday? | 16:52 |
| *** replaceafill has joined #schooltool | 16:54 | |
| yvl | I was thinking late Tuesday | 16:54 |
| th1a | OK. Cool. | 16:54 |
| replaceafill | testing... | 16:54 |
| th1a | And you'll want to come back to testing at some point? | 16:54 |
| aelkner_ | somebody overslept :) | 16:54 |
| yvl | Earth to replaceafill | 16:54 |
| yvl | Earth to replaceafill | 16:54 |
| yvl | can you hear us | 16:54 |
| replaceafill | good morning | 16:54 |
| yvl | morning! | 16:55 |
| replaceafill | sorry i'm late, i'm at the mall near home | 16:55 |
| yvl | yes, th1a | 16:55 |
| replaceafill | we have no electricity at home | 16:55 |
| * replaceafill goes read the logs | 16:55 | |
| aelkner_ | bummer replaceafill | 16:55 |
| th1a | Do you know the cause replaceafill? | 16:56 |
| * menesis hi | 16:56 | |
| replaceafill | yes, it's very windy since yesterday, and it seems like a post went down | 16:56 |
| th1a | Ah. | 16:56 |
| th1a | hi menesis. | 16:56 |
| th1a | Thanks yvl. | 16:57 |
| th1a | aelkner_? | 16:57 |
| aelkner_ | ok, i got the javascript to work for locking out sending email if no recipient with email was chosen | 16:57 |
| aelkner_ | and i created a modal for after the email was sent | 16:58 |
| aelkner_ | http://69.164.203.135:36660/schooltool.interventions/2011-2012/student109 | 16:58 |
| aelkner_ | as teacher001 | 16:58 |
| aelkner_ | i set up the email on my test instance to go to my gmail account | 16:58 |
| aelkner_ | actually, i should say, to come from that account | 16:59 |
| aelkner_ | is you'd like, you could change teacher001's email to your own email address | 16:59 |
| aelkner_ | so that you can see proof that the email got there | 16:59 |
| th1a | Lets fix that hint under email. | 16:59 |
| aelkner_ | what should it be instead? | 17:00 |
| th1a | "Send a copy of the message to recipients with contact email addresses?" | 17:00 |
| aelkner_ | is that a question? :) | 17:01 |
| th1a | The choices are "Yes" and "No." | 17:01 |
| aelkner_ | yeah, i shouldn't joke, one could in theory use questions for any boolean hint | 17:01 |
| aelkner_ | anyway, click around on the people and note that the email is disabled if no person has mail icon | 17:02 |
| th1a | Yes. | 17:02 |
| menesis | neither yes or no are selected by default | 17:02 |
| aelkner_ | is that wrong? | 17:03 |
| th1a | I would make it yes by default. | 17:03 |
| menesis | it is confusing | 17:03 |
| menesis | what happens if I do not select anything? | 17:03 |
| aelkner_ | we have that issue in other places in the app | 17:04 |
| th1a | ? | 17:04 |
| aelkner_ | in zope, if the value of a boolean is None, then neither button is selected | 17:04 |
| aelkner_ | look at demo fields | 17:04 |
| th1a | Shouldn't we just give it a default value? | 17:04 |
| *** replaceafill_ has joined #schooltool | 17:05 | |
| aelkner_ | th1a, if you'd like it to be Yes by default, i can do that | 17:05 |
| aelkner_ | btw, i should count the fact that the email server is disabled | 17:05 |
| aelkner_ | when i decide whether the Email field is enabled or not, right? | 17:06 |
| th1a | Yes. | 17:06 |
| aelkner_ | yeah, i'll do that | 17:06 |
| *** replaceafill has quit IRC | 17:07 | |
| aelkner_ | anyway, i made one of the parent's email an invalid address to test handling email errors | 17:07 |
| aelkner_ | replaceafill_is having connectivity problems (: | 17:07 |
| aelkner_ | i was hoping for his input on one question | 17:08 |
| aelkner_ | interestingly, if one recipient has valid email and the other invalid | 17:08 |
| aelkner_ | the server returns the queued email with invalid status code | 17:08 |
| aelkner_ | and a list of the invalid addresses are stored in the email | 17:08 |
| aelkner_ | which end up in the message | 17:08 |
| aelkner_ | the thing is, should i give a more informative message | 17:09 |
| th1a | Yes. | 17:09 |
| aelkner_ | showing that the email was sent to the people it got to | 17:09 |
| th1a | And explicitly noting that the email has not been sent. | 17:09 |
| aelkner_ | have you tried it out yet? | 17:10 |
| th1a | Yes. | 17:10 |
| aelkner_ | it already notes that it didn't send the email to the invalid address | 17:10 |
| aelkner_ | i'm using the status_messages dict from mail.py as yvl suggested | 17:11 |
| aelkner_ | any messages, that way, will match what the email manager gives | 17:11 |
| th1a | Well, it is telling me it couldn't log in to the SMTP server. | 17:11 |
| th1a | But not that the mail wasn't sent. | 17:11 |
| aelkner_ | i mean, i shouldn't be creating my own email error messages, right? | 17:12 |
| th1a | Alan, USERS. | 17:12 |
| th1a | The user shouldn't have to imply the significance of the error message. | 17:12 |
| aelkner_ | th1a, consistency | 17:12 |
| aelkner_ | shouldn't we change mail.py, and hence, the way the email tab works? | 17:13 |
| th1a | What the user must know from this message is that the email wasn't set. | 17:13 |
| th1a | Secondarily why. | 17:13 |
| th1a | wasn't sent. | 17:13 |
| aelkner_ | replaceafill_, what do you think about status_messsages, should it change? | 17:14 |
| th1a | There is no reason the first line of the dialog can't be "The message was not sent as an email to the following addresses: ..." | 17:14 |
| th1a | Reason: couldn't log in to smtp server. | 17:14 |
| replaceafill_ | aelkner_: change it as you need | 17:15 |
| aelkner_ | replaceafill_, ok, will do | 17:15 |
| replaceafill_ | aelkner_: just take into account i18n please | 17:15 |
| aelkner_ | one problem with status_messages is that there is no paragraph break | 17:15 |
| aelkner_ | implied in the content of the messages | 17:16 |
| aelkner_ | so having a multi-line message like what th1a suggests requires a plan | 17:16 |
| aelkner_ | should we imbed \n in status_messages when we want multi-line messages | 17:16 |
| aelkner_ | and then i would split('\n') and make separate paragraphs in my modal? | 17:17 |
| aelkner_ | i should ask, does anyone have anything invested in the way our email message work now | 17:18 |
| th1a | I wouldn't put line breaks in the status_messages. | 17:18 |
| aelkner_ | or should i just change then to do whatever i want | 17:18 |
| th1a | Why do you need them? | 17:18 |
| aelkner_ | the email utility does the job of sending email | 17:19 |
| aelkner_ | there are some seven possible exceptions that can happen | 17:19 |
| aelkner_ | and when that happens, the email gets queued with a status code | 17:19 |
| th1a | YEs... | 17:19 |
| aelkner_ | the status_messages dict is used to translate that code into a meaningful message | 17:20 |
| *** replaceafill has joined #schooltool | 17:20 | |
| th1a | Why do you need line breaks? | 17:20 |
| aelkner_ | you suggested a multi-line message | 17:20 |
| aelkner_ | the email was not send to the following addresses: one, two, three | 17:21 |
| aelkner_ | is one <p> | 17:21 |
| aelkner_ | Reason: the email addresses are invalid | 17:21 |
| aelkner_ | is another <p> | 17:21 |
| *** replaceafill_ has quit IRC | 17:21 | |
| *** alga has quit IRC | 17:22 | |
| aelkner_ | so, if that is in fact the message in that case, status_messages would need to have some \n | 17:22 |
| aelkner_ | or something to allow the client code to break up the message into multiple <p>s | 17:22 |
| th1a | Or you could compose the dialog text some other way. | 17:23 |
| th1a | It seems to me you're saying "The email was not sent..." has to be added to the status message, when it seems to me that it is a separate message anyhow. | 17:24 |
| *** alga has joined #schooltool | 17:24 | |
| th1a | At least, that's the way it seems to me. ;-) | 17:24 |
| aelkner_ | whatever we do for email delivery messages, it should be done in the view itself | 17:25 |
| aelkner_ | these things should be handled in the utility as it is now | 17:26 |
| aelkner_ | and right now, the utility doesn't have email messages that contain the fact that the email was not delivered | 17:26 |
| aelkner_ | jsut the reason | 17:26 |
| aelkner_ | and | 17:26 |
| aelkner_ | the messages are one-liners | 17:27 |
| aelkner_ | the point it: it should be handled by the utility | 17:27 |
| th1a | Well, I'd say we've beaten this into the ground, but I don't see why the utility needs to be the source of a more general prompt to the user like "This email was not sent." | 17:27 |
| yvl | followed by the message from utility | 17:28 |
| th1a | Right. | 17:28 |
| aelkner_ | if the email was sent to one user and not to the other | 17:28 |
| aelkner_ | "This email was not sent." | 17:28 |
| aelkner_ | that would not be correct | 17:28 |
| aelkner_ | and besides, the utility should handle creating the message | 17:29 |
| aelkner_ | yvl, i thought this was your idea? | 17:29 |
| aelkner_ | and a good one, in fact | 17:29 |
| aelkner_ | we don't need various views deciding how to give email error messages | 17:29 |
| th1a | The utility doesn't have to provide all text related to the event. | 17:29 |
| yvl | ??? | 17:29 |
| yvl | aelkner_, I really do not get what you're trying to say | 17:30 |
| aelkner_ | ok, what i'm saying is that we have this email utility | 17:30 |
| aelkner_ | it sends email and reacts to exceptions | 17:30 |
| *** replaceafill has quit IRC | 17:30 | |
| aelkner_ | translates those exceptions into message intended for the user | 17:30 |
| *** replaceafill has joined #schooltool | 17:31 | |
| aelkner_ | if those messages are wrong in the utility, then they should be fixed there | 17:31 |
| th1a | Does it just change the numeric code into text? | 17:31 |
| aelkner_ | not in a particular view that serves as a client of the utility | 17:31 |
| yvl | yes th1a | 17:31 |
| aelkner_ | more than that | 17:31 |
| yvl | and adds parameters | 17:31 |
| aelkner_ | it also uses the queued email message for info | 17:31 |
| aelkner_ | like which email addresses were invlid | 17:32 |
| yvl | yes | 17:32 |
| aelkner_ | the point is, that needs to be handled in the utility | 17:32 |
| yvl | why? | 17:33 |
| th1a | You're not going to want to use the exact same text for, say, a log viewed by an admin and an error message for a very non-technical user. | 17:33 |
| aelkner_ | we could add a method to mail.py that returns a list of message to be used in <p> elems | 17:33 |
| aelkner_ | th1a, ah, i see | 17:33 |
| aelkner_ | well, wait | 17:33 |
| aelkner_ | you did suggest putting a reason in the message | 17:34 |
| aelkner_ | what are you saying would go there? | 17:34 |
| yvl | aelkner_, maybe you could just copy the status_messages dict | 17:34 |
| yvl | and put whatever text th1a wants there? | 17:34 |
| yvl | btw | 17:34 |
| th1a | I would just divide the utility's output into a data structure and let the view arrange it as made sense. | 17:35 |
| yvl | keep in mind, that once the email sending becomes asynchronous | 17:35 |
| yvl | you will only get "sent" statuses | 17:35 |
| yvl | because it will fail way later | 17:35 |
| aelkner_ | really> | 17:35 |
| aelkner_ | ? | 17:35 |
| aelkner_ | so this is all going to change later? | 17:36 |
| yvl | unless we don't make it asynchronous | 17:36 |
| aelkner_ | hell, if that's the case, why don't i ignore the email status | 17:36 |
| aelkner_ | and just say that it was sent | 17:36 |
| th1a | lol | 17:36 |
| th1a | It is pretty much done already. | 17:36 |
| menesis | schooltool.email is not used by anything else, only intervention. | 17:37 |
| aelkner_ | for now | 17:37 |
| menesis | it it does somehting wrong, fix it | 17:37 |
| yvl | yes | 17:37 |
| yvl | *if* | 17:37 |
| th1a | All I was really asking for in the first place was a line explaining that the significance of the error is that the email is not sent. | 17:37 |
| yvl | :))) | 17:38 |
| th1a | Because that is not obvious. | 17:38 |
| aelkner_ | heck, i'll change the email utility to do whatever i want if noone cares about it changing | 17:38 |
| yvl | is it broken, aelkner_ ? | 17:38 |
| * th1a can't understand why a line can't be added directly to the dialog. | 17:38 | |
| yvl | well it can! | 17:39 |
| yvl | via magic of page templates | 17:39 |
| th1a | Just do it! | 17:39 |
| yvl | aelkner_, please just hard-code it | 17:39 |
| yvl | if email failed | 17:39 |
| yvl | <p i18n:translate="">The email could not be delivered to all people</p> | 17:39 |
| th1a | recipients. | 17:40 |
| aelkner_ | status_messages = { | 17:40 |
| aelkner_ | 10: _('The SchoolTool mail service is disabled'), | 17:40 |
| aelkner_ | 20: _("Couldn't connect to the SMTP server (${info})"), | 17:40 |
| aelkner_ | 30: _('Error sending HELO to the SMTP server (${info})'), | 17:40 |
| aelkner_ | 40: _("Couldn't login as ($username) to SMTP server (${info})"), | 17:40 |
| aelkner_ | 50: _('The server (${info}) rejected the From address: ${from_address}'), | 17:40 |
| aelkner_ | 60: _('The server (${info}) rejected the following recipient addresses: ' | 17:40 |
| aelkner_ | '${addresses}'), | 17:40 |
| aelkner_ | 70: _('The server (${info}) replied that the message data was malformed'), | 17:40 |
| aelkner_ | } | 17:40 |
| aelkner_ | should it not use this list of messages for status codes | 17:41 |
| yvl | but it can! | 17:41 |
| *** replaceafill has quit IRC | 17:41 | |
| th1a | aelkner_: We just need an additional explanation of what all of these status codes mean. | 17:41 |
| yvl | you can put *both* a generic paragraph | 17:41 |
| yvl | notifying of failure | 17:41 |
| yvl | and also the failure message next to it | 17:41 |
| aelkner_ | ok, one line for for notifying the failure | 17:42 |
| yvl | in a second paragraph | 17:42 |
| aelkner_ | he email could not be delivered to all | 17:42 |
| aelkner_ | and then the status_messages for the reason | 17:42 |
| yvl | right | 17:42 |
| aelkner_ | i could live with that | 17:42 |
| aelkner_ | so if person one got the email and person two didn't, we are covered by the 'not to all' part | 17:42 |
| yvl | right | 17:43 |
| aelkner_ | sounds like a plan | 17:44 |
| th1a | Thank God. | 17:44 |
| aelkner_ | thank sober discussion | 17:44 |
| th1a | OK, so... whatever you do with this, finish it by the end of the day tomorrow. | 17:44 |
| th1a | I wish I wasn't sober. | 17:45 |
| th1a | And then I guess section locations still need to be done? | 17:45 |
| aelkner_ | yes, that would be next | 17:46 |
| aelkner_ | this email thing was a distraction that interrupted that | 17:46 |
| th1a | OK. | 17:47 |
| th1a | Oh... I did just assign a bug to you at the end of the week about importing custom demographics. | 17:47 |
| th1a | Can you check to see if that works before moving on to section locations, aelkner_? | 17:47 |
| aelkner_ | yes | 17:47 |
| aelkner_ | ok | 17:47 |
| th1a | OK. Cool. | 17:48 |
| th1a | Thanks aelkner_. | 17:48 |
| th1a | menesis? | 17:48 |
| menesis | not much | 17:48 |
| menesis | added more options to start-schooltool-instance script | 17:49 |
| menesis | fixed some tests broken by recent merges | 17:49 |
| menesis | tried to package schooltool-book, but stumbled | 17:51 |
| menesis | cannot apply a patch on native package | 17:51 |
| th1a | ? | 17:51 |
| menesis | that is a branch that has debian/ directory in upstream branch | 17:52 |
| menesis | I needed to modify Makefile so that buildout is not used | 17:52 |
| menesis | will fix it some other way | 17:52 |
| th1a | OK. | 17:53 |
| menesis | also looked at zope2.12 build failure on ubuntu. | 17:53 |
| menesis | it is not my responsibility.. | 17:53 |
| th1a | That's what I was thinking. ;-) | 17:54 |
| menesis | but still I though I could make it build with python2.7 | 17:54 |
| menesis | or zope2.12 will be removed | 17:54 |
| menesis | not that we need it | 17:55 |
| menesis | ok | 17:55 |
| menesis | so you want a beta release this week | 17:55 |
| menesis | but I should expect some fixes land today/tomorrow | 17:56 |
| menesis | ? | 17:56 |
| th1a | Uh... there's this mail thing, maybe a critical spreadsheet bug. | 17:56 |
| menesis | custom demographics import? | 17:57 |
| th1a | Yes. | 17:57 |
| th1a | You can start now or after Wednesday, whichever makes sense to you. | 17:58 |
| th1a | Whatever else is going in will be smallish bugfixes. | 17:58 |
| menesis | ok | 17:59 |
| th1a | Use your discretion. | 17:59 |
| th1a | OK, no replaceafill now, so I guess we're done. | 18:00 |
| th1a | Send me your invoices. | 18:00 |
| th1a | I'll see you Wednesday. | 18:00 |
| th1a | Have a great week. | 18:00 |
| menesis | thanks | 18:00 |
| * th1a drops the bag of gravel. | 18:00 | |
| aelkner_ | cya guys wed | 18:01 |
| yvl | good luck guys! | 18:02 |
| *** replaceafill has joined #schooltool | 18:36 | |
| * replaceafill 's home has electricity again! | 18:36 | |
| replaceafill | i had a "you've got to be kidding me" moment at the mall | 18:36 |
| replaceafill | electricity went down(?) there too! | 18:37 |
| replaceafill | *went off | 18:39 |
| *** ignas has joined #schooltool | 18:59 | |
| aelkner_ | hey replaceafill | 19:01 |
| *** th1a has quit IRC | 19:09 | |
| *** aelkner_ has quit IRC | 19:17 | |
| *** aelkner has joined #schooltool | 19:23 | |
| *** aelkner has quit IRC | 19:28 | |
| *** aelkner has joined #schooltool | 19:31 | |
| yvl | replaceafill, you may find this interesting | 19:34 |
| yvl | http://bazaar.launchpad.net/~schooltool-owners/schooltool.lyceum.journal/flourish/revision/326 | 19:34 |
| * replaceafill goes to see | 19:34 | |
| yvl | browser UI extension: http://bazaar.launchpad.net/~schooltool-owners/schooltool/flourish/revision/3341#src/schooltool/basicperson/ftesting.py | 19:34 |
| yvl | web element level extension: http://bazaar.launchpad.net/~schooltool-owners/schooltool/flourish/revision/3341#src/schooltool/skin/flourish/ftesting.py | 19:35 |
| replaceafill | !!! | 19:35 |
| replaceafill | manager.ui.person.add!!! | 19:35 |
| yvl | bwahahahaha! | 19:35 |
| replaceafill | :)) | 19:35 |
| yvl | oh | 19:35 |
| yvl | and if you add in buildout.cfg a line at eggs= | 19:36 |
| yvl | ipdb | 19:36 |
| yvl | you'll get ipdb when running tests with -D | 19:36 |
| replaceafill | what's the advantange of ipdb? | 19:37 |
| * replaceafill has never used it | 19:37 | |
| yvl | assaults your senses with many colours | 19:37 |
| replaceafill | :D | 19:37 |
| yvl | and autocompletion mostly | 19:37 |
| yvl | it's like its based on IPython | 19:37 |
| replaceafill | ah | 19:38 |
| yvl | * it's | 19:38 |
| replaceafill | i like the way you "hide" browser.wait_no :) | 19:38 |
| replaceafill | inside type_ind_date | 19:38 |
| replaceafill | type_in_date | 19:38 |
| yvl | well | 19:39 |
| yvl | better than nothing :) | 19:39 |
| replaceafill | this means we're good to go with the schoolyear/term set up views, right? | 19:39 |
| yvl | works for me :P | 19:39 |
| replaceafill | i mean, the datepicker shouldn't be a problem anymore | 19:39 |
| yvl | correct | 19:39 |
| yvl | and please add helpers like ui.person.add | 19:40 |
| yvl | and ui.enter_date | 19:40 |
| yvl | as you go | 19:40 |
| replaceafill | ah ok | 19:40 |
| yvl | one thing... | 19:40 |
| yvl | you may notice the name "person.add" | 19:41 |
| yvl | it splits the line by '.' | 19:41 |
| yvl | and then builds the objects | 19:41 |
| yvl | so you get browser.ui.person.add | 19:41 |
| yvl | but it | 19:41 |
| yvl | it's probably obvious | 19:41 |
| replaceafill | can you point me to the line about the splitting? | 19:42 |
| replaceafill | i don't see it | 19:42 |
| yvl | registerExtension | 19:42 |
| yvl | in testing/selenium.py | 19:42 |
| replaceafill | ah got it | 19:43 |
| replaceafill | lol | 19:43 |
| replaceafill | black magic | 19:43 |
| replaceafill | :D | 19:43 |
| yvl | In modern times, some find that the definition of "black magic" has been convoluted by people who define practices that they disapprove of as "black magic" | 19:44 |
| yvl | thus spoketh Wikipedia | 19:44 |
| replaceafill | :O | 19:45 |
| *** th1a has joined #schooltool | 19:45 | |
| th1a | Hi replaceafill. | 19:45 |
| replaceafill | yvl, so the helpers need to be registered inside the test setup | 19:46 |
| replaceafill | correct? | 19:46 |
| replaceafill | hi th1a | 19:46 |
| replaceafill | sorry i got disconnected also at the mall | 19:46 |
| th1a | np | 19:46 |
| yvl | well, I'd like them registered in registry | 19:46 |
| th1a | Sorry I had to take advantage of the good weather here and having the car to go skate. | 19:46 |
| yvl | say, registerSeleniumSetup is called when basicperson/ftesting.py is imported | 19:46 |
| *** ignas has quit IRC | 19:47 | |
| yvl | and it is imported in basicperson/__init__.py | 19:47 |
| replaceafill | yvl, ah got it | 19:47 |
| replaceafill | should we add the same helpers we used to have: to add school years, terms, courses, sections? | 19:47 |
| yvl | ok... happy testing! ;) | 19:47 |
| yvl | if by we you mean you | 19:48 |
| yvl | then be my guest :P | 19:48 |
| yvl | sorry | 19:48 |
| replaceafill | np | 19:48 |
| yvl | yes, we should | 19:48 |
| replaceafill | thanks yvl | 19:48 |
| replaceafill | no i have to think of a test to write :D | 19:48 |
| yvl | but yes, helpers would be greatly appreciated | 19:48 |
| yvl | see you soon ;) | 19:48 |
| *** yvl has quit IRC | 19:48 | |
| * replaceafill goes to set up his selenium test runner | 19:49 | |
| replaceafill | th1a, i like vinny's idea about putting the url at the bottom of the pdf :) | 19:50 |
| replaceafill | see online at: ... | 19:50 |
| th1a | On the report card? | 19:50 |
| replaceafill | yes | 19:50 |
| replaceafill | it's maybe not possible, but i like it | 19:51 |
| th1a | Well, aside from the fact that parents can't. | 19:51 |
| replaceafill | right | 19:51 |
| replaceafill | maybe it's just me, but selenium exceptions are definitely more understandable now | 20:27 |
| replaceafill | WebDriverException: Message: u'Element is not clickable at point (255.5, 430). Other element would receive the click: ... | 20:28 |
| th1a | replaceafill: Could I mix in that jquery ready() thing with my D3 script? | 21:05 |
| replaceafill | th1a, i think so | 21:05 |
| th1a | OK. I'll note that for the future. | 21:05 |
| replaceafill | you could also use window.onload i think | 21:06 |
| replaceafill | if you dont want to use jquery | 21:06 |
| th1a | Probably I'll make you figure it out eventually. ;-) | 21:06 |
| replaceafill | oops sorry | 21:06 |
| replaceafill | body.onload | 21:06 |
| replaceafill | :) | 21:06 |
| th1a | Part of the inevitable cleanup. | 21:07 |
| replaceafill | http://stackoverflow.com/questions/3698200/window-onload-vs-document-ready | 21:07 |
| replaceafill | iirc ready is faster | 21:08 |
| replaceafill | but they both make sure you have the dom loaded | 21:08 |
| replaceafill | which is what you need | 21:08 |
| th1a | replaceafill: Btw, the reason my scripts worked sometimes is because often the page was drawn before the json could be parsed, depending on the sequence in the script. | 21:16 |
| replaceafill | ah | 21:16 |
| * replaceafill goes to get lunch | 21:29 | |
| * replaceafill back | 22:13 | |
| *** alga has quit IRC | 22:18 | |
| th1a | replaceafill: What's up with this message in my console -- Resource interpreted as Font but transferred with MIME type font/woff: "http://themes.googleusercontent.com/static/fonts/ubuntu/v4/0ihfXUL2emPh0ROJezvraD8E0i7KZn-EPnyo3HZu7kw.woff" | 23:01 |
| replaceafill | th1a, we still use the fontapi from google in flourish | 23:03 |
| replaceafill | <link rel="stylesheet" type="text/css" href="http://fonts.googleapis.com/css?family=Ubuntu:regular,bold&subset=Latin" /> | 23:04 |
| th1a | Yes... Have you seen that message before? I assume it is harmless. | 23:04 |
| replaceafill | i think i have | 23:04 |
| replaceafill | but i dont remember when exactly | 23:04 |
| th1a | I'll google it... | 23:04 |
| th1a | Eh, just something Google should fix. | 23:05 |
| *** alga has joined #schooltool | 23:45 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!